From nobody Thu Dec 18 01:37:13 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02A161F03DE for ; Tue, 17 Dec 2024 12:55:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734440153; cv=none; b=P3cggG07Ln0RVE0HEcsriZzUYl82muP6Y7on6m5YVznG4MhYWjqzvmiT+wZLSliY7Stt8VHSyUYfNnjSsoI+Cg1eRrmvX5fuWNrVNRESXEq18r0iQ0iscMcCY774FkRsEbH+6FNRliUUL/Noa7FNBNaqtY1U+xz282HgeNzNNj0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734440153; c=relaxed/simple; bh=3CKnHNjH+jwH5zwLJfrFBP0tmerBCMeB7tmsQ+JP9YU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=OB0OBoyIwDA9QmrCm1LguOC2CKhd/eRLNLhuqeevVZWqv6sWlX0KeIfmaDRS5e1XP2riK5RwV0Dz3wXZXmEg1LKYYLqmRXIxwPjNMia99EUzjiGR2j4aCLpCDjEOzDCK9lulPn5UuKeHOaETdD9qQCcrrmWTDHMj6FlMRqOjgUk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l6qmMKjy; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l6qmMKjy" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5d7e527becaso493868a12.3 for ; Tue, 17 Dec 2024 04:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734440149; x=1735044949; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=FgZd//oGB3D0/SHnIuOr6EaXxeoNU4PXKsD5sDU9eng=; b=l6qmMKjy1Nx8j7FS8+4zg11AiQbKj2jRauVENOYlwqirRSQMW+sN1POdS0zhK6Z/V3 vSEAJinymgUp6lhUlqIBJJrywzVN7E8rv9E5J03tm79YiWwZjr05gxLZFym5r/idZAUZ IOoXgFJ9LUTYHk/IKB1B0k2LV13rYIe08cAX80TQcGtvcamTtFHGRK1v2ByTnzxIj4KN K1Ac84fRs5iZyF8DaobsmLybtfCNs5lUYyymTlsb4oSiH1Lnswope2rf8zGpBsEsxX/A z0F5KdctahZC39RnFq9TtX4+fAv/eEhklWR8UQnzPKoP6mme+Y+fCTr5LqdWLvbAkBgk tbfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734440149; x=1735044949; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=FgZd//oGB3D0/SHnIuOr6EaXxeoNU4PXKsD5sDU9eng=; b=I5ysxe0guERsW7EW7P0qz4cU3Lfr26CdvZ4ddG8d7Ai/QSqfanAdYHqBjVNRqW8En4 2TNxgPNQLy4E7dOpqBL7wfa8dsDm4OmiAiH3b0xPte4if7M6cqp6buDh4K4/Xb0iqC50 pa6x+0r4DTVRz8f/V67L6etyY5IWyI+8QEX0szjqIeCFFG2BlSEs91feDnjS73fs+QYc FDHnmjUzb4uuOMXpDTt3e7BDu+xiLGao/EOswMiAU+XP+Qkfglw7yu84nyh5lET2wQom mu9C4B21LOw+q0NEntQ2lcnItxhm3SJgXQ+iuvR7G9Rr2mZIqMMN/ubHRe5/APWXGCYi xpDQ== X-Forwarded-Encrypted: i=1; AJvYcCWYR7y/dNyx3WLJtxAX/iMs8+KAjT23xRYUb5WmAKSkNO47iNTbE1pnK4WAhr4kKol9IZx/2Rc64jXvc8I=@vger.kernel.org X-Gm-Message-State: AOJu0YzpLrn/E81Qu+7likBcOfEr6gNNbefsT8H9RRhcimxJ5HBHWL/c ac7+8PIqDkmYnM7sk2gli1iC/VMw2N067HeNRzo7D++ENTgapvVKn8B2HO2ZzXE= X-Gm-Gg: ASbGncvQtCgD1EPWe+DQ8NMonNMMIRgnbcbV2z64iOwx4/dOIa2167BM/q2wNzQpPmR 9DPuBe5euGBU1Ia2xV2RkhU55q9kYQQPZ4OEeTEFYWmcKqTZw/y2LyMPr93kI92h5rTY32UzzUh BKhNMzc73pHC5gcG+RZG5a5QTKNbkr9raz2t3jLUfNBrIAbIbGxkffIy9VqA9Nk9b4sGxJ8LPrk Bc6Jktrw6Qt1cF3dyhkb+gsR53PtLWPPaAk7zMY8oG+fYzSddtbd9seJzoSgBPxDcI= X-Google-Smtp-Source: AGHT+IHy3wTLEBYa02eLhJwDwxGpeyqkNg2ZTkwe4hozyHj/eJSkGWPwUopusDKgYBQ/2qDVMAUv3w== X-Received: by 2002:a05:6402:4499:b0:5d4:55e:f99e with SMTP id 4fb4d7f45d1cf-5d63c3405bfmr43091113a12.18.1734440149347; Tue, 17 Dec 2024 04:55:49 -0800 (PST) Received: from [192.168.1.140] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab963892c1sm439921366b.133.2024.12.17.04.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:55:49 -0800 (PST) From: Linus Walleij Date: Tue, 17 Dec 2024 13:55:48 +0100 Subject: [PATCH] wifi: cw1200: Fix potential NULL dereference Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241217-cw1200-fix-v1-1-911e6b5823ec@linaro.org> X-B4-Tracking: v=1; b=H4sIANN0YWcC/x2MQQqAIBAAvyJ7TnCX0Ogr0UF0rb1YKFQQ/j3pO AMzL1QuwhVm9ULhS6ocuQMOCsLu88ZaYmcgQyMSOh1uJGN0kkdH6x1RQrZTgh6chbv+Z8va2gd EkCRMXAAAAA== X-Change-ID: 20241217-cw1200-fix-d6a722f1e68f To: Kalle Valo Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Dan Carpenter , Linus Walleij X-Mailer: b4 0.14.2 A recent refactoring was identified by static analysis to cause another potential NULL dereference, fix this! Reported-by: kernel test robot Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202411271742.Xa7CNVh1-lkp@intel.com/ Fixes: 2719a9e7156c ("wifi: cw1200: Convert to GPIO descriptors") Signed-off-by: Linus Walleij --- drivers/net/wireless/st/cw1200/cw1200_spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/st/cw1200/cw1200_spi.c b/drivers/net/wire= less/st/cw1200/cw1200_spi.c index 862964a8cc8761bb412b15addef562d61811440b..52386dfb5f4aa9c1f3e12e2a400= 2241d9ece72ee 100644 --- a/drivers/net/wireless/st/cw1200/cw1200_spi.c +++ b/drivers/net/wireless/st/cw1200/cw1200_spi.c @@ -442,8 +442,8 @@ static void cw1200_spi_disconnect(struct spi_device *fu= nc) cw1200_core_release(self->core); self->core =3D NULL; } + cw1200_spi_off(self, dev_get_platdata(&func->dev)); } - cw1200_spi_off(self, dev_get_platdata(&func->dev)); } =20 static int __maybe_unused cw1200_spi_suspend(struct device *dev) --- base-commit: 40384c840ea1944d7c5a392e8975ed088ecf0b37 change-id: 20241217-cw1200-fix-d6a722f1e68f Best regards, --=20 Linus Walleij