From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DB72D1CF7A1 for ; Mon, 16 Dec 2024 20:13:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379997; cv=none; b=MhoJA4bhra4t1yMm8BBSL74mVCwL3xjycV//Xbyly47hL0Q9CLwFcUEV5Isa9QafYwXk2t7/FKyCEmdCWRt7DO4Dk7yQ9ZyN+vlnaYn8lnLvJ9IDGPVqWiqsooCOHTHYJsiVG4wDuoI5FsdIIUvFeKQ94CbSjugNRQ3nE9OXkSA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379997; c=relaxed/simple; bh=sBbcW+mFe9y8oA+JwKVNSCOVQeN+nDtYYa9zn14EvWU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EtxALwPQaZrAWBn0MoZo6r1noVR4gk240JTYRgOvGWH+UOCvV+0AqIbpro176lhIJMUkp/0I5cnL7CyXS9Jz2zWO+r9XN8p+rTT3SjvNauEccGddjZk6IqPnBLdjV8l0youjbcBETJy6L+UdbNQJzSMzsI4+u5JsvOoAA4hTgRs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=UX1LNf8e; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UX1LNf8e" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-436341f575fso32202845e9.1 for ; Mon, 16 Dec 2024 12:13:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379993; x=1734984793; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UAD9QQaJMjOoF8GYY259h6abZLmkhVQBDuUpRGuLzv4=; b=UX1LNf8eP2kPtb4TQ0sWPhR7w3bUqt4ThglInQTVwxcDktG2PQ5bTZYctNMaSZatLN jcv2aemSOYSP/1FfCUsCvF8evb7z4WAKfgADxduthw/iP5rbqJ16h6G5z8bAdledFfEK KlWZUeeiTN8beWBCo3jOiBINwDywOAjMU8fzO7u7InY0CkQFBmpr2ZzLq3QbF9Jr2FAT OZCod5/2JJLOaUuMUGSY8wxmzXlxuNwD2j9jyOJx3pejEXBKEKE3R3+77xXBIxQcBUuv LA6aG5CJYmaABrviSnmXwIEsGbKxSYGrG3TYnJ61SbbvUl5Fb2dQIqiLoJ5mgCpKk2t2 NGAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379993; x=1734984793; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UAD9QQaJMjOoF8GYY259h6abZLmkhVQBDuUpRGuLzv4=; b=ewnt/1jzzIXLs0ueeEA1N5aYCKwt88fmp2YUG1tRZc5BlWQDf2PlIYLyA9gCNDW84U UVZ2ygTavA6fQej1KA3YhT7dFoWna89EDN5gmyIOuUUFawrX/mGJdD81ZZ5HEvcWy+mp qKy4qSAQwNsolhN3YzZHHd6K4HAbcAg/UAV+f2JmrahUoSYjPeOAAk4/UNvEIQokhyje NcoH9pYIg4oQC+Ud7LYZ3rkbcYPwcA+r6FuUxwkjYw2583q4J/DJoHvxFVT5nUFDpwec CW4pQblARCUJLx2c97tzpf1Xelb11xhP3QHiQ4otKZTLIs5huZ2NslAkm38HncUk82H4 eOWQ== X-Forwarded-Encrypted: i=1; AJvYcCV33O+KSxlXKh5ITgxZ7Inri/6PaA1JXWE3rqQvRuHIl7RUNKxKO4Lntgb8cLX9kofd3DtWKTNslzDyvcU=@vger.kernel.org X-Gm-Message-State: AOJu0YyYcqwGJqiqBItunHj1jcoxyQhHoRAfNic/f/tLinFbMmL5Wsu1 CFIwLhSBtNrLrZKMgJMAgeVx5mB0Gm2a6HULS30c31rviLsQ/BE/g8ZClAW6ics= X-Gm-Gg: ASbGnctDVpvA/uu6qt4H0ZS6vCphNiQhPh+zISQjRb0Z5rIqI4VP6nmQZNpFKpn+DgQ 0EZLTMRy2shliRFfgFUE9/xhWZN20mMr6dROC3A5pbGTicJHbZHHgDfgUG1MJ5mpzaoS+vGlpXe /DuD3BhNCeOfIsgb7CELZi8b4n9NJpygIuZ8ypL9fZZFnF06ZXmP4ZaDkZNe8IGkHEkYuFs4BDx tYmvk+85akuHOP6e7e1FOvgHUSdQCmBwl94KdaNplrSFRHZKMOAgo6sUg== X-Google-Smtp-Source: AGHT+IFMZaawvgQ0mmiXQ+XIost4nkLrH59oXQYTws/XE+0Hed0N6s2bXCIdJJdDop0UM3Vco0N0aw== X-Received: by 2002:a05:600c:468b:b0:434:a706:c0fb with SMTP id 5b1f17b1804b1-4362aa369ffmr164608895e9.10.1734379993276; Mon, 16 Dec 2024 12:13:13 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:13 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 1/9] sched: Convert CONFIG_RT_GROUP_SCHED macros to code conditions Date: Mon, 16 Dec 2024 21:12:57 +0100 Message-ID: <20241216201305.19761-2-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Convert the blocks guarded by macros to regular code so that the RT group code gets more compile validation. Reasoning is in Documentation/process/coding-style.rst 21) Conditional Compilation. With that, no functional change is expected. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 10 ++++------ kernel/sched/syscalls.c | 2 +- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index bd66a46b06aca..6ea46c7219634 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1068,13 +1068,12 @@ inc_rt_prio_smp(struct rt_rq *rt_rq, int prio, int = prev_prio) { struct rq *rq =3D rq_of_rt_rq(rt_rq); =20 -#ifdef CONFIG_RT_GROUP_SCHED /* * Change rq's cpupri only if rt_rq is the top queue. */ - if (&rq->rt !=3D rt_rq) + if (IS_ENABLED(CONFIG_RT_GROUP_SCHED) && &rq->rt !=3D rt_rq) return; -#endif + if (rq->online && prio < prev_prio) cpupri_set(&rq->rd->cpupri, rq->cpu, prio); } @@ -1084,13 +1083,12 @@ dec_rt_prio_smp(struct rt_rq *rt_rq, int prio, int = prev_prio) { struct rq *rq =3D rq_of_rt_rq(rt_rq); =20 -#ifdef CONFIG_RT_GROUP_SCHED /* * Change rq's cpupri only if rt_rq is the top queue. */ - if (&rq->rt !=3D rt_rq) + if (IS_ENABLED(CONFIG_RT_GROUP_SCHED) && &rq->rt !=3D rt_rq) return; -#endif + if (rq->online && rt_rq->highest_prio.curr !=3D prev_prio) cpupri_set(&rq->rd->cpupri, rq->cpu, rt_rq->highest_prio.curr); } diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c index ff0e5ab4e37cb..77d0d4a2b68da 100644 --- a/kernel/sched/syscalls.c +++ b/kernel/sched/syscalls.c @@ -650,7 +650,7 @@ int __sched_setscheduler(struct task_struct *p, retval =3D -EPERM; goto unlock; } -#endif +#endif /* CONFIG_RT_GROUP_SCHED */ #ifdef CONFIG_SMP if (dl_bandwidth_enabled() && dl_policy(policy) && !(attr->sched_flags & SCHED_FLAG_SUGOV)) { --=20 2.47.1 From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B216A1CDFDE for ; Mon, 16 Dec 2024 20:13:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379997; cv=none; b=qOccw1elBH34iUJ8WqXHj4o76xCwSHkO/x+nWMOgut2DxvOmWYagaiypDmELWEdS8kReQ0pEBt2qvD5/eSWJ7eLmfCAVTcQbQZRJByL30EUPdgZGhulahjKNWdLN037pnUb0InAUb5+OM1Z4boUkLZOm96MfRBs0wkhZJfkXWqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379997; c=relaxed/simple; bh=MemPLMXdk3uWnJs6gP0DQZ23rUlRf5oFXli2ZPMpwBE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N9mBomOhg52hDy0VI3s6q1G3/itppz5iZy5rR8M68Fk/THFMjYnctsaZM99iROtBghIVd+nDUAm+NeT85PLUTnE1M46GF4G/zIW9UferonooJnemtimdxBYOSPV30j2Fnb3/VNCSHwirpDJBeonMfkjCOWfeT5PBJ1Ir66Ycus8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=MFGdYbBB; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="MFGdYbBB" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-385e87b25f0so3661876f8f.0 for ; Mon, 16 Dec 2024 12:13:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379994; x=1734984794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ykUk1nCLfLYbgO6G1uURbaiHMeIrcr+xR9t27WM8uH0=; b=MFGdYbBBrxlathNLnbnI3sDz4DiLXLnavDBvvwYiL5NXgLpIUbRtPqJj2xcrdCSAzY 4eA9PxlEO8lEC9Hy4K9/XdI+acNos5dbVzyxnUi80guhC6/Qv/s3iuszMrUCRnmYiMoO vHhrswPCeflHTzH5NW2CDF9HgQeRwVR+qn/v9gIH4KeW3btv4zd02n07xKpO1l24jL10 TqcOGcoqGcXiI5Oo8EYoWkCIa0efcELv/C3a2YBvCaOhk2KGTMMJAmI+nwF19R7/rqtO j+QeEuvy7Vua0p2j0uZCAAdFByOhPYKHb/WuqHBSUgUGv0OnQTvnMNPKFS5SKsU+s0aL RPLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379994; x=1734984794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ykUk1nCLfLYbgO6G1uURbaiHMeIrcr+xR9t27WM8uH0=; b=AeqOsRJ34q82G4DJ/6AjIy9WWuEq4tqs1RJrouSZkoFX4777Rn5N0cRCcGfbm7747m GBz16apb4hOUAlQo2MXllWcXg/AeNI/b/go+e3cPRBND5yzwcaqbDh7ib/7AxqqgW5m4 8E7xhh7+m4lCexq3Tl2o5qf1vNMkZMHWElA1CP436xkwkvPCD8vGt0s7LpdXUu9CKPd2 k6Jsz54aluty1ZCPN8y7vcN7YKd041OUOZdaJuFwfodh9twFx+q8Nz6DFViVUrMBR4oJ Qw2gphiOEjBI9zsVKoNqzXIXPyUDLdBQZBKFVrubz67mcQzsvf8YFIILDyfaVVjH2MFO Rj5w== X-Forwarded-Encrypted: i=1; AJvYcCWBUiPbqH3RZuvpRPNClp4F8jQ8jQssdzS9LC2NjblE4q+jDcj4dHVK3kwKFhETYaJ5qSRNgZgl1VC3QEs=@vger.kernel.org X-Gm-Message-State: AOJu0YwdcEfDz+oc/5/IFpxC4LGLPIO7SFG0KuCxelHV7yAdoh8EgTl1 uC2E7tHzlfJodcSfG22xojVeW0YVRjJ2w2CCoo57ZaB4wyaEExWMlPC2JuIaCVY= X-Gm-Gg: ASbGnct7z0WjPduWRZ/+U0gbPso9az0J9gn3AQ23Yz7FyildZ6boQqgMNUUYbT2Na6Y QF/EV8WtLNcW6Kg1FdCYHAs7KeLtBAfy5xyt0f6MDUEYSN/Jmq6E/gso7lvLzk/Pr8/2PT4ifhJ hj0b5CXZ1+o0HnuuSzaJSb1RPzWU59j6zrWEYau0FzG8YN6LIJe6NFtEBM8RhEXD0MTyWhFxCFy kzcaymiP2fDCeR14eY5BYdPBCXCbxfb2iYQD+oKCq91QvmP4eaE1+gaYQ== X-Google-Smtp-Source: AGHT+IEkYdyHI1WGeTQVT3vTd9OrSkaJ/xGHM0dboeckZ2SBEOCxX/VzsSBkp7vOrSwHHiSIivFM1w== X-Received: by 2002:a5d:584a:0:b0:385:f892:c8be with SMTP id ffacd0b85a97d-388db27533bmr583056f8f.23.1734379994063; Mon, 16 Dec 2024 12:13:14 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:13 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 2/9] sched: Remove unneeed macro wrap Date: Mon, 16 Dec 2024 21:12:58 +0100 Message-ID: <20241216201305.19761-3-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable rt_entity_is_task has split definitions based on CONFIG_RT_GROUP_SCHED, therefore we can use it always. No functional change intended. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 6ea46c7219634..1940301c40f7d 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -1257,11 +1257,9 @@ static void __delist_rt_entity(struct sched_rt_entit= y *rt_se, struct rt_prio_arr static inline struct sched_statistics * __schedstats_from_rt_se(struct sched_rt_entity *rt_se) { -#ifdef CONFIG_RT_GROUP_SCHED /* schedstats is not supported for rt group. */ if (!rt_entity_is_task(rt_se)) return NULL; -#endif =20 return &rt_task_of(rt_se)->stats; } --=20 2.47.1 From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81B821D1730 for ; Mon, 16 Dec 2024 20:13:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379998; cv=none; b=uqy4/BSxX0YrF2HTPmHjkBcvsSVhnjC+D0Rsu0hI6r7eFnfuyowZkhTWKvTHqeng06Pn2lskvk6In0rPRRDwdbSUotYp8DuoH5RUllGxHp2A9CrXLMq/6Scer1tgUAYCntaS+KGkBSJx2/6kCbItPZ9G9RmL2N5/F3xvVBzfEDU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379998; c=relaxed/simple; bh=RYk23+XCY5BrG85isbX7d7sB012sPIA2IgncWgxuiqg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dPWI3aGFPTPm9MKJ4qg27V0jpyRoHMLBAssaZ0iff7ns/tPb7QLCEv8YISR6qY80EdBu+mIQoNniLr5mVVPMwpolwgKdBxR/HDPWI5qEW9G61UoRYEswZZnBa08ZsJMQzWvVJgT941eMoM8akDRWbEq2PwYdq2c4Wo+pARJpYbU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=GFS9j/hU; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="GFS9j/hU" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4362bae4d7dso24238215e9.1 for ; Mon, 16 Dec 2024 12:13:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379995; x=1734984795; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BWohpvsaidJAImWnCCb6nIgTAJEp6TGh7j1uXezpKLk=; b=GFS9j/hUxZi7Nts6eGzuXbKr+jHXI/SNhfH5FkHHdePGaYX0hcwH5QGIlcAK7jNe7b I0chkwGBOiqx/JKMEEUIP5oNweEhKPXF1K0JceG8GcS5wj1PIDHUKTRaYZf7VSZMs523 LQRJcs8aCSjR7MK0Nau2gnzqc6AEZMT2StQrXWaTOymXQf43RfZB/jTF0ywQkJASRLx7 tOuAEHkrziM8JqN7cC/r9fJAdxZ1K4HP9bV5MuTQJV1Q1fWxfdseOSbG+ybaiGIqXfAu 5tJSPTTXhF8JW2tKGfQ08nPpgLy+DeUc+/7C+suQF6LnCi30fWKVWv6BTRYPFZxjeshG qt3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379995; x=1734984795; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BWohpvsaidJAImWnCCb6nIgTAJEp6TGh7j1uXezpKLk=; b=wQ+/qrtRQfGr4ykWaL1NaVI0BbIjCoz5XEkHs6XEPm3nwSalgtqOl/DCHrHjLz4t2H k49miuVDIAYZk6HpiAE7JkpgEkie2h5KAOdGKH+bm1PU+FvMu4VZXP3mXqH5zLMeJJdr m/XQGVsdeuzJvbr0wEPk2+MFajVBEc67m57VBv+cUIuh1EUCsnFHZ6FBeChg+WWQDpSh qdikdyXsijeHXBzlRAdzPjzlmq3V3tDVU2myF1eifJ1nnkjixAodl3oo9X08OlG4zF9P BH/gFLClVGfDZSEgMWongG5A+RzEgZMIRAUMhha9xGJIEWNzDVRCRn7nB7L6FwwFyBui idqw== X-Forwarded-Encrypted: i=1; AJvYcCVXMw+4MndmjLz9sdVJs+lkxfI8n3RmHK9ATHCtCR0aAtEHFPUOvT4dYWolm/ySfFiGPVE+mv4spxpcYTU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3RLLl4i4+uECjHsrkIbsKqGs5CDe2EZwynpa5bSh1Plb0b7ki rjM/Jpin447QwyWbtF9OsE1Y73fGZIlhe03rH92Z5w+oI+uxu3EHYyLGqcad/FA= X-Gm-Gg: ASbGnctIOUY/m1I44CzPSk7touPCPq016A2uSTovyk4AcSu7j3vHFgacDUhyMvOm1RK UMKfDJsrpos7XbyMyeLOyA+99ufsQczM0cLWn8Z2uD2Mh7QIt2OsZVi8vM4ghF5UxJUThxVJsel b/YiNZYRro89aRyxGQfHwe8FaJ+0iVHWVHHJxPyfjoWpEQZVnUWsYCuEk4oPGczI8Pbef/exlL1 H9zIes8CLdA5vLqtiMuD4XeJ7PTKpb2srhkaNTE5NKQyj7pU4GVwU+5dQ== X-Google-Smtp-Source: AGHT+IHJNXDQlYkb8clBBC3f+NAsF9zFsTHuTzAExcEQsQ+x/QllJKlwA0cXeJSh82Dvjt73cqZ58g== X-Received: by 2002:a05:600c:1c1c:b0:434:f953:eed with SMTP id 5b1f17b1804b1-4362aab0ec4mr135894205e9.30.1734379994894; Mon, 16 Dec 2024 12:13:14 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:14 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 3/9] sched: Always initialize rt_rq's task_group Date: Mon, 16 Dec 2024 21:12:59 +0100 Message-ID: <20241216201305.19761-4-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable rt_rq->tg may be NULL which denotes the root task_group. Store the pointer to root_task_group directly so that callers may use rt_rq->tg homogenously. root_task_group exists always with CONFIG_CGROUPS_SCHED, CONFIG_RT_GROUP_SCHED depends on that. This changes root level rt_rq's default limit from infinity to the value of (originally) global RT throttling. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 7 ++----- kernel/sched/sched.h | 2 ++ 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 1940301c40f7d..41fed8865cb09 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -89,6 +89,7 @@ void init_rt_rq(struct rt_rq *rt_rq) rt_rq->rt_throttled =3D 0; rt_rq->rt_runtime =3D 0; raw_spin_lock_init(&rt_rq->rt_runtime_lock); + rt_rq->tg =3D &root_task_group; #endif } =20 @@ -484,9 +485,6 @@ static inline bool rt_task_fits_capacity(struct task_st= ruct *p, int cpu) =20 static inline u64 sched_rt_runtime(struct rt_rq *rt_rq) { - if (!rt_rq->tg) - return RUNTIME_INF; - return rt_rq->rt_runtime; } =20 @@ -1156,8 +1154,7 @@ inc_rt_group(struct sched_rt_entity *rt_se, struct rt= _rq *rt_rq) if (rt_se_boosted(rt_se)) rt_rq->rt_nr_boosted++; =20 - if (rt_rq->tg) - start_rt_bandwidth(&rt_rq->tg->rt_bandwidth); + start_rt_bandwidth(&rt_rq->tg->rt_bandwidth); } =20 static void diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 76f5f53a645fc..38325bd32a0e0 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -820,6 +820,8 @@ struct rt_rq { unsigned int rt_nr_boosted; =20 struct rq *rq; +#endif +#ifdef CONFIG_CGROUP_SCHED struct task_group *tg; #endif }; --=20 2.47.1 From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 386E01D515B for ; Mon, 16 Dec 2024 20:13:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380000; cv=none; b=DEVAJ7enNSCL+fW8hyM8PGGm8717f8NE5+J4FkrbA1m6JIbfm2enSctwTnZkII6qY++ifpDBfjBKtgIhC69dZ72cGNO/EJAr3uhh8omzdiPWEqoDig8qqgT8uCV+ZdyVA5B0UF3Nr5ubzmoy9Gp75hErzsNvENFcRGkMaqLwf1U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380000; c=relaxed/simple; bh=kgkb/U2cImJvjDQzwb8/y9+msWpDFa2mSq28GSAc/qE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=H+tvL/xGhH9zBK/+napt741v83Ri4iWLhzMvvvd413h5wn6DK510yCgcC6J/hUmabv0oMDu3PKkjeu3bjBpJHChlq8Xh6yflH5ES2Ks9tUhTmMf2/3fE3EE+Ap7XrSj2Flci3ofpX1dHblZpNmDLMFNpsjBZ6gdYCmsEj9wb5s0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=VhRkQidi; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="VhRkQidi" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-436281c8a38so29761985e9.3 for ; Mon, 16 Dec 2024 12:13:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379996; x=1734984796; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EcO2b6bGyel//lc1A0Ez4rBVc7IGRT8q21dTkVTikaM=; b=VhRkQidiGWPYcJ9IIIzhgYGLRKgM2w4nOb14HB5O/N9dGsfwmKuDtdGxxwFQ/fjG31 RzDjrNz/TPkcarDFKOGwwrlfmmHIOagcUITIoxRhX2aenUXQMS7q+s1OEJ8ZAIaDSbff I0zVFMddEEGwYUN6DzKqxB/bX/tShF7p5nkcxWeqU2jND/ztxbA+23K8JEoyP5u6LY+l dqYwaMmEkR03fZYlitifcaNXIJUV0pPGZlBT7sMDM5jujBP5PxBxefxHrjR6KqdPFg+r /FrCuEOmwZoq9GX841roG0ByncxjA7S22mQSh/1gbod2NHdkT0muodD5U2N7s0UuJocd 1fWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379996; x=1734984796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EcO2b6bGyel//lc1A0Ez4rBVc7IGRT8q21dTkVTikaM=; b=LpxgYdD7aeAfk1olWtNd6pic5jiXdMzY6Dyrqt7DD3e6LuZZtWXMZDdf/WCjBSQbzY U9eAtYHwnCSKM3iZs3qtVW8w9l8IS8SnTNv101dyqR9np6xVs7VsmbDDjQRA1ixq/aaU J0m6TdWp5t501SpADuFtuhsxrqr3PP0n12GSsKVKlLGm6SgZRQfqGYXA6Bl4k/vrr1yM 6wwRlTk7M9XRRZ/tmlSdmozza80AJYd9godf2re38MDjGB+Xlgz35tfHjvZqG5MJsJoK ZO19lXW3vTjPNrKpj1942BBHG+IrU8AzkRiPOxFg4wah3j5wGBwast+oqVrBTKmya4qS VfWg== X-Forwarded-Encrypted: i=1; AJvYcCXv3gajDAL9kS3z7apGLLS/BooTaEqkPbe05uSVjSQTP8zB+lcGUY+eeckUskPO05X+xhmFj98fyfiTbuo=@vger.kernel.org X-Gm-Message-State: AOJu0YxxRsKtZT4QLxCw3aZBLZjrdAcT+6po4F5wUp2iHGfmbQ3YaxLS +hf9wsL5f689XMTMf4lM+WiWDY1oIMVoJU2XBtkDGBv4nZgZpjcUcgU7ogiXh8k= X-Gm-Gg: ASbGncuteIB2L6CZWUj4WcbF7gOBbYINCtuKKhRqBqzE3I6AqzF92zW9C28u5Y8b562 NeW0/PDpbL3nJHPzZ8RI51q6UO5umTtFHn1LOx/lvjz1eVzT4Sk2I5bpjXubq8wgBGYoLudz34X TVWUEEbMqTmjHBUKEF4+kVjgerf4AiSExGaheXT6ASo0SOfMlkMuRDgbhOOkl4SU7XCQaXlNCs6 dzfk7GvDHiDFwuPtQOP7TDj9xVezcWzXtwul1OrYGI6dD+e0pw+lRpXKA== X-Google-Smtp-Source: AGHT+IE1+7v6rC9j0mpAzs7abmQ8Ecbmx3mX7nPYgbcuKpdGXUfmDxdl7UNMEdc42gIrM1YtJroZEA== X-Received: by 2002:a05:600c:1da1:b0:431:547e:81d0 with SMTP id 5b1f17b1804b1-4362aa4386dmr122477995e9.11.1734379996481; Mon, 16 Dec 2024 12:13:16 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:16 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 4/9] sched: Add commadline option for RT_GROUP_SCHED toggling Date: Mon, 16 Dec 2024 21:13:00 +0100 Message-ID: <20241216201305.19761-5-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Only simple implementation with a static key wrapper, it will be wired in later. Signed-off-by: Michal Koutn=C3=BD --- .../admin-guide/kernel-parameters.txt | 5 ++++ init/Kconfig | 11 ++++++++ kernel/sched/core.c | 25 +++++++++++++++++++ kernel/sched/sched.h | 17 +++++++++++++ 4 files changed, 58 insertions(+) diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentatio= n/admin-guide/kernel-parameters.txt index 3872bc6ec49d6..1c890c9ad8716 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -5937,6 +5937,11 @@ Memory area to be used by remote processor image, managed by CMA. =20 + rt_group_sched=3D [KNL] Enable or disable SCHED_RR/FIFO group scheduling + when CONFIG_RT_GROUP_SCHED=3Dy. Defaults to + !CONFIG_RT_GROUP_SCHED_DEFAULT_DISABLED. + Format: + rw [KNL] Mount root device read-write on boot =20 S [KNL] Run init in single mode diff --git a/init/Kconfig b/init/Kconfig index a20e6efd3f0fb..7823e5ac0311d 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -1076,6 +1076,17 @@ config RT_GROUP_SCHED realtime bandwidth for them. See Documentation/scheduler/sched-rt-group.rst for more information. =20 +config RT_GROUP_SCHED_DEFAULT_DISABLED + bool "Require boot parameter to enable group scheduling for SCHED_RR/FIFO" + depends on RT_GROUP_SCHED + default n + help + When set, the RT group scheduling is disabled by default. The option + is in inverted form so that mere RT_GROUP_SCHED enables the group + scheduling. + + Say N if unsure. + config EXT_GROUP_SCHED bool depends on SCHED_CLASS_EXT && CGROUP_SCHED diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c6d8232ad9eea..47898f895a5a3 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -9844,6 +9844,31 @@ static struct cftype cpu_legacy_files[] =3D { { } /* Terminate */ }; =20 +#ifdef CONFIG_RT_GROUP_SCHED +# ifdef RT_GROUP_SCHED_DEFAULT_DISABLED +DEFINE_STATIC_KEY_FALSE(rt_group_sched); +# else +DEFINE_STATIC_KEY_TRUE(rt_group_sched); +# endif + +static int __init setup_rt_group_sched(char *str) +{ + long val; + + if (kstrtol(str, 0, &val) || val < 0 || val > 1) { + pr_warn("Unable to set rt_group_sched\n"); + return 1; + } + if (val) + static_branch_enable(&rt_group_sched); + else + static_branch_disable(&rt_group_sched); + + return 1; +} +__setup("rt_group_sched=3D", setup_rt_group_sched); +#endif /* CONFIG_RT_GROUP_SCHED */ + static int cpu_extra_stat_show(struct seq_file *sf, struct cgroup_subsys_state *css) { diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 38325bd32a0e0..1c457dc1472a3 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1501,6 +1501,23 @@ static inline bool sched_group_cookie_match(struct r= q *rq, } =20 #endif /* !CONFIG_SCHED_CORE */ +#ifdef CONFIG_RT_GROUP_SCHED +# ifdef RT_GROUP_SCHED_DEFAULT_DISABLED +DECLARE_STATIC_KEY_FALSE(rt_group_sched); +static inline bool rt_group_sched_enabled(void) +{ + return static_branch_unlikely(&rt_group_sched); +} +# else +DECLARE_STATIC_KEY_TRUE(rt_group_sched); +static inline bool rt_group_sched_enabled(void) +{ + return static_branch_likely(&rt_group_sched); +} +# endif /* RT_GROUP_SCHED_DEFAULT_DISABLED */ +#else +# define rt_group_sched_enabled() false +#endif /* CONFIG_RT_GROUP_SCHED */ =20 static inline void lockdep_assert_rq_held(struct rq *rq) { --=20 2.47.1 From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE68B1D31AE for ; Mon, 16 Dec 2024 20:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380001; cv=none; b=peYXE45miN9qhMecJTugk9o+8vVULdloGJmtdjvXxZS+5vzkUO6t9UXH5EEp3+nu5HcEGIH0IKubqKhaI0bg2CmCNu/bycH2ue2b6YL5cuMkuIvl51RbBYMz9+XxESClsXkg2Z3ZHMcr/5Ueofg/qySZkQU6TuUAYW+0WcF62DI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380001; c=relaxed/simple; bh=GEVPFmfx8lJk0msTC4kBxvoqsFBYZDzhe/s440TxMQc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HZtJrE08LlzbKGTw4OTjO3v/sz3+K0AlaSEmxpJL7X/7B2WoW84DvM0/uv2HP/oqwhDpAjA0jR6cWn09XsTnNrxyPPmdvVLpbJ27LCfq/VhnzKEyaWswTmJKSsBPv0FV/tYIoJ5V9CjVVvk+14INAzGbL09EijAF8oEaRklSV8U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=OFFWs2IR; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="OFFWs2IR" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-434b3e32e9dso49695425e9.2 for ; Mon, 16 Dec 2024 12:13:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379997; x=1734984797; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AQzHk+vq4hHffbPZrG6QBU6HzZrXvwTNaQRxK1FhdoM=; b=OFFWs2IRpc7vC2rcS0i+0eMrYoWre/vJiK8Yh6ICQwk+zBFIYTkuuw7xpedpDaw2t/ Z+iVePgVR0GeoaC4uzHXY+0Em2qHZQT0HBtdAP220VUJRHqVDw4UIrRvym41z1lUYf2h e4+QaZpGvagH37I0xHbpg09t+ux22PL75JcHKUNnvjy0U44yba+B4ZPA578Ua7ZIXGQr slWQ8PQn6MqztxdK7qr2O7VwgfZ8uNpAQOT48OZn7SFJ5pq6/5oe67sVhlkd2CG+FB9W 12z+1sFgQ8yhVEZd4K7dqrYmvWmwqujla2qm4LxcnUX5DutjCSl4J/Yhdnx8IEU5s20d xbbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379997; x=1734984797; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AQzHk+vq4hHffbPZrG6QBU6HzZrXvwTNaQRxK1FhdoM=; b=Lij+xq0fjsFXQnFfojM/RUDcaZpER8ktcxVY+/wyIOpvcA9TOpZP1XNe6a6IeN+UJZ I6YkbjwRbomkSVMh+STAHja1elhu2QghWJ3Np/FhnChZrtZOH1eaYJO5njPeTY1a5NZS n5hHHQJoOBcER5S40ZHDNbr+eJnrM+bbe6bjXzjpPXpo5tJNugI0PT9HXnwdm82Zo2Ca W3MJEsHofkehTzgtuxuY731/HXDTR2H9HkByeKQ4vM44ATQaNsW7IgdUcI0NvpJlODJB 107eNv/NP79WJNHaeEGUoBAv7Zcz8bbEKzsjeJQcAEf+K9nzXBm2xJ5CKeNEv1+mkNYK HSNA== X-Forwarded-Encrypted: i=1; AJvYcCVUxqwEYQY5hW/6L1SFR6jpc1nE96fPTqtNCa3PTIsKzkYqvs5SRbYzDhvIG4gxPAgmGCunpXBOfyWOnW4=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0IkfQjUKPZYdJfnAr0miG/RkICU5aNH6LRSWt8/K4OedfPWn/ 9E9IHYH9J1HCS/6WWBnDoKiyCM41OXlg69PMsZX+jDeUXkIJP3/aBqTVndGDj+M= X-Gm-Gg: ASbGncvRCddQlkaLvEl8b3hKBEHMAvLurEy9rzAXyyyYBw3Htjxwuzt5cDBTKK8JaYt vUU2bWxSDRHFvZk0KDBev7BKJpxdpstU2xetHmqa6zFOqu9rULNNWqO4jnnnzOorOe4T3J1nJux uSRhbZlHEqMQjDp67wHv+gEwAlYCk9GhxNofq5RKk1Y+FeAuRRq6pn0dyPNj2sh24DURvqtcqws 8L+FpKwBpSM0RfgXl8PdP/CVPgywQdA6WvV1ej2POK2VVg+zDjERZqPEg== X-Google-Smtp-Source: AGHT+IGyt5ABFZR5mnMw1R3r7LXBL15BSl/L4PEq55+haAC/GNs+ad/ewuDRlHUqZRIg1Cop42eYZg== X-Received: by 2002:a05:600c:83cf:b0:434:edcf:7474 with SMTP id 5b1f17b1804b1-4362aaa1ee4mr112233245e9.33.1734379997270; Mon, 16 Dec 2024 12:13:17 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:17 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 5/9] sched: Skip non-root task_groups with disabled RT_GROUP_SCHED Date: Mon, 16 Dec 2024 21:13:01 +0100 Message-ID: <20241216201305.19761-6-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable First, we want to prevent placement of RT tasks on non-root rt_rqs which we achieve in the task migration code that'd fall back to root_task_group's rt_rq. Second, we want to work with only root_task_group's rt_rq when iterating all "real" rt_rqs when RT_GROUP is disabled. To achieve this we keep root_task_group as the first one on the task_groups and break out quickly. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/core.c | 2 +- kernel/sched/rt.c | 9 ++++++--- kernel/sched/sched.h | 7 +++++++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 47898f895a5a3..dfd2778622b8b 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -8958,7 +8958,7 @@ void sched_online_group(struct task_group *tg, struct= task_group *parent) unsigned long flags; =20 spin_lock_irqsave(&task_group_lock, flags); - list_add_rcu(&tg->list, &task_groups); + list_add_tail_rcu(&tg->list, &task_groups); =20 /* Root should already exist: */ WARN_ON(!parent); diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 41fed8865cb09..923ec978ff756 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -497,6 +497,9 @@ typedef struct task_group *rt_rq_iter_t; =20 static inline struct task_group *next_task_group(struct task_group *tg) { + if (!rt_group_sched_enabled()) + return NULL; + do { tg =3D list_entry_rcu(tg->list.next, typeof(struct task_group), list); @@ -509,9 +512,9 @@ static inline struct task_group *next_task_group(struct= task_group *tg) } =20 #define for_each_rt_rq(rt_rq, iter, rq) \ - for (iter =3D container_of(&task_groups, typeof(*iter), list); \ - (iter =3D next_task_group(iter)) && \ - (rt_rq =3D iter->rt_rq[cpu_of(rq)]);) + for (iter =3D &root_task_group; \ + iter && (rt_rq =3D iter->rt_rq[cpu_of(rq)]); \ + iter =3D next_task_group(iter)) =20 #define for_each_sched_rt_entity(rt_se) \ for (; rt_se; rt_se =3D rt_se->parent) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 1c457dc1472a3..d8d28c3d1ac5f 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -2148,6 +2148,13 @@ static inline void set_task_rq(struct task_struct *p= , unsigned int cpu) #endif =20 #ifdef CONFIG_RT_GROUP_SCHED + /* + * p->rt.rt_rq is NULL initially and it is easier to assign + * root_task_group's rt_rq than switching in rt_rq_of_se() + * Clobbers tg(!) + */ + if (!rt_group_sched_enabled()) + tg =3D &root_task_group; p->rt.rt_rq =3D tg->rt_rq[cpu]; p->rt.parent =3D tg->rt_se[cpu]; #endif --=20 2.47.1 From nobody Wed Dec 17 21:39:46 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA7FC1D434F for ; Mon, 16 Dec 2024 20:13:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; cv=none; b=kcZdxKqJIa55EZygUPONzOjBAB4Z4i/LYDWA/9NRN99jkd0pMeqUcJOiLjltJeDS2W3k5zkxgGAiP8OuA/fw7xe+Q+bkNAZojesN+dgxPBUyx7St6iPoE7JDQZ7cJacKC49LhxoRIprroMSqhkVhfcxoBB5kBUHxVdbAKuxVM+w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; c=relaxed/simple; bh=8xpukR/cApv4dVgoo08xeVNSIFIEqldxvUynW0kO7ws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DfjnC1xc+g+weWCSTOjgy4S1T0QGDEJ8sHbqfZ0lBMGSfygjqPN5YaLjtm2BX+B95h8rwqll2JnVT75HFxuotLRSAyhAcMjHdHJQ8Gr/Nyk+hm93DXOmWiUQ3aNzAOhAVJV7Zb0bkzyw/2F4/zE2NlctyH8MndIeP3EbXw3n+Uc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=V9Fg00Dv; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="V9Fg00Dv" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43635796b48so16210895e9.0 for ; Mon, 16 Dec 2024 12:13:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379998; x=1734984798; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ELwtM8rOu6mwy4EhHFHUg+bGTeHEN0nMLysx4xsM2ks=; b=V9Fg00Dvp3QdE6Jjo4kIiwISnywXb/0+PSeC75ScaGVp2yfiZaepzl8H3Kv5pWKCtu 3DwOYsIJPOBiIr81quD/AbB2a9Ih1IY8xs9ktlqPsDotFo6jcQ5finrHEz+Bu2nQk7I7 jPh466ILR/JGUOKOdala1RtgvXSaJpsosbmCy57zQku2JnsiuZNgI1Y4qdC2xWRBXM1J NwYQz1bsIjyPaA2ReYX5OXONa8UOzUzEZnVgJUwXGyM/XwTAQ1gEKIMI9OrjF0i1nJzP f0/LK3vuLxpwFsAcKlYRCdjX0yKekgyMNf4tx/LIfe5gnobHf2Zj2rkFoGDY93n64QsN Zy2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379998; x=1734984798; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ELwtM8rOu6mwy4EhHFHUg+bGTeHEN0nMLysx4xsM2ks=; b=j2umos3nmMagQfG+lOnvmyO9/2ljvwRFLxx2CefqD4BtEB/ATRFGWu4EU9Wbt0t9xn 4qloL1nEiDlUyz37C9098GCRovEYGICivPJ5mXehSYQbTsEWicUGQ3vsVg71CjMthJzN q75GoOqcS0C7mHGby/ah889KNUNAyGb9eZek9QBeXbPIkhWgO7I+MYesxD88lqAun7Tz Vl7EbBkX28xcdLcuj3h1/1KMUNBYsVooLei/qPOaN9shUPGfBR5USpFTfYDXt7nnqIIg R2ilTEElgdCs9dcSbB1FLBpdRg8iPC/jujSlxEk8yLmvQAp1fClq4B8mQ7eAg1oJ9xXS /dsw== X-Forwarded-Encrypted: i=1; AJvYcCWpTevi2/4tQ/nuTfDNmSa1SrnyEc9WtW8JmwxkbpBBUU8uqiTE0Kn2RFl0/N7j7gWZ49twUrUpvowad/k=@vger.kernel.org X-Gm-Message-State: AOJu0YyPfmHBzvpW0nqPfqe84EKOWRxL1LFTJjr3m7hB6XKXbJW7aHN5 8KuQ1HMNLvZfKXM+c9SLR3m3EuvFTp/Atp/LMgVGQ9rNjHIULKLlXALv7kaFzIU= X-Gm-Gg: ASbGncsqmzW0ez8JHMofLNmcNKizU3PV+GH5rB1thSapU10+KcwqSK/X3TCK3JsAywb 3q8h8ByJoRIl5uzgymW8+VG8cT7Uf1fSCVMtcXNXXZYZloUnzQ/JfBxLfdUsxblkLKexHNaEawZ R1AY9C1bjTuTABZsjLhLBzJ4JIOLpvB65Qekz8OR9V3wU4W5p/jB8R/vqcjSF+OkaBO0FmClmVw Q/8ggrmfrEBtDAH+RCDGMmtS7rmtv9Z2n8oqc+Ek7nrFgh4O6O4+qdSqA== X-Google-Smtp-Source: AGHT+IFaU+hTk8Vcu6QoJN6vBQIdWmOKWjm88Qu4m49pXUf0WXbKshK4S50Byug0SSi+sU7UrwZLbA== X-Received: by 2002:a05:600c:1d25:b0:436:1af3:5b13 with SMTP id 5b1f17b1804b1-436481ebda5mr5845185e9.15.1734379998111; Mon, 16 Dec 2024 12:13:18 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:17 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 6/9] sched: Bypass bandwitdh checks with runtime disabled RT_GROUP_SCHED Date: Mon, 16 Dec 2024 21:13:02 +0100 Message-ID: <20241216201305.19761-7-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When RT_GROUPs are compiled but not exposed, their bandwidth cannot be configured (and it is not initialized for non-root task_groups neither). Therefore bypass any checks of task vs task_group bandwidth. This will achieve behavior very similar to setups that have !CONFIG_RT_GROUP_SCHED and attach cpu controller to cgroup v2 hierarchy. (On a related note, this may allow having RT tasks with CONFIG_RT_GROUP_SCHED and cgroup v2 hierarchy.) Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/core.c | 6 +++++- kernel/sched/rt.c | 2 +- kernel/sched/syscalls.c | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index dfd2778622b8b..6e21e0885557d 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -9158,11 +9158,15 @@ static int cpu_cgroup_can_attach(struct cgroup_task= set *tset) struct task_struct *task; struct cgroup_subsys_state *css; =20 + if (!rt_group_sched_enabled()) + goto scx_check; + cgroup_taskset_for_each(task, css, tset) { if (!sched_rt_can_attach(css_tg(css), task)) return -EINVAL; } -#endif +scx_check: +#endif /* CONFIG_RT_GROUP_SCHED */ return scx_cgroup_can_attach(tset); } =20 diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 923ec978ff756..161d91f7479b4 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -2866,7 +2866,7 @@ static int sched_rt_global_constraints(void) int sched_rt_can_attach(struct task_group *tg, struct task_struct *tsk) { /* Don't accept real-time tasks when there is no way for them to run */ - if (rt_task(tsk) && tg->rt_bandwidth.rt_runtime =3D=3D 0) + if (rt_group_sched_enabled() && rt_task(tsk) && tg->rt_bandwidth.rt_runti= me =3D=3D 0) return 0; =20 return 1; diff --git a/kernel/sched/syscalls.c b/kernel/sched/syscalls.c index 77d0d4a2b68da..80382f5d53a44 100644 --- a/kernel/sched/syscalls.c +++ b/kernel/sched/syscalls.c @@ -644,7 +644,8 @@ int __sched_setscheduler(struct task_struct *p, * Do not allow real-time tasks into groups that have no runtime * assigned. */ - if (rt_bandwidth_enabled() && rt_policy(policy) && + if (rt_group_sched_enabled() && + rt_bandwidth_enabled() && rt_policy(policy) && task_group(p)->rt_bandwidth.rt_runtime =3D=3D 0 && !task_group_is_autogroup(task_group(p))) { retval =3D -EPERM; --=20 2.47.1 From nobody Wed Dec 17 21:39:47 2025 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 203E61D6188 for ; Mon, 16 Dec 2024 20:13:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; cv=none; b=iC/e7m3t8zIQqM0evk58I2LrXAySSei/3DdVNzHKRAa8zYXJz16n3R05OZRZ3Qm6DyE4wS4WbyPrV5UfFnpTU682LHMSWPVU1PQRbuXFv1hCJuVujK4dNTSupwFHcC0rkNyfuTVnJ0jyjyjtSJjs7EGJYtvbQgctO1dksPA0J0Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; c=relaxed/simple; bh=BgnE3y0aEkA+6mEwxppauEiIwzvGAc2MheHabRKMMzs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kZdp5TIOq+XelGhv+GLeFe9CRNUHPbsnrO4IH92TrCZO2BVMZR7qSYWJ6Xhlxh7jhOx4wieR4blh0Gnt9LW7MiLRKTwOmChhu798j0f0kbrMo5yz72Pf7RaPDM9kFfEK40eSDt4gFcSWHVEJLLvPKJmhQ4limN7+cuGb8mD4N/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CWeZVFj5; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CWeZVFj5" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4364a37a1d7so192075e9.3 for ; Mon, 16 Dec 2024 12:13:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734379999; x=1734984799; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G+uDEQRPgLnIuRhkfP+uF78Vcg5q4+H6L1oWNhvU8jc=; b=CWeZVFj545qKgLqsnPIpmdOJSkO4XpUJygw1kdtE8G7ePbk3/c87SlkGneCVxQQem3 UhCrZmn+1k0oW3TVE6jiFtsHa8CyUrHLYCCNOz8gUlEKnyNgOtOgPBWiDoSW/A831j/3 k5orv2kLboI5piGGpjTL7JXmYF7spb8O8KlJ0IsebdJbJ9YV9p9SmRruXs7ry0IZOMnL 6tHcD0sMY4oqxBNk9/bupIrTiwSSSULSqqW6vzRSG4mMdXTYQMc2yYoyyMuFN1iuwmsJ RxI7CMuY0M/nGMYxLLeQ8VZ6AJtFdUkuSDRKxPXdyedkNRhbEuans8hOGLwFPtxIfRpo m/UA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379999; x=1734984799; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G+uDEQRPgLnIuRhkfP+uF78Vcg5q4+H6L1oWNhvU8jc=; b=M5VbdVh6n4l5Wdcmp3BAi3aUh6y/Vz0uSXorQaTvv5mFdTxtm9HMBfRX75Lv2UYnnK kIO0KCdDp3vM/PIdPqGB3fRiNKKwma2kJ0HUiHxEhFHY8CF9uT+6vJDBy0HEP7pPi4J4 Z3tDGAb/RTZk0RoCakKioATXjSvaRAhAJG9qA12FoVQjcYrgJ0e9cu1wMkWomFxwGXKk UHmNMpDLtSAB7XtJbt+Dx1kWN7mQS2rPpia3maozqY0nDWhqiCsEjUmXoY6lX8buNsgi Ld8UUUrqPK5ct67w+Lg4RpvxnaAXJFOD3A3GXrA1eJWRv6OGfctLOamIuTZc80Tc0leK 0EQQ== X-Forwarded-Encrypted: i=1; AJvYcCW6IOyPq0zlmimVBeiRzOhifqXNKZ6M1jOBkLJaIek62rhGykXBoiZAeBKMJAn10745pHgWAZSl28F9qq0=@vger.kernel.org X-Gm-Message-State: AOJu0YzLBpZxino9sNj9tLanO3ux7b11Gz9r3ty00r0fDGf5O1udgO0+ 1d1xvOL0RgcbIJ1fpEiOUqMDRsOi/0j0vP9Gi1aQRlbk7TOjWAhIVD90StsdaEY= X-Gm-Gg: ASbGncsi5qquEwYp4qbn+1MckeWpGVvluFlN8Lk2jouYrYQ7O2ow/HkOAaaTr0GkQRL qmF+UH1VIYMCr+oMTDuMzivT2SYP4HMp8BcYmLCYX0BwIinvgkp5hplc2V2aGZpIKT9Qsd1vyI6 Ird5uJ2YAoJEnEOFh/KsKZ41BpIBiRT/STuLcnJqtdYmtBeKMcPbLyk49UCnF59Ba25qlbS6L0c h9472b+5sxpXcasBy6ftUCrh6QsPd3MP1q3CvA0wx8+zcK+pMApGVhIIw== X-Google-Smtp-Source: AGHT+IE0YPWhe33Skc7Ao7kIv0JHWWBX92wx7RBLT/PPrRR4qswieUBdDloiYM0Sh7mx0mPRokcAOg== X-Received: by 2002:a05:600c:4e11:b0:434:f804:a9b0 with SMTP id 5b1f17b1804b1-4362aaa49b1mr125287635e9.29.1734379998887; Mon, 16 Dec 2024 12:13:18 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:18 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 7/9] sched: Do not construct nor expose RT_GROUP_SCHED structures if disabled Date: Mon, 16 Dec 2024 21:13:03 +0100 Message-ID: <20241216201305.19761-8-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Thanks to kernel cmdline being available early, before any cgroup hierarchy exists, we can achieve the RT_GROUP_SCHED boottime disabling goal by simply skipping any creation (and destruction) of RT_GROUP data and its exposure via RT attributes. We can do this thanks to previously placed runtime guards that would redirect all operations to root_task_group's data when RT_GROUP_SCHED disabled. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/core.c | 36 ++++++++++++++++++++++++------------ kernel/sched/rt.c | 9 +++++++++ 2 files changed, 33 insertions(+), 12 deletions(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 6e21e0885557d..300a1a83e1a3c 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -9819,18 +9819,6 @@ static struct cftype cpu_legacy_files[] =3D { .seq_show =3D cpu_cfs_local_stat_show, }, #endif -#ifdef CONFIG_RT_GROUP_SCHED - { - .name =3D "rt_runtime_us", - .read_s64 =3D cpu_rt_runtime_read, - .write_s64 =3D cpu_rt_runtime_write, - }, - { - .name =3D "rt_period_us", - .read_u64 =3D cpu_rt_period_read_uint, - .write_u64 =3D cpu_rt_period_write_uint, - }, -#endif #ifdef CONFIG_UCLAMP_TASK_GROUP { .name =3D "uclamp.min", @@ -9849,6 +9837,20 @@ static struct cftype cpu_legacy_files[] =3D { }; =20 #ifdef CONFIG_RT_GROUP_SCHED +static struct cftype rt_group_files[] =3D { + { + .name =3D "rt_runtime_us", + .read_s64 =3D cpu_rt_runtime_read, + .write_s64 =3D cpu_rt_runtime_write, + }, + { + .name =3D "rt_period_us", + .read_u64 =3D cpu_rt_period_read_uint, + .write_u64 =3D cpu_rt_period_write_uint, + }, + { } /* Terminate */ +}; + # ifdef RT_GROUP_SCHED_DEFAULT_DISABLED DEFINE_STATIC_KEY_FALSE(rt_group_sched); # else @@ -9871,6 +9873,16 @@ static int __init setup_rt_group_sched(char *str) return 1; } __setup("rt_group_sched=3D", setup_rt_group_sched); + +static int __init cpu_rt_group_init(void) +{ + if (!rt_group_sched_enabled()) + return 0; + + WARN_ON(cgroup_add_legacy_cftypes(&cpu_cgrp_subsys, rt_group_files)); + return 0; +} +subsys_initcall(cpu_rt_group_init); #endif /* CONFIG_RT_GROUP_SCHED */ =20 static int cpu_extra_stat_show(struct seq_file *sf, diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 161d91f7479b4..db7cdc82003bd 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -195,6 +195,9 @@ static inline struct rq *rq_of_rt_se(struct sched_rt_en= tity *rt_se) =20 void unregister_rt_sched_group(struct task_group *tg) { + if (!rt_group_sched_enabled()) + return; + if (tg->rt_se) destroy_rt_bandwidth(&tg->rt_bandwidth); } @@ -203,6 +206,9 @@ void free_rt_sched_group(struct task_group *tg) { int i; =20 + if (!rt_group_sched_enabled()) + return; + for_each_possible_cpu(i) { if (tg->rt_rq) kfree(tg->rt_rq[i]); @@ -247,6 +253,9 @@ int alloc_rt_sched_group(struct task_group *tg, struct = task_group *parent) struct sched_rt_entity *rt_se; int i; =20 + if (!rt_group_sched_enabled()) + return 1; + tg->rt_rq =3D kcalloc(nr_cpu_ids, sizeof(rt_rq), GFP_KERNEL); if (!tg->rt_rq) goto err; --=20 2.47.1 From nobody Wed Dec 17 21:39:47 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7995E1D63C4 for ; Mon, 16 Dec 2024 20:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; cv=none; b=ChqLh0frYh3NoH0AyH3rk0wYkyLhpLQJ1f4OWXdXcEuY+13jp/jvqmxOcwBtpws+eT6ZzRWCMnXhlySB+eknrl7Pz3s+vvjTw8DiO9Y+7NORShTiC9SXMOaU/kkyu89rNisP1Hn03NE7wNIRwxX9pRS6pRse7l+IbfYmzpvQF7k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380003; c=relaxed/simple; bh=sAuqG2C0OeDsO12ruW4vbErIpYaHfkRnSMmWfHPILLM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=vGaazUG80TRpNzRJWVg/1WiXW9gRjxYXjiVQcsoITFkC3SdIghs7T3YekhZmOZpZIlGUQuCB+e9TbUYGueN/GaASpVhcigPybo/ynnJQrlPLcKDhBv/V3AgQltTBYGU1u2KFqARR7G51h3Tsk/LQrVWB9pmxo2Y0z8PzNTMDldM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Wnmq1gsG; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Wnmq1gsG" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4361a50e337so31698165e9.0 for ; Mon, 16 Dec 2024 12:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734380000; x=1734984800; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TKj14npJ7R9cs4fWfeOYO+IBaB1ICPemXIGU+5j22xk=; b=Wnmq1gsGGOBpNBcw3BHfwpkWCkOSPbSxB39hoxboHQSFLAbuJx2iVYiD3ydrUMVEgP w/XGNuW7pBFW0ww9kRN0Rpvr1uGsMhFXUf73gPH2nEG7NXX1qblI7kjfFOuLpg/WA+Fd Kh0tvsyfNfJojCROZ04SYJN5jTQXJ0rYss7nHRh3EORy8tpADbJMOn3yGQu7FkMKgAnj vdmPJyPneIIBbG81kXDmDZgSQwZpfSkPLGXjg9E66Qs9EXcGDtIHwKVxaM3UfKB3lNPc 5DaFe/5jFRinsywfNqJt8VaYCVct+F5ZuafiPX4TL8grQ8cVvxZOLzpt1CXlgUM9/oTl 45dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734380000; x=1734984800; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TKj14npJ7R9cs4fWfeOYO+IBaB1ICPemXIGU+5j22xk=; b=qDZXsWQ3jzPPacU8qC6SAh+eKapKtAnZ94cN0CCPLepr6Ln0qHlFfmrjJZ0WJphOy6 c1tdYe66pL3B1tLf6tLX32rQTG6jbja5epf260daqVkv/DdtEqadcgl8dBVzhITIZoP6 nkqQkd6IOgQkBhDFmVOB+TtLo1la9P7WHUOslkWyXkOrZ+KOeUIHLjypHxpk30miDAu5 r/kk9nBtGao6novIEX61nb57saXLe4T5JmOxGXNGROPhSpcr5quBoV82dVvXC0nSGk3l G2uFG63g9L55KrZXKINlqY2SwujrwKyre5Onp1NoRdUTVHf25Ck6onZ1tZ7nYjeDs1UE w07g== X-Forwarded-Encrypted: i=1; AJvYcCUHFXAe6VgOZYGR3wGUiiqHuGn1qXzUYkoC5naAdVGlWvx5mgRW00TF9wMidP8p187+8vHQD6ZEQt82n/k=@vger.kernel.org X-Gm-Message-State: AOJu0YxCrSz+keAaam3QW6Ecm4VO38z7xsnIQJGJlWxUUggpurKyjI0q K3bPJv2y+Fu9oSHRiKv1FktYAVB2WcUOC81MIxyxxnVfzT0tuFHl+RAmXi14BsY= X-Gm-Gg: ASbGncsDux/NPwN0pNS4999gJ0wFsUNokz8L+CAOgoKjqqJO9oo/fY+sHxRzcq43hik U1lGba4lXbncusWzqSppcvW5ALmMkHm7dgLWnGY2zPVVYob4anKVEIbgFbtoKwkogHCjYon6ZRr nGxc1HwHg4kzuGsxh/Yf1PGgdeCPBYatRzVJTCD5xq9obGk6AfzKabPbTuZVtjnwCD5Omi32Fot 9KzFkFkYEHB8xJOZCGL1CXPXXg76vzlyDPSUI+B+u6VqLjj5YVnHfcmoA== X-Google-Smtp-Source: AGHT+IH7d1GySzdi9zfSxB6g8GzAlPF95KSWZ0OkCE4h3jr0ii1QwEHaxJGNZ/FP2XbW/sNy/OmBrw== X-Received: by 2002:a05:600c:3109:b0:434:fdaf:af2d with SMTP id 5b1f17b1804b1-4362aab4e5amr127654525e9.30.1734379999689; Mon, 16 Dec 2024 12:13:19 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:19 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 8/9] sched: Add RT_GROUP WARN checks for non-root task_groups Date: Mon, 16 Dec 2024 21:13:04 +0100 Message-ID: <20241216201305.19761-9-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable With CONFIG_RT_GROUP_SCHED but runtime disabling of RT_GROUPs we expect the existence of the root task_group only and all rt_sched_entity'ies should be queued on root's rt_rq. If we get a non-root RT_GROUP something went wrong. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/rt.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index db7cdc82003bd..deacd46e27823 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -178,11 +178,14 @@ static inline struct task_struct *rt_task_of(struct s= ched_rt_entity *rt_se) =20 static inline struct rq *rq_of_rt_rq(struct rt_rq *rt_rq) { + /* Cannot fold with non-CONFIG_RT_GROUP_SCHED version, layout */ + WARN_ON(!rt_group_sched_enabled() && rt_rq->tg !=3D &root_task_group); return rt_rq->rq; } =20 static inline struct rt_rq *rt_rq_of_se(struct sched_rt_entity *rt_se) { + WARN_ON(!rt_group_sched_enabled() && rt_se->rt_rq->tg !=3D &root_task_gro= up); return rt_se->rt_rq; } =20 @@ -190,6 +193,7 @@ static inline struct rq *rq_of_rt_se(struct sched_rt_en= tity *rt_se) { struct rt_rq *rt_rq =3D rt_se->rt_rq; =20 + WARN_ON(!rt_group_sched_enabled() && rt_rq->tg !=3D &root_task_group); return rt_rq->rq; } =20 @@ -506,8 +510,10 @@ typedef struct task_group *rt_rq_iter_t; =20 static inline struct task_group *next_task_group(struct task_group *tg) { - if (!rt_group_sched_enabled()) + if (!rt_group_sched_enabled()) { + WARN_ON(tg !=3D &root_task_group); return NULL; + } =20 do { tg =3D list_entry_rcu(tg->list.next, @@ -2609,8 +2615,9 @@ static int task_is_throttled_rt(struct task_struct *p= , int cpu) { struct rt_rq *rt_rq; =20 -#ifdef CONFIG_RT_GROUP_SCHED +#ifdef CONFIG_RT_GROUP_SCHED // XXX maybe add task_rt_rq(), see also sched= _rt_period_rt_rq rt_rq =3D task_group(p)->rt_rq[cpu]; + WARN_ON(!rt_group_sched_enabled() && rt_rq->tg !=3D &root_task_group); #else rt_rq =3D &cpu_rq(cpu)->rt; #endif @@ -2720,6 +2727,9 @@ static int tg_rt_schedulable(struct task_group *tg, v= oid *data) tg->rt_bandwidth.rt_runtime && tg_has_rt_tasks(tg)) return -EBUSY; =20 + if (WARN_ON(!rt_group_sched_enabled() && tg !=3D &root_task_group)) + return -EBUSY; + total =3D to_ratio(period, runtime); =20 /* --=20 2.47.1 From nobody Wed Dec 17 21:39:47 2025 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D2721D63F2 for ; Mon, 16 Dec 2024 20:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380004; cv=none; b=hAq1f4DfZeIpU08PthZwl883tBSjgtX40PT6Mh0LhYsI8nLgAJeOs27GUgXhDQXBUUQfrPKQ4tNIs/skPVVd7BuaQJ9Ptl9twvmFlrNUC8MH2v6397WzHTRJb2joeOJ+hYTmkwWFxc5v3bAeLT4qhyL2OnvP0xGhprXrmyDC6z8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734380004; c=relaxed/simple; bh=G4qyJ4T2+Mw8CB2FJ++y7NvEzFOTYgilqb9SFDaYviw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eCjgOWq8xzU2bCzmEb2FQ0Zu79jM301TgtzEvLaKhN7TtGv09LSZ0wZBwgTeh7xBmPx8MP484DXJqQbBmLHA001KOv5FU5QeLr9JBHA2U+M8dw5oSXfsiNBsDrmKecaYWtjFdDZh+Zj0ib4zj5sxrPfPe8iuQ+mc6iY9LMgwMmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=UvmFOb72; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UvmFOb72" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4361e89b6daso31620355e9.3 for ; Mon, 16 Dec 2024 12:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734380001; x=1734984801; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sjXZeEiyAKD8VfYmqGcOYaYcyWg1RcYgwrkfT5jxudY=; b=UvmFOb72vREdFk7z9DPKw7wtz55tJfkehHH964hlK+BkEk2J9pg2svopDs4yvXrMB+ S1TrEkHlQJUoqXbCyNjXGzWzygYaOnMqK5Y3O4zEPq54MgYiq72d/g+U/A/I24jLuHKB pIkF6krC1sBhSa78cfpWs5tJWT6wNlB7S8KmQKUJeiZis7li+veS9pPCWkBCyyxAUWCv /kONfAXduFSmEnZKuqrPrDNTE/SkXsh0qnnBv4EmgdtynVxOrPxH+iye05uunKxBup0J E20hanFlnUiU0ZSejs3v5OFJtwW5USvA0FEK6M3n7ZZYh3O3ZlHtyIRs3E8vgitP0ePT GDDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734380001; x=1734984801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sjXZeEiyAKD8VfYmqGcOYaYcyWg1RcYgwrkfT5jxudY=; b=JcHOJAN2t87O075tlVOoF22Ov5WQhCHBA9KOgLkZ/P3DzFTvBfKNWYYDfnbIFl4B7A RZEq7FG3J0CHs04P22YVre5eM+BsqKfu8f8tzXwE7UyKua1aGaL9cs4hpXwSlcfoB2Ds bkyTNlqEmseUQLsrgYOU+zuk0JFFcA1qxnPBfMHrNfX0ACHdlyc24stDRYuU2cvnnNEH aTxngscNJduRJlbmdHtPL01lDW9v7fFJJhGRKv26AGfQe2yJ9WMjLxy7PL+O2tV/1aDl lgmISGclZsTvZxc2ooJpwIByFk25uTdvvkv+uzxgENLkWZ/tTRtZ1RrAjpOLXJHsgpvJ ToRw== X-Forwarded-Encrypted: i=1; AJvYcCUq5MNQPMq4uq402YFRBNeRVnFr9cjQmBlkr8QDm+dTeYA/b7k+hKz+6gBbctXS7DQyfn6nNOT3isXAd7o=@vger.kernel.org X-Gm-Message-State: AOJu0Yw46fiSlzSsg+gHEj0fo5JVjSwW/2ZA9oA+Io4icD4YTB+EF4vN PSD4cejWhK0MXQrmVuxmTjsyekIovnzCrgHz/PbDeqRblw9TBQJ34P/NjcdALFo= X-Gm-Gg: ASbGncsg0q1pxhxmgUfNIXnrjvCEPG6NOsk/28rzg76X27SgyNv4gorIQt9qLtlos60 kjZjwUU5gWV8ddxs9cKpYrycPL0MmshlTHb7XLlwLvQaRXi/Oq8hnCi+i4JB1+OFgWY0hDYx06N AysaOKDfNmSLAjpJTprhE9yfWeZ3KLTzcbYrjBAuNw6X5kGMp//L/tvdRb/qqaPJZCF0wlczpKU kZYvCkBkMtQbqnmCF1fPhF8XMYdlZHaQAcO8nXEkytprWbpQAWVMggKNg== X-Google-Smtp-Source: AGHT+IHvg2JySc6luFarg1m27oTMM9k7iAcd2BNt3xfcXvFaFYd51oqzF0i7hhs76tRKRCR7w1DFoA== X-Received: by 2002:a05:600c:3109:b0:434:f953:efb with SMTP id 5b1f17b1804b1-4362aaa208dmr110458345e9.32.1734380000716; Mon, 16 Dec 2024 12:13:20 -0800 (PST) Received: from blackbook2.suse.cz ([84.19.86.74]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4364a379d69sm473715e9.0.2024.12.16.12.13.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 12:13:20 -0800 (PST) From: =?UTF-8?q?Michal=20Koutn=C3=BD?= To: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Frederic Weisbecker Subject: [RFC PATCH 9/9] sched: Add annotations to RT_GROUP_SCHED fields Date: Mon, 16 Dec 2024 21:13:05 +0100 Message-ID: <20241216201305.19761-10-mkoutny@suse.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20241216201305.19761-1-mkoutny@suse.com> References: <20241216201305.19761-1-mkoutny@suse.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Update comments to ease RT throttling understanding. Signed-off-by: Michal Koutn=C3=BD --- kernel/sched/sched.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index d8d28c3d1ac5f..5c32c23915810 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -812,17 +812,17 @@ struct rt_rq { =20 #ifdef CONFIG_RT_GROUP_SCHED int rt_throttled; - u64 rt_time; - u64 rt_runtime; + u64 rt_time; /* consumed RT time, goes up in update_curr_rt */ + u64 rt_runtime; /* allotted RT time, "slice" from rt_bandwidth, RT shar= ing/balancing */ /* Nests inside the rq lock: */ raw_spinlock_t rt_runtime_lock; =20 unsigned int rt_nr_boosted; =20 - struct rq *rq; + struct rq *rq; /* this is always top-level rq, cache? */ #endif #ifdef CONFIG_CGROUP_SCHED - struct task_group *tg; + struct task_group *tg; /* this tg has "this" rt_rq on given CPU for runna= ble entities */ #endif }; =20 --=20 2.47.1