From nobody Sun Dec 14 19:13:58 2025 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2BC6A1CF5DF for ; Mon, 16 Dec 2024 20:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379921; cv=none; b=aI9pm+o0iPGthqaUQiXSPKcynlP2KaYx+eoBeCK3es1AQwNV9p5x6HsJOo8wYh/6AzIHibVlR7ZchaQC7PUAst7K7AJSsnlfjJSMjAuuh+/fBpLJgW3tDieyuepy7Z2qkfhRqCuosNr4DXI8FqRaA3qww8KKUInsMsrxMDPZhpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379921; c=relaxed/simple; bh=7jxU4hpAwSWmevfX99YkDoTD1JGxKAVZgzPD8jgn35M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XCHt8Jbl8phvdbYMLVkf9iWvFQCbrS8rWe7Sbm4b2kjYQsY+nLaqPHgBvQXAWs7VdfNfIqzqL+ieSkRrmA/hWGS5BVJo1n3wfNZd/xP4e0u5jrmWE/1wouY84613e4P+EQobyUWub5kWq3PfoUnP/HffBxq1thEVUWKwxNpvLro= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CNdanyNU; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CNdanyNU" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-801c8164ef9so2283053a12.1 for ; Mon, 16 Dec 2024 12:12:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734379919; x=1734984719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rqa++bQfJwX3ua/s3cRo3Ckug/2w2jf2s5usPRs7cJ8=; b=CNdanyNUq4OPpiruLbQnSyqtd0ycqSKEQxMIWRqYCAScBtfZEnK6Tjy9U3l7hErlNH tIgU500AGccqO4DY3FmhY6Tvk9j6RTNs9C+AJE/ufTzIjYMCqvZ0HzdpaojP2FrhRImq 4ZJu5yKy6pyFMHRA//y+PJflXxBL4BCEaczSo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379919; x=1734984719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rqa++bQfJwX3ua/s3cRo3Ckug/2w2jf2s5usPRs7cJ8=; b=CSrn5Z6DbTWNDjZkiyHje7kb87dzXcAUp6Fc7A3Fn/qT1cu58/6AAaqacEXEDQxpDl nTjwDAdYS16Gvb7DEaJB72qqHjSv0t3p+LsCGdhXmAyFtnBz3vDWX95zN7QqA99VwDBw n/sMmyVbjSRJR/kela4t/57MrFrYqdGgMY6YzkRdZW1cgcSNvGiHoqcYX/FRVMVizUfe Pt4hUc+DZx0I3fgYmtnzkSfCI9YYhd4htpHk0e8q7PCpqDR57ZRtm6as+d62PJ9TSpkH j+0sdwb8jA3g93SVYprIU56PMvuV0rhZEVWj+zQrpvGy4utXRqgqqd65YRCCtzYsuQjo aAMw== X-Forwarded-Encrypted: i=1; AJvYcCW8hrvaBq1W6TzTDcVCyGEiAvQyAnjFZpWJkY/I6sDpUKiWrQkuaZkI8Hlr71ga56ENqieuL8MzRG3n0pI=@vger.kernel.org X-Gm-Message-State: AOJu0YzdHwRctrmG2EbO5lkT8zwWR/Br2uE+OTRjDoRwl1VkJAxbBluJ 00larl4YxiL4yIsH+PJB75W4ekp13Tucdphnv4W2hPz57lior6rPiM3H7pSsEA== X-Gm-Gg: ASbGncutHw+5Q37c3AHCXN+FRe5yv7J/HsMbgLHPldBVFYQH5JebmXb/OHWqMFTDIym T7cH6ScYFlYAFndGpZfPPT8DrvFycbJMnDkRgXzxpPuXG6NVSnQkmMKpHL0PxOOVEBKnocJMMEG Wyu4J9tV8O7CVxIIxSNEN+157oJuPugASLGeSCurGKJOObgrBBzYymnH8K4ALUYe/uRrEjrYHBE LYHRxPssNR7+27nCNTzqnwomkUS2QhsmR57b4DhvoaNm9qdBWSnFOZf7XPGCNsuTQbwciN5g108 3JleyRczJv5HP+nthg== X-Google-Smtp-Source: AGHT+IFgqfe+kqsUtZy9+xGWMGhOgzZuAgj5lfe6mAr4/ZjzImfvHLnClnHam5X0h2CYqu1MJB3xkw== X-Received: by 2002:a17:90b:51cf:b0:2ee:c30f:33c9 with SMTP id 98e67ed59e1d1-2f2d883bf1emr990096a91.14.1734379919583; Mon, 16 Dec 2024 12:11:59 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:953:5b91:a52c:e817]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2f142d90bcdsm8423943a91.5.2024.12.16.12.11.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 12:11:59 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , David Gow , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Brian Norris , "Rafael J. Wysocki" Subject: [PATCH v3 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Date: Mon, 16 Dec 2024 12:11:42 -0800 Message-ID: <20241216201148.535115-2-briannorris@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20241216201148.535115-1-briannorris@chromium.org> References: <20241216201148.535115-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, and the source of a few bugs, such as the one fixed by commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). It's hard to imagine a good reason that these device_match_*() APIs should return 'true' for a NULL argument. Augment these to return 0 (false). Reviewed-by: Rob Herring (Arm) Acked-by: Rafael J. Wysocki Signed-off-by: Brian Norris Acked-by: David Gow Acked-by: Shuah Khan --- Changes in v3: * Add Rafael's Acked-by Changes in v2: * Add Rob's Reviewed-by drivers/base/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 94865c9d8adc..2b7b13fc36d7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5246,13 +5246,13 @@ EXPORT_SYMBOL_GPL(device_match_name); =20 int device_match_of_node(struct device *dev, const void *np) { - return dev->of_node =3D=3D np; + return np && dev->of_node =3D=3D np; } EXPORT_SYMBOL_GPL(device_match_of_node); =20 int device_match_fwnode(struct device *dev, const void *fwnode) { - return dev_fwnode(dev) =3D=3D fwnode; + return fwnode && dev_fwnode(dev) =3D=3D fwnode; } EXPORT_SYMBOL_GPL(device_match_fwnode); =20 @@ -5264,13 +5264,13 @@ EXPORT_SYMBOL_GPL(device_match_devt); =20 int device_match_acpi_dev(struct device *dev, const void *adev) { - return ACPI_COMPANION(dev) =3D=3D adev; + return adev && ACPI_COMPANION(dev) =3D=3D adev; } EXPORT_SYMBOL(device_match_acpi_dev); =20 int device_match_acpi_handle(struct device *dev, const void *handle) { - return ACPI_HANDLE(dev) =3D=3D handle; + return handle && ACPI_HANDLE(dev) =3D=3D handle; } EXPORT_SYMBOL(device_match_acpi_handle); =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 19:13:58 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF16A1D4359 for ; Mon, 16 Dec 2024 20:12:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379923; cv=none; b=J/PolcifwzBhHcW9vfObooMWZIfsA/ahQ2IRoinJq8WJRv8+3VcScvYXFIWUQ6QqT28JEpa+5EC9yjDpz1cVsGWkGFKcHATZtWdum/V01F8xomQGUyDjsUMUmajpQaqIqxRkLj+PRrSp3LB/EdkKXfTaWzZhzd6KE6MESky882g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379923; c=relaxed/simple; bh=wcShxfPbnClrISO1dAhdVjYKxC3gZhQzGp9ty+s6tng=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=heF5oXSV8ad15AsicuSN1cfsJem07HD4ZC9CNOYHFG/GxtPz9Kee83Zj6tx6KlSMQ9dstWx7D79p97cDfGjaUd8w3TdlzpYj8ukJ8e+SCfUPlHmzy8XJCeQRZW3NYCt+dfsC4nytIHDqo1LAQWO3Ae5slhgj0sWUsLvXDmpq18U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CyxHrd6Y; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CyxHrd6Y" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-216401de828so36142985ad.3 for ; Mon, 16 Dec 2024 12:12:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734379921; x=1734984721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fBk1B/iGfmqWsVYAcS6S50yqQBfz2Y6wZFszhj2EhmQ=; b=CyxHrd6YQF7GWWJ2k+SbX9xh/haSR7y2Ih/2Mi4+Xv/ldkmYPGVqY0UUGK0Qys90lB HRhKFYcYEKnMdMV1aCFGCj2x0xOZwJb6vYkTy95JQo/ArvScjPor5GVmQEyTaoR8pgCn DgRWUHzdCeEptJR2TRwOt6EzatwUofbxcxqyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379921; x=1734984721; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBk1B/iGfmqWsVYAcS6S50yqQBfz2Y6wZFszhj2EhmQ=; b=TuC3D6jwAPt7hIj3xaK9g+k1MoCegDX0CBRCHPM+IqoLu741gO/L/v4DlBRc3huAun LVRRaneaao7AkLuICqVf0RpzuD/wvsAEZQzQSLponUJqOlfefeH/7ijzvNh+v2Jf5rcr CSfAIwC4xTD1YKDDcsjfF4EkcMhmqs3lVZ+ZD9Kp2LIrS/pibFE3Ua41WuIpZZWnA4o3 inVroRuRv5EQNqcJF7cAiLCwSbIzWVyyCLxJh1vMxum+0Q7BtdHf2rqYL3YxE0ApqJii 7nKS6D9mrxvpb4hZNzCB3nKkkUauVnGpkv9M4jT1R8nVQ9XLkNvBs5CCkGqIS23nxZFj o8pg== X-Forwarded-Encrypted: i=1; AJvYcCVbYsqFt5/OnK+XeHFDXiR/2RNNEi8+DZK65/SZEr83oci+tcoE1tbWKmJrEG2BEA6/itaD0wMmpJb6mbI=@vger.kernel.org X-Gm-Message-State: AOJu0YycrBuOdifXlpy78tNsbld7ouRqW1ShoX/mtVBbXY3vdFZTA8lU jc5IEVpoUg4nCb/72L+7QbPAcv8l3AHk9i/bHaKiZCMGKXWTnYyU/eDtj8GQ3g== X-Gm-Gg: ASbGncvjfKWHSZboSTa38uUORrZNpap2s64BZPTX33RYoEzYf1DjhchC3JQKDLSLzDr UxwDMVvbMY4ZGMy9cDNLkyssylvf7kmhtMCknoT7G5UhL02+9aP2mrMtdPs8ro40JHtwo8jJo6F epJ32RhXXMJHNncmv/FkNKk456zuRHfaezo4UnOeqi7yGHsaPJ8RFUfRQnAOdIcqBlBCSZ4ulZM 0mD/l1KLfvhz39Hl/onHgxSgCHyUyfQ0TMpa/pDzwYYWZgKbT9yuOixqsr87QmE3ZfIoufXKeDI jY9X0PR1VTx5zkn4JQ== X-Google-Smtp-Source: AGHT+IF2iv9Je95U9OGbHT2oN5GIgDqe2UtAMFx/DSAMFSH7IN0Tter2gRXLrFhHCS1ZV+etVrE7DQ== X-Received: by 2002:a17:903:3256:b0:215:7faa:ece2 with SMTP id d9443c01a7336-21892a4177emr159121845ad.35.1734379921239; Mon, 16 Dec 2024 12:12:01 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:953:5b91:a52c:e817]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-218a1db5883sm46591995ad.41.2024.12.16.12.12.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 12:12:00 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , David Gow , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v3 2/3] drivers: base: test: Enable device model tests with KUNIT_ALL_TESTS Date: Mon, 16 Dec 2024 12:11:43 -0800 Message-ID: <20241216201148.535115-3-briannorris@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20241216201148.535115-1-briannorris@chromium.org> References: <20241216201148.535115-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS. This enables these platform_device tests for common configurations, such as with: ./tools/testing/kunit/kunit.py run Signed-off-by: Brian Norris Reviewed-by: David Gow Reviewed-by: Maxime Ripard --- (no changes since v1) drivers/base/test/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig index 5c7fac80611c..2756870615cc 100644 --- a/drivers/base/test/Kconfig +++ b/drivers/base/test/Kconfig @@ -12,6 +12,7 @@ config TEST_ASYNC_DRIVER_PROBE config DM_KUNIT_TEST tristate "KUnit Tests for the device model" if !KUNIT_ALL_TESTS depends on KUNIT + default KUNIT_ALL_TESTS =20 config DRIVER_PE_KUNIT_TEST tristate "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 19:13:58 2025 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE2211D3194 for ; Mon, 16 Dec 2024 20:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379925; cv=none; b=IgXbhMmx4UQdm908niO0HoN/CIO4wwFT+6fQIWMIP4Fm6VaJpts1uEA8QvCCLBt361svH7i+OlNNYq27Ve7HPI2h01cvbntPuoxze5UY9XB+tp7ZhUrGHTctTqVROankXMDc5FXakBfuneQo1AEUeOpJsVNh7/yc2eiBG1NUGWY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734379925; c=relaxed/simple; bh=H6OpmDmtDpO2Zw9oPoveIwfU5S4mQl0QvewtjG8lnI8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Nc4fRtVcwkKd62aZ3T4zqDmWdUfdYY9TtWvYMq6Iv7QAKb/vqgALjItYeUP0qWH6vKmcn3/sE88TWY4haeTUfQoPX+7hK+PhqTEwbLtUbKcxF4o+0GZNjANN0Fc22/YR/q2LmC3QS22icR+sxN1qKTBv4ssa2JuMgzWBzSegAuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=idTMj13b; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="idTMj13b" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2ee67e9287fso4077081a91.0 for ; Mon, 16 Dec 2024 12:12:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734379923; x=1734984723; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=djvMV74okcAY/0lAlFHYz0uZLVdKOBaTEOPTBRi9sN4=; b=idTMj13bH3WLlPjKnPfPxQy6icNRx5Eo3xCf847jUnA8aJR7pZcF3bHgB7K9qR2o09 3vmWy6pB9uazkqDyc/hromm4TA8eu9D3LlTPfjlTeO7GhjHNABLwnLtMZgKpGIupCQOp nBwkiWGsGGJHuB25kMdKdDK/Vr4yvvJ+VLXHE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734379923; x=1734984723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djvMV74okcAY/0lAlFHYz0uZLVdKOBaTEOPTBRi9sN4=; b=QS2EsiyUZsdBFeRJmdUPxglFS2thA6YtJHBW4NwZ5jj2+8kZ8O5J1pRyxK5LpMUPpN yu1h0KXUc7Jj7ia8pnP8kSjo/+WDK8NYT4+G4n7bEr0hRwBRMgwo8V+vD/Rmy3lZiXh1 xAuM4nLgUbAAW2V+XRsZ+msrAbkF+78aegz5CzApMHd/7qM2w7RSeTq5JyTC4VANISgc 1PWUIWqnqdaFCjMm4xsErr4tKoqevvK1bH8sl7yb/FQr6llbWdBf2NR7GfjbE6Jm6Ygs 9Vz5/4q11Gq7STbrrQtxueOa95PAG48cmg0mQnJ2K0LFCENPsp69e9pFHuaJOtGQYzQR 0Qaw== X-Forwarded-Encrypted: i=1; AJvYcCXhopfsnwq839SOiUcwhLDH2p4HGtnygNOHO5RS0QMATZH1/A+OevG3g00eURo89Qlg0wfxH0Pl/IvUeK8=@vger.kernel.org X-Gm-Message-State: AOJu0YxkgTBTBcug5CG1aXi9YIFgJaLndG51bqMxryQLGgm1CCTHKsXY /XPj7w3fX1hzgZ1k5wPT6RVj2TVEgOAE6O30I5JyrJNrb6M2okeU2Pa3qeSpsg== X-Gm-Gg: ASbGnct1J0sfO4BSwkXmEYCiztELVuAQsibpoTtD664VyqM6LPP7ZuqXn1yND1QlCFF 7IVinvwfABTNIeKWEuEiIao9FLrYDBLSvDV8mZk96g0WMOC0EbxS8BMqMtgtr//Pc/ILJ1LiPJ3 660lDWrg7R2EOMG+gJ8lgXmhkRsmuUavO3/Z3EWCdSqVbWbOJCq8GdHtp958N/M/zEN0NG8wRaq 2/OxgRn3RcaELnZ/Ao6r3h8knazFsDBFEH8cgqEKKUIYMwTNc/UUzKyZqEPtfpMFOM6NY+1qu4t TGZZ2yluTmypJzWqBQ== X-Google-Smtp-Source: AGHT+IEis0SU953jTVyxT2H0yo03Me4jIuEsbijattQtH7vbZS2FTiO7qBvoO1t0qS6vmyUZ86ypdQ== X-Received: by 2002:a17:90b:180b:b0:2ee:dcf6:1c8f with SMTP id 98e67ed59e1d1-2f28fb71a7emr22546306a91.16.1734379923047; Mon, 16 Dec 2024 12:12:03 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:953:5b91:a52c:e817]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2f2a1e7e07bsm5122503a91.1.2024.12.16.12.12.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 12:12:02 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: Maxime Ripard , linux-acpi@vger.kernel.org, Rae Moar , Rob Herring , David Gow , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, Brian Norris Subject: [PATCH v3 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests Date: Mon, 16 Dec 2024 12:11:44 -0800 Message-ID: <20241216201148.535115-4-briannorris@chromium.org> X-Mailer: git-send-email 2.47.1.613.gc27f4b7a9f-goog In-Reply-To: <20241216201148.535115-1-briannorris@chromium.org> References: <20241216201148.535115-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We recently updated these device_match*() (and therefore, various *find_device_by*()) functions to return a consistent 'false' value when trying to match a NULL handle. Add tests for this. This provides regression-testing coverage for the sorts of bugs that underly commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). Reviewed-by: Maxime Ripard Signed-off-by: Brian Norris Acked-by: Shuah Khan Reviewed-by: David Gow --- Changes in v3: * Fix potential leak in test error case * Add Maxime's Reviewed-by Changes in v2: * Keep "devm" and "match" tests in separate suites drivers/base/test/platform-device-test.c | 41 +++++++++++++++++++++++- 1 file changed, 40 insertions(+), 1 deletion(-) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/p= latform-device-test.c index ea05b8785743..6355a2231b74 100644 --- a/drivers/base/test/platform-device-test.c +++ b/drivers/base/test/platform-device-test.c @@ -1,8 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 =20 +#include #include =20 #include +#include +#include #include =20 #define DEVICE_NAME "test" @@ -217,7 +220,43 @@ static struct kunit_suite platform_device_devm_test_su= ite =3D { .test_cases =3D platform_device_devm_tests, }; =20 -kunit_test_suite(platform_device_devm_test_suite); +static void platform_device_find_by_null_test(struct kunit *test) +{ + struct platform_device *pdev; + int ret; + + pdev =3D kunit_platform_device_alloc(test, DEVICE_NAME, PLATFORM_DEVID_NO= NE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret =3D kunit_platform_device_add(test, pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + KUNIT_EXPECT_PTR_EQ(test, of_find_device_by_node(NULL), NULL); + + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_of_node(&platform_bus_type, = NULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_fwnode(&platform_bus_type, N= ULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_acpi_dev(&platform_bus_type,= NULL), NULL); + + KUNIT_EXPECT_FALSE(test, device_match_of_node(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_fwnode(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_dev(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_handle(&pdev->dev, NULL)); +} + +static struct kunit_case platform_device_match_tests[] =3D { + KUNIT_CASE(platform_device_find_by_null_test), + {} +}; + +static struct kunit_suite platform_device_match_test_suite =3D { + .name =3D "platform-device-match", + .test_cases =3D platform_device_match_tests, +}; + +kunit_test_suites( + &platform_device_devm_test_suite, + &platform_device_match_test_suite, +); =20 MODULE_DESCRIPTION("Test module for platform devices"); MODULE_AUTHOR("Maxime Ripard "); --=20 2.47.1.613.gc27f4b7a9f-goog