From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D29841D45FC for ; Mon, 16 Dec 2024 21:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383847; cv=none; b=k7FkWvDs3XGmWsznE9VvAMpu5Cr768GeCzmYm5HUjkyx2vvvLC9sD0Pnhbwey6kgM4VDtvv+XRzKEjhMVVn7WdWJ6TpIUufjppoYGXtC/5cyx8tM/u+ME1yNJY2YSIK/UvKBvT5XaYLFDcXitDycA3TtI5z2O0mhBPzB88ts9fg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383847; c=relaxed/simple; bh=kKwZloJ+pxiytz9zfwyv5msK5QwJz26A7aW8bSu0I3s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hvEvS36u5OGzuqe+VhZmaTAZXkrB2SeaEqZTpJclhrcn2l5AiibWLQ790bxEW2FcGvFJnSC5kpfCd7G4nV3ERjLFLRrbIBwtDpV9W/Hb3IOlvXOWNOQ679fAnrrPvWWMEeiI7+MZ1Jr2iXcpvxa1VnR22v1zZjtV2QGGFdMYiHA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=RirRtlIs; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RirRtlIs" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-46792996074so54146771cf.0 for ; Mon, 16 Dec 2024 13:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383845; x=1734988645; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kM2B80UZkeR2LPczGOfVlIBqSwSauWzJe2cC0H2QDRc=; b=RirRtlIskXwmaHipMITx24EyeCZsFaL6QXksT07tn27TpSzPZLiLexMe/AHK5oulAU J5mQxx7d268giF+o/uF9Qmggcagd+VNuPUu6p6Mww8FdZ4Ao+PCnALLzulW0N/kNNNaD eXDLvJ0+QHlHtKHntzuTQqEsEctSu9LdG+wfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383845; x=1734988645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kM2B80UZkeR2LPczGOfVlIBqSwSauWzJe2cC0H2QDRc=; b=H3WDEzOAmX6RvUjDjkNW3UqueHjfjfZIoZdaBsRsXWiVJUPtlbWh6M2ODlMMHwvRKE oTLe80DARHdsv3xZxPzjLfN4wLBc07Hytod/SDioI2+cU3riJ1KDKfM/68hg99Io7LXQ GRbHZt84gJ57aCCYaoDLnvisZASty8UStiWC4jSrtkI53fSmcHHo5oMxD8MrhKIiVDJo erp0Ak3NT1bDaZHvkd2fh0RM1epcnXinB3e2sTXet/EtsRw8E4NKHVA4I90pPeXEERYr QM8Ge0mDY4j2ZgxOgY0zHdxxhk8DDA4sX6032vuIvakGil+nHja0qwhlFF916W0o1qVk LklQ== X-Forwarded-Encrypted: i=1; AJvYcCUt5EWipE2LiIvli4hyM0HgzigPrkqjisXZpGYm8bH0ABj3UqFlNETmGy9Cs0ap3CgMuioQKLS4OVBzv/o=@vger.kernel.org X-Gm-Message-State: AOJu0YydAmfx5iDc2I3ToQjivR+EqA158l6cHPi4ECfsFFlfur6BChVQ GzmpxVboSythbs9/421d18UMR8E6iXsJymF/7Ql3cKLK4uGPebRlUGOpb6X7sw== X-Gm-Gg: ASbGncudPJf9HTF8+rEJkgTsUFlzqZttqPleLy1hgtgreUnnlzG8+j9nNP5cdqiZrRA EV2UIAIR/u9dxCMhnqGTUg6OKbswEi7cDKRPwTo6xxioz3bDVr+kzPQG+pEU64cALf7TWJZ096l LKGw3U9Whfp1hroYGxEdsj7kTWMRL7DYHji54klBl4SpcXU3ajN71plzFBXNmJEqiIDfb0dR4yJ dCmMwvly1a8VjD9TdKbt96V2H8ZCKxlE03npr+m7BvHuUISFBhNYvOOyDAkiTNJMdssH++y/NdA SNQXAAg2BDhNuuc020pUzl7kJ+vVIcc= X-Google-Smtp-Source: AGHT+IHSGnqI6FhkQaL0069bHSXiDXW28qApI4WsVyO7HAsa7gVNw+XbMJ7VfZy9PvrVRyRjuC0jMg== X-Received: by 2002:a05:622a:1487:b0:467:45b7:c495 with SMTP id d75a77b69052e-468f8ad232emr17931231cf.15.1734383844801; Mon, 16 Dec 2024 13:17:24 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:23 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:15 +0000 Subject: [PATCH v5 1/7] ACPI: bus: change the prototype for acpi_get_physical_device_location Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-1-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda X-Mailer: b4 0.13.0 It generally is not OK to use acpi_status and/or AE_ error codes without CONFIG_ACPI and they really only should be used in drivers/acpi/ (and not everywhere in there for that matter). So acpi_get_physical_device_location() needs to be redefined to return something different from acpi_status (preferably bool) in order to be used in !CONFIG_ACPI code. Suggested-by: Rafael J. Wysocki Signed-off-by: Ricardo Ribalda --- drivers/acpi/mipi-disco-img.c | 3 +-- drivers/acpi/scan.c | 4 +--- drivers/acpi/utils.c | 7 +++---- drivers/base/physical_location.c | 4 +--- drivers/media/pci/intel/ipu-bridge.c | 4 ++-- drivers/usb/core/usb-acpi.c | 3 +-- include/acpi/acpi_bus.h | 2 +- 7 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/acpi/mipi-disco-img.c b/drivers/acpi/mipi-disco-img.c index 92b658f92dc0..5b85989f96be 100644 --- a/drivers/acpi/mipi-disco-img.c +++ b/drivers/acpi/mipi-disco-img.c @@ -624,8 +624,7 @@ static void init_crs_csi2_swnodes(struct crs_csi2 *csi2) if (!fwnode_property_present(adev_fwnode, "rotation")) { struct acpi_pld_info *pld; =20 - status =3D acpi_get_physical_device_location(handle, &pld); - if (ACPI_SUCCESS(status)) { + if (acpi_get_physical_device_location(handle, &pld)) { swnodes->dev_props[NEXT_PROPERTY(prop_index, DEV_ROTATION)] =3D PROPERTY_ENTRY_U32("rotation", pld->rotation * 45U); diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 74dcccdc6482..93d340027b7f 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -723,10 +723,8 @@ int acpi_tie_acpi_dev(struct acpi_device *adev) static void acpi_store_pld_crc(struct acpi_device *adev) { struct acpi_pld_info *pld; - acpi_status status; =20 - status =3D acpi_get_physical_device_location(adev->handle, &pld); - if (ACPI_FAILURE(status)) + if (!acpi_get_physical_device_location(adev->handle, &pld)) return; =20 adev->pld_crc =3D crc32(~0, pld, sizeof(*pld)); diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index 6de542d99518..526563a0d188 100644 --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -494,7 +494,7 @@ bool acpi_device_dep(acpi_handle target, acpi_handle ma= tch) } EXPORT_SYMBOL_GPL(acpi_device_dep); =20 -acpi_status +bool acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld) { acpi_status status; @@ -502,9 +502,8 @@ acpi_get_physical_device_location(acpi_handle handle, s= truct acpi_pld_info **pld union acpi_object *output; =20 status =3D acpi_evaluate_object(handle, "_PLD", NULL, &buffer); - if (ACPI_FAILURE(status)) - return status; + return false; =20 output =3D buffer.pointer; =20 @@ -523,7 +522,7 @@ acpi_get_physical_device_location(acpi_handle handle, s= truct acpi_pld_info **pld =20 out: kfree(buffer.pointer); - return status; + return ACPI_SUCCESS(status); } EXPORT_SYMBOL(acpi_get_physical_device_location); =20 diff --git a/drivers/base/physical_location.c b/drivers/base/physical_locat= ion.c index 951819e71b4a..5db06e825c94 100644 --- a/drivers/base/physical_location.c +++ b/drivers/base/physical_location.c @@ -13,13 +13,11 @@ bool dev_add_physical_location(struct device *dev) { struct acpi_pld_info *pld; - acpi_status status; =20 if (!has_acpi_companion(dev)) return false; =20 - status =3D acpi_get_physical_device_location(ACPI_HANDLE(dev), &pld); - if (ACPI_FAILURE(status)) + if (!acpi_get_physical_device_location(ACPI_HANDLE(dev), &pld)) return false; =20 dev->physical_location =3D diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index a0e9a71580b5..6cc2614b8f86 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -259,12 +259,12 @@ static enum v4l2_fwnode_orientation ipu_bridge_parse_= orientation(struct acpi_dev { enum v4l2_fwnode_orientation orientation; struct acpi_pld_info *pld =3D NULL; - acpi_status status =3D AE_ERROR; + bool status =3D false; =20 #if IS_ENABLED(CONFIG_ACPI) status =3D acpi_get_physical_device_location(adev->handle, &pld); #endif - if (ACPI_FAILURE(status)) { + if (!status) { dev_warn(ADEV_DEV(adev), "_PLD call failed, using default orientation\n"= ); return V4L2_FWNODE_ORIENTATION_EXTERNAL; } diff --git a/drivers/usb/core/usb-acpi.c b/drivers/usb/core/usb-acpi.c index 03c22114214b..935c0efea0b6 100644 --- a/drivers/usb/core/usb-acpi.c +++ b/drivers/usb/core/usb-acpi.c @@ -213,8 +213,7 @@ usb_acpi_get_connect_type(struct usb_port *port_dev, ac= pi_handle *handle) * no connectable, the port would be not used. */ =20 - status =3D acpi_get_physical_device_location(handle, &pld); - if (ACPI_SUCCESS(status) && pld) + if (acpi_get_physical_device_location(handle, &pld) && pld) port_dev->location =3D USB_ACPI_LOCATION_VALID | pld->group_token << 8 | pld->group_position; =20 diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index b2e377b7f337..19f92852e127 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -43,7 +43,7 @@ acpi_status acpi_evaluate_ost(acpi_handle handle, u32 source_event, u32 status_code, struct acpi_buffer *status_buf); =20 -acpi_status +bool acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld); =20 bool acpi_has_method(acpi_handle handle, char *name); --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 313331D5165 for ; Mon, 16 Dec 2024 21:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383848; cv=none; b=TI5wGI+NULNMXH1xwANYHtig/b7rZKc926ZrF2CmMdja7/PnA9oeAZ4NB1OgffdSyqWskVN9a+4YSwBxKDg8WOwm2ly+cY/pw5g0mC0b5wxSl6b880TKjqEATYE10iUl1E65fqudMUzFT6VXxkUQFJFOcdpw2AFuwZqInpTmOo4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383848; c=relaxed/simple; bh=e7SFMwzDWsXgzO/ZNzsWTCVExP8H4avRE4Psyn2EYBU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lbZlqkvhlP0ETCopVsUqQw9UsJ81lK/o2eENSicJvB8L0/2U8RLYuejPkAONBnJVEOF322j4yX24eHNPxTUXm2d2LQkZohgccXkiZrS8COA560V0MItpXRLGvsh5+yMH/va94j45jkPJUMpQszdcQKuNBdqEWAaLqqW9bWXd3oU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=i+n7Bm4s; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="i+n7Bm4s" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-46772a0f85bso40897811cf.3 for ; Mon, 16 Dec 2024 13:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383846; x=1734988646; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Wrx/XZpVy8CcSfrt0QCmmOTT7oU2GR+FF7o9rBsUVb8=; b=i+n7Bm4sReOYy2is0Ik2ld+rfDnMgcXNbiTuFJ1dnSXDVn3+nUqdzXnM4x2DVcAuj9 6QmUyC5Ak9ZyJ60EkyD7e1aDHLcbwFvuVbSDl9sfmnEpeDRHc0MTSMemosc9KEATuTj0 1k1dFsHB4MThXVJpPJt6OAQrErapz1VA+sCFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383846; x=1734988646; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wrx/XZpVy8CcSfrt0QCmmOTT7oU2GR+FF7o9rBsUVb8=; b=suMVz9qcCpN4rXZmtiGAFgQW4m6QCxWYmoPOzeEmTRC1KRkgL8I+ii42r/boJ3j+se 66jGC5nbj9Es0mQjSoo37rw7Zf8k5nXBT8LvBOeNf7egzoETgo+kuZmJFRpo25v6/PGR 1kds6yKgX8MCNrKgqcNJNAfmPrvyU8QEyadEAb5UENybOp8uLxkWh6K6XGNTQywqvNg4 rAc6ZEc0lptrXUjIVADeNfiVjbL7kj926BitS9FJ+8o+ivwPaVquVT1DND/++8gyjV5L oWY7o0JKznQOn9JCIDq45OccKQx2sxRoDHFBesesNc+SGqUL0cbfFGyXEkHVuuUl86ex ZoRw== X-Forwarded-Encrypted: i=1; AJvYcCUGkD/vrUg/QtjvOp7roXpEXNK/AVutbFiNUSp/BlGgfeyXUYbF7JSenLTMe2Fj7nyHCQqZcsnSfG0vCek=@vger.kernel.org X-Gm-Message-State: AOJu0Yxo9eFBA+8yKFu2SgzZsLNbSWa4X5cHO7L36A+CIIro+m4SgEeo wunQcSQ97A/tzYgUoQtCm43gxgm6yNR1xUknnu5tl0sz3K6j5OIbcc1ch8UxeA== X-Gm-Gg: ASbGncu8PaRVRJYHAkGOmwJcAuvHJUgDfSSzYU5cy+lEab4SVwUGB2p6TkSqlqu2rc1 vzovQmxV04uDePRWymid//V8lwOkIri3k24z+zftoGrUOc6kZxJoZ4y22zVR1MIigjtDSTZSYy5 vsRus3M3Yf2nFqw6VcEcHul7Jjk2/cDgGsUpyvlRh1jA52Uy6il0bCCFvqiqeCQQVWc0Ob2qLo9 w72HNTmhRkUDRcNtiFUyn+ZZMf/FNMNcCxR2NlZrmYCr62f2t08nQHOUS0YL68T4hhE2+t6nl/d fJgylEG5VyBsMnI4b/w4msAZjzxDZvk= X-Google-Smtp-Source: AGHT+IFe0W9f2W39cOFyxGiYpi+wHrRevZyo7XAuH0Mr2XhLF/7Z6NTzZgUOvov+yVRzbUrbAYKkSw== X-Received: by 2002:a05:622a:115:b0:466:9a61:273a with SMTP id d75a77b69052e-468f8b66f1emr17164551cf.52.1734383846255; Mon, 16 Dec 2024 13:17:26 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:25 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:16 +0000 Subject: [PATCH v5 2/7] ACPI: bus: implement for_each_acpi_dev_match when !ACPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-2-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 Provide an implementation of for_each_acpi_dev_match that can be used when CONFIG_ACPI is not set. The condition `false && hid && uid && hrv` is used to avoid "variable not used" warnings. Reviewed-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- include/acpi/acpi_bus.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 19f92852e127..a9b5a5204781 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -1003,6 +1003,9 @@ static inline int unregister_acpi_bus_type(void *bus)= { return 0; } =20 static inline int acpi_wait_for_acpi_ipmi(void) { return 0; } =20 +#define for_each_acpi_dev_match(adev, hid, uid, hrv) \ + for (adev =3D NULL; false && (hid) && (uid) && (hrv); ) + #endif /* CONFIG_ACPI */ =20 #endif /*__ACPI_BUS_H__*/ --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 983191D5ADB for ; Mon, 16 Dec 2024 21:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383850; cv=none; b=QPUURtJDSXkYSR2W7MH2yTYDwIDI40mFhzVtfSMsYrTGBD1d3rRmRl99aCR4xpBuo59mN7Mm/GosJxSVt9Hrc0WfUSBA5vs53yxiE5uyVTFJZFlYYhdtMuOYhseelJyrRiNVeK4Uj/hWRuuntcf7s7rQLzn899fcf8DWjKRO8jw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383850; c=relaxed/simple; bh=X32i657SSLdAHHKEkAbumTOxZEIg1B0mwuSYHOFYedE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pJSXNDmksPWEI8m6f3n4qc+tP45F2N9YjCmB+YGIIYMZk1ogG1FI2nE9ZJUKywLdRQ4jbGAGIR33GOaeV0oVfQzYFn7+FaW1Q9ANTl9TeLIIytsO/1cTOBwO6F1ziCKvRvQK7ghzi9BIXpvysCYkRMOvP/459cqzC/LbnoQyyT4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LSEs2M+2; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LSEs2M+2" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4679eacf25cso23425151cf.3 for ; Mon, 16 Dec 2024 13:17:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383847; x=1734988647; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WqBBzZFuR8Mx+keH2/BU5geK8A+jljM9pAiu8cpH6y0=; b=LSEs2M+2u4DUw7wALz8b4Ub6cQ2qEl/y/zuTqEE3TwDenbsNWiFE490qDAuagbC75v RUwY0bCqz9XbHcdpEcetZGUp/wPYfmGgQAPLKDbLGag8TmV81Tb+vMoLZ2aqvDn201/+ sZaqERXgCo9kspL1Kdh0UuH7V7U+WZPvH86Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383847; x=1734988647; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WqBBzZFuR8Mx+keH2/BU5geK8A+jljM9pAiu8cpH6y0=; b=i9A9iDqxK5T9DfHvSAd1yWwOIcS5oNsQxDUdzrYM9a2c5WI8YYDar/pwkTGgKQT9eS KehDn9l0YSAqtFRMr2AAvegUjrFlQk4PDNTLOfU9qWlbuxsCPip/SnzvLYP8OFst6m50 a95rlVR1ccUS+07hjuEm8weuVa3oSxCW1Q23SmJK3XzriUP57yf7z81B03PFcmod/aa4 cf9OpoC3Anxqt4oJ58dCKSdXAnMjo1GiHixNX2Yb/2pg6NG1yTXTKqA4b5jNywhStUnN wVybqbBK50RO/xQBCQFmz6gCShVqtdRifnHbYmrPiJTi6MJ/0uYnSWaVEYCcoQD6c9oV MJ2g== X-Forwarded-Encrypted: i=1; AJvYcCUYJmlfVzyn69TsyxsUtjhrNLiLCrRMRLjxGBTGc4vqoWEarqE7pC04TydvCi8StWJrow7edKoUrw0vvh0=@vger.kernel.org X-Gm-Message-State: AOJu0YxBfysCncPiDmPb0TQpFH5UOEUfzvmFfuy064q+se3T3DlTJcaW 5lfHbRMT9hVLQaCVxjYhx/wXml97XRC+aoiv2MPHVkPVfu9o9zhEyCXNtg1ZPnnebWUtnFp9aFg = X-Gm-Gg: ASbGncvaYnYV2AHx8cQHikgancC9nsl+iGFZh66bCqUdY2h1uEDup3E3ZqDafSI3Hgj AKOjzEmZHN64Uj1OXS8wZCTk4Dg+CLHisoqEwdxDfoOPHxrV12cQnKeaZ9jTw8aCIwJcVb82NCD v3DWeEZBnG9VoIZvzQOPlVR/bAOsxRaKRUQX6Vh0qHWEwW3ci4I31/BuY6mHgYwuIhNzqLbRnC9 Ok17knTjdf8MnMcRqE4S8SzIRO5PL0I6lTxC1wTRWzw49BFGOu6x4KcbHrkfbeUIQBqWj4QcP8/ sxXpGevLhg1RoGW9PVMDwdj9ldLzcFY= X-Google-Smtp-Source: AGHT+IFa0lE3VU6S7yMTSi6U10IiAbRleFzkYam8wiPnIWkXufZo9uMrtys/YCrx+kHmkm9mMlGHjg== X-Received: by 2002:a05:622a:1aa1:b0:467:79eb:4a16 with SMTP id d75a77b69052e-467a5721b4dmr271093651cf.4.1734383847705; Mon, 16 Dec 2024 13:17:27 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:26 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:17 +0000 Subject: [PATCH v5 3/7] ACPI: bus: implement acpi_get_physical_device_location when !ACPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-3-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 Provide an implementation of acpi_get_physical_device_location that can be used when CONFIG_ACPI is not set. Reviewed-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- include/acpi/acpi_bus.h | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index a9b5a5204781..f38e8b1c8e1f 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -43,9 +43,6 @@ acpi_status acpi_evaluate_ost(acpi_handle handle, u32 source_event, u32 status_code, struct acpi_buffer *status_buf); =20 -bool -acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld); - bool acpi_has_method(acpi_handle handle, char *name); acpi_status acpi_execute_simple_method(acpi_handle handle, char *method, u64 arg); @@ -60,6 +57,9 @@ bool acpi_check_dsm(acpi_handle handle, const guid_t *gui= d, u64 rev, u64 funcs); union acpi_object *acpi_evaluate_dsm(acpi_handle handle, const guid_t *gui= d, u64 rev, u64 func, union acpi_object *argv4); #ifdef CONFIG_ACPI +bool +acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld); + static inline union acpi_object * acpi_evaluate_dsm_typed(acpi_handle handle, const guid_t *guid, u64 rev, u64 func, union acpi_object *argv4, @@ -1003,6 +1003,12 @@ static inline int unregister_acpi_bus_type(void *bus= ) { return 0; } =20 static inline int acpi_wait_for_acpi_ipmi(void) { return 0; } =20 +static inline bool +acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld) +{ + return false; +} + #define for_each_acpi_dev_match(adev, hid, uid, hrv) \ for (adev =3D NULL; false && (hid) && (uid) && (hrv); ) =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C94F01D63ED for ; Mon, 16 Dec 2024 21:17:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383851; cv=none; b=XsIWP/Q5eQD6+YbJPWpSUGJ/G5mD5N8FShHitOwEgXq/Jme7IDw1YYk+hHodQCyueHPXt47GAnMsyc2LaIwytJVzwt9s/waJReYJISGEDYHfLf1b8OTlqdhs9KVAZOUx5BHwxxOl99gqDzsiaTukrfY0ZbKnXclj2jgozyX3HiM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383851; c=relaxed/simple; bh=OSI5+enbqVnK80hh3GRt2v2/xjuyertlyl2dDt3BvaM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JVZMVQL4xAMTm+5D34O1LBGVvQE37uiMLbMGw0y70D+9lIkKqvUVavgyP22Y0/4FIaWIR/4zJ4J+jss7pj8+GJJl4oTnYBbT8NJZuvDJn4/BVKvmMJ7AqNAecbUDyGuQh1Ue4f71AHjx0tCHZYHfoVr/HXMuQfDe42QIwOfb69U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=fkTiktYF; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="fkTiktYF" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-467a8d2d7f1so29564711cf.1 for ; Mon, 16 Dec 2024 13:17:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383849; x=1734988649; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=94GpRvEFGP1zDl7TooYa5XXxiXoizWnVF+RBMjgEO9A=; b=fkTiktYFTPmDeU9C4JP925QArvW+eKnHcm6j/H5w2zAykkSRytleeNs+VWy4zzwKTB +aYKjrb1UEjiGE6Du8jzPlIzSkdGhavIKg0Gbnk2WkrGHnPO3naJwCBiMxKlW8mBpNuN GOsPXWogbrd2ZH1g8Gj1fL7YemXx3isGnfgSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383849; x=1734988649; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=94GpRvEFGP1zDl7TooYa5XXxiXoizWnVF+RBMjgEO9A=; b=kR3p5lxHYP0BDhsk9yKohTU4UQYqSafRe/5/oEedC5ckWDLukzh9GyPG7nRYEp9na2 ez7b/XE7YsW1AHXFCmKTkmEt0qkCOinYcyPOYzUTprzIdKec2szjI5HJzELHX/rpIY1f unDyC2OuZ+q9hrq4mFmhNRWkBhIvbADXR1XqAoNFRsj7i8nIoFXi9gotweoTq3JePukj 2GbLD/eebfI9q3JRW2r0NDsB1GxyPWHePLGw1A8xQazE0zxn+JtKy/Oq4AqpQrnZ+UuN /6ne22NW+uQNbuheKjBdVckZyk5wNwK7dUaXSfLMm/zrkYFbuG+kDRON3fFqG+Owkqva t0sA== X-Forwarded-Encrypted: i=1; AJvYcCVRJwajsbokogcpEIkjHiotCXFR+W7xyeDWIRokh1YUI8i5jfA4EGWGsymGS+RAxHdwWlZwb0Ah96Ty8g0=@vger.kernel.org X-Gm-Message-State: AOJu0YzmsfcpWmZhGXj5kk3YLTms5Nh3gFI3SjytBS+L0x4bGS2LAkh6 bwCvFxUqvFo9jy6bj4JGRP4w9D0W4zXC7qJFnYT4JqUvGWpbhRhoyRFe0+5msG7j62ROcq30B1U = X-Gm-Gg: ASbGncvxOj5qABY6OcnlekP3OL+TKb/6B6mRUMiOaVGonscd9JsTwV0w0hesJBIKH+W gJjY0+V6H9/esSIycqnX8pZ0Hh8CB/ZLpIGTo1BiiqRG7TS+ISrypgwiB9hsVv7m8Ra4Ad8FW/3 UOET9g13j9Hn2EqEwyz7CD9C3vt/4y+2y7p4PbwYBE5bkHUa7JxPpwG/CzQWHoqqj6a8CdNo4ou P4yYWed9d1W0vLBpzM+cekXQwih8Xtm4RJf9OAdAq/pHRiylNwtNQa23msRGXfhIQU5Qu6XoiAv dYKvk0u8B4hUCV86mlahhd5ycktp2gI= X-Google-Smtp-Source: AGHT+IFyzGw+gglrqm8+RhNerLly3LfTpt0cYg/FTCF385N1SMb70IaANKI6otHSuU62jnflMlYR+g== X-Received: by 2002:a05:622a:1210:b0:462:e827:c11a with SMTP id d75a77b69052e-467a575a86emr267051701cf.19.1734383849004; Mon, 16 Dec 2024 13:17:29 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:28 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:18 +0000 Subject: [PATCH v5 4/7] ACPI: header: implement acpi_device_handle when !ACPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-4-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 Provide an implementation of acpi_device_handle that can be used when CONFIG_ACPI is not set. Reviewed-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- include/linux/acpi.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 05f39fbfa485..fb88f21bffb2 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -854,6 +854,11 @@ static inline struct fwnode_handle *acpi_fwnode_handle= (struct acpi_device *adev) return NULL; } =20 +static inline acpi_handle acpi_device_handle(struct acpi_device *adev) +{ + return NULL; +} + static inline bool has_acpi_companion(struct device *dev) { return false; --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC0EE1D90AD for ; Mon, 16 Dec 2024 21:17:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383853; cv=none; b=Z0ep6ZdgxyT0iWZJZ0RwGrQQM1wapYEWww4H+Qquegb3TwfqLUiOtCPCNonNeH9+dpXXI1gbsWBtYxvltaMCh9WPMt9yFsRh8hqf/fy1Tf0llsEH9vtV62n8+BOttGyS1F+HdDOY+BzQ5wQngyIBIlqnOnkU8OnrWvLZI4hFVwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383853; c=relaxed/simple; bh=95QUI19i+vnnT5+G1KHFOpDSO/pMrFLiSHBGkodQPoc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pVz4Nw5NH807cIfQRQAbMr85WctH8aQh92gBIph3Q1EI43ByejrGhY0GhJbprOuLo7onAWmK2thQCvUuvf8FSqBa6YhtEeYxov4IOKNNHl2pQtD5EZPMT7vC6KwwrljbOanM21lnSuqHjBa3sc5B5uN8pR0dY3aSkedF2BEWJKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=OZKlqkrt; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OZKlqkrt" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-467a1d43821so37086711cf.1 for ; Mon, 16 Dec 2024 13:17:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383850; x=1734988650; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Q9wRik7VAWXozMa2pBEsGGs4ayCPfnrgn33kguAxeWI=; b=OZKlqkrt9/2ONupx19ZzXA18kP6cweiU/xz/phCbkZJv0oh8Qajw9vF0Y1tWpO8MBE R1kwkFWtqtyfkzDbyWgXHOPB53jkFsqq0SJrkILJ+zKZUmHrjcGbbzW+G50g+LblXBPs iCbi9ciTLTmUskmHGwYd1H7CDftzpPmg98WFU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383850; x=1734988650; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q9wRik7VAWXozMa2pBEsGGs4ayCPfnrgn33kguAxeWI=; b=GE1rpeY64rZ3zAf/ZPhwMaYiv66OL9jRYXvPe8nOw0jeXvPnNfM5uHTTf/oHFRZnUb 8PMDfK5AXnOmWhVartbImjZjpKl0/mftmdU/ujvULuzBNG3S2o6GvBOKGnPJ57KGSPbu yf4yZZ7tdYalstegOQzPjaJfQ/48q7KWK9w+7vATcSY96xUraDzTSVfyP/pD6YxyaH8L EtTn6pW0GqOUJcJ5aCh2KpDRcgmYaWKZ7Ou/07VsF7lcKVmfJWQaXYE1y0bI/y5TbxiP pmksuNCBW/Or9cenZY+a73j8J1eQBkv1eW6v7EwJz+auRYd5oNhY/gS8psHeRr3kWpq9 3uhA== X-Forwarded-Encrypted: i=1; AJvYcCVgGKm/A39+DsDLpLbPDos3GQMRJ7k9oOLlVUjZlwv/r1MpjwmpwmEMPKiEC0M0rrohavJH2ZcASgbos3A=@vger.kernel.org X-Gm-Message-State: AOJu0YzlENBBOdwbqSjSCT4L1t5fd2Ty+SzdXds7HK1kHgz6hHO1NaR3 radQvLJM+chJjQ9+8Jxb8GCptL6sUmvBk0rkJcA3YVx+kaZbirHlpX9MVt9bBQ== X-Gm-Gg: ASbGnctsFx7BHXW0V1PaSfd7yuTpU+bWLZY3Xylsb3bnfsXrUx5l2m25MEn9/t9/JKi CbffBAqGi660XO5+suvwx/gaZHBBBrysGqMCsR9PDCc/qmnEPKsD5GLUrKxUL24oSy/sSnvZUfE vV5LCLt+bbKD3iz2garGiXrvvgpt/08SJQoT4kC1oPEFW1U02mFldmholfn051D4IRTvq0Fhw9I lZBaoNQqYCYgsmXgbkpfbx2oLShFp3rYyrkyfheluQrfOhuJjsno8kLnuVcfJ/IdGgGfiOSfVGd 1ZlPZN/NIeezdLHZabvQBwkC3yeHQr0= X-Google-Smtp-Source: AGHT+IEWoLxfSlaf8rXHfYGdo/dNrMIk3fj9viLQXfHndjp90WcsgvICJeewTTVu5HvfhfYK4N5nnA== X-Received: by 2002:ac8:570b:0:b0:465:2fcd:cb0b with SMTP id d75a77b69052e-468f8df3bcemr12486021cf.24.1734383849763; Mon, 16 Dec 2024 13:17:29 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:29 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:19 +0000 Subject: [PATCH v5 5/7] ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-5-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 Provide an implementation of for_each_acpi_consumer_dev that can be use used when CONFIG_ACPI is not set. The expression `false && supplier` is used to avoid "variable not used" warnings. Reviewed-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- include/acpi/acpi_bus.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index f38e8b1c8e1f..68c0e2fb029f 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -1009,6 +1009,9 @@ acpi_get_physical_device_location(acpi_handle handle,= struct acpi_pld_info **pld return false; } =20 +#define for_each_acpi_consumer_dev(supplier, consumer) \ + for (consumer =3D NULL; false && (supplier);) + #define for_each_acpi_dev_match(adev, hid, uid, hrv) \ for (adev =3D NULL; false && (hid) && (uid) && (hrv); ) =20 --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70DC11DAC92 for ; Mon, 16 Dec 2024 21:17:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383854; cv=none; b=BTEQi5K/zi3tf8qZneKQtZrUcbIb1rZV7wAb42GcKEpo95WAQN/cz6EWzfyqzywM03JLzh3HN0Juq4s1EHrvJc6SbG1XaH2tqJ+ycPHciU7z3XRET1QjmhrhaBhTS4bcbG0//DKPSlttABkEw5iS41+DFedlTCAjRdJq5K5INBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383854; c=relaxed/simple; bh=Juo2ve3rrjlu9oDP30UIZmhGa+flQbphR9swoQR5GS8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r9PzAOjVLkjN/70i6/MW6aJCQF3k2+wvGF+rikekl8xV7qvdww4cx8CZzBM/qmeeU2lAufgwkihUzgH7Yq9SFb0AGOYMxbNsuxOtjgQRaVHHCdsXqx7EUagcyKJ+pTs9sP7MmNcuPv8BYNO4VW4Hzj55drn+w7pCZigDeV10Tr4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ck7Az4yN; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ck7Az4yN" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-4679eacf25cso23425491cf.3 for ; Mon, 16 Dec 2024 13:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383851; x=1734988651; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=JdfI8iMG82M8irlFSVYMbWfZvDLPeTNhiZE+t4N6pwc=; b=ck7Az4yNU1mMJp66dLdH5at7e8d7WaBtyH4gT39AhwIjPBkPwFHn+a46+0wShnHe0E 01R+r5E5DBuZ978DazWMFvzEHniQUS19ChznG0DpEQ+h/iSYD4Sxo7Z6lIvtF5O4m4CG wwKcjEOI4PvJWeo+vh7MpCNT1cDGbbBNi8BX4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383851; x=1734988651; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JdfI8iMG82M8irlFSVYMbWfZvDLPeTNhiZE+t4N6pwc=; b=KAvzfCyiGK90jbqBMC7TFv2moie0F7qZQz1ETOLHfEBAsAQpwZ5vwasChH4+8AsMLI uFxPo/L8zMsNLobQdb1vsdkmmNqxywDoKOrlpODjV29EYj3pK2Ipg6v89CpiPT43vfJy +ojVKP6yvAXkiEEju88eeY05m0dLtGcztsPG0jPQ5Bb/psaBgtBOMSviVld9C6oedhbK C1usv0b4nu4IjjxYbTgRLKs8GcnlDwwrpsTocWpJxGoyLscxaTYExhUrsatowrZVfU9b fcjGpOGdJDQt/8U1mBclaWLT46wQ0H+oi2bcDaYIYEkpK8bFVCHPE1UMSO2ePerUskfV HY7A== X-Forwarded-Encrypted: i=1; AJvYcCVQb/HqIR5gzcxpRqfiCEvOVmpovAp5QP1mO+f/G5gHXVqPdMeEODGcC+c8qG8cr02ll3YNf6BhuqNxkv8=@vger.kernel.org X-Gm-Message-State: AOJu0YyqXz91d756hckq1yGe5qTANrH6jh650rkX5nUvbu8FSCgeCLmR JPbyR/21qM5YeEngsINZKbLFcPKpmKkf+/nPiDIJV583mSg1tNCDdj7D5hkXgw== X-Gm-Gg: ASbGncvZiFZIWmxPDN/xw2vFOdhlL02/Ds1a/1TqewhSska0ra0AG4+8vo+gPD20Whe m/9dGKDnfkmViaW6homknovNXf+F2jAMXp7/+2GR+YKn6xTiDxUDmaB3CJORBEOleWgluYdlR8n /zQAuqLdYQvAy241YR3Q0Awr/GudcZmJ4e8UssRRenl7vuXvc7PUAzs8cy2gcGvDdTRQvZzhcoI 0aOFMNA743tIYAf59OCp7nAMA6QOfQTkwFfGgsfxRPrQZ4lm1wIJnbYVePAr+QguetjxERc4R5Y 4kqewrSpkAV5GnEM7OewD7CD8shZciU= X-Google-Smtp-Source: AGHT+IEl8hUUhzs8PDA9iSUQEkMmOZX53TWYQb+JuoOBexm0lrDkqiD/7RB/yiHbTUvOThs4R816YQ== X-Received: by 2002:a05:622a:1817:b0:467:53c8:7572 with SMTP id d75a77b69052e-467a5759258mr245947171cf.13.1734383851253; Mon, 16 Dec 2024 13:17:31 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:30 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:20 +0000 Subject: [PATCH v5 6/7] ACPI: bus: implement acpi_device_hid when !ACPI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-6-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 Provide an implementation of acpi_device_hid that can be used when CONFIG_ACPI is not set. Reviewed-by: Sakari Ailus Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- include/acpi/acpi_bus.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/acpi/acpi_bus.h b/include/acpi/acpi_bus.h index 68c0e2fb029f..aad1a95e6863 100644 --- a/include/acpi/acpi_bus.h +++ b/include/acpi/acpi_bus.h @@ -1003,6 +1003,11 @@ static inline int unregister_acpi_bus_type(void *bus= ) { return 0; } =20 static inline int acpi_wait_for_acpi_ipmi(void) { return 0; } =20 +static inline const char *acpi_device_hid(struct acpi_device *device) +{ + return ""; +} + static inline bool acpi_get_physical_device_location(acpi_handle handle, struct acpi_pld_info= **pld) { --=20 2.47.1.613.gc27f4b7a9f-goog From nobody Sun Dec 14 13:44:41 2025 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 327FA1DB95F for ; Mon, 16 Dec 2024 21:17:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383855; cv=none; b=ilIOrYQLFxE2A35KDk0rq2yIRijTMR7pfBwP+lqTfpOlrdqzhtwDchpdaO0r/fxf5k+J9iLcT36W4afg6RplS66toDGutb9TSOOl5uNeCLqvABWeNSxj4dsYQFPSNVPMmsJE4eGLCd0SP3MsikTmsx92KwSE/UrHZf8vfstMgbs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734383855; c=relaxed/simple; bh=IKB58y4snq/gqAR94o4C+T0eqQtkn7ecDZk3e6CYE68=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=M4W9mwy76o+BG53LF+qWbJ2ezqfnBAA3YAI/AhJNFQ+SnnvBXnp1m4Px4ladfuvN1LsEKY3XzLHUf5/v2X1LBOvWKMMdsnDuIMK97ekjBDpuUjTZDNEWno9VQF2R1qIJr/it9zu3vwQHfn/HTXqTcbI/LwZ6aWJI4yrqaoJoUgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GJPwkgNF; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GJPwkgNF" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-468f6b3a439so5579291cf.1 for ; Mon, 16 Dec 2024 13:17:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734383852; x=1734988652; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pSt2f8yebuqnlO+DsTFByKH2G3GRiRhWURC3O1KFqeY=; b=GJPwkgNFlEuz0Eo+vpfVsbPktf5ec6XKKDuEt1RQ1hOB+pdMWdEJCIRPeOOXTVeD+w r8i5ieBBTYy7w/lHAIqLfHDnPQYyxUZjRmC9ayjDAy0tNczRtAvk9T6UpMazzqA33S8W Z3PJNYgbgNXTLQ9SEwXsnkjyRnLP7pAENC8LI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734383852; x=1734988652; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pSt2f8yebuqnlO+DsTFByKH2G3GRiRhWURC3O1KFqeY=; b=bbcy1gcu2pnufdOnDpG6RtWfR3EzHndKeVIf83Wu4drqzW0LAxbsgA66kDrlTHnICf pG90FRFsxE1JPX1kE7eG6chki50F3Wj8GBPzZ2yfsqwufgkGKsfuWkS91tDtUnkDocnJ GNtHJsLhAIuRTmRijhGFibkekaP5z+joQ5102FRp0NCb0P03BpqPg3OvVp0hJ4MMm8qc vSvQ13msS18K6ORppv1OZEBDb401eOvTJq3GQv72z5VufoYRS8ARBDqnwmQ+3QgBAao/ 84zYbwyZTqoOTQvsvN5a3XebxvQIDWNP1/HJQ+6/2Z+uUxC7rfBWt3eECIaNmTqBg0Ah YciA== X-Forwarded-Encrypted: i=1; AJvYcCVA8+ic9R8KH6k2rkoDLrg7TbgOV0HqjMSanF68WuIOYk2LhyQhstzUq9AVR2WaygGbeytdJUvwsVNRRfw=@vger.kernel.org X-Gm-Message-State: AOJu0YwH6ySRojb9zvkE4WdDi+OmNcRi2tJOtd3yzFMGMPchmI2Hfubm ythdZHaeG0MHMOgrb86F8Zai3XLPQSLxYOoQXmuYIqOGdF8wCXuAvUltNA1r9w== X-Gm-Gg: ASbGnctJivmaib6aRFATRSD+LFWhiXaPOTLiP+ZIqwIFssVHLFvYhIs/KaDxiwUkzfO RJf0NGRupwRBJWxxV3K4/aNx4ZaOFZN8LWTREpMnhbY+9PUp0u0aHDpYRZyVyxFkSJ8fGUqxMjV 9EuoLQNL7JnsQ14N5uISGhYWdYfRTwjtZuAckVg9afKovqYH1X3tp0kgsqWyVURcPOpw/Uk6x4i 54q4McacR/+7TyuTjIX8fJxgLxNmPVgR67hSwY12Jo5cV7r52bVgMJzgBK5fxjsDI6DbB7DzXyi vWrKEmcs2YOQJrssGmkqxlx9EGwTyd8= X-Google-Smtp-Source: AGHT+IGA7OE2/+AFr8NJQp1+beNCjHTix5HDCvzlrGBd1KJenMxv6YV5fSV7uyPrfaZdLlcoEJkjrQ== X-Received: by 2002:ac8:5a93:0:b0:466:a983:a15a with SMTP id d75a77b69052e-467a581d253mr223743851cf.42.1734383852093; Mon, 16 Dec 2024 13:17:32 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e85c03sm31927501cf.69.2024.12.16.13.17.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 13:17:31 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 21:17:21 +0000 Subject: [PATCH v5 7/7] media: ipu-bridge: Remove unneeded conditional compilations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-ipu-v5-7-3d6b35ddce7b@chromium.org> References: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> In-Reply-To: <20241216-fix-ipu-v5-0-3d6b35ddce7b@chromium.org> To: "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Robert Moore , "Rafael J. Wysocki" Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-usb@vger.kernel.org, acpica-devel@lists.linux.dev, Sakari Ailus , Dan Carpenter , Ricardo Ribalda , Mauro Carvalho Chehab X-Mailer: b4 0.13.0 The ACPI headers have introduced implementations for some of their functions when the kernel is not configured with ACPI. Let's use them instead of our conditional compilation. It is easier to maintain and less prone to errors. Reviewed-by: Mauro Carvalho Chehab Acked-by: Mauro Carvalho Chehab Signed-off-by: Ricardo Ribalda --- drivers/media/pci/intel/ipu-bridge.c | 29 ++++------------------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel= /ipu-bridge.c index 6cc2614b8f86..be84c100d732 100644 --- a/drivers/media/pci/intel/ipu-bridge.c +++ b/drivers/media/pci/intel/ipu-bridge.c @@ -2,6 +2,7 @@ /* Author: Dan Scally */ =20 #include +#include #include #include #include @@ -107,7 +108,6 @@ static const char * const ipu_vcm_types[] =3D { "lc898212axb", }; =20 -#if IS_ENABLED(CONFIG_ACPI) /* * Used to figure out IVSC acpi device by ipu_bridge_get_ivsc_acpi_dev() * instead of device and driver match to probe IVSC device. @@ -127,11 +127,11 @@ static struct acpi_device *ipu_bridge_get_ivsc_acpi_d= ev(struct acpi_device *adev const struct acpi_device_id *acpi_id =3D &ivsc_acpi_ids[i]; struct acpi_device *consumer, *ivsc_adev; =20 - acpi_handle handle =3D acpi_device_handle(adev); + acpi_handle handle =3D acpi_device_handle(ACPI_PTR(adev)); for_each_acpi_dev_match(ivsc_adev, acpi_id->id, NULL, -1) /* camera sensor depends on IVSC in DSDT if exist */ for_each_acpi_consumer_dev(ivsc_adev, consumer) - if (consumer->handle =3D=3D handle) { + if (ACPI_PTR(consumer->handle) =3D=3D handle) { acpi_dev_put(consumer); return ivsc_adev; } @@ -139,12 +139,6 @@ static struct acpi_device *ipu_bridge_get_ivsc_acpi_de= v(struct acpi_device *adev =20 return NULL; } -#else -static struct acpi_device *ipu_bridge_get_ivsc_acpi_dev(struct acpi_device= *adev) -{ - return NULL; -} -#endif =20 static int ipu_bridge_match_ivsc_dev(struct device *dev, const void *adev) { @@ -259,12 +253,8 @@ static enum v4l2_fwnode_orientation ipu_bridge_parse_o= rientation(struct acpi_dev { enum v4l2_fwnode_orientation orientation; struct acpi_pld_info *pld =3D NULL; - bool status =3D false; =20 -#if IS_ENABLED(CONFIG_ACPI) - status =3D acpi_get_physical_device_location(adev->handle, &pld); -#endif - if (!status) { + if (!acpi_get_physical_device_location(ACPI_PTR(adev->handle), &pld)) { dev_warn(ADEV_DEV(adev), "_PLD call failed, using default orientation\n"= ); return V4L2_FWNODE_ORIENTATION_EXTERNAL; } @@ -498,9 +488,7 @@ static void ipu_bridge_create_connection_swnodes(struct= ipu_bridge *bridge, if (sensor->csi_dev) { const char *device_hid =3D ""; =20 -#if IS_ENABLED(CONFIG_ACPI) device_hid =3D acpi_device_hid(sensor->ivsc_adev); -#endif =20 snprintf(sensor->ivsc_name, sizeof(sensor->ivsc_name), "%s-%u", device_hid, sensor->link); @@ -671,11 +659,7 @@ static int ipu_bridge_connect_sensor(const struct ipu_= sensor_config *cfg, struct acpi_device *adev =3D NULL; int ret; =20 -#if IS_ENABLED(CONFIG_ACPI) for_each_acpi_dev_match(adev, cfg->hid, NULL, -1) { -#else - while (true) { -#endif if (!ACPI_PTR(adev->status.enabled)) continue; =20 @@ -768,15 +752,10 @@ static int ipu_bridge_ivsc_is_ready(void) unsigned int i; =20 for (i =3D 0; i < ARRAY_SIZE(ipu_supported_sensors); i++) { -#if IS_ENABLED(CONFIG_ACPI) const struct ipu_sensor_config *cfg =3D &ipu_supported_sensors[i]; =20 for_each_acpi_dev_match(sensor_adev, cfg->hid, NULL, -1) { -#else - while (true) { - sensor_adev =3D NULL; -#endif if (!ACPI_PTR(sensor_adev->status.enabled)) continue; =20 --=20 2.47.1.613.gc27f4b7a9f-goog