From nobody Wed Dec 17 19:36:06 2025 Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACE82203D50 for ; Mon, 16 Dec 2024 10:06:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734343562; cv=none; b=PuMInNm8mBB96Y6hHyVzJUOIeRyl4/rcti2EKvXmKPZBZ3IAwwYHG7T2oR91Ce8ScbEfJfO+EQNLceROFu5lwmTYLOVmhjMwDYtD9HCz/Ujj46fFyz6oYm5JPGHtvxB2zH/Vq4gEY4/GLd41v1iSfwASWdTmDyhTHye4PmrQGsg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734343562; c=relaxed/simple; bh=gAPvOX9MA1RfnQEjldGIYfNXLHWHc8W6NhPyeulDtfk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=JPu8YCRkow+2CyF8qvN1Y7pOeBFuQsTv8xQnSXoP3uLVnie3rlKFhwPMOnkM1U8ZWcPWS/qj4b84FVpOuz4xzhxo8oRWTm8qJk73FUrOhhyjy7DV456zSX8NvN3XhW4MN4qy+BJ3C9SH3Cgjos6uOKnkFeocA9AO9Ict+r6xsxs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Cp3W37Tg; arc=none smtp.client-ip=209.85.160.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Cp3W37Tg" Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-467838e75ffso49961771cf.3 for ; Mon, 16 Dec 2024 02:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1734343559; x=1734948359; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=a54MOsy6E9jGa95QYlzvvh2hUV8d3jTYLCJlM0YtnOQ=; b=Cp3W37TgA9UC4md1hVjvpcDVQLXV09GVI+Ml4YPjFuGAn0DOUiXgUG3qj954nTnKHL yn+LpO83L1I3xqf65RJlkeoV5l0pPTQrQs1AsMRFtA73nBPnuYirL9xnaBqcBW6s9FBW OTp+7hag9XAD9zbwhRBzti7ltf3M1RTGyoz+c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734343559; x=1734948359; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a54MOsy6E9jGa95QYlzvvh2hUV8d3jTYLCJlM0YtnOQ=; b=m2dCDehC8klxqUlzBJaRvKZjLSP+NtpfrNh7p9LmxlKV5FV+u6KA4utxl4eok6tGFN y+GuTbYtPSA35FQ/QHiniktmz17Za7H5/VzsIj+F3Nl4aXBbAD/LDqZ7nAQfHxOnmLCv SuiINp3jFF4klvUdrJJIF2By+mA1dLUDp40+q+RSUCUHa82K1gTzj6xv6U5UjJBPeyoB s87/VQvceBACiaK6h3i0Je/3RU1h/9UT44saCEH7TfCv7rjQi7GycI2tuGTgGRavrGSZ 4HzXNnZWjKRgoLXBvLxhCqy+7WQIRDe+FAW014nhmTtXp+5CSzRHmiq8s5QykY2vpeed MsFQ== X-Forwarded-Encrypted: i=1; AJvYcCXfbPEVB62jd3/nQiA0HXINrrtXeQXANAN7AYrpLcwyEgVNzHlnl5beBDarcXYIKYBfqEJC0NAnVE6biMc=@vger.kernel.org X-Gm-Message-State: AOJu0YybHVUn86LoGfEqvmEfkPjmvKoGQIPVp7SuZc9KtpERSe+Zr5n8 rLO/+Nzi9LzDPq8HJ9PPXQJdgI1ubahObi0zWtD7cgohqk4FJYCSekqH0T0t8Q== X-Gm-Gg: ASbGnctpQL7hZ/orC+YjGSf1tGYbGtMexkaY+OjvJ3JMxh9wZuUeDtMmJrZ5ncLjrB2 XEWqMISsARFJHxSRCt9I8UTXS5zJNCj9VnNxB4cwgJo0zpXzEDUkgUZcgHZBVZOS12f3yfTd7I+ gj1FTby1oT5+YCFqZqoxvL3PFmPO13mtvzUvqeP1+wasgOehFJQXar5jYNqqEV1c577qqinoQPv gJ0sUMfdgHNcPfSioklZ6kKfVMAH3/lk23oAfB4+hF5ZzaMd4a1Y2tu+UZqroiqT/jew+NpisMu 2jMsrNX38VxGrNzRBqRc3PQsudlwpzw= X-Google-Smtp-Source: AGHT+IFteOIbUZklbNq6Lvzp47tpuTjAPTyYBZsHN//8HRk3Wlh7C8RoplzbksUacH4TArFOoBbnPQ== X-Received: by 2002:ac8:7fc2:0:b0:466:a7d8:fd21 with SMTP id d75a77b69052e-467a57895d6mr229719981cf.24.1734343559722; Mon, 16 Dec 2024 02:05:59 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-467b2e81606sm26145561cf.71.2024.12.16.02.05.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2024 02:05:58 -0800 (PST) From: Ricardo Ribalda Date: Mon, 16 Dec 2024 10:05:53 +0000 Subject: [PATCH v2] iio: hid-sensor-prox: Split difference from multiple channels Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241216-fix-hid-sensor-v2-1-ff8c1959ec4a@chromium.org> X-B4-Tracking: v=1; b=H4sIAID7X2cC/13MMQ7CMAyF4atUnjFKXKCEiXugDpC6jYc2yIEKV OXuhEosjL/l9y2QWIUTnKoFlGdJEqcStKnAh+s0MEpXGsjQzpKpsZcXBukw8ZSi4oHYusax70w NZXRXLh8reGlLB0mPqO/Vn+33+qP2/9Rs0aK7NUfX184TmbMPGkd5jtuoA7Q55w/oGslFrwAAA A== To: Jiri Kosina , Jonathan Cameron , Srinivas Pandruvada , Lars-Peter Clausen Cc: Jonathan Cameron , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 When the driver was originally created, it was decided that sampling_frequency and hysteresis would be shared_per_type instead of shared_by_all (even though it is internally shared by all). Eg: in_proximity_raw in_proximity_sampling_frequency When we introduced support for more channels, we continued with shared_by_type which. Eg: in_proximity0_raw in_proximity1_raw in_proximity_sampling_frequency in_attention_raw in_attention_sampling_frequency Ideally we should change to shared_by_all, but it is not an option, because the current naming has been a stablished ABI by now. Luckily we can use separate instead. That will be more consistent: in_proximity0_raw in_proximity0_sampling_frequency in_proximity1_raw in_proximity1_sampling_frequency in_attention_raw in_attention_sampling_frequency Fixes: 596ef5cf654b ("iio: hid-sensor-prox: Add support for more channels") Signed-off-by: Ricardo Ribalda --- Changes in v2: - Use separate - Link to v1: https://lore.kernel.org/r/20241205-fix-hid-sensor-v1-1-9b789f= 39c220@chromium.org --- drivers/iio/light/hid-sensor-prox.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-se= nsor-prox.c index c83acbd78275..71dcef3fbe57 100644 --- a/drivers/iio/light/hid-sensor-prox.c +++ b/drivers/iio/light/hid-sensor-prox.c @@ -49,9 +49,10 @@ static const u32 prox_sensitivity_addresses[] =3D { #define PROX_CHANNEL(_is_proximity, _channel) \ {\ .type =3D _is_proximity ? IIO_PROXIMITY : IIO_ATTENTION,\ - .info_mask_separate =3D _is_proximity ? BIT(IIO_CHAN_INFO_RAW) :\ - BIT(IIO_CHAN_INFO_PROCESSED),\ - .info_mask_shared_by_type =3D BIT(IIO_CHAN_INFO_OFFSET) |\ + .info_mask_separate =3D \ + (_is_proximity ? BIT(IIO_CHAN_INFO_RAW) :\ + BIT(IIO_CHAN_INFO_PROCESSED)) |\ + BIT(IIO_CHAN_INFO_OFFSET) |\ BIT(IIO_CHAN_INFO_SCALE) |\ BIT(IIO_CHAN_INFO_SAMP_FREQ) |\ BIT(IIO_CHAN_INFO_HYSTERESIS),\ --- base-commit: 78d4f34e2115b517bcbfe7ec0d018bbbb6f9b0b8 change-id: 20241203-fix-hid-sensor-62e1979ecd03 Best regards, --=20 Ricardo Ribalda