From nobody Wed Dec 17 18:05:37 2025 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4BD2213A26F; Sat, 14 Dec 2024 08:16:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734164169; cv=none; b=trLIq0s41hNQrzv8LJmjiY+ztF+s2mbQy6poKHAXgtMgpBcU4c4JvW+BduP+iNKflKFyaEuXHt9RcrFuoyNWUuMK9LahKhyFkkS7VTmB3k7tU1pG5KmPekurteZWFhs2fzqplEGw5bhU8adVcyJCgFvizqVfeUuBtRZJLipdPlE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734164169; c=relaxed/simple; bh=hKFk/4z9zsj72Oe4sT58MeuUz4hbc5O8lh01uVziLe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CDtj5QY8TBrec92Do9jxjeOc5PClo/yrxLvc1th0hFniLCfg6WwOXsnyXAvtFD1M6B5v11v54hSdJZ9xvxdNoa6Ax0g25vf4D2KhchF7BzvA+YTzqIz0HGFq/Oa9BuU4ijtwo1kPCwppeQXiVRKq2gw7gMkX4EkdFQSTocGgATM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=OtIxROwW; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="OtIxROwW" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=25xcw dNxX/lfe8oSFBT2V+pmo+tcl2WqIZwouNsSlgo=; b=OtIxROwWMXDb1NcskdTg5 1ZzA2jxrTuRCX7kj3a1zSxiMCJB28fYP7JfFuqxH84WlNGpUVv7LMVGM21XQfOJj d0SkOzzpWw2lNn36OubxsRmzfoKVudgmk7MspPOqM11oumQn2uwzoDNDT7LGzyao Ua3cFOcO725QLh7V5hZsUQ= Received: from ProDesk.. (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wD3vwGjPl1n3T_wAQ--.16730S4; Sat, 14 Dec 2024 16:15:37 +0800 (CST) From: Andy Yan To: heiko@sntech.de Cc: hjc@rock-chips.com, krzk+dt@kernel.org, s.hauer@pengutronix.de, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, derek.foreman@collabora.com, detlev.casanova@collabora.com, Andy Yan Subject: [PATCH v6 02/16] drm/rockchip: vop2: Fix the windows switch between different layers Date: Sat, 14 Dec 2024 16:15:10 +0800 Message-ID: <20241214081529.3330243-3-andyshrk@163.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241214081529.3330243-1-andyshrk@163.com> References: <20241209122943.2781431-1-andyshrk@163.com> <20241214081529.3330243-1-andyshrk@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wD3vwGjPl1n3T_wAQ--.16730S4 X-Coremail-Antispam: 1Uf129KBjvJXoWxZw4fWF4DAFW5Zr1xXFyxKrg_yoW5try8pF 15Xryagw4DKFs0qrnrtr48uF15A397Ga17X3Wxtw1fCa48tr1DGan8AF9ayr1UGFn3uryj yr13ur98uFWUtF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jTPfdUUUUU= X-CM-SenderInfo: 5dqg52xkunqiywtou0bp/1tbiMxq1XmddNBynbwABsZ Content-Type: text/plain; charset="utf-8" From: Andy Yan Every layer of vop2 should bind a window, and we also need to make sure that this window is not used by other layer. 0x5 is a reserved layer sel value on rk3568, but it will select Cluster3 on rk3588, configure unused layers to 0x5 will lead alpha blending error on rk3588. When we bind a window from layerM to layerN, we move the old window on layerN to layerM. Fixes: 604be85547ce ("drm/rockchip: Add VOP2 driver") Tested-by: Derek Foreman Signed-off-by: Andy Yan --- Changes in v6: - Limit line length not exceeds 100 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 47 ++++++++++++++------ 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm= /rockchip/rockchip_drm_vop2.c index 698e40cea3fa..81207a79530c 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c @@ -2541,7 +2541,10 @@ static void vop2_setup_layer_mixer(struct vop2_video= _port *vp) struct drm_plane *plane; u32 layer_sel =3D 0; u32 port_sel; - unsigned int nlayer, ofs; + u8 layer_id; + u8 old_layer_id; + u8 layer_sel_id; + unsigned int ofs; u32 ovl_ctrl; int i; struct vop2_video_port *vp0 =3D &vop2->vps[0]; @@ -2585,9 +2588,30 @@ static void vop2_setup_layer_mixer(struct vop2_video= _port *vp) for (i =3D 0; i < vp->id; i++) ofs +=3D vop2->vps[i].nlayers; =20 - nlayer =3D 0; drm_atomic_crtc_for_each_plane(plane, &vp->crtc) { struct vop2_win *win =3D to_vop2_win(plane); + struct vop2_win *old_win; + + layer_id =3D (u8)(plane->state->normalized_zpos + ofs); + + /* + * Find the layer this win bind in old state. + */ + for (old_layer_id =3D 0; old_layer_id < vop2->data->win_size; old_layer_= id++) { + layer_sel_id =3D (layer_sel >> (4 * old_layer_id)) & 0xf; + if (layer_sel_id =3D=3D win->data->layer_sel_id) + break; + } + + /* + * Find the win bind to this layer in old state + */ + for (i =3D 0; i < vop2->data->win_size; i++) { + old_win =3D &vop2->win[i]; + layer_sel_id =3D (layer_sel >> (4 * layer_id)) & 0xf; + if (layer_sel_id =3D=3D old_win->data->layer_sel_id) + break; + } =20 switch (win->data->phys_id) { case ROCKCHIP_VOP2_CLUSTER0: @@ -2632,17 +2656,14 @@ static void vop2_setup_layer_mixer(struct vop2_vide= o_port *vp) break; } =20 - layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(plane->state->normalized_zpo= s + ofs, - 0x7); - layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(plane->state->normalized_zpos= + ofs, - win->data->layer_sel_id); - nlayer++; - } - - /* configure unused layers to 0x5 (reserved) */ - for (; nlayer < vp->nlayers; nlayer++) { - layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(nlayer + ofs, 0x7); - layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(nlayer + ofs, 5); + layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(layer_id, 0x7); + layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(layer_id, win->data->layer_se= l_id); + /* + * When we bind a window from layerM to layerN, we also need to move the= old + * window on layerN to layerM to avoid one window selected by two or mor= e layers. + */ + layer_sel &=3D ~RK3568_OVL_LAYER_SEL__LAYER(old_layer_id, 0x7); + layer_sel |=3D RK3568_OVL_LAYER_SEL__LAYER(old_layer_id, old_win->data->= layer_sel_id); } =20 vop2_writel(vop2, RK3568_OVL_LAYER_SEL, layer_sel); --=20 2.34.1