From nobody Sun Dec 14 19:14:04 2025 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39A5CC2E0 for ; Thu, 12 Dec 2024 00:32:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963531; cv=none; b=rbsKavJDQt1QTONsbXNsRM42y7gb8BnbManO0TkJyQaCnbhGdNeZSZrt+U9sKF/RH/BRQPw5+q9LJFaQfwsAZHlXpSfJWnN5bMMqfbGlk9Vhh5d96Fj6kdz7W6dg81CmP3ykvqjnpibs6UZwDPFgKKhrvVV3vZEfvcFHHL0EOLA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963531; c=relaxed/simple; bh=Kd6noYu5kKaYuzY2in9AHzWwTWDE6GDZOmHXqRdwZq8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rmZ4foWDzP99VtJC4ljR5EIwEdVyfg+39f9MimSgGBxgiiuvdc5xc0O6kUuA3+BDOWy9ZdTXRYBuffiTzVaSRjxoCDG9EWHINTirPlWD8ddOOQ14c1uuuviwGlQTdl8pT6Wx/rVqmuRkVGMn3Lm9HGUCHQjv/ztD6iBSJj5qTx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Pp9QeeFR; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Pp9QeeFR" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2161eb95317so320155ad.1 for ; Wed, 11 Dec 2024 16:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963529; x=1734568329; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=Pp9QeeFRfnoMlCiiurrzdJkSvsudEVGzZvOCuEawQ413F15UbpFsEzWHAww5e5YBX5 fzCWEP/KFSJ7RgviBE8CpnHpjfbV+sw+1ub8DhqAACBAn4fWZ+CAKp7aZeRXNGOvM20T DtB+S+i+IszUzirH0wpt7FPHHPGK8XgUO9eLY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963529; x=1734568329; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gGGmVpvyGZhHzPnoBu+k0MVypYw0iPNz1iJuuVrkK4k=; b=a9EL90wVeZO46pUz0h4aLWjeHinhocayvva/PLD/VEyyopo43op+5exRFU8zaKtYAY CasyEi+8gW1wvMAWgczHrGC/Q55nGUcnwcaNQYL2LDnmkjtIrWACKdMthkQM4jfXEd4A 04gUYuWdbbAkWcWcnPZMiIMJDsPiYjlljspDQHwwJHft+okfppoP07Ks0M3HsAsw0auO mw6M8ViJ0gxABl+/8k1WkFMRvLQhEV+w6i8rodOKGHSXdKcuQBL0imrqEmed3vX0C7GR MO5kF8eOpz/Py6OBFPulqPxf1RWarJsAAatd/EEGrKcZQXROCTM3bBWjBkke8KJBBCK7 FfWw== X-Forwarded-Encrypted: i=1; AJvYcCVsjNvc6hAVfZyzpxlAkZew5sUTsOLz0Ueuc5q5TsjkGTTZB+ypoDWkiM3xIHeMozX3vbb+pbGkQ06yZDQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm6/dj94b/xOzk2DXlxq4Vv79enNWySjhFNMa+XTC+/riUov3Q VuNrL/zDwHBKmATGoA7Txsbp78Wk5pBgyRPNRqMl2+ca+8ZVQeW4a5kRpbRqwQ== X-Gm-Gg: ASbGncvdwiXx1dSM1yo/0k/9NVAeOXb+8FNfnj9Dn1P2NQNQl5xp+3NVzcEG3wkf6h3 l/WolKoVEQOT2mOCgnlMDawDYRh05zZhsVXFMLQkwH4rv01BqzUK//sTTZOq6W0j5GNF70imSW3 025XbsZWBk4MXwZJmjbVRwJo2srYbw7YmSa2S3sd6L090tK1qpAWBboHiQFQhWIfVftHDrXL8IS 4lBdcwgI06KkADTBQWEoSVVUjX/Rq72TUnOVCxblDr+Kb6s64VOyy/yJtNl5+7ZLFo922A+Ne6y 1/k6ie81uuREKAKAk1k= X-Google-Smtp-Source: AGHT+IFSuT2+ENL2AFZJMBD75mM9b3DCrYPiGx2+DNGXuCjKQhYTfFJJzw1Pi1HU4HlUFrZS1ojuOQ== X-Received: by 2002:a17:902:ce92:b0:215:e685:fa25 with SMTP id d9443c01a7336-217783b7a08mr70313815ad.20.1733963529631; Wed, 11 Dec 2024 16:32:09 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-21680814d6bsm25853825ad.157.2024.12.11.16.32.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:08 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc Date: Wed, 11 Dec 2024 16:31:39 -0800 Message-ID: <20241212003201.2098123-2-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_find_device_by_node(), bus_find_device_by_of_node(), bus_find_device_by_fwnode(), ..., all produce arbitrary results when provided with a NULL of_node, fwnode, ACPI handle, etc. This is counterintuitive, and the source of a few bugs, such as the one fixed by commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). It's hard to imagine a good reason that these device_match_*() APIs should return 'true' for a NULL argument. Augment these to return 0 (false). Signed-off-by: Brian Norris Reviewed-by: Rob Herring (Arm) Acked-by: Rafael J. Wysocki --- Changes in v2: * Add Rob's Reviewed-by drivers/base/core.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 94865c9d8adc..2b7b13fc36d7 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -5246,13 +5246,13 @@ EXPORT_SYMBOL_GPL(device_match_name); =20 int device_match_of_node(struct device *dev, const void *np) { - return dev->of_node =3D=3D np; + return np && dev->of_node =3D=3D np; } EXPORT_SYMBOL_GPL(device_match_of_node); =20 int device_match_fwnode(struct device *dev, const void *fwnode) { - return dev_fwnode(dev) =3D=3D fwnode; + return fwnode && dev_fwnode(dev) =3D=3D fwnode; } EXPORT_SYMBOL_GPL(device_match_fwnode); =20 @@ -5264,13 +5264,13 @@ EXPORT_SYMBOL_GPL(device_match_devt); =20 int device_match_acpi_dev(struct device *dev, const void *adev) { - return ACPI_COMPANION(dev) =3D=3D adev; + return adev && ACPI_COMPANION(dev) =3D=3D adev; } EXPORT_SYMBOL(device_match_acpi_dev); =20 int device_match_acpi_handle(struct device *dev, const void *handle) { - return ACPI_HANDLE(dev) =3D=3D handle; + return handle && ACPI_HANDLE(dev) =3D=3D handle; } EXPORT_SYMBOL(device_match_acpi_handle); =20 --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 19:14:04 2025 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC37318B03 for ; Thu, 12 Dec 2024 00:32:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963533; cv=none; b=NfICjszwaAL9iniIJRXelGA/P+aYWkuA7j0R88p6CA/+ovf1rF55uBbEC11CMAz94bSN515fOn4SyWfkrWqrG5KgLItGsHQaaQ3B29mWUZ+wBvLd7b4VupA5UcmSe7WJxxefks6MLUPz6z4JKgf0V37gWgWfUGFhlIV7+atxYJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963533; c=relaxed/simple; bh=D4wKzLL6P8kjio2DoNo6T3LLiJX47WeOUYHZv/B1uik=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k9rSjSkzGbm7IGpxQ39COCGJUeh2QpuK/XqokunIE9BgXA5eACMMxXv/DrTC9FNVjtPn4yOTw9VUFkEPUKdW3qokXvsIPelPYP97SZ/SE/B9cW5+6vYrTC6uHrwjwwks/60I/pJEZ7QNU/XsQ1gXtTturIswZ2zjpBEiDJ8al8s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZQPYGCPB; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZQPYGCPB" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-216728b1836so402675ad.0 for ; Wed, 11 Dec 2024 16:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963531; x=1734568331; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q8D6ygKlZnTqTfL4YWEBFZxFC5MoNr1XcjZ+M09PQhc=; b=ZQPYGCPBoxvFCCUqXwtUATpD2ZE5Fnq9gKIsBoOlyDyuGTGijm2XYpDMgoaOlejtHX G1Tv3i598PxbLDaFpIQllPCCNTjQXRFUnHn8Kj9kCaIwG0UVByNeI//mj6JnlLhRwmho Xxno8fw2kcbHhsktG7mlsoQyRFX+Fa3RCs2iY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963531; x=1734568331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q8D6ygKlZnTqTfL4YWEBFZxFC5MoNr1XcjZ+M09PQhc=; b=WMe25svCNKkgStsO3rNh7gDdKl3/NxDKv9iWb4KT/Ti0fD2FLqoJwKOa9K2uWr/nnJ /uM8KjgqJVtRzreCzwwzUzPvNGH1ss13i+hhpdAmKPiOPjB/Jln7B5v3xj7ZQ3PJ+gqp cjqM40v3ivr1/wg9lOe5nXl300jX0PNKDKPz5ND3UgtEo3OQ9ajjS+Vcd7p3H2DAGlX9 3BGKmRAQIr7BYRLsz884auno4VeV3JROif79TCJCy9MeavjTjxC7V6csDwS1kP9a4SY8 Y8j6YMFsM3XlmOtd4+8vjsFeAtOURE5HqjE32/dhQYMIOvswQEqqIQTxXnx2O12s1I2Q qHBg== X-Forwarded-Encrypted: i=1; AJvYcCWnKue4IO5iRe8/bYapB+VMwp7ezy+Phy4vog2Vw3+KtwE+eZLLWgTKUVGWrkdEZoejyEkHoN26l91S1Lw=@vger.kernel.org X-Gm-Message-State: AOJu0YwP3wzze+ktGhHcupMj0TRS/TCdoebD1hQQCynB9pmgqou/UHiX wVDBnsp8fxsgrUpM4f7/bOoOxxx7Nv2tl8KQwVM4xqGEb4+jR65uolkmLBnqSKVdWGSMPWjEGu8 = X-Gm-Gg: ASbGncsCofCnLtagnbHtExvolMsji76ooyNWk0amtCAwstg/jDdxW//IGlP3w3LEqs+ Z8QoxBejqmMK1mllRmjDEBr5SDVea3mNPvm1r2MLvZPv0R8DSpKpPMsw1QU4T48+zABl0Ra+nVT pscIGPeHBCSjh0GMSGJhMUBz5UA075peOMO7uRUJnj5gcE6AwC0oYQgvACdnnLCDusIxlDyrweg ++TkRxNcy4uxiZjUHSiBZdlbj62J6/sEj2ya3jdrn0IxMg1CPHUvMY8euCg8kTSU3CdeQ9eJmo6 Mog0/28j3oNjRO+wxKk= X-Google-Smtp-Source: AGHT+IHkPbKs3MqtSv9QsOis9HgYSk80Xsrurh11pKn4Z3ghlcVU8XnfyIU14vl7WdQ/uQmhi+CZqw== X-Received: by 2002:a17:902:d48c:b0:215:b9a6:5cb9 with SMTP id d9443c01a7336-2178ae4c25dmr25271915ad.5.1733963531278; Wed, 11 Dec 2024 16:32:11 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-2163724c42bsm70938605ad.174.2024.12.11.16.32.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:11 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 2/3] drivers: base: test: Enable device model tests with KUNIT_ALL_TESTS Date: Wed, 11 Dec 2024 16:31:40 -0800 Message-ID: <20241212003201.2098123-3-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Per commit bebe94b53eb7 ("drivers: base: default KUNIT_* fragments to KUNIT_ALL_TESTS"), it seems like we should default to KUNIT_ALL_TESTS. This enables these platform_device tests for common configurations, such as with: ./tools/testing/kunit/kunit.py run Signed-off-by: Brian Norris --- (no changes since v1) drivers/base/test/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig index 5c7fac80611c..2756870615cc 100644 --- a/drivers/base/test/Kconfig +++ b/drivers/base/test/Kconfig @@ -12,6 +12,7 @@ config TEST_ASYNC_DRIVER_PROBE config DM_KUNIT_TEST tristate "KUnit Tests for the device model" if !KUNIT_ALL_TESTS depends on KUNIT + default KUNIT_ALL_TESTS =20 config DRIVER_PE_KUNIT_TEST tristate "KUnit Tests for property entry API" if !KUNIT_ALL_TESTS --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 19:14:04 2025 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 939CD2B9A2 for ; Thu, 12 Dec 2024 00:32:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963535; cv=none; b=GObWU4YcRbOHiTUcNEifrBD4EF/K0/uQ4udCW194KgCiMGlwXJn3mkYO8t+v1/1aqfX/CaTMqQSVvM9CyzIPlZHnAM0CsFKWzRJtadVlanvivKBciK6fh330xujlmpD7YP1U4GOzXrGJbp+zPp67VXym473ti90n9DfHSR6J2j0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733963535; c=relaxed/simple; bh=y5nwWgTVBI2UXYuNENiRQFzqncmPN23qxZLRHMtG29c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=XJnkizfZXg6XZnOPJxPn67RhdAkw1HFhRPGx85SDa2RHlpJaIrQvRyKOjDjQjgcQR+QmEZsxWSJj8R793zkOJZvRjRs+1/OBprZm+8QUqTIFOMjsqixhFEU8Xrk1cgQzcYe779S9YNxKEPuA2IKRaL9GBtWxnhLua5ulXsrLBog= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FCm8BLgy; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FCm8BLgy" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2161eb95317so320555ad.1 for ; Wed, 11 Dec 2024 16:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733963533; x=1734568333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3AVQu3QWop0H0c+IcZ6mMGnn73hEqL5BKjdosgsTiGA=; b=FCm8BLgyqZ79CS2uNCVdS/VBz04o89PGFfnlwXzBFac9Yb0nn6pKl4+cz+yP2qthbo TrVe2jYTHdVLDSH2VyerbPlA39oUCqOU35A/TkrNIOZy6/CRZTtR36vrCMqkzdFHRiSW Lo6JXXHTA0XlgC/kjG2a5d9O6t29PGw08nxKQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733963533; x=1734568333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3AVQu3QWop0H0c+IcZ6mMGnn73hEqL5BKjdosgsTiGA=; b=Ijgz1ZI1MPvjThHYrBlvjKk0mBGf/Nm9FGVql9tR2JrDp3rlu6dO0FiQkQYk4DUEeO 7C5NhQUnQ0tbSFoRR3/tV+3aOcy0uLgN/Fn99nns0IEgDgp1BjSusrEcCVBiBtCLLUug BREB2uyRK4ZnS5IynDHHIJ6epesrow927FU046lDTFi1I6ZAz6LkEkrzV0sgVqGfNQRo 0DEdPPwy0DN/4t+i1HitF4JI3rh0HHD8aLGgvTdwgdo64hRDpt8562wqikNeiG0q2jFY /FO/lDOSwSXpZHWNa/djI8jyQ9mrdpqrS9/njz5vUEVaQsgqg+vunU3mdRzDnRivIbiL tfpg== X-Forwarded-Encrypted: i=1; AJvYcCW681iY8YJFdM8etJzWVe/W/ZBzpA/F8aJID2OAO6a69VvIDvowCQBKk/YJVXgvp8yz6fLJ4WfWDMU6QIc=@vger.kernel.org X-Gm-Message-State: AOJu0Yxblpcb4sh7rXhhcsBQP7pKNetoqFKoVcjBQn2lyS11sVbEvefT BG1UyCr9d4is7OdMuMIu9VcQM7CrDQyDiuUeM1AJaWsznooCbqcbncIHmfFMcA== X-Gm-Gg: ASbGncvlB92DNPZwrNHbniehWckxbtwh/VO8aocgdH46fiGIHYYgBDIZwda81xzGprG tPsb9o+7FZXlHj1/T++pqhuYXB+aBNZ2XlfoYC1j1sA0QOgfDaKZ38qPd3OZWWNOS8PS+bYmjYb QvOB9o5vFvcsNM1D65Ug5ILR1cd4SNJB1tb5fsoTk+5BGcE+Vib/zh9uv9N247UCDHq/xNq/LnL enqbZ8VPbabe7HZOKLbmdBBMYPZnf3d1einNudpTfNIBP8EVA7t+781Bs2PBEq/4HidQyKyRuLe 2bFIxn8ujP7tNF+sMls= X-Google-Smtp-Source: AGHT+IEGLgadsxVUtkYmrldWfxFt3dO7ayUdfAi8DTpzJjhNb3S1+xd9gbNu33I+qMnncuaz+9QyRQ== X-Received: by 2002:a17:902:cecc:b0:215:a3e4:d251 with SMTP id d9443c01a7336-21778395944mr84017305ad.6.1733963532911; Wed, 11 Dec 2024 16:32:12 -0800 (PST) Received: from localhost ([2a00:79e0:2e14:7:b1a5:9c72:5742:89e0]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-216338fee40sm75395405ad.94.2024.12.11.16.32.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2024 16:32:12 -0800 (PST) From: Brian Norris To: Greg Kroah-Hartman Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, Maxime Ripard , David Gow , Rae Moar , linux-kselftest@vger.kernel.org, "Rafael J. Wysocki" , Rob Herring , Brian Norris Subject: [PATCH v2 3/3] drivers: base: test: Add ...find_device_by...(... NULL) tests Date: Wed, 11 Dec 2024 16:31:41 -0800 Message-ID: <20241212003201.2098123-4-briannorris@chromium.org> X-Mailer: git-send-email 2.47.0.338.g60cca15819-goog In-Reply-To: <20241212003201.2098123-1-briannorris@chromium.org> References: <20241212003201.2098123-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We recently updated these device_match*() (and therefore, various *find_device_by*()) functions to return a consistent 'false' value when trying to match a NULL handle. Add tests for this. This provides regression-testing coverage for the sorts of bugs that underly commit 5c8418cf4025 ("PCI/pwrctrl: Unregister platform device only if one actually exists"). Signed-off-by: Brian Norris Reviewed-by: Maxime Ripard --- Changes in v2: * Keep "devm" and "match" tests in separate suites drivers/base/test/platform-device-test.c | 42 +++++++++++++++++++++++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/drivers/base/test/platform-device-test.c b/drivers/base/test/p= latform-device-test.c index ea05b8785743..c8d4b0a385f2 100644 --- a/drivers/base/test/platform-device-test.c +++ b/drivers/base/test/platform-device-test.c @@ -3,6 +3,8 @@ #include =20 #include +#include +#include #include =20 #define DEVICE_NAME "test" @@ -217,7 +219,45 @@ static struct kunit_suite platform_device_devm_test_su= ite =3D { .test_cases =3D platform_device_devm_tests, }; =20 -kunit_test_suite(platform_device_devm_test_suite); +static void platform_device_find_by_null_test(struct kunit *test) +{ + struct platform_device *pdev; + int ret; + + pdev =3D platform_device_alloc(DEVICE_NAME, PLATFORM_DEVID_NONE); + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, pdev); + + ret =3D platform_device_add(pdev); + KUNIT_ASSERT_EQ(test, ret, 0); + + KUNIT_EXPECT_PTR_EQ(test, of_find_device_by_node(NULL), NULL); + + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_of_node(&platform_bus_type, = NULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_fwnode(&platform_bus_type, N= ULL), NULL); + KUNIT_EXPECT_PTR_EQ(test, bus_find_device_by_acpi_dev(&platform_bus_type,= NULL), NULL); + + KUNIT_EXPECT_FALSE(test, device_match_of_node(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_fwnode(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_dev(&pdev->dev, NULL)); + KUNIT_EXPECT_FALSE(test, device_match_acpi_handle(&pdev->dev, NULL)); + + platform_device_unregister(pdev); +} + +static struct kunit_case platform_device_match_tests[] =3D { + KUNIT_CASE(platform_device_find_by_null_test), + {} +}; + +static struct kunit_suite platform_device_match_test_suite =3D { + .name =3D "platform-device-match", + .test_cases =3D platform_device_match_tests, +}; + +kunit_test_suites( + &platform_device_devm_test_suite, + &platform_device_match_test_suite, +); =20 MODULE_DESCRIPTION("Test module for platform devices"); MODULE_AUTHOR("Maxime Ripard "); --=20 2.47.0.338.g60cca15819-goog