From nobody Sun Dec 14 21:15:41 2025 Received: from smtp.ps-zuehlke.com (smtp.ps-zuehlke.com [193.135.254.84]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 286911A0726; Wed, 11 Dec 2024 16:39:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.135.254.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733935181; cv=none; b=Ud8mozKDiQ0jBG2OvNOnubIl7z7FvZD+TdCQutlHQGVWR/+JFeFaFBSzfsvVcBLt3BeQQlAtRdIhS7JcKVdh+A9TvO3m24K6o3aCQ4qO87fXbcUt35aCsrthb/9ghGBAJQolQHXU0di8Kq5MxwL5Q2/tnHwPIHMTRJzZKijk+mk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733935181; c=relaxed/simple; bh=RyWqeoP8DlkITpAgb06Z9urOqB1IzYlqiNZ4kms8ib4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pGbOO+m4GS7Hjc10WfEYLLpBaFfnkxPmnIzEWx02BmhY0NySQTbmPBTATBkZStmY+qyiCPQf3UwOhi4Itz+UnXiyPig5UWsVDMyrLu7vBAgj30WRfQMD28bFeMiV5aH/naBShyv/C7eLDeoPPz7d6DLhDq9yROo2QAM1Xt84qY8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zuehlke.com; spf=pass smtp.mailfrom=zuehlke.com; arc=none smtp.client-ip=193.135.254.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zuehlke.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zuehlke.com Received: from ZUEN49445. (unknown [10.195.248.60]) by smtp.ps-zuehlke.com (Postfix) with ESMTP id C67672B8; Wed, 11 Dec 2024 17:32:57 +0100 (CET) From: Oliver Facklam Date: Wed, 11 Dec 2024 17:32:47 +0100 Subject: [PATCH v3 3/3] usb: typec: hd3ss3220: support configuring role preference based on fwnode property and typec_operation Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241211-usb-typec-controller-enhancements-v3-3-e4bc1b6e1441@zuehlke.com> References: <20241211-usb-typec-controller-enhancements-v3-0-e4bc1b6e1441@zuehlke.com> In-Reply-To: <20241211-usb-typec-controller-enhancements-v3-0-e4bc1b6e1441@zuehlke.com> To: Heikki Krogerus , Biju Das , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Benedict von Heyl , Mathis Foerst , Michael Glettig , Oliver Facklam X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1733934778; l=5156; i=oliver.facklam@zuehlke.com; s=20241107; h=from:subject:message-id; bh=RyWqeoP8DlkITpAgb06Z9urOqB1IzYlqiNZ4kms8ib4=; b=jpvHMUJb6XJgTnrFVZOFQFdYYUlryqhX/lgvkts8YFMTDI9Vr4me82+qn4ThqtQwjESFmmBRA hlvsxU7i0euAEnu3m5MK0MuWl+TYJYTViEFGzgSgc8RqP9IJ5NOe/s0 X-Developer-Key: i=oliver.facklam@zuehlke.com; a=ed25519; pk=bMlB+nko+ewJHQJLwq2t26VDbmRmNDPr/1woleqp7Lw= The TI HD3SS3220 Type-C controller supports configuring its role preference when operating as a dual-role port through the SOURCE_PREF field of the General Control Register. The previous driver behavior was to set the role preference based on the dr_set typec_operation. However, the controller does not support swapping the data role on an active connection due to its lack of Power Delivery support. Remove previous dr_set typec_operation, and support setting the role preference based on the corresponding fwnode property, as well as the try_role typec_operation. Signed-off-by: Oliver Facklam Reviewed-by: Heikki Krogerus --- drivers/usb/typec/hd3ss3220.c | 72 ++++++++++++++++++++++++++++-----------= ---- 1 file changed, 47 insertions(+), 25 deletions(-) diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index e2059b925ab15733ff097e940751759ed51e0ab3..3ecc688dda82a371929e204a490= a68c8e9d81fe9 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -127,8 +127,25 @@ static int hd3ss3220_set_port_type(struct hd3ss3220 *h= d3ss3220, int type) return err; } =20 -static int hd3ss3220_set_source_pref(struct hd3ss3220 *hd3ss3220, int src_= pref) +static int hd3ss3220_set_source_pref(struct hd3ss3220 *hd3ss3220, int pref= er_role) { + int src_pref; + + switch (prefer_role) { + case TYPEC_NO_PREFERRED_ROLE: + src_pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT; + break; + case TYPEC_SINK: + src_pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SNK; + break; + case TYPEC_SOURCE: + src_pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SRC; + break; + default: + dev_err(hd3ss3220->dev, "bad role preference: %d\n", prefer_role); + return -EINVAL; + } + return regmap_update_bits(hd3ss3220->regmap, HD3SS3220_REG_GEN_CTRL, HD3SS3220_REG_GEN_CTRL_SRC_PREF_MASK, src_pref); @@ -160,27 +177,11 @@ static enum usb_role hd3ss3220_get_attached_state(str= uct hd3ss3220 *hd3ss3220) return attached_state; } =20 -static int hd3ss3220_dr_set(struct typec_port *port, enum typec_data_role = role) +static int hd3ss3220_try_role(struct typec_port *port, int role) { struct hd3ss3220 *hd3ss3220 =3D typec_get_drvdata(port); - enum usb_role role_val; - int pref, ret =3D 0; =20 - if (role =3D=3D TYPEC_HOST) { - role_val =3D USB_ROLE_HOST; - pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SRC; - } else { - role_val =3D USB_ROLE_DEVICE; - pref =3D HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_TRY_SNK; - } - - ret =3D hd3ss3220_set_source_pref(hd3ss3220, pref); - usleep_range(10, 100); - - usb_role_switch_set_role(hd3ss3220->role_sw, role_val); - typec_set_data_role(hd3ss3220->port, role); - - return ret; + return hd3ss3220_set_source_pref(hd3ss3220, role); } =20 static int hd3ss3220_port_type_set(struct typec_port *port, enum typec_por= t_type type) @@ -191,7 +192,7 @@ static int hd3ss3220_port_type_set(struct typec_port *p= ort, enum typec_port_type } =20 static const struct typec_operations hd3ss3220_ops =3D { - .dr_set =3D hd3ss3220_dr_set, + .try_role =3D hd3ss3220_try_role, .port_type_set =3D hd3ss3220_port_type_set, }; =20 @@ -200,9 +201,6 @@ static void hd3ss3220_set_role(struct hd3ss3220 *hd3ss3= 220) enum usb_role role_state =3D hd3ss3220_get_attached_state(hd3ss3220); =20 usb_role_switch_set_role(hd3ss3220->role_sw, role_state); - if (role_state =3D=3D USB_ROLE_NONE) - hd3ss3220_set_source_pref(hd3ss3220, - HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT); =20 switch (role_state) { case USB_ROLE_HOST: @@ -293,6 +291,28 @@ static int hd3ss3220_configure_port_type(struct hd3ss3= 220 *hd3ss3220, return hd3ss3220_set_port_type(hd3ss3220, cap->type); } =20 +static int hd3ss3220_configure_source_pref(struct hd3ss3220 *hd3ss3220, + struct fwnode_handle *connector, + struct typec_capability *cap) +{ + /* + * Preferred role can be configured through device tree + */ + const char *cap_str; + int ret; + + ret =3D fwnode_property_read_string(connector, "try-power-role", &cap_str= ); + if (ret) + return 0; + + ret =3D typec_find_power_role(cap_str); + if (ret < 0) + return ret; + + cap->prefer_role =3D ret; + return hd3ss3220_set_source_pref(hd3ss3220, cap->prefer_role); +} + static const struct regmap_config config =3D { .reg_bits =3D 8, .val_bits =3D 8, @@ -319,8 +339,6 @@ static int hd3ss3220_probe(struct i2c_client *client) if (IS_ERR(hd3ss3220->regmap)) return PTR_ERR(hd3ss3220->regmap); =20 - hd3ss3220_set_source_pref(hd3ss3220, - HD3SS3220_REG_GEN_CTRL_SRC_PREF_DRP_DEFAULT); /* For backward compatibility check the connector child node first */ connector =3D device_get_named_child_node(hd3ss3220->dev, "connector"); if (connector) { @@ -348,6 +366,10 @@ static int hd3ss3220_probe(struct i2c_client *client) typec_cap.ops =3D &hd3ss3220_ops; typec_cap.fwnode =3D connector; =20 + ret =3D hd3ss3220_configure_source_pref(hd3ss3220, connector, &typec_cap); + if (ret < 0) + goto err_put_role; + ret =3D hd3ss3220_configure_port_type(hd3ss3220, connector, &typec_cap); if (ret < 0) goto err_put_role; --=20 2.34.1