From nobody Thu Dec 18 05:22:28 2025 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5902046BC for ; Tue, 10 Dec 2024 17:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850636; cv=none; b=cDpYm8XmrrqIl+p5bybEWh3jZPdSExSEBQdvaIehuK6oOQ5Ll88hgAQpMR9/d3wuwovQ+RiGjpHjuztPZJT3ct19ljKwaS7SjMMlf4RAZF5FfEw3mInRPtYiz0L1lVfuiUBm+yLdP2b/VVukm6PvwQzyYLcUn9mwywYTynTlUuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850636; c=relaxed/simple; bh=nYG4Bh/KOUygEwsE3gKVUjg9VDgkI5hhLIDAicMnjio=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=suRznR1wrqWVLkrC3PGgsvJZo3WCUYy6wuZ50Qt1vy0isYoJs773BFhcrqzRltjotZ7VwfwC522RjVAwu2hVt6gzXKM3cLkWvbpK1WtbfmptEYuCXJMnOh2hbKQWyREYLMe1FPPJIvycZp+HKx5chlBNg2BVkLYHCLUNBAvDRHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Fo1i+w3T; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Fo1i+w3T" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d3ea065b79so4489244a12.3 for ; Tue, 10 Dec 2024 09:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850633; x=1734455433; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A+Q7Wyi2VpUxYoA4m3KALmoe6y3o5M1OmNQXa4v/tj4=; b=Fo1i+w3TJi+119cQoeOTad7/37hS8TCOsKVxQ5/NPLbmUw7h0HJt9tPJdTQTMgMwqC 9bOctIBCN4I/yOX51anVUxQBNwSYrOAp2lHKXA52MzkPGScd+bT06LA3c3Q9/kJqmWG0 0LTIG1fpZzhfZryQGu290Cd/XIFbr5VHjzkS8roXYYCJ7I+yvg8hqJ2dFshuNWql2Qrt nhtVcvtkIMrX9DAxFsbiTbDOb+TtbYW+Pj9oPYtksfxu2px7ltzB8Li54IJ5ij0lYEF2 gkJJtQNG8OkUSSYPyxsChtGMK6HSrNCiYluQmDmrXmrlNi9RaDi++XA7cFA2g/HD5m6P gcdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850633; x=1734455433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A+Q7Wyi2VpUxYoA4m3KALmoe6y3o5M1OmNQXa4v/tj4=; b=vxU5cZ9J5FpMulTdlAocJBOEg6+iVpT540XbbMpAgDxj40rEUwEXJYnfILC/ca/CA4 9aEUF0qnzODHPrmO8S1TNEG5KvM/2NtTtrpsUJlcwGkDXa5gLiRRebx66y0XnhI2Cqit VJB+bDM6+O6I8l0zJj2ZpuMHIq+97uQAqfHN0cOC32pxdOtaRZlJye3q9C3qC+68w+dG 8kWTWX//9e8ZJulYHngAjQa25cuJpsQ+WnnVr3OYpywBnYwaFeQ8X1w+ESE8tARDxogR OHn8AJY9FkPqvE+zlOmrx6HBHyeQEzGHsUKEXObxIri6Q9+nWpVVtC1KrugyZVOIKGEu hrZw== X-Forwarded-Encrypted: i=1; AJvYcCW3L87xJ90ei/iq9aJa8nuPNFbKdv+FjHBOjSCxmVmnGpPiB7fH80nzj7jszXH2VMH2JipQCrNFXzfZPp4=@vger.kernel.org X-Gm-Message-State: AOJu0YxzJ0fs8ZX1UBhGA3aLCFhN6DsUxPRyaC6FKi22aEhaCxrCuMjj qfKwQIj0N3QmJDK/pqq5Kw7lfxCxoKI/6cOP6mYfHWMrj+mN4baNBLGQKBedXjI= X-Gm-Gg: ASbGnct8M26S9cIE96MPG9wM+RacyrJn43wihK3uQAIdpWQ9HKlgL8+eqOPU5L4Rix8 wB4jgYh6cagUCNb5438qg1otRK7nmLXdThZ907rgM6wjiZ35jKWyMCGhKekSuT5IrPDsFeE7Mm9 qfYAim5dZ+vXxMkp2kJQyeTIOFmNRChL9UeC+ILUVzs6R+uI1AzcZepyWMpnYtcRAZT7ZiY912f JzuDB9ha/VFlahqtkNhDhgos5OW0D6UDntaWIv8qIBmjWxqvheGs/bNcsqYEAvdBeaifXUhIfYB Nic+PICS X-Google-Smtp-Source: AGHT+IEBCVJ5ksFpp4FwClVaCrJfMHHPabOYnva4BY/zYpG72K/0Fg/nCKLr56XOe4brB+WYlaK2nA== X-Received: by 2002:a05:6402:2688:b0:5d2:7199:ae6 with SMTP id 4fb4d7f45d1cf-5d41852f3dcmr6281078a12.9.1733850632877; Tue, 10 Dec 2024 09:10:32 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:32 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 12/24] ASoC: renesas: rz-ssi: Use goto label names that specify their actions Date: Tue, 10 Dec 2024 19:09:41 +0200 Message-Id: <20241210170953.2936724-13-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Use goto label names that specify their action. In this way we can have a better understanding of what is the action associated with the label by just reading the label name. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 74632e2482f8..209b5b8827e5 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1084,15 +1084,15 @@ static int rz_ssi_probe(struct platform_device *pde= v) /* Error Interrupt */ ssi->irq_int =3D platform_get_irq_byname(pdev, "int_req"); if (ssi->irq_int < 0) { - rz_ssi_release_dma_channels(ssi); - return ssi->irq_int; + ret =3D ssi->irq_int; + goto err_release_dma_chs; } =20 ret =3D devm_request_irq(dev, ssi->irq_int, &rz_ssi_interrupt, 0, dev_name(dev), ssi); if (ret < 0) { - rz_ssi_release_dma_channels(ssi); - return dev_err_probe(dev, ret, "irq request error (int_req)\n"); + dev_err_probe(dev, ret, "irq request error (int_req)\n"); + goto err_release_dma_chs; } =20 if (!rz_ssi_is_dma_enabled(ssi)) { @@ -1136,7 +1136,7 @@ static int rz_ssi_probe(struct platform_device *pdev) ssi->rstc =3D devm_reset_control_get_exclusive(dev, NULL); if (IS_ERR(ssi->rstc)) { ret =3D PTR_ERR(ssi->rstc); - goto err_reset; + goto err_release_dma_chs; } =20 reset_control_deassert(ssi->rstc); @@ -1152,17 +1152,17 @@ static int rz_ssi_probe(struct platform_device *pde= v) ARRAY_SIZE(rz_ssi_soc_dai)); if (ret < 0) { dev_err(dev, "failed to register snd component\n"); - goto err_snd_soc; + goto err_pm_put; } =20 return 0; =20 -err_snd_soc: +err_pm_put: pm_runtime_put(dev); err_pm: pm_runtime_disable(dev); reset_control_assert(ssi->rstc); -err_reset: +err_release_dma_chs: rz_ssi_release_dma_channels(ssi); =20 return ret; --=20 2.39.2