From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F293C237A20 for ; Tue, 10 Dec 2024 17:10:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850611; cv=none; b=tbEprwv1pe2ijTqH1Ol6VgiPsN0dsMoGs2r+YZmUlvEvt16VNaGruwvL65uXNkg0uLqClSY/hHJKL8SnmPUkghtLhmCOcREQ/pa5thiRZwWB7w7Xb3bLCGty1XTqGXSxUm15NoqbzPQhOuA5v6fZ0jT0g/XC0GeeCDWkQteOIVc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850611; c=relaxed/simple; bh=xBCdUB4AW8mhnjHqG44vkCdEwLfV+6wgiY3J65tG+OY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZDrbyAGLCb4p/YbHgt4UKOzMdeWqaUjUbacckCsqX+UTD4InDmvtPSKpU7U84bOlaw3g8ovAR9i/Dc67JAqYigdCEQGir2rDvOl4oFqtfUS3RkfsPgZ2FONaU+yS+d09XOX6A63meNUHtqw2apE1yQdRw2URSIFoQs/tMLSdiGI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=qwepIQu8; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="qwepIQu8" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso3810442a12.0 for ; Tue, 10 Dec 2024 09:10:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850607; x=1734455407; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uadH9PhfIl+f0c96d/6lazQpTxglh5DEUY3M9hlx46E=; b=qwepIQu8Yg6rq7XNULediZPPpEvxO93yeuXndvMNU0jbQ/voAmEBjkAxOZ6e6rsxUC FK1SfzKx4XWvU1YQ3TAFb92flx3FGRzIR6zZ92Y7MmnlZNzsEvJhuiyRWdLCSKsct2lY cDxy0+F3Y0rLBzVgos2JQ0C47F57+8Zv98/uEHA+x/6H6Q/KpprkqZQ9otSyy3HQ5IuW eYMBbUP6pG6QifLHnNMV7QIYyRcCSHa6fsSOA7WlnfWPFnsyb9fSqUTaULNBdf6Ha1jy n6mfe8+Oqd1NLmwFALkYbAHJ63Jx+HZanXq55UkoRX4ZQs+IBB9BFVQcg7aymtqSAYfm JMiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850607; x=1734455407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uadH9PhfIl+f0c96d/6lazQpTxglh5DEUY3M9hlx46E=; b=hBlQFux6ontFpdl33j7/R0co2fhsXcRE8L0RXfU39W0hd0kNN8wQMZUsGT5ucCNE0f n04BpfEwVxtO0W+A/30drd0Gd/Qe8+/XRcWc68zhXDZdood58a6P51g5iqycgRV8oCdM sSdQtU6ZGN8mdS73einf9vKrBM1UqSZJYJ4rqN8jP7cbg0qmllwfqtcQikGea4Dxdn6e tlpm0VvOBIQCxuXV9Z58qvFEJGUtLNfF9Bf2NAsif4TU2I7Dt98dMlAHahm0K1OGogN3 xj7onP9uI557tDnSrkmx/ndcBl8gb2mzJ0pgNFdvOrcCIClBdbpmpxiek1au7c4h3p31 vFuA== X-Forwarded-Encrypted: i=1; AJvYcCVcnlL852RVfE10R5ORCD4SXMJKeR5QO5kvhDFmD+etlLfTxpssZ/iEuRTmJdNkRpLd/+IcMx6U1hDj2mI=@vger.kernel.org X-Gm-Message-State: AOJu0YwP9BTvfqAWEKv6XcC7T5zFD9sxMVee0b5Csc3nc5ctJ0qXhhfd 3OkCV0VQq/nJunkE3T8pw++LiBYRH5hCMQT5eWb413Jx8mrDKiE1WPgt+LVPQwg= X-Gm-Gg: ASbGncu/+RwAd80Nmms+YXnurYgcG5ojTctcI+IXGGFrF/aVD21DglqBoHKB6wjdFtM x9A2NAVuPB00AmG68IAK1sYK8zL3a2UHU6nR8n9pX3vWgKBDPQ9hRAl8gPz2S9FJel+RZBKfe44 pvFjZyLrNQGlHQ+DvdAQCWGaYG+7VMVtyxEH8alWiqgZDsgvYUPGrnNdxQKaYoTbEfFoL/x6Gcn dL+fE/TkH2DxTJ2wFb31f6Klr+570kM+5ouyFDGEsFSWPUenL4/d4NSxNWdSRxCoTeDkRjTJCRU 5bAlBuJp X-Google-Smtp-Source: AGHT+IGFg61AhXK6q2yCp479aYEgRKUVM1++05q63Nd9oxa57q0bisHWfgqRash6JB5OY1cEW+iywA== X-Received: by 2002:a05:6402:4005:b0:5d2:7270:6125 with SMTP id 4fb4d7f45d1cf-5d3be6889e3mr17256633a12.8.1733850607270; Tue, 10 Dec 2024 09:10:07 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:06 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 01/24] clk: versaclock3: Prepare for the addition of 5L35023 device Date: Tue, 10 Dec 2024 19:09:30 +0200 Message-Id: <20241210170953.2936724-2-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The 5P35023 and 5L35035 Versa 3 clock generator variants are different but the versaclock3 driver could be used with small adjustments. The features that are implemented in driver and differs b/w variants are the PLL2 Fvco and clock sel bit for SE2 clock. Adjust the driver to prepare for the addition of 5L35023 device. Reviewed-by: Biju Das Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - collected tags Changes in v2: - none drivers/clk/clk-versaclock3.c | 61 ++++++++++++++++++++++++----------- 1 file changed, 43 insertions(+), 18 deletions(-) diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 76d7ea1964c3..1398d16df5d0 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -78,9 +78,6 @@ #define VC3_PLL1_VCO_MIN 300000000UL #define VC3_PLL1_VCO_MAX 600000000UL =20 -#define VC3_PLL2_VCO_MIN 400000000UL -#define VC3_PLL2_VCO_MAX 1200000000UL - #define VC3_PLL3_VCO_MIN 300000000UL #define VC3_PLL3_VCO_MAX 800000000UL =20 @@ -147,9 +144,13 @@ struct vc3_pfd_data { u8 mdiv2_bitmsk; }; =20 +struct vc3_vco { + unsigned long min; + unsigned long max; +}; + struct vc3_pll_data { - unsigned long vco_min; - unsigned long vco_max; + struct vc3_vco vco; u8 num; u8 int_div_msb_offs; u8 int_div_lsb_offs; @@ -166,12 +167,17 @@ struct vc3_div_data { struct vc3_hw_data { struct clk_hw hw; struct regmap *regmap; - const void *data; + void *data; =20 u32 div_int; u32 div_frc; }; =20 +struct vc3_hw_cfg { + struct vc3_vco pll2_vco; + u32 se2_clk_sel_msk; +}; + static const struct clk_div_table div1_divs[] =3D { { .val =3D 0, .div =3D 1, }, { .val =3D 1, .div =3D 4, }, { .val =3D 2, .div =3D 5, }, { .val =3D 3, .div =3D 6, }, @@ -386,10 +392,10 @@ static long vc3_pll_round_rate(struct clk_hw *hw, uns= igned long rate, const struct vc3_pll_data *pll =3D vc3->data; u64 div_frc; =20 - if (rate < pll->vco_min) - rate =3D pll->vco_min; - if (rate > pll->vco_max) - rate =3D pll->vco_max; + if (rate < pll->vco.min) + rate =3D pll->vco.min; + if (rate > pll->vco.max) + rate =3D pll->vco.max; =20 vc3->div_int =3D rate / *parent_rate; =20 @@ -680,8 +686,10 @@ static struct vc3_hw_data clk_pll[] =3D { .num =3D VC3_PLL1, .int_div_msb_offs =3D VC3_PLL1_LOOP_FILTER_N_DIV_MSB, .int_div_lsb_offs =3D VC3_PLL1_VCO_N_DIVIDER, - .vco_min =3D VC3_PLL1_VCO_MIN, - .vco_max =3D VC3_PLL1_VCO_MAX + .vco =3D { + .min =3D VC3_PLL1_VCO_MIN, + .max =3D VC3_PLL1_VCO_MAX + } }, .hw.init =3D &(struct clk_init_data) { .name =3D "pll1", @@ -698,8 +706,6 @@ static struct vc3_hw_data clk_pll[] =3D { .num =3D VC3_PLL2, .int_div_msb_offs =3D VC3_PLL2_FB_INT_DIV_MSB, .int_div_lsb_offs =3D VC3_PLL2_FB_INT_DIV_LSB, - .vco_min =3D VC3_PLL2_VCO_MIN, - .vco_max =3D VC3_PLL2_VCO_MAX }, .hw.init =3D &(struct clk_init_data) { .name =3D "pll2", @@ -716,8 +722,10 @@ static struct vc3_hw_data clk_pll[] =3D { .num =3D VC3_PLL3, .int_div_msb_offs =3D VC3_PLL3_LOOP_FILTER_N_DIV_MSB, .int_div_lsb_offs =3D VC3_PLL3_N_DIVIDER, - .vco_min =3D VC3_PLL3_VCO_MIN, - .vco_max =3D VC3_PLL3_VCO_MAX + .vco =3D { + .min =3D VC3_PLL3_VCO_MIN, + .max =3D VC3_PLL3_VCO_MAX + } }, .hw.init =3D &(struct clk_init_data) { .name =3D "pll3", @@ -901,7 +909,6 @@ static struct vc3_hw_data clk_mux[] =3D { [VC3_SE2_MUX] =3D { .data =3D &(struct vc3_clk_data) { .offs =3D VC3_SE2_CTRL_REG0, - .bitmsk =3D VC3_SE2_CTRL_REG0_SE2_CLK_SEL }, .hw.init =3D &(struct clk_init_data) { .name =3D "se2_mux", @@ -982,6 +989,7 @@ static int vc3_probe(struct i2c_client *client) { struct device *dev =3D &client->dev; u8 settings[NUM_CONFIG_REGISTERS]; + const struct vc3_hw_cfg *data; struct regmap *regmap; const char *name; int ret, i; @@ -1029,9 +1037,16 @@ static int vc3_probe(struct i2c_client *client) clk_pfd[i].hw.init->name); } =20 + data =3D i2c_get_match_data(client); + /* Register pll's */ for (i =3D 0; i < ARRAY_SIZE(clk_pll); i++) { clk_pll[i].regmap =3D regmap; + if (i =3D=3D VC3_PLL2) { + struct vc3_pll_data *pll_data =3D clk_pll[i].data; + + pll_data->vco =3D data->pll2_vco; + } ret =3D devm_clk_hw_register(dev, &clk_pll[i].hw); if (ret) return dev_err_probe(dev, ret, "%s failed\n", @@ -1059,6 +1074,11 @@ static int vc3_probe(struct i2c_client *client) /* Register clk muxes */ for (i =3D 0; i < ARRAY_SIZE(clk_mux); i++) { clk_mux[i].regmap =3D regmap; + if (i =3D=3D VC3_SE2_MUX) { + struct vc3_clk_data *clk_data =3D clk_mux[i].data; + + clk_data->bitmsk =3D data->se2_clk_sel_msk; + } ret =3D devm_clk_hw_register(dev, &clk_mux[i].hw); if (ret) return dev_err_probe(dev, ret, "%s failed\n", @@ -1108,8 +1128,13 @@ static int vc3_probe(struct i2c_client *client) return ret; } =20 +static const struct vc3_hw_cfg vc3_5p =3D { + .pll2_vco =3D { .min =3D 400000000UL, .max =3D 1200000000UL }, + .se2_clk_sel_msk =3D BIT(6), +}; + static const struct of_device_id dev_ids[] =3D { - { .compatible =3D "renesas,5p35023" }, + { .compatible =3D "renesas,5p35023", .data =3D &vc3_5p }, { /* Sentinel */ } }; MODULE_DEVICE_TABLE(of, dev_ids); --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A771237A2F for ; Tue, 10 Dec 2024 17:10:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850613; cv=none; b=bGWOK/8eHZU6oB3se0VxSIEIEOhB6EY23wR7hMWNdd0OXU+sesGY0LwjOMON3T5jjyrRVBVJLT0B9RjIa+cpBBQTAZnGvpx4TZvbNZBoSM9uGmsShla6BLUC1wuJ/tKIAMYs9l1akufED1LFrilW/m3VC3ju7qsP6VZxzzTF0X0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850613; c=relaxed/simple; bh=28M0DwDkMWfh/cCYd77FlED8MgZgXdkVNsI9ruq8oCo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rPVPnbQd4R09QfeftdfoHt7vWZpEGf8uV+xevi6RTzItbpmSsWeUt4LxbqFsyib8z7lvHNopkmTDKCx9hB/fM4Rjb6DdhW8dtmiJY8hUCGlrNGG0QgSe+ZL1Qq1njfO0lzowyoqma6djGpjR0OiJOuCzezVaZspmbsg4K1+loN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=MQzjBXDp; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="MQzjBXDp" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5cf6f804233so7354853a12.2 for ; Tue, 10 Dec 2024 09:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850609; x=1734455409; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ehtFOxPVmrl0HXvdtrtv9cXQJbKgItgUhCJ0+pIiLcI=; b=MQzjBXDpRt18BnyVhFu9LW0hpGwvvwgHbxOjUiClJRXR5FVfaLIcqTvY+AH+LG3Kym v6A3midGaWsqoE1p7IqYJmQlSfnloI8iql6JSIms2HdJ5zZNEm663ModvEElq7Lihl3M OYgG5fJ3Tm5LgkoTXe0ZwLfAJg0Qb3N8/3+eWq2pg7ZQe24Er7zOp/5n9fCv6pOfwhWX N90AH9dvQZem8yoXZKO9Mbsw0pqeO1fqEn4x4SjZG6fE64Btrjc6mzUPACvHIr8ojC2f yoLrRyr9hGVHj17l9COx+a7NKAeIFVYt3z1bb2wf6AZ1Hlo/+7TMnth9iS9asdpKEm3o 7Buw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850609; x=1734455409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ehtFOxPVmrl0HXvdtrtv9cXQJbKgItgUhCJ0+pIiLcI=; b=L/kM5WY8wkoeGxYBRKFvx4oqqyl4j/LiNnSXu5FRmCb8XNMDY3nh/BpG8BL3kZaEz9 3h2zjGpbLvPITCgYKgdMBlot7hZB5VNF7i7ox87IkaIqHPBO/rmZDdgdledQoBKJ5xff CxrSikQ1n9da6hAGJYBuMGIfRKvVHBZp7gUqv8AuTm8+sbzbovHQdK6SklO7HikZ6oJv g5QqaHs2wqT9whmmcYXPExPJHAl+/E3k9oBqiHEfk979xlB9LvLTWLUYkqokvysj83II rlkYpv8WH2k4N8Kq5vLBwJwdjlDd95j1WXKXaxrhcHLaZHpHURzXF+M9/ENmbNZBHHmc vatA== X-Forwarded-Encrypted: i=1; AJvYcCWOGSvi/NnxAi6AMQC6nWqLNVNVLuXy4OTn1QdsSyLKlD+S4d/4ubp7V/pOK9elFYGisF6uhUSId2ILKNc=@vger.kernel.org X-Gm-Message-State: AOJu0YxNUTZX/RUnD7d6SmfCD9umO43F67tgegoQ+rbcqZnal2ydF2ju ofGY17yew+1RyzOlMYjBsfX6xafPSpYbWePtcAMm+Seela416oJ1MT0VRDOLlas= X-Gm-Gg: ASbGncu7ULAWFbq3WrxctC6O2rkrchNbrmFLInt59Oi1azENeSHfRaV0psbcEN3DTeJ 8AcDf4sPHYDCpsfzUWG/vqMSBuxP1e6IiHDWDCmVym9Oh8uLC3awUQt40vLRSCM1F8iQkwnG80U kigfIIAlyo3S1QgUzT/2E8E/9kllsgTKgtC4M+1yGwankcJ6eej+GwbCw4DGAFbwNGeQZlhKPo8 q8YdoePrIP5CSH+WNZr3Q0vWtihBrVu4+or4qP5sTOeiCV3pmxNKwMWj9T4jfjWsfyeAvUi5VXc UxYbPe9A X-Google-Smtp-Source: AGHT+IFmnNKXXAN067E1UbwhBJfMpK5O10AWTX9+hlwh80SSPAEOWU+7C2pI3MGNxXbuHtb4mGyh4w== X-Received: by 2002:a05:6402:1ed6:b0:5d1:3da:e6c with SMTP id 4fb4d7f45d1cf-5d41853e70cmr5928380a12.10.1733850609561; Tue, 10 Dec 2024 09:10:09 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:09 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea , Krzysztof Kozlowski Subject: [PATCH v4 02/24] dt-bindings: clock: versaclock3: Document 5L35023 Versa3 clock generator Date: Tue, 10 Dec 2024 19:09:31 +0200 Message-Id: <20241210170953.2936724-3-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea There are some differences b/w 5L35023 and 5P35023 Versa3 clock generator variants but the same driver could be used with minimal adjustments. The identified differences are PLL2 Fvco, the clock sel bit for SE2 clock and different default values for some registers. Acked-by: Krzysztof Kozlowski Reviewed-by: Biju Das Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - collected tags Changes in v2: - collected tags Documentation/devicetree/bindings/clock/renesas,5p35023.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/clock/renesas,5p35023.yaml b= /Documentation/devicetree/bindings/clock/renesas,5p35023.yaml index 42b6f80613f3..162d38035188 100644 --- a/Documentation/devicetree/bindings/clock/renesas,5p35023.yaml +++ b/Documentation/devicetree/bindings/clock/renesas,5p35023.yaml @@ -31,6 +31,7 @@ description: | properties: compatible: enum: + - renesas,5l35023 - renesas,5p35023 =20 reg: --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57666237A5A for ; Tue, 10 Dec 2024 17:10:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850616; cv=none; b=WffwVb/r+YrkNE+ajgj365w2dKqNPj19YZBjBiYTNz2TcnvVL1B7X1OTYIoK98tel288opUf9R/780p4Xu8RNNuIKYeNjNyYDSALVZvbX5S79dvJJ/WBpIVxfjJcmBhAFaNIUkqqBPVGALjOy8kjWahP3NE8cvPnGC9jR5AQBk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850616; c=relaxed/simple; bh=OTYVPrJXZsCibJypCZf8QK2KZMdsmtd9T0kWyznh0q0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=OjgOIvRGgnJsKT4sMLekdnJ3MJZOnJ9yFl5xTLbl0UCViOLQDSsRAhhDJUGINuee+YenZdUHwBf0W0UGFE8C3zLAydr8YcSQMix5fFda0VUdAjeEU3T0t+IFbV5l856q93rrwSId5pEo4IhkiQsDveZ67oPqOo4gsugn+r93URo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=bHzgadTq; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="bHzgadTq" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d27243ba8bso8671797a12.2 for ; Tue, 10 Dec 2024 09:10:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850613; x=1734455413; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y4VjqX7iwW/vu6N1WvzJJpy4sCnLnXPgQs452O7qiog=; b=bHzgadTqkHFD23BtqN2KbvqYcbXCWKNUpmCFiMAvclw4XLSAoYgrzQ3jl0PppOLaGC 2guV1KrjMFb/xNpNtSVhLLhizXZkv/WVqDyhAK4+0zvCiKgaN8qASbW/DZ0ESOVWhcYr 2mAtA2hpqZtUouIL8PyLmxSVpGapr/QtPWRkV0WIr3etRR7WM4oQ3uj4WFfeig3nJjR3 RX4aMNwM5coMXfJy0wXFRf8RLOIrtDJelVmkR+EKSp/qt4GRM9CdKxhpTNeHCUhvtPuu kMcyUIziiPvWZFq77/6D46/4wGYT0Gm8pWaqHjIPImy5VHEVA5Cr+o1puS89MMbcjWzb 0nrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850613; x=1734455413; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y4VjqX7iwW/vu6N1WvzJJpy4sCnLnXPgQs452O7qiog=; b=G0DUaupXf6PEXe/ecHFCXNZMsx6jIgMaWZXChc6wHBdey28fQgblaMWJAXqvEUTTXP +6uvlcsPRwJbfVVjvUlxMskxICnEg/Telv/S7XbBewXq2Tmfnevn9wDa/7VMX4AP5waI p+qzoJnR01n0kJ7GZ8K8K0Djrt9EO32UfxFn9i8MpaFZJdH7IrfmES8fjyq+NXkKhpAG Ws/CixR6dG7k/PVZe2F/n1ku3gQwSlvbddH2t2QiIyXICNImJdlfHDR1p5nDfcaF3Jyw 13YjF5cOI4DmqOovJAx2KY05PW/rIR8pDKogtMsO2WJYRsSmZbv1JHpFld+0Kop1o0Cg 134w== X-Forwarded-Encrypted: i=1; AJvYcCW+yvzQp28q8ivlJZfkQNJKxZI8J0kJyIyuNNMSqw+th+PrzNSVR0ypcTz6MYNFLBVErjCFfX5h4pzHeHg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxb1lKJgLZgtWzGEroROuNEWNz0DFbsHZ9+YH8TZCmgVZuTmPyo CphnxEFPhB3zYcwNdUROod72CVJETTGU2Znbe+ITidycNmMT7wcpHnaoGVkhYf0= X-Gm-Gg: ASbGncs5UxIZvsn35/LMAnfFJCy8Tz3vrHvT+jeGuJrZ4iIpXBN1Dr9GCXRMWJMgdW6 sAfztKSeQx0SPYJvkcsnf1BPksNVby26Mmk8FB5p2cSjvFfFDfGuoZ7BtWHzhfhsxdUwfmUM30o 80AG4fDW1GNThCFInP6vPv1W6dteqgw0pEa8nuzhbcphvhMrDtFat+TOagUFYQ9pTLN8SeXD8eR O+xldrO22RVizOcoz1Hreoucq5hzYr/ZWjTDmlFgkaI+ml1GrNK381q/HuQxcFovKIvhXC+Hs5T yb47hBuq X-Google-Smtp-Source: AGHT+IF1pww2qqLE9zMCq4Z4/K+bkG+iAYWr1I2S2Beewnfd6QMcuan64k6kobi5emQ4TB2NMs4iTA== X-Received: by 2002:a05:6402:13d4:b0:5d3:ba97:527e with SMTP id 4fb4d7f45d1cf-5d4185fea2fmr5584908a12.25.1733850612616; Tue, 10 Dec 2024 09:10:12 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:11 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 03/24] clk: versaclock3: Add support for the 5L35023 variant Date: Tue, 10 Dec 2024 19:09:32 +0200 Message-Id: <20241210170953.2936724-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add support for the 5L35023 variant of the Versa 3 clock generator. Reviewed-by: Biju Das Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - collected tags Changes in v2: - none drivers/clk/clk-versaclock3.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 1398d16df5d0..9fe27dace111 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -1133,8 +1133,14 @@ static const struct vc3_hw_cfg vc3_5p =3D { .se2_clk_sel_msk =3D BIT(6), }; =20 +static const struct vc3_hw_cfg vc3_5l =3D { + .pll2_vco =3D { .min =3D 30000000UL, .max =3D 130000000UL }, + .se2_clk_sel_msk =3D BIT(0), +}; + static const struct of_device_id dev_ids[] =3D { { .compatible =3D "renesas,5p35023", .data =3D &vc3_5p }, + { .compatible =3D "renesas,5l35023", .data =3D &vc3_5l }, { /* Sentinel */ } }; MODULE_DEVICE_TABLE(of, dev_ids); --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67E6D237A59 for ; Tue, 10 Dec 2024 17:10:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850618; cv=none; b=AyjK+U7HMUAEoalg0V2adWMeIZLQW2bmKBrdeNUxfJSsX7C1CsIoIwPuhJKnVny8wnk3nGzyDTEjPI6LBHbvQbteznDfLjyKp+7oznUUD5tQkdibIPYTOwB5A+JzZ0ond1wlucVSjDOzVZax914gp5+FGisawU9hr405RB6vNB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850618; c=relaxed/simple; bh=o6bb+5TT8a4+4885SQUIo5IIlBm8LtwjyGEaLw06x18=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NJbU5ec1nxL4yFj4XoFd/6F/WwDFOJ8ePmqZf/qjHqmrNl80RgryL8d5H+V48WCUjXuNCXNexAm/pCx1hDcPH2+z4l53/hNMkTxCl7IWK63NALG8kfe7OKYvIaMcYzsk0sHMDip3bbpT/A6Fd6R3cJmuno3A2KI8sMa33xSwiTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Z8aS1rFk; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Z8aS1rFk" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5d414b8af7bso3087807a12.0 for ; Tue, 10 Dec 2024 09:10:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850615; x=1734455415; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qo27pKYlk9UKLBg0czdTh7Uwm7olEalHUIHQAM8AonU=; b=Z8aS1rFkPFcW6HVvHWEvY3y1gaA/3L8R4Y98KSpWWewm5TtWDlhTKpXZpV3K77P/4c N2wqVl0vJ+oPaKCY7GdIUhj2aYeo1oHpZUecZOGzAbaXLIPtnCXOA1EemDfWm9c1ZLgg M9CWLqbsW9uJUOhykjAVP29IClLpmLF3aXFYIU+cBFiVbAgrdaAQlOVr3ftX5biZBNUt 2sS8bKUzq82r2zT1gvyFXzlbxxVQOoDpk3w7JpbWHTcCly5WGb95yy/qyUn3Vuv/wSk2 ynDhUmd2NGKP26b9mYYJVxMuBXjw3RmbDNx1jnUnI60IJKxnVG6vqJS82eTB6It62ydr mK1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850615; x=1734455415; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qo27pKYlk9UKLBg0czdTh7Uwm7olEalHUIHQAM8AonU=; b=O9cczWWuqsZqVZj5l/cG2x6OFIqphJ4vfafaA1p00a7APqyqzpdpURrVKDnG4/mBAi A7FoTZVX1DskQZxxRHeNfCh8YAMaPDczIvZvv9w/8UkkJaNre/L06hakY1Iih2LmsQ1F B2A5L56TJBctBGo61GjAjSV8hEJrJDZhHqnlAA2uIz609zZ9VFRQwZT6ySJA0pMg0leV y86RCCmBUiYZByQRGhM7pn7SrFhMYxNy7O2qB1qd2SB2otYjMJtoKp7HAozGITzfdGEa Azx8D8cXuQi1oRG3+bPw4sx4zQws0Ow/YIvpeppvysqrLYmM0fP1j6vrYWoVurl1wT22 tPGw== X-Forwarded-Encrypted: i=1; AJvYcCWKNR8g2hJWONu+RUPoNPCn3TqvNao2NzHISyGhfdjzarBREMHawIpMAjh+6fivHsj7sOYoQ8sU4rpip6o=@vger.kernel.org X-Gm-Message-State: AOJu0Yxs/yvc5dYCOffn2vIQdJubB04KSrRRy3243lRC8WHbV0LD4Ko2 bMH4nS3eJ7I/+DHokM8V3CVkHPZMV9VGVouOfvxxqF4OHzzFySDMqpYmVQ4YgBA= X-Gm-Gg: ASbGncsEN4Z6l0kb09fB9O+7UXInHp6WOIqRmp37gXpMyOeVy78onBS299Reci9PQsX C3AKQYn5aG5eQD/tbsnjm66qOydJ4YwPSOgffg36Yo/3071d0T6rh3sYEkPsO+AaQe86YTCXMMb +YMsoN8v9qvNjuUjIEbkKfw8VHcYDwk4DlnQ1dTHH20XZl1PYz36GQeB1FWntIosShF7lou6JY2 OvA26YwPpd0FSoLgFur2I0tnBCzDASrkmLaDVCsSJPFUPOPHaIWvJn60HQwoeupsY0xSNscGQen AvuXgmF8 X-Google-Smtp-Source: AGHT+IGWUjWO6EYZ1uAazblGzPDgU2K3A7r87jOiz1TUWyFTmpyxPZFuPXfCgEn67jBfzXe1r6LxEw== X-Received: by 2002:a05:6402:11d1:b0:5d1:f009:9266 with SMTP id 4fb4d7f45d1cf-5d3be65f80bmr15150003a12.2.1733850614698; Tue, 10 Dec 2024 09:10:14 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:14 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea , stable@vger.kernel.org Subject: [PATCH v4 04/24] ASoC: renesas: rz-ssi: Terminate all the DMA transactions Date: Tue, 10 Dec 2024 19:09:33 +0200 Message-Id: <20241210170953.2936724-5-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The stop trigger invokes rz_ssi_stop() and rz_ssi_stream_quit(). - The purpose of rz_ssi_stop() is to disable TX/RX, terminate DMA transactions, and set the controller to idle. - The purpose of rz_ssi_stream_quit() is to reset the substream-specific software data by setting strm->running and strm->substream appropriately. The function rz_ssi_is_stream_running() checks if both strm->substream and strm->running are valid and returns true if so. Its implementation is as follows: static inline bool rz_ssi_is_stream_running(struct rz_ssi_stream *strm) { return strm->substream && strm->running; } When the controller is configured in full-duplex mode (with both playback and capture active), the rz_ssi_stop() function does not modify the controller settings when called for the first substream in the full-duplex setup. Instead, it simply sets strm->running =3D 0 and returns if the companion substream is still running. The following code illustrates this: static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) { strm->running =3D 0; if (rz_ssi_is_stream_running(&ssi->playback) || rz_ssi_is_stream_running(&ssi->capture)) return 0; // ... } The controller settings, along with the DMA termination (for the last stopped substream), are only applied when the last substream in the full-duplex setup is stopped. While applying the controller settings only when the last substream stops is not problematic, terminating the DMA operations for only one substream causes failures when starting and stopping full-duplex operations multiple times in a loop. To address this issue, call dmaengine_terminate_async() for both substreams involved in the full-duplex setup when the last substream in the setup is stopped. Fixes: 4f8cd05a4305 ("ASoC: sh: rz-ssi: Add full duplex support") Cc: stable@vger.kernel.org Reviewed-by: Biju Das Signed-off-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven --- Changes in v4: - updated patch description Changes in v3: - collected tags - use proper fixes commit SHA1 and description - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 6efd017aaa7f..2d8721156099 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -415,8 +415,12 @@ static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct= rz_ssi_stream *strm) rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TEN | SSICR_REN, 0); =20 /* Cancel all remaining DMA transactions */ - if (rz_ssi_is_dma_enabled(ssi)) - dmaengine_terminate_async(strm->dma_ch); + if (rz_ssi_is_dma_enabled(ssi)) { + if (ssi->playback.dma_ch) + dmaengine_terminate_async(ssi->playback.dma_ch); + if (ssi->capture.dma_ch) + dmaengine_terminate_async(ssi->capture.dma_ch); + } =20 rz_ssi_set_idle(ssi); =20 --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 126B6239780 for ; Tue, 10 Dec 2024 17:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850620; cv=none; b=fI23dF3WNV02oQATP+xgNeZUEOUbw5/IXBXRlrHNc24qtz3n0tH+fdqUOudI3hdY8YQ03RbuxElKMsUyT8VCP+px9dOxh0JThMh/slTgdhsN0TXPIhBKTeOKLa20dAGfXVT9ViOYMtLZyahtOfGSConqfgueVNVJ9LXzNYqdfZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850620; c=relaxed/simple; bh=cYpvDeE6GTSqLQn4hyIC1LguXTCN6MR9BcYpMn3wlfA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=fPlOsglng0N069lEpRFIj0mDMk3j4oob4Va95ES0qarfTDjKCSihHUBN0dphVYOMEuBCvx09Rd1rd/KIxW909aBEsfGyi/kiSqLGhr/KMd4MImPna9FsPwhwRrFT7ezTquYhuwuHj0yZyNC9UJ94AUic3jW7ZJWrGqfSlmwBJyc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=L2bV9tXv; arc=none smtp.client-ip=209.85.208.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="L2bV9tXv" Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5d3f57582a2so4458849a12.1 for ; Tue, 10 Dec 2024 09:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850616; x=1734455416; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WRP6aXMQvXzM2V4VFmQeuWDqqgGNHEkIoJ0Wes8B7Jk=; b=L2bV9tXva4tdVQ/BevOqjIS9pdswIp8ld+5SLzEWysDscaLRaAJvjzGR5tDJiw1luy WMJounXTaSWsOcIJ5K2zcFMft8+FvV3SA2EBuI5eJaIW5XGT9OcigFvWXAnjGbw4Xm9v P84S9ue930Edv3/RJy5H+9c8BbyovRWJaF466n/rDo1qAQfaIIBdf5+8zSalq27ZfU4P /6SJfOA6fzbJpKjB6avY0NMM7+R9tCSdT7vWTHySTELllvYrRgKLRKSKNGjDzbei7dA8 mEMFSIXv/hTjmCTxNXx5PYGHN5uOwWgLelIAOgEyEAJGN7BXIQ6rgjY3Vcd2HX+tR+ju 4+NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850616; x=1734455416; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WRP6aXMQvXzM2V4VFmQeuWDqqgGNHEkIoJ0Wes8B7Jk=; b=rf/voM0DOFZLRL0nAbyISJFA5ZN/fr8YNOdix00PtMWiHlVRFTNXblG5m6sT474HGJ W+5dj7UPXYulTWhOXtUcav0DQxvmrt6xLSBP+dk00DUDfeyJ099QU/1cvsEc+kRVs7sM 3ZmmJ7rC4sZVZjaTAkaK0DTCdXUNs6ppaFznZE2cbmH8i9JY+e15H0ZKuuDdFIhGwYG0 7JcxxCM9AU5DTLJ+pgI7xkCIqT9bosOjR1HSMrghMWCvgAQ+hnVKxbetl0tuJDR/zah4 ifKzORhyNs7PcaI4AG3ylSvnsYgjl4uWcCM/e0NGbhEHiCRQNht3f4Yh971MQFo3ymuJ by9Q== X-Forwarded-Encrypted: i=1; AJvYcCU5vRhkc5IMzU4kaVKid4fZSxbjmZzTOXFkexowlqqWdBdGqxCZqFPp0BxWmEdr55OYWFOZYyjlTl6aNrw=@vger.kernel.org X-Gm-Message-State: AOJu0YyUrdzXKDJYX6JOVT3N421mnuBszO+ajSin9paADbXZqJIUFSvD LDxtYspX/oO7t1MhPXvfQoA8rMW7UFspFsoTGRlUH1woLpB4S+Us/XsBa0JLCdA= X-Gm-Gg: ASbGncuqcX6i44qCAEM25YKBgDgqdc/ShHR/+PDBJX4eAOAE3g5xjsk7CJexCUa8uxU d8k0r45utpkAqM/P8T9rCkb/MedbFLHjhKqXuFTvJePH2m1kioNnHbXjJIpN+zamaNKX7VzTDt2 vnYzQeVs57Ylg4t55Ylg2DbrAvpLRtXAY5q39Hn4BEv86ce064qTiAoUYsXq7bKI8ctX1lU+OBI +kovBoOD2sFWGTta7/IHcHoYlGGCdm3tAhWymrU1N+a4EVbDkcp94QeqpFghwY36o+y0IHtMJBR bLmRDSn5 X-Google-Smtp-Source: AGHT+IHNyZ6Gmhi8CkHwki8iCp5hZVMJCqmLrVUuVJwgJ65+43JewzpqCE+zMexCnQ7438KBklSDKg== X-Received: by 2002:a05:6402:510a:b0:5d0:d208:4cad with SMTP id 4fb4d7f45d1cf-5d41e16362amr4618611a12.2.1733850616337; Tue, 10 Dec 2024 09:10:16 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:15 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 05/24] ASoC: renesas: rz-ssi: Use only the proper amount of dividers Date: Tue, 10 Dec 2024 19:09:34 +0200 Message-Id: <20241210170953.2936724-6-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea There is no need to populate the ckdv[] with invalid dividers as that part will not be indexed anyway. The ssi->audio_mck/bclk_rate should always be >=3D 0. While at it, change the ckdv type as u8, as the divider 128 was previously using the s8 sign bit. Signed-off-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven --- Changes in v4: - changed the ckdv type from s8 to u8 and updated patch description to reflect it Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 2d8721156099..178c915331e9 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -258,8 +258,7 @@ static void rz_ssi_stream_quit(struct rz_ssi_priv *ssi, static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, unsigned int rate, unsigned int channels) { - static s8 ckdv[16] =3D { 1, 2, 4, 8, 16, 32, 64, 128, - 6, 12, 24, 48, 96, -1, -1, -1 }; + static u8 ckdv[] =3D { 1, 2, 4, 8, 16, 32, 64, 128, 6, 12, 24, 48, 96 = }; unsigned int channel_bits =3D 32; /* System Word Length */ unsigned long bclk_rate =3D rate * channels * channel_bits; unsigned int div; --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE1C82397AE for ; Tue, 10 Dec 2024 17:10:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850623; cv=none; b=kuBRF4f87DYZqx5B1k7qJbfyoKpwHdNg5xtcIub6jXH82QIoVrsMJVBGgD1YeZjWuhEO+122bEEVA97mdAMn/sAYNiJ4jgrXqgsJe1NjFw9bGd9/C8hzNwHxaG9LPGyIe9+krT1HPG3P2GgTB3FsRsOJYuV4vhjaiHFD67PJVRo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850623; c=relaxed/simple; bh=hgummav4gWlxydCCaiYlSrENU1T64Eunf3Cfp6+7rSU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ErBL2uoRz/CGU7Mf+Xg6ZMUvCoIOk3dhDMJZIbe3egD84QqVprVY6+6CR37wAP9WOp0UmMQZzkqVdmK3rMQcmO8yOm6RbfQjCbyy4XryFcqGmc0oU54yF7BBg3lvRHXGtQmfX4jD+mUWJKui0udJFVLVbqr8H4lxt+7wDJu9SXw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=hDi+eEZM; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="hDi+eEZM" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso3810750a12.0 for ; Tue, 10 Dec 2024 09:10:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850619; x=1734455419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eFuKmapnbE9+QOXBiNESOVZ7AOkqywZ/u7IM8EV36Uw=; b=hDi+eEZMHKYaStvYGNqdq89LdNEds2TOOG3WmHMR2G5bGIw+1r7JQMrwNVZfDNGpQq 67ciFOKnp7z+LRoH5r1a22banVTgRw05K7pEhUj7MyX/rloEGEncZE7eGcVfzXAEdjU1 J+ZeOGFMmxO0i3FyoB/bHDuRHEfDrxwiSKLKu0JQXTDNFLSyeeI6ZceIYCG7hxfxoKQf ntMm/dLiPvrjDIk8TD+QvRLDjd53E6RhInc2wHnOa3GfkiWj5wCWA7ZL5aBMm9SZXWk8 8TXzRDFkHHXW4WvzkIFKH0Ra45UICMoqR1uvMS9K3cBpe0uCRXP7uhuZepJJWNnMIWzL nt9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850619; x=1734455419; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFuKmapnbE9+QOXBiNESOVZ7AOkqywZ/u7IM8EV36Uw=; b=LY3/3tce+L2BRs700VKn+J1sGDuIYWSRic0mauXmYxF9kjAkjgkgWHpb5YwRa4JuZx f00PsdI0VbnIhjv99UYIuhFZzNIwKCiLaVOwBrPKL5+JStU6RxhBBW5iNehsEA2apxu2 AovwZPGgdiCZ3bsbjOBDxqrvmXIkDufhj+FKmCUCeetNSivgFlxMLXOqQhdPMctg4QcO Mp8jXIENk603qG2SRhtzhbDdDiF3pB34LYSzkVfEwiip9Fq3tLOdpzwSfXKPrUp9MQG7 qLyBtl9R15+wIDEB6qRu1Ye+CIO4GzCZJdtg/H4nDpNMneNfviDAEQmYV7EC6yw7VoDK +iKQ== X-Forwarded-Encrypted: i=1; AJvYcCU6iQdTu56F5r7WdWwz31vdvw6jOLTuJOTfj1a8OxvFNMJK3T0R3Rn3kxM5K3UjmA47cxsMTMWfvzm7eH4=@vger.kernel.org X-Gm-Message-State: AOJu0YzJFHgn+MB4FpLFO+7nsQ2lah8cr5F2SpvYZ9WEv88FAcH+pQ1J AAUqlzxF9p3eXKDuUvQt5UH/ZvxLMTTAjVHZglVpTOfevATSDO1B3Ej8JUS1oO8= X-Gm-Gg: ASbGncuhXSvF6cKv+77doEU+3OA4N+BcvLvVBpNU1JZ1aIx2yDKx9b0ShaUkxSkCNh7 OEs3HnPqWl/mDqo2RQhbgIplc+I5wA3dfO2YRb55S8ozGZg1T2f5nxraBU5+BNi6EzFqhg39Dhw KkwQmIzmAbQNajan8aug0u3IpcsUg1Mjo1XOJPKLxOV6n1/LfWzzOqodF57/cLBkSHXUea8S6xK Nd21M8mIMBrTjOhFtC5ETghXK2qfExqbua/1K3z7Zh+yhzxpLe29Z5b9IomlBRqC0jEv5YVoUV8 HdpccqZ0 X-Google-Smtp-Source: AGHT+IGIek6OPyyjZZjrXkuvdN81VR6DHl8mzdwNbzCCYx8cbaECzDZswIN2k+lpO7iWi6HMxuv6jA== X-Received: by 2002:a05:6402:360f:b0:5d3:bab1:513f with SMTP id 4fb4d7f45d1cf-5d3be6c4046mr19223495a12.18.1733850618930; Tue, 10 Dec 2024 09:10:18 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:18 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 06/24] ASoC: renesas: rz-ssi: Fix typo on SSI_RATES macro comment Date: Tue, 10 Dec 2024 19:09:35 +0200 Message-Id: <20241210170953.2936724-7-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The SSI_RATES macro covers 8KHz-48KHz audio frequencies. Update macro comment to reflect it. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 178c915331e9..35929160a8a5 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -71,7 +71,7 @@ #define PREALLOC_BUFFER (SZ_32K) #define PREALLOC_BUFFER_MAX (SZ_32K) =20 -#define SSI_RATES SNDRV_PCM_RATE_8000_48000 /* 8k-44.1kHz */ +#define SSI_RATES SNDRV_PCM_RATE_8000_48000 /* 8k-48kHz */ #define SSI_FMTS SNDRV_PCM_FMTBIT_S16_LE #define SSI_CHAN_MIN 2 #define SSI_CHAN_MAX 2 --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1646223A56B for ; Tue, 10 Dec 2024 17:10:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850626; cv=none; b=h4+3XbwQM2rFdMc/PNO3v27RYZGFLci+4vt4kFA8O61jPIdjbCGeHmI99IoKXsFak0daCzJZZ7/ahvxS6StalWqn02hihaXbL5GzbSre7o1Ni359d7iMqakSmRpccNcb6nqzJHa3xutLlk2CQ74/L7wVUNdxqZNC2s9n/SP7zrY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850626; c=relaxed/simple; bh=RalPxCPilUWbjYvZHpa4B7ebOphri7Uk5DSwxD2axvs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LS0cqxXXokkz5ZLMGjh3JL2BLiG2rtVOV7NLK5Cuwqoa6fa8JwzvnymcsT7mAASMS/7/tJPDYCyv9R7Xg4H2H7RfM2z69ELaf9732xlWcsLQNiFUcp2pXrae7fGxzii3DuXSxaWvJzQT9qA07KaO43hI/NmeVh3m11TLlBulWcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=EGQjxsQc; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="EGQjxsQc" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5cf6f367f97so8533287a12.0 for ; Tue, 10 Dec 2024 09:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850622; x=1734455422; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=quo1xBiWZKYYPo7MUB0R0AMbPr7YypV5dW0W8isrnRE=; b=EGQjxsQcO50WGgYmy6Zfh/+57aYcCdg7phDM3bX4pHrdJ37AUoYs2w6rYlD3P/XnRK vbL4L65+v1Vs8/KJ6KMpaAyDEC3qzyhLAgeaE8b3jPpr5Sp0/bkbIKVdJwAWc8tRUM2s e176Of272Zl/+1F40fo8kkusiwXkwbrKNL/BAsJiIYuXe2GcdgzbDM1m0h0F6nroiCsZ joj7pJLA3cycvZ3GPh0FWXDgEcNH1zATjoJsy/jd3R4HboJBtquK5AAXIz78ftY6qrsr gOFAOI3bx1NzbuB8EsLg2Q/0peDZCDQLDozqftozXP4vufrfhcgScr5Var4YdT3at6Xq Qu/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850622; x=1734455422; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=quo1xBiWZKYYPo7MUB0R0AMbPr7YypV5dW0W8isrnRE=; b=Np3fPo0SPSh5d6x7KquG9HdZocXoLp6o5BUDU4nUzrSO/xZWWsr+NToXjejuG9UgII xTFj1LliqRDY8uYUFun752jnfh5mLTIXKQi4Uu/3F7DXGMiBf8C6OOn26mK2ToRWPTor 49oLAVnP1+i802GbhCmfns+TWxfrxl68ISwoHkBbbwjFaqG4Sp6PNdCE7vAkVICeDpB8 w97k2zwEt8/14pK1NRNMtHAVuJI9m5TU3rMomBX7KrFwAD4Ia9iyCukfeyMS+uBBd441 OJ5EvkUDVC237Sk30JQYcd24kcX1cWF2vA0THAacXYCAH7Fxvd+pPYc7bZZ0W+IQIac0 UAKw== X-Forwarded-Encrypted: i=1; AJvYcCVrFTLKtAXxyf3uyZenVyPwpVOfG+ofaBEgj7uKxYZT6lEqnJv5yU25diJ4ysFYz3bwzTD3onF4GmHm0VU=@vger.kernel.org X-Gm-Message-State: AOJu0YyruTYXI5afuUJ+jw6P/amq7fY+13vc4J3+z26DrH9yGjNeSTvI KMwp2EpPe+QtEWL9CY8kbIIRVtre8PsrYTlBdp0nRk5svEj5n391QAx5MtctRoE= X-Gm-Gg: ASbGncvdrjgmb16RhkHMI6/FLic1ngTtWSoviZ3QUZx0J8fVGL6p4YkB9eZB5Yearz5 DiTx77mBe5iGBRdgHHymLzgM2jdNXVfSRLwCUyEVM0AyyvWlT3G5Ah4AgKkFhsrAlIh26Tg44Jp MU7Gse8ggXQnqORUyU097zvL3KkSmiaIAv96O92awGN/dMWfkLRPI1nug/oy2GWD0dpHj8CxlwW QUSvPy+seCP5XZWRSGjV94ujlcP8rOk9wli5H+bVIcaZXsCrrmLVmv1zml+GVbPHzBGaY/Ed5qs nHGEdLX1 X-Google-Smtp-Source: AGHT+IEVq5G+gawrHiPzQYVclV2UevSYSlAdxNYl7RmLq5d6hxx+eXzeCUIVNOyKC/W4oWQ1f5HO/Q== X-Received: by 2002:a05:6402:1cc1:b0:5d0:ee52:353e with SMTP id 4fb4d7f45d1cf-5d41862ed58mr5867285a12.29.1733850622148; Tue, 10 Dec 2024 09:10:22 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:20 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 07/24] ASoC: renesas: rz-ssi: Remove pdev member of struct rz_ssi_priv Date: Tue, 10 Dec 2024 19:09:36 +0200 Message-Id: <20241210170953.2936724-8-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Remove the pdev member of struct rz_ssi_priv as it is not used. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 35929160a8a5..b24c323ee05f 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -99,7 +99,6 @@ struct rz_ssi_stream { =20 struct rz_ssi_priv { void __iomem *base; - struct platform_device *pdev; struct reset_control *rstc; struct device *dev; struct clk *sfr_clk; @@ -1043,7 +1042,6 @@ static int rz_ssi_probe(struct platform_device *pdev) if (!ssi) return -ENOMEM; =20 - ssi->pdev =3D pdev; ssi->dev =3D &pdev->dev; ssi->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(ssi->base)) --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABBB223A56F for ; Tue, 10 Dec 2024 17:10:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850628; cv=none; b=SJm6TtqmQjZsr1q6JpwWOq6qpvUrBLe3UoWyeJ5kSs3E2R0HGFGpK90hnNtlHPGCJPwiHPcQ1ByM9XKp/hHQbud3x/3xl14omRgsgK82RRMOtpgjkPQ5rtsYVmpsq0dWuHeZzEgl9yS/8AYORDa1xfrx7ECYit1rRnA8IWd0QC0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850628; c=relaxed/simple; bh=TdUpesvK2bqZRA5lCnWS4V50ZEqpa6uiukIdp73czu8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=M7FYZoZj9mPTbW9AdKWyTl8H144Bq+N3qq95zvxWnWsRNb1N2itLwvySU50FhpDVKMHXp2pvY6QSdmh3YDi/cYfrYempo8hBorVH9G1P+kwUVNm81neeozrfkW5ba9eFapk5pL97vEednQraq29KkmRBZ5M2N3O3bqRjNdtXTAs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=l7eMh92F; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="l7eMh92F" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d2726c0d45so8938823a12.2 for ; Tue, 10 Dec 2024 09:10:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850624; x=1734455424; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+fZD7MbYY4k4sOMCUWO81EIjBCeOEixHEXtaO9JyHpg=; b=l7eMh92FJNf507Qb2dky0SDTjlhKn5rluqm2wke2c6XR5VTTXtbbN0RRbE1OezXBsb Hcf0QGSTKHPLU3mUXf/Sbr8swuW/vEbMtTrEFNV+okGTAyjUcp/tXX35A2BIq1pwEM1+ Zrmrj0neRmP42VA1U/H3LtIECDofqlIEiF6Z6vSnQuR1iVcZ0JvpLh8mMv9+fhtgpkto avrM1zPfdmEKDUUq9m5h5a2Aw4S0p+u65brKXzaXyW7kXlDNtoLuzn6wwvJx0UQT1vuO PqzPcJe3KHrMPMXh8Y1D6dt69YQPVOLGb2c1T1UznaHHN7PDEBOYf5WwHQDv+OmCOLhu nLtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850624; x=1734455424; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fZD7MbYY4k4sOMCUWO81EIjBCeOEixHEXtaO9JyHpg=; b=a90yPCVLsbEdsG2EILEO60y7XclIOxajBF09wr/vUjyPBSto9r/lJvbPSFqmFX2mmJ Tu4GerBUuePFFYrUUHjb7jy+/Y04FNLtAVWTHbN2OQsgtbV8J0NDzNk8kdChxn7oSY4g zfk1dekVbhMZoj2JXF97GlrG18sh3mFFQoS8dFqgtfWgqtfAxjNOcKYwC9W6AfuQxYN/ E1u6XuJWLhKTiWBbF+xgrNvgQIUfRLoPQGIjoeyB+pUSvDzlVlHICqFGWARioqQ7zW8r IXiMOHq4y+Vz8RR0jAjYvBw51baXkw9ZGGZTGtxdQNxsR6sP33GaJx4w8vfUTpB7ABhG XgTg== X-Forwarded-Encrypted: i=1; AJvYcCUS0bjicIfrzeDacTN9vmrRo6i6Sa+vmMGE/S873vIFgVulHsQFBxRP+VA4hT0UtJCMf3nJpT39IkL4wHM=@vger.kernel.org X-Gm-Message-State: AOJu0YwV/NEqjZm9aUnF+wwiaZmZml1lrlNFP4EWjdtxGSv+RZUtFRqO LJEcwEg+IrXCPXX425269+lzKlSJad1YnXshN8sRkGCjblqHv4wm232Je0xRQ0o= X-Gm-Gg: ASbGncvESk0JwMAi99RBZF449+MejQeUQ5qqMppt2fKE2w0hQfr25PBLxLW2NJz98hQ YV2ouryY9kuf5IhGGIKwAr2kYn68UtTEEj8a/S4TyjYxtvIqJa2kZJEHcfGB77UCTLyevQmCDWA sbzgnHsNHE9QMxvHUAOuXp5w/QS6/qaKOlM/6R2nYM0PQwjd+OhYRy3M9l7OgzPaZBdasVELWr5 UXnvZtRNa310yE2U/B4Ev67XpH+OOAHx2XDcm87FTw/Zr/hggzW63hi79GzL9kIxQiyjTXN+ajm U0lv9BfT X-Google-Smtp-Source: AGHT+IGPNWGY9jEOkszzr7a+HCzsQHx/+czOpLjoEtr5Y51ztb7vYMYNc711VxTTfs7vb+1yWs3GDg== X-Received: by 2002:a05:6402:26ce:b0:5d3:c4a8:d259 with SMTP id 4fb4d7f45d1cf-5d41856a452mr6845842a12.19.1733850623996; Tue, 10 Dec 2024 09:10:23 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:23 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 08/24] ASoC: renesas: rz-ssi: Remove the rz_ssi_get_dai() function Date: Tue, 10 Dec 2024 19:09:37 +0200 Message-Id: <20241210170953.2936724-9-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Remove the rz_ssi_get_dai() function and use directly the snd_soc_rtd_to_cpu() where needed or the struct device pointer embedded in the struct rz_ssi_priv objects. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags - updated patch description Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index b24c323ee05f..e2e172d8e9db 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -162,14 +162,6 @@ static void rz_ssi_reg_mask_setl(struct rz_ssi_priv *p= riv, uint reg, writel(val, (priv->base + reg)); } =20 -static inline struct snd_soc_dai * -rz_ssi_get_dai(struct snd_pcm_substream *substream) -{ - struct snd_soc_pcm_runtime *rtd =3D snd_soc_substream_to_rtd(substream); - - return snd_soc_rtd_to_cpu(rtd, 0); -} - static inline bool rz_ssi_stream_is_play(struct rz_ssi_priv *ssi, struct snd_pcm_substream *substream) { @@ -243,15 +235,15 @@ static void rz_ssi_stream_init(struct rz_ssi_stream *= strm, static void rz_ssi_stream_quit(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) { - struct snd_soc_dai *dai =3D rz_ssi_get_dai(strm->substream); + struct device *dev =3D ssi->dev; =20 rz_ssi_set_substream(strm, NULL); =20 if (strm->oerr_num > 0) - dev_info(dai->dev, "overrun =3D %d\n", strm->oerr_num); + dev_info(dev, "overrun =3D %d\n", strm->oerr_num); =20 if (strm->uerr_num > 0) - dev_info(dai->dev, "underrun =3D %d\n", strm->uerr_num); + dev_info(dev, "underrun =3D %d\n", strm->uerr_num); } =20 static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, unsigned int rate, @@ -988,7 +980,8 @@ static int rz_ssi_pcm_open(struct snd_soc_component *co= mponent, static snd_pcm_uframes_t rz_ssi_pcm_pointer(struct snd_soc_component *comp= onent, struct snd_pcm_substream *substream) { - struct snd_soc_dai *dai =3D rz_ssi_get_dai(substream); + struct snd_soc_pcm_runtime *rtd =3D snd_soc_substream_to_rtd(substream); + struct snd_soc_dai *dai =3D snd_soc_rtd_to_cpu(rtd, 0); struct rz_ssi_priv *ssi =3D snd_soc_dai_get_drvdata(dai); struct rz_ssi_stream *strm =3D rz_ssi_stream_get(ssi, substream); =20 --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C7D23A59C for ; Tue, 10 Dec 2024 17:10:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850629; cv=none; b=VxPU01oSYWEvxfqNZPfnMTA4m4c1QXAZ+O8hh7NiXQbU18u+7u4NdtHBNKHgB3io9eX9SSiN9LV6x33fzZ3tLtaF12LzTJxFdDQ8RtdUkWBfAb8a+4ZAZ8zvjPKlrnh71xI5Qp4sgy60wun33rN1lKtYP/rG+GllQhgyyAgcCPA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850629; c=relaxed/simple; bh=ujffKmfqqDwP9nSS/Rh8QsJL6MbeKN+Qqc+lwPTDO6o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Su1Unjp1oFxSR8zG85S/KbSV+zkGbeChRM8zaDMGzIjxRQbJTZVHN+1e2vnUrcnKRGNS2L1hSY1+/irn/rydCL8uykG4ypV9ED+hn405LPwo5FUrlcEIjoKHSFhxMOVs3D24MFpQHZGrRL10Clis8/uPkUAgaoD5dHkMXY9YfyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=R0QKl8lt; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="R0QKl8lt" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5d3e6274015so5213987a12.0 for ; Tue, 10 Dec 2024 09:10:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850626; x=1734455426; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nt6/CuLO4TNfbHvjGkE7QWPE5biRbMT4tQY2cpGkikU=; b=R0QKl8ltpkWoHydIefVc0xQrvPiLvplUyTjqzT6eHRvjJgdOVWa7o1ljB35cZVL3cd /NQI5szGDpJFyZlfoB1gawjPP0g8QUKO4DhZGoEM8GSqS88YT2ZgZ17TzWofc0EzxTOC TRSmQJfu0+JVzRqM+B6TUF5trZYIjjvnOl70wC4vDMO0gMcDFgB4j+hxE246F5nKqLmu kfoZBoL8BgkErwniYfqW8dajUAYq8FDikk5QWw9Tmb9JYf1Jp3ukkxZA7dVvq5vVnOOy Is8T+LIE5dV8rUZ/KlSZ7p7EZR/bZ3+Efq1njQqwVnAQ2Py8btOxhsngdgvTBhE+cXws Yr6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850626; x=1734455426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nt6/CuLO4TNfbHvjGkE7QWPE5biRbMT4tQY2cpGkikU=; b=pY2M38Q2NE2k0v3eGbwbUGWe7PdCjI1Blt4R8pNHuqn07ZcicJoll9RlohnSdYY68R gMFWQEs9pJig3u+uRuhLlzX4ZrLSKSLtevxVmzOTGRKMjIFRGFGM55s6gZDwidPm9kLO WCawoUtGxkV/XgVP90PBnjeT8jgtJZQMYs4+bXocdTIqTejIY/qj5CgNA3txCCoFNCgE FVciK68FP2s69O9+aGgvtJs58N6vDNlTuMKQmZdyOw0MCD2KmOv8fF+tTNlEqbk7X+Em yN6PInPZ1Rmu1p5PPgHMXCH/tNEbii2Tt/v6kNsiQs6NzK3K0lzs/oArN5DebM+VXPj9 lzKg== X-Forwarded-Encrypted: i=1; AJvYcCXCAxqul2HG+h2TV8vL+6r4FLrLt6hS3rahbjx3UZBO6bdx0WZ2UbQqdeMh1T1cegPdMHjQrREm55br6KM=@vger.kernel.org X-Gm-Message-State: AOJu0YwDflfd9d8txdRMsq3+EYMyiASUOEqRwyQM3OEZ8K/9eJ0MdA5w YqiypfJ1tNFf4Irj4CMEwfuG3KpJASCySZzUlfsRwZjGKWwEhRmEtjc2Mgl8P5o= X-Gm-Gg: ASbGnct2FC4iazTXD4VTQUZIVl6oR9V2fbjadezI6HvciUtfC8pdMKMsrtKGJuRiR6Z D73JnHMCGDhlOMuvPUPJN5vPGVstHpepW94wT6Il1hdMHY4owf1TP6b4b825QFpsZ0YOZ6D1UOr gIdxw/2wjCpZVAwX6V0NtJ9xny0K9AXZ7zTPmeBvdozfvVA+P1Rtea+6FkFjky09UJl04+WRlUS AaD6aqsdR4o/lZBD7qylrh/B5gFipZxrxW4XhU8yd8DyUmC8NAKQhoN41Xp9xBbrv7eVNE1jIWY ygHo9ce+ X-Google-Smtp-Source: AGHT+IFnf0CQr0jkK6OJUnuRd7yMlMyY8yimkX0n0o6RyaHOTAp9AyL9lRgA8mS0FG7jjIMo1TvGpQ== X-Received: by 2002:a05:6402:2813:b0:5d3:d4cf:feb5 with SMTP id 4fb4d7f45d1cf-5d3d4d00325mr14392707a12.29.1733850625802; Tue, 10 Dec 2024 09:10:25 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:25 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 09/24] ASoC: renesas: rz-ssi: Remove the first argument of rz_ssi_stream_is_play() Date: Tue, 10 Dec 2024 19:09:38 +0200 Message-Id: <20241210170953.2936724-10-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The first argument of the rz_ssi_stream_is_play() is not used. Remove it. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - fixed typos in patch title and description - collected tags sound/soc/renesas/rz-ssi.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index e2e172d8e9db..1a98f6b3e6a7 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -162,8 +162,7 @@ static void rz_ssi_reg_mask_setl(struct rz_ssi_priv *pr= iv, uint reg, writel(val, (priv->base + reg)); } =20 -static inline bool rz_ssi_stream_is_play(struct rz_ssi_priv *ssi, - struct snd_pcm_substream *substream) +static inline bool rz_ssi_stream_is_play(struct snd_pcm_substream *substre= am) { return substream->stream =3D=3D SNDRV_PCM_STREAM_PLAYBACK; } @@ -337,7 +336,7 @@ static void rz_ssi_set_idle(struct rz_ssi_priv *ssi) =20 static int rz_ssi_start(struct rz_ssi_priv *ssi, struct rz_ssi_stream *str= m) { - bool is_play =3D rz_ssi_stream_is_play(ssi, strm->substream); + bool is_play =3D rz_ssi_stream_is_play(strm->substream); bool is_full_duplex; u32 ssicr, ssifcr; =20 @@ -674,7 +673,7 @@ static int rz_ssi_dma_transfer(struct rz_ssi_priv *ssi, */ return 0; =20 - dir =3D rz_ssi_stream_is_play(ssi, substream) ? DMA_MEM_TO_DEV : DMA_DEV_= TO_MEM; + dir =3D rz_ssi_stream_is_play(substream) ? DMA_MEM_TO_DEV : DMA_DEV_TO_ME= M; =20 /* Always transfer 1 period */ amount =3D runtime->period_size; @@ -800,7 +799,7 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substream = *substream, int cmd, if (ssi->dma_rt) { bool is_playback; =20 - is_playback =3D rz_ssi_stream_is_play(ssi, substream); + is_playback =3D rz_ssi_stream_is_play(substream); ret =3D rz_ssi_dma_slave_config(ssi, ssi->playback.dma_ch, is_playback); /* Fallback to pio */ --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B77B3DABE2 for ; Tue, 10 Dec 2024 17:10:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850634; cv=none; b=NEN1udaUN41aynjJfp/S7vj82QEf0XQsNtNSIEM8tWcQ+XfZtK//855AJheAe/+u9R9p8J3Hx+jAeIvbTn6wUrnE/RFNRQAjVFZcSgqPGLhO9kSpo8Uj2Lo6pIT6PgtyyFuZY8yes9LhALPbSuFThAGNfN4sDKzP+F+oKVY+Qgw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850634; c=relaxed/simple; bh=cnajpc59mzRLWDYn+TlQEWJ18Tzqm1CRjbROQ6JPtZs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=a6bg0VWBKlAHkqaL9Z/ivfCGgvkFOiUC1l7QXX3ydSg1vgEWQ0UNn9BNE6Q6WB57S9B3GsE1nM+uZj8VIVFwEzW3LYQdEQJJ5H8hjXKRBp76cZKGEKxGCcSjwJvP7hL09IphfdYCwBnbPJLMdTPe0x6cPdCG0XqfMhBlFa2XSJc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=BY4gWM0a; arc=none smtp.client-ip=209.85.208.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="BY4gWM0a" Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5d0d32cd31aso6838985a12.0 for ; Tue, 10 Dec 2024 09:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850628; x=1734455428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3F8PzVf1JVHBMdfZjuuSPBsoTNCHuDc7mT2swoePkeA=; b=BY4gWM0aRKGmRPNfU/t17wSV6WCBMCbALqJIZ4xdnA62ORaysTgl0Mq1WJUkC/jvOe EtqPV8SeIsWUpXEHMdIo1c8ASje479H3/71wwqGhO3lmhIjeJ7y9U2kCThtRAxUGo+Y5 9pl2SuPLNEF42r//twOOg5LRgNgar9DFo2waWQUjstF0PZZ8ZGD5IEaQga6RYBzS8aI4 TuRFpVgkOT4HlZLzfo0mAsTMy5HkDY+bgcScK9oLG2PgCRL0EZphfkwVUSSU+n/Janrv ygBdWpp2fy6pVySIZmTqxnk1/CtHuq3Cc7tAAXkiQ9QZ28GURU+2nZltLA2fgy3btaMr 0umw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850628; x=1734455428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3F8PzVf1JVHBMdfZjuuSPBsoTNCHuDc7mT2swoePkeA=; b=KuDHYDFumU0G6hqh9M2kjA9VlFhf5s/vmsHGv7sA/c0wfrWW2//bzaOgiQJpXJ+dKo cbGnOLNHb5BA64CtDDIIq14ZNR7urgshasYvOocj0b+adMar7wzEXOgjZ9+XY0xPvHbd KiwGnCdGQvH4D+yzIS/joen8dxzLqPKZQ3sk4gsAStEm/QdcvGbDKK5hbvY+dYppZUJb iqjpux4zAD6gQ66iA6YZDLNUut+rMnCoIb5hlBxFy1Haq896E15FVO6iFW+pvYlCBKiO uvLMv9fzWA1E/n0f2euEr/O8v6tGDjAso+vPg4l6B0910NK6LBIG3KFyp0LRxlWx1NEu j+Sg== X-Forwarded-Encrypted: i=1; AJvYcCVzfHz40CUq9E6AMfIxxpBktFUm3UUAj6jZAfhEKFX3UP3JpzEX18ljK9XvmmYf35n/aPQKgQEAwao9kaE=@vger.kernel.org X-Gm-Message-State: AOJu0YwFMpc/s0VWodZB01HRN7A3sH84LlAFin/mr0rZY8LoQTfVX24D 6c0ewm1buKUbgNoaV57mKbBpOSIjuYekEl6ZKbe6ntrvTfNgcfbIfIoMMOF56CE= X-Gm-Gg: ASbGncuo/2NRrH9UHeNo28OUO7vHZp46Zihe+pZJM2Tn7HJZtxH6FpeeXuI4fXmtqW4 oflZTymtkpqY3AbcQWQtHJgHBTTLUlwO99TQ0FDTAjKfnXPs1G/Mo4CXPejd7bfVcEMvwFCHzHQ jskgZzSf1wurguRaIMcma3FHQ2nTSg8UkTZotXy8Fc6Dd5DbDr9SEbkHn4Q49lLElb9Mt1rNwd5 fIrgBdE0pG6kqMdYJNSnCgEvcBoqfhXsFNjQFxZMmUoGwVqQPjvFQJEFXa/pbi0saq0kWECnH8R cp42pJfc X-Google-Smtp-Source: AGHT+IF6mILseNMfJmIB9ZOyimXPXPfxpdkmjbt3WuqKLQbtoG5tgiV9L7CF+aAEAjMF8dRgPTsU9A== X-Received: by 2002:a05:6402:42c6:b0:5d0:ea4f:972f with SMTP id 4fb4d7f45d1cf-5d4185060b8mr11381588a12.8.1733850628448; Tue, 10 Dec 2024 09:10:28 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:27 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 10/24] ASoC: renesas: rz-ssi: Use readl_poll_timeout_atomic() Date: Tue, 10 Dec 2024 19:09:39 +0200 Message-Id: <20241210170953.2936724-11-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Use readl_poll_timeout_atomic() instead of hardcoding something similar. While at it replace dev_info() with dev_warn_ratelimited() as the rz_ssi_set_idle() can also be called from IRQ context and if the SSI idle is not properly set this is at least a warning for user. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 1a98f6b3e6a7..03d409d3070c 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -307,7 +308,8 @@ static int rz_ssi_clk_setup(struct rz_ssi_priv *ssi, un= signed int rate, =20 static void rz_ssi_set_idle(struct rz_ssi_priv *ssi) { - int timeout; + u32 tmp; + int ret; =20 /* Disable irqs */ rz_ssi_reg_mask_setl(ssi, SSICR, SSICR_TUIEN | SSICR_TOIEN | @@ -320,15 +322,9 @@ static void rz_ssi_set_idle(struct rz_ssi_priv *ssi) SSISR_RUIRQ), 0); =20 /* Wait for idle */ - timeout =3D 100; - while (--timeout) { - if (rz_ssi_reg_readl(ssi, SSISR) & SSISR_IIRQ) - break; - udelay(1); - } - - if (!timeout) - dev_info(ssi->dev, "timeout waiting for SSI idle\n"); + ret =3D readl_poll_timeout_atomic(ssi->base + SSISR, tmp, (tmp & SSISR_II= RQ), 1, 100); + if (ret) + dev_warn_ratelimited(ssi->dev, "timeout waiting for SSI idle\n"); =20 /* Hold FIFOs in reset */ rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_FIFO_RST); --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E5AC8633D for ; Tue, 10 Dec 2024 17:10:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850634; cv=none; b=VJLn3OluLr+LARp60cg+mnooi9Al5yNWBkLcDbAxC43GQLhXCJ8TV6if3bCLhj0u0hmEAIQlPPYYHbuNakZgfsY6lsq82s/ngYwl4Zsbqzi3H2lBxzqATBpRSUOCNf7ZHCt7L4UsQnx3N45eW7PnOXh/nHzIiR3uCqdU0P3b4q4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850634; c=relaxed/simple; bh=k3Z7SepXf6kK0GBAAx+gh10sWRGIrQ/wXZMtZNGeO8k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=PtEAOo4IAF+qjAsjpPZDv+x5GjYmirRMzBpV4ioax/9FjVPZrUUCI/EuoeoVXWItW6PJH+pvA6+CT7s/5GggA0SXRvhvwvnOm+QEAQUFTHh53fTi+M76J9+vVp64CZQKAXq7eysVmdPtkZfWAVxETxYh0yh6BfklrMWONYs/Uxc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=EifxrIGK; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="EifxrIGK" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5d3cf094768so6586912a12.0 for ; Tue, 10 Dec 2024 09:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850630; x=1734455430; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hkl99V7JHk+PHmXk7Z/OM1i1KIFRiXSecR3DTIS4ac0=; b=EifxrIGKRKKCT49M/aXjayRDJzhSxZH6x3FgMANG6c67KCxirJVypeLjsfSunTf5sn 1ZDKe0/WxuZlQzhv/V7y4gEHmsSvK94N4MlZDt2YEHiDU4izjX9IMY0SClxTrmDqw8vJ R3wxizzL5Beykl4gO4pR1qd0Y28z5EyiKC7JgC7T8HyEADhgsTCXgutOQ/jdfwUOfqib 7/1USClPdI7H47lJObPoLt17aOq0rNkZVqEqHzm5WXACrQ9VKKeBSqjLeCJZWksI0kKa VnegIIA+w4KXZXfJd9ONJJjN0JtfXak0VJAgY8mzoK8l1QShqRXGdkIacM9c/1KXByIk 3wBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850630; x=1734455430; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hkl99V7JHk+PHmXk7Z/OM1i1KIFRiXSecR3DTIS4ac0=; b=AWZHZymPIvaN0bqFxCWYI6fbkoc41IagDjC8yYIixqEZY57RVAe/qkny6T9ldnz2mO hwT4f+ZiBIC7zXaeWKDZcU8dLpv6Ez8RergPDCNwWID4NE3Fj1xTzjXVuebyS+wuyK+5 06V1LuMApYiejjhhIAlyBx6bRlzVO6RNaa8B34EcvtHBJHvEqPJbjpWMhcgsQk6tslCU 7Fa5Hin3e+C+PHhjIouUokC1ZJqyCirgMSeDpfbDg5VVAnltckD2QsjVeZv3q68G0WMw 3ZqzyFv2uJyfmPZTMwQ4TlUZ47uxiiqRRvYgJ7MOfaY16Rsk/r1zzWWZO0ihbjSyavhc mtMg== X-Forwarded-Encrypted: i=1; AJvYcCXKYtcJSYCNNOcOkYDmaBpeVcN0Hlsh14vcKMQ5OqEKobB6dxdWAhdk/KRwoLlq2VwJESLPMayl+CWuYYI=@vger.kernel.org X-Gm-Message-State: AOJu0YwAqhRvodZwjUyzwBROHnze4uwksnMx06vGVplTWjNKh8KrliWa MCjl4acs9TeOXCe/G659Cx+OSktRKTIyf3GF3l2yZBlKqRhOnx0pALEWS43eX3U= X-Gm-Gg: ASbGnctFk2x3PflbzCUzz3ziOH8c0V43k+nFOwskXAJzHqr9mRE5RvZwhp07qjV7Bxk +NncT8NeL4kwHDIk1xZ0W1LeXq1gPujLKAUhUd6r9RDwjrBVKM7eZ30mDAL5mJx9xX/bNsfqKJd 02n4uZ/Q4iGfxg2Yb7XMmm3cAi82umayVahSz+PTPgD53Qo94LcLvD1PS8EfxsFfPg/6PgV2FtJ dGzFMJ4ZKMD8KXEIxjKu9TSY93LGcp0hJrGMeN89GSLg9HALny0vwtgbhjdx+NjghLqXhTPNylf 437iCN82 X-Google-Smtp-Source: AGHT+IGiyQL90tdiVNR8CEbdQwt+84VQwU+X2Ih+j4zZRGxrQOsXOlnJklGXo6a6srhL1lfK868Leg== X-Received: by 2002:a05:6402:35c6:b0:5d0:e696:1bfc with SMTP id 4fb4d7f45d1cf-5d41856a3e0mr6960258a12.15.1733850630300; Tue, 10 Dec 2024 09:10:30 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:29 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 11/24] ASoC: renesas: rz-ssi: Use temporary variable for struct device Date: Tue, 10 Dec 2024 19:09:40 +0200 Message-Id: <20241210170953.2936724-12-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Use a temporary variable for the struct device pointers to avoid dereferencing. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 62 +++++++++++++++++++------------------- 1 file changed, 31 insertions(+), 31 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 03d409d3070c..74632e2482f8 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1021,36 +1021,37 @@ static const struct snd_soc_component_driver rz_ssi= _soc_component =3D { =20 static int rz_ssi_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct rz_ssi_priv *ssi; struct clk *audio_clk; struct resource *res; int ret; =20 - ssi =3D devm_kzalloc(&pdev->dev, sizeof(*ssi), GFP_KERNEL); + ssi =3D devm_kzalloc(dev, sizeof(*ssi), GFP_KERNEL); if (!ssi) return -ENOMEM; =20 - ssi->dev =3D &pdev->dev; + ssi->dev =3D dev; ssi->base =3D devm_platform_get_and_ioremap_resource(pdev, 0, &res); if (IS_ERR(ssi->base)) return PTR_ERR(ssi->base); =20 ssi->phys =3D res->start; - ssi->clk =3D devm_clk_get(&pdev->dev, "ssi"); + ssi->clk =3D devm_clk_get(dev, "ssi"); if (IS_ERR(ssi->clk)) return PTR_ERR(ssi->clk); =20 - ssi->sfr_clk =3D devm_clk_get(&pdev->dev, "ssi_sfr"); + ssi->sfr_clk =3D devm_clk_get(dev, "ssi_sfr"); if (IS_ERR(ssi->sfr_clk)) return PTR_ERR(ssi->sfr_clk); =20 - audio_clk =3D devm_clk_get(&pdev->dev, "audio_clk1"); + audio_clk =3D devm_clk_get(dev, "audio_clk1"); if (IS_ERR(audio_clk)) return dev_err_probe(&pdev->dev, PTR_ERR(audio_clk), "no audio clk1"); =20 ssi->audio_clk_1 =3D clk_get_rate(audio_clk); - audio_clk =3D devm_clk_get(&pdev->dev, "audio_clk2"); + audio_clk =3D devm_clk_get(dev, "audio_clk2"); if (IS_ERR(audio_clk)) return dev_err_probe(&pdev->dev, PTR_ERR(audio_clk), "no audio clk2"); @@ -1063,13 +1064,13 @@ static int rz_ssi_probe(struct platform_device *pde= v) ssi->audio_mck =3D ssi->audio_clk_1 ? ssi->audio_clk_1 : ssi->audio_clk_2; =20 /* Detect DMA support */ - ret =3D rz_ssi_dma_request(ssi, &pdev->dev); + ret =3D rz_ssi_dma_request(ssi, dev); if (ret < 0) { - dev_warn(&pdev->dev, "DMA not available, using PIO\n"); + dev_warn(dev, "DMA not available, using PIO\n"); ssi->playback.transfer =3D rz_ssi_pio_send; ssi->capture.transfer =3D rz_ssi_pio_recv; } else { - dev_info(&pdev->dev, "DMA enabled"); + dev_info(dev, "DMA enabled"); ssi->playback.transfer =3D rz_ssi_dma_transfer; ssi->capture.transfer =3D rz_ssi_dma_transfer; } @@ -1078,7 +1079,7 @@ static int rz_ssi_probe(struct platform_device *pdev) ssi->capture.priv =3D ssi; =20 spin_lock_init(&ssi->lock); - dev_set_drvdata(&pdev->dev, ssi); + dev_set_drvdata(dev, ssi); =20 /* Error Interrupt */ ssi->irq_int =3D platform_get_irq_byname(pdev, "int_req"); @@ -1087,12 +1088,11 @@ static int rz_ssi_probe(struct platform_device *pde= v) return ssi->irq_int; } =20 - ret =3D devm_request_irq(&pdev->dev, ssi->irq_int, &rz_ssi_interrupt, - 0, dev_name(&pdev->dev), ssi); + ret =3D devm_request_irq(dev, ssi->irq_int, &rz_ssi_interrupt, + 0, dev_name(dev), ssi); if (ret < 0) { rz_ssi_release_dma_channels(ssi); - return dev_err_probe(&pdev->dev, ret, - "irq request error (int_req)\n"); + return dev_err_probe(dev, ret, "irq request error (int_req)\n"); } =20 if (!rz_ssi_is_dma_enabled(ssi)) { @@ -1104,11 +1104,11 @@ static int rz_ssi_probe(struct platform_device *pde= v) if (ssi->irq_rt < 0) return ssi->irq_rt; =20 - ret =3D devm_request_irq(&pdev->dev, ssi->irq_rt, + ret =3D devm_request_irq(dev, ssi->irq_rt, &rz_ssi_interrupt, 0, - dev_name(&pdev->dev), ssi); + dev_name(dev), ssi); if (ret < 0) - return dev_err_probe(&pdev->dev, ret, + return dev_err_probe(dev, ret, "irq request error (dma_rt)\n"); } else { if (ssi->irq_tx < 0) @@ -1117,50 +1117,50 @@ static int rz_ssi_probe(struct platform_device *pde= v) if (ssi->irq_rx < 0) return ssi->irq_rx; =20 - ret =3D devm_request_irq(&pdev->dev, ssi->irq_tx, + ret =3D devm_request_irq(dev, ssi->irq_tx, &rz_ssi_interrupt, 0, - dev_name(&pdev->dev), ssi); + dev_name(dev), ssi); if (ret < 0) - return dev_err_probe(&pdev->dev, ret, + return dev_err_probe(dev, ret, "irq request error (dma_tx)\n"); =20 - ret =3D devm_request_irq(&pdev->dev, ssi->irq_rx, + ret =3D devm_request_irq(dev, ssi->irq_rx, &rz_ssi_interrupt, 0, - dev_name(&pdev->dev), ssi); + dev_name(dev), ssi); if (ret < 0) - return dev_err_probe(&pdev->dev, ret, + return dev_err_probe(dev, ret, "irq request error (dma_rx)\n"); } } =20 - ssi->rstc =3D devm_reset_control_get_exclusive(&pdev->dev, NULL); + ssi->rstc =3D devm_reset_control_get_exclusive(dev, NULL); if (IS_ERR(ssi->rstc)) { ret =3D PTR_ERR(ssi->rstc); goto err_reset; } =20 reset_control_deassert(ssi->rstc); - pm_runtime_enable(&pdev->dev); - ret =3D pm_runtime_resume_and_get(&pdev->dev); + pm_runtime_enable(dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed\n"); + dev_err(dev, "pm_runtime_resume_and_get failed\n"); goto err_pm; } =20 - ret =3D devm_snd_soc_register_component(&pdev->dev, &rz_ssi_soc_component, + ret =3D devm_snd_soc_register_component(dev, &rz_ssi_soc_component, rz_ssi_soc_dai, ARRAY_SIZE(rz_ssi_soc_dai)); if (ret < 0) { - dev_err(&pdev->dev, "failed to register snd component\n"); + dev_err(dev, "failed to register snd component\n"); goto err_snd_soc; } =20 return 0; =20 err_snd_soc: - pm_runtime_put(ssi->dev); + pm_runtime_put(dev); err_pm: - pm_runtime_disable(ssi->dev); + pm_runtime_disable(dev); reset_control_assert(ssi->rstc); err_reset: rz_ssi_release_dma_channels(ssi); --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E5902046BC for ; Tue, 10 Dec 2024 17:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850636; cv=none; b=cDpYm8XmrrqIl+p5bybEWh3jZPdSExSEBQdvaIehuK6oOQ5Ll88hgAQpMR9/d3wuwovQ+RiGjpHjuztPZJT3ct19ljKwaS7SjMMlf4RAZF5FfEw3mInRPtYiz0L1lVfuiUBm+yLdP2b/VVukm6PvwQzyYLcUn9mwywYTynTlUuk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850636; c=relaxed/simple; bh=nYG4Bh/KOUygEwsE3gKVUjg9VDgkI5hhLIDAicMnjio=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=suRznR1wrqWVLkrC3PGgsvJZo3WCUYy6wuZ50Qt1vy0isYoJs773BFhcrqzRltjotZ7VwfwC522RjVAwu2hVt6gzXKM3cLkWvbpK1WtbfmptEYuCXJMnOh2hbKQWyREYLMe1FPPJIvycZp+HKx5chlBNg2BVkLYHCLUNBAvDRHQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Fo1i+w3T; arc=none smtp.client-ip=209.85.208.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Fo1i+w3T" Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-5d3ea065b79so4489244a12.3 for ; Tue, 10 Dec 2024 09:10:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850633; x=1734455433; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A+Q7Wyi2VpUxYoA4m3KALmoe6y3o5M1OmNQXa4v/tj4=; b=Fo1i+w3TJi+119cQoeOTad7/37hS8TCOsKVxQ5/NPLbmUw7h0HJt9tPJdTQTMgMwqC 9bOctIBCN4I/yOX51anVUxQBNwSYrOAp2lHKXA52MzkPGScd+bT06LA3c3Q9/kJqmWG0 0LTIG1fpZzhfZryQGu290Cd/XIFbr5VHjzkS8roXYYCJ7I+yvg8hqJ2dFshuNWql2Qrt nhtVcvtkIMrX9DAxFsbiTbDOb+TtbYW+Pj9oPYtksfxu2px7ltzB8Li54IJ5ij0lYEF2 gkJJtQNG8OkUSSYPyxsChtGMK6HSrNCiYluQmDmrXmrlNi9RaDi++XA7cFA2g/HD5m6P gcdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850633; x=1734455433; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A+Q7Wyi2VpUxYoA4m3KALmoe6y3o5M1OmNQXa4v/tj4=; b=vxU5cZ9J5FpMulTdlAocJBOEg6+iVpT540XbbMpAgDxj40rEUwEXJYnfILC/ca/CA4 9aEUF0qnzODHPrmO8S1TNEG5KvM/2NtTtrpsUJlcwGkDXa5gLiRRebx66y0XnhI2Cqit VJB+bDM6+O6I8l0zJj2ZpuMHIq+97uQAqfHN0cOC32pxdOtaRZlJye3q9C3qC+68w+dG 8kWTWX//9e8ZJulYHngAjQa25cuJpsQ+WnnVr3OYpywBnYwaFeQ8X1w+ESE8tARDxogR OHn8AJY9FkPqvE+zlOmrx6HBHyeQEzGHsUKEXObxIri6Q9+nWpVVtC1KrugyZVOIKGEu hrZw== X-Forwarded-Encrypted: i=1; AJvYcCW3L87xJ90ei/iq9aJa8nuPNFbKdv+FjHBOjSCxmVmnGpPiB7fH80nzj7jszXH2VMH2JipQCrNFXzfZPp4=@vger.kernel.org X-Gm-Message-State: AOJu0YxzJ0fs8ZX1UBhGA3aLCFhN6DsUxPRyaC6FKi22aEhaCxrCuMjj qfKwQIj0N3QmJDK/pqq5Kw7lfxCxoKI/6cOP6mYfHWMrj+mN4baNBLGQKBedXjI= X-Gm-Gg: ASbGnct8M26S9cIE96MPG9wM+RacyrJn43wihK3uQAIdpWQ9HKlgL8+eqOPU5L4Rix8 wB4jgYh6cagUCNb5438qg1otRK7nmLXdThZ907rgM6wjiZ35jKWyMCGhKekSuT5IrPDsFeE7Mm9 qfYAim5dZ+vXxMkp2kJQyeTIOFmNRChL9UeC+ILUVzs6R+uI1AzcZepyWMpnYtcRAZT7ZiY912f JzuDB9ha/VFlahqtkNhDhgos5OW0D6UDntaWIv8qIBmjWxqvheGs/bNcsqYEAvdBeaifXUhIfYB Nic+PICS X-Google-Smtp-Source: AGHT+IEBCVJ5ksFpp4FwClVaCrJfMHHPabOYnva4BY/zYpG72K/0Fg/nCKLr56XOe4brB+WYlaK2nA== X-Received: by 2002:a05:6402:2688:b0:5d2:7199:ae6 with SMTP id 4fb4d7f45d1cf-5d41852f3dcmr6281078a12.9.1733850632877; Tue, 10 Dec 2024 09:10:32 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:32 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 12/24] ASoC: renesas: rz-ssi: Use goto label names that specify their actions Date: Tue, 10 Dec 2024 19:09:41 +0200 Message-Id: <20241210170953.2936724-13-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Use goto label names that specify their action. In this way we can have a better understanding of what is the action associated with the label by just reading the label name. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 74632e2482f8..209b5b8827e5 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1084,15 +1084,15 @@ static int rz_ssi_probe(struct platform_device *pde= v) /* Error Interrupt */ ssi->irq_int =3D platform_get_irq_byname(pdev, "int_req"); if (ssi->irq_int < 0) { - rz_ssi_release_dma_channels(ssi); - return ssi->irq_int; + ret =3D ssi->irq_int; + goto err_release_dma_chs; } =20 ret =3D devm_request_irq(dev, ssi->irq_int, &rz_ssi_interrupt, 0, dev_name(dev), ssi); if (ret < 0) { - rz_ssi_release_dma_channels(ssi); - return dev_err_probe(dev, ret, "irq request error (int_req)\n"); + dev_err_probe(dev, ret, "irq request error (int_req)\n"); + goto err_release_dma_chs; } =20 if (!rz_ssi_is_dma_enabled(ssi)) { @@ -1136,7 +1136,7 @@ static int rz_ssi_probe(struct platform_device *pdev) ssi->rstc =3D devm_reset_control_get_exclusive(dev, NULL); if (IS_ERR(ssi->rstc)) { ret =3D PTR_ERR(ssi->rstc); - goto err_reset; + goto err_release_dma_chs; } =20 reset_control_deassert(ssi->rstc); @@ -1152,17 +1152,17 @@ static int rz_ssi_probe(struct platform_device *pde= v) ARRAY_SIZE(rz_ssi_soc_dai)); if (ret < 0) { dev_err(dev, "failed to register snd component\n"); - goto err_snd_soc; + goto err_pm_put; } =20 return 0; =20 -err_snd_soc: +err_pm_put: pm_runtime_put(dev); err_pm: pm_runtime_disable(dev); reset_control_assert(ssi->rstc); -err_reset: +err_release_dma_chs: rz_ssi_release_dma_channels(ssi); =20 return ret; --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EEF92237A27 for ; Tue, 10 Dec 2024 17:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850640; cv=none; b=KdpHUDRWrP1DXk71DJ7nzy60xmsZWWkWov8qF+xCoUKRge13Q0/NGiDLqIPrRNPaz2oPts5s5e2N896IJnyXHygjl65EWqHrZMq+TEjQdapTyiLjK81wShSu6Dclhb31FpyBDdp4ejAyltoW8fJFicTuOMBGRUI6jyHihOLTzsA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850640; c=relaxed/simple; bh=Yz055MkA+pxfsMjRAkbTxtMOq7knGNv3D+SNR/Ylrow=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=oBKGcjFvogXg0XTokXMzk4kK6Ri917RNzVHgzM1IlRV+vcfoqHX4OUvXRbT2e6gjO4R9BYlNntn7Z+eAbLeTrRC18s2EP+bjo4Jh9RbZhRl8eyy3wGRZwjjbqLDjK1LQGRz1Kt//vWcM3fMBVRm+j0PJUJFO5Rmb+4dY3jukSNw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=MAZVe3e8; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="MAZVe3e8" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5d122cf8dd1so9452020a12.2 for ; Tue, 10 Dec 2024 09:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850636; x=1734455436; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kGFKtP/kqhSYwKWsXVqygeaqizf9KcZRKhKS1yEgkJI=; b=MAZVe3e8PZ9TTx9ehV1VXTuqvgGeoAxTuyx9+A38aNUVRkXEKeLwn9Ymx8AlYr7KEA XzfhBuBq0J82ZudgH2v0irugxF7G8Sp5KHxi3oJ+SVDxdIJkODXb+sosZfCyJVETG8cr m6RgsIiCkPfi3WDf6R89tMfTjzfoXW/bi/x2/UdJ+094drqSMGNYS/MHdxslkiu99U9y y78IP21BpxYyHQe3A480mWyYY7FAPrAsc4U1CgpBtvxo1h82JPvVOmfVbUcMrqjzv/zB xbCsj8tbDx/7y/RYIFSsIlDTFapOTNpr94fzJXcss63Sn7FoYv65qKP5d6PuKM89CRJv KuCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850636; x=1734455436; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kGFKtP/kqhSYwKWsXVqygeaqizf9KcZRKhKS1yEgkJI=; b=fhy1pKT/dH2y+fu6XhmOz9v0tkuuELy+lJo2vgh9U390dvXEcDmpZGnjM4ww3NbIzH Wqyk38npDvwnEkkwTW23PXddulWmMMjJceBCx++O13Q0dWdPdYJhSDzWoZE2H0TwnA/6 kVuNytbHZvQ2HLqk2zuug5ADqmggYYfPBaWy9HeOxe6T0gkOSYbvQSfrPOSg72vw81py FXBHxBkYi9g3lmx4nXhBjzmufjzU/J5O+6J7+IBsU/bKs1T+3fgR7ys+ZNFtetlOhKvE dHJp8h0T1zb6SmsCxwBniE2tB0ADrD8yyL7AI6OBrmvqt1fUdOgCj+Lga+yhwIGWsnoV cCnA== X-Forwarded-Encrypted: i=1; AJvYcCXPZsoGM0T3YZC30vh7QaYMrbPcrUsuuGWOly7b9cPY2yYBuvUUJ5P38a2Kd1Azz/zo3+RyaBG2ENrispE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6kKjVILexi3Y/ZWXLaX+97XtdF49E0WirhQF8RZ62BsTuHVXy GT0U7g0/2dyJxsijpIz6kBtsJzhceeMQxrdz+6Cr5y0sNsrT9wW70SKeSKmquRA= X-Gm-Gg: ASbGncsHV5wzoCC09rHzaBfwnHfZ/q7cVeAwfkfwH5rAh8KqvOiURdLzmmh5hNN5p3Z g2efUC0pUoihc8GBrG057qMcTFnbH02WCqyCOG+MEypygCKaYLw3b43QNN0c+U7i31VVJrF6Odv 0kC1xBu9xy8h0tI1OkXzc4OIHu8AiS26qY6qD+Rjweei39/Zahzo6RP9UlaWB0JuC5GSLRjPN8V V4aZNLhrafnOEbeXqsaMY9oMnRLUclsOsmRbGXfTl8H5FTj1hoZngUOF3dzz6HtsWPByn6oXcLZ zgvnyUvY X-Google-Smtp-Source: AGHT+IEC55JYbSGMCcanrVtAVCn++NmOM5lxtdpdi4NfwxaJizcleFUS/sRGsmrPp5CnJom5vv0rQw== X-Received: by 2002:a05:6402:43c5:b0:5d0:b51c:8479 with SMTP id 4fb4d7f45d1cf-5d3be680125mr18546630a12.10.1733850636238; Tue, 10 Dec 2024 09:10:36 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:34 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 13/24] ASoC: renesas: rz-ssi: Rely on the ASoC subsystem to runtime resume/suspend the SSI Date: Tue, 10 Dec 2024 19:09:42 +0200 Message-Id: <20241210170953.2936724-14-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The ASoC subsystem takes care of runtime resume/suspend the audio devices when needed. Just enable the runtime PM on the SSI driver and let the subsystem runtime resume/suspend it. While at it use directly the devm_pm_runtime_enable(). Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 209b5b8827e5..878158344f88 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1140,11 +1140,10 @@ static int rz_ssi_probe(struct platform_device *pde= v) } =20 reset_control_deassert(ssi->rstc); - pm_runtime_enable(dev); - ret =3D pm_runtime_resume_and_get(dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - dev_err(dev, "pm_runtime_resume_and_get failed\n"); - goto err_pm; + dev_err(dev, "Failed to enable runtime PM!\n"); + goto err_reset; } =20 ret =3D devm_snd_soc_register_component(dev, &rz_ssi_soc_component, @@ -1152,15 +1151,12 @@ static int rz_ssi_probe(struct platform_device *pde= v) ARRAY_SIZE(rz_ssi_soc_dai)); if (ret < 0) { dev_err(dev, "failed to register snd component\n"); - goto err_pm_put; + goto err_reset; } =20 return 0; =20 -err_pm_put: - pm_runtime_put(dev); -err_pm: - pm_runtime_disable(dev); +err_reset: reset_control_assert(ssi->rstc); err_release_dma_chs: rz_ssi_release_dma_channels(ssi); @@ -1174,8 +1170,6 @@ static void rz_ssi_remove(struct platform_device *pde= v) =20 rz_ssi_release_dma_channels(ssi); =20 - pm_runtime_put(ssi->dev); - pm_runtime_disable(ssi->dev); reset_control_assert(ssi->rstc); } =20 --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BC1222FAE3 for ; Tue, 10 Dec 2024 17:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850642; cv=none; b=M5PLojd8jSQKv1AA2VYChdmA5jgSEYOzCy1Gf0Fyn33h0G0BM7eSoGya8dln/1lGgdJwbdhaaWQuVj8+vZEWvnIOlgLKHpbIUiP3F/B2CsvRL13Hcojp2Am+pNxZsXq5NdHYCNLdA6rUfz6kVGHnTpA2RI7JPN9wt+gxe9n6ALk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850642; c=relaxed/simple; bh=cB+Bpu7l1dV+zM88HO7Ze3t/5fdXwi7jPTuxAvUk+U8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HXKbjlBHTVxjSlovWYk9mM75iokNUTDlQs2nqUkR/R9hgUA1nl9mjyxvb6c8SHkgteWqzHSnZMTUR/QTmj3oAzT+KQLkFqYXaAw4zw/7P/JDoJIkXmADA9CE5vm653vsjW+pQfHKZoGaEO9tfddSIgh3VUrLjsrWdnhmKstv+iY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=VqH3JmWO; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="VqH3JmWO" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5d122cf8dd1so9452088a12.2 for ; Tue, 10 Dec 2024 09:10:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850638; x=1734455438; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z6Hy/pRodMw2d91URONzNaEgR8YWtQs7fLTqCwO7+FQ=; b=VqH3JmWO8a/dlBZKwdVROvo/+MKWvN5DXmrbLUo5A39E3UaP444kOfHcntyoanVGjg 5vyCowgmh/B2NTIEPfRrqdv0rMnEf53eif3FLFzpyLecp4R3kKQg69iHg1sFQCWSBeqM HJ8Ui6I6oZMTPq6JmgABmhUfAZP7iJddfzI+mHWvTGonyc819SJ4HtBssjejTKjz7c2z m4puIilvI35SmSnQDwsF/8cyKd+rs81QLiYLKWa7XfKVGFrSQW6YweovrzD/7hrFpmNv zGHqHUvL/jxvurpIGALUpBWfFaERvJ0HBkM9GM/FX8ruLg8wCe3SfYiquALvGyB7mhqC 5f1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850638; x=1734455438; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z6Hy/pRodMw2d91URONzNaEgR8YWtQs7fLTqCwO7+FQ=; b=phj0X8ZaOKZEbCwMrqts+0mQ8QZ7iGdZBjn9V6qhJyrlHivqYvXBx/JrCSdO5SQ9y5 kxC6jeK6meRiLyPAkNTXFo1tkhJ/2VROOX5yzk5nyMwwKLZO5DAvhx/RWX1JeFJxEUS6 ln6ku431GbDOLz+wUH3x5yp2RWzl3Gr16UXkNml47bDEfcu81O4m9G61Gd1q3t68jQqH hN9v2FvbnFgjQygwxV6eTSxIhHI7rAS0p9sYpnbP4fPEMqK2O+Ij9jsHT96rerP1hBJr GHljOF7btqsffTMYxAlZwupp39yVbY08S9OiG7qEiy3LyeWxT7xV3+vz+x57tC+b9fy2 LkyQ== X-Forwarded-Encrypted: i=1; AJvYcCV8sLABCsjLgnWUzeBZ3fPyjnEbr5zHj43z9lcFgUQ/461OsS0SLn3Xqm13xRw+rmQ0qm7f6vOnDf7PQms=@vger.kernel.org X-Gm-Message-State: AOJu0YyzriyihgYptvcC6QdLdpwSrCYhsoYdbTS0Fku3EFIABwnR/L6q Au5RKR06V+03J4D59Ubl+ta3I4iOIGgqaBeMQEJhrCQV/TZHK9rRqF56RN6xAuQ= X-Gm-Gg: ASbGncuWEpY0bIvy6W4GCUgbfR1wZVe6rjYgC/KiaQDQForeZP6ymZ/wZ9k6D0y7aSG /W8rjVX4Ee3xiFi6IbKf9jxbE25hdVblSXu6blHoaz6uQSWY8UAwQ8GF+Ik5DkAYA+Snwz0s7aG 6bqQCbWBSyL7XpcjuWR3KpTNxf21vZvkr/T0zdFhnEjcInxx4rdt24ikVN1L2RWIxVFw/umcQpy diFBIHha6Vkqo5BPHKqsVOsgPSmMUZtKzcIY12NqTzh+zPfOqL1kDTzqAJlz0iTgT1M9LVuQ9V0 +aybb2dGiR0= X-Google-Smtp-Source: AGHT+IGqcJ6bqhwIIKJrt+yeOZgP79f+Ka5SbVUv4mcFJwjMu+9gX00sz7DE8koWILZTW546alVDvg== X-Received: by 2002:a05:6402:1f10:b0:5d0:b4ea:9743 with SMTP id 4fb4d7f45d1cf-5d3be67e142mr17354125a12.8.1733850638421; Tue, 10 Dec 2024 09:10:38 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:37 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 14/24] ASoC: renesas: rz-ssi: Enable runtime PM autosuspend support Date: Tue, 10 Dec 2024 19:09:43 +0200 Message-Id: <20241210170953.2936724-15-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Enable runtime PM autosuspend support. The chosen autosuspend delay is zero for immediate autosuspend. In case there are users that need a different autosuspend delay, it can be adjusted through sysfs. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 878158344f88..eebf2d647ef2 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1140,6 +1140,9 @@ static int rz_ssi_probe(struct platform_device *pdev) } =20 reset_control_deassert(ssi->rstc); + /* Default 0 for power saving. Can be overridden via sysfs. */ + pm_runtime_set_autosuspend_delay(dev, 0); + pm_runtime_use_autosuspend(dev); ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { dev_err(dev, "Failed to enable runtime PM!\n"); --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4BD232372 for ; Tue, 10 Dec 2024 17:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850644; cv=none; b=OJ2q4FgPxgCWK62N64ME2c5lOZN6m7Ej+XA+o9npaoFudrsg33WX8ckX27el3UI8ke4jevQLMmnL6xyVW6Ll62bfVF5XslEzxanA885DRRwUohFfC5CFpSB3HmI0y+RU/0TS5jUK2ppcW/vkADO2sBHR4xoNgL5qY0vEvwyWB+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850644; c=relaxed/simple; bh=QfMAQ3ObJOM7gWSlinrrpwhjt1hderzxfmdZZzAXUok=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=VzpivkZW7JVXP4TmovMN9y4KWbczBVk/q1NlW0xOQBDvXcW4vq66KqMxYYVo8re3nfAbYW7rPHIvZSwbog6RM7ZUCFMPsXBzJB4Lcrv28ta/GDnNa5hNc3I2r8g6NRb6JfMf4p1GzICy5Oc3hNE1Ud+echEH+WH3O9WjEKrweQM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=JqwHzBsB; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="JqwHzBsB" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5cfa1ec3b94so7696520a12.2 for ; Tue, 10 Dec 2024 09:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850641; x=1734455441; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6UysEDL+tYPOXb/CerEK2e/yd8/mnBKQO5ExCdaAA4A=; b=JqwHzBsBEtd6G7nP26tKtUetS/eenZbMMrUCRVLkWx99zAOMVKHQFyp8iaVQCf8OyC pK0H6wj5Qz2eWGxAGNMG82okQscg8tl5fVDnO55YWDbGhrh/K1+YOykOomQREU8H9yHs PTSEEQV+ewrbVQFglz+GYna9/XyO6nmPvpQmYCHLs9smQM+ayP85EAhIQlNgmOM2oGSY EUUVRaFxjvpyaDHkAdpcrzmXnvOi+QwqCiU0SxGsaOnTJ1xh7gN9LN+ugcGDiIKJap8t LRbpYIWSPUtH8TcB1Ly1vA2Bk6FHKxqZnE1DZBOe0TyasfNUoUm1xQ31sRez2CrvhUGB hrPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850641; x=1734455441; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6UysEDL+tYPOXb/CerEK2e/yd8/mnBKQO5ExCdaAA4A=; b=voF/4m43zmzbN10mmQASX9BIWY6a6017drkiImkKubbI5hliIy65WdezCBV99j+V7y ETv2FDzMkudT2xFB2QQ3i4WPP7zJxy0SBug1881LkKGETO058urxCI75MZ6mqmu0A8di mXIyerq7wMFujwBeGjwN9PubaxNYzMzA+JmLDDMjoSYTU4Lh5jaklEddGJKqjzvF4WCm Rcmq82E89NCGASajo4KRSkGv1+vp1Hlc6Oj69kEZ2oXknmPhHGFKpuzF3RILv1tGm2qQ PgKShcOhtqAEEmnGz/BI4hrAFOp9r117COWz3oG6ccuHDYNWisbx+ufbJIlzJ2GNZeFb HX0A== X-Forwarded-Encrypted: i=1; AJvYcCUYOLZ+W8zxrkAi2PGXjOkEs4qc5lHqZ7WeaE9BnQf8vjH9lPdVzQ2bV8mcvHLpUqfoEq7+VzARhjuJo3o=@vger.kernel.org X-Gm-Message-State: AOJu0YwIVONCameJ9mMBJ8j4X8/08rQTnFd7+hfTgAbG4prYESHdM1dH 4czP27Sytx2r00dyAlUVLhzCwMEmfXhKHHkZ3FwbrXvWdYvzm8QtbLwSxaUgh6c= X-Gm-Gg: ASbGncvFT5FyjvLpOTO4iVX9c9ZLkl9gO8mGsI8791p1gQseW73HB/6v6Fn1jGIu/3Q i80wJKhZXNcjmsSIW7Up0QsM6NlL0kliVrOg7e6MRG2gQJlJklRN9qGiyynwVKzxPJbn0qBsKRH pO3gtUGPAEfcekTs0z1g8pOUgTPfGxsTMHTvsR8lzbBRrlAu9vbQViZJCXyoaQBHhXaT1ienPE3 ac1soxxJmMM6jHaNiOwx5qZ1zw3TKx/oKkxY+MLL2nEBbdTuSwm8kwWgpntvfeJdALJEPuhbCag D4Tx9xGo X-Google-Smtp-Source: AGHT+IGDKksFRS7v8EJ79Qo0q8lVB55Bo0RkH6EDk6sqVxrrszOEC3HW/n36JzbvJ+iqRQS48HVTZQ== X-Received: by 2002:a05:6402:35d1:b0:5d0:a80d:bce9 with SMTP id 4fb4d7f45d1cf-5d3be71c114mr15442107a12.20.1733850640930; Tue, 10 Dec 2024 09:10:40 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:40 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 15/24] ASoC: renesas: rz-ssi: Add runtime PM support Date: Tue, 10 Dec 2024 19:09:44 +0200 Message-Id: <20241210170953.2936724-16-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add runtime PM support to the ssi driver. This assert/de-assert the reset lines on runtime suspend/resume. Along with it the de-assertion of the reset line from probe function was removed as it is not necessary anymore. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index eebf2d647ef2..34c2e22b5a67 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -1139,14 +1139,13 @@ static int rz_ssi_probe(struct platform_device *pde= v) goto err_release_dma_chs; } =20 - reset_control_deassert(ssi->rstc); /* Default 0 for power saving. Can be overridden via sysfs. */ pm_runtime_set_autosuspend_delay(dev, 0); pm_runtime_use_autosuspend(dev); ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { dev_err(dev, "Failed to enable runtime PM!\n"); - goto err_reset; + goto err_release_dma_chs; } =20 ret =3D devm_snd_soc_register_component(dev, &rz_ssi_soc_component, @@ -1154,13 +1153,11 @@ static int rz_ssi_probe(struct platform_device *pde= v) ARRAY_SIZE(rz_ssi_soc_dai)); if (ret < 0) { dev_err(dev, "failed to register snd component\n"); - goto err_reset; + goto err_release_dma_chs; } =20 return 0; =20 -err_reset: - reset_control_assert(ssi->rstc); err_release_dma_chs: rz_ssi_release_dma_channels(ssi); =20 @@ -1182,10 +1179,29 @@ static const struct of_device_id rz_ssi_of_match[] = =3D { }; MODULE_DEVICE_TABLE(of, rz_ssi_of_match); =20 +static int rz_ssi_runtime_suspend(struct device *dev) +{ + struct rz_ssi_priv *ssi =3D dev_get_drvdata(dev); + + return reset_control_assert(ssi->rstc); +} + +static int rz_ssi_runtime_resume(struct device *dev) +{ + struct rz_ssi_priv *ssi =3D dev_get_drvdata(dev); + + return reset_control_deassert(ssi->rstc); +} + +static const struct dev_pm_ops rz_ssi_pm_ops =3D { + RUNTIME_PM_OPS(rz_ssi_runtime_suspend, rz_ssi_runtime_resume, NULL) +}; + static struct platform_driver rz_ssi_driver =3D { .driver =3D { .name =3D "rz-ssi-pcm-audio", .of_match_table =3D rz_ssi_of_match, + .pm =3D pm_ptr(&rz_ssi_pm_ops), }, .probe =3D rz_ssi_probe, .remove =3D rz_ssi_remove, --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61164232392 for ; Tue, 10 Dec 2024 17:10:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850646; cv=none; b=tTu+Wa+Ao/5EBciFrmkJ1P7DdiepgV0lDlicLkUNcGTMXOal4sdIplK+7mqlU+JeRF8jz4dBGuWBUDhzlNtrfvt2KjOhmvW3lmGSwSjms3P2azqT+GXLvdZG/M86QaE7Y4O+Y+PkvOQiqvRaQ9dmNlWHB0G2iVpfCCY7dZSoLbI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850646; c=relaxed/simple; bh=WRiEYmvCrEDu0efYiS+BnJtjOfOD3CrYjSzhUZqxggA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=du+c33GqFkDuBM03uNYMKnqLxnSpTKWsn30y+eBD8ffr7su0/XrAltp3bDvpkCx9y0WbD8J2x4mFSRlhKSKJ2aQWdu+n3+enSXjBP2zfVg35AKjiYgJlH+g594+wzHiRticRnwQKxUfzM9EVFoqbhnzktdn8lpWAcLA3VQfpByQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Zvofd3HV; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Zvofd3HV" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d3f65844deso4040733a12.0 for ; Tue, 10 Dec 2024 09:10:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850643; x=1734455443; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gNFyzgag91SKUVQoD8nVAEcB8AscK0h2z9GDPU+fWvo=; b=Zvofd3HV+DvTBxPWHoe1SPdInPdjNUYoU2M8AXG1stpYGcYV3v7cBbmZd8kUT+meB8 12eWtszwZpoFY5Kf28ox3CaKK6VH1DlCk0TsS05KBwIJEtEDQrNGXzfsTTvPZJqoV7jY II6zCvU6yiK/5vViQp3OF2FWBUUhUt/fkT+r/obZsWVi2LVRJqRySj8621edsqgbPH5i 0Smr+H8kGxvN8wt/xDjT9PP8rlDT1SyDFtRpuLB2xYZW96CM4BO3cI2ctyLmY2Cg1/VA KmZgpa/FA911VIvsqiyyzxCaTMBTzH3SMSWZfk4CCbQqoMyP8rIc/G9gm7cz92e/lbcH Qtug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850643; x=1734455443; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gNFyzgag91SKUVQoD8nVAEcB8AscK0h2z9GDPU+fWvo=; b=kEyNbgjqj1TtIDX332rr2aFoLPH91FSBtbbk6dc/U74zMzpd0ynVWG/lWF/d17FYXF ZNur/ruYmw7qSXbUhDKPf+bQ2PEpPZ4him5KGiR8bSnrAIwUuE4mdDYq9aV25ARqWCHZ zSw6WHECRjwNHGQz6X6WntwrHdlrvYhcfvjUpzAEv+xvs3r+FCAtGE/LUoZmzkEQGDV+ lF3EIVZ8sviDefCkC4xwAfJC38/Zcq8Wdrw5fsOjn8cf4jGTuAMFfLozuFYFnfiO0+dk HQEVMTP1KfuqfTHGbBfexd7QfPpF/QE2Bd1M8UFY/8RcknfsAMc9w30/YbGT2uBQ5QDL tyOQ== X-Forwarded-Encrypted: i=1; AJvYcCV8Z+R4TFFugYIEKLwD80qKMn/2Krb+hCfY9z9vmDpDH1d6AWgiEbgoqBYBI171K6ihmoxiIjELiM3jL6s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5i7C+WXIikP8yxWX2sg6ZDXf/zI/ZYu+mXrfyd5kojAqbOGmP T7ECGLpEqUbE/pnYssKQTBfbz1D0dw1pxOCpnRZjRjvje3f3x061gicdDMtcm3M= X-Gm-Gg: ASbGncsTzebS5JcfHRZsa228sKCIpRkxp+sIugfE2rB+8y1vbzU7VJ2uzRdSlOkP6TP VPmGa1i/ppxPmtnUQ9iG6rip3ZJfm1ndbDALRvx+BbxtwCcLE+rl7cg3VPMldtqsdLKPFZ6piI/ 1j4e5/gjHT3vU3udghoxQIz23KMbLOcYSkitoToEnYS8xlUsbsyBr3/HfYC9mDGqfI9Sw4CcmH8 BgktslTcKRHSJx0DUS0cZNjuU67kJzpy1Ikf+rOU2QvmjAc59ZvaL9qn85XgGTTk6tfwdw0p0x5 nvyLnraL X-Google-Smtp-Source: AGHT+IGBwrXeGyw9PzNdwLgYXKjgGaPgrny0AlmNGbVXlrqkKBOlqakuZUH3QzbVuduS9Y4Lgz1XGQ== X-Received: by 2002:aa7:d985:0:b0:5d3:d8b9:674d with SMTP id 4fb4d7f45d1cf-5d3d8b967femr12400130a12.0.1733850642620; Tue, 10 Dec 2024 09:10:42 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:42 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 16/24] ASoC: renesas: rz-ssi: Issue software reset in hw_params API Date: Tue, 10 Dec 2024 19:09:45 +0200 Message-Id: <20241210170953.2936724-17-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The code initially issued software reset on SNDRV_PCM_TRIGGER_START action only before starting the first stream. This can be easily moved to hw_params() as the action is similar to setting the clocks. Moreover, according to the hardware manual (Table 35.7 Bits Initialized by Software Reset of the SSIFCR.SSIRST Bit) the software reset action acts also on the clock dividers bits. Due to this issue the software reset in hw_params() before configuring the clock dividers. This also simplifies the code in trigger API. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags - use rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_SSIRST); in rz_ssi_swrese= t() as suggested in the review process Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 34c2e22b5a67..486822d79458 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -388,6 +388,15 @@ static int rz_ssi_start(struct rz_ssi_priv *ssi, struc= t rz_ssi_stream *strm) return 0; } =20 +static int rz_ssi_swreset(struct rz_ssi_priv *ssi) +{ + u32 tmp; + + rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_SSIRST); + rz_ssi_reg_mask_setl(ssi, SSIFCR, SSIFCR_SSIRST, 0); + return readl_poll_timeout_atomic(ssi->base + SSIFCR, tmp, !(tmp & SSIFCR_= SSIRST), 1, 5); +} + static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm) { strm->running =3D 0; @@ -782,14 +791,6 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substream= *substream, int cmd, =20 switch (cmd) { case SNDRV_PCM_TRIGGER_START: - /* Soft Reset */ - if (!rz_ssi_is_stream_running(&ssi->playback) && - !rz_ssi_is_stream_running(&ssi->capture)) { - rz_ssi_reg_mask_setl(ssi, SSIFCR, 0, SSIFCR_SSIRST); - rz_ssi_reg_mask_setl(ssi, SSIFCR, SSIFCR_SSIRST, 0); - udelay(5); - } - rz_ssi_stream_init(strm, substream); =20 if (ssi->dma_rt) { @@ -914,6 +915,7 @@ static int rz_ssi_dai_hw_params(struct snd_pcm_substrea= m *substream, SNDRV_PCM_HW_PARAM_SAMPLE_BITS)->min; unsigned int channels =3D params_channels(params); unsigned int rate =3D params_rate(params); + int ret; =20 if (sample_bits !=3D 16) { dev_err(ssi->dev, "Unsupported sample width: %d\n", @@ -940,6 +942,10 @@ static int rz_ssi_dai_hw_params(struct snd_pcm_substre= am *substream, rz_ssi_cache_hw_params(ssi, rate, channels, strm->sample_width, sample_bits); =20 + ret =3D rz_ssi_swreset(ssi); + if (ret) + return ret; + return rz_ssi_clk_setup(ssi, rate, channels); } =20 --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E30E23EBF5 for ; Tue, 10 Dec 2024 17:10:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850648; cv=none; b=q0NgbiMM+FdQCeLxe4ajoRZzsp0uMAjG5qwC+n6dTQdmnvUCmhMC7820bf6PHQeBzV4x74aHJ+iugpXc2ylugJ/DK9fDBWmzUZRxlauzAK1Ea44Dhc1FBDqY/zsOiq5UQ2Ue9r40xyKteAxWFjyB8dLh2p5ReliwAnzm5YSG3UM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850648; c=relaxed/simple; bh=JQNGPZYkGQRQ2sTS79lFZ6me2mcLImriGT7BK3n9sx8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=G7nLpF8V/6+45Sa82IBq3GFYkDPSsHd438X/eTIhl6XdmeZNnSMj9LDkOxk2rhJAScNjpXd6zl30JfzOvXlf6O3uHMI4GcXpePBt8b9T011yZYIHPS0rAAvpTuz42hkWhsZXu702pDsVjKMlAN6QnaXwEgk/fVptJRfEjoyCqFc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=RxkgtaoU; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="RxkgtaoU" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5d3bdccba49so7279184a12.1 for ; Tue, 10 Dec 2024 09:10:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850645; x=1734455445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zdorf6J6oUWOvTlM/ckHP3yguOeZKUZzy/Da078XD3Q=; b=RxkgtaoUMawCkOLuYSCT0LaqBXe0bXBvLgBy/pgjEtbXQNA8Vqy5k636ofhxNKac5Z euouPsNyepl84zZmi1DHJ57gUxsm4a4ZMnOXZnO5n9tTgpmC1IjGud8k5RQvqfer6dl6 5BlooiNDCoggtL79AHgEC9LkU8fE7fo+U7sVSwvu8w2URX970dpGlgGJ1xW7RJOdAf2e c/m0Jd+uARwv2JQ7MTVqrHJDjU3lwWw1Z0wlgEZm+04vghaA3jzfQdhpI+ZkjHV01CA3 ZqPWHBXF6RkDUQGeLYHOdYHrJUG6MIz9WwYtVRaMFWn8NPC0K6pyL2PSOL8iah+PegfE 2IWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850645; x=1734455445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zdorf6J6oUWOvTlM/ckHP3yguOeZKUZzy/Da078XD3Q=; b=hz+CjK2HfKpKROnKTUcbkAuTCcPkrtzpwmNmMqRm6Gero/7+tJK4fGZIibgbFl3J3z mvYD3qtpGH2KUG6E6lY24dl9l3oBEFxG+rrxRZ0AbO13nkdRW7nrhFOLqsPTet9uZlzf gjWsbdVkRzck8dT37tvISfgJ+shvPCy3aIqsM4gTJIO3mVAeh5LJSVCfv8U6N3/LTRnC AJylf288rL5abWSr21PS3cIKA+1EyJQPZirIuoK/kkvGz7A3hEqKVIQwviftUnJ6BsXl RHJ8j5fJGU+pT1sHyQrYMEgHdDJLbFfNtSWwkfVAbWpeIkI/0Y/JhkdwnajphgWhy65i gpmw== X-Forwarded-Encrypted: i=1; AJvYcCXdIBh5A+HoERVisaq/R4QjN+QvG8YFb1wU5aCEx54cZZwNTorWyLV3pVQQLPT1jiaVeCeTL/J3T+cQJyE=@vger.kernel.org X-Gm-Message-State: AOJu0YwjOCsDNU442uqTCVnj+R6yxtLvrR5hkjNF7wiwQCQnTn5I1oRl Xg2srHA2G1NXu/22fabCGXR5ggry2ROGaIQ3m9FbZgA3/uoCW3B/jOd8mdwV/uDGLhri0uHLqaW D X-Gm-Gg: ASbGncucZR/jlmhyZqFIPqRht9PxZSpk+5WLcij8sUJwsNs98buKU+IzaufrsjPDmU1 E1WlSKMn8LYPeYhloBB9dNWoWYqmw2aIzmWMw+VgdQEKJqusu53VKPoMn4UbHlH3CG20eI/BXl4 dxlUYwnncneDr5K/CLF9oNIK5qFCfX6g0WdGEG2eK2WIt6SObClPXsQ7kBMtMiPYMVJixfi3VfO PTGLYbu2NzJ4M/qb9tULWrG6+qPL9E9HGAuKSjHHc/a29TXJgyH9mnZvaOdLP2a9+PeO/OeOPGj gvPhTSB4 X-Google-Smtp-Source: AGHT+IG0YYavl8GoEPcOWdjWdvPZujuBgG2HJ16HofI4S8uWOgmyS/RSRLDoRpiWfKoP6RlhHB13MA== X-Received: by 2002:a05:6402:3493:b0:5d3:e9fd:9a15 with SMTP id 4fb4d7f45d1cf-5d3e9fd9b71mr12243945a12.32.1733850644830; Tue, 10 Dec 2024 09:10:44 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:43 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 17/24] ASoC: renesas: rz-ssi: Add suspend to RAM support Date: Tue, 10 Dec 2024 19:09:46 +0200 Message-Id: <20241210170953.2936724-18-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The SSIF-2 IP is available on the Renesas RZ/G3S SoC. The Renesas RZ/G3S SoC supports a power-saving mode where power to most of the SoC components is turned off. Add suspend/resume support to the SSIF-2 driver to support this power-saving mode. On SNDRV_PCM_TRIGGER_SUSPEND trigger the SSI is stopped (the stream user pointer is left untouched to avoid breaking user space and the dma buffer pointer is set to zero), on SNDRV_PCM_TRIGGER_RESUME software reset is issued for the SSIF-2 IP and the clocks are re-configured. Signed-off-by: Claudiu Beznea --- Changes in v4: - none Changes in v3: - s/sh/renesas in patch title Changes in v2: - none sound/soc/renesas/rz-ssi.c | 46 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git a/sound/soc/renesas/rz-ssi.c b/sound/soc/renesas/rz-ssi.c index 486822d79458..d48e2e7356b6 100644 --- a/sound/soc/renesas/rz-ssi.c +++ b/sound/soc/renesas/rz-ssi.c @@ -782,6 +782,32 @@ static int rz_ssi_dma_request(struct rz_ssi_priv *ssi,= struct device *dev) return -ENODEV; } =20 +static int rz_ssi_trigger_resume(struct rz_ssi_priv *ssi) +{ + int ret; + + if (rz_ssi_is_stream_running(&ssi->playback) || + rz_ssi_is_stream_running(&ssi->capture)) + return 0; + + ret =3D rz_ssi_swreset(ssi); + if (ret) + return ret; + + return rz_ssi_clk_setup(ssi, ssi->hw_params_cache.rate, + ssi->hw_params_cache.channels); +} + +static void rz_ssi_streams_suspend(struct rz_ssi_priv *ssi) +{ + if (rz_ssi_is_stream_running(&ssi->playback) || + rz_ssi_is_stream_running(&ssi->capture)) + return; + + ssi->playback.dma_buffer_pos =3D 0; + ssi->capture.dma_buffer_pos =3D 0; +} + static int rz_ssi_dai_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai) { @@ -790,8 +816,16 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substream= *substream, int cmd, int ret =3D 0, i, num_transfer =3D 1; =20 switch (cmd) { + case SNDRV_PCM_TRIGGER_RESUME: + ret =3D rz_ssi_trigger_resume(ssi); + if (ret) + return ret; + + fallthrough; + case SNDRV_PCM_TRIGGER_START: - rz_ssi_stream_init(strm, substream); + if (cmd =3D=3D SNDRV_PCM_TRIGGER_START) + rz_ssi_stream_init(strm, substream); =20 if (ssi->dma_rt) { bool is_playback; @@ -819,6 +853,12 @@ static int rz_ssi_dai_trigger(struct snd_pcm_substream= *substream, int cmd, =20 ret =3D rz_ssi_start(ssi, strm); break; + + case SNDRV_PCM_TRIGGER_SUSPEND: + rz_ssi_stop(ssi, strm); + rz_ssi_streams_suspend(ssi); + break; + case SNDRV_PCM_TRIGGER_STOP: rz_ssi_stop(ssi, strm); rz_ssi_stream_quit(ssi, strm); @@ -958,7 +998,8 @@ static const struct snd_soc_dai_ops rz_ssi_dai_ops =3D { static const struct snd_pcm_hardware rz_ssi_pcm_hardware =3D { .info =3D SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_MMAP | - SNDRV_PCM_INFO_MMAP_VALID, + SNDRV_PCM_INFO_MMAP_VALID | + SNDRV_PCM_INFO_RESUME, .buffer_bytes_max =3D PREALLOC_BUFFER, .period_bytes_min =3D 32, .period_bytes_max =3D 8192, @@ -1201,6 +1242,7 @@ static int rz_ssi_runtime_resume(struct device *dev) =20 static const struct dev_pm_ops rz_ssi_pm_ops =3D { RUNTIME_PM_OPS(rz_ssi_runtime_suspend, rz_ssi_runtime_resume, NULL) + SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume) }; =20 static struct platform_driver rz_ssi_driver =3D { --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D03323238A for ; Tue, 10 Dec 2024 17:10:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850649; cv=none; b=lrRgOrXqLmmayDOcXqPjNCsvVAcB5Pk6xAfKit1YDrso5Y0tE10rZFnXAbysK4jEl7fTogh7+nLUArRFsG2naXMOA3DFcTP46TTaEHctg1qa8/aMpJb5ETQic8KjuyuuAumEisupplyq1sJV4LwJt2O8PXIgKaCO2CvFq/HiQUw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850649; c=relaxed/simple; bh=NtVph11BLd+x3z/1Zok/7JAFGIkvZxSriGpx0rha4FE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gJ4EvKCg5OsGZdciOvADXgCSN/XsIGNbUmmi1o7JHyYRgHQvYkGuen0mR8flWhlvGnHEaYfWUv69J77oV6nKnVTzRcW5oQDR8ZTQH9WFm8KmoH6675/cYCqvq3pwHism1vUKLJrNEcIyZAe5Ov75pFHhjkSoJmVUFl74M0YXtiU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=Oum+znJo; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="Oum+znJo" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d3e9f60bf4so4671211a12.3 for ; Tue, 10 Dec 2024 09:10:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850646; x=1734455446; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pzloo09Dgg4guioxkvLZOvAnsn9Efhp0SVwyR1byrx8=; b=Oum+znJotR81/GL+s9X3RPKW5dG7Pck33ayCgAliJEErevbuKFkHniF15QcQxdR1Lu vF3o8AhuF6Ny7cyQFsEuNwdPc6trLk/EWN7ujzUcFmQaHysDSPF6A1ZhxolQstOajJiZ ZnKbRxOk3roMK3Rz+yycNhSsGq6SJ3gksF1ieic7eNUH5/N3IdtUd70i8hCLfbbCAcfJ k80F0Quf6lF3FZxetKrqqw0wS0zJMxdVFKF3jdUSgL1yV+xE9tpT43R43DsKI95fJPvs EC4e4vq9x+nXRpvQaTgPqeslzokVL1S2fr6vO7ngkTGvpUSiVxsz5w+aWIRSQeFrjF6q SB6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850646; x=1734455446; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pzloo09Dgg4guioxkvLZOvAnsn9Efhp0SVwyR1byrx8=; b=CQ59k9vQGdzAPmQsM2G99yqJ/TJiPbC/KLre6hEeVt3cX8+Gqjx+E8RBO/qi1L1nJ0 pAZ6osqvE9b7e8EAm11VMorgfthZcjZ+/U4VjUiOuFbJYyxeaFS+ufqvWuNjdX+Dv+NN mbF6SeFcB3NoQcB7RVj9nIosrF5i6VdJnRy92g8342HcKcPLmK9Dt2L9dYFdWZJsMd7c JFK488MrYrmAyspSms7Js9ebwkfIpSDmgYoKwsZz2TDPz4U0B9eUldL9+lgkUoq88B4I aat6chOgTvqFxMtvUHKzjaZ86u45cutCZDnWS5bKZk0cwbi5JWFbxGq77636n/cHHOsz 2PVw== X-Forwarded-Encrypted: i=1; AJvYcCURHodmWqWYm2HL/I8hrTaar/xResziLnpcbMQIm9TtMsN4G3REveijWvhWKaB5jg4O1SUkRThBKIPqLhM=@vger.kernel.org X-Gm-Message-State: AOJu0YzZWzy2+99ipV9T8KLJolI+A7XwFxDwZ/JPwN8f7AW5KmJOJD91 HqZZ4AzxziPWPNyJQqHlsXKjftpQY5lBLpgvNvj1bSqiWsIMZrZl746tqUAKwnM= X-Gm-Gg: ASbGnctbtaTO+Dv82N6NfIuA/cFiBYnsvJAjY+9E2Ch0ovE9HXxRTXVVyU1PClM5Bp/ 8tqo8bRy2FT62zVjNbhWZ6aP6nxagxNSQYttLanj54sZv3FP7icXwgUfYE25N/VgC9qvCR9vh83 bSbE7EeMYNhpJfFNx5RqjNXl8Y5KyhfRoLV5XxQ0Y2FDGQwUQ6Kq99TF5U7Yd2ItwCkHkyWwmZj mWR0w5tc+74tWP8CGo672O+EZwZ9lxJ3PywFUYRpsp3MEhR2WbCwYxQlagV9W+X8vU/shmYFTH7 ySzhr34iYU0= X-Google-Smtp-Source: AGHT+IHu+/x+M8u5QIMjQ6egtfsihnsclgAo9NZ4IQV+C7GzhzYxCnvnX8xs1AndpKM2ie6VGxgEag== X-Received: by 2002:a05:6402:3591:b0:5d3:e45d:ba91 with SMTP id 4fb4d7f45d1cf-5d3e45dbbfbmr13230055a12.32.1733850646516; Tue, 10 Dec 2024 09:10:46 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:46 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea , Geert Uytterhoeven Subject: [PATCH v4 18/24] ASoC: dt-bindings: renesas,rz-ssi: Remove DMA description Date: Tue, 10 Dec 2024 19:09:47 +0200 Message-Id: <20241210170953.2936724-19-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Remove the DMA description, as it duplicates content from ../dma/renesas,rz-dma.yaml. Additionally, remove the MID/RID examples mentioned in the dropped description (this information is already documented in the hardware manual). Suggested-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - none; this patch is new .../bindings/sound/renesas,rz-ssi.yaml | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/= Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml index f4610eaed1e1..5b42eec864f8 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml @@ -57,24 +57,6 @@ properties: dmas: minItems: 1 maxItems: 2 - description: - The first cell represents a phandle to dmac. - The second cell specifies the encoded MID/RID values of the SSI port - connected to the DMA client and the slave channel configuration - parameters. - bits[0:9] - Specifies MID/RID value of a SSI channel as below - MID/RID value of SSI rx0 =3D 0x256 - MID/RID value of SSI tx0 =3D 0x255 - MID/RID value of SSI rx1 =3D 0x25a - MID/RID value of SSI tx1 =3D 0x259 - MID/RID value of SSI rt2 =3D 0x25f - MID/RID value of SSI rx3 =3D 0x262 - MID/RID value of SSI tx3 =3D 0x261 - bit[10] - HIEN =3D 1, Detects a request in response to the risin= g edge - of the signal - bit[11] - LVL =3D 0, Detects based on the edge - bits[12:14] - AM =3D 2, Bus cycle mode - bit[15] - TM =3D 0, Single transfer mode =20 dma-names: oneOf: --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE98240372 for ; Tue, 10 Dec 2024 17:10:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850653; cv=none; b=jCRiBVRbfdCqS0ChnuqLK2m9JyUROUhuSxcGNZJLAnic4sH+EoA0KXaU2Ksgdw2GyUmZPrUQTNj0Ly1pLzSccFtFyMZcOwQqyTX82u5zmG7P93jz56Uy+HqPUkpOBHxb8mNt9G8CMt6rmUqVjzTFwYv+qOhvIYN1n785Dom16u0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850653; c=relaxed/simple; bh=jlwgcsx3LUvZUCXYVhjc8Lyua4wYz+90XYYggB1WV0E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=V2NfJJEwBuFNpuZm0evvvmvJgD4aLkiMGGhxEbNsJIWEtC/geiHdG3SF69NBjWMrXVdeQ2XxgXv9JQtLkujlpJihLFjdvLYHJcKdJBWiZKS2np7yjglkIf8074IaLOlYLiB/bYZeYpmoo66JUQY8CIb8uSTeIDDqHwn1x0g+Gf0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=cs7DgxPe; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="cs7DgxPe" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5cf6f367f97so8534044a12.0 for ; Tue, 10 Dec 2024 09:10:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850650; x=1734455450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DMj/2kdBQwniGBjdZnm5DjNL0YdrCH1deyApmD3I+y8=; b=cs7DgxPeXIsJnhodf4oK44aB8VicMtAoqzJfIKp+oNm1FDwMl8RTlVOk1bTCpU2kwN NXtrNd3IGDmMhIf6cXonlwsD1LCkpW5WKuLRhfyfqrDyUTBQ2muc4maR56R/r4+If36f 2lHVOOFpXUmDo598BB58RYNWXT/QzJ8/3KKCmYQKhCx6T2myAQwG3VYC13nWzr3lF8PZ Pr4L+mMvQh+6TtdrSVzxe16w3v/IEsInGCQJJa3crQPSC8ky/4Ge6/WFq5E6T6BVxNcj wEt2dkGQ+N+mJlpfEpWLIasB9H3sPfLlweeyw9XQWlbWgfrJmMA2BEEGkEuOuA853D6a /2xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850650; x=1734455450; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DMj/2kdBQwniGBjdZnm5DjNL0YdrCH1deyApmD3I+y8=; b=RM142HmWmwNeF2zTDMIZx7mV1yty6FwFnDqQNlDdtQtfR683hi7i6hRKByBtjbu42z RuajQXO2Un8GAl5SE8xzy0gDMOJ4XLJsu5oI600ZxnoCTVMIkN+4mSQhNFesgCPa1K4B k/LzDkOR+LiqK1UpzUTg3EesNdvoaZKAtZ/NcwzVOvs8ooWPWZkebSsULEhkjOac6J8l xbxYlUl8pa0gSWiKkFpelCb5zJ8CxcCSIZOHLQPuVB/pMlfzUxsh5cSXC/avvmeFDdbT 4pDzDyJEXDFrlWuaAHsshYc1qWpM6QHkq1JpgOtBdpsve8FLkrzqfyoPzvV4AGOcZ/26 wUYg== X-Forwarded-Encrypted: i=1; AJvYcCX0PZfztmjvUFHf/8he2vBZ/zYQ2uvWWk368ucK/4TFhDiIOqirgResR9VfHonxIqB6cMZIW51YXZoffKY=@vger.kernel.org X-Gm-Message-State: AOJu0YwPqGbQDBNGmyX+D/j0sQoeixylQFseci/CO0ThDeBtXQAB/Kvn owcwPEuJXRQZwjOS0Iu5s5iNzO7hfu0R89Ld76G5KRzb9057qD7GGa5M/4fM3mY= X-Gm-Gg: ASbGncsVMOs8Uo4A0Kn1aaOMF4jpP5g3nu2cNNzh9X4Xen0amfDV0QRRwOKRTs/FIeX 5T251ADjDcs22co0Sgp7XEqJ1SEdI0qF1kQUMJOOlQ9JNZUXn9rZfRj6Gt8ZzuuehqZ0FCwO8ok Jyq31Rr0AuDnKCqIXdDBjJX4HiBgJ2667olpIj3N7m8rURclODSG9Lv5vO2soOWJjsE8UgmsEPW MuKAvgYTGksD4rNUq2QbXi8xccWWzfFaOHqSFQCE9G+jz6MtWBCe9MOKOu4PGBVCV+y8u20wUcC GSJ4rUgh X-Google-Smtp-Source: AGHT+IFXUw5ybDLD5qa89ZofGoIXkdy91MQ4lgB9QjSQ6ZzxsKHCx4/ijSbtTty6jRiH6OvTPqEZrg== X-Received: by 2002:a05:6402:2691:b0:5d0:8f1c:8b94 with SMTP id 4fb4d7f45d1cf-5d418534c20mr6265042a12.13.1733850649565; Tue, 10 Dec 2024 09:10:49 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:48 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea , Krzysztof Kozlowski Subject: [PATCH v4 19/24] ASoC: dt-bindings: renesas,rz-ssi: Document the Renesas RZ/G3S SoC Date: Tue, 10 Dec 2024 19:09:48 +0200 Message-Id: <20241210170953.2936724-20-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea The SSI IP variant present on the Renesas RZ/G3S SoC is similar to the one found on the Renesas RZ/G2{UL, L, LC} SoCs. Add documentation for it. Acked-by: Krzysztof Kozlowski Signed-off-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven --- Changes in v4: - none Changes in v3: - none Changes in v2: - collected tags Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml b/= Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml index 5b42eec864f8..e4cdbf2202b9 100644 --- a/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml +++ b/Documentation/devicetree/bindings/sound/renesas,rz-ssi.yaml @@ -19,6 +19,7 @@ properties: - renesas,r9a07g043-ssi # RZ/G2UL and RZ/Five - renesas,r9a07g044-ssi # RZ/G2{L,LC} - renesas,r9a07g054-ssi # RZ/V2L + - renesas,r9a08g045-ssi # RZ/G3S - const: renesas,rz-ssi =20 reg: --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 762A2240379 for ; Tue, 10 Dec 2024 17:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850655; cv=none; b=hvTGAChsQBw9x15R86mUzNzURsQW3SuMM2dnYcNb9YgBHNOVWz2pmQOa1kq7/vHzTjSFEpxxtowmqLq2+ag6QwsQ1kIUg+BoVkjNXp8Ox5aUWvoX/bcHO2hxFINOPuf5I/J5hOz50Wi8Q8nfbfZ0ENCoeypT8c734ewdan2kWR4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850655; c=relaxed/simple; bh=8/PHs3hergaZwLujvAzPGvYQcQ9nR8hOIaSM9/vOn8M=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=YWfo9E8EkLhjxRpXfag5xiuMa139JX3Mw/dij3g6JcF25X3NgriJzdFt/woANR7m9JdL5VdN3oEvum3j1wehGOUGAb1xEAuw/iSxRL97Sgc1njFKmkzbYiJXjLjFkDoHvzQqSWKqNX+J9Gcz4qkYjrXAM3at1s0LtsNHgxYfRw8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=AB4H3d2Q; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="AB4H3d2Q" Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso2977716a12.0 for ; Tue, 10 Dec 2024 09:10:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850652; x=1734455452; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbnqkT50sIwhXb4LpARwC8AegnQU36VT8IZg+EnVYck=; b=AB4H3d2QmUUS7e0l4duXv68N8unNjDfzowPK79rCaei43hqMG8q9H+JmheBZpZR13I cy5iLp3kSzVQkUO7hAJbBId9puM5t7FmqfmFBW0sQJBJMKPb6dkHuclCTxZ+57s/oouE 5Bf/fgWgse2itV+sGrhoasJRF9LkS8c3kphy6c/Kc5IPEvKmoBTFElm/ULy/iXRmf373 eltyS14NbO2FraEGaudz8kYcXt47zoAEfCfRbVcgQf2pXj6kYMjfqPgBdM///rh+47+8 DBwArM7E9dBiARrBhbe8lH1a/q8Vb3zltrS0r6qxvFOYp81GAXzTJVttJ00qG4bI4MZr H0SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850652; x=1734455452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbnqkT50sIwhXb4LpARwC8AegnQU36VT8IZg+EnVYck=; b=TJllEg67HKT12+PMFbw9y756cqIk/E+2nvGYROojMzc/lNqGOctNmKsZd07PjjB1/w DgpDDw2Codg32BYvlenoR8J1VJK5cDlICjDtf1emQv11mwpOD4HaFybgkiNndkbYW6kh bthb+fAhK4LtjX7+gSPoPIz7li0wh0SQ8bualynIXFvU5pm7/dQ9e6UT337QnGrs5gsa WNMwcvPdy/xSNDdenMEkH0lN1fMvPCaE/jVNWIUTxysESe7y0X+2iUIcHkIsQyPatDBl 1WK25/7FWtTdT5Hq3v2oPUe6f08UOVZ59XZsVK6keeP2bnNLsBme5mVa1EVM46Oz/oRK ovWA== X-Forwarded-Encrypted: i=1; AJvYcCVgK0BFYYx4CiFbC01+PnLoyzOHga/R9y0J5ouwXbc1P2MTrp/DfWwXtkMfZshQtIjuZIwAHQmJcA7Tjlw=@vger.kernel.org X-Gm-Message-State: AOJu0YwWT39VAtw00IcXGayvHUkn662C7ygzWRXZvHDHUZ8DhAvHSBC+ 8SX+KFhE2W2aI740hk1BaJZGwiZ4+PLiBZRwsKFUtlXD0hZPw0YplP55k9iwvV0= X-Gm-Gg: ASbGncsUFeP28y5az+5Z8sR4FaDYmplzNmedmhOvj242Mz7d39XKkrkx7Xey09BxaCN CCsdZxvst4bPTAa1i7r0W78xOqzQtCRjoXfHkwNvfApKNlIipodG9PuZEiJyprJXPvjx04RQmZT cJ7Pxn9C95ZvPseG84x497Dr/U1u0SSFnw4uQ1SljbnMN+wgOK7a2//0uFpt6CXNfJntaa/r/V+ uICW0L+m3qM6B0k+aXj6s/swC52Yd0PmJDRfIeUC3EdrGXH6MSddAvu2DsZSB5qUhUTaDTgZlUw subOWkdbZU8= X-Google-Smtp-Source: AGHT+IGhOq0ISs6UITM0F+o/rYn/y64cloP1K9d/mnU2rOj31uCI1nueqLaUR3TcQZ6R+M3PsUDCEA== X-Received: by 2002:a05:6402:4308:b0:5d0:e9a8:4c96 with SMTP id 4fb4d7f45d1cf-5d41e2b4a25mr4157459a12.9.1733850651848; Tue, 10 Dec 2024 09:10:51 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:51 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 20/24] arm64: dts: renesas: r9a08g045: Add SSI nodes Date: Tue, 10 Dec 2024 19:09:49 +0200 Message-Id: <20241210170953.2936724-21-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add DT nodes for the SSI IPs available on the Renesas RZ/G3S SoC. Along with it external audio clocks were added. Board device tree could use it and update the frequencies. Reviewed-by: Biju Das Signed-off-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven --- Changes in v4: - s/audio-clk1/audio1-clk - s/audio-clk2/audio2-clk - dropped status for the audio clock nodes - collected tags Changes in v3: - none Changes in v2: - none arch/arm64/boot/dts/renesas/r9a08g045.dtsi | 94 ++++++++++++++++++++++ 1 file changed, 94 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi b/arch/arm64/boot/d= ts/renesas/r9a08g045.dtsi index be8a0a768c65..0e06a4b96c64 100644 --- a/arch/arm64/boot/dts/renesas/r9a08g045.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a08g045.dtsi @@ -14,6 +14,20 @@ / { #address-cells =3D <2>; #size-cells =3D <2>; =20 + audio_clk1: audio1-clk { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + /* This value must be overridden by boards that provide it. */ + clock-frequency =3D <0>; + }; + + audio_clk2: audio2-clk { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + /* This value must be overridden by boards that provide it. */ + clock-frequency =3D <0>; + }; + cpus { #address-cells =3D <1>; #size-cells =3D <0>; @@ -187,6 +201,86 @@ i2c3: i2c@10090c00 { status =3D "disabled"; }; =20 + ssi0: ssi@100a8000 { + compatible =3D "renesas,r9a08g045-ssi", + "renesas,rz-ssi"; + reg =3D <0 0x100a8000 0 0x400>; + interrupts =3D , + , + ; + interrupt-names =3D "int_req", "dma_rx", "dma_tx"; + clocks =3D <&cpg CPG_MOD R9A08G045_SSI0_PCLK2>, + <&cpg CPG_MOD R9A08G045_SSI0_PCLK_SFR>, + <&audio_clk1>, <&audio_clk2>; + clock-names =3D "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; + resets =3D <&cpg R9A08G045_SSI0_RST_M2_REG>; + dmas =3D <&dmac 0x2665>, <&dmac 0x2666>; + dma-names =3D "tx", "rx"; + power-domains =3D <&cpg>; + #sound-dai-cells =3D <0>; + status =3D "disabled"; + }; + + ssi1: ssi@100a8400 { + compatible =3D "renesas,r9a08g045-ssi", + "renesas,rz-ssi"; + reg =3D <0 0x100a8400 0 0x400>; + interrupts =3D , + , + ; + interrupt-names =3D "int_req", "dma_rx", "dma_tx"; + clocks =3D <&cpg CPG_MOD R9A08G045_SSI1_PCLK2>, + <&cpg CPG_MOD R9A08G045_SSI1_PCLK_SFR>, + <&audio_clk1>, <&audio_clk2>; + clock-names =3D "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; + resets =3D <&cpg R9A08G045_SSI1_RST_M2_REG>; + dmas =3D <&dmac 0x2669>, <&dmac 0x266a>; + dma-names =3D "tx", "rx"; + power-domains =3D <&cpg>; + #sound-dai-cells =3D <0>; + status =3D "disabled"; + }; + + ssi2: ssi@100a8800 { + compatible =3D "renesas,r9a08g045-ssi", + "renesas,rz-ssi"; + reg =3D <0 0x100a8800 0 0x400>; + interrupts =3D , + , + ; + interrupt-names =3D "int_req", "dma_rx", "dma_tx"; + clocks =3D <&cpg CPG_MOD R9A08G045_SSI2_PCLK2>, + <&cpg CPG_MOD R9A08G045_SSI2_PCLK_SFR>, + <&audio_clk1>, <&audio_clk2>; + clock-names =3D "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; + resets =3D <&cpg R9A08G045_SSI2_RST_M2_REG>; + dmas =3D <&dmac 0x266d>, <&dmac 0x266e>; + dma-names =3D "tx", "rx"; + power-domains =3D <&cpg>; + #sound-dai-cells =3D <0>; + status =3D "disabled"; + }; + + ssi3: ssi@100a8c00 { + compatible =3D "renesas,r9a08g045-ssi", + "renesas,rz-ssi"; + reg =3D <0 0x100a8c00 0 0x400>; + interrupts =3D , + , + ; + interrupt-names =3D "int_req", "dma_rx", "dma_tx"; + clocks =3D <&cpg CPG_MOD R9A08G045_SSI3_PCLK2>, + <&cpg CPG_MOD R9A08G045_SSI3_PCLK_SFR>, + <&audio_clk1>, <&audio_clk2>; + clock-names =3D "ssi", "ssi_sfr", "audio_clk1", "audio_clk2"; + resets =3D <&cpg R9A08G045_SSI3_RST_M2_REG>; + dmas =3D <&dmac 0x2671>, <&dmac 0x2672>; + dma-names =3D "tx", "rx"; + power-domains =3D <&cpg>; + #sound-dai-cells =3D <0>; + status =3D "disabled"; + }; + cpg: clock-controller@11010000 { compatible =3D "renesas,r9a08g045-cpg"; reg =3D <0 0x11010000 0 0x10000>; --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71EF8241F49 for ; Tue, 10 Dec 2024 17:10:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850658; cv=none; b=niQRkE3pA56/UnEzgEgJejI2RIbQtr6ZHaWzm4u9EhMDZFChuIkXoNoRO9rSasVKF+jhUIuskavT4YaMtZ5hgdDQ/liiluFRmMOCCUacbZBtcDJu+3/1x/I4sW+PajsZB+Giu9arb8eVNTop2r23ghsVzcf+3e/PFqxT1ybQejE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850658; c=relaxed/simple; bh=d78/cjRoA1rGuCezGVFS8ZJSQg5DxH7DXWKg06PRmuY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=UBLI+K7kTe/YaQ1kt1pxNJOtUg0JioOOLPmbsRrhER4KlPtWQ3VTlKeJULgxYHf8hJzDzw3Q+EAXRMGeo+aGh8YvO27iSZtbJ4o5r4CxTYbx0G/Jo9OcAbb6E86xq52oSHUX8Hb+jJl2tyXn74A4blFva3Adf3zKdoSHjVrFb9o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=jx6caag1; arc=none smtp.client-ip=209.85.208.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="jx6caag1" Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso6043485a12.1 for ; Tue, 10 Dec 2024 09:10:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850655; x=1734455455; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XG8zYqRJnsZkhZfRr2g1CnvN6FDBTlyfj/tmdbveBiw=; b=jx6caag1FYIcxb+as7XhlwVVacZd/ekU9KnjO00lsodxHeXPYAK+G4uBi7/HDdlwBb x+nB9qINuLm029N9r5tjrwgkQdSMhJWEjW2KElU2DMSqV9YZbYzVT/PiiseM909qmiRX OSXQKQAH2vhof7kbqRRvQru+KyBuW6nJCDTvGF/8sGexnxZY/u+qU2Gs6wmYS7ZLOiw5 Wgqistxd93er9z4AOGdsYExS0pcX6p1cZWkowHg1dLesFdZtEjXP6Jezg1N+l2dOoh33 BtedPGoyeGg2dTlxYlR7EwaScHpQ+DePhTZLUnsMQPaQFGZ45SUSZvQsroeSNvyfMVLh 2XMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850655; x=1734455455; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XG8zYqRJnsZkhZfRr2g1CnvN6FDBTlyfj/tmdbveBiw=; b=Cs1Jiv9WKliFVw2nu8IVtYUUDqirXF3sCEAzm+m1nK+Vmbz+097xSu0g0YnqCR+Nww eVVQ/RIz8N8dHKDC5gsQViFqaY6Bvmt/0NYFLQzBA4ziWRN/If8Ij0fVdccNxpX011Ha tHDvjFNR99Amk6NcMDQVFiXMx71lTKLG1BFbGToG1K6MBxJK0hnmHEATXkjRMHqbkJnU YeEgamKSby4kehZntbH/dD3+YYsmP8gKNuzI5qendTH2FJwQ4J3sviPJntOsj4Ao1Npr Qq2gFejKoN2x35S7cYn9mtaX9z3KvHkdtDjZunEvkBO4/OS9i+s/vGF7J+BUV6p8s+Mi 6axg== X-Forwarded-Encrypted: i=1; AJvYcCXBkGJKN/m9oOHZFa5wIxPf6V0MihBaGINVqVuf9xrogVMl+G8ni00YtasqIAllzvRnsGUQ6A8LR3izU1I=@vger.kernel.org X-Gm-Message-State: AOJu0YyBjN6DHpjiG2stbHtX6K0md3c+h7JwHA8g2g6QxkAZaCrtT9K9 jCOVwhFXF8MeOzcZOOP+3jai8OhzJMRmOKP1pXSk8OWrwemamB1iCmZ+vAhIo7o= X-Gm-Gg: ASbGncu78m5pEDmvAO/fmhLLkE4IuCt3Bu5mnzVGzxHhQDSkvCWvCcNXnWcBSJv/izn 7aRdZM8mj2hOhh9Fl3JFtlHhcCAqX2GStp4Caox+XCasvJXAqiAnOnIDEf9vdUN+rXm5SN9JFYy 1ksNU0tZTrWCqN3/QotJiZEgkuP+dGRhAQucElgIAGPJ1yQBczMmDaAuBGf/xE4q0o/c9J8dShS LKcxm5wMazfGmvslsRmv2tMB8PklhQ1koXL6WT7WfQTXnmJIDos8JaBMh7WxiR9d2XnXf6gIZl5 13XUSltC X-Google-Smtp-Source: AGHT+IEgKnHNaC3IX1FEtNtvTz24/8StgSao5VAD6Ub2m7Bx+D6TJNFGkozP9JnrbZSvN4zlM3/+Ng== X-Received: by 2002:a05:6402:510a:b0:5d0:d208:4cad with SMTP id 4fb4d7f45d1cf-5d41e16362amr4621139a12.2.1733850654831; Tue, 10 Dec 2024 09:10:54 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:53 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 21/24] arm64: dts: renesas: rzg3s-smarc-som: Add versa3 clock generator node Date: Tue, 10 Dec 2024 19:09:50 +0200 Message-Id: <20241210170953.2936724-22-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add versa3 clock generator node. It provides the clocks for the Ethernet PHY, PCIe, audio devices. Reviewed-by: Geert Uytterhoeven Reviewed-by: Biju Das Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - none Changes in v2: - none .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 30 +++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi b/arch/arm64/= boot/dts/renesas/rzg3s-smarc-som.dtsi index 2ed01d391554..6e58d47d85b0 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi @@ -92,6 +92,12 @@ vcc_sdhi2: regulator2 { gpios =3D <&pinctrl RZG2L_GPIO(8, 1) GPIO_ACTIVE_HIGH>; enable-active-high; }; + + x3_clk: x3-clock { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <24000000>; + }; }; =20 #if SW_CONFIG3 =3D=3D SW_ON @@ -152,6 +158,30 @@ &extal_clk { =20 &i2c1 { status =3D "okay"; + + versa3: clock-generator@68 { + compatible =3D "renesas,5l35023"; + reg =3D <0x68>; + clocks =3D <&x3_clk>; + #clock-cells =3D <1>; + assigned-clocks =3D <&versa3 0>, + <&versa3 1>, + <&versa3 2>, + <&versa3 3>, + <&versa3 4>, + <&versa3 5>; + assigned-clock-rates =3D <24000000>, + <12288000>, + <11289600>, + <25000000>, + <100000000>, + <100000000>; + renesas,settings =3D [ + 80 00 11 19 4c 42 dc 2f 06 7d 20 1a 5f 1e f2 27 + 00 40 00 00 00 00 00 00 06 0c 19 02 3f f0 90 86 + a0 80 30 30 9c + ]; + }; }; =20 #if SW_CONFIG2 =3D=3D SW_ON --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAD87242A81 for ; Tue, 10 Dec 2024 17:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850660; cv=none; b=Ibm8Sj5ozzOkcgt3NhVczAwwuGuGhwbnOB4kki0Zzk+6h/qTMvTuXBh7Cle+gC6ZoEQG+gCNyxqUxp2ZT/z0HqQDqQ0HEoIzbVm8ATFi7LTLeO949JKhMF2BNfe8exOhh/Maxdzdt3cKKhrvPWN2T3APD88UO/dxe9r7eZyvmZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850660; c=relaxed/simple; bh=CcnOmZ4wJdtquX3MvcxFwHJDSz8ukso3gSLgf6pWQno=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LDshBBN8zLXjXtLeQ51efNgg31V9dXERr8KMqSMF2zthB21YJdE8N7APjmNtxv4Dy6/QpTNW56sv7TAdd7UBRjay4+gYlM8dLwh56HzNiIlePDgj6emWvVkMG/CGVnpyHHOPhkCahcnEcIdTtO4vPQZuIij/EIAWKBFkWv/y5SY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=LZNfVXPt; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="LZNfVXPt" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d3ecae02beso3811748a12.0 for ; Tue, 10 Dec 2024 09:10:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850657; x=1734455457; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qbHdnNXTXnTR3tThfeMauJ9l0Itp93/txTopWT8Ines=; b=LZNfVXPtYDVS18Yte82iCw12NcdAvZnLHfH3EW0tVUQORbtzxAdRtpnj10pIqOl9PE jEM+YR7r98GwCsRLVjrqYGp+AMLP/Pb3LcgNG9TvRFS/VjnWLEU07nbYGiHoPbW86tw4 XBdk0blKN11toswsFbluz7EVLXbNbJZ6Glb9b1iQ6bKtIr8EhZj0Cl8jlG3gjBrK5oEB LhVJ/Sue+fkM/6mpWiNVmdF9aPodprZmZTaDZoMzqYeZ+xxvXnplF+FuA7GpUhwqXrf0 XkDmk80PKQkWf9Uc5VrSpDU8l79JRUh1FaGhIt1Q/HFL8EVqSQ+wriTSX0c8caErCh0G xhjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850657; x=1734455457; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qbHdnNXTXnTR3tThfeMauJ9l0Itp93/txTopWT8Ines=; b=cqt5xtC+liYcYUa+ggxE3NmyYORlXjzmH97tPR53gCRD//26cN9M8q0MvaBmduiMTf vUW2HpOiVUADYWChEALw9pqqtoD6WZTFlGPXDMedeA0PmhGQ2FKFUCdK2rjavtY+iWlr mJ17at1j8Cj2PDpjIEv/GdBTtE8wVZSKO/NKnfzjg+MqosrQLIGNokfOyiNlekdlUtDy wPSiSasELnG09WXpsyT0XpnEI31WOwvR0+4VC6VtrSfxEYPcbvb9KX/ZzwVwtkbqbJvF t2Eu1k9scS0DZHu089hadho9+EUA+/J2kG+0t13cj4gw3zzG93XLfwM5jxs90E76Az1X UH9Q== X-Forwarded-Encrypted: i=1; AJvYcCU3zKteZyXb0muN2aWJzBeWuD+p1kySkgkO/YczRF9vQmpcsok9t9r7aYo//xTRa+0eOTcRRRE05P3rtf4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr6pB0GI89Bxq/Ff1HwTCcDjRXdYljUavAzQwbEWgDIoKBqjtY dWGe+ge7+6ojheqGNf6SoYYfyc7P2LHQMnF/mxFRSRJ81RGylH0+IXiE5yoOej0= X-Gm-Gg: ASbGncseOm02H/vKNS3VVj3iD/uiNB3+rMOirYI2ZYlZ0gcvTh1Yb11uN4PCdiXenNu KarI4vEgZ1Zkgn7lC92qCyRTRUyYahlE1DF+vKU3CTXr88VAFbvkvnLuwqV88IFZLqiJ1uvwPKo sh5puO1aTWs32Pav2dZtAX4BmdWy59NOuoEvdyTwf336isRaQUrXWA1HunKvXFE1mRIQ7AiZQrk m3TWeVmSlU96aFb+c91ZqQaCEvoFW14rJCMFDhfL9x5PPOjML4GkbrT1bzT8Gvp9SpX7DjwOfMI wAN5UKjR540= X-Google-Smtp-Source: AGHT+IFoRF8BSZrpYteUQ6a7MVI24wh97GfyVKWhabGoatai7X1+0ZapR3mbMn4ogZwncEoqa1pzEQ== X-Received: by 2002:a05:6402:3705:b0:5d0:d183:cc05 with SMTP id 4fb4d7f45d1cf-5d3be66d0b6mr16199052a12.5.1733850657163; Tue, 10 Dec 2024 09:10:57 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:56 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 22/24] arm64: dts: renesas: Add da7212 audio codec node Date: Tue, 10 Dec 2024 19:09:51 +0200 Message-Id: <20241210170953.2936724-23-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add the da7212 audio codec node. Along with it regulators nodes were reworked to be able to re-use them on da7212. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags - dropped #address-cells, #size-cells - moved #sound-dai-cells after clock names to align with the documentation example Changes in v3: - none Changes in v2: - none .../boot/dts/renesas/rzg3s-smarc-som.dtsi | 17 ++++++++++----- arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 21 +++++++++++++++++++ 2 files changed, 33 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi b/arch/arm64/= boot/dts/renesas/rzg3s-smarc-som.dtsi index 6e58d47d85b0..5ee9dac4aebb 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc-som.dtsi @@ -63,7 +63,6 @@ vcc_sdhi0: regulator0 { enable-active-high; }; =20 -#if SW_CONFIG2 =3D=3D SW_ON vccq_sdhi0: regulator1 { compatible =3D "regulator-gpio"; regulator-name =3D "SDHI0 VccQ"; @@ -73,8 +72,8 @@ vccq_sdhi0: regulator1 { gpios-states =3D <1>; states =3D <3300000 1>, <1800000 0>; }; -#else - reg_1p8v: regulator1 { + + reg_1p8v: regulator2 { compatible =3D "regulator-fixed"; regulator-name =3D "fixed-1.8V"; regulator-min-microvolt =3D <1800000>; @@ -82,9 +81,17 @@ reg_1p8v: regulator1 { regulator-boot-on; regulator-always-on; }; -#endif =20 - vcc_sdhi2: regulator2 { + reg_3p3v: regulator3 { + compatible =3D "regulator-fixed"; + regulator-name =3D "fixed-3.3V"; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + regulator-boot-on; + regulator-always-on; + }; + + vcc_sdhi2: regulator4 { compatible =3D "regulator-fixed"; regulator-name =3D "SDHI2 Vcc"; regulator-min-microvolt =3D <3300000>; diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot= /dts/renesas/rzg3s-smarc.dtsi index ee19c4155750..899d88467d79 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi @@ -68,6 +68,27 @@ &i2c0 { status =3D "okay"; =20 clock-frequency =3D <1000000>; + + da7212: codec@1a { + compatible =3D "dlg,da7212"; + reg =3D <0x1a>; + + clocks =3D <&versa3 1>; + clock-names =3D "mclk"; + + #sound-dai-cells =3D <0>; + + dlg,micbias1-lvl =3D <2500>; + dlg,micbias2-lvl =3D <2500>; + dlg,dmic-data-sel =3D "lrise_rfall"; + dlg,dmic-samplephase =3D "between_clkedge"; + dlg,dmic-clkrate =3D <3000000>; + + VDDA-supply =3D <®_1p8v>; + VDDSP-supply =3D <®_3p3v>; + VDDMIC-supply =3D <®_3p3v>; + VDDIO-supply =3D <®_1p8v>; + }; }; =20 &i2c1 { --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B26C242AB4 for ; Tue, 10 Dec 2024 17:11:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850663; cv=none; b=h4WyYSKskHCBv9B7zXeHhNXwXfag466bsHvPCMUSo6zP314SoMaN5blIggEawm9NmYzp7igeQbwRnX0pxh7Nv8d0BPjcc3Tl1z5T0C7uJTObueB6mHTnqv2By35ruheHIFCB1G2e9+eYX0Lq3nTvdTQ9oqYD7lgI/WSeO+7txTk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850663; c=relaxed/simple; bh=j3EZQQ+bJ4Pgh8+9W/k4Ypg3jmTVeLSoZtZxACS5Ilw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=rUn0E+AA+tYn03IyUE846EL3Qfs3mTJ5+jXmb9buTvSkW4ZgYwJ0G3ht1r17ZXfHekUvCOz5dFkHhorFcbubWzThGElHWR+iyYMwfawDz5DPQHqdX/T3vZMzNK7DTp1P4nRlaM94JGkoxmHkCopOBUdenCuozawEze3ZNHZJZNk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=ZUd6KoHx; arc=none smtp.client-ip=209.85.208.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="ZUd6KoHx" Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-5cec9609303so6814534a12.1 for ; Tue, 10 Dec 2024 09:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850660; x=1734455460; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jE6wTwaLZbTxO8+1zmhGoRQFuhziI2yndu2tr5ybLTY=; b=ZUd6KoHxKUkZMl4YclFXBsHflSt9GCw+rx+Gpsrq6TTs5QX4jgkXrgGTYXCN6PALaK q80rRXMJsxj3Qt3fCxRv/oKsmrtOAPPw1UMJJdne8jQrCcp6JlvB03urTzkY7rakPhnQ T69cej1tAaWAijNxNwOvbIA0BOPlAGX+NIIrCMvuwKujcTl98Vn+3TMwjdD/eAblZCP+ zYFIXt+2umxLxxLRDuGg7Wty0d2hf3UZVOOf9m352Ufe8fS6bH0mLohsiO82326s5i0c 2dmH6ZtwOpFUkyur5lGfjGKOPLHhlaKR+T8hMPbsMkwntU2NjqTBrG1jqjjFu386saVU GUJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850660; x=1734455460; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jE6wTwaLZbTxO8+1zmhGoRQFuhziI2yndu2tr5ybLTY=; b=Ks3qYoTrQCzrj6RFlWoATFgDWSOyNVegvk3xaKArcElfRX5q3UBXmkDI9MP9O6JmMo V/N2Bc+FBYKj3w2OVDf2rKnNTeXu5Iv4ngnHYEANaFB4q7M2jIYkE9QdxtM9fpg6vLyS TQz5jGHSFeabB911bagqE1ILAVVXlvbFPs1zqy7zfWtBgBYnERNNABDRFgBN8WlH4DZK iHfhddKGQiF/7DrIhqcIb66Ou1SR2bNRL+HZvRq/1WnkeiMjQ+3nYguT3/77TTiVlfXB l6pOVZ6IfuQbL9qPNFfn1ZBAeKwG4NkpLOmhwauwcRMLgSuiJyCnwHmOCDkVHhc8NnWF 6bog== X-Forwarded-Encrypted: i=1; AJvYcCVZq3YS2h9ojao42NCKJMXdmtZQQGN8ryIyxNlWgh0fF9UCEJBdXmzscaerrt1jV0Au6PgeVPZ2j3A6wDE=@vger.kernel.org X-Gm-Message-State: AOJu0YyH0AlLqMxBgiHPJKz6w/FfmGBgZzlIkLa3pV4m09F7chivYPNs /jtHav0OUhxmV01dzwvpIm+B5ZaRSixB75+Y822AgIrSCtnjpIjAo3HdGhUy4U0= X-Gm-Gg: ASbGncteg37ZDxLmDEtSJNh9kbY3rpq2PzKznBA3mXi9CaG3UAKmK2rNqALt6CKFLpH EOV25YqhAI2XvFYCe/Zy39jcWOrJOatLu9gZggznvtE9sQwvpr54CZM/7jbZ+tZDvgWjt3SMpOY ACx2iRMRFZsnz8265ppXAxJZsoxiCEsGXMfz5dY/oa76WpfR7IYW+K/nFucPgX4feTtsQJTTDBB cTPMZOczQYoLaJx+JtVXAhtEVzGcAZguTVOQfuVNCCFOWoSn8gjF3eFKaTLS68smOCXCwUoi2Jf R5TKfKUJ X-Google-Smtp-Source: AGHT+IFlYyo736yb9cxpJS2cGnLCOO0TpZQwWI6UbvDphomE+gSa6jZr1VtWzN9wAD+vqnofdD3cjQ== X-Received: by 2002:a05:6402:2791:b0:5d0:b925:a8a with SMTP id 4fb4d7f45d1cf-5d3be6c1598mr19946134a12.16.1733850659570; Tue, 10 Dec 2024 09:10:59 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:10:59 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 23/24] arm64: dts: renesas: rzg3s-smarc: Enable SSI3 Date: Tue, 10 Dec 2024 19:09:52 +0200 Message-Id: <20241210170953.2936724-24-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Enable SSI3. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags - dropped status for audio_clk2 Changes in v3: - none Changes in v2: - none arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 25 ++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot= /dts/renesas/rzg3s-smarc.dtsi index 899d88467d79..1944468a2961 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi @@ -64,6 +64,10 @@ vccq_sdhi1: regulator-vccq-sdhi1 { }; }; =20 +&audio_clk2 { + clock-frequency =3D <12288000>; +}; + &i2c0 { status =3D "okay"; =20 @@ -105,6 +109,11 @@ power-monitor@44 { }; =20 &pinctrl { + audio_clock_pins: audio-clock { + pins =3D "AUDIO_CLK1", "AUDIO_CLK2"; + input-enable; + }; + key-1-gpio-hog { gpio-hog; gpios =3D ; @@ -162,6 +171,13 @@ cd { pinmux =3D ; /* SD1_CD */ }; }; + + ssi3_pins: ssi3 { + pinmux =3D , /* BCK */ + , /* RCK */ + , /* TXD */ + ; /* RXD */ + }; }; =20 &scif0 { @@ -182,3 +198,12 @@ &sdhi1 { max-frequency =3D <125000000>; status =3D "okay"; }; + +&ssi3 { + clocks =3D <&cpg CPG_MOD R9A08G045_SSI3_PCLK2>, + <&cpg CPG_MOD R9A08G045_SSI3_PCLK_SFR>, + <&versa3 2>, <&audio_clk2>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&ssi3_pins>, <&audio_clock_pins>; + status =3D "okay"; +}; --=20 2.39.2 From nobody Wed Dec 17 09:00:09 2025 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5ECF6243542 for ; Tue, 10 Dec 2024 17:11:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850666; cv=none; b=IlCbswfPjSRfU4SDeo5cMVm0cOOKMjQcUJ9p6ow3XvY0xBilMBhZQQPlLX1KPEE6FaDtLDF0FERr/URfrm+Ou6FMm+/dGkqttdrb4UzXYKhvL4I2sOte+u7QrXiGXstNfzCsrzhI9GaYDsAPitz2G9uyzV3NIxX9ineNH7uahuo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733850666; c=relaxed/simple; bh=hJDCv1TyaQlo/L0tvA82G+IiLtzZURDjCsIXt6YWZzI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=GkBqIror7TfsDl0vVDO0Z4mL6DqbVhyPeUwXwaCp8wek0+Mx0WUrPsvH1YSmk9hd/H2/kQXog2Bq3xt6lIqW9wPyAs/aXiDalfI1inEyOE0R0rb1tUKcGlRhrhb+xtXAQajOeLKqOwWBkioR+J+AW/TgVXun/QLE6RzcoVpOpk4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=H4Oo73oc; arc=none smtp.client-ip=209.85.208.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="H4Oo73oc" Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5d3e9a88793so4788003a12.1 for ; Tue, 10 Dec 2024 09:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733850663; x=1734455463; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TwyXnruxyE1MIUM59wwP+urrQ2EdZ5O+ybJnem/vHTM=; b=H4Oo73ocUU6EO5L86bsbLakxd18SGRoMb/J2jzJtaIAmNhotmttFlW/TmdIeordbJZ Dq+bShklzmdfREDBwuxJjDLed5ej3M+XFdsU4eDmnuGhRUVNt+PJ40Ionl0av+NKnuam 20kW6ycQNBXnYADF2aarxkcua1Z23wHlFv4RkB10Mzt9g4G4T1wVBNpetas+bTy1Y/ra QxlTvkMagWUEayvqovJIrXb6kvLmnSdz5LF+mTMRyfpXgNdPR5z4JALaPwtMfAI4Jqk2 ssmNkWomPf8q8YXmUV3JnL5oqVsbP/qx81usGKG8bDL3iWU+IqMU+2BeYTV4XYrxA9yj pM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733850663; x=1734455463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TwyXnruxyE1MIUM59wwP+urrQ2EdZ5O+ybJnem/vHTM=; b=X3sBgf4C2V9tV1TvFxDHpHQSLHyUu2nUe6EZuFBFUbZ5FmcQxswpt+V5kudOGCUUp0 2zwOyHsMwtPmoxJ5vogyPszFBwl3NragaYC3JOr1e8yRAVdVngey19C+EXAtSPQ7oKeK NNnP41+dgLtGkXU0hKODz/YaWGi05ivEldIehP+AX9qR7exJlBF5N8fa5Itjrlc//7el YYe8Zr9mmoJaD5dNceGxDJOx+L1ThdDYiK0WsiHEHz4Ik06BC5RtVsZ4iLv9UfxdG2lv h2r5aS8VaWzE20i5LJ+U1TzisbuPzgHWzu7Evrs9SaiB1+OiOeicvi7xeEmFo3YkG04H kguQ== X-Forwarded-Encrypted: i=1; AJvYcCUWAerC+POOHcE6m874rj+AMRAR4G6+uWe3InLTy/+WfGSERpvPDwvdKOuyGNRYMw7OG1J3LO1t6Kpia4s=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0euA9FpXTzY1EhTpOLzbp+xab/DsXLnb6nyXmdgmzZmVpn/k4 dKHKCX/zyfpyzZdURibn0HjD5yY82ho96QTFCFP19w/QW31nWaKOSl+ri2niDp0= X-Gm-Gg: ASbGncsuZzDOPmxsvvFNr+n35WoE8oT/8lh6KHIL1OKKAhpfKgOBIYNwgPuxZpHbYmA MOV9A4NVXskpCV+UCv3PU5acdJq0S0+KZxfnnOlWUyPVRTon4kL5Bs3wC+pPYMJ5BeJi6CHBjDF Ze8cd8YODIIMJUfw4xXyhn9JEcJoV0Y/HkwhPpAYawLnrASDTpVal5HUWKaCGZ30vKm1TlxWiBV +QKnCnD9E1GgVqIV6UpSoFgAmxoU4T2roMVsn5YcO2fXnYly/cHMQV/1/pWELOL72mVE5B+/Sny Mk/WAXfR X-Google-Smtp-Source: AGHT+IGQNruuJ2fmbhGEBR6v4EYtbwtUlKzpp82KdDiJC4wYZhl0SU6OosybB2Txg3S5RjOBSBjG+g== X-Received: by 2002:a05:6402:3490:b0:5d0:d5af:d417 with SMTP id 4fb4d7f45d1cf-5d418502c64mr5890914a12.1.1733850662767; Tue, 10 Dec 2024 09:11:02 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3e7936581sm4853124a12.56.2024.12.10.09.10.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 09:11:01 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, lgirdwood@gmail.com, broonie@kernel.org, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, p.zabel@pengutronix.de, biju.das.jz@bp.renesas.com Cc: claudiu.beznea@tuxon.dev, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Claudiu Beznea Subject: [PATCH v4 24/24] arm64: dts: renesas: rzg3s-smarc: Add sound card Date: Tue, 10 Dec 2024 19:09:53 +0200 Message-Id: <20241210170953.2936724-25-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> References: <20241210170953.2936724-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Add sound card with SSI3 as CPU DAI and DA7212 as codec DAI. Reviewed-by: Geert Uytterhoeven Signed-off-by: Claudiu Beznea --- Changes in v4: - collected tags Changes in v3: - none Changes in v2: - none arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi b/arch/arm64/boot= /dts/renesas/rzg3s-smarc.dtsi index 1944468a2961..5329f3461990 100644 --- a/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg3s-smarc.dtsi @@ -44,6 +44,23 @@ key-3 { }; }; =20 + snd_rzg3s: sound { + compatible =3D "simple-audio-card"; + simple-audio-card,format =3D "i2s"; + simple-audio-card,bitclock-master =3D <&cpu_dai>; + simple-audio-card,frame-master =3D <&cpu_dai>; + simple-audio-card,mclk-fs =3D <256>; + + cpu_dai: simple-audio-card,cpu { + sound-dai =3D <&ssi3>; + }; + + codec_dai: simple-audio-card,codec { + sound-dai =3D <&da7212>; + clocks =3D <&versa3 1>; + }; + }; + vcc_sdhi1: regulator-vcc-sdhi1 { compatible =3D "regulator-fixed"; regulator-name =3D "SDHI1 Vcc"; --=20 2.39.2