From nobody Wed Dec 17 12:45:57 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D19EA5674D for ; Tue, 10 Dec 2024 13:46:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838417; cv=none; b=uIbq/d93JqF9PKIDNeeJfmptRnk4N+V8xPecg8wKqKDncEkZJzZkNSZo3roLBtAY3Tf2C/so9tPBpbBG6gOQ6AMPQaLco3zlXGThSxDyiE8WxcKxkHgfMHQYfsTnPdqRYNOUz2oWyVPPO/PlqiTQotrW41lNe656ZUiMXWkNYhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838417; c=relaxed/simple; bh=wyzV1BQL4C01kVePczNFq0iJWvjrnyRm9K3W89hBsSA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ao/Wck4PkRE4Zeuw2y763GCgx0omr9uNVsmcciH2s1YBXQtFmIrXaUY61SLNyqq9Ha2svZesKvKyFCfBUvXE0q7T4hObYhNBThzJHDVYGBrVVeB3E0HbPSXoEP3cUjlhGP2tD2bdavngOvoJJQT+vUGdmdb1tOU5ta6SWwp5OV4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=VTij4G94; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="VTij4G94" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BAA1ErD020594; Tue, 10 Dec 2024 14:46:35 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= B88LI0a9Jttf2T4vTgk1R/W8xNzBmhzuueRUVJ5fXx8=; b=VTij4G94oiwG6nVs kAOhyaddTScvF0XJY6Owefa8LEB0JtyABva6XNVZlRrDA7mFQjbFr/5xhO8Q1Wgv MABJhtVAV1GsZPCrORnP17UsBLwTW6/A4qye+a586WqtsI62ydPo47XKvOU99tws qMkIh4o86OReclYJKD8KUig49P4B3tNDHegejsf8kp+YB0u8MXC3rcig9dN+YKWz sxT9QgBwEgRtV193dK+0ZV1C4/DTDdUYbAqHS4X4VBpc07oPP9K4SdQjH6WjrViS dty40BRrRlGJ3zfNbFFzOhhY32XfbgY52mI0D43M/A9XECl7jBEiHVxsMh/m34zG WrMiRQ== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43d0t5aq79-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:46:35 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3FAB040049; Tue, 10 Dec 2024 14:45:07 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 62071258555; Tue, 10 Dec 2024 14:44:08 +0100 (CET) Received: from localhost (10.252.12.81) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Dec 2024 14:44:08 +0100 From: Olivier Moysan To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Olivier Moysan , , Subject: [PATCH 1/3] drm: bridge: adv7511: fill i2s stream capabilities Date: Tue, 10 Dec 2024 14:42:52 +0100 Message-ID: <20241210134254.2967524-2-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241210134254.2967524-1-olivier.moysan@foss.st.com> References: <20241210134254.2967524-1-olivier.moysan@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Content-Type: text/plain; charset="utf-8" Set no_i2s_capture flag in hdmi_codec_pdata structure to report that the ADV7511 HDMI bridge does not support i2s audio capture. Signed-off-by: Olivier Moysan --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/d= rm/bridge/adv7511/adv7511_audio.c index 61f4a38e7d2b..28ae81ca3651 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -234,6 +234,7 @@ static const struct hdmi_codec_pdata codec_data =3D { .ops =3D &adv7511_codec_ops, .max_i2s_channels =3D 2, .i2s =3D 1, + .no_i2s_capture =3D 1, .spdif =3D 1, }; =20 --=20 2.25.1 From nobody Wed Dec 17 12:45:57 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 608A826AF6 for ; Tue, 10 Dec 2024 13:46:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838417; cv=none; b=CvB72qtg7tX7opvkGtAjsEDpQldhd6MaWapbzeM1A2f5IeGPPPRW2m6rAKa527a1pdPdaMobcpQyPiRuXyu38ZqI6hp14uMfUQ+xaCyCniKAmROHh43gg1ydQjLIHeocWJ0/OcPigSY7ItJVdP2X7vvzzQL2sWep8Tpv7DeGiAE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838417; c=relaxed/simple; bh=P+FJMUW6dhvTydtfcR0bDyrwofhtTXu6HDBL5CWwY94=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=J2bHdjMir0luONbEiIuf/c0Yr8YV/xFWK/AjEuevpTz5kEtzTLacTPtNsxyw8pq+StzIClqZmmsfpyKwTkGPoy1LIgJ+zyT2jZIdJcAgD3KzjZDo65tiPtQ7jupXd02LUnL1iTn4eeGAl9QJapiOTy9X4TBj9RDrbHUcn14a9pc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=q6bh+dZK; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="q6bh+dZK" Received: from pps.filterd (m0369458.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BAAbOaF025829; Tue, 10 Dec 2024 14:46:38 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= oAn87QHJepSxFgirg8GRxK9W/hXFqtjZBsb7YLbCrvk=; b=q6bh+dZKfuIAAHvX if+YpWF2HMiPOZcERvVA4rG8dV6NP0qd4fqzIVRi0lTt3BM4Br8F2d0Y3GkNjyP2 FcHRd9XrOHOSZx5bmmODTlNsahtGsmmgwHOYajL3tPKZbZL9GH6A9FF+13/EOrK9 t8lJ32/8Tro7jqrxo0hSkjtJ66Ap/cNcMgIGkdS+CpHaSx20mQsoblHwB8ybaByl Hy+sVpZOSKg8Fjlxnv37wbbL++Qy+74Wlo3wGXkPhoTLB6ksTApUHAVwt1g5djHH gq3TIsFV0dcq/zDNgylSUQ7msaE06uhnphMb+kkRYFL0sl97EIZ65wjH4vWWP5Cr KZ1Daw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43d0t5aq7d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:46:38 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 3FBA74004A; Tue, 10 Dec 2024 14:45:07 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 6FC9C24A15B; Tue, 10 Dec 2024 14:44:09 +0100 (CET) Received: from localhost (10.252.12.81) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Dec 2024 14:44:09 +0100 From: Olivier Moysan To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter CC: Olivier Moysan , , Subject: [PATCH 2/3] drm: bridge: adv7511: remove s32 format from i2s capabilities Date: Tue, 10 Dec 2024 14:42:53 +0100 Message-ID: <20241210134254.2967524-3-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241210134254.2967524-1-olivier.moysan@foss.st.com> References: <20241210134254.2967524-1-olivier.moysan@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Content-Type: text/plain; charset="utf-8" The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format). However the HDMI codec exposes S32_LE format as supported. Adapt ADV7511 HDMI I2S format list to expose formats actually supported. Signed-off-by: Olivier Moysan --- drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/d= rm/bridge/adv7511/adv7511_audio.c index 28ae81ca3651..ce6eda87bfe0 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c @@ -232,6 +232,9 @@ static const struct hdmi_codec_ops adv7511_codec_ops = =3D { =20 static const struct hdmi_codec_pdata codec_data =3D { .ops =3D &adv7511_codec_ops, + .i2s_formats =3D (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | + SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE | + SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE), .max_i2s_channels =3D 2, .i2s =3D 1, .no_i2s_capture =3D 1, --=20 2.25.1 From nobody Wed Dec 17 12:45:57 2025 Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com [185.132.182.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91B7F5474C; Tue, 10 Dec 2024 13:46:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.132.182.106 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838400; cv=none; b=n4bB2kkl+mD6I23oPLo/Rt3FAt01CwyAfnw7vHzVWsa+uQB9YYWpmM/Wam9fSP6tXRlKzliBeEDJXcdq4jZqTgzcqZP+FTQ04kDwwRyqSVIesgMprEFTb7XUdds/+NzdDMGkMRPKHcJ1C0bdDUdn4FdjcPKjXV/W+oDUVxHr2pM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733838400; c=relaxed/simple; bh=K8BKEsPwZfVtQ1cYfoZqbIL5ZMAioRFKM4YuvfrG6Oc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QdXxfdyFMs1aKN7PKBoNqsnfAJp51n1Z0qwOBOwa8E8+mTuDGgQ2jXZ2KvwhWvy4ql8DzQKGKwq6RvAs5n2OiVUnBnhwdAWBzASJloULHpXTh5O+hAZRJGkIYEvLpA2xiPPJXOPzI/8tyxsVOIE96zcx4wmxzexTtnhC9wQUSOo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=dTmqX/2y; arc=none smtp.client-ip=185.132.182.106 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="dTmqX/2y" Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BA9RBJK019832; Tue, 10 Dec 2024 14:46:27 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= 1xH1hRPovKqSjZCOM05XbpqMkFeQvHRRRSV7ye98WJk=; b=dTmqX/2yxaM92omG amKHH4saqd8K5qM4vp/lGUry64V4q/DRMPl+mNuHYTE8MD7kHlpEOVM1caVEuX9Z bCDKVZL/VUGkeTKhxOK3UZtsdiJda16fu4xu3EIBY15nU4oVGvv8U8Rq73WosxOo rxNXI05hylGaahES/Tdo7IN96WdWLan5mIYtddR3KaUPth47Sr55DS1rvSvjiz1b 2RQyOEU+i+oSGM9NhBCWUanTiO8gBNkGe1+wlL+tFj+IpiW58W70hCXNxTjYGbKd 5NC2kBY/lVWT+W3efjEVWWEyhu2oKhYecbi6qbrqhGGONqF52ivxKX0mXm1Xuj0l DkZfPA== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 43cek1vwnw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 14:46:27 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 4593740053; Tue, 10 Dec 2024 14:45:35 +0100 (CET) Received: from Webmail-eu.st.com (shfdag1node1.st.com [10.75.129.69]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 9283C2591FE; Tue, 10 Dec 2024 14:45:10 +0100 (CET) Received: from localhost (10.252.12.81) by SHFDAG1NODE1.st.com (10.75.129.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 10 Dec 2024 14:45:10 +0100 From: Olivier Moysan To: Jaroslav Kysela , Takashi Iwai , Liam Girdwood , Mark Brown CC: Olivier Moysan , , Subject: [PATCH 3/3] ASoC: hdmi-codec: allow to refine formats actually supported Date: Tue, 10 Dec 2024 14:42:54 +0100 Message-ID: <20241210134254.2967524-4-olivier.moysan@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241210134254.2967524-1-olivier.moysan@foss.st.com> References: <20241210134254.2967524-1-olivier.moysan@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SHFCAS1NODE2.st.com (10.75.129.73) To SHFDAG1NODE1.st.com (10.75.129.69) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Content-Type: text/plain; charset="utf-8" Currently the hdmi-codec driver registers all the formats that are allowed on the I2S bus. Add i2s_formats field to codec data, to allow the hdmi codec client to refine the list of the audio I2S formats actually supported. Signed-off-by: Olivier Moysan --- include/sound/hdmi-codec.h | 1 + sound/soc/codecs/hdmi-codec.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h index 5e1a9eafd10f..a65da989dab1 100644 --- a/include/sound/hdmi-codec.h +++ b/include/sound/hdmi-codec.h @@ -122,6 +122,7 @@ struct hdmi_codec_ops { /* HDMI codec initalization data */ struct hdmi_codec_pdata { const struct hdmi_codec_ops *ops; + u64 i2s_formats; uint i2s:1; uint no_i2s_playback:1; uint no_i2s_capture:1; diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c index d9df29a26f4f..3f9dfdbc693e 100644 --- a/sound/soc/codecs/hdmi-codec.c +++ b/sound/soc/codecs/hdmi-codec.c @@ -1077,6 +1077,10 @@ static int hdmi_codec_probe(struct platform_device *= pdev) if (hcd->i2s) { daidrv[i] =3D hdmi_i2s_dai; daidrv[i].playback.channels_max =3D hcd->max_i2s_channels; + if (hcd->i2s_formats) { + daidrv[i].playback.formats =3D hcd->i2s_formats; + daidrv[i].capture.formats =3D hcd->i2s_formats; + } if (hcd->no_i2s_playback) memset(&daidrv[i].playback, 0, sizeof(daidrv[i].playback)); --=20 2.25.1