From nobody Wed Feb 5 16:55:14 2025 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8110A33985 for ; Tue, 10 Dec 2024 09:13:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733822035; cv=none; b=cEdPVYHyCIGfsQNmeR8wY2vhAGukqSornYx7qODr1E4P34Gtq0DaEdbLFoN0/Xl2WWoxzuf1pYwFGYfRYPZpHBvLJM0sqH/tC9j9KmLtbrjdpjDxx4yZ0VEF6sSVJ+PB2R050t4lU8UncPcuHdWxjQJJjxH5Np/VjZcMG5obvGM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733822035; c=relaxed/simple; bh=6Rl7RBY3Oa2zHfOGIECtMA0i5U3bJs6BtQr9QbPTHFs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dXpc0Kkwzo78tLb0TB0khKGtF1hg8itVmfgjy/eX4A/j5B+QRacR2oUYDf6xbSzpeSR+3H/USGfI5f0iWZsnlyvOh6SYe9nv193y/5TO7ECM9lMndWlyWXLLzx9I0KOpBzaZxpMQOUE+a+1x/gAHu3QexgQKKHu2K6TLq/MAcWM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=U9PA05rb; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="U9PA05rb" Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BA1jCpd026166; Tue, 10 Dec 2024 09:13:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=4mzlhbrauKtzuT5c2kr1XA1iLimiPdESabUb5K3/R eQ=; b=U9PA05rbT76iEleTxTpFJhoRzTq0Fp79VQUioft61CDB0xvrDTsviOJd3 X7iVy2Yk3sjyNLARLLeBe2iiek5GnOVcgpvGy2Q/zIvevccpVgLLo3Gi+QBfg2Ib kLkmQ+xMhomK2biqIczOGz11IZY/bN9JQVzDcAwQAuTLNaH32sMHHMmANevmzIii 9bp+EI1nh/nekY56aAavbonI/7bghM01ttxGnUK4P2OxdkOIEAsCD9fvmIMl+JU7 /Xqh+RMMEttQ6QSKChK8+ep1FEqoyCUGIU2DCRBZFcS3+gnCKT1BQ2nwuJ1sN2sU Rk8LrpcmjYfdCdx3b8WF1wzgj+C0w== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43cdv8p4xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 09:13:36 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BA97wXJ017393; Tue, 10 Dec 2024 09:13:35 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43d3d1jhmb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 10 Dec 2024 09:13:35 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BA9DW3p56754554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 10 Dec 2024 09:13:32 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E59E220043; Tue, 10 Dec 2024 09:13:31 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1476820040; Tue, 10 Dec 2024 09:13:29 +0000 (GMT) Received: from li-4f5ba44c-27d4-11b2-a85c-a08f5b49eada.ibm.com.com (unknown [9.43.32.79]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 10 Dec 2024 09:13:28 +0000 (GMT) From: Sourabh Jain To: ebiederm@xmission.com Cc: Sourabh Jain , Baoquan he , Hari Bathini , Madhavan Srinivasan , Michael Ellerman , kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] kexec: Initialize ELF lowest address to ULONG_MAX Date: Tue, 10 Dec 2024 14:43:14 +0530 Message-ID: <20241210091314.185785-1-sourabhjain@linux.ibm.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-GUID: fFJ-KCR_VpFI_xMj5BF-3yEWiruOfqhJ X-Proofpoint-ORIG-GUID: fFJ-KCR_VpFI_xMj5BF-3yEWiruOfqhJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 spamscore=0 clxscore=1011 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412100068 Content-Type: text/plain; charset="utf-8" kexec_elf_load() loads an ELF executable and sets the address of the lowest PT_LOAD section to the address held by the lowest_load_addr function argument. To determine the lowest PT_LOAD address, a local variable lowest_addr (type unsigned long) is initialized to UINT_MAX. After loading each PT_LOAD, its address is compared to lowest_addr. If a loaded PT_LOAD address is lower, lowest_addr is updated. However, setting lowest_addr to UINT_MAX won't work when the kernel image is loaded above 4G, as the returned lowest PT_LOAD address would be invalid. This is resolved by initializing lowest_addr to ULONG_MAX instead. This issue was discovered while implementing crashkernel high/low reservation on the PowerPC architecture. Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()") Cc: Baoquan he Cc: Hari Bathini CC: Madhavan Srinivasan Cc: Michael Ellerman Cc: kexec@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Sourabh Jain Acked-by: Baoquan He --- kernel/kexec_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/kexec_elf.c b/kernel/kexec_elf.c index d3689632e8b9..3a5c25b2adc9 100644 --- a/kernel/kexec_elf.c +++ b/kernel/kexec_elf.c @@ -390,7 +390,7 @@ int kexec_elf_load(struct kimage *image, struct elfhdr = *ehdr, struct kexec_buf *kbuf, unsigned long *lowest_load_addr) { - unsigned long lowest_addr =3D UINT_MAX; + unsigned long lowest_addr =3D ULONG_MAX; int ret; size_t i; =20 --=20 2.47.1