From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAF52770E2; Tue, 10 Dec 2024 01:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794229; cv=none; b=gfLJbx0Bk0gr4CbdifWM1XlTGL47aBS+F0XQTpL48QerdmOk5HMO+zyXzGc+3MBZLac+IRZVpjFHBPbOKKjemb2MzsGq9OX4/TU6mxdjouQ8jGwTvxBc+B2Khe0ttVZVbmRYGLxH/3eI51wX0KOLgSUtlxcuzcVLRiPzvkmNhH8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794229; c=relaxed/simple; bh=mR5adaxqGtsuJQzKNCMllgT2TTCrBqKnWNwUktkOtYU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KqFBDRHsjQUTWX0RG4C07nyH/81dKzcTcQojYXvk4CBm8Iazj6Wj811VfjWUNWgm6CyPA1xr05uznJ2s5hLjClLWS6yguEq564pObmENmNhwRYuR14ZX0enDP/iS3fFKzvI6BCVuzDNdHydDbT+ivCwFLh01yk3ui8CpthYfYx0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=JgkwfL3P; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JgkwfL3P" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6d8918ec243so50940106d6.1; Mon, 09 Dec 2024 17:30:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794226; x=1734399026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5sUmnsMlb6+J2z+CZq/V8Utz5Q8oJwF2bHLJE2t/SHA=; b=JgkwfL3PWX8v2dawK+h5TB03tIR6KpvPTGVGhGaca5HXaNUupFESTGqOPlr+GL/+7a knOdKIjGLVIrPfiiJCJSkH8/+xtlLdZK9KbPUNUyHMIOcsVIkCic/jAD7pHzD13jx9Cc VyXh+3ZYDpnq982o3pP0K6F3cmYE9dCplVnDJ0IwvXts1tSL74i5jSL7SgipGxNff8f8 I/rvbcTyaeUKXhVVpO9zo4osy+S87weHP2e4ig3M2W1r1KSoJm5JE8v+ZJlce7fgGhZZ GHK68wTzfMiapjXKNYU6Y8hROY/kyf45jZ7IUXeleE/WldFVLvQ0k1bQyq3WEPhjbO5W XujQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794226; x=1734399026; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5sUmnsMlb6+J2z+CZq/V8Utz5Q8oJwF2bHLJE2t/SHA=; b=S7LPWA/m+iXDiTY7YXRWaq1aeabemwwYDMfZm6+Ix1YhpymLbBsaQMd14DQU/5jAL9 rmUBiaDSsyIWU24wFX5vopBSK49IBhjhQI8OjV9TqmllKj0mA8xxOc9qc8Nc14kPz+LP KJr+LOaLEe03CAcRbvTY3rwmUu9E2s8M7vBqzSx2b5icuO9xsvy5iqpHL7cTloVkeJd4 HKxamYSijm5FWF/2nS17NGmqLRchQApcOD8FlKHpCxiezdVbNPY65VSZwwkyBdD7z63l uVfsoGawOGS5NLcssxpett1VlmPYUgD7oB+eH6mHsWItnGXx4ZHXvjh6DTykJ4aTlhaw cZIw== X-Forwarded-Encrypted: i=1; AJvYcCUP30o37UxObnZ67CgPkzTp/M0XnGmuJBHSmnwrq3Vxkr6s0XzKjZaPTKli3C8WXfjXO990J2SLwni9K8Y=@vger.kernel.org, AJvYcCVXhQyu4eBvxOqkdGnpcWurDk17GQDqrdblhCBQjCup4hSs7ApR1F/UyJv4nYE4M96VbuMTrkdCScQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzmFg65HtlBKs9abgZxXlqvBDn65tFI5YgTjlxLIrUmh2o2jFJM OsYURo2KNBCHG/GW+U148wLA626vv4ms/cT0A3nAk5Xet7aHBPSK X-Gm-Gg: ASbGncv6cBFm6aVXl0n97uFtQYiBAje8+hnOqz8uBw8RIQyJkTLv7nmyfdm36/cW7zo OZyFOBqsT+Bz1i7fql11UQ/SeWsDklQJchT3xfXV1nKIt2zgNOnOS3PFQ2EhcYvLwBA113bI96z GLtv1E92fYVO6BFTcgBqgO5wtus5b0WqBzR0tDZosLhnL+phK7xyD/AgefVWsuxOERPXr4+Kz6p zXOB//gWgFtRtQf7ZsTXZ+2YxngEuiAi3eQSUjfujABYuf/KrYpSFu3sqIVDfC+dA== X-Google-Smtp-Source: AGHT+IE1D13JutVol/zUpThGrVNHALTvBXJmh1Qc3SYE16zwA1SMBc6vR4AEEi2kPGJtGcjxoFLleg== X-Received: by 2002:a05:6214:23c6:b0:6d8:960e:5785 with SMTP id 6a1803df08f44-6d91e314427mr51513186d6.13.1733794226579; Mon, 09 Dec 2024 17:30:26 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:26 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Caesar Wang , Detlev Casanova , Finley Xiao , Jonathan Cameron , Kevin Hilman , Krzysztof Kozlowski , Ulf Hansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 1/6] pmdomain: rockchip: fix rockchip_pd_power error handling Date: Tue, 10 Dec 2024 01:30:05 +0000 Message-Id: <20241210013010.81257-2-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The calls rockchip_pd_power makes to rockchip_pmu_set_idle_request lack any return error handling, causing device drivers to incorrectly believe the hardware idle requests succeed when they may have failed. This leads to software possibly accessing hardware that is powered off and the subsequent SError panic that follows. Add error checking and return errors to the calling function to prevent such crashes. gst-launch-1.0 videotestsrc num-buffers=3D2000 ! v4l2jpegenc ! fakesink Setting pipeline to PAUSED ...er-x64 Pipeline is PREROLLING ... Redistribute latency... rockchip-pm-domain ff100000.syscon:power-controller: failed to get ack on domain 'hevc', val=3D0x98260, idle =3D 0 SError Interrupt on CPU2, code 0x00000000bf000002 -- SError CPU: 2 UID: 0 PID: 804 Comm: videotestsrc0:s Not tainted 6.12.0-rc5+ #54 Hardware name: Firefly roc-rk3328-cc (DT) pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) pc : rockchip_vpu2_jpeg_enc_run+0x168/0xbc8 lr : device_run+0xb0/0x128 sp : ffff800082143a20 x29: ffff800082143a20 x28: 0000000000000140 x27: 0000000000000000 x26: ffff582c47a313e8 x25: ffff582c53e95000 x24: ffff582c53e92800 x23: ffff582c5bbe0000 x22: 0000000000000000 x21: ffff582c47a31080 x20: ffffa0d78cfa4168 x19: ffffa0d78cfa4168 x18: ffffb755b0519000 x17: 000000040044ffff x16: 00500072b5503510 x15: a7a6a5a4a3a29a99 x14: 989796959493928a x13: 0000000051eb851f x12: 00000000000000ff x11: ffffa0d78d812880 x10: ffffa0d78d7fbca0 x9 : 000000000000003f x8 : 0000000000000063 x7 : 000000000000003f x6 : 0000000000000040 x5 : ffff80008010d000 x4 : ffffa0d78cfa4168 x3 : ffffa0d78cfbfdd8 x2 : ffff80008010d0f4 x1 : 0000000000000020 x0 : 0000000000000140 Kernel panic - not syncing: Asynchronous SError Interrupt CPU: 2 UID: 0 PID: 804 Comm: videotestsrc0:s Not tainted 6.12.0-rc5+ #54 Hardware name: Firefly roc-rk3328-cc (DT) Call trace: dump_backtrace+0xa0/0x128 show_stack+0x20/0x38 dump_stack_lvl+0xc8/0xf8 dump_stack+0x18/0x28 panic+0x3ec/0x428 nmi_panic+0x48/0xa0 arm64_serror_panic+0x6c/0x88 do_serror+0x30/0x70 el1h_64_error_handler+0x38/0x60 el1h_64_error+0x7c/0x80 rockchip_vpu2_jpeg_enc_run+0x168/0xbc8 device_run+0xb0/0x128 v4l2_m2m_try_run+0xac/0x230 v4l2_m2m_ioctl_streamon+0x70/0x90 v4l_streamon+0x2c/0x40 __video_do_ioctl+0x194/0x400 video_usercopy+0x10c/0x808 video_ioctl2+0x20/0x80 v4l2_ioctl+0x48/0x70 __arm64_sys_ioctl+0xb0/0x100 invoke_syscall+0x50/0x120 el0_svc_common.constprop.0+0x48/0xf0 do_el0_svc+0x24/0x38 el0_svc+0x38/0x100 el0t_64_sync_handler+0xc0/0xc8 el0t_64_sync+0x1a8/0x1b0 SMP: stopping secondary CPUs Kernel Offset: 0x20d70c000000 from 0xffff800080000000 PHYS_OFFSET: 0xffffa7d3c0000000 CPU features: 0x00,00000090,00200000,0200421b Memory Limit: none ---[ end Kernel panic - not syncing: Asynchronous SError Interrupt ]--- Fixes: 7c696693a4f5 ("soc: rockchip: power-domain: Add power domain driver") Signed-off-by: Peter Geis --- drivers/pmdomain/rockchip/pm-domains.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rock= chip/pm-domains.c index cb0f93800138..57e8fa25d2bd 100644 --- a/drivers/pmdomain/rockchip/pm-domains.c +++ b/drivers/pmdomain/rockchip/pm-domains.c @@ -590,14 +590,18 @@ static int rockchip_pd_power(struct rockchip_pm_domai= n *pd, bool power_on) rockchip_pmu_save_qos(pd); =20 /* if powering down, idle request to NIU first */ - rockchip_pmu_set_idle_request(pd, true); + ret =3D rockchip_pmu_set_idle_request(pd, true); + if (ret < 0) + return ret; } =20 rockchip_do_pmu_set_power_domain(pd, power_on); =20 if (power_on) { /* if powering up, leave idle mode */ - rockchip_pmu_set_idle_request(pd, false); + ret =3D rockchip_pmu_set_idle_request(pd, false); + if (ret < 0) + return ret; =20 rockchip_pmu_restore_qos(pd); } --=20 2.39.5 From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A61AE70821; Tue, 10 Dec 2024 01:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794231; cv=none; b=Hbc123+OK2A6mmy5vW9fvrX/7sbbbufyYFY8iSdNxaffvzW5l6lJh1vvu+o/WJ7EPz4rpYdh4enSggl0y0xPBsfhtM8sUU+Z0XdTKeV/tkdFYdetG4sOp+Lg0xb7ciaIVQBu8MJo2dc79njiH+lk+OoGOufzHpilmEGH/WRi0N4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794231; c=relaxed/simple; bh=Dzs3B7MIUzasS8NT6pMEAG53wjk3aUUcR96wcHK22Hc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sf9wb8yn7y+RQGDemdbFmHyFHQZGtbULPP0m6y6Hd5AUGLjLB6hAeShLYFu+Uu2hXQqBCPgtUV5CROtFWHBZ1mIjE5UjyH9/l2ki3c+lAQyOzDwlM852zzO8+ySf9r7m+qrEPZgx38X+KFTlEylM5NIGHGxbfHHrXGgjWwUIczY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Jl+35DYE; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jl+35DYE" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d87ab49423so49438976d6.0; Mon, 09 Dec 2024 17:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794228; x=1734399028; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZbMZ1XEGG9+iR89acIoDRWlRdmkKPe5qHYKAcY8LBOk=; b=Jl+35DYEfVogm58CPyz4HUdFoeeovtj0hJgIAbi0VKU/TnS0nke2YVhQrN5daU2j1d cqnrvFYG3fKuH9MNLqwHcWMXbt5N9HBL06dyEMQCF0nc1qS4AXn+6kyXEkK6l35mn5yZ cg3Qf8LlwOedF+0chwR6xICTHd8YQk4VENe6VxUz3YZFylakUo+uaWjt9v3A4roMoICq gK05EjWBKt6Vpu4OLqzhHUrHHe6Tp2yXJ5kOG3o7ddwZD2iJWvjzuxc4p/qy5bh8IWE9 24lfVpPGxzcYOAP3IdrBgde6dSaPV00jpxltD1HkzwqyZRlaW1zWy7acJV5EbLj6+9jq vvlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794228; x=1734399028; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZbMZ1XEGG9+iR89acIoDRWlRdmkKPe5qHYKAcY8LBOk=; b=qI6nWCMwkeYc2jnC3B5o7l/ySeDhqNvYCt5w+Vc4iMJ5BuS1Yc8Xcp/oBCmSMu7EG9 dIzW2UqFKNyTbItavSjXMHTIhojWMWDlOYP2UEMOkd6/ODWqHNJBKPC9Yx3Rn76HcpIP 81cFvJwzmA0gwrdXTKY1zrPvTXUdY71saqdraLg71eShdqhDoEs7rCE6XZHQa92Utodn NjmnUmFoPzftzgQdihzPu9kyLZFbJMBXxZrWqfBxPsxHY2qRBKpu7Ch180a8+zOmK+p/ LGGQFYLh3Rz77bpO6ACp5ikgMGfgZ7gmPZCslbp70cMoN7BwQGuBmXvKeUS/+jlPN0dC ibvQ== X-Forwarded-Encrypted: i=1; AJvYcCV0vE1LX2dseg+J5zsObQXkIu9nuo1l9TKBdW6O8OHQR526BlIVABdba79amMz18ZXGJ4pXeRHwgcc=@vger.kernel.org, AJvYcCXOH4diWMiKhLV6QJctv1sjBR+fmYn6MEJo1eYFIp+TXn4wpg74S/2Pyl7XZ8TOuBqOGhw/QKT1qCxZDkwm@vger.kernel.org X-Gm-Message-State: AOJu0YxMN5r0zqp2yJa2xzU9uh3zZubIg87H1sAzzlPInuGfptjtdy5/ EAGMMvaKj1WXCYIUEcWEal0q5c/eblf4NTMZiBMf2m8FWmwP3AjzKGMQSy1e X-Gm-Gg: ASbGncseXRyoLBVFWE8R3RVw2cwWhEnN5M8molpFbwd7lVZjEXBhkGrfbYzay8sAvAm vK9PzeLf8M+T+POONFyTSnsXTIaSkeJwJvWLfCSKP0NQfpQfh0F6g2Fom+Iw46dV3nTWiGBtxGX GyI2/rZ5XPQ98jIC94SMf4gMHDEBtRCoJIt/gEqCVeZ/a1P9ndOuTudTQgDqbQEZ45/n1f2ClXH ijJ0JQuBT1f5e9Vn3JeNu8wDqNa6HU3V5PjpOctH5nHoyzATPnzH7m1nPJDRjBB4g== X-Google-Smtp-Source: AGHT+IHtWOPd4M5xIQAtOFMGvJ2WXw5oVrlCvjGb1M5Y3tJlywOZoegb0SMUWVqBgkFNZkQZZVQ7Og== X-Received: by 2002:a05:6214:d06:b0:6d8:850a:4d6a with SMTP id 6a1803df08f44-6d91e2d2bf2mr47042826d6.1.1733794228302; Mon, 09 Dec 2024 17:30:28 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:27 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Elaine Zhang , Michael Turquette , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 2/6] clk: rockchip: fix wrong clk_ref_usb3otg parent for rk3328 Date: Tue, 10 Dec 2024 01:30:06 +0000 Message-Id: <20241210013010.81257-3-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Correct the clk_ref_usb3otg parent to fix clock control for the usb3 controller on rk3328. Verified against the rk3328 trm and usb3 clock tree documentation. Fixes: fe3511ad8a1c ("clk: rockchip: add clock controller for rk3328") Signed-off-by: Peter Geis --- drivers/clk/rockchip/clk-rk3328.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3328.c b/drivers/clk/rockchip/clk-r= k3328.c index 3bb87b27b662..cf60fcf2fa5c 100644 --- a/drivers/clk/rockchip/clk-rk3328.c +++ b/drivers/clk/rockchip/clk-rk3328.c @@ -201,7 +201,7 @@ PNAME(mux_aclk_peri_pre_p) =3D { "cpll_peri", "gpll_peri", "hdmiphy_peri" }; PNAME(mux_ref_usb3otg_src_p) =3D { "xin24m", - "clk_usb3otg_ref" }; + "clk_ref_usb3otg_src" }; PNAME(mux_xin24m_32k_p) =3D { "xin24m", "clk_rtc32k" }; PNAME(mux_mac2io_src_p) =3D { "clk_mac2io_src", --=20 2.39.5 From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 34736155308; Tue, 10 Dec 2024 01:30:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794233; cv=none; b=FrP8a8xgWdn2M09dOEfCmbJWIUpl6nPkdua/mxMsVK2a8OAROrDazpP8fmmNYHqjZeVB45mNMnnLe7+HRyV5K2jQCCvevrc2eoAd17dgx3XQIXoGebaY4hwNG1+u2HQto/FCSuBnKuZtc2dH1LFrVk3s0zQxeO0pQAKIj708mUc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794233; c=relaxed/simple; bh=DUbLOQDRS/uCD9wQoNVZebUfm7GeL5XJwHgnz9Pasc8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mXuFlvb9q/LQ1WGkuiXm19n6TKziQxsCCCerexBNRGaElPaGxq/wMyYsw5Us9m0Z7ir7bieKHWNxkdNWKWf/fKlY7zuwhPGmcgdO9Yb/Slaf4fHuZRg1Vqy9zAMmeKU0mGp8JqhESPojNYhEB4RBZPbgOmo//t3+6eAjJNQ7rxA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fGwJnGdu; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fGwJnGdu" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d88d3d1eb6so48206676d6.0; Mon, 09 Dec 2024 17:30:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794231; x=1734399031; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7ryxhFq/D6uK4o3TwTQ7Wdb4StN8ThF9XTxHXMGYXkM=; b=fGwJnGdudVZV1qgFDVN+9CH0z8ac/hYJHh+CBPQ4j8+rTh74s2c19A6XBjfIY0eM8A Ss5QR3EwG6YDWRyZe4NlTgAjeGIoqIqPGIUY2ql925iNRkGJq4XmfkdYTOy8xTVM/Sf5 4S52ieo9ZpHo2gxN0+dkLQjRVWN7meg31GmFawtaDT43SX+FDErikEKMgosoLid/D7Xa A7vOd2JWOJqMjFIBQxkVY13rBWmfp6uHrASWvtr1hv5PAS0JeL/Cobgdy72PDOjCw4+G ShZuVFRA+FGRkm55c4Y+kbtbs73LH1GPjoaCHthg9Egqs00ixBJj563zDWbj+nqYK3t+ t5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794231; x=1734399031; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7ryxhFq/D6uK4o3TwTQ7Wdb4StN8ThF9XTxHXMGYXkM=; b=FXKBegJXnT91Hs/PKurXsxKhzr2f7zGy7Y7eoGxdu1qiuPWaORpqQ+xzNLWIhTQBBx SlRYFDvUP46D9l8UfroaoEOGddLK5b1VuLVEd8GWxLpm8rn/vf75ooqax1gEgqtUVrq+ +Kng2TxbzoprW62Rf2LEEohQlcWv752MUyKPVhKHbuGSdY8ofOKXqfxHBi/IrBSTCruG /yB8nTx8fXepZjMuVtwJYdMEwEtqmWDKvu/BhQL58bc2WHvYwBwyCKaaIbxVdZiVKv1n jKNUtQL5b1uSM0rF60GaPWHrxkJ+hYZPXPjLsJEH1xGvD6vYoLW1os1VmH7zZOoxMx4I 2GgA== X-Forwarded-Encrypted: i=1; AJvYcCWLj80ISvnRL6iZ2XgNRIUvJdrTMWwVngGBlDYenIeec4f565+Y7vR5552neLZFrtPKLPLfJyRKbD6IQGRS@vger.kernel.org, AJvYcCXOEvM4adXz3vjITR+A4HAC9cTa6+OMnD5fKDDxsCPINnCkvZXEjg3nGlK6XCG+5ni996rA1rS2v7D3@vger.kernel.org X-Gm-Message-State: AOJu0YzJnYO5MEUFmHImNXFACa+Saaog9uFJgD6G+h6O1MPRGoQIP6de jEdXFLEVaKb5YbbMaFXpAVgrNAqXYyXcStE0OdUFmCT74c0aRamO X-Gm-Gg: ASbGnctzFKaO4apnd/Lg8uAy+rwWlCSixsIsTxiRket0zrorJCgB6feymGp17WEGg1R TJSGbcqnit78+PJmUTQ2dJ4Iw3Xg75cwnZ9THzh41iVwFSJ7Y/Z0IOFmHpETsAoZfzNH7F0Lw9T o4GlvIesivL1g9R6s3kUPz2c/ZZtRxVrUH/cjvD8tggMm0SUTt4tvcYoq7vzxpjwV+TIicx1Vap 9v8ihHdOWzOcI+TVDxZf38FL1BBOYTOrTF1MPJMCoMwjo6jtxtevrGhfjNOL02XaQ== X-Google-Smtp-Source: AGHT+IGnHu4GKol3hVAzHldnP2oJaYa4cSwD67AUlgoZTcrdM6Y6t8bZ454xDQJ+meiSiuoKJRyJhw== X-Received: by 2002:a0c:edcd:0:b0:6d4:287d:b8d9 with SMTP id 6a1803df08f44-6d92128fb74mr27104106d6.2.1733794230935; Mon, 09 Dec 2024 17:30:30 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:29 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Conor Dooley , Diederik de Haas , Dragan Simic , Johan Jonker , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 3/6] arm64: dts: rockchip: remove ethernet alias from rk3328-roc Date: Tue, 10 Dec 2024 01:30:07 +0000 Message-Id: <20241210013010.81257-4-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove the ethernet alias added back in during the rk3328-roc dtsi conversion. Fixes: f3c6526d6fb2 ("arm64: dts: rockchip: Convert dts files used as paren= ts to dtsi files") Signed-off-by: Peter Geis --- arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/boot= /dts/rockchip/rk3328-roc.dtsi index b5bd5e7d5748..f782c8220dd3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi @@ -9,7 +9,6 @@ =20 / { aliases { - ethernet0 =3D &gmac2io; mmc0 =3D &sdmmc; mmc1 =3D &emmc; }; --=20 2.39.5 From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E6E219DF7D; Tue, 10 Dec 2024 01:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794235; cv=none; b=Ql+ivXCHUIeoLQPfFXVDgEo365PKjBSJke8Gy9Lm3NBkrgIvUgvNxnn5L95o3y9D1bkTV9d6BIBrQ8B3qGlQnb3BKw3QHXaGC5XMVLA316tlV2ZQjPhwDaH4cvqARCwfeZ5HmOteSU10yYdUrWHvnCinU0z7gcnAPe8yPCyDiaQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794235; c=relaxed/simple; bh=ASCKekPDWvwthwVMcENIEemFajBQNC4WJRFy+efGCHU=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J+xfiOchXgXyJjjCKcbJ/MfKKXJf/186QqivOeoUnwIkRr5RmAQekZ39TorrlVq01EhzWh1t45OvLO1bW5uNg4WAku/LcL9z0R3bMfE/EpK/UFP5MPUXRM+SYnsftgsJWAJitwDWXP3dBf31A6KgbGB3qbfYSK342OjL6vDKwXg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f7VE8rPe; arc=none smtp.client-ip=209.85.219.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f7VE8rPe" Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6d87ab49423so49439506d6.0; Mon, 09 Dec 2024 17:30:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794233; x=1734399033; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nes5VB2VcAfNvacXIUYzGUAIsX7gVlGNiJVgrHet/68=; b=f7VE8rPeEW9YNscAhASNR3btviHkoCx2s7ieWqfJ3JslsEezeFPTyZa+J0pXvj337E yecibvXXxBE6gQHMvtOGnXkI1KxBYvL3LbmPCdLEUlYjBkj/5abbQ83ckfqlCByVyEVB xNiSKDtepToGbz4tJYmTH3JxBv44nzKqw//WLVADEBf8YOVpDZhdg/nulTuusZMJomva mdNCXDqhs0NFH/A3TP8dmfQmzHmYruYM7Ne3bc8aEZWbkSoBwQ2mn/XO+brrZM6sFcgc zE78wirZMaoB8ZliaqtbwxIcmVIOhiWN8lqwvduNwemstvfPGq25wMyJzgg3M4cVIRRM SbDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794233; x=1734399033; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nes5VB2VcAfNvacXIUYzGUAIsX7gVlGNiJVgrHet/68=; b=VCzoUDh3XMPRQi2XEeXXL07Zou9mmOU+8hWT0eIy3kIaL/DJB2NqUxUWhekWqZkybe 67FX40kRVK17NRxyPmyoveVwQiRA5NncUGAwSJnMFDnBxF2TYI2dbOycMaa71KR/alTF LA9pIe5h3KIgbIvYBl8UrCVw6SKbUJyWxJVnb9115S0bFop+xwS7bH+/cPuOnHfZl8sw 4VTIyj7WylLF0pgw7t1i5Br+5bv5kRvb8SGeyPCYHXh4TCLMTdW4qXnvVflLtEP2czYL 1v7/whpPXnEd9iCtTj2Gfh+4y7Cg+plahILGpXRvyt+3AMQbMB7R+/bATCYohyBzzk3D rwjA== X-Forwarded-Encrypted: i=1; AJvYcCVwUrBezJdRdEsDoBYFPNw9Yj/BBYXafgFjs9z2kcmkTpUKsbGnsl2982DP9GIdaCyciM87/B/MfvYI@vger.kernel.org, AJvYcCXArYkLQUcr21Efq6zFockhvFCgtUj/28mgrxrXE+7dQysBMmEBBU/3be/KUwv+4j53eaoqOkl2HdIvuGHv@vger.kernel.org X-Gm-Message-State: AOJu0YySsdWDjTnNJ1Ii7OoR/BWZnLTSLPjstAgud9DQnD+zh8BsE3rZ qVBf8MYX6odAOvJYL5Ea6JT6T26ArYMK90OT0+TUCKpOmP1TNCEa X-Gm-Gg: ASbGncvMr6k0Fv7iG7yQkKh4APmSo7fdQfwX5gVTGwZQY4KOp3uYsqUZ7QGmxmYTnjW 5nksVnyToGtuumFXOD3b2a9e8i70pp4dA+gz/rA2muFjEDRcKDqpzJjx6h0ZjnU3XB6kimdHLlp BlIWFMUwp2Rd5HZeenwzjnmHEBYb/f9l8fBfZma+AqAVE3iJJ9DiKL13x87tj+SwNum9+hjVRtc oiQ4FAoXTySP3ocBIEnvBtpCsrJl+nLnKHSOJLHWdX9R+pGoE+jdsga4cFar68Hzg== X-Google-Smtp-Source: AGHT+IGDRUk9+gv8pP1CJieucgxw/FIyVkf5JoAn+WsrS/JAfYgwU4trbE3sWTyJ4SkA4cp4lgjq+A== X-Received: by 2002:a05:6214:d06:b0:6d8:850a:4d6a with SMTP id 6a1803df08f44-6d91e2d2bf2mr47046016d6.1.1733794232931; Mon, 09 Dec 2024 17:30:32 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:31 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Alex Bee , Conor Dooley , Diederik de Haas , Dragan Simic , Johan Jonker , Jonas Karlman , Krzysztof Kozlowski , Liang Chen , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, shironeko Subject: [PATCH 4/6] arm64: dts: rockchip: add hevc power domain clock to rk3328 Date: Tue, 10 Dec 2024 01:30:08 +0000 Message-Id: <20241210013010.81257-5-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There is a race condition at startup between disabling power domains not used and disabling clocks not used on the rk3328. When the clocks are disabled first, the hevc power domain fails to shut off leading to a splat of failures. Add the hevc core clock to the rk3328 power domain node to prevent this condition. rcu: INFO: rcu_sched detected expedited stalls on CPUs/tasks: { 3-.... } 1087 jiffies s: 89 root: 0x8/. rcu: blocking rcu_node structures (internal RCU debug): Sending NMI from CPU 0 to CPUs 3: NMI backtrace for cpu 3 CPU: 3 UID: 0 PID: 86 Comm: kworker/3:3 Not tainted 6.12.0-rc5+ #53 Hardware name: Firefly ROC-RK3328-CC (DT) Workqueue: pm genpd_power_off_work_fn pstate: 20400005 (nzCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=3D--) pc : regmap_unlock_spinlock+0x18/0x30 lr : regmap_read+0x60/0x88 sp : ffff800081123c00 x29: ffff800081123c00 x28: ffff2fa4c62cad80 x27: 0000000000000000 x26: ffffd74e6e660eb8 x25: ffff2fa4c62cae00 x24: 0000000000000040 x23: ffffd74e6d2f3ab8 x22: 0000000000000001 x21: ffff800081123c74 x20: 0000000000000000 x19: ffff2fa4c0412000 x18: 0000000000000000 x17: 77202c31203d2065 x16: 6c6469203a72656c x15: 6c6f72746e6f632d x14: 7265776f703a6e6f x13: 2063766568206e69 x12: 616d6f64202c3431 x11: 347830206f742030 x10: 3430303034783020 x9 : ffffd74e6c7369e0 x8 : 3030316666206e69 x7 : 205d383738353733 x6 : 332e31202020205b x5 : ffffd74e6c73fc88 x4 : ffffd74e6c73fcd4 x3 : ffffd74e6c740b40 x2 : ffff800080015484 x1 : 0000000000000000 x0 : ffff2fa4c0412000 Call trace: regmap_unlock_spinlock+0x18/0x30 rockchip_pmu_set_idle_request+0xac/0x2c0 rockchip_pd_power+0x144/0x5f8 rockchip_pd_power_off+0x1c/0x30 _genpd_power_off+0x9c/0x180 genpd_power_off.part.0.isra.0+0x130/0x2a8 genpd_power_off_work_fn+0x6c/0x98 process_one_work+0x170/0x3f0 worker_thread+0x290/0x4a8 kthread+0xec/0xf8 ret_from_fork+0x10/0x20 rockchip-pm-domain ff100000.syscon:power-controller: failed to get ack on domain 'hevc', val=3D0x88220 Fixes: 52e02d377a72 ("arm64: dts: rockchip: add core dtsi file for RK3328 S= oCs") Signed-off-by: Peter Geis Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts= /rockchip/rk3328.dtsi index 0597de415fe0..7d992c3c01ce 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -333,6 +333,7 @@ power: power-controller { =20 power-domain@RK3328_PD_HEVC { reg =3D ; + clocks =3D <&cru SCLK_VENC_CORE>; #power-domain-cells =3D <0>; }; power-domain@RK3328_PD_VIDEO { --=20 2.39.5 From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA4D219F117; Tue, 10 Dec 2024 01:30:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794238; cv=none; b=gg6WlJdmGd8MkeMxfenfw3paF99CncqJSXT1/wYwNYENDpC/AeLhoX4hw6S8nk/xPqHX6IsBV13pMvELwDlEyrEdQwYhBnX00AbSk+RoXRpG61bf+bY+9svnRDlCJhDtXi3jjiXWUlGyAxN0Q3rhPvyOSCf3rqpDDxJKMkQSpvI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794238; c=relaxed/simple; bh=cDexXHX4GzgWdDmlf1YRfDkxlON8YYEX9HpLDOcY0BM=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hDovkf67g778o5VIEgdfFKwYLeb8+yjwiaWRaifo+P3oZPoqRD+eWGHMXk/b46kU9RxvsT/WFZ7kZKlcfBRE5rLHkn6qjXyE+Ra2pC47FNGRjPPfLbfhqdVffGJxgdJxaFXCW6t6S7gZmgh3BqqbKOPB6eWDwZzrzE/1Hch0C1A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lJuyM3De; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lJuyM3De" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d88d3d1eb6so48207106d6.0; Mon, 09 Dec 2024 17:30:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794235; x=1734399035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fC9D6bBSfVEUhHq7Trd28DiW5CSpsRgZ8oSjVO7Uwcc=; b=lJuyM3DevFopQ+QTJ/Zzko32N/AswveCgMBUwTb0WY4qGd3PXNh2G6rsCQnj4NxEq4 pCQVmZaDXJyGb0Ba3bLkvbvjdu6dTr3fbvJaa65OXDrzYdnUGsJMQrxPStsgP/2WBmcA UYTAZbII7khphho9J48QZyB4poWerc4ZkDTRZOI8eWKGly6epVwoCca8wRIkyAFLSAnv n6dbF4h9DOjbHk8Ri01yrq+Z1x+OKmQLI/Op0+ev3SWyzwZj/NEh71H85h+dugoKivyI jWGJcMU38vDjwW1elNd9XkmcN6qrYJMCAD9zE+4CzArL4vlJ8gVjMA8LtpC5lqaP4qfG VMZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794235; x=1734399035; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fC9D6bBSfVEUhHq7Trd28DiW5CSpsRgZ8oSjVO7Uwcc=; b=LqtVIx1Jr6D4k3x1gMwjLWZMxZB9Fn2XcaAV9REYgWSEKVczabPReErBdvqBZ8+Wt6 DZwsdw7u+mfBwHD1hp5DaS2YbkkpPai84NW/nV2SsgOhfpya/89o6+7vxpgpFnpc5/L7 SUws8VSkTmI1eX+qsAJ3ejkrQ4CF+dc8v/6Gj6UtN47lS/uDoRG2LXBqk09SbR2vHIux U6ScJeELnh30pxHvffYD3UyZhuUuE8pJONrbSJKSxHSU0Hf/RAVQ9qWSw+oLkmn1KDmF BW6VGqnegDXvg+KWFJGpSlp5vORLVmdqyBzYkvN+UppOBk6JQw1MoEhQ9egpfhLn0jpX cLjw== X-Forwarded-Encrypted: i=1; AJvYcCU4oWWm667m/LfZQ1/p1cNTr7IVMTw2ax/GEYWRHH++B13GPlyZinCGC843XZUzWBBQiSfLbohPM5hO@vger.kernel.org, AJvYcCW6EKUSro99FCcm5n+4J1rVDhEz/0koXSgbuc4i+5clsXub05CxYvUqeBJUhcl1SsnV7/jI/oYVJ1EmZtmA@vger.kernel.org X-Gm-Message-State: AOJu0Yxz9/GReB9U5dfS7H6HNAjPibcC17kNL23HX3KULhpRLRIzKWbw AB+bBFa932olqMMA3DxhFHLm0zYEmt1fR019mNV96iFUEaWUbV3x X-Gm-Gg: ASbGnctKMuGPRt2Y3QRw3qzFTTGD6kXnAeMKUr+U0Qtc1o4UIGVzkFW12mWnjLjPsEu nyFRP7Rq9l6umAsfWx2bPCOoyr8KwJWNHZSXt2t+65Pzh7VWxFoyoNqkAizdwxxP/htfuczfpCC RsSHrfG7fQx1+ukxi+WGgiW439OQNBGFA875QpMEi80e+WWIgKEUKWf6c4Oa68JgL0bFdMXwHYU 57jzZxOyByhrAWkRtDi4oAvZb1R3Pyo0jd1c/KWxMW3jPLdkMyihJxOmQqaBHUXDw== X-Google-Smtp-Source: AGHT+IEljNAVBvyvJhfVHfvliBl66vtZbHIQPQl7CHgoQDBd6uJthPJkN2CurCsM+FLREOa8EJMyWQ== X-Received: by 2002:a05:6214:c82:b0:6d8:b5dd:7699 with SMTP id 6a1803df08f44-6d92131428amr19515826d6.17.1733794235614; Mon, 09 Dec 2024 17:30:35 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:34 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Conor Dooley , Diederik de Haas , Dragan Simic , Johan Jonker , Krzysztof Kozlowski , Levin Du , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 5/6] arm64: dts: rockchip: correct rk3328-roc regulator map Date: Tue, 10 Dec 2024 01:30:09 +0000 Message-Id: <20241210013010.81257-6-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The rk3328-roc-cc input power is sourced from a micro-usb port, while the rk3328-roc-pc input power is sourced from a usb-c port. Both inputs are 5vdc only. Remove the 12v input from the device tree. While we are at it, add missing voltages and supply to vcc_phy, missing voltages to vcc_host1_5v, and standardize the order of regulator properties among the fixed regulators. Fixes: 2171f4fdac06 ("arm64: dts: rockchip: add roc-rk3328-cc board") Signed-off-by: Peter Geis --- arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 23 +++++++++++++------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/boot= /dts/rockchip/rk3328-roc.dtsi index f782c8220dd3..6984387ff8b3 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi @@ -24,22 +24,23 @@ gmac_clkin: external-gmac-clock { #clock-cells =3D <0>; }; =20 - dc_12v: regulator-dc-12v { + /* fed from passive usb input connector */ + dc_5v: regulator-dc-5v { compatible =3D "regulator-fixed"; - regulator-name =3D "dc_12v"; + regulator-name =3D "dc_5v"; regulator-always-on; regulator-boot-on; - regulator-min-microvolt =3D <12000000>; - regulator-max-microvolt =3D <12000000>; + regulator-min-microvolt =3D <5000000>; + regulator-max-microvolt =3D <5000000>; }; =20 vcc_sd: regulator-sdmmc { compatible =3D "regulator-fixed"; + regulator-name =3D "vcc_sd"; gpio =3D <&gpio0 RK_PD6 GPIO_ACTIVE_LOW>; pinctrl-names =3D "default"; pinctrl-0 =3D <&sdmmc0m1_pin>; regulator-boot-on; - regulator-name =3D "vcc_sd"; regulator-min-microvolt =3D <3300000>; regulator-max-microvolt =3D <3300000>; vin-supply =3D <&vcc_io>; @@ -50,22 +51,25 @@ vcc_sdio: regulator-sdmmcio { states =3D <1800000 0x1>, <3300000 0x0>; regulator-name =3D "vcc_sdio"; regulator-type =3D "voltage"; + regulator-always-on; regulator-min-microvolt =3D <1800000>; regulator-max-microvolt =3D <3300000>; - regulator-always-on; vin-supply =3D <&vcc_sys>; }; =20 vcc_host1_5v: vcc_otg_5v: regulator-vcc-host1-5v { compatible =3D "regulator-fixed"; + regulator-name =3D "vcc_host1_5v"; enable-active-high; pinctrl-names =3D "default"; pinctrl-0 =3D <&usb20_host_drv>; - regulator-name =3D "vcc_host1_5v"; regulator-always-on; + regulator-min-microvolt =3D <5000000>; + regulator-max-microvolt =3D <5000000>; vin-supply =3D <&vcc_sys>; }; =20 + /* sourced from usb input through 3A fuse */ vcc_sys: regulator-vcc-sys { compatible =3D "regulator-fixed"; regulator-name =3D "vcc_sys"; @@ -73,7 +77,7 @@ vcc_sys: regulator-vcc-sys { regulator-boot-on; regulator-min-microvolt =3D <5000000>; regulator-max-microvolt =3D <5000000>; - vin-supply =3D <&dc_12v>; + vin-supply =3D <&dc_5v>; }; =20 vcc_phy: regulator-vcc-phy { @@ -81,6 +85,9 @@ vcc_phy: regulator-vcc-phy { regulator-name =3D "vcc_phy"; regulator-always-on; regulator-boot-on; + regulator-min-microvolt =3D <3300000>; + regulator-max-microvolt =3D <3300000>; + vin-supply =3D <&vcc_io>; }; =20 leds { --=20 2.39.5 From nobody Wed Dec 17 14:23:38 2025 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37F861A01C6; Tue, 10 Dec 2024 01:30:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794240; cv=none; b=b8VBjW70Hq78XhpHuOh/exqxHkL7uz6fyfVSV2wRyU7IzKVNSCo+EgssuPYeEuoCrU/8WVHcX6YCa9HYDalxU5Ner3YDbtRHrvkH7auwh9xYQz8fUK4THKfrxeAxHKZhzP9X1Y3gypGcjcOgChfDyWDUi/uhcZ4b9V0GNJq3gwA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733794240; c=relaxed/simple; bh=BZYDFRTpTR3NtC0vC92IDRbXApKJBbwtNKxfulbPgWY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=WJG/9NkHlCdhDy/LexrTpJxE6rCjjKSeOLekIyla3tHG579ebDdNy4XYA1PPfqP8qvEwyFplw9fvbHcBbnxrUOk7F4SpBdaK5xJBTkILb3vZ4Z9OBj5BoXzR2TKlx4VE6X9GTevEnNtGoRT+o5M4Hj5u0kWz0WaF0+R29Nao4Xs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OnlUz32d; arc=none smtp.client-ip=209.85.160.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OnlUz32d" Received: by mail-qt1-f171.google.com with SMTP id d75a77b69052e-467777d7c83so1666101cf.3; Mon, 09 Dec 2024 17:30:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733794238; x=1734399038; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Jqw9ssvr+RamFhuTkFddw4DLtLM/EJe/MJOiR1nlAKE=; b=OnlUz32d8X/zRJo4HX4SXTwRWw++VVCWHpD583OC2wOZakMw7MaALrYws/3W9oC5xq xUIBJBjGqE9E83PuF3ecIEILspaQFgtIS99vHiGvy+KYILjp7bkvtNClrOPNeyb/M5s3 C7+HpFaZlMdBDPs/hDSM0yoLbYRy8hTbP7eQQkkjzPMKtWu5mSqNAtbDevhBknb0Q4m/ kWMRvnjX+AvhKI0wHey2gmsHx5zZv/8Sb/x3Il62wSyBnwfBBq3oQ2tojxi7aFlNn4m8 UukkORXXC0rOyF6/gwZRDbXavgFbxz5xVXcmsIwiiTAChvi0tf1W4i7Tyw2SGz8eq2MO mjWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733794238; x=1734399038; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Jqw9ssvr+RamFhuTkFddw4DLtLM/EJe/MJOiR1nlAKE=; b=MOOjadri7kjZ3KuIXztTNJoXX29QTP1BD7Hm8UfjaIp6eAj0Lc38Irw4V+qI2BwN2T pg96qhIStQtgPUq1zv3MuQPxrp3hnVm6/9JpAU04vgrKHceeLl0xz40EV8VEWNzkVNCK oEMpU24UMMUJQWFqN7uXS93URfuPkPVcdk9gKJRrBFVHLmmvwfNcm43enfxxKJOTzrHH Q2D0FDAgH36ba1eDP1RFHN7YxJGIJ/VgKlq8M/hG2AJJj4geNoNBo2QjjOpi21z7Gq1z e2UoZfykQEm5koDCXStDCUsYb7sgfvdcJpk+hpfafcOeG+blIv9XRrH6gNfhczvrfhE9 OT7A== X-Forwarded-Encrypted: i=1; AJvYcCWfnANBIw/2y5QY/J7s3omOQPv7QVbWHcqFm+xpPbpfbM7vSU6v1OK/j7TqNe89F149pJMMmqunvYhS@vger.kernel.org, AJvYcCXbyAhMa/hymT+v9SXLwB9t8ctE+u9IfEDKY5RchqUOMqmNpN8DgaIWSSkTgKqj4UwP/7emrHIVOW34NNbS@vger.kernel.org X-Gm-Message-State: AOJu0YwOTevSI9/3Yo9LGZT2VDcmFvLmtJX3SKuecAdQ/a/DmiI0utB0 JEceBp4yEiYSxvP9r3lnU6/PxM1frXA2IfRm0oXNNlRcnS0q3TRK X-Gm-Gg: ASbGncuxQrciZbuIis0Dyk1WDjAjKCmWYf5EVkb50/fVAV1qrxJwPQqpZNr/5qUb7u+ RNhG705f2v7cpXqZoYk9IyaUbfqn4PoOtiuZMJBHtpdrVA965zlHcC3W3Zto8AD+ytIeMkIsOeX u3jAVRxRSie/zJ3J9dz8ASsVWmERGmBaoxvN9CuDkbCyEQmaUknE34pfVcfAeI6m2eS/MWwmL+g 6xTbE0kMWjH16Y7GATsDKlG8L1tsE/FY1saTeuc6jHZKWAERX7bkjT+ddTNcr7lpw== X-Google-Smtp-Source: AGHT+IH6JIbgEEMAy3xvXZsAPmdWHrEPx5XojlgCSN0/zSm0Ou9M/ynX9WkvMGNi2Bhw9DACvmHMFw== X-Received: by 2002:a05:6214:226a:b0:6d8:86c8:c2a9 with SMTP id 6a1803df08f44-6d8e73bf6b0mr241598566d6.31.1733794238061; Mon, 09 Dec 2024 17:30:38 -0800 (PST) Received: from master-x64.sparksnet ([204.111.53.234]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d8f429a79csm36834346d6.72.2024.12.09.17.30.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 17:30:36 -0800 (PST) From: Peter Geis To: Heiko Stuebner Cc: Peter Geis , Conor Dooley , Diederik de Haas , Dragan Simic , Johan Jonker , Krzysztof Kozlowski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: [PATCH 6/6] arm64: dts: rockchip: Remove address aligned beats from rk3328-roc Date: Tue, 10 Dec 2024 01:30:10 +0000 Message-Id: <20241210013010.81257-7-pgwipeout@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241210013010.81257-1-pgwipeout@gmail.com> References: <20241210013010.81257-1-pgwipeout@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Since commit 8a469ee35606 ("arm64: dts: rockchip: Add txpbl node for RK3399/RK3328"), the snps,aal, snps,txpbl, and snps,rxpbl nodes have been unnecessary in the separate device trees. There is also a performance loss to using snps,aal. Remove these from the rk3328-roc device tree. Signed-off-by: Peter Geis Reviewed-by: Dragan Simic --- arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi b/arch/arm64/boot= /dts/rockchip/rk3328-roc.dtsi index 6984387ff8b3..0d476cc2144d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc.dtsi @@ -155,12 +155,9 @@ &gmac2io { phy-mode =3D "rgmii"; pinctrl-names =3D "default"; pinctrl-0 =3D <&rgmiim1_pins>; - snps,aal; snps,reset-gpio =3D <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us =3D <0 10000 50000>; - snps,rxpbl =3D <0x4>; - snps,txpbl =3D <0x4>; tx_delay =3D <0x24>; rx_delay =3D <0x18>; status =3D "okay"; --=20 2.39.5