From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55DB32343A8 for ; Tue, 10 Dec 2024 09:42:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823764; cv=none; b=YIN8S6h4cB+wi4LeBcPauavADg6tXOwp+zE/YzOlHiL4I7hwo16AQO/uuc4PVlLoaun70nep1YPacjG0Nn6Jmq34Kgu6nz6TMm0sR9j2fgZRu9F8CPz73zwt5oRXQI2fXz0gNGC/yS+UsIB7JuMP+Js1CCJSbE+qBXp1Iu0e/Nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823764; c=relaxed/simple; bh=rmwFzpOA42dIRXNsU2drW2dWyEvkHqz3gtgDji2Och0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=HTnL7fkBJ+sP4hGTvAJu1TNjIfFlcPdRTJHpwMeeQg/FdxAE03a3grPpgGyytRwQSYLdXYi3ul0CxcEnMFfzO/CjtaMtcxtxjou+6odFfxEipsfiPNFOmYTUeDKwl3dzhpmtcOGASn8rzAA5FoB/W3i7NPmInpb6X7EYpBeHyBk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=g0ZcH7lg; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="g0ZcH7lg" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-46375ac25fbso51373851cf.0 for ; Tue, 10 Dec 2024 01:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823762; x=1734428562; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mgd78hYMarmsibCfxN09wNv5VkU7Kl0GIxvAEFpsb+k=; b=g0ZcH7lgdUKw3HuKI6e6x0CocS+EEmi8/0aZiOK6E7N7SuqVCkgmDKlG39cWCCNTiY Hs7v7KP3GEXtVOPu8YpXPE+vSazCyN3b8EQJCpU7gDexXouh94cdpiH+qCS2iIDu+sh2 RFSB1h7BgEI22lGPLYDMEAUL8VOTCC6aiU8T4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823762; x=1734428562; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mgd78hYMarmsibCfxN09wNv5VkU7Kl0GIxvAEFpsb+k=; b=mdo6zdVUB+5DSmkBkiVxAcL6a5KVTD8rqCHl/+qlycVSIw40xMLp5P7wgoxqIiqGhL ynO4sno3E+ogVsoEhzLSEIdapFnKD+lIGP4VZ0JS3KWgQJ+HI/71n6eHNfUhBnBD+KZ1 VTa9TTUlKdCKy57NB2TldtWkFaZMxnXvK341Vkgj8d/t7IhSwK0VUkI1ai3faahkXnZA d3jerFzktP/ZUKDQGozoazpIq/BOaFkkHUEkxsKbQuV70btcqYuQ6qTV/S9AAZiDIIsW FF5k64k32I6vKLipfCa3AG0NMA5ytyzD5J4nwLft17r63F6OHCVTRlOBDfp5VMeA4LHp vzVg== X-Forwarded-Encrypted: i=1; AJvYcCVUuJmMExBGnGvq9ZEBK+rgjFufBBRQ4mvBUHmpBRSeE3rmAeRnQLAoBRIS6MgsD0HEDm00mTDkCYmSdfs=@vger.kernel.org X-Gm-Message-State: AOJu0YxpQKFr+gd+FgMD4kY1LY1nWFDzmOo49q4Fbjcw48Yk2GhGp6Zh E+BjnYTBFdpWIa8kk/y0sJx+HuL1oHtYn1+Is3ay3hsxqK9GfaiKU7GLKRihiA== X-Gm-Gg: ASbGnctEv+sAJXNjQfurMiOLR3lCq4PpZzE/fN+poMoHBYcmM4lZK82hgYcepuj5q0O PKABjnkmt/gXykXR1nsr4wGNVtPswVZKmciycqM/qHx85ZpJozU8RqYEEdoWDs1KeLHZNcdZ9ma ZkVmtVAUv0b/3D5SID3YqvLkPHWc0jR6hoTaDovBNc4J5tn4ZNxHnGSwpuZru43JNvA1/ThIMHB a8ywjG/vm3rwy/2lT96EjA6Npk6vcl9fz1OUEzm5aVRq1p9ylasjys/D2vECfn3qtrPCgjanjLn iB0vtfZ3mTRNnVYj6WwByu4LSgNA X-Google-Smtp-Source: AGHT+IEoHdjAOUrtfazsH3n6Y31nFhgn307yyWvBWJlDV472zk6B1DrShdvegUY+dN1ioRJHlGD/zg== X-Received: by 2002:a05:6214:c25:b0:6d1:7433:3670 with SMTP id 6a1803df08f44-6d91e2d3799mr68330476d6.4.1733823762206; Tue, 10 Dec 2024 01:42:42 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:41 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:37 +0000 Subject: [PATCH v16 01/18] media: uvcvideo: Fix event flags in uvc_ctrl_send_events Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-1-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , stable@vger.kernel.org, Yunke Cao X-Mailer: b4 0.13.0 If there is an event that needs the V4L2_EVENT_CTRL_CH_FLAGS flag, all the following events will have that flag, regardless if they need it or not. This is because we keep using the same variable all the time and we do not reset its original value. Cc: stable@vger.kernel.org Fixes: 805e9b4a06bf ("[media] uvcvideo: Send control change events for slav= e ctrls when the master changes") Reviewed-by: Laurent Pinchart Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 4fe26e82e3d1..bab9fdac98e6 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1673,13 +1673,13 @@ static void uvc_ctrl_send_events(struct uvc_fh *han= dle, { struct uvc_control_mapping *mapping; struct uvc_control *ctrl; - u32 changes =3D V4L2_EVENT_CTRL_CH_VALUE; unsigned int i; unsigned int j; =20 for (i =3D 0; i < xctrls_count; ++i) { - ctrl =3D uvc_find_control(handle->chain, xctrls[i].id, &mapping); + u32 changes =3D V4L2_EVENT_CTRL_CH_VALUE; =20 + ctrl =3D uvc_find_control(handle->chain, xctrls[i].id, &mapping); if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS) /* Notification will be sent from an Interrupt event. */ continue; --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38E862343B2 for ; Tue, 10 Dec 2024 09:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823766; cv=none; b=TsmXCo9rlVEo8wuTQugczYBekm1fjK1SC9f6dr1XLOnrvSnAPiyb6e9c7Z2AjZtp5+zV715Wr4vihCCSpMEO4YVo0HlolKF8PwD2uQDiX7bJAeKjbLoYBJULPIHnow4uetmaqHFUMrFDMC0NPY597SX+Kz1W3HKWekXbDGRHqvU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823766; c=relaxed/simple; bh=mSr7Gvae8SyDIcFX3igGruNP0QzUB8T910r8ssCG2qo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ub05dzseVKzCgMmrnto1Bt2Fu38ZNvD28YC1jZqZ9ib8wtI1r0QX0gyZQjUm3YKTOAnX2hTVQdAqpWO0/t2OYkuJ8XXn4tbEJR01Hdt6/877uAUH75LJzObcur5oYcyB8EFpGC2UxFhSlbswGN4pPfnoGc9duAl3hR4FxY2/enY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=h8WzHBDz; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="h8WzHBDz" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7b1b224f6c6so567132885a.3 for ; Tue, 10 Dec 2024 01:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823763; x=1734428563; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HwpWIJ+QJD5X+8ABcKOk5KEH3gUKj+thJplDDZ9yydE=; b=h8WzHBDzvkRCFSEKhR9I0QeacLfbtVypZa7WsGwjotuo2JFtHzosFrY93IuXD/PZe4 IzoFc0bLCHpN3VIAAk/+yd1+jeM6o2fqG0m9mGBjm65WYBF7qJSwdyO/1IlVzWLetrE5 5b5D30x6ducuS/Wo8JNAEnqDDx5zAdMvYS0Zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823763; x=1734428563; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HwpWIJ+QJD5X+8ABcKOk5KEH3gUKj+thJplDDZ9yydE=; b=Bg7qjZ30tDsv5BXKhIkwCYWFuoHub6j/GOyQ7jVUSaM5k4mCduPYpeOfpED3w/5viV 51W8xukCmJjm3+FznPTfU1kbestb+HkR+3DWpqlZFkfI8fCDC+8gCoUfMHj+ACGA/0Zv c5er0Txn/L3J9lv80eabOk/at81Cwa0Xq5ikUelaTF7adTubD6uGr7GtcYHSXx4nT+bP TfsfB6x2msphoTxhcQseMr0gkEOcBjc8i3TzsLbNOX6y4uYBHEUZIJuERdJnnqNenIZ/ rA9YoJHkLFOPk3Jhn6WtQ9ibBj9UtHlHnVpWoljT1DhiPnS1kkYY2azHOOqLOghBbR46 2U2g== X-Forwarded-Encrypted: i=1; AJvYcCVBX7YPmoCXNyB89eYhhDHtA9pmIl3WSx3+gRXkSQcDx6jAbd2UfNc5vDzV9Q6psEiuPydw09tHScuRtfQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwEl8MJvo6XkB1zJI4xoNTujpiUtbS+w7FRNKTaohZjNZpqcSLQ Tzhc0f7Ub2TmjAMipPTV7H8mfoewNVPFkQ7s7ICwKfUKN5FAsje5XyxcBXUtrR6jaTnI1KypXxI = X-Gm-Gg: ASbGncs1FyBTgv77y8Nf1BvzNGn5oleCZzn0Pcc66S4Be2sbDC0vwE4daXF3DP4CMnE 82V1j6rvNZSiM9i/Cu8FLXFE321lLeHwEszjGQzefTkYRqcU+fQLMXGxkHAkuOzUdkEQ2U6rT+7 lc1WANio3N2SGCdosxqz8ScQe1fC11EQ3+ls2UmHGwKYu9D2N2xKKX2RQ+t8YqtXAfYRqrj8ELI CW9ViEA8sA6zxbVEnYgtH4gZUfyFbND1ckRAAU27axPWoU1FIqtZdRhLgMQxUAf7fxKS2b+SZ65 U6IeQLV3F7oKZ8bKuphPQIAX4Vkp X-Google-Smtp-Source: AGHT+IFa2TEpe2Qesl7yI5CyQNIsC6eMEK14b9r7ylhftJYRY2kreBYXeuXMKDreeRGeTp879aRXJw== X-Received: by 2002:a05:620a:448b:b0:7b6:604c:f334 with SMTP id af79cd13be357-7b6dcec6bfemr561814385a.55.1733823763159; Tue, 10 Dec 2024 01:42:43 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:42 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:38 +0000 Subject: [PATCH v16 02/18] media: v4l2_ctrl: Add V4L2_CTRL_TYPE_RECT Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-2-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao , Sergey Senozhatsky , Daniel Scally , Hans Verkuil X-Mailer: b4 0.13.0 From: Yunke Cao Add p_rect to struct v4l2_ext_control with basic support in v4l2-ctrls. Reviewed-by: Laurent Pinchart Reviewed-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky Reviewed-by: Daniel Scally Signed-off-by: Yunke Cao Reviewed-by: Hans Verkuil Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 4 ++++ .../userspace-api/media/v4l/vidioc-queryctrl.rst | 7 +++++++ .../userspace-api/media/videodev2.h.rst.exceptions | 1 + drivers/media/v4l2-core/v4l2-ctrls-core.c | 16 ++++++++++++= +++- include/media/v4l2-ctrls.h | 2 ++ include/uapi/linux/videodev2.h | 2 ++ 6 files changed, 31 insertions(+), 1 deletion(-) diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b= /Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst index 4d56c0528ad7..b74a74ac06fc 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst @@ -199,6 +199,10 @@ still cause this situation. - ``p_area`` - A pointer to a struct :c:type:`v4l2_area`. Valid if this control is of type ``V4L2_CTRL_TYPE_AREA``. + * - struct :c:type:`v4l2_rect` * + - ``p_rect`` + - A pointer to a struct :c:type:`v4l2_rect`. Valid if this control is + of type ``V4L2_CTRL_TYPE_RECT``. * - struct :c:type:`v4l2_ctrl_h264_sps` * - ``p_h264_sps`` - A pointer to a struct :c:type:`v4l2_ctrl_h264_sps`. Valid if this = control is diff --git a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst b/D= ocumentation/userspace-api/media/v4l/vidioc-queryctrl.rst index 4d38acafe8e1..56d5c8b0b88b 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst @@ -441,6 +441,13 @@ See also the examples in :ref:`control`. - n/a - A struct :c:type:`v4l2_area`, containing the width and the height of a rectangular area. Units depend on the use case. + * - ``V4L2_CTRL_TYPE_RECT`` + - n/a + - n/a + - n/a + - A struct :c:type:`v4l2_rect`, containing a rectangle described by + the position of its top-left corner, the width and the height. Units + depend on the use case. * - ``V4L2_CTRL_TYPE_H264_SPS`` - n/a - n/a diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b= /Documentation/userspace-api/media/videodev2.h.rst.exceptions index 429b5cdf05c3..3cf1380b52b0 100644 --- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions +++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions @@ -150,6 +150,7 @@ replace symbol V4L2_CTRL_TYPE_HEVC_SPS :c:type:`v4l2_ct= rl_type` replace symbol V4L2_CTRL_TYPE_HEVC_PPS :c:type:`v4l2_ctrl_type` replace symbol V4L2_CTRL_TYPE_HEVC_SLICE_PARAMS :c:type:`v4l2_ctrl_type` replace symbol V4L2_CTRL_TYPE_AREA :c:type:`v4l2_ctrl_type` +replace symbol V4L2_CTRL_TYPE_RECT :c:type:`v4l2_ctrl_type` replace symbol V4L2_CTRL_TYPE_FWHT_PARAMS :c:type:`v4l2_ctrl_type` replace symbol V4L2_CTRL_TYPE_VP8_FRAME :c:type:`v4l2_ctrl_type` replace symbol V4L2_CTRL_TYPE_VP9_COMPRESSED_HDR :c:type:`v4l2_ctrl_type` diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2= -core/v4l2-ctrls-core.c index eeab6a5eb7ba..4c8744c8cd96 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c @@ -370,7 +370,11 @@ void v4l2_ctrl_type_op_log(const struct v4l2_ctrl *ctr= l) case V4L2_CTRL_TYPE_AV1_FILM_GRAIN: pr_cont("AV1_FILM_GRAIN"); break; - + case V4L2_CTRL_TYPE_RECT: + pr_cont("%ux%u@%dx%d", + ptr.p_rect->width, ptr.p_rect->height, + ptr.p_rect->left, ptr.p_rect->top); + break; default: pr_cont("unknown type %d", ctrl->type); break; @@ -815,6 +819,7 @@ static int std_validate_compound(const struct v4l2_ctrl= *ctrl, u32 idx, struct v4l2_ctrl_hdr10_mastering_display *p_hdr10_mastering; struct v4l2_ctrl_hevc_decode_params *p_hevc_decode_params; struct v4l2_area *area; + struct v4l2_rect *rect; void *p =3D ptr.p + idx * ctrl->elem_size; unsigned int i; =20 @@ -1172,6 +1177,12 @@ static int std_validate_compound(const struct v4l2_c= trl *ctrl, u32 idx, return -EINVAL; break; =20 + case V4L2_CTRL_TYPE_RECT: + rect =3D p; + if (!rect->width || !rect->height) + return -EINVAL; + break; + default: return -EINVAL; } @@ -1872,6 +1883,9 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ct= rl_handler *hdl, case V4L2_CTRL_TYPE_AREA: elem_size =3D sizeof(struct v4l2_area); break; + case V4L2_CTRL_TYPE_RECT: + elem_size =3D sizeof(struct v4l2_rect); + break; default: if (type < V4L2_CTRL_COMPOUND_TYPES) elem_size =3D sizeof(s32); diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 59679a42b3e7..b0db167a3ac4 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -56,6 +56,7 @@ struct video_device; * @p_av1_tile_group_entry: Pointer to an AV1 tile group entry structure. * @p_av1_frame: Pointer to an AV1 frame structure. * @p_av1_film_grain: Pointer to an AV1 film grain structure. + * @p_rect: Pointer to a rectangle. * @p: Pointer to a compound value. * @p_const: Pointer to a constant compound value. */ @@ -89,6 +90,7 @@ union v4l2_ctrl_ptr { struct v4l2_ctrl_av1_tile_group_entry *p_av1_tile_group_entry; struct v4l2_ctrl_av1_frame *p_av1_frame; struct v4l2_ctrl_av1_film_grain *p_av1_film_grain; + struct v4l2_rect *p_rect; void *p; const void *p_const; }; diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index e7c4dce39007..c1c2ae150d30 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -1859,6 +1859,7 @@ struct v4l2_ext_control { __s32 __user *p_s32; __s64 __user *p_s64; struct v4l2_area __user *p_area; + struct v4l2_rect __user *p_rect; struct v4l2_ctrl_h264_sps __user *p_h264_sps; struct v4l2_ctrl_h264_pps __user *p_h264_pps; struct v4l2_ctrl_h264_scaling_matrix __user *p_h264_scaling_matrix; @@ -1929,6 +1930,7 @@ enum v4l2_ctrl_type { V4L2_CTRL_TYPE_U16 =3D 0x0101, V4L2_CTRL_TYPE_U32 =3D 0x0102, V4L2_CTRL_TYPE_AREA =3D 0x0106, + V4L2_CTRL_TYPE_RECT =3D 0x0107, =20 V4L2_CTRL_TYPE_HDR10_CLL_INFO =3D 0x0110, V4L2_CTRL_TYPE_HDR10_MASTERING_DISPLAY =3D 0x0111, --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009BC2343D5 for ; Tue, 10 Dec 2024 09:42:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823768; cv=none; b=g/x1179Y9oYPnmwCrZMQhsiATIvShcQSILphs4GTub4TF7J+D+6+VoAuuoDdBILP0MAkmkw0yf8BI7rjB0FyKRNuHC3rmQCTwHuyujIwOhXqFr/ojJ5BrbbXwauekM1EyO+SMFaDmI4s6ERUb+W49s34kw1Ks+gvgEMYJlRuAX4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823768; c=relaxed/simple; bh=hRXGdIGbTI2YB1HYZWU7dqZqGD2NjOESoH3kkBmtgfM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KH0mYO6acXtM9XeGcCjVGCaxC8imRP3cfiPD45yft1DqiNpXTH5YaFgMPvd/7evbYBcipgS1j1XyIAyiIDoH0XeiGWLQZhkVDGqUOxoktBhSZCxfgzCd0/9+/i/stKCrlW2IXs3poCtW9rhSZorzjD0c60pXD5f57Io3Vj9oEcM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=XL2mMr7g; arc=none smtp.client-ip=209.85.219.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="XL2mMr7g" Received: by mail-qv1-f45.google.com with SMTP id 6a1803df08f44-6d8e8445219so27460576d6.0 for ; Tue, 10 Dec 2024 01:42:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823765; x=1734428565; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=p6ThprH3RJFEIOmz2KNW6/UEBeFhYx/tQ+j/vnjRjiI=; b=XL2mMr7gdPRdo7jm4K1qssy6sxKHIjAIlpj2NWjfrU2gZjlAkripV8RwH1/mL2L5hK qXtnzL2QlhBIWvLghY4wHmfpa810i+sXyq0vPIPc47xxUcUreLQF2q+GtHnh51boNcVu MnRf9wWIhE1lGJbQkdjtC4kk6KIOSxE9S6Ji4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823765; x=1734428565; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p6ThprH3RJFEIOmz2KNW6/UEBeFhYx/tQ+j/vnjRjiI=; b=VewE+M0p9tJINinY7r85VzChTUJFnAUzCRCYYoz/tTkxtGDFUfVsUnYaRJUBcLm8Cq 2brDN992Uwe2o1ycF/u5S5Bau4ku9t5kq5bNZn0N9F1TyluIgYfDkujJp1d29y+pplzF L+FVoG77+0XZdhcWBdPg1Z9SxFEYScTFtnQgOU410Iky0DNeml1H08DR74rp6dr2CsRT nJb0DexKfELxNwqBL9+ytwrN2XcWniy/KQXx5dSQ8r2NXLxBivikrPATgko9ZKdATlQI scIyKA10GzTdsiheLsSx80+kWwKvw23F+RFA/DAyNT1Yt4Xm9iEdIqE18p25H2LCCFeI oCFA== X-Forwarded-Encrypted: i=1; AJvYcCV69Qmlg8jIg73yQAdd8+2in2EjLA/Qj4d1l/WNZeu55pcwNV8bfmKSsix5d1O1KaLzHjUn6BN8j3FGIJw=@vger.kernel.org X-Gm-Message-State: AOJu0YxhPAbaPrcc9VD3E2ldnNFf9UmETX8tqDj17QeHoLXKaqqJjCQN bVUKIb3ElUe4fPdPQpRgDcYKtqzIR1ynvAaV4MV2yQdLejoPnzZYYhvghaew2A== X-Gm-Gg: ASbGncunCYFrjRDNNH0XcwSFiwJ7NYhwNd+dcBRm58PLoLo24Kog3HljniacySCHiru 9XvYMhLqcQyqMvvzcXLDNNyNb5bQcRnVA5tObbBZuoaqf/VZCK1NzvRPXaRcunzMWLf1a9xPOrf WuR/w3TSQP4cMO3y3Z0i356VVlA6a/Cc4FiJ3JlwIuRzniG0BkQow/xu5FDO8ixq2Wf9dcwUXbh XPGQURa/UU5P9I40LtOlKYpGGENibaqDeLwkknsjAWjDvx5Hl9CH0oGmBWdj32/Efzn507ZGT68 Brka6JE7PTcfvul78TcIkWwkP/7Y X-Google-Smtp-Source: AGHT+IE8KJtS3tAAh/5noJmxNQYPUDI9sAZE+6jdGsqEt5//zqvoWpUdFq149mcin+dkDWHICoT1eQ== X-Received: by 2002:a05:6214:21ea:b0:6d8:8480:27e with SMTP id 6a1803df08f44-6d8e7125d1emr207267976d6.11.1733823764806; Tue, 10 Dec 2024 01:42:44 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:44 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:39 +0000 Subject: [PATCH v16 03/18] media: v4l2-ctrls: add support for V4L2_CTRL_WHICH_MIN/MAX_VAL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-3-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 From: Hans Verkuil Add the capability of retrieving the min and max values of a compound control. [Ricardo: Added static to v4l2_ctrl_type_op_(maximum|minimum) proto] [Ricardo: Fix documentation] Signed-off-by: Hans Verkuil Signed-off-by: Yunke Cao Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- .../userspace-api/media/v4l/vidioc-g-ext-ctrls.rst | 22 ++- .../userspace-api/media/v4l/vidioc-queryctrl.rst | 9 +- .../userspace-api/media/videodev2.h.rst.exceptions | 3 + drivers/media/i2c/imx214.c | 4 +- drivers/media/platform/qcom/venus/venc_ctrls.c | 9 +- drivers/media/v4l2-core/v4l2-ctrls-api.c | 54 ++++++-- drivers/media/v4l2-core/v4l2-ctrls-core.c | 151 +++++++++++++++++= ---- drivers/media/v4l2-core/v4l2-ioctl.c | 4 +- include/media/v4l2-ctrls.h | 36 ++++- include/uapi/linux/videodev2.h | 3 + 10 files changed, 247 insertions(+), 48 deletions(-) diff --git a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst b= /Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst index b74a74ac06fc..b8698b85bd80 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-g-ext-ctrls.rst @@ -338,14 +338,26 @@ still cause this situation. - Which value of the control to get/set/try. * - :cspan:`2` ``V4L2_CTRL_WHICH_CUR_VAL`` will return the current val= ue of the control, ``V4L2_CTRL_WHICH_DEF_VAL`` will return the default - value of the control and ``V4L2_CTRL_WHICH_REQUEST_VAL`` indicates that - these controls have to be retrieved from a request or tried/set for - a request. In the latter case the ``request_fd`` field contains the + value of the control, ``V4L2_CTRL_WHICH_MIN_VAL`` will return the minimum + value of the control, and ``V4L2_CTRL_WHICH_MAX_VAL`` will return the max= imum + value of the control. ``V4L2_CTRL_WHICH_REQUEST_VAL`` indicates that + the control value has to be retrieved from a request or tried/set for + a request. In that case the ``request_fd`` field contains the file descriptor of the request that should be used. If the device does not support requests, then ``EACCES`` will be returned. =20 - When using ``V4L2_CTRL_WHICH_DEF_VAL`` be aware that you can only - get the default value of the control, you cannot set or try it. + When using ``V4L2_CTRL_WHICH_DEF_VAL``, ``V4L2_CTRL_WHICH_MIN_VAL`` + or ``V4L2_CTRL_WHICH_MAX_VAL`` be aware that you can only get the + default/minimum/maximum value of the control, you cannot set or try it. + + Whether a control supports querying the minimum and maximum values using + ``V4L2_CTRL_WHICH_MIN_VAL`` and ``V4L2_CTRL_WHICH_MAX_VAL`` is indicated + by the ``V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX`` flag. Most non-compound + control types support this. For controls with compound types, the + definition of minimum/maximum values are provided by + the control documentation. If a compound control does not document the + meaning of minimum/maximum value, then querying the minimum or maximum + value will result in the error code -EINVAL. =20 For backwards compatibility you can also use a control class here (see :ref:`ctrl-class`). In that case all controls have to diff --git a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst b/D= ocumentation/userspace-api/media/v4l/vidioc-queryctrl.rst index 56d5c8b0b88b..3549417c7feb 100644 --- a/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst +++ b/Documentation/userspace-api/media/v4l/vidioc-queryctrl.rst @@ -447,7 +447,10 @@ See also the examples in :ref:`control`. - n/a - A struct :c:type:`v4l2_rect`, containing a rectangle described by the position of its top-left corner, the width and the height. Units - depend on the use case. + depend on the use case. Support for ``V4L2_CTRL_WHICH_MIN_VAL`` and + ``V4L2_CTRL_WHICH_MAX_VAL`` is optional and depends on the + ``V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX`` flag. See the documentation of + the specific control on how to interpret the minimum and maximum values. * - ``V4L2_CTRL_TYPE_H264_SPS`` - n/a - n/a @@ -664,6 +667,10 @@ See also the examples in :ref:`control`. ``dims[0]``. So setting the control with a differently sized array will change the ``elems`` field when the control is queried afterwards. + * - ``V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX`` + - 0x1000 + - This control supports getting minimum and maximum values using + vidioc_g_ext_ctrls with V4L2_CTRL_WHICH_MIN/MAX_VAL. =20 Return Value =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D diff --git a/Documentation/userspace-api/media/videodev2.h.rst.exceptions b= /Documentation/userspace-api/media/videodev2.h.rst.exceptions index 3cf1380b52b0..35d3456cc812 100644 --- a/Documentation/userspace-api/media/videodev2.h.rst.exceptions +++ b/Documentation/userspace-api/media/videodev2.h.rst.exceptions @@ -396,6 +396,7 @@ replace define V4L2_CTRL_FLAG_HAS_PAYLOAD control-flags replace define V4L2_CTRL_FLAG_EXECUTE_ON_WRITE control-flags replace define V4L2_CTRL_FLAG_MODIFY_LAYOUT control-flags replace define V4L2_CTRL_FLAG_DYNAMIC_ARRAY control-flags +replace define V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX control-flags =20 replace define V4L2_CTRL_FLAG_NEXT_CTRL control replace define V4L2_CTRL_FLAG_NEXT_COMPOUND control @@ -570,6 +571,8 @@ ignore define V4L2_CTRL_DRIVER_PRIV ignore define V4L2_CTRL_MAX_DIMS ignore define V4L2_CTRL_WHICH_CUR_VAL ignore define V4L2_CTRL_WHICH_DEF_VAL +ignore define V4L2_CTRL_WHICH_MIN_VAL +ignore define V4L2_CTRL_WHICH_MAX_VAL ignore define V4L2_CTRL_WHICH_REQUEST_VAL ignore define V4L2_OUT_CAP_CUSTOM_TIMINGS ignore define V4L2_CID_MAX_CTRLS diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c index 4962cfe7c83d..b0439005ec71 100644 --- a/drivers/media/i2c/imx214.c +++ b/drivers/media/i2c/imx214.c @@ -774,7 +774,9 @@ static int imx214_ctrls_init(struct imx214 *imx214) imx214->unit_size =3D v4l2_ctrl_new_std_compound(ctrl_hdlr, NULL, V4L2_CID_UNIT_CELL_SIZE, - v4l2_ctrl_ptr_create((void *)&unit_size)); + v4l2_ctrl_ptr_create((void *)&unit_size), + v4l2_ctrl_ptr_create(NULL), + v4l2_ctrl_ptr_create(NULL)); =20 v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx214_ctrl_ops, &props); =20 diff --git a/drivers/media/platform/qcom/venus/venc_ctrls.c b/drivers/media= /platform/qcom/venus/venc_ctrls.c index 51801a962ed2..4d36c44f9d44 100644 --- a/drivers/media/platform/qcom/venus/venc_ctrls.c +++ b/drivers/media/platform/qcom/venus/venc_ctrls.c @@ -662,11 +662,16 @@ int venc_ctrl_init(struct venus_inst *inst) =20 v4l2_ctrl_new_std_compound(&inst->ctrl_handler, &venc_ctrl_ops, V4L2_CID_COLORIMETRY_HDR10_CLL_INFO, - v4l2_ctrl_ptr_create(&p_hdr10_cll)); + v4l2_ctrl_ptr_create(&p_hdr10_cll), + v4l2_ctrl_ptr_create(NULL), + v4l2_ctrl_ptr_create(NULL)); =20 v4l2_ctrl_new_std_compound(&inst->ctrl_handler, &venc_ctrl_ops, V4L2_CID_COLORIMETRY_HDR10_MASTERING_DISPLAY, - v4l2_ctrl_ptr_create((void *)&p_hdr10_mastering)); + v4l2_ctrl_ptr_create((void *)&p_hdr10_mastering), + v4l2_ctrl_ptr_create(NULL), + v4l2_ctrl_ptr_create(NULL)); + =20 v4l2_ctrl_new_std_menu(&inst->ctrl_handler, &venc_ctrl_ops, V4L2_CID_MPEG_VIDEO_INTRA_REFRESH_PERIOD_TYPE, diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-= core/v4l2-ctrls-api.c index 95a2202879d8..c61f3ec09d24 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c @@ -94,6 +94,22 @@ static int def_to_user(struct v4l2_ext_control *c, struc= t v4l2_ctrl *ctrl) return ptr_to_user(c, ctrl, ctrl->p_new); } =20 +/* Helper function: copy the minimum control value back to the caller */ +static int min_to_user(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl) +{ + ctrl->type_ops->minimum(ctrl, 0, ctrl->p_new); + + return ptr_to_user(c, ctrl, ctrl->p_new); +} + +/* Helper function: copy the maximum control value back to the caller */ +static int max_to_user(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl) +{ + ctrl->type_ops->maximum(ctrl, 0, ctrl->p_new); + + return ptr_to_user(c, ctrl, ctrl->p_new); +} + /* Helper function: copy the caller-provider value as the new control valu= e */ static int user_to_new(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl) { @@ -229,8 +245,8 @@ static int prepare_ext_ctrls(struct v4l2_ctrl_handler *= hdl, cs->error_idx =3D i; =20 if (cs->which && - cs->which !=3D V4L2_CTRL_WHICH_DEF_VAL && - cs->which !=3D V4L2_CTRL_WHICH_REQUEST_VAL && + (cs->which < V4L2_CTRL_WHICH_DEF_VAL || + cs->which > V4L2_CTRL_WHICH_MAX_VAL) && V4L2_CTRL_ID2WHICH(id) !=3D cs->which) { dprintk(vdev, "invalid which 0x%x or control id 0x%x\n", @@ -259,6 +275,15 @@ static int prepare_ext_ctrls(struct v4l2_ctrl_handler = *hdl, return -EINVAL; } =20 + if (!(ctrl->flags & V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX) && + (cs->which =3D=3D V4L2_CTRL_WHICH_MIN_VAL || + cs->which =3D=3D V4L2_CTRL_WHICH_MAX_VAL)) { + dprintk(vdev, + "invalid which 0x%x or control id 0x%x\n", + cs->which, id); + return -EINVAL; + } + if (ctrl->cluster[0]->ncontrols > 1) have_clusters =3D true; if (ctrl->cluster[0] !=3D ctrl) @@ -368,8 +393,8 @@ static int prepare_ext_ctrls(struct v4l2_ctrl_handler *= hdl, */ static int class_check(struct v4l2_ctrl_handler *hdl, u32 which) { - if (which =3D=3D 0 || which =3D=3D V4L2_CTRL_WHICH_DEF_VAL || - which =3D=3D V4L2_CTRL_WHICH_REQUEST_VAL) + if (which =3D=3D 0 || (which >=3D V4L2_CTRL_WHICH_DEF_VAL && + which <=3D V4L2_CTRL_WHICH_MAX_VAL)) return 0; return find_ref_lock(hdl, which | 1) ? 0 : -EINVAL; } @@ -389,10 +414,12 @@ int v4l2_g_ext_ctrls_common(struct v4l2_ctrl_handler = *hdl, struct v4l2_ctrl_helper *helpers =3D helper; int ret; int i, j; - bool is_default, is_request; + bool is_default, is_request, is_min, is_max; =20 is_default =3D (cs->which =3D=3D V4L2_CTRL_WHICH_DEF_VAL); is_request =3D (cs->which =3D=3D V4L2_CTRL_WHICH_REQUEST_VAL); + is_min =3D (cs->which =3D=3D V4L2_CTRL_WHICH_MIN_VAL); + is_max =3D (cs->which =3D=3D V4L2_CTRL_WHICH_MAX_VAL); =20 cs->error_idx =3D cs->count; cs->which =3D V4L2_CTRL_ID2WHICH(cs->which); @@ -432,13 +459,14 @@ int v4l2_g_ext_ctrls_common(struct v4l2_ctrl_handler = *hdl, =20 /* * g_volatile_ctrl will update the new control values. - * This makes no sense for V4L2_CTRL_WHICH_DEF_VAL and + * This makes no sense for V4L2_CTRL_WHICH_DEF_VAL, + * V4L2_CTRL_WHICH_MIN_VAL, V4L2_CTRL_WHICH_MAX_VAL and * V4L2_CTRL_WHICH_REQUEST_VAL. In the case of requests * it is v4l2_ctrl_request_complete() that copies the * volatile controls at the time of request completion * to the request, so you don't want to do that again. */ - if (!is_default && !is_request && + if (!is_default && !is_request && !is_min && !is_max && ((master->flags & V4L2_CTRL_FLAG_VOLATILE) || (master->has_volatiles && !is_cur_manual(master)))) { for (j =3D 0; j < master->ncontrols; j++) @@ -467,6 +495,10 @@ int v4l2_g_ext_ctrls_common(struct v4l2_ctrl_handler *= hdl, ret =3D -ENOMEM; else if (is_request && ref->p_req_valid) ret =3D req_to_user(cs->controls + idx, ref); + else if (is_min) + ret =3D min_to_user(cs->controls + idx, ref->ctrl); + else if (is_max) + ret =3D max_to_user(cs->controls + idx, ref->ctrl); else if (is_volatile) ret =3D new_to_user(cs->controls + idx, ref->ctrl); else @@ -564,9 +596,11 @@ int try_set_ext_ctrls_common(struct v4l2_fh *fh, =20 cs->error_idx =3D cs->count; =20 - /* Default value cannot be changed */ - if (cs->which =3D=3D V4L2_CTRL_WHICH_DEF_VAL) { - dprintk(vdev, "%s: cannot change default value\n", + /* Default/minimum/maximum values cannot be changed */ + if (cs->which =3D=3D V4L2_CTRL_WHICH_DEF_VAL || + cs->which =3D=3D V4L2_CTRL_WHICH_MIN_VAL || + cs->which =3D=3D V4L2_CTRL_WHICH_MAX_VAL) { + dprintk(vdev, "%s: cannot change default/min/max value\n", video_device_node_name(vdev)); return -EINVAL; } diff --git a/drivers/media/v4l2-core/v4l2-ctrls-core.c b/drivers/media/v4l2= -core/v4l2-ctrls-core.c index 4c8744c8cd96..d510ca67e815 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls-core.c +++ b/drivers/media/v4l2-core/v4l2-ctrls-core.c @@ -182,29 +182,66 @@ static void std_init_compound(const struct v4l2_ctrl = *ctrl, u32 idx, } } =20 -void v4l2_ctrl_type_op_init(const struct v4l2_ctrl *ctrl, u32 from_idx, +static void std_min_compound(const struct v4l2_ctrl *ctrl, u32 idx, + union v4l2_ctrl_ptr ptr) +{ + void *p =3D ptr.p + idx * ctrl->elem_size; + + if (ctrl->p_min.p_const) + memcpy(p, ctrl->p_min.p_const, ctrl->elem_size); + else + memset(p, 0, ctrl->elem_size); +} + +static void std_max_compound(const struct v4l2_ctrl *ctrl, u32 idx, union v4l2_ctrl_ptr ptr) +{ + void *p =3D ptr.p + idx * ctrl->elem_size; + + if (ctrl->p_max.p_const) + memcpy(p, ctrl->p_max.p_const, ctrl->elem_size); + else + memset(p, 0, ctrl->elem_size); +} + +static void __v4l2_ctrl_type_op_init(const struct v4l2_ctrl *ctrl, u32 fro= m_idx, + u32 which, union v4l2_ctrl_ptr ptr) { unsigned int i; u32 tot_elems =3D ctrl->elems; u32 elems =3D tot_elems - from_idx; + s64 value; =20 - if (from_idx >=3D tot_elems) + switch (which) { + case V4L2_CTRL_WHICH_DEF_VAL: + value =3D ctrl->default_value; + break; + case V4L2_CTRL_WHICH_MAX_VAL: + value =3D ctrl->maximum; + break; + case V4L2_CTRL_WHICH_MIN_VAL: + value =3D ctrl->minimum; + break; + default: return; + } =20 switch (ctrl->type) { case V4L2_CTRL_TYPE_STRING: + if (which =3D=3D V4L2_CTRL_WHICH_DEF_VAL) + value =3D ctrl->minimum; + for (i =3D from_idx; i < tot_elems; i++) { unsigned int offset =3D i * ctrl->elem_size; =20 - memset(ptr.p_char + offset, ' ', ctrl->minimum); - ptr.p_char[offset + ctrl->minimum] =3D '\0'; + memset(ptr.p_char + offset, ' ', value); + ptr.p_char[offset + value] =3D '\0'; } break; case V4L2_CTRL_TYPE_INTEGER64: - if (ctrl->default_value) { + if (value) { for (i =3D from_idx; i < tot_elems; i++) - ptr.p_s64[i] =3D ctrl->default_value; + ptr.p_s64[i] =3D value; } else { memset(ptr.p_s64 + from_idx, 0, elems * sizeof(s64)); } @@ -214,9 +251,9 @@ void v4l2_ctrl_type_op_init(const struct v4l2_ctrl *ctr= l, u32 from_idx, case V4L2_CTRL_TYPE_MENU: case V4L2_CTRL_TYPE_BITMASK: case V4L2_CTRL_TYPE_BOOLEAN: - if (ctrl->default_value) { + if (value) { for (i =3D from_idx; i < tot_elems; i++) - ptr.p_s32[i] =3D ctrl->default_value; + ptr.p_s32[i] =3D value; } else { memset(ptr.p_s32 + from_idx, 0, elems * sizeof(s32)); } @@ -226,32 +263,61 @@ void v4l2_ctrl_type_op_init(const struct v4l2_ctrl *c= trl, u32 from_idx, memset(ptr.p_s32 + from_idx, 0, elems * sizeof(s32)); break; case V4L2_CTRL_TYPE_U8: - memset(ptr.p_u8 + from_idx, ctrl->default_value, elems); + memset(ptr.p_u8 + from_idx, value, elems); break; case V4L2_CTRL_TYPE_U16: - if (ctrl->default_value) { + if (value) { for (i =3D from_idx; i < tot_elems; i++) - ptr.p_u16[i] =3D ctrl->default_value; + ptr.p_u16[i] =3D value; } else { memset(ptr.p_u16 + from_idx, 0, elems * sizeof(u16)); } break; case V4L2_CTRL_TYPE_U32: - if (ctrl->default_value) { + if (value) { for (i =3D from_idx; i < tot_elems; i++) - ptr.p_u32[i] =3D ctrl->default_value; + ptr.p_u32[i] =3D value; } else { memset(ptr.p_u32 + from_idx, 0, elems * sizeof(u32)); } break; default: - for (i =3D from_idx; i < tot_elems; i++) - std_init_compound(ctrl, i, ptr); + for (i =3D from_idx; i < tot_elems; i++) { + switch (which) { + case V4L2_CTRL_WHICH_DEF_VAL: + std_init_compound(ctrl, i, ptr); + break; + case V4L2_CTRL_WHICH_MAX_VAL: + std_max_compound(ctrl, i, ptr); + break; + case V4L2_CTRL_WHICH_MIN_VAL: + std_min_compound(ctrl, i, ptr); + break; + } + } break; } } + +void v4l2_ctrl_type_op_init(const struct v4l2_ctrl *ctrl, u32 from_idx, + union v4l2_ctrl_ptr ptr) +{ + __v4l2_ctrl_type_op_init(ctrl, from_idx, V4L2_CTRL_WHICH_DEF_VAL, ptr); +} EXPORT_SYMBOL(v4l2_ctrl_type_op_init); =20 +static void v4l2_ctrl_type_op_minimum(const struct v4l2_ctrl *ctrl, + u32 from_idx, union v4l2_ctrl_ptr ptr) +{ + __v4l2_ctrl_type_op_init(ctrl, from_idx, V4L2_CTRL_WHICH_MIN_VAL, ptr); +} + +static void v4l2_ctrl_type_op_maximum(const struct v4l2_ctrl *ctrl, + u32 from_idx, union v4l2_ctrl_ptr ptr) +{ + __v4l2_ctrl_type_op_init(ctrl, from_idx, V4L2_CTRL_WHICH_MAX_VAL, ptr); +} + void v4l2_ctrl_type_op_log(const struct v4l2_ctrl *ctrl) { union v4l2_ctrl_ptr ptr =3D ctrl->p_cur; @@ -1296,6 +1362,8 @@ EXPORT_SYMBOL(v4l2_ctrl_type_op_validate); static const struct v4l2_ctrl_type_ops std_type_ops =3D { .equal =3D v4l2_ctrl_type_op_equal, .init =3D v4l2_ctrl_type_op_init, + .minimum =3D v4l2_ctrl_type_op_minimum, + .maximum =3D v4l2_ctrl_type_op_maximum, .log =3D v4l2_ctrl_type_op_log, .validate =3D v4l2_ctrl_type_op_validate, }; @@ -1768,7 +1836,10 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_c= trl_handler *hdl, s64 min, s64 max, u64 step, s64 def, const u32 dims[V4L2_CTRL_MAX_DIMS], u32 elem_size, u32 flags, const char * const *qmenu, - const s64 *qmenu_int, const union v4l2_ctrl_ptr p_def, + const s64 *qmenu_int, + const union v4l2_ctrl_ptr p_def, + const union v4l2_ctrl_ptr p_min, + const union v4l2_ctrl_ptr p_max, void *priv) { struct v4l2_ctrl *ctrl; @@ -1892,6 +1963,12 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_c= trl_handler *hdl, break; } =20 + if (type < V4L2_CTRL_COMPOUND_TYPES && + type !=3D V4L2_CTRL_TYPE_BUTTON && + type !=3D V4L2_CTRL_TYPE_CTRL_CLASS && + type !=3D V4L2_CTRL_TYPE_STRING) + flags |=3D V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX; + /* Sanity checks */ if (id =3D=3D 0 || name =3D=3D NULL || !elem_size || id >=3D V4L2_CID_PRIVATE_BASE || @@ -1900,6 +1977,7 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_ct= rl_handler *hdl, handler_set_err(hdl, -ERANGE); return NULL; } + err =3D check_range(type, min, max, step, def); if (err) { handler_set_err(hdl, err); @@ -1941,6 +2019,10 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_c= trl_handler *hdl, =20 if (type >=3D V4L2_CTRL_COMPOUND_TYPES && p_def.p_const) sz_extra +=3D elem_size; + if (type >=3D V4L2_CTRL_COMPOUND_TYPES && p_min.p_const) + sz_extra +=3D elem_size; + if (type >=3D V4L2_CTRL_COMPOUND_TYPES && p_max.p_const) + sz_extra +=3D elem_size; =20 ctrl =3D kvzalloc(sizeof(*ctrl) + sz_extra, GFP_KERNEL); if (ctrl =3D=3D NULL) { @@ -2006,6 +2088,22 @@ static struct v4l2_ctrl *v4l2_ctrl_new(struct v4l2_c= trl_handler *hdl, memcpy(ctrl->p_def.p, p_def.p_const, elem_size); } =20 + if (flags & V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX) { + void *ptr =3D ctrl->p_def.p; + + if (p_min.p_const) { + ptr +=3D elem_size; + ctrl->p_min.p =3D ptr; + memcpy(ctrl->p_min.p, p_min.p_const, elem_size); + } + + if (p_max.p_const) { + ptr +=3D elem_size; + ctrl->p_max.p =3D ptr; + memcpy(ctrl->p_max.p, p_max.p_const, elem_size); + } + } + ctrl->type_ops->init(ctrl, 0, ctrl->p_cur); cur_to_new(ctrl); =20 @@ -2056,7 +2154,8 @@ struct v4l2_ctrl *v4l2_ctrl_new_custom(struct v4l2_ct= rl_handler *hdl, type, min, max, is_menu ? cfg->menu_skip_mask : step, def, cfg->dims, cfg->elem_size, - flags, qmenu, qmenu_int, cfg->p_def, priv); + flags, qmenu, qmenu_int, cfg->p_def, cfg->p_min, + cfg->p_max, priv); if (ctrl) ctrl->is_private =3D cfg->is_private; return ctrl; @@ -2081,7 +2180,8 @@ struct v4l2_ctrl *v4l2_ctrl_new_std(struct v4l2_ctrl_= handler *hdl, } return v4l2_ctrl_new(hdl, ops, NULL, id, name, type, min, max, step, def, NULL, 0, - flags, NULL, NULL, ptr_null, NULL); + flags, NULL, NULL, ptr_null, ptr_null, + ptr_null, NULL); } EXPORT_SYMBOL(v4l2_ctrl_new_std); =20 @@ -2114,7 +2214,8 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_menu(struct v4l2_= ctrl_handler *hdl, } return v4l2_ctrl_new(hdl, ops, NULL, id, name, type, 0, max, mask, def, NULL, 0, - flags, qmenu, qmenu_int, ptr_null, NULL); + flags, qmenu, qmenu_int, ptr_null, ptr_null, + ptr_null, NULL); } EXPORT_SYMBOL(v4l2_ctrl_new_std_menu); =20 @@ -2146,7 +2247,8 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_menu_items(struct= v4l2_ctrl_handler *hdl, } return v4l2_ctrl_new(hdl, ops, NULL, id, name, type, 0, max, mask, def, NULL, 0, - flags, qmenu, NULL, ptr_null, NULL); + flags, qmenu, NULL, ptr_null, ptr_null, + ptr_null, NULL); =20 } EXPORT_SYMBOL(v4l2_ctrl_new_std_menu_items); @@ -2154,7 +2256,9 @@ EXPORT_SYMBOL(v4l2_ctrl_new_std_menu_items); /* Helper function for standard compound controls */ struct v4l2_ctrl *v4l2_ctrl_new_std_compound(struct v4l2_ctrl_handler *hdl, const struct v4l2_ctrl_ops *ops, u32 id, - const union v4l2_ctrl_ptr p_def) + const union v4l2_ctrl_ptr p_def, + const union v4l2_ctrl_ptr p_min, + const union v4l2_ctrl_ptr p_max) { const char *name; enum v4l2_ctrl_type type; @@ -2168,7 +2272,7 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_compound(struct v= 4l2_ctrl_handler *hdl, } return v4l2_ctrl_new(hdl, ops, NULL, id, name, type, min, max, step, def, NULL, 0, - flags, NULL, NULL, p_def, NULL); + flags, NULL, NULL, p_def, p_min, p_max, NULL); } EXPORT_SYMBOL(v4l2_ctrl_new_std_compound); =20 @@ -2192,7 +2296,8 @@ struct v4l2_ctrl *v4l2_ctrl_new_int_menu(struct v4l2_= ctrl_handler *hdl, } return v4l2_ctrl_new(hdl, ops, NULL, id, name, type, 0, max, 0, def, NULL, 0, - flags, NULL, qmenu_int, ptr_null, NULL); + flags, NULL, qmenu_int, ptr_null, ptr_null, + ptr_null, NULL); } EXPORT_SYMBOL(v4l2_ctrl_new_int_menu); =20 diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core= /v4l2-ioctl.c index 0304daa8471d..bfdba96e938c 100644 --- a/drivers/media/v4l2-core/v4l2-ioctl.c +++ b/drivers/media/v4l2-core/v4l2-ioctl.c @@ -893,7 +893,9 @@ static bool check_ext_ctrls(struct v4l2_ext_controls *c= , unsigned long ioctl) return false; break; case V4L2_CTRL_WHICH_DEF_VAL: - /* Default value cannot be changed */ + case V4L2_CTRL_WHICH_MIN_VAL: + case V4L2_CTRL_WHICH_MAX_VAL: + /* Default, minimum or maximum value cannot be changed */ if (ioctl =3D=3D VIDIOC_S_EXT_CTRLS || ioctl =3D=3D VIDIOC_TRY_EXT_CTRLS) { c->error_idx =3D c->count; diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index b0db167a3ac4..9ed7be1e696f 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -133,6 +133,8 @@ struct v4l2_ctrl_ops { * * @equal: return true if all ctrl->elems array elements are equal. * @init: initialize the value for array elements from from_idx to ctrl->e= lems. + * @minimum: set the value to the minimum value of the control. + * @maximum: set the value to the maximum value of the control. * @log: log the value. * @validate: validate the value for ctrl->new_elems array elements. * Return 0 on success and a negative value otherwise. @@ -142,6 +144,10 @@ struct v4l2_ctrl_type_ops { union v4l2_ctrl_ptr ptr1, union v4l2_ctrl_ptr ptr2); void (*init)(const struct v4l2_ctrl *ctrl, u32 from_idx, union v4l2_ctrl_ptr ptr); + void (*minimum)(const struct v4l2_ctrl *ctrl, u32 idx, + union v4l2_ctrl_ptr ptr); + void (*maximum)(const struct v4l2_ctrl *ctrl, u32 idx, + union v4l2_ctrl_ptr ptr); void (*log)(const struct v4l2_ctrl *ctrl); int (*validate)(const struct v4l2_ctrl *ctrl, union v4l2_ctrl_ptr ptr); }; @@ -247,6 +253,12 @@ typedef void (*v4l2_ctrl_notify_fnc)(struct v4l2_ctrl = *ctrl, void *priv); * @p_def: The control's default value represented via a union which * provides a standard way of accessing control types * through a pointer (for compound controls only). + * @p_min: The control's minimum value represented via a union which + * provides a standard way of accessing control types + * through a pointer (for compound controls only). + * @p_max: The control's maximum value represented via a union which + * provides a standard way of accessing control types + * through a pointer (for compound controls only). * @p_cur: The control's current value represented via a union which * provides a standard way of accessing control types * through a pointer. @@ -306,6 +318,8 @@ struct v4l2_ctrl { } cur; =20 union v4l2_ctrl_ptr p_def; + union v4l2_ctrl_ptr p_min; + union v4l2_ctrl_ptr p_max; union v4l2_ctrl_ptr p_new; union v4l2_ctrl_ptr p_cur; }; @@ -425,6 +439,8 @@ struct v4l2_ctrl_handler { * @step: The control's step value for non-menu controls. * @def: The control's default value. * @p_def: The control's default value for compound controls. + * @p_min: The control's minimum value for compound controls. + * @p_max: The control's maximum value for compound controls. * @dims: The size of each dimension. * @elem_size: The size in bytes of the control. * @flags: The control's flags. @@ -454,6 +470,8 @@ struct v4l2_ctrl_config { u64 step; s64 def; union v4l2_ctrl_ptr p_def; + union v4l2_ctrl_ptr p_min; + union v4l2_ctrl_ptr p_max; u32 dims[V4L2_CTRL_MAX_DIMS]; u32 elem_size; u32 flags; @@ -723,17 +741,25 @@ struct v4l2_ctrl *v4l2_ctrl_new_std_menu_items(struct= v4l2_ctrl_handler *hdl, * @ops: The control ops. * @id: The control ID. * @p_def: The control's default value. + * @p_min: The control's minimum value. + * @p_max: The control's maximum value. * - * Sames as v4l2_ctrl_new_std(), but with support to compound controls, th= anks - * to the @p_def field. Use v4l2_ctrl_ptr_create() to create @p_def from a - * pointer. Use v4l2_ctrl_ptr_create(NULL) if the default value of the - * compound control should be all zeroes. + * Same as v4l2_ctrl_new_std(), but with support for compound controls. + * To fill in the @p_def, @p_min and @p_max fields, use v4l2_ctrl_ptr_crea= te() + * to convert a pointer to a const union v4l2_ctrl_ptr. + * Use v4l2_ctrl_ptr_create(NULL) if you want the default, minimum or maxi= mum + * value of the compound control to be all zeroes. + * If the compound control does not set the ``V4L2_CTRL_FLAG_HAS_WHICH_MIN= _MAX`` + * flag, then it does not has minimum and maximum values. In that case jus= t use + * v4l2_ctrl_ptr_create(NULL) for the @p_min and @p_max arguments. * */ struct v4l2_ctrl *v4l2_ctrl_new_std_compound(struct v4l2_ctrl_handler *hdl, const struct v4l2_ctrl_ops *ops, u32 id, - const union v4l2_ctrl_ptr p_def); + const union v4l2_ctrl_ptr p_def, + const union v4l2_ctrl_ptr p_min, + const union v4l2_ctrl_ptr p_max); =20 /** * v4l2_ctrl_new_int_menu() - Create a new standard V4L2 integer menu cont= rol. diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index c1c2ae150d30..c8cb2796130f 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -1912,6 +1912,8 @@ struct v4l2_ext_controls { #define V4L2_CTRL_WHICH_CUR_VAL 0 #define V4L2_CTRL_WHICH_DEF_VAL 0x0f000000 #define V4L2_CTRL_WHICH_REQUEST_VAL 0x0f010000 +#define V4L2_CTRL_WHICH_MIN_VAL 0x0f020000 +#define V4L2_CTRL_WHICH_MAX_VAL 0x0f030000 =20 enum v4l2_ctrl_type { V4L2_CTRL_TYPE_INTEGER =3D 1, @@ -2019,6 +2021,7 @@ struct v4l2_querymenu { #define V4L2_CTRL_FLAG_EXECUTE_ON_WRITE 0x0200 #define V4L2_CTRL_FLAG_MODIFY_LAYOUT 0x0400 #define V4L2_CTRL_FLAG_DYNAMIC_ARRAY 0x0800 +#define V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX 0x1000 =20 /* Query flags, to be ORed with the control ID */ #define V4L2_CTRL_FLAG_NEXT_CTRL 0x80000000 --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12F2E210F65 for ; Tue, 10 Dec 2024 09:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823768; cv=none; b=pNibFCGHaiXjGHLmVnEViPLkGiizcbQyapXGhL7d491uoqyk691TWOqe146i/dOPYhLcUVhpBAFdECEoMVc+pGmTXC17xCgvFoqtelmlqJ/QMsTDVNIgeBSkVlr/W701lIZPZOPeyjnq6NN+BVP8ev1ITF8b369O5hAEeNEbneE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823768; c=relaxed/simple; bh=K0DZI4UBFz6Q1LavHWAO5fp1PzEV7p8YAKo5Gp+ADQw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CLtAfyxCPSmaHfTM9r9U4gCwNLQEHi9QhI/Xc7rA7H0rk6Bq3Jv/qz2Hx4uK6cyiVo2bQNjvJ1NOTiL1p3SkrYEK1CdwYtXGQ6R9aPABUu1ORt6yHVBvfIz9Mc+hcSzNodhVGfZunj1tNKxIMyhKshwO7yHhM6H6pmmaHQC175I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ODvp8bFM; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ODvp8bFM" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6d91653e9d7so12286926d6.1 for ; Tue, 10 Dec 2024 01:42:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823766; x=1734428566; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mf5LuVEPO74SAkZYBzrIXfOzplKA9uICYltmS7j18Lk=; b=ODvp8bFMPzJS7ZzEPtMgocFmFvOqb1zUnnsB2AiH7hD71egqUt7xXD/HwGUR3Fi6V2 xFomojbgsFPEHVhB8PQnoqpNwcWZhyeNl1xxCVjZLgORVxV7PHia+dJXP1IfsJvslTgh f42AaaoW03IubAZKLrZMs6qHMqE4ygKvXhqZ4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823766; x=1734428566; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mf5LuVEPO74SAkZYBzrIXfOzplKA9uICYltmS7j18Lk=; b=jUZdgsEAXmDmTX9v421P465k889QH3Z9yl0t1Zz7z+3uMYh9cJdeheJBZxxb7Qd4Mo EtI58aQp/RjUBD+vv9868I2l90xqy/eHsxTlv272NrTxYE8PgQKhSNSAPXGpXJpZFcsd bccKGJcxROYunFqy9gpd/lZAw6OFrlbkU63PBGvCZcVLRCTK29LAukQFZgYVArNNxurz t5+JM/4nsFSwE0jKaukDhL+Fz8YwPT+oKFPm11GansxyMUMbVvizV4YaHHJjaN2G17k4 t5JU58n/B8KFfLcvCH2pqi+pcv4bjXsy7XNVnMI3pBCJxIfH0OARvK5KEbu3VnNzQsfe IAGw== X-Forwarded-Encrypted: i=1; AJvYcCXqoCuSR0Iw6sldHsbIM4IoFBBzYWzXGWGvckPBPHtpAnMHf/L5b1U4lAD7Rq48Z0wf7YK+WjR43BqsZmU=@vger.kernel.org X-Gm-Message-State: AOJu0Yxch8wAfnwSrw63BhLudsG7dbM33nvya8EIdDdTJNiZDfmpN9WS K3yP8NHeflDJZWsuhytGWoWEO4GktM2zNQn1SSR/m7BhHs68gD6Qbikkx+/oqg== X-Gm-Gg: ASbGncv10+NV6nAJeQk7iHRBP3D9+JRfchz2mQwGmR9VpXvXFobPd2RYxwoIwenNGGC 6FImBmnLU0nGdTafQsDot8gTMkD8Nk2SzFot20ZQuk4VYakYkKT1jWnmC476uOqD2CmLVJyDy7A vgneclkFtGlji8dpYHkbtepYb4d02P1/DMMgIHqjFAzoblPxWLTw9JWB/RTeG76PM5zzGH3Zlrg 1YzaNMyUnlsttlHPiEF2RsBX3sSN1D8KrbIeYA8pM6D9Ijp8KfYHLkVhV9EVvQgMn5IcMdEwhBS LfKqo51e+kEDon9D8SGObq5/ewTY X-Google-Smtp-Source: AGHT+IGT4gzfITvLDwHStH5Rg/t89JsU98DuOgF0s+ypUy2x7EUDyd1LNn2KVDFdffsHdPjaiYA0UA== X-Received: by 2002:a05:6214:76b:b0:6d8:8165:ef21 with SMTP id 6a1803df08f44-6d8e727e5f5mr249233116d6.49.1733823766038; Tue, 10 Dec 2024 01:42:46 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:45 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:40 +0000 Subject: [PATCH v16 04/18] media: vivid: Add a rectangle control Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-4-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao , Hans Verkuil X-Mailer: b4 0.13.0 From: Yunke Cao This control represents a generic read/write rectangle. It supports V4L2_CTRL_WHICH_MIN/MAX_VAL. Signed-off-by: Yunke Cao Reviewed-by: Hans Verkuil Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/test-drivers/vivid/vivid-ctrls.c | 34 ++++++++++++++++++++++= ++++ 1 file changed, 34 insertions(+) diff --git a/drivers/media/test-drivers/vivid/vivid-ctrls.c b/drivers/media= /test-drivers/vivid/vivid-ctrls.c index 2b5c8fbcd0a2..57346b714534 100644 --- a/drivers/media/test-drivers/vivid/vivid-ctrls.c +++ b/drivers/media/test-drivers/vivid/vivid-ctrls.c @@ -37,6 +37,7 @@ #define VIVID_CID_U8_PIXEL_ARRAY (VIVID_CID_CUSTOM_BASE + 14) #define VIVID_CID_S32_ARRAY (VIVID_CID_CUSTOM_BASE + 15) #define VIVID_CID_S64_ARRAY (VIVID_CID_CUSTOM_BASE + 16) +#define VIVID_CID_RECT (VIVID_CID_CUSTOM_BASE + 17) =20 #define VIVID_CID_VIVID_BASE (0x00f00000 | 0xf000) #define VIVID_CID_VIVID_CLASS (0x00f00000 | 1) @@ -360,6 +361,38 @@ static const struct v4l2_ctrl_config vivid_ctrl_ro_int= 32 =3D { .step =3D 1, }; =20 +static const struct v4l2_rect rect_def =3D { + .top =3D 100, + .left =3D 200, + .width =3D 300, + .height =3D 400, +}; + +static const struct v4l2_rect rect_min =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1, + .height =3D 1, +}; + +static const struct v4l2_rect rect_max =3D { + .top =3D 0, + .left =3D 0, + .width =3D 1000, + .height =3D 2000, +}; + +static const struct v4l2_ctrl_config vivid_ctrl_rect =3D { + .ops =3D &vivid_user_gen_ctrl_ops, + .id =3D VIVID_CID_RECT, + .name =3D "Rect", + .type =3D V4L2_CTRL_TYPE_RECT, + .flags =3D V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX, + .p_def.p_const =3D &rect_def, + .p_min.p_const =3D &rect_min, + .p_max.p_const =3D &rect_max, +}; + /* Framebuffer Controls */ =20 static int vivid_fb_s_ctrl(struct v4l2_ctrl *ctrl) @@ -1685,6 +1718,7 @@ int vivid_create_controls(struct vivid_dev *dev, bool= show_ccs_cap, dev->int_menu =3D v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_int_menu= , NULL); dev->ro_int32 =3D v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_ro_int32= , NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_area, NULL); + v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_rect, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_array, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u32_dyn_array, NULL); v4l2_ctrl_new_custom(hdl_user_gen, &vivid_ctrl_u16_matrix, NULL); --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42A122153D3 for ; Tue, 10 Dec 2024 09:42:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823777; cv=none; b=jSrAl4MoW2m7F/WKKiaTqTDtb7ZbyjsZJyxFcvKsH43k+DmuztjXyCDxQs9uVZbRFUiLX9bwjC3cPVcsxOsiSv8zF0PX5T4oDSlNBcx/gVrpfxwv06jlh2pmTGHU/wCCeGXp5qIWRePUwF0Kh/QhTQAsJkEITkW8pXrK1e+QfCA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823777; c=relaxed/simple; bh=gv8rUdmSV4UR2dPzdenPsbmaBxNvhydo09k/zl6tPLc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sfhaQ0gWiAqwPE80cDsGIsEwN3w3DbRz1BDlzFQwfzG6Z6dJOxvGRNyO5tIJ12EGXv1Wx77IC14vHCMP2xu9UBQ36TSRmYmb81Z9hREPFyLwG+gR5VFzDrb8Nn+rgX5fU08on/IrTPf+pFdYIsBNYJSIS1yhLDTqDXHhwqc+cpA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=FEX1WuAf; arc=none smtp.client-ip=209.85.222.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FEX1WuAf" Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b6da2d7884so111325585a.1 for ; Tue, 10 Dec 2024 01:42:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823774; x=1734428574; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=aay2950jnBOP0EyAzMLsHhQ9XSwerGPpxxvrerX51do=; b=FEX1WuAfF3HIY3dJGLy7KNWvB6n58yuCwwEFIg6zmlg6mkcUJQAVL9611dzHZSETpr dEOr0dJnzNjDqtN4WxiUHCUbygE72h3pcNAdnh84vfsQtqbLg3DyDkgVgZE+UFBg45fv 2gHI21Bl6sVnZc9YPiZAPB8PLWqrH3hfL797s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823774; x=1734428574; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aay2950jnBOP0EyAzMLsHhQ9XSwerGPpxxvrerX51do=; b=hfypPBkARI/oZFly0PMzQDa9lTvfOey6O6E1Ojk705l7BFLlKjWk7NIe6bJQyBbGb+ mfyfcUwXVnfvN410NSyOCy5YKIffHkdzPzW1Gvig3wWn4XcufDk1E+Bn2PBArcv+mmHV q/2y3oyywc177L+Ify/HnnUoA2CtOc1Ltp0NIhe5b66uoYEMtd2bsFJ8CG2Ynclay7tu OM7Z90XtaWKVnIaac1+Vtn00SFD1Lj29SyEVova/Y5lxCFGZ0P3FYEoX51K21iHNYQev VfPI9hJeFAhLOvMelfhnevTn+hF+7Cb0er8yP4DmFLALXMxD1lGNXQPch4pjj1WurGH9 UIHg== X-Forwarded-Encrypted: i=1; AJvYcCVaSY9qUJmdTGnWISm/v+oaHhSdwKI5u1AD9aP9GSqWXQG1c81lbtL7RRxC4vTG+/ZgZhOV4N0/ESnFins=@vger.kernel.org X-Gm-Message-State: AOJu0YxfGeK0CHfvNIPUuIMJUOz7Bix2Bx/qlMqHQL0vWxr7nLQ1jgmx qnCNhOqjQIfXVSypLpOZNu2nvJsk2UrA1frhpgSG1R+M7UAMUi+TTBjcVd0Imw== X-Gm-Gg: ASbGncsq4ziIvuDzyBZHTs0bMb8F7ebb3yXGWKbRktYzTHPQJC/MAzsbRuRTT7iOkDw hH3a1CFn+zo5Upq3Z7MUV2qRzZkxtxo59rjpQQcHiYCXm5sAqc38LT6Ut3p+FbfBOZvleztSBaJ zpWSZIpHa2huTRJubH/1AJoXCe6kA8Nq/9bLkQrztZEKVE+/MomDicind8q9jElV9arn64hP/uW H16/jYbimIkY1Ayk3ncZBLi4noO5Qsc+r7oJusDTSHr2jjqXjQyS5T8/w1XJHxDMMgszY5XFaDr 5um5CuFNLLvvZQje5d2be6TagdrB X-Google-Smtp-Source: AGHT+IHvsVSX4cF7Uq+tXoU3l7S6TpqvBBTt/QzYkHDT411ehQjvH1Xv2+t0pEkiDu6zBFsC1FpPbA== X-Received: by 2002:a05:620a:2905:b0:7b6:d241:d4ae with SMTP id af79cd13be357-7b6dcebc84fmr718784185a.42.1733823767088; Tue, 10 Dec 2024 01:42:47 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:46 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:41 +0000 Subject: [PATCH v16 05/18] media: uvcvideo: Handle uvc menu translation inside uvc_get_le_value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-5-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 map->get() gets a value from an uvc_control in "UVC format" and converts it to a value that can be consumed by v4l2. Instead of using a special get function for V4L2_CTRL_TYPE_MENU, we were converting from uvc_get_le_value in two different places. Move the conversion to uvc_get_le_value(). Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 77 +++++++++++++++++-------------------= ---- 1 file changed, 32 insertions(+), 45 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index bab9fdac98e6..77f7058ec966 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -862,6 +862,25 @@ static inline void uvc_clear_bit(u8 *data, int bit) data[bit >> 3] &=3D ~(1 << (bit & 7)); } =20 +static s32 uvc_menu_to_v4l2_menu(struct uvc_control_mapping *mapping, s32 = val) +{ + unsigned int i; + + for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i) { + u32 menu_value; + + if (!test_bit(i, &mapping->menu_mask)) + continue; + + menu_value =3D uvc_mapping_get_menu_value(mapping, i); + + if (menu_value =3D=3D val) + return i; + } + + return val; +} + /* * Extract the bit string specified by mapping->offset and mapping->size * from the little-endian data stored at 'data' and return the result as @@ -896,6 +915,16 @@ static s32 uvc_get_le_value(struct uvc_control_mapping= *mapping, if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_SIGNED) value |=3D -(value & (1 << (mapping->size - 1))); =20 + /* If it is a menu, convert from uvc to v4l2. */ + if (mapping->v4l2_type !=3D V4L2_CTRL_TYPE_MENU) + return value; + + switch (query) { + case UVC_GET_CUR: + case UVC_GET_DEF: + return uvc_menu_to_v4l2_menu(mapping, value); + } + return value; } =20 @@ -1060,32 +1089,6 @@ static int uvc_ctrl_populate_cache(struct uvc_video_= chain *chain, return 0; } =20 -static s32 __uvc_ctrl_get_value(struct uvc_control_mapping *mapping, - const u8 *data) -{ - s32 value =3D mapping->get(mapping, UVC_GET_CUR, data); - - if (mapping->v4l2_type =3D=3D V4L2_CTRL_TYPE_MENU) { - unsigned int i; - - for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i) { - u32 menu_value; - - if (!test_bit(i, &mapping->menu_mask)) - continue; - - menu_value =3D uvc_mapping_get_menu_value(mapping, i); - - if (menu_value =3D=3D value) { - value =3D i; - break; - } - } - } - - return value; -} - static int __uvc_ctrl_load_cur(struct uvc_video_chain *chain, struct uvc_control *ctrl) { @@ -1136,8 +1139,8 @@ static int __uvc_ctrl_get(struct uvc_video_chain *cha= in, if (ret < 0) return ret; =20 - *value =3D __uvc_ctrl_get_value(mapping, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); + *value =3D mapping->get(mapping, UVC_GET_CUR, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); =20 return 0; } @@ -1287,7 +1290,6 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, { struct uvc_control_mapping *master_map =3D NULL; struct uvc_control *master_ctrl =3D NULL; - unsigned int i; =20 memset(v4l2_ctrl, 0, sizeof(*v4l2_ctrl)); v4l2_ctrl->id =3D mapping->id; @@ -1330,21 +1332,6 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_ch= ain *chain, v4l2_ctrl->minimum =3D ffs(mapping->menu_mask) - 1; v4l2_ctrl->maximum =3D fls(mapping->menu_mask) - 1; v4l2_ctrl->step =3D 1; - - for (i =3D 0; BIT(i) <=3D mapping->menu_mask; ++i) { - u32 menu_value; - - if (!test_bit(i, &mapping->menu_mask)) - continue; - - menu_value =3D uvc_mapping_get_menu_value(mapping, i); - - if (menu_value =3D=3D v4l2_ctrl->default_value) { - v4l2_ctrl->default_value =3D i; - break; - } - } - return 0; =20 case V4L2_CTRL_TYPE_BOOLEAN: @@ -1592,7 +1579,7 @@ void uvc_ctrl_status_event(struct uvc_video_chain *ch= ain, ctrl->handle =3D NULL; =20 list_for_each_entry(mapping, &ctrl->info.mappings, list) { - s32 value =3D __uvc_ctrl_get_value(mapping, data); + s32 value =3D mapping->get(mapping, UVC_GET_CUR, data); =20 /* * handle may be NULL here if the device sends auto-update --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF3D878F4E for ; Tue, 10 Dec 2024 09:42:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823778; cv=none; b=izJV6YsxDIjNh/altvP65JBYcaQRnwfx2NbBzvPhJ5a7IEWviOyrZy5SvXq3YnunGMBICH3rMh247Z1q4F85mCnSM0hpUZ4D5DnVzWwpt9FI3F24bhWGtPUqqgTA8B9FT2wpVm34KDUGdfR15WeWAkUNjkhfFXvE8cA7B+CBHYI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823778; c=relaxed/simple; bh=u449lsO4Hxwuzsi+uevB0tOEaOX42zxpyNVYt6QiE+Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pjGRvWgJmc9wkv+tGRguZENpTblghnokdC31M97r3rm1pKtHyyBziXulk1vvAwTKFhVal/jS7dLT/R1rl7v/6+1rJoVFxpmoJ7xIX+boysrOpgLu8usisc1zR+/iRt/fJwOq5/KUw0zPalOcN20Q5dALdBHtnjX4ldaJpK3aYAA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=PLz7bCwU; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PLz7bCwU" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-46774573043so11779461cf.2 for ; Tue, 10 Dec 2024 01:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823776; x=1734428576; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CWfbsZInLShg4gyqs0rpMPp74K9ThJEcDiTxSB3xYgo=; b=PLz7bCwUPOjzxNjoeP4Zhx6RcnEpz6azTb0zg1/H5aVLr5fPrUKaZbzYNebuPZQrmO /AtSsiJY7cUyiCcvMXyR0aG/m9OoQ7PHBiyMOQcsDsvCdaKgF/+qiAdbmDJG9466jo5Z 7Gft6p6Y5qQHem+zOsHlvz9CzAuiqG7kb39xE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823776; x=1734428576; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CWfbsZInLShg4gyqs0rpMPp74K9ThJEcDiTxSB3xYgo=; b=F75Pl8DK7sKCW5zR+/gFnjR0zVtZgDz+oCEZS6Vpanh/Uhd4q8/j5Myqx1rp86tO+T /UJugM0IRI1Qj5k4S4leXB9QvtEn8iXen1u+4cqsW0zfhklFpeWKvpGAUmjJjOUMqt8+ rHl1AIHYvXlgCLt2PL/HjWRXPNyoIW5RPyYasakHgLMQb1MQrgFl4zr7+Ynoe6HOvOJu xPTTch3g32pJbe360TaEpADN3pFXSz2RkWWXov/FfiYP7QXR8wrFowZCCWmxWdVmpTXa 8Vi97681p8i1TipDw1DfrJzkyjPZmJZytARjfiN2KHJ9jMHWXML61cq0mHdArGtGYgli wZjw== X-Forwarded-Encrypted: i=1; AJvYcCVCkEFJJh3q0B9MGles6Yq/Q1gyWKPNnMOr79u/k6iIyOmB5IfUh1UOBxo+E7yn6cDCE52ePD9DRtIFqzE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywm7/bcJPYYNKdyPu0oMSRUTXpT0kG1UYSgSszwU5ez9oPx45/m bt6yc5VZJMrrRg+0nvWrEzfoVmtBAJIg1Ivaur9cK1Wes6/r8dg0xw6p7dGmOA== X-Gm-Gg: ASbGncscM4GZhZCrIBHk6fV3Q4fBYmrcnMjcsIWIjojkCZfh3NcjhqV+Ia+PCYeNu9o 6MPI71Ue/QLvJdrqEKfTZKgXjf/K+PqE0qXM7gq0VSmaWZxpB+NgYiQmH+lUmKYApUSkQ/B9ZrG GzldvENeFrh+kMv4V3biUnf9MEDO1HDvqgC4rbCz7h7IbrTiT84smyevzMOFQfQFHdpnK1Hvhv5 mInDcsM73C6/NNh3kRk3y4LuxgRcjD6waWQ7pDI7XdPi2ARwP+4LNZWr3i3C+YOY45NldiyvEfu 20Rx84MiZAx5MamrVZR0dt94q+dY X-Google-Smtp-Source: AGHT+IGuOmp0WbqkpDp2dV3LPmaXUEWbDVLaY4faBYplusjjW5QMSEy+Ggl5P5GPgFHXeQMWUS+EDg== X-Received: by 2002:a05:6214:5087:b0:6d8:8d16:7cf3 with SMTP id 6a1803df08f44-6d91e43ce55mr65152556d6.40.1733823775842; Tue, 10 Dec 2024 01:42:55 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:54 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:42 +0000 Subject: [PATCH v16 06/18] media: uvcvideo: Handle uvc menu translation inside uvc_set_le_value Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-6-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Be consistent with uvc_get_le_value() and do the menu translation there. Note that in this case, the refactor does not provide much... but consistency is a nice feature. Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 30 +++++++++++++++++++----------- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 77f7058ec966..987a9700bed9 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -939,14 +939,22 @@ static void uvc_set_le_value(struct uvc_control_mappi= ng *mapping, int offset =3D mapping->offset; u8 mask; =20 - /* - * According to the v4l2 spec, writing any value to a button control - * should result in the action belonging to the button control being - * triggered. UVC devices however want to see a 1 written -> override - * value. - */ - if (mapping->v4l2_type =3D=3D V4L2_CTRL_TYPE_BUTTON) + switch (mapping->v4l2_type) { + case V4L2_CTRL_TYPE_MENU: + value =3D uvc_mapping_get_menu_value(mapping, value); + break; + case V4L2_CTRL_TYPE_BUTTON: + /* + * According to the v4l2 spec, writing any value to a button + * control should result in the action belonging to the button + * control being triggered. UVC devices however want to see a 1 + * written -> override value. + */ value =3D -1; + break; + default: + break; + } =20 data +=3D offset / 8; offset &=3D 7; @@ -1988,23 +1996,23 @@ int uvc_ctrl_set(struct uvc_fh *handle, if (!test_bit(xctrl->value, &mapping->menu_mask)) return -EINVAL; =20 - value =3D uvc_mapping_get_menu_value(mapping, xctrl->value); - /* * Valid menu indices are reported by the GET_RES request for * UVC controls that support it. */ if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK) { + int val =3D uvc_mapping_get_menu_value(mapping, + xctrl->value); if (!ctrl->cached) { ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) return ret; } =20 - if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & value)) + if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & val)) return -EINVAL; } - + value =3D xctrl->value; break; =20 default: --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 899592153DB for ; Tue, 10 Dec 2024 09:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823779; cv=none; b=IJMxkufDbgcyB3bBtm8h/l/WQ9inOXmVO8SuseVFUWDAMyIcW8WveIRFG37S1/bIRMYZIOtmY8AP8Nr+bMqUN2aOmdH5gtGxpneNKZgrfYSUWMVzMkjBc7Xt7jXEC7dKJ1rPnIqg6SN2ssq1oWerx4WS7/0NhUH4k5ujPkrsZLI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823779; c=relaxed/simple; bh=GtKZpTsdb2dvroqPwQk6P+D+VqxjXsWA4K0LgOtCk+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TVVkfCZc9xZbI/g1xswUWNARfFBS9m68gWfONVARB3S47xdfLVqPCUsw6GT+G0829DhV3YLAxOKhwAZCRy9Yvx6hd3hSEszU+qTIFDKbVbvkfZzke1eSUrZGi4QVC+zAeJKDV40989uxXCqwmrCCY3QP5kqfyC2iFq+SmYuSyGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZBVm9jsu; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZBVm9jsu" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-4676e45234dso10854111cf.0 for ; Tue, 10 Dec 2024 01:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823776; x=1734428576; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rUxdbTzsjHBE16Atfsk1TxmxgMhTKgD4TgYnLbGJtwM=; b=ZBVm9jsuunPVsO/Npib35CfvTPs3OhsMfqN+toWkr/11DzcCrRPTqAMtzETwgq4uaB FeQJ+WyEYzwjy2rdrHy+57nb6dElitH9qoD8haPbmlEA3jNDZEu+NdIEdVubkKtZQanf uM1qvnkk5BJ6RKGAvhd6bg2yxMwqvuF8KUefw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823776; x=1734428576; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rUxdbTzsjHBE16Atfsk1TxmxgMhTKgD4TgYnLbGJtwM=; b=UOzVmV6IOUtDe13SWhV2igHcDAI6nJVr3OxQ8uBoXG/FgpG6k2YkvMuUhkw231BIIF +/JYNIYNjloSTJauOrY5cJ+88Vh4uzytTippzpfsNkjTs7HOme2JxWVyOYUVOEtRPTYn rb3sT7gqKqoQNHtXHl5AdvOGf/ObLtjPz34pehDh7Z3CY5v5Pkit9BL9EVD3SYq4Efos KbHWeYWToDDWW8L7X0dQWc/cpJn8eFBryDSJlL98mqB46fNJM+V4f2RA2CAKVIvmF8To IjPDRIYaikUxrFpAke/5FP/B0kA3rC+rEfeCkY/THAGRRs8t6Y1V+16+fjkOUtITdJ/v ih6A== X-Forwarded-Encrypted: i=1; AJvYcCV3pcPptN6T9uUAMjgPqV+AsaInl5j5aClg3dO+YYOU1Hc9s+vAQRqe1TkpnoI5HeLCxXXz4oHgaRhU1F4=@vger.kernel.org X-Gm-Message-State: AOJu0YykUZMYEI4m1QCL32CcHtjmi66huCg5ZSw9ycsPqy29NfKy2Ewn eG94eSnO/8AWboP+2mz8fFAmeAEwcUBggs5D/N/ZWu5RR0K0WoiLTProH5dEpEltgPR9l0LqPuU = X-Gm-Gg: ASbGnct34vCVnJ+iNFjSsPF6YBmmzKCu56aml7keDrcMrIvIIJTGpZT426YHjuqgU3O KShV4WeHHC7OZ8Qpnq3LafyYs9sO15QLNYXMkTJc46ZkMqlUMESvfgi7csz7lOuK1sUNXyagZ/A uJlbunIGhU859T93bwJPn7Kzn5eG9O5dsWQnbUSWwI2ZUtvA201rMHVmDymGYtV+S8WtBZTqQIT JfTWTFZHSvs2WaQ5csK9eDYEumLjzlZNvjqVa1wMHTJl3Ed+4BRXpmzwgZXavZu8X+oZlIGCo2+ Qq5gEwqydkkhXCXDZM0eKF7vwDNU X-Google-Smtp-Source: AGHT+IFR79c6AfufLGPoblEmwJJEzbibgTXgjSFkUykGZ8Cp3S6Wc8BlYkoUbuSlrw6WDQWkP0jUow== X-Received: by 2002:ad4:5c49:0:b0:6d9:dd:5c5a with SMTP id 6a1803df08f44-6d9213c2296mr47786416d6.23.1733823776610; Tue, 10 Dec 2024 01:42:56 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:56 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:43 +0000 Subject: [PATCH v16 07/18] media: uvcvideo: refactor uvc_ioctl_g_ext_ctrls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-7-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 We want to support fetching the min and max values with g_ext_ctrls, this patch is a preparation for that. Instead of abusing uvc_query_v4l2_ctrl(), add an extra parameter to uvc_ctrl_get, so it can support fetching the default value. Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 21 ++++++++++++++++++--- drivers/media/usb/uvc/uvc_v4l2.c | 28 +++++++++++----------------- drivers/media/usb/uvc/uvcvideo.h | 3 ++- 3 files changed, 31 insertions(+), 21 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 987a9700bed9..12ce7e38d6f6 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1908,8 +1908,8 @@ int __uvc_ctrl_commit(struct uvc_fh *handle, int roll= back, return ret; } =20 -int uvc_ctrl_get(struct uvc_video_chain *chain, - struct v4l2_ext_control *xctrl) +int uvc_ctrl_get(struct uvc_video_chain *chain, u32 which, + struct v4l2_ext_control *xctrl) { struct uvc_control *ctrl; struct uvc_control_mapping *mapping; @@ -1921,7 +1921,22 @@ int uvc_ctrl_get(struct uvc_video_chain *chain, if (ctrl =3D=3D NULL) return -EINVAL; =20 - return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); + switch (which) { + case V4L2_CTRL_WHICH_CUR_VAL: + return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); + case V4L2_CTRL_WHICH_DEF_VAL: + if (!ctrl->cached) { + int ret =3D uvc_ctrl_populate_cache(chain, ctrl); + + if (ret < 0) + return ret; + } + xctrl->value =3D mapping->get(mapping, UVC_GET_DEF, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); + return 0; + } + + return -EINVAL; } =20 int uvc_ctrl_set(struct uvc_fh *handle, diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 97c5407f6603..02fd5cbc3474 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1078,34 +1078,28 @@ static int uvc_ioctl_g_ext_ctrls(struct file *file,= void *fh, struct uvc_video_chain *chain =3D handle->chain; struct v4l2_ext_control *ctrl =3D ctrls->controls; unsigned int i; + u32 which; int ret; =20 + switch (ctrls->which) { + case V4L2_CTRL_WHICH_DEF_VAL: + case V4L2_CTRL_WHICH_CUR_VAL: + which =3D ctrls->which; + break; + default: + which =3D V4L2_CTRL_WHICH_CUR_VAL; + } + ret =3D uvc_ctrl_check_access(chain, ctrls, VIDIOC_G_EXT_CTRLS); if (ret < 0) return ret; =20 - if (ctrls->which =3D=3D V4L2_CTRL_WHICH_DEF_VAL) { - for (i =3D 0; i < ctrls->count; ++ctrl, ++i) { - struct v4l2_queryctrl qc =3D { .id =3D ctrl->id }; - - ret =3D uvc_query_v4l2_ctrl(chain, &qc); - if (ret < 0) { - ctrls->error_idx =3D i; - return ret; - } - - ctrl->value =3D qc.default_value; - } - - return 0; - } - ret =3D uvc_ctrl_begin(chain); if (ret < 0) return ret; =20 for (i =3D 0; i < ctrls->count; ++ctrl, ++i) { - ret =3D uvc_ctrl_get(chain, ctrl); + ret =3D uvc_ctrl_get(chain, which, ctrl); if (ret < 0) { uvc_ctrl_rollback(handle); ctrls->error_idx =3D i; diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 07f9921d83f2..6ebaabd11443 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -788,7 +788,8 @@ static inline int uvc_ctrl_rollback(struct uvc_fh *hand= le) return __uvc_ctrl_commit(handle, 1, NULL); } =20 -int uvc_ctrl_get(struct uvc_video_chain *chain, struct v4l2_ext_control *x= ctrl); +int uvc_ctrl_get(struct uvc_video_chain *chain, u32 which, + struct v4l2_ext_control *xctrl); int uvc_ctrl_set(struct uvc_fh *handle, struct v4l2_ext_control *xctrl); int uvc_ctrl_is_accessible(struct uvc_video_chain *chain, u32 v4l2_id, const struct v4l2_ext_controls *ctrls, --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9565E2153E9 for ; Tue, 10 Dec 2024 09:42:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823780; cv=none; b=D6+EMbNQYudp8StcY8Y0OI9wyk0R3nT40414QpnB7+jXqJtIAPvxE9qgjOs7UImf9dJNNjJd0ZrmASv7V3Q5H9/Ao00Esifww4USLUgkBl08aSVV8XC/hVIS6wJ52SLUs1Ez6tqFaz9cNfNTVEUW64gdo3ZhtODpuPvzmsU4KYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823780; c=relaxed/simple; bh=7tx9tY1TZ7Mz0s7zOjD3n2wpSrIQUzX0lYUD2DrQrH8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eeCxhWSjQoie5hDzEWAUMpOSsLhSZmTlsI+IChV4435rMDCZ0hLQ+rLtnDvm6c4uGFgvAS9gHLmyHXWB4l326fe3Jcjirrf1G6X/X55MBhF3YvHtDDdrPIR63HsvCAfdn1JgTAM8TRt7nqcvHByWypOV++w1y3GE6dKtLzzPDyI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=euKxpdUE; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="euKxpdUE" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7b6d23b1449so196607385a.2 for ; Tue, 10 Dec 2024 01:42:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823777; x=1734428577; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=L0JByQfuAg+uD0hv4jRjMFUtllhDg1QrDpBOUHpuPvE=; b=euKxpdUEsJYHEKCJGkqnp1gCNHgT167YD9udhT/UygtsJyV1glI6qwyugzxU2y/GWI PHfG29ebCrVh3G4OCRM7Mgg2WEI/jip3dl/a/TMZ+n9CxAqBxbhs4hymXrggUpd5CtuC hCIrHihTL/1+yC7ms9c+CvkThFkodQ7jlBYu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823777; x=1734428577; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L0JByQfuAg+uD0hv4jRjMFUtllhDg1QrDpBOUHpuPvE=; b=ZOMBsD/QDleBxcga5X2A8IRdsRHQcvi5pyPbWA9NL9RJ4K3bw3uYKpNGCtV+/82Cgp PWbxd04Nsd6/+2ZhxdjwgoChcOk8q0MipoPu9SOWn4jOSQW59oIVg6wIPr07YE7eeoJQ K2GKuA75Mw++BgMM1DP/HQ99h1SbX43kQvStlK2egYOIKBgtOuISLAkFNFIuyJ1ji+95 wCpIE5aomHJ2WaLxDfzWxDj/Fyiru6co4JumHLMN5YysJWmoagDMnwLW82xFEIhUyW/1 +WB/mnhkeP8E6154TT212ZgK+2ZZBUe9zfH3T5hhsNaM18m4XRAC9VAjRsCbKHhZV1fm SpIg== X-Forwarded-Encrypted: i=1; AJvYcCUXPpBSqguKC1mgJ3T5QAAWWiUyEKD6D4PK83j/VXtkCVaQLeZulDP0GI3j4MZlWVc221/2D6tr5W4N/h4=@vger.kernel.org X-Gm-Message-State: AOJu0YxADeEWwPdZDoK18kpPXn4Re498s+g/dggl4kGmCxS8dEEBABs1 kOn+/7MdbCljkP4JxfkExbfNX094BIUDZJSmemiHpSfTXpkMMSmSgpF8C7P0Dg== X-Gm-Gg: ASbGncvDJn8ViKvvBQLyV+yWynKq96ihQs6Z/KWWGT8+emh8Ivo8ea1Kr76EFAmOo6z NZxDF7GVIweklAbcoMQoOlDaxbnRgr+dxk9O/C2485inJgyYCsYFkEHGk42JFeT1P5JzCU7WVFE Gioo/og22cDZ6VIsm1580QcRtHfygfiz0JkaXSt9NTKdj+g8E6qExGEosAg1ixXXEmjgmcv4XEX 3rIOOsBl4G8woDhhZHFLv6LvHU7U002BxHHdL2vxwInITBjk6R/iiK6UKoM45jm/V5RAiBZo1MI 56LNub5BI9QAhwx6jIZGE1T8bliw X-Google-Smtp-Source: AGHT+IExR45IaZ1efaic3FpvsqoapdjA78ZUgUcbHZEtkDM1i3ZvkPfWr958oENOEkerIrjSg+Bv6g== X-Received: by 2002:a05:620a:1922:b0:7b6:d910:5b1a with SMTP id af79cd13be357-7b6dce94fa9mr608857985a.42.1733823777521; Tue, 10 Dec 2024 01:42:57 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:56 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:44 +0000 Subject: [PATCH v16 08/18] media: uvcvideo: uvc_ioctl_(g|s)_ext_ctrls: handle NoP case Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-8-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 If nothing needs to be done. Exit early. Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 02fd5cbc3474..65dbb53b1e75 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1081,6 +1081,9 @@ static int uvc_ioctl_g_ext_ctrls(struct file *file, v= oid *fh, u32 which; int ret; =20 + if (!ctrls->count) + return 0; + switch (ctrls->which) { case V4L2_CTRL_WHICH_DEF_VAL: case V4L2_CTRL_WHICH_CUR_VAL: @@ -1121,6 +1124,9 @@ static int uvc_ioctl_s_try_ext_ctrls(struct uvc_fh *h= andle, unsigned int i; int ret; =20 + if (!ctrls->count) + return 0; + ret =3D uvc_ctrl_check_access(chain, ctrls, ioctl); if (ret < 0) return ret; --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41E8E2153FB for ; Tue, 10 Dec 2024 09:42:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823781; cv=none; b=EfabpwDJkfJKK7ejd8HyKKHwg2ed4wTgLZFBzn0Sey+Na7dZu8MN/l5uQC6m5RPtkaIBfG0H79zAD0QuX8MbmEE97DbiEcQZQC9/xCCevw65d7QqN1ehPtuUXpHaG3P559DQ3vTUP0DtAH1M3P9tHIg/Jpv9RlJJBJkGmoQ2fFc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823781; c=relaxed/simple; bh=4xbVKX6i7so/xLpTZa/XjbZr4+Bsicj6dDAFUgCiOPQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sWTAvDKQESgHEYSp2A48By0dn7F7h1RFhKlyR1uEcSBZSvKAAk+dUXl5zcQ3gt4l8rAt9enepAFbwWbGaIb8pkfPfQAvHH4j4+skR9e6m6zu+QlYr6e/9ZBkr2lR3ymGmvY6wBrzaOU7sU2UnVRIO9cXLq4t6WPFbANQ+BWpvVM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=GQNS8Reu; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="GQNS8Reu" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6d87ab49423so52345216d6.0 for ; Tue, 10 Dec 2024 01:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823778; x=1734428578; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BFj66RyTk6sqT9V9Y9d3LeaKrBJRM9mSw2F5nWt5/Tw=; b=GQNS8ReuQ4z/uRrHUQbCHlnTcr1i9t3zuY5UUu6cFFBl5i1dGCWj8gt8iRim4oRu0r OVurlvRPnUgZ7yTfpR03E+D+cTFHyG5TNcU8uHsshoOuJXdYFeD7+t5eOd/5ZdlMV9Kd i++09WD2ybdh1VD9/lN6w8dQMQ4cBgXIG03tE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823778; x=1734428578; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BFj66RyTk6sqT9V9Y9d3LeaKrBJRM9mSw2F5nWt5/Tw=; b=ewuPW7neuwNFqJpxWr02dlQtbfmsu5vqEP0C5MQ/SkcNRCcpao43cmuIMWkQWcftoo Zd45d/KZ5Bc7F412IfCqex2e08Ug7i0rYyxXJQJmdrOv6YvvXlcwLfzLBVnAPuiaSwxY dMBpTcx47azRiqhv/CCAJFAQiAjnnxQBverOSCVeuGf88AD33OC1laOP5+hdzdxX/fop vvmG7fbCxaPXOYp83rU0VJgQb8EQHKUiGKX4wTNf2JcbT6ae2FbCH53NWlsOI+iJkoCa GtmJfhWScY23HqEiqshENRKqk8aPNSfoxw+QEXduZLvrrwXbNIcEMT1CXOuQaUQ/4VT+ nB4g== X-Forwarded-Encrypted: i=1; AJvYcCUStA0jlZa43a+Vk7aRcd4UGfXwkZGgkfMIQ5BL/KyGdjE7xb0DsB+MaUVxeg/0Txg1Az6A1es8mCU7Ex0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3Kf7eHzpA2AZywwXFcYDv9L2uFJqieVgoIvYI9bt3fW1aYl7p D92EQ1SOYGj/pQYawLqhePWU3hoEclSBy4633fpgooziVvdkhxBPL8rgk8m9QQ== X-Gm-Gg: ASbGnct17UCYyHpcaGV+bj3JWdSxxHmtVX9uOKNBG3vI2HPD9CYKWRdvbRFzSSvlPUq oxdFW21cmxo59xUHWmCLbls1rKHOafgCeIYdNDSbNE4+huTkBmvkkeu+sZI8ORmrkW6fLCgMHwk 3EznFjN0kaBnH79yjg7fI8IalS5D6cmmSFkMwWLNjvZZ+kW2K1HZpzzJ8EukjwNmOhm+4MVewXG 9uiC3Ywbtyz7wWq4xWMjyg/kLxqg+APKeH3DTk1q6fuii2U8mblazj7aCbZDxCWpogO2ATqI1JG XGNkrDzBrHAAkcSnl1b/6X3tC5Li X-Google-Smtp-Source: AGHT+IHYM3HgfWV26yqIYegG7eG1m3LG+GjVuVqNl6AyxQo8dS/maLswppMMcvwBORh7NXSiVEHMOA== X-Received: by 2002:a05:6214:d8d:b0:6d4:1f6d:695f with SMTP id 6a1803df08f44-6d91e2d2d35mr80814336d6.2.1733823778212; Tue, 10 Dec 2024 01:42:58 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:57 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:45 +0000 Subject: [PATCH v16 09/18] media: uvcvideo: Support any size for mapping get/set Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-9-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Right now, we only support mappings for v4l2 controls with a max size of s32. This patch modifies the prototype of get/set so it can support any size. This is done to prepare for compound controls. Suggested-by: Laurent Pinchart Reviewed-by: Yunke Cao Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 181 +++++++++++++++++++++++++++--------= ---- drivers/media/usb/uvc/uvcvideo.h | 8 +- 2 files changed, 130 insertions(+), 59 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 12ce7e38d6f6..8fc83961c76e 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -367,6 +367,22 @@ static const u32 uvc_control_classes[] =3D { =20 static const int exposure_auto_mapping[] =3D { 2, 1, 4, 8 }; =20 +static s32 uvc_mapping_get_s32(struct uvc_control_mapping *mapping, + u8 query, const void *data_in) +{ + s32 data_out =3D 0; + + mapping->get(mapping, query, data_in, sizeof(data_out), &data_out); + + return data_out; +} + +static void uvc_mapping_set_s32(struct uvc_control_mapping *mapping, + s32 data_in, void *data_out) +{ + mapping->set(mapping, sizeof(data_in), &data_in, data_out); +} + /* * This function translates the V4L2 menu index @idx, as exposed to usersp= ace as * the V4L2 control value, to the corresponding UVC control value used by = the @@ -405,58 +421,93 @@ uvc_mapping_get_menu_name(const struct uvc_control_ma= pping *mapping, u32 idx) return v4l2_ctrl_get_menu(mapping->id)[idx]; } =20 -static s32 uvc_ctrl_get_zoom(struct uvc_control_mapping *mapping, - u8 query, const u8 *data) +static int uvc_ctrl_get_zoom(struct uvc_control_mapping *mapping, u8 query, + const void *uvc_in, size_t v4l2_size, + void *v4l2_out) { - s8 zoom =3D (s8)data[0]; + u8 value =3D ((u8 *)uvc_in)[2]; + s8 sign =3D ((s8 *)uvc_in)[0]; + s32 *out =3D v4l2_out; + + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; =20 switch (query) { case UVC_GET_CUR: - return (zoom =3D=3D 0) ? 0 : (zoom > 0 ? data[2] : -data[2]); + *out =3D (sign =3D=3D 0) ? 0 : (sign > 0 ? value : -value); + return 0; =20 case UVC_GET_MIN: case UVC_GET_MAX: case UVC_GET_RES: case UVC_GET_DEF: default: - return data[2]; + *out =3D value; + return 0; } } =20 -static void uvc_ctrl_set_zoom(struct uvc_control_mapping *mapping, - s32 value, u8 *data) +static int uvc_ctrl_set_zoom(struct uvc_control_mapping *mapping, + size_t v4l2_size, const void *v4l2_in, + void *uvc_out) { - data[0] =3D value =3D=3D 0 ? 0 : (value > 0) ? 1 : 0xff; - data[2] =3D min((int)abs(value), 0xff); + u8 *out =3D uvc_out; + s32 value; + + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; + + value =3D *(u32 *)v4l2_in; + out[0] =3D value =3D=3D 0 ? 0 : (value > 0) ? 1 : 0xff; + out[2] =3D min_t(int, abs(value), 0xff); + + return 0; } =20 -static s32 uvc_ctrl_get_rel_speed(struct uvc_control_mapping *mapping, - u8 query, const u8 *data) +static int uvc_ctrl_get_rel_speed(struct uvc_control_mapping *mapping, + u8 query, const void *uvc_in, + size_t v4l2_size, void *v4l2_out) { unsigned int first =3D mapping->offset / 8; - s8 rel =3D (s8)data[first]; + u8 value =3D ((u8 *)uvc_in)[first + 1]; + s8 sign =3D ((s8 *)uvc_in)[first]; + s32 *out =3D v4l2_out; + + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; =20 switch (query) { case UVC_GET_CUR: - return (rel =3D=3D 0) ? 0 : (rel > 0 ? data[first+1] - : -data[first+1]); + *out =3D (sign =3D=3D 0) ? 0 : (sign > 0 ? value : -value); + return 0; case UVC_GET_MIN: - return -data[first+1]; + *out =3D -value; + return 0; case UVC_GET_MAX: case UVC_GET_RES: case UVC_GET_DEF: default: - return data[first+1]; + *out =3D value; + return 0; } } =20 -static void uvc_ctrl_set_rel_speed(struct uvc_control_mapping *mapping, - s32 value, u8 *data) +static int uvc_ctrl_set_rel_speed(struct uvc_control_mapping *mapping, + size_t v4l2_size, const void *v4l2_in, + void *uvc_out) { unsigned int first =3D mapping->offset / 8; + u8 *out =3D uvc_out; + s32 value; + + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; + + value =3D *(u32 *)v4l2_in; + out[first] =3D value =3D=3D 0 ? 0 : (value > 0) ? 1 : 0xff; + out[first + 1] =3D min_t(int, abs(value), 0xff); =20 - data[first] =3D value =3D=3D 0 ? 0 : (value > 0) ? 1 : 0xff; - data[first+1] =3D min_t(int, abs(value), 0xff); + return 0; } =20 static const struct uvc_control_mapping uvc_ctrl_power_line_mapping_limite= d =3D { @@ -887,14 +938,20 @@ static s32 uvc_menu_to_v4l2_menu(struct uvc_control_m= apping *mapping, s32 val) * a signed 32bit integer. Sign extension will be performed if the mapping * references a signed data type. */ -static s32 uvc_get_le_value(struct uvc_control_mapping *mapping, - u8 query, const u8 *data) +static int uvc_get_le_value(struct uvc_control_mapping *mapping, + u8 query, const void *uvc_in, size_t v4l2_size, + void *v4l2_out) { - int bits =3D mapping->size; int offset =3D mapping->offset; + int bits =3D mapping->size; + const u8 *data =3D uvc_in; + s32 *out =3D v4l2_out; s32 value =3D 0; u8 mask; =20 + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; + data +=3D offset / 8; offset &=3D 7; mask =3D ((1LL << bits) - 1) << offset; @@ -916,29 +973,41 @@ static s32 uvc_get_le_value(struct uvc_control_mappin= g *mapping, value |=3D -(value & (1 << (mapping->size - 1))); =20 /* If it is a menu, convert from uvc to v4l2. */ - if (mapping->v4l2_type !=3D V4L2_CTRL_TYPE_MENU) - return value; + if (mapping->v4l2_type !=3D V4L2_CTRL_TYPE_MENU) { + *out =3D value; + return 0; + } =20 switch (query) { case UVC_GET_CUR: case UVC_GET_DEF: - return uvc_menu_to_v4l2_menu(mapping, value); + *out =3D uvc_menu_to_v4l2_menu(mapping, value); + return 0; } =20 - return value; + *out =3D value; + return 0; } =20 /* * Set the bit string specified by mapping->offset and mapping->size * in the little-endian data stored at 'data' to the value 'value'. */ -static void uvc_set_le_value(struct uvc_control_mapping *mapping, - s32 value, u8 *data) +static int uvc_set_le_value(struct uvc_control_mapping *mapping, + size_t v4l2_size, const void *v4l2_in, + void *uvc_out) { - int bits =3D mapping->size; int offset =3D mapping->offset; + int bits =3D mapping->size; + u8 *data =3D uvc_out; + s32 value; u8 mask; =20 + if (WARN_ON(v4l2_size !=3D sizeof(s32))) + return -EINVAL; + + value =3D *(s32 *)v4l2_in; + switch (mapping->v4l2_type) { case V4L2_CTRL_TYPE_MENU: value =3D uvc_mapping_get_menu_value(mapping, value); @@ -966,6 +1035,8 @@ static void uvc_set_le_value(struct uvc_control_mappin= g *mapping, bits -=3D 8 - offset; offset =3D 0; } + + return 0; } =20 /* ------------------------------------------------------------------------ @@ -1147,8 +1218,8 @@ static int __uvc_ctrl_get(struct uvc_video_chain *cha= in, if (ret < 0) return ret; =20 - *value =3D mapping->get(mapping, UVC_GET_CUR, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); + *value =3D uvc_mapping_get_s32(mapping, UVC_GET_CUR, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); =20 return 0; } @@ -1281,12 +1352,12 @@ static u32 uvc_get_ctrl_bitmap(struct uvc_control *= ctrl, * as supported. */ if (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES) - return mapping->get(mapping, UVC_GET_RES, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + return uvc_mapping_get_s32(mapping, UVC_GET_RES, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX) - return mapping->get(mapping, UVC_GET_MAX, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); + return uvc_mapping_get_s32(mapping, UVC_GET_MAX, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); =20 return ~0; } @@ -1331,8 +1402,8 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, } =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF) { - v4l2_ctrl->default_value =3D mapping->get(mapping, UVC_GET_DEF, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); + v4l2_ctrl->default_value =3D uvc_mapping_get_s32(mapping, + UVC_GET_DEF, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); } =20 switch (mapping->v4l2_type) { @@ -1365,16 +1436,16 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_c= hain *chain, } =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MIN) - v4l2_ctrl->minimum =3D mapping->get(mapping, UVC_GET_MIN, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN)); + v4l2_ctrl->minimum =3D uvc_mapping_get_s32(mapping, UVC_GET_MIN, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN)); =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX) - v4l2_ctrl->maximum =3D mapping->get(mapping, UVC_GET_MAX, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); + v4l2_ctrl->maximum =3D uvc_mapping_get_s32(mapping, UVC_GET_MAX, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES) - v4l2_ctrl->step =3D mapping->get(mapping, UVC_GET_RES, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + v4l2_ctrl->step =3D uvc_mapping_get_s32(mapping, UVC_GET_RES, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); =20 return 0; } @@ -1587,7 +1658,7 @@ void uvc_ctrl_status_event(struct uvc_video_chain *ch= ain, ctrl->handle =3D NULL; =20 list_for_each_entry(mapping, &ctrl->info.mappings, list) { - s32 value =3D mapping->get(mapping, UVC_GET_CUR, data); + s32 value =3D uvc_mapping_get_s32(mapping, UVC_GET_CUR, data); =20 /* * handle may be NULL here if the device sends auto-update @@ -1931,8 +2002,8 @@ int uvc_ctrl_get(struct uvc_video_chain *chain, u32 w= hich, if (ret < 0) return ret; } - xctrl->value =3D mapping->get(mapping, UVC_GET_DEF, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); + xctrl->value =3D uvc_mapping_get_s32(mapping, UVC_GET_DEF, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); return 0; } =20 @@ -1969,12 +2040,12 @@ int uvc_ctrl_set(struct uvc_fh *handle, return ret; } =20 - min =3D mapping->get(mapping, UVC_GET_MIN, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN)); - max =3D mapping->get(mapping, UVC_GET_MAX, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); - step =3D mapping->get(mapping, UVC_GET_RES, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + min =3D uvc_mapping_get_s32(mapping, UVC_GET_MIN, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN)); + max =3D uvc_mapping_get_s32(mapping, UVC_GET_MAX, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); + step =3D uvc_mapping_get_s32(mapping, UVC_GET_RES, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); if (step =3D=3D 0) step =3D 1; =20 @@ -2053,8 +2124,8 @@ int uvc_ctrl_set(struct uvc_fh *handle, ctrl->info.size); } =20 - mapping->set(mapping, value, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); + uvc_mapping_set_s32(mapping, value, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); =20 if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS) ctrl->handle =3D handle; diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 6ebaabd11443..3d32a56c5ff8 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -131,10 +131,10 @@ struct uvc_control_mapping { const struct uvc_control_mapping *(*filter_mapping) (struct uvc_video_chain *chain, struct uvc_control *ctrl); - s32 (*get)(struct uvc_control_mapping *mapping, u8 query, - const u8 *data); - void (*set)(struct uvc_control_mapping *mapping, s32 value, - u8 *data); + int (*get)(struct uvc_control_mapping *mapping, u8 query, + const void *uvc_in, size_t v4l2_size, void *v4l2_out); + int (*set)(struct uvc_control_mapping *mapping, size_t v4l2_size, + const void *v4l2_in, void *uvc_out); }; =20 struct uvc_control { --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AE8321576A for ; Tue, 10 Dec 2024 09:42:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823782; cv=none; b=X3qf9fZGxMVu+AR1TPpypMKFi0eDqul2Di/MOWqQ75IWc2QMUZG1CEDhTkukN0vDjtigHbvQsHRp11DhhRTxaGSIoC4Zklwagif7MQL1Ww5XnG63T9fbs8VsJ3mfqlrDR+AXCOCLcDrjkQghruUR/YRcO5YPdwohgRTDACY/6Ro= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823782; c=relaxed/simple; bh=Vz8bAvwdEEadzQqCLWQ4ZMfQ2c7Ovu4YJ7E9TC+hlEY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XtI8bpBCvBa/EIZQJIyVfcg4eKI7xbPGDy442W4sM847AP5E7Srs1rJZuYj1yS64Kcqg0C8MLk/tF9N9Vr9pgwKgwa+nHuyjdI5Z57JH08hq0LcznWHg41DikOSVIITQo7J/NGauh0XtcxbGoxdWFEiALlx81yPga6cM8JzUShM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Hi3wrvQd; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Hi3wrvQd" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b6e7f04c98so5095785a.2 for ; Tue, 10 Dec 2024 01:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823779; x=1734428579; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=oZ3g5bZEuxcEXI8DiQzHarhSV0V4/CTEhxMXIFDKmOg=; b=Hi3wrvQd/xabDE9mn/qqoC5AginiI1GwZC1B+5dQL6IFuUelPjhfuQcRKMEuOjit36 Ai6qtTiDHcJLENTCxh9Mc5PFq3nIT4esI8pgG9OtJZemwtHUogW/1X4AhhHvjXwZGt3Z b5gnpkvCbD0Ze9VKCIhN49OYxuVvlONSDIGdI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823779; x=1734428579; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oZ3g5bZEuxcEXI8DiQzHarhSV0V4/CTEhxMXIFDKmOg=; b=K/n4iM1TI4QalV7yqjhN2mrpv0M3CMBUFnhbCGeYwUKJz4ogYDCdF4AxhvniZ08wFv cum6wCtisxMA8qgaee7P/IzZeuMD5Jxdq4BbAAYvTuu1Xp2T+8WP0IBOM79yg1dKpeJb H5bdLm+Y/kei5aQMFUzqB2FHxl1orJLEr9QLwwcdgvyQowQsYGh7VHwZ+nwTFuNzZMM9 hBazCmL+DayoBC2N+Hdz8FO/o9eTZHgRi5OcAv3cc4cJWsAYfV+/h9oJl9YEqpdGgcFG lE9v+bM00Ft5xDnqWiAn0SvjII8UXdrj1PQE7jX1P/9ZQ5Imha3yhra3XSia8dv5KpC/ tfIw== X-Forwarded-Encrypted: i=1; AJvYcCWpxIlV4RBwjeOKStRXNRfE03oIb9XTmlvIq/XLJNSat0KIYzT10E8ZamsjKAnD/vnHQBF9jbZfPQHveI0=@vger.kernel.org X-Gm-Message-State: AOJu0YycCPD5SkOJLpdo9RGHtZ3wBHWYBVA7l/iTPIPAMLiTIrZBCJHv 2jNt3Dx+KoyyJDsjWXwLR74MFYi9lVK/MOjbUD576FT93lRXM/SS1KRqHNvEaw== X-Gm-Gg: ASbGnctbtOZ99i6wddN++Ory5aie3XczYGPhIXBnMYPmCvtVFeyKm1hdMy/y6foAEqg 5eaZTjda1UXV+1Qlw4l72uKkQ1JnLsuQyqItjEsd/peFbxWTG3a+5/zk/4uEeANmaJFJmVnacoG 8+rmHCb3JAETAu6DqFeWsUIrOrb3E6lzq5Ai6y9BVaPCArotA8EoyDeigXjcZEUzsdX08x2x3Rq OVPBgClw7Upi4qH56tZgv4UYqZ7MYhHiFvdVp/6TebXsG3TtPcXv50oZVqdCEN264O0mRJHu+vv XFCa0rGHYNTAGPT5iZ3ZAbbOZSyk X-Google-Smtp-Source: AGHT+IF8U35izwV/nHX+p4seSA3KTbcuZ18YbCP8LguOy+GNHTGswMHJMWEvV2Qr2+rCQLe2Ra6Apw== X-Received: by 2002:a05:6214:490:b0:6d4:22fc:ce3e with SMTP id 6a1803df08f44-6d8e71dad68mr241873486d6.44.1733823779121; Tue, 10 Dec 2024 01:42:59 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:58 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:46 +0000 Subject: [PATCH v16 10/18] media: uvcvideo: Factor out clamping from uvc_ctrl_set Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-10-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Move the logic to a separated function. Do not expect any change. This is a preparation for supporting compound controls. Reviewed-by: Yunke Cao Reviewed-by: Hans de Goede Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 82 +++++++++++++++++++++---------------= ---- 1 file changed, 44 insertions(+), 38 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 8fc83961c76e..4d0307b28fa8 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -2010,28 +2010,17 @@ int uvc_ctrl_get(struct uvc_video_chain *chain, u32= which, return -EINVAL; } =20 -int uvc_ctrl_set(struct uvc_fh *handle, - struct v4l2_ext_control *xctrl) +static int uvc_ctrl_clamp(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + s32 *value_in_out) { - struct uvc_video_chain *chain =3D handle->chain; - struct uvc_control *ctrl; - struct uvc_control_mapping *mapping; - s32 value; + s32 value =3D *value_in_out; u32 step; s32 min; s32 max; int ret; =20 - if (__uvc_query_v4l2_class(chain, xctrl->id, 0) >=3D 0) - return -EACCES; - - ctrl =3D uvc_find_control(chain, xctrl->id, &mapping); - if (ctrl =3D=3D NULL) - return -EINVAL; - if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) - return -EACCES; - - /* Clamp out of range values. */ switch (mapping->v4l2_type) { case V4L2_CTRL_TYPE_INTEGER: if (!ctrl->cached) { @@ -2049,14 +2038,13 @@ int uvc_ctrl_set(struct uvc_fh *handle, if (step =3D=3D 0) step =3D 1; =20 - xctrl->value =3D min + DIV_ROUND_CLOSEST((u32)(xctrl->value - min), - step) * step; + value =3D min + DIV_ROUND_CLOSEST((u32)(value - min), step) * step; if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_SIGNED) - xctrl->value =3D clamp(xctrl->value, min, max); + value =3D clamp(value, min, max); else - xctrl->value =3D clamp_t(u32, xctrl->value, min, max); - value =3D xctrl->value; - break; + value =3D clamp_t(u32, value, min, max); + *value_in_out =3D value; + return 0; =20 case V4L2_CTRL_TYPE_BITMASK: if (!ctrl->cached) { @@ -2065,21 +2053,20 @@ int uvc_ctrl_set(struct uvc_fh *handle, return ret; } =20 - xctrl->value &=3D uvc_get_ctrl_bitmap(ctrl, mapping); - value =3D xctrl->value; - break; + value &=3D uvc_get_ctrl_bitmap(ctrl, mapping); + *value_in_out =3D value; + return 0; =20 case V4L2_CTRL_TYPE_BOOLEAN: - xctrl->value =3D clamp(xctrl->value, 0, 1); - value =3D xctrl->value; - break; + *value_in_out =3D clamp(value, 0, 1); + return 0; =20 case V4L2_CTRL_TYPE_MENU: - if (xctrl->value < (ffs(mapping->menu_mask) - 1) || - xctrl->value > (fls(mapping->menu_mask) - 1)) + if (value < (ffs(mapping->menu_mask) - 1) || + value > (fls(mapping->menu_mask) - 1)) return -ERANGE; =20 - if (!test_bit(xctrl->value, &mapping->menu_mask)) + if (!test_bit(value, &mapping->menu_mask)) return -EINVAL; =20 /* @@ -2087,8 +2074,7 @@ int uvc_ctrl_set(struct uvc_fh *handle, * UVC controls that support it. */ if (mapping->data_type =3D=3D UVC_CTRL_DATA_TYPE_BITMASK) { - int val =3D uvc_mapping_get_menu_value(mapping, - xctrl->value); + int val =3D uvc_mapping_get_menu_value(mapping, value); if (!ctrl->cached) { ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) @@ -2098,14 +2084,34 @@ int uvc_ctrl_set(struct uvc_fh *handle, if (!(uvc_get_ctrl_bitmap(ctrl, mapping) & val)) return -EINVAL; } - value =3D xctrl->value; - break; + return 0; =20 default: - value =3D xctrl->value; - break; + return 0; } =20 + return 0; +} + +int uvc_ctrl_set(struct uvc_fh *handle, struct v4l2_ext_control *xctrl) +{ + struct uvc_video_chain *chain =3D handle->chain; + struct uvc_control_mapping *mapping; + struct uvc_control *ctrl; + int ret; + + if (__uvc_query_v4l2_class(chain, xctrl->id, 0) >=3D 0) + return -EACCES; + + ctrl =3D uvc_find_control(chain, xctrl->id, &mapping); + if (!ctrl) + return -EINVAL; + if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) + return -EACCES; + + ret =3D uvc_ctrl_clamp(chain, ctrl, mapping, &xctrl->value); + if (ret) + return ret; /* * If the mapping doesn't span the whole UVC control, the current value * needs to be loaded from the device to perform the read-modify-write @@ -2124,7 +2130,7 @@ int uvc_ctrl_set(struct uvc_fh *handle, ctrl->info.size); } =20 - uvc_mapping_set_s32(mapping, value, + uvc_mapping_set_s32(mapping, xctrl->value, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); =20 if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS) --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A76F215795 for ; Tue, 10 Dec 2024 09:43:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823783; cv=none; b=oPs/UPtW4LCVin/x5GV0U11Ksff/pVPt3j+kenjLuHbgRYr3mRctyWnVGpWDjj9EKDtQrlAQL+ePA3t4WgOufbPk2tdWjBryk7LdDB9hIcsGK/QTKlKJ7d/eQNg9+qxiGVOoSfd3biZxv7oOH+0uvdTZ1/BL4+xaMgcGRJANn5o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823783; c=relaxed/simple; bh=syU3SP1UFRBOFzSKFIOQYfVKkT7l3MfLBIScrqiIV0w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r9E7fiIYoYkNEEK0Laa2UieCABJTMZtXVTxAF3aTLwe0MLAj44w0HVEn50pS27wr2gBAzTAd31lzsSNHOUsz2OAl6uBFkED6P/T0XAODWfxNf4+qN74nbVdd+/OWI8KWbhu2u+zYdGeUTsLgnzD8JR5yYV5w1oYjsPCXY6LmkuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=UsPZUy+A; arc=none smtp.client-ip=209.85.219.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="UsPZUy+A" Received: by mail-qv1-f44.google.com with SMTP id 6a1803df08f44-6d8f1505045so25800336d6.1 for ; Tue, 10 Dec 2024 01:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823780; x=1734428580; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Bkn1FTenh9IoogHBbEytCPJjCzMA63zFkclq+5ZFIRM=; b=UsPZUy+A9GjVyL3fq9jfxdpCwETI14p7exqgCsThobYcx9QDEdfXE9O2kPpShQKkkI Z7lj1KfoiU41aYQ4hk5UhubusPVqsS8UU/emiRSQcOtelMJj7jdZGAxEENcuojQ9wu1X mJSSdFiSDAI9C87zglX19w0dS8zRJ0T0o5RmQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823780; x=1734428580; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bkn1FTenh9IoogHBbEytCPJjCzMA63zFkclq+5ZFIRM=; b=UtGKDwkThaFFOcCJyUmjPGz/UBfxhY9VRlFI9GOlZK60NP8bp06Y2hNjsSpIejFtHm K1By3lFVZFE3fVl2JSDXibUveDOw13LXjKsE8w71fOS7SxLMPTaEYfXW6fzLXMiy56ke ES4+NYZLhct7RtKNhzfG63AgAY1A8NenvsOKFi19r2iuzgQ5jb+wOcmjT63Ca4vpMkBo TIYC/ADgZ31avjKsu+yOaZV992p6G270Xm3DNFB6uUaSQa3G6so3b6Z2TOjj7LeWfUff 83hnpdKszb2yK1lkdwzRrqgz1U6EtQmFIMa1Abt6cv3BwvHlqOlM8ZyubE6IXqklmMmo 03cg== X-Forwarded-Encrypted: i=1; AJvYcCXwEhlJm8vZnk2lPVsdARXzHhmD364hy2A7UCqVgo3ochUfsLaBIKffj5g28tS1h5L48ftkmOVzgHHrLS4=@vger.kernel.org X-Gm-Message-State: AOJu0YyDc/4GnVvryqLUKyDy9aGy4JkrYLHh3kuKozqqIH8bKq0siR+s CRzcy2gzoGrwUXG+Suuims2M2gSCynHx8MUVS4DCXV2lW9dSQNfLbPYNQ/Zi4DyPfoShsQFwfoM = X-Gm-Gg: ASbGncvcbt+WTZvhD70upSrsA6RZAJgGRN+8snZ5aoBYp+yr+p/OAZnWvTiWpKImP/O iwnqX1ijl9VUsj44oz017R6Vbm3tbR7a3Q8OCiAbJYYlGDCVLcond5gnuc5RbNGDfosEW47IFUS En4XBJgf3Fnh/6b58heN8ocUtELPG6/jWSFIXn5sDZ0IgcmCIztWhZxg74BiPLjKBtGQLy5qi6y 0WuxaDuIu5q3EX+e1YFvwiytj4VDFOsC0oRMkx82d7A9RpAIHLCavq0TUOZ4PyRANJJikeq+zaF I5Rh9gERn55PPxXDN1+GBBusEOxB X-Google-Smtp-Source: AGHT+IGXUszI74qq0e9uoefo1xO0lmDcF16DFHbJ0I0zOd9Bd+fviDJXHggCHAlkl2mjD7gP0nC2NA== X-Received: by 2002:a05:6214:4009:b0:6d8:9065:2033 with SMTP id 6a1803df08f44-6d91e435246mr52366936d6.31.1733823779986; Tue, 10 Dec 2024 01:42:59 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.42.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:42:59 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:47 +0000 Subject: [PATCH v16 11/18] media: uvcvideo: add support for compound controls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-11-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 From: Yunke Cao This patch adds support for compound controls. This is required to support controls that cannot be represented with a s64 data, such as the Region of Interest. Signed-off-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 212 +++++++++++++++++++++++++++++++++--= ---- drivers/media/usb/uvc/uvcvideo.h | 5 + 2 files changed, 189 insertions(+), 28 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 4d0307b28fa8..794d5c365352 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -367,6 +367,11 @@ static const u32 uvc_control_classes[] =3D { =20 static const int exposure_auto_mapping[] =3D { 2, 1, 4, 8 }; =20 +static bool uvc_ctrl_mapping_is_compound(struct uvc_control_mapping *mappi= ng) +{ + return mapping->v4l2_type >=3D V4L2_CTRL_COMPOUND_TYPES; +} + static s32 uvc_mapping_get_s32(struct uvc_control_mapping *mapping, u8 query, const void *data_in) { @@ -1055,7 +1060,7 @@ static int uvc_entity_match_guid(const struct uvc_ent= ity *entity, =20 static void __uvc_find_control(struct uvc_entity *entity, u32 v4l2_id, struct uvc_control_mapping **mapping, struct uvc_control **control, - int next) + int next, int next_compound) { struct uvc_control *ctrl; struct uvc_control_mapping *map; @@ -1070,14 +1075,16 @@ static void __uvc_find_control(struct uvc_entity *e= ntity, u32 v4l2_id, continue; =20 list_for_each_entry(map, &ctrl->info.mappings, list) { - if ((map->id =3D=3D v4l2_id) && !next) { + if (map->id =3D=3D v4l2_id && !next && !next_compound) { *control =3D ctrl; *mapping =3D map; return; } =20 if ((*mapping =3D=3D NULL || (*mapping)->id > map->id) && - (map->id > v4l2_id) && next) { + (map->id > v4l2_id) && + (uvc_ctrl_mapping_is_compound(map) ? + next_compound : next)) { *control =3D ctrl; *mapping =3D map; } @@ -1091,6 +1098,7 @@ static struct uvc_control *uvc_find_control(struct uv= c_video_chain *chain, struct uvc_control *ctrl =3D NULL; struct uvc_entity *entity; int next =3D v4l2_id & V4L2_CTRL_FLAG_NEXT_CTRL; + int next_compound =3D v4l2_id & V4L2_CTRL_FLAG_NEXT_COMPOUND; =20 *mapping =3D NULL; =20 @@ -1099,12 +1107,13 @@ static struct uvc_control *uvc_find_control(struct = uvc_video_chain *chain, =20 /* Find the control. */ list_for_each_entry(entity, &chain->entities, chain) { - __uvc_find_control(entity, v4l2_id, mapping, &ctrl, next); - if (ctrl && !next) + __uvc_find_control(entity, v4l2_id, mapping, &ctrl, next, + next_compound); + if (ctrl && !next && !next_compound) return ctrl; } =20 - if (ctrl =3D=3D NULL && !next) + if (!ctrl && !next && !next_compound) uvc_dbg(chain->dev, CONTROL, "Control 0x%08x not found\n", v4l2_id); =20 @@ -1227,7 +1236,8 @@ static int __uvc_ctrl_get(struct uvc_video_chain *cha= in, static int __uvc_query_v4l2_class(struct uvc_video_chain *chain, u32 req_i= d, u32 found_id) { - bool find_next =3D req_id & V4L2_CTRL_FLAG_NEXT_CTRL; + bool find_next =3D req_id & + (V4L2_CTRL_FLAG_NEXT_CTRL | V4L2_CTRL_FLAG_NEXT_COMPOUND); unsigned int i; =20 req_id &=3D V4L2_CTRL_ID_MASK; @@ -1317,10 +1327,12 @@ int uvc_ctrl_is_accessible(struct uvc_video_chain *= chain, u32 v4l2_id, } =20 __uvc_find_control(ctrl->entity, mapping->master_id, &master_map, - &master_ctrl, 0); + &master_ctrl, 0, 0); =20 if (!master_ctrl || !(master_ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) return 0; + if (WARN_ON(uvc_ctrl_mapping_is_compound(master_map))) + return -EIO; =20 ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); if (ret >=3D 0 && val !=3D mapping->master_manual) @@ -1384,10 +1396,15 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_c= hain *chain, =20 if (mapping->master_id) __uvc_find_control(ctrl->entity, mapping->master_id, - &master_map, &master_ctrl, 0); + &master_map, &master_ctrl, 0, 0); if (master_ctrl && (master_ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) { s32 val; - int ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); + int ret; + + if (WARN_ON(uvc_ctrl_mapping_is_compound(master_map))) + return -EIO; + + ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); if (ret < 0) return ret; =20 @@ -1395,6 +1412,15 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_ch= ain *chain, v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_INACTIVE; } =20 + if (v4l2_ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES) { + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_HAS_PAYLOAD; + v4l2_ctrl->default_value =3D 0; + v4l2_ctrl->minimum =3D 0; + v4l2_ctrl->maximum =3D 0; + v4l2_ctrl->step =3D 0; + return 0; + } + if (!ctrl->cached) { int ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) @@ -1635,11 +1661,12 @@ static void uvc_ctrl_send_slave_event(struct uvc_vi= deo_chain *chain, u32 changes =3D V4L2_EVENT_CTRL_CH_FLAGS; s32 val =3D 0; =20 - __uvc_find_control(master->entity, slave_id, &mapping, &ctrl, 0); + __uvc_find_control(master->entity, slave_id, &mapping, &ctrl, 0, 0); if (ctrl =3D=3D NULL) return; =20 - if (__uvc_ctrl_get(chain, ctrl, mapping, &val) =3D=3D 0) + if (uvc_ctrl_mapping_is_compound(mapping) || + __uvc_ctrl_get(chain, ctrl, mapping, &val) =3D=3D 0) changes |=3D V4L2_EVENT_CTRL_CH_VALUE; =20 uvc_ctrl_send_event(chain, handle, ctrl, mapping, val, changes); @@ -1658,7 +1685,12 @@ void uvc_ctrl_status_event(struct uvc_video_chain *c= hain, ctrl->handle =3D NULL; =20 list_for_each_entry(mapping, &ctrl->info.mappings, list) { - s32 value =3D uvc_mapping_get_s32(mapping, UVC_GET_CUR, data); + s32 value; + + if (uvc_ctrl_mapping_is_compound(mapping)) + value =3D 0; + else + value =3D uvc_mapping_get_s32(mapping, UVC_GET_CUR, data); =20 /* * handle may be NULL here if the device sends auto-update @@ -1744,6 +1776,7 @@ static void uvc_ctrl_send_events(struct uvc_fh *handl= e, =20 for (i =3D 0; i < xctrls_count; ++i) { u32 changes =3D V4L2_EVENT_CTRL_CH_VALUE; + s32 value; =20 ctrl =3D uvc_find_control(handle->chain, xctrls[i].id, &mapping); if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS) @@ -1768,6 +1801,10 @@ static void uvc_ctrl_send_events(struct uvc_fh *hand= le, slave_id); } =20 + if (uvc_ctrl_mapping_is_compound(mapping)) + value =3D 0; + else + value =3D xctrls[i].value; /* * If the master is being modified in the same transaction * flags may change too. @@ -1778,7 +1815,7 @@ static void uvc_ctrl_send_events(struct uvc_fh *handl= e, changes |=3D V4L2_EVENT_CTRL_CH_FLAGS; =20 uvc_ctrl_send_event(handle->chain, handle, ctrl, mapping, - xctrls[i].value, changes); + value, changes); } } =20 @@ -1810,7 +1847,8 @@ static int uvc_ctrl_add_event(struct v4l2_subscribed_= event *sev, unsigned elems) u32 changes =3D V4L2_EVENT_CTRL_CH_FLAGS; s32 val =3D 0; =20 - if (__uvc_ctrl_get(handle->chain, ctrl, mapping, &val) =3D=3D 0) + if (uvc_ctrl_mapping_is_compound(mapping) || + __uvc_ctrl_get(handle->chain, ctrl, mapping, &val) =3D=3D 0) changes |=3D V4L2_EVENT_CTRL_CH_VALUE; =20 uvc_ctrl_fill_event(handle->chain, &ev, ctrl, mapping, val, @@ -1943,7 +1981,7 @@ static int uvc_ctrl_find_ctrl_idx(struct uvc_entity *= entity, =20 for (i =3D 0; i < ctrls->count; i++) { __uvc_find_control(entity, ctrls->controls[i].id, &mapping, - &ctrl_found, 0); + &ctrl_found, 0, 0); if (uvc_control =3D=3D ctrl_found) return i; } @@ -1979,19 +2017,64 @@ int __uvc_ctrl_commit(struct uvc_fh *handle, int ro= llback, return ret; } =20 -int uvc_ctrl_get(struct uvc_video_chain *chain, u32 which, - struct v4l2_ext_control *xctrl) +static int uvc_mapping_get_xctrl_compound(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + u32 which, + struct v4l2_ext_control *xctrl) { - struct uvc_control *ctrl; - struct uvc_control_mapping *mapping; - - if (__uvc_query_v4l2_class(chain, xctrl->id, 0) >=3D 0) - return -EACCES; + u8 *data __free(kfree) =3D NULL; + size_t size; + u8 query; + int ret; + int id; =20 - ctrl =3D uvc_find_control(chain, xctrl->id, &mapping); - if (ctrl =3D=3D NULL) + switch (which) { + case V4L2_CTRL_WHICH_CUR_VAL: + ret =3D __uvc_ctrl_load_cur(chain, ctrl); + if (ret < 0) + return ret; + id =3D UVC_CTRL_DATA_CURRENT; + query =3D UVC_GET_CUR; + break; + case V4L2_CTRL_WHICH_DEF_VAL: + ret =3D uvc_ctrl_populate_cache(chain, ctrl); + if (ret < 0) + return ret; + id =3D UVC_CTRL_DATA_DEF; + query =3D UVC_GET_DEF; + break; + default: return -EINVAL; + } + + size =3D DIV_ROUND_UP(mapping->size, 8); + if (xctrl->size < size) { + xctrl->size =3D size; + return -ENOSPC; + } + + data =3D kmalloc(size, GFP_KERNEL); + if (!data) + return -ENOMEM; + + ret =3D mapping->get(mapping, query, uvc_ctrl_data(ctrl, id), size, data); + if (ret < 0) + return ret; + + /* + * v4l2_ext_control does not have enough room to fit a compound control. + * Instead, the value is in the user memory at xctrl->ptr. The v4l2 + * ioctl helper does not copy it for us. + */ + return copy_to_user(xctrl->ptr, data, size) ? -EFAULT : 0; +} =20 +static int uvc_mapping_get_xctrl_std(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + u32 which, struct v4l2_ext_control *xctrl) +{ switch (which) { case V4L2_CTRL_WHICH_CUR_VAL: return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); @@ -2010,6 +2093,33 @@ int uvc_ctrl_get(struct uvc_video_chain *chain, u32 = which, return -EINVAL; } =20 +static int uvc_mapping_get_xctrl(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + u32 which, struct v4l2_ext_control *xctrl) +{ + if (uvc_ctrl_mapping_is_compound(mapping)) + return uvc_mapping_get_xctrl_compound(chain, ctrl, mapping, + which, xctrl); + return uvc_mapping_get_xctrl_std(chain, ctrl, mapping, which, xctrl); +} + +int uvc_ctrl_get(struct uvc_video_chain *chain, u32 which, + struct v4l2_ext_control *xctrl) +{ + struct uvc_control *ctrl; + struct uvc_control_mapping *mapping; + + if (__uvc_query_v4l2_class(chain, xctrl->id, 0) >=3D 0) + return -EACCES; + + ctrl =3D uvc_find_control(chain, xctrl->id, &mapping); + if (!ctrl) + return -EINVAL; + + return uvc_mapping_get_xctrl(chain, ctrl, mapping, which, xctrl); +} + static int uvc_ctrl_clamp(struct uvc_video_chain *chain, struct uvc_control *ctrl, struct uvc_control_mapping *mapping, @@ -2093,6 +2203,42 @@ static int uvc_ctrl_clamp(struct uvc_video_chain *ch= ain, return 0; } =20 +static int uvc_mapping_set_xctrl_compound(struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + struct v4l2_ext_control *xctrl) +{ + u8 *data __free(kfree) =3D NULL; + size_t size; + + size =3D DIV_ROUND_UP(mapping->size, 8); + if (xctrl->size !=3D size) + return -EINVAL; + + /* + * v4l2_ext_control does not have enough room to fit a compound control. + * Instead, the value is in the user memory at xctrl->ptr. The v4l2 + * ioctl helper does not copy it for us. + */ + data =3D memdup_user(xctrl->ptr, size); + if (IS_ERR(data)) + return PTR_ERR(data); + + return mapping->set(mapping, size, data, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); +} + +static int uvc_mapping_set_xctrl(struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + struct v4l2_ext_control *xctrl) +{ + if (uvc_ctrl_mapping_is_compound(mapping)) + return uvc_mapping_set_xctrl_compound(ctrl, mapping, xctrl); + + uvc_mapping_set_s32(mapping, xctrl->value, + uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); + return 0; +} + int uvc_ctrl_set(struct uvc_fh *handle, struct v4l2_ext_control *xctrl) { struct uvc_video_chain *chain =3D handle->chain; @@ -2130,8 +2276,9 @@ int uvc_ctrl_set(struct uvc_fh *handle, struct v4l2_e= xt_control *xctrl) ctrl->info.size); } =20 - uvc_mapping_set_s32(mapping, xctrl->value, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_CURRENT)); + ret =3D uvc_mapping_set_xctrl(ctrl, mapping, xctrl); + if (ret) + return ret; =20 if (ctrl->info.flags & UVC_CTRL_FLAG_ASYNCHRONOUS) ctrl->handle =3D handle; @@ -2509,6 +2656,7 @@ static int __uvc_ctrl_add_mapping(struct uvc_video_ch= ain *chain, struct uvc_control_mapping *map; unsigned int size; unsigned int i; + int ret; =20 /* * Most mappings come from static kernel data, and need to be duplicated. @@ -2549,6 +2697,12 @@ static int __uvc_ctrl_add_mapping(struct uvc_video_c= hain *chain, goto err_nomem; } =20 + if (uvc_ctrl_mapping_is_compound(map)) + if (WARN_ON(!map->set || !map->get)) { + ret =3D -EIO; + goto free_mem; + } + if (map->get =3D=3D NULL) map->get =3D uvc_get_le_value; if (map->set =3D=3D NULL) @@ -2570,11 +2724,13 @@ static int __uvc_ctrl_add_mapping(struct uvc_video_= chain *chain, return 0; =20 err_nomem: + ret =3D -ENOMEM; +free_mem: kfree(map->menu_names); kfree(map->menu_mapping); kfree(map->name); kfree(map); - return -ENOMEM; + return ret; } =20 int uvc_ctrl_add_mapping(struct uvc_video_chain *chain, diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 3d32a56c5ff8..f429f325433b 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -115,7 +115,12 @@ struct uvc_control_mapping { u8 entity[16]; u8 selector; =20 + /* + * Size of the control data in the payload of the UVC control GET and + * SET requests, expressed in bits. + */ u8 size; + u8 offset; enum v4l2_ctrl_type v4l2_type; u32 data_type; --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BE5B234976 for ; Tue, 10 Dec 2024 09:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823784; cv=none; b=cNx8PQicdXt5mPdfzNiNMLDJN8egl6Apq9JLDbKLRYwEMcRB+J8gBbDHybtxIu8yhll+lo7DkZRZ+gohEVSHMRLwesU9h6w5fPiayiWOGArxQpBkG1uIGEswrCkkhdM33dvuXn3UTnfwcnS2E8mJGOY8aKYwDtfzZKJqXGX3cGs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823784; c=relaxed/simple; bh=mfhLeffdilkffQ88aag3azfnh854oo6y05hzwCztGkw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=f9quHHm/xnbnZQJz/JIXMlfBss0zeCn7hx12IWlwIlH3dnP/jKsota8oyPb5KgKQonfQ9YnQlx6kyaYioI2DjWtOJY+QODXgt+Ohki5W8YdrfLh0XdAZSOpovo7LdXpXQiWXD+cgrEmQwL4NcaqN/Ey+2WDKUK3cSc+GIAGo3pU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=O72uzeY5; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="O72uzeY5" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7b6d109bca7so161210285a.0 for ; Tue, 10 Dec 2024 01:43:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823781; x=1734428581; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eiwmj5eM7vigYSm+9Mmo6PKLcpfGimwewDBerK/2fr0=; b=O72uzeY53Yi6lleNdRtJidpfbwDOzxdynO0L/BsPrPv87OikiG42McrjVtYFJWzVcB 77sIWPYueOeHX47wVAqTSwekCDTdnwdIYN0NwweRR6JrqtpZMprN3Em22rcewls/NlpK vpxJ6qI/vhv53qDDB1E1AjUzrN4hN1NU6el2E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823781; x=1734428581; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eiwmj5eM7vigYSm+9Mmo6PKLcpfGimwewDBerK/2fr0=; b=npidrTrX1hbhtl8ykB6Ry/ao7nm5VAE9EWdIKWPBzX7D7vPzqZiYT0Zvnoli+DcjOD o4dw0sVuzgFZNjhIJslUaUhBEu7JhsDx5LPoNBIZhKDXMz367eGV2fbf95HsmNj+p8+t kavkNl9QVFHu/bejpbYjotH264jvv72ev27tXdmIIZl6d0aQ35PpzybOEo0GTxuRSiex Mq/WIipcvKuby/Kc+hPpHN2c5+P/z+eR/Cc15Bwm1lIhqS5xFCRBycx4X7JVKMhtqLGP thLcx+NUF9Rizds8y7HmOZLh3o8cKiqKPIPC69GYAkgaGa9J+3TuBcvnRDl0eYeWagDA HWNw== X-Forwarded-Encrypted: i=1; AJvYcCXADYkZCb6+YNu4fSAXB8WyiDTsMkRtbhNVo/XTHYoL09E6YSkU9MwzTuuczBAsDeuPAgHRESxtZhCZ2gQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxXFnjWr8H1X75/NT/7o2NS+JVVr3ZZydTIOmuY3U0UfGd20zMz cNmj0w4/sHXnZ0YYcq8Cdgp+1IeGVTojk8U+Zy3vbl1/OHWAezXoZHaNLremhA== X-Gm-Gg: ASbGncsKteo4MXRFl0ZieRQ6CsHQ9zD32NEmZliAnZqTdGg+u9uDDg69actwF//+gMV Gzb09xDQ/U3g6znzBnOEuz6OGRl+8y2RS8MPkFN2/aEA5xG4IronAC63/mea6IyU9SmE41MyghZ bSunxKVHOrQDKP+8ZzBlcGDvmzcRHEgrGEFGj1hNrDSPK7LPnr3gXZyso66ld9/fhAO0aKICXKa SSacqfLvjQoHL9ff4tvaiV9cIUd7DmMYxVeuz+BkoGVWzlgRHkY8u8HVI6FbHPBqrNqh+GqVYWi 0S7NWF9JhrXRZ+Uu4DZGD8oG67lD X-Google-Smtp-Source: AGHT+IHpra8NicNX39bLjc8qG29QdCb3vJ/1EaZ3tqQYIlrU6vu2eVYCAwoAIvz2bnvNzvbnqJSOJg== X-Received: by 2002:a05:6214:20aa:b0:6d8:7fe2:8b1e with SMTP id 6a1803df08f44-6d8e741e814mr204079766d6.48.1733823781235; Tue, 10 Dec 2024 01:43:01 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:00 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:48 +0000 Subject: [PATCH v16 12/18] media: uvcvideo: Factor out query_boundaries from query_ctrl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-12-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Split the function in two parts. queryctrl_boundaries will be used in future patches. No functional change expected from this patch. Reviewed-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 106 ++++++++++++++++++++++-------------= ---- 1 file changed, 60 insertions(+), 46 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 794d5c365352..785af382103b 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1374,53 +1374,11 @@ static u32 uvc_get_ctrl_bitmap(struct uvc_control *= ctrl, return ~0; } =20 -static int __uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, - struct uvc_control *ctrl, - struct uvc_control_mapping *mapping, - struct v4l2_queryctrl *v4l2_ctrl) +static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + struct v4l2_queryctrl *v4l2_ctrl) { - struct uvc_control_mapping *master_map =3D NULL; - struct uvc_control *master_ctrl =3D NULL; - - memset(v4l2_ctrl, 0, sizeof(*v4l2_ctrl)); - v4l2_ctrl->id =3D mapping->id; - v4l2_ctrl->type =3D mapping->v4l2_type; - strscpy(v4l2_ctrl->name, uvc_map_get_name(mapping), - sizeof(v4l2_ctrl->name)); - v4l2_ctrl->flags =3D 0; - - if (!(ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) - v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_WRITE_ONLY; - if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) - v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; - - if (mapping->master_id) - __uvc_find_control(ctrl->entity, mapping->master_id, - &master_map, &master_ctrl, 0, 0); - if (master_ctrl && (master_ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) { - s32 val; - int ret; - - if (WARN_ON(uvc_ctrl_mapping_is_compound(master_map))) - return -EIO; - - ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); - if (ret < 0) - return ret; - - if (val !=3D mapping->master_manual) - v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_INACTIVE; - } - - if (v4l2_ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES) { - v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_HAS_PAYLOAD; - v4l2_ctrl->default_value =3D 0; - v4l2_ctrl->minimum =3D 0; - v4l2_ctrl->maximum =3D 0; - v4l2_ctrl->step =3D 0; - return 0; - } - if (!ctrl->cached) { int ret =3D uvc_ctrl_populate_cache(chain, ctrl); if (ret < 0) @@ -1464,18 +1422,74 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_c= hain *chain, if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MIN) v4l2_ctrl->minimum =3D uvc_mapping_get_s32(mapping, UVC_GET_MIN, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MIN)); + else + v4l2_ctrl->minimum =3D 0; =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX) v4l2_ctrl->maximum =3D uvc_mapping_get_s32(mapping, UVC_GET_MAX, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_MAX)); + else + v4l2_ctrl->maximum =3D 0; =20 if (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES) v4l2_ctrl->step =3D uvc_mapping_get_s32(mapping, UVC_GET_RES, uvc_ctrl_data(ctrl, UVC_CTRL_DATA_RES)); + else + v4l2_ctrl->step =3D 0; =20 return 0; } =20 +static int __uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, + struct uvc_control *ctrl, + struct uvc_control_mapping *mapping, + struct v4l2_queryctrl *v4l2_ctrl) +{ + struct uvc_control_mapping *master_map =3D NULL; + struct uvc_control *master_ctrl =3D NULL; + + memset(v4l2_ctrl, 0, sizeof(*v4l2_ctrl)); + v4l2_ctrl->id =3D mapping->id; + v4l2_ctrl->type =3D mapping->v4l2_type; + strscpy(v4l2_ctrl->name, uvc_map_get_name(mapping), + sizeof(v4l2_ctrl->name)); + v4l2_ctrl->flags =3D 0; + + if (!(ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_WRITE_ONLY; + if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + + if (mapping->master_id) + __uvc_find_control(ctrl->entity, mapping->master_id, + &master_map, &master_ctrl, 0, 0); + if (master_ctrl && (master_ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR)) { + s32 val; + int ret; + + if (WARN_ON(uvc_ctrl_mapping_is_compound(master_map))) + return -EIO; + + ret =3D __uvc_ctrl_get(chain, master_ctrl, master_map, &val); + if (ret < 0) + return ret; + + if (val !=3D mapping->master_manual) + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_INACTIVE; + } + + if (v4l2_ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES) { + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_HAS_PAYLOAD; + v4l2_ctrl->default_value =3D 0; + v4l2_ctrl->minimum =3D 0; + v4l2_ctrl->maximum =3D 0; + v4l2_ctrl->step =3D 0; + return 0; + } + + return __uvc_queryctrl_boundaries(chain, ctrl, mapping, v4l2_ctrl); +} + int uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, struct v4l2_queryctrl *v4l2_ctrl) { --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081DF234997 for ; Tue, 10 Dec 2024 09:43:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823785; cv=none; b=WTRX2uBE/A4br6w3teDdjP8Gd4h0/BzrGuKeiUIyVUVLU1y+xAqmcx9mrUl1X86dl+UwvXW/U81sU/rZcjMTbEQ2ZAp0P7RI1PhFlT2fMzPzx6fhTEijv+Suu/osLWUg+g3jf5B8G71mXGoXDU8+6mtSnoFy+UI3sBrdCgQ9yFI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823785; c=relaxed/simple; bh=1mIhj0L3S8RyfekH5P2w4xxehFGRoAkXfDpeUyyJAW0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=NfVb1DN7C4/XbnOgGRWxwz0XfnmuIVXEjmuy7wiqnVmj29IofOnNEUnw3sO4pFUJG6+tDlzF6x9n1Ev8VmCm/t6UX/+MT5SAnnDWA5J9TTPqsYMJvUQQX3MwzNV+2fYueJCHQ+BTym/NWbMJxe3X6OcQsVQxiCODboaVaFwmI/c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=RZwodfJl; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="RZwodfJl" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d87fea84cdso40304556d6.2 for ; Tue, 10 Dec 2024 01:43:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823782; x=1734428582; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ggsRkdgdY3jtYJRW9AvbLuVLQMJV/njoy22w/Cmb86g=; b=RZwodfJl/FxoCS42F31/3xCxxldV0O0D7atlhbxv+0nQucx5VbcRY9RXFFn0lcjAuG FnjOkJsXOz6AuKElciSCcRWMLZn6lSNQDHPKBOpW60aEq1U/qTOnWNoxIlCz76VO5fLC Dk/PpllIuwWx594pRIJHS3bq85My8Ziuu7ohc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823782; x=1734428582; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ggsRkdgdY3jtYJRW9AvbLuVLQMJV/njoy22w/Cmb86g=; b=RxeubEUFWcZPaKiQIERUQbixNZx9RlwXfpQWThmOdGXeQLwSABqY5IGHrqcCZase7u mhLHS6EXZKLyNGweTxpkS/A7W7tZjevbK5OowPcqpn072G4FQgOPDrPtiqBXLBOIpTZT hcw6tUv68tmBs+uTlQiyDExhu1RgoK6YuwQLFoJHZwRnaerwts65TlqLGIZqeb+/NRZ+ wVXYNmVK9LTjVizW03Ls/3Pdxt3+mUeGYDLzZHYCjzzgxZWKjHEJ2Uwezpu0Dyj05IHa O/Anb1+NA9Ju6E5X4rhmn3k40Y/2fur5tv4W7BZcNhqHJvaLQVV978bsVQey6QOYp/si bOrA== X-Forwarded-Encrypted: i=1; AJvYcCWMcmj8q0KoaLXKugpCjb3p90lWz+QSBelHzOMV041zX/CVa/7ItVo5JjCnJRipVJ1eYQI4kkP/mftIySI=@vger.kernel.org X-Gm-Message-State: AOJu0YxW39/9RJh3tozpXTbwRwETczB+5y5E56+qS8GMGoqJHwUcmJKK t6T3WNGDYWma8KEy7w5s7m44toxOOckdf1uXgZve/3K79NEbc9O7gNRtSIvI2g== X-Gm-Gg: ASbGnctreN2nnkjFQO3li082VVQwCnxmKKfqt3trGDQv9F6QZY4gPBHlVCRbvW//088 Z9o2cgsxBmBl2hd1Ec3XmnVGQCxq61YxLG9KnbfL0CC3rZfzsZeVT61nqur/ZLg6qpRzzupvdZw Ujsc/NDcIsPO8qFBh0ooEQQ8eSIKtohdUosy6k3+LPMXYqnZReUuVtO1Z/taVpuDEaRARythp39 GbWa0VwSFUR62luqaZtvOLFABYwR+DQZCCXUh7zxJ18lFWiCxau/7WlpYzmyt1Pmusf5urhl5IQ rUY9VRA3gEl/dFj5v4D1EbDxMZWt X-Google-Smtp-Source: AGHT+IFWNgHEkkw0X3lGHyza0LOLXXjjNZr+apm6ApxDr5Cb85UBasRKklbmAAOPnhUreGFehC1jXg== X-Received: by 2002:a05:6214:29e9:b0:6d8:7e03:c434 with SMTP id 6a1803df08f44-6d8e7118423mr255304156d6.20.1733823781973; Tue, 10 Dec 2024 01:43:01 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:01 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:49 +0000 Subject: [PATCH v16 13/18] media: uvcvideo: support V4L2_CTRL_WHICH_MIN/MAX_VAL Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-13-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 From: Yunke Cao Add support for V4L2_CTRL_WHICH_MIN/MAX_VAL in uvc driver. It is needed for the V4L2_CID_UVC_REGION_OF_INTEREST_RECT control. Signed-off-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 96 ++++++++++++++++++++++++++++++++----= ---- drivers/media/usb/uvc/uvc_v4l2.c | 2 + 2 files changed, 79 insertions(+), 19 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 785af382103b..14aa9619fbf1 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1277,6 +1277,37 @@ static int uvc_query_v4l2_class(struct uvc_video_cha= in *chain, u32 req_id, return 0; } =20 +static bool uvc_ctrl_is_readable(u32 which, struct uvc_control *ctrl, + struct uvc_control_mapping *mapping) +{ + if (which =3D=3D V4L2_CTRL_WHICH_CUR_VAL) + return !!(ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR); + + if (which =3D=3D V4L2_CTRL_WHICH_DEF_VAL) + return !!(ctrl->info.flags & UVC_CTRL_FLAG_GET_DEF); + + /* Types with implicit boundaries. */ + switch (mapping->v4l2_type) { + case V4L2_CTRL_TYPE_MENU: + case V4L2_CTRL_TYPE_BOOLEAN: + case V4L2_CTRL_TYPE_BUTTON: + return true; + case V4L2_CTRL_TYPE_BITMASK: + return (ctrl->info.flags & UVC_CTRL_FLAG_GET_RES) || + (ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX); + default: + break; + } + + if (which =3D=3D V4L2_CTRL_WHICH_MIN_VAL) + return !!(ctrl->info.flags & UVC_CTRL_FLAG_GET_MIN); + + if (which =3D=3D V4L2_CTRL_WHICH_MAX_VAL) + return !!(ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX); + + return false; +} + /* * Check if control @v4l2_id can be accessed by the given control @ioctl * (VIDIOC_G_EXT_CTRLS, VIDIOC_TRY_EXT_CTRLS or VIDIOC_S_EXT_CTRLS). @@ -1295,7 +1326,6 @@ int uvc_ctrl_is_accessible(struct uvc_video_chain *ch= ain, u32 v4l2_id, struct uvc_control *master_ctrl =3D NULL; struct uvc_control_mapping *mapping; struct uvc_control *ctrl; - bool read =3D ioctl =3D=3D VIDIOC_G_EXT_CTRLS; s32 val; int ret; int i; @@ -1307,10 +1337,10 @@ int uvc_ctrl_is_accessible(struct uvc_video_chain *= chain, u32 v4l2_id, if (!ctrl) return -EINVAL; =20 - if (!(ctrl->info.flags & UVC_CTRL_FLAG_GET_CUR) && read) - return -EACCES; + if (ioctl =3D=3D VIDIOC_G_EXT_CTRLS) + return uvc_ctrl_is_readable(ctrls->which, ctrl, mapping); =20 - if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR) && !read) + if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) return -EACCES; =20 if (ioctl !=3D VIDIOC_S_EXT_CTRLS || !mapping->master_id) @@ -1459,6 +1489,9 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_WRITE_ONLY; if (!(ctrl->info.flags & UVC_CTRL_FLAG_SET_CUR)) v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_READ_ONLY; + if ((ctrl->info.flags & UVC_CTRL_FLAG_GET_MAX) && + (ctrl->info.flags & UVC_CTRL_FLAG_GET_MIN)) + v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_HAS_WHICH_MIN_MAX; =20 if (mapping->master_id) __uvc_find_control(ctrl->entity, mapping->master_id, @@ -2045,16 +2078,18 @@ static int uvc_mapping_get_xctrl_compound(struct uv= c_video_chain *chain, =20 switch (which) { case V4L2_CTRL_WHICH_CUR_VAL: - ret =3D __uvc_ctrl_load_cur(chain, ctrl); - if (ret < 0) - return ret; id =3D UVC_CTRL_DATA_CURRENT; query =3D UVC_GET_CUR; break; + case V4L2_CTRL_WHICH_MIN_VAL: + id =3D UVC_CTRL_DATA_MIN; + query =3D UVC_GET_MIN; + break; + case V4L2_CTRL_WHICH_MAX_VAL: + id =3D UVC_CTRL_DATA_MAX; + query =3D UVC_GET_MAX; + break; case V4L2_CTRL_WHICH_DEF_VAL: - ret =3D uvc_ctrl_populate_cache(chain, ctrl); - if (ret < 0) - return ret; id =3D UVC_CTRL_DATA_DEF; query =3D UVC_GET_DEF; break; @@ -2072,6 +2107,14 @@ static int uvc_mapping_get_xctrl_compound(struct uvc= _video_chain *chain, if (!data) return -ENOMEM; =20 + if (which =3D=3D V4L2_CTRL_WHICH_CUR_VAL) + ret =3D __uvc_ctrl_load_cur(chain, ctrl); + else + ret =3D uvc_ctrl_populate_cache(chain, ctrl); + + if (ret < 0) + return ret; + ret =3D mapping->get(mapping, query, uvc_ctrl_data(ctrl, id), size, data); if (ret < 0) return ret; @@ -2089,22 +2132,37 @@ static int uvc_mapping_get_xctrl_std(struct uvc_vid= eo_chain *chain, struct uvc_control_mapping *mapping, u32 which, struct v4l2_ext_control *xctrl) { + struct v4l2_queryctrl qc; + int ret; + switch (which) { case V4L2_CTRL_WHICH_CUR_VAL: return __uvc_ctrl_get(chain, ctrl, mapping, &xctrl->value); case V4L2_CTRL_WHICH_DEF_VAL: - if (!ctrl->cached) { - int ret =3D uvc_ctrl_populate_cache(chain, ctrl); + case V4L2_CTRL_WHICH_MIN_VAL: + case V4L2_CTRL_WHICH_MAX_VAL: + break; + default: + return -EINVAL; + } =20 - if (ret < 0) - return ret; - } - xctrl->value =3D uvc_mapping_get_s32(mapping, UVC_GET_DEF, - uvc_ctrl_data(ctrl, UVC_CTRL_DATA_DEF)); - return 0; + ret =3D __uvc_queryctrl_boundaries(chain, ctrl, mapping, &qc); + if (ret < 0) + return ret; + + switch (which) { + case V4L2_CTRL_WHICH_DEF_VAL: + xctrl->value =3D qc.default_value; + break; + case V4L2_CTRL_WHICH_MIN_VAL: + xctrl->value =3D qc.minimum; + break; + case V4L2_CTRL_WHICH_MAX_VAL: + xctrl->value =3D qc.maximum; + break; } =20 - return -EINVAL; + return 0; } =20 static int uvc_mapping_get_xctrl(struct uvc_video_chain *chain, diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 65dbb53b1e75..7e284770149d 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1087,6 +1087,8 @@ static int uvc_ioctl_g_ext_ctrls(struct file *file, v= oid *fh, switch (ctrls->which) { case V4L2_CTRL_WHICH_DEF_VAL: case V4L2_CTRL_WHICH_CUR_VAL: + case V4L2_CTRL_WHICH_MAX_VAL: + case V4L2_CTRL_WHICH_MIN_VAL: which =3D ctrls->which; break; default: --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 866032500A8 for ; Tue, 10 Dec 2024 09:43:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823786; cv=none; b=OL0bwcZOdwvFDbNX1dS17pVroi5DK74P4y8FniejluHaYoz8fr6YTvIiLjMEuQC9sNAz4VOj1j3Jw1SpY9nILZN4K7dTM9Rsb40CDaLJZDuViUafrdOYUyX2PsqQ/EJgwQZapSDzze68mvwlJCPq9BvNPVPx2M51NlbSHEBRbT0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823786; c=relaxed/simple; bh=yqji/xzHYuOsoD1S6Hj7O2pucPqwN31k/pN+iJwwrO4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DJzDQ7xssgDBBfVhuja+fccF7Yb91LOOAspVWJyiDo2OvcLdJE8OKhvJr2Sf4s6kdko7WaUOo0yhiRCOPqgZBIZRbaIHuGClQzDL6elfnHuaXcmymB+TBMXF/w5dy3vFzRVEXLqoc6Mvg3owRjyvW0Ceid0YlLyJAoZwUHloihs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bxXFqYYo; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bxXFqYYo" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-6d8f99cb0d9so23145266d6.0 for ; Tue, 10 Dec 2024 01:43:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823783; x=1734428583; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S4DLEGpbxISaKGwkcSnN6qP20jbOjfnGAGZ1UU5NuHw=; b=bxXFqYYoqvjs5zW7e4ZRCQ/k4PuhewxRGQKvY+oXka+LKcTijAqk4YXRg7VKky9gjb 3iDRnTuzjl4716iI1vo+HJGFVb6phuQUsuLgbPSdivtp3be9Xd5KJP0bJz4HAWloMXfL J91+4uKvkFHvwJSYRC65t2nnQG5via4HM7RXs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823783; x=1734428583; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S4DLEGpbxISaKGwkcSnN6qP20jbOjfnGAGZ1UU5NuHw=; b=ptH/3DITMS+4QiYewt292lvAA+bt4r2r92XOrHG0dZQZ4r3JH3VWg2ZjTZAGaadA2K HfqXFKTzbNwPEdc7BoI+5yZRQMWZPZ0bvb3UPs6bHu2Of8/3laqkP5C5rUH/QhKJn1c2 BdE4+4/QzEhKdatoBGA+EnGWHnPj54+Z/r91OAUZNpEPUBvFjuRfaM5wWZQwczDcXjWg pVKKAaGJu0c/oThyxdF+b5VU2Seh/bJ4CXVdRsD945icoqBLsKndGpJ/YwACNAAX1ihy 9/gbJ2swKpdFrBxBPjVFZ9WjMDWjr65lwP6r8tNvFgAGSegHcv8VifcHZTfSA4Bre4A/ oo1g== X-Forwarded-Encrypted: i=1; AJvYcCWVNmyF5296+Fgb88HO+tuIceRCZtWYzBPzWmRhjDDAd2AbnvF//30duUpLl27zirBJKGzsTUz5hdd3H70=@vger.kernel.org X-Gm-Message-State: AOJu0YwQpbbA6ys63RWSFtuFTHsv7P1VG7yKUXVOGupsm8gEpb11vfTx oFnfDuKLxdTGxuYhGVyYWM7UuR3HPEK6Jibe/Af1G0QsMdGhQMWEh38IIZVGcw== X-Gm-Gg: ASbGncuAjbNdVPEl53AITjfIsYutwZr0+yWygNpXF/TX2+G4idAujzkVD0zXzY+4fvQ Rxzd1jXgQZ5zGhYdWYKWiVrsfXdl3AtmuqKK0D7GrxwG9gT8pX0Vu8/T+NYDV7xHmNLsVI5GIGP iLUQ6R2eZ1U0jAa0iDABANfVIyVWtTVqG86t5gxYlu91ZNRf4oP9yEwUxxgB+GX6NmuJsm4KOd6 Csc66DfGx5TbIPODJ+6fXhxrkW/c5zYFiFM19ZFBzuiHBv/K3dtPfxV916V+yleZUMDpjEMPdjJ fGz9YueYXewoTEwRFYTQmd3XQLFZ X-Google-Smtp-Source: AGHT+IGDLwVPsYRL6IYDVi5Q+ZWF5oyLjYiYvYAuxK4fkpF2rSBiWjqmp7rVZEHZCpZBZUq7IJEJPQ== X-Received: by 2002:a05:6214:e6b:b0:6d8:848e:76c8 with SMTP id 6a1803df08f44-6d91e442686mr68091406d6.42.1733823783400; Tue, 10 Dec 2024 01:43:03 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:02 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:50 +0000 Subject: [PATCH v16 14/18] media: uvcvideo: let v4l2_query_v4l2_ctrl() work with v4l2_query_ext_ctrl Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-14-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 v4l2_query_ext_ctrl contains information that is missing in v4l2_queryctrl, like elem_size and elems. With this change we can handle all the element_size information inside uvc_ctrl.c. Now that we are at it, remove the memset of the reserved fields, the v4l2 ioctl handler should do that for us. There is no functional change expected from this change. Reviewed-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 24 ++++++++++++++---------- drivers/media/usb/uvc/uvc_v4l2.c | 35 +++++++++++++++-------------------- drivers/media/usb/uvc/uvcvideo.h | 2 +- 3 files changed, 30 insertions(+), 31 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 14aa9619fbf1..58bd42191f3e 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1259,7 +1259,8 @@ static int __uvc_query_v4l2_class(struct uvc_video_ch= ain *chain, u32 req_id, } =20 static int uvc_query_v4l2_class(struct uvc_video_chain *chain, u32 req_id, - u32 found_id, struct v4l2_queryctrl *v4l2_ctrl) + u32 found_id, + struct v4l2_query_ext_ctrl *v4l2_ctrl) { int idx; =20 @@ -1407,7 +1408,7 @@ static u32 uvc_get_ctrl_bitmap(struct uvc_control *ct= rl, static int __uvc_queryctrl_boundaries(struct uvc_video_chain *chain, struct uvc_control *ctrl, struct uvc_control_mapping *mapping, - struct v4l2_queryctrl *v4l2_ctrl) + struct v4l2_query_ext_ctrl *v4l2_ctrl) { if (!ctrl->cached) { int ret =3D uvc_ctrl_populate_cache(chain, ctrl); @@ -1473,7 +1474,7 @@ static int __uvc_queryctrl_boundaries(struct uvc_vide= o_chain *chain, static int __uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, struct uvc_control *ctrl, struct uvc_control_mapping *mapping, - struct v4l2_queryctrl *v4l2_ctrl) + struct v4l2_query_ext_ctrl *v4l2_ctrl) { struct uvc_control_mapping *master_map =3D NULL; struct uvc_control *master_ctrl =3D NULL; @@ -1511,6 +1512,9 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_INACTIVE; } =20 + v4l2_ctrl->elem_size =3D sizeof(s32); + v4l2_ctrl->elems =3D 1; + if (v4l2_ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES) { v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_HAS_PAYLOAD; v4l2_ctrl->default_value =3D 0; @@ -1524,7 +1528,7 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, } =20 int uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, - struct v4l2_queryctrl *v4l2_ctrl) + struct v4l2_query_ext_ctrl *v4l2_ctrl) { struct uvc_control *ctrl; struct uvc_control_mapping *mapping; @@ -1650,7 +1654,7 @@ static void uvc_ctrl_fill_event(struct uvc_video_chai= n *chain, struct uvc_control_mapping *mapping, s32 value, u32 changes) { - struct v4l2_queryctrl v4l2_ctrl; + struct v4l2_query_ext_ctrl v4l2_ctrl; =20 __uvc_query_v4l2_ctrl(chain, ctrl, mapping, &v4l2_ctrl); =20 @@ -2132,7 +2136,7 @@ static int uvc_mapping_get_xctrl_std(struct uvc_video= _chain *chain, struct uvc_control_mapping *mapping, u32 which, struct v4l2_ext_control *xctrl) { - struct v4l2_queryctrl qc; + struct v4l2_query_ext_ctrl qec; int ret; =20 switch (which) { @@ -2146,19 +2150,19 @@ static int uvc_mapping_get_xctrl_std(struct uvc_vid= eo_chain *chain, return -EINVAL; } =20 - ret =3D __uvc_queryctrl_boundaries(chain, ctrl, mapping, &qc); + ret =3D __uvc_queryctrl_boundaries(chain, ctrl, mapping, &qec); if (ret < 0) return ret; =20 switch (which) { case V4L2_CTRL_WHICH_DEF_VAL: - xctrl->value =3D qc.default_value; + xctrl->value =3D qec.default_value; break; case V4L2_CTRL_WHICH_MIN_VAL: - xctrl->value =3D qc.minimum; + xctrl->value =3D qec.minimum; break; case V4L2_CTRL_WHICH_MAX_VAL: - xctrl->value =3D qc.maximum; + xctrl->value =3D qec.maximum; break; } =20 diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 7e284770149d..5000c74271e0 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -1014,40 +1014,35 @@ static int uvc_ioctl_s_input(struct file *file, voi= d *fh, unsigned int input) return ret; } =20 -static int uvc_ioctl_queryctrl(struct file *file, void *fh, - struct v4l2_queryctrl *qc) +static int uvc_ioctl_query_ext_ctrl(struct file *file, void *fh, + struct v4l2_query_ext_ctrl *qec) { struct uvc_fh *handle =3D fh; struct uvc_video_chain *chain =3D handle->chain; =20 - return uvc_query_v4l2_ctrl(chain, qc); + return uvc_query_v4l2_ctrl(chain, qec); } =20 -static int uvc_ioctl_query_ext_ctrl(struct file *file, void *fh, - struct v4l2_query_ext_ctrl *qec) +static int uvc_ioctl_queryctrl(struct file *file, void *fh, + struct v4l2_queryctrl *qc) { struct uvc_fh *handle =3D fh; struct uvc_video_chain *chain =3D handle->chain; - struct v4l2_queryctrl qc =3D { qec->id }; + struct v4l2_query_ext_ctrl qec =3D { qc->id }; int ret; =20 - ret =3D uvc_query_v4l2_ctrl(chain, &qc); + ret =3D uvc_query_v4l2_ctrl(chain, &qec); if (ret) return ret; =20 - qec->id =3D qc.id; - qec->type =3D qc.type; - strscpy(qec->name, qc.name, sizeof(qec->name)); - qec->minimum =3D qc.minimum; - qec->maximum =3D qc.maximum; - qec->step =3D qc.step; - qec->default_value =3D qc.default_value; - qec->flags =3D qc.flags; - qec->elem_size =3D 4; - qec->elems =3D 1; - qec->nr_of_dims =3D 0; - memset(qec->dims, 0, sizeof(qec->dims)); - memset(qec->reserved, 0, sizeof(qec->reserved)); + qc->id =3D qec.id; + qc->type =3D qec.type; + strscpy(qc->name, qec.name, sizeof(qc->name)); + qc->minimum =3D qec.minimum; + qc->maximum =3D qec.maximum; + qc->step =3D qec.step; + qc->default_value =3D qec.default_value; + qc->flags =3D qec.flags; =20 return 0; } diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index f429f325433b..8aca1a2fe587 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -766,7 +766,7 @@ void uvc_status_put(struct uvc_device *dev); extern const struct v4l2_subscribed_event_ops uvc_ctrl_sub_ev_ops; =20 int uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, - struct v4l2_queryctrl *v4l2_ctrl); + struct v4l2_query_ext_ctrl *v4l2_ctrl); int uvc_query_v4l2_menu(struct uvc_video_chain *chain, struct v4l2_querymenu *query_menu); =20 --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77758215792 for ; Tue, 10 Dec 2024 09:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823787; cv=none; b=dv+3BZdGX7aDl7/4KQwrk4ITHra7IXxfpt7s2mijwLSvNKLpwbH+GmwHYkK8ALcnrfigzExINow174xqRt2Gkuu1keUPvCDO/H6Y2rJx1hM6XhKUIDWbQn+UH99mZCSnT00HpgJL/FBb9YFkZk+UOXoOBF+5KJfw60jDbDK1v+M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823787; c=relaxed/simple; bh=j6w/ehoFFcMfXU0GvWdVutVl4sbMYNCORCUrUbyVXPY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KrcRsVYy0h9i46eTm+EaTaQ90swYEq5V9TRSULcVPVUJYOTr6+cyS2vsU1kQ+4FUqYhVrOkah9EmQM0LhtrV/DZSwOgM4R+BSHQontq99/8PfyAOuj7vMxmTRkbPekllExd6KlbbwlT9LNXKNACYaOJsICVQdIXyStEBjRiOcSE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ZmVpE196; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ZmVpE196" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6d8918ec243so53708806d6.1 for ; Tue, 10 Dec 2024 01:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823784; x=1734428584; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=teneHbxdymYBZ2TJXTz4C2Fnz+shby6Rz+Rw9UldIMg=; b=ZmVpE196GIYFHl4MJlQhv9glMEJv9th6z+yPxbzztGBiJJQkXBOOX1XRzNKireLXKb wAM0WZza2M0qYQb7xLfW48t6y0Oux4ZiWFmD787urHOyfsOeIojmPIxsK012jU+vxVVv jUd9GlZ1PeqxOCMx1PGg69/Z5M1/JlQPCEkfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823784; x=1734428584; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=teneHbxdymYBZ2TJXTz4C2Fnz+shby6Rz+Rw9UldIMg=; b=kGh1OrycssH/91krkuZh4FNpMxkgx57F5P9Hi7WUuBmBUEQotpjq1WW2lMvvEptRyf 6dgtSVkHckXGi1vN/xdj1/zf5VJEAoFLV4c+R9oyQF7lR692Op402Bup9945qQOzUUP0 fsczHN7TK8EE7oJmklkTYstI4V8o7zjfFmgkHstzfSswjlTiR/zuy63Yc9B0SXvReUin GaYUOUg5IHePvqsTqmJadruz7NtB1i9k+9DQe+tCAGUd3q2LgIqc3IvfC603g8uR8aNG HnBsvQ6wGuOK/FIpMRmPq5gbHgtN/VPUBKX4Apcwn0rAE64I3ujZys7G49gncjgXYRIJ Gdbg== X-Forwarded-Encrypted: i=1; AJvYcCWSoCsqND3Ah3NjcYbz23nT3z9RR9e6a1BOZSMtNIOgl/JqtsHNmwkDj2F4dKleRScak8Ln/5HONPKVB78=@vger.kernel.org X-Gm-Message-State: AOJu0YzRsPjbnQ5iwt5QyS96KCS83Wfgx4KS7YYnrJUoM5WFNpdHwBj+ A/4K8n2nTfuS9bITaSRB+/tcRLIIVYZj/GHMDTzd7Hv73bHBjxHXoteeQYEtGQ== X-Gm-Gg: ASbGncuhzFIPDfN27zmZpOKJmEc4bOURvx0b/kvml9uBWJ+gF0CSR4rSN0O4r5pZGzF B7pVi2uT+PCs/Eey4jj8muu99hxbL04W6SfLzYSzH83JwXatNPEyL7HGSflC6yBvFJZObfO/4i8 UiKobe3Fva1wWekwrrtcqd4CE3p2rvgn67MGbqakKgEorJmNUaGi3nsQMNXTnuNt9vYrvLuqNVw FRIxaYSA6y9NRuD1/wlQhppVPShMMpSFnuc++zP2Qzo2SwPufRyCfdQKAkqDVylwJaQ6tVG3nIp EmzVkXIfwtCqSG/ZKypNQO0q6Dr6 X-Google-Smtp-Source: AGHT+IHPeSY10FnNmsQEJGreViToMkX+83gWAxGpMBUhrfxnm5Cs2DpKJx49CNRZNU1nYkGjkjlubQ== X-Received: by 2002:ad4:5c49:0:b0:6cb:99db:bdd5 with SMTP id 6a1803df08f44-6d91e40b5b5mr67741986d6.39.1733823784162; Tue, 10 Dec 2024 01:43:04 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:03 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:51 +0000 Subject: [PATCH v16 15/18] media: uvcvideo: Introduce uvc_mapping_v4l2_size Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-15-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Centralize the calculation for the v4l2_size of a mapping. Reviewed-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_ctrl.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index 58bd42191f3e..dd6129becf58 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -1471,6 +1471,14 @@ static int __uvc_queryctrl_boundaries(struct uvc_vid= eo_chain *chain, return 0; } =20 +static size_t uvc_mapping_v4l2_size(struct uvc_control_mapping *mapping) +{ + if (uvc_ctrl_mapping_is_compound(mapping)) + return DIV_ROUND_UP(mapping->size, 8); + + return sizeof(s32); +} + static int __uvc_query_v4l2_ctrl(struct uvc_video_chain *chain, struct uvc_control *ctrl, struct uvc_control_mapping *mapping, @@ -1512,7 +1520,7 @@ static int __uvc_query_v4l2_ctrl(struct uvc_video_cha= in *chain, v4l2_ctrl->flags |=3D V4L2_CTRL_FLAG_INACTIVE; } =20 - v4l2_ctrl->elem_size =3D sizeof(s32); + v4l2_ctrl->elem_size =3D uvc_mapping_v4l2_size(mapping); v4l2_ctrl->elems =3D 1; =20 if (v4l2_ctrl->type >=3D V4L2_CTRL_COMPOUND_TYPES) { @@ -2101,7 +2109,7 @@ static int uvc_mapping_get_xctrl_compound(struct uvc_= video_chain *chain, return -EINVAL; } =20 - size =3D DIV_ROUND_UP(mapping->size, 8); + size =3D uvc_mapping_v4l2_size(mapping); if (xctrl->size < size) { xctrl->size =3D size; return -ENOSPC; @@ -2284,9 +2292,8 @@ static int uvc_mapping_set_xctrl_compound(struct uvc_= control *ctrl, struct v4l2_ext_control *xctrl) { u8 *data __free(kfree) =3D NULL; - size_t size; + size_t size =3D uvc_mapping_v4l2_size(mapping); =20 - size =3D DIV_ROUND_UP(mapping->size, 8); if (xctrl->size !=3D size) return -EINVAL; =20 --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 259633DAC19 for ; Tue, 10 Dec 2024 09:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823787; cv=none; b=Hm1nZIZg/RPYWHPIXVar09SlS9xSXyscj0LstyDzGt+AmmP46j7x85mhTpgHEgfN74UzRodprUJ70Of1yVWWMrMPUpZuoyM9o7x5ggBDur17glaIpN+I/OMAd8rzWi6JN0JZ2cvjyyadDGFlzPMguOKk+H9xyFpYFAeWGlR8b3U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823787; c=relaxed/simple; bh=HCkd9QY2OfGozb/+L9hVVayAr5QQOjRc9Dn84hpf1DE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Tk3gdItJ3WOF2P+vCm+XLlXb8sM33VxgUdaDwFu40/jnlFigCDlDM9sJ6Jm1nEqWJDZTtSB0o/tTI/tvGLtwCx2dD196/EAPJPYSo6qZaumXDZ2DVVWhfWhggBE8sIrhaoJnZXs9axY4fg9ZlcTfMPdFzRQlizK3E9yRqYtoP0k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=V0JLBHHk; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V0JLBHHk" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-6d87fffeb13so44134146d6.1 for ; Tue, 10 Dec 2024 01:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823785; x=1734428585; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=OHxayE4k42tgzCvBKbSWRnUHa8HIxT/un4VmPqqRwYk=; b=V0JLBHHkfNETy6LIQWkMe3tRi7jKLYn3A4HMix+MibqqGpssvFUe0c7Lupo9Y+OgtT VoHI0jgCZhPqSrLKDPV9Iotwwt+Uyr457T/S7lYLKITVHhbzo2KQ1qTh9AkuDPoIIybp ERrGdyBF3kyFW1F6ZZ7bR1hApBmgJg+9R9PCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823785; x=1734428585; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OHxayE4k42tgzCvBKbSWRnUHa8HIxT/un4VmPqqRwYk=; b=E4fc3ovM8okgL44TNjJ3Ncumx1fBKA3LkTNZbF5AFoO8R4a+P9IOy4QGHKaUgLAW2p enEJ6TCrP2CWX+E4Kxfq4WJTY4OOa2BTXA66vV+gP0uJOorahk97JJ3ntxiQd4aBCuI8 IW4P0zbhmIeU4IOz2oVSDwpYMVefydoek6FWXkrZcF/dDxFlcmpQ3ys+zEnG+jShzK3e MqSwcRlEVDEqRi9PJx+lWjSBvGb64Uuc0o1LxMb90HqVqXPp7ImVPOoZM574BSMW3mM1 NR0+jDeljZxfgopoKyBnVvje52Q7JKR4hTRK4X5QFJUZg8fyYKl/oM+RzjUdiNQDJ/iq +3WA== X-Forwarded-Encrypted: i=1; AJvYcCUK47fqcLSUMxKwVnX/nL3daEDUdcG9G35Uf9Al1HAopuKkSDlwmxkiZxlohw/ZuYwpvcuiRB02cp0+fkE=@vger.kernel.org X-Gm-Message-State: AOJu0YxElgu3XXO9Uan1uQLEAwy0WeBNkPTWHg3hrIywdGcVKVgmgR3U 1C3pu9orW+rOsJgRdvsaFPc71q0L8qVg4fSdpJgeood6AZss4CNeluFS+znClw== X-Gm-Gg: ASbGnctJpHMMyAiW0fJvTLOe3OB3LaOjAubmkLAhsbFsMHsqYNCVtKBuDV5zCTNofy1 RgmzFESmiusdHdsqkzbbWdx5GckMAVkVD20hWj0n6a7Q/jIb8Efwmvey4B78BTwde0bcTM2/wdH HkBgO3+vHXQKxzWdbqOZySc/ihnt5b96/eJYGc1iotK8Vk9IQ30Q90OahONVtpWksfvIPfg511p 3BpbWsMP/saDQ8tLtM4u7aTd57nQLDYf/nmz9NolXI17KAlVrSrrOZgld2owx2Ev0BFUhbjgi3U aHj3a+sockavVU6MzKxuKgIbtZMc X-Google-Smtp-Source: AGHT+IEdReo0MRnNlTyTmOkuTUdcKCx+CoS8N4Bbe9AR14bTkRgBndNrGwfcStRIkm86B2Q5mtIIRQ== X-Received: by 2002:a05:6214:f62:b0:6d8:a148:9ac9 with SMTP id 6a1803df08f44-6d8e73be7c3mr272587766d6.30.1733823785070; Tue, 10 Dec 2024 01:43:05 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:04 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:52 +0000 Subject: [PATCH v16 16/18] media: uvcvideo: Add sanity check to uvc_ioctl_xu_ctrl_map Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-16-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 Do not process unknown data types. Tested-by: Yunke Cao Reviewed-by: Hans de Goede Signed-off-by: Ricardo Ribalda --- drivers/media/usb/uvc/uvc_v4l2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_v4l2.c b/drivers/media/usb/uvc/uvc_v= 4l2.c index 5000c74271e0..0d9d056f1bbe 100644 --- a/drivers/media/usb/uvc/uvc_v4l2.c +++ b/drivers/media/usb/uvc/uvc_v4l2.c @@ -106,6 +106,12 @@ static int uvc_ioctl_xu_ctrl_map(struct uvc_video_chai= n *chain, struct uvc_control_mapping *map; int ret; =20 + if (xmap->data_type > UVC_CTRL_DATA_TYPE_BITMASK) { + uvc_dbg(chain->dev, CONTROL, + "Unsupported UVC data type %u\n", xmap->data_type); + return -EINVAL; + } + map =3D kzalloc(sizeof(*map), GFP_KERNEL); if (map =3D=3D NULL) return -ENOMEM; --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ED27B2253F6 for ; Tue, 10 Dec 2024 09:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823789; cv=none; b=JJ3OfnmlLUcHmKq+mbksokWU+L8oJl4dR468Sl7/trqAgxShZyLv4uR2uHzTLTHPsg2UDioSiVvecIhkW621YlRE+9qIIJjdhdeGVM5Nea1eJpyogplnB2d77dtRq8oVQrb/24yq+7EsDEG+MdiIJETWPlx0aNnDSjt92fEh81Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823789; c=relaxed/simple; bh=HryVrfF4ja+UE4Nf++7Oms3/m6HrslBSeTxh251rrlM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=KE9XtMey66Xnpxc7TII/ITVNeOXKXXaE4hEYDYaxiIKpuUP9oAkvUy+mmOnD6m0GjGtCD74TfS2WWmRpN0JpfXPHcY0tiaNhJUjYeCSyyccrSr+hq6PrNpZqHyF5Df0SaPAZHv9X9DMsXYJl/pI4GHSZDRbz8kzmiQ03xQR8omY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=f0af1yjh; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f0af1yjh" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6d8918ec243so53708966d6.1 for ; Tue, 10 Dec 2024 01:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823786; x=1734428586; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=2aUprzMfZUWIyjxGkmKCAmM/uBFiYLCsY67DDg7bs5I=; b=f0af1yjhXQk3n/QhWxnOwXAk86JDvwdsC9G9REOtCneE3HR/fvHr1WL8vb5MtzQx5i 5ippmVTwnw9GX7WqHldvZKeLNIh7HBknE99q2rjkl2kcXVT9N48dlKLc1XPT89ZdClu/ rTIYfahCmL4h6JthpJ8p6q/VB8Gd52FDYYjAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823786; x=1734428586; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2aUprzMfZUWIyjxGkmKCAmM/uBFiYLCsY67DDg7bs5I=; b=qUIDvRbtlMU4Y8VtPCeo+oZowr6QX3LDv/Cf8NsdZNrLW4EWyEwo+9xTq49DavH4T6 zSpmy7jfYlmxxsYApo3jfzHjbbcZPWlh9Mon2Q5UoxB3ai+qGWdfD/z2Sn/wf482+OWz iqoAArYWz6QjchmzVpRVmp1FbL4+f8Hslq9zqo627q4fhq12KrEVPQu03u4enmKHUKTY A8wJt6ImdWRyQ7ojQMQakkNUBArBI30Tl8KC7GVsTYGLgElldWf2mdcBu7vhEvoRpg0h NNBmkDdD94GzLdah2TRqE5a0C3um2sdhdh56rK4Gflk253nOwxpcyIPgxVh3ePeZ4mMC UZng== X-Forwarded-Encrypted: i=1; AJvYcCXnvc48gvHyQLjO3b8l3ivZKUaJl4q4L3EQ+EqaQ9KMC9nvfIT7AvQtvULRaSXuNbgjESscWbxv7QrORnk=@vger.kernel.org X-Gm-Message-State: AOJu0YxFaApFtt1rec0awsv+9Q87V2hQ8amOqfu2mYZ4+QIB6KsdHOZ+ FrhLZ13jS5vEQoX82F4Bs2yPpv/yQO5pe7vBynALQZhaRdywv6OSRLdbEbvmiuMcWN6kH+zLYAI = X-Gm-Gg: ASbGncsx8Z2vjCRRhJ+mv/xIgFahFMVWM7ZUCXNUsrLUUI8NmiQn23DWedcdRd4XS8O DJyOn5BXDITxdHEQ1KzzRMt6H5daKqrlSNhjHc4pEB134zZ/nMOpGZxijxnIsh+hdYXsOr9N9zm 2jYgCmJbn+tJju4KrqHrISzQ1yCjfkPZvlsQZ2JKNi/sXuyDScWpNsfJNW7Xul+3Fu/3mQVDGKh AU1X8HZUxJDc8VSc1fZ4i67GmkKctWZd6pzk/PFsSL+CfF5mp+c4nyBn8Td9+0qTLkVxlTQJE+V 8dfDe0+Zd+EzJrRx1/EOO/CGBIYs X-Google-Smtp-Source: AGHT+IEV5cazRGN6FSky6OmAJjjskESsyqTGoGeNqQvsriM6DHVN+Snh/fT73/JwaEBDp9NXdAYkiw== X-Received: by 2002:a05:6214:f06:b0:6d8:ab7e:e55e with SMTP id 6a1803df08f44-6d91e40b22amr56041826d6.34.1733823785890; Tue, 10 Dec 2024 01:43:05 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:05 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:53 +0000 Subject: [PATCH v16 17/18] media: uvcvideo: implement UVC v1.5 ROI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-17-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao X-Mailer: b4 0.13.0 From: Yunke Cao Implement support for ROI as described in UVC 1.5: 4.2.2.1.20 Digital Region of Interest (ROI) Control ROI control is implemented using V4L2 control API as two UVC-specific controls: V4L2_CID_UVC_REGION_OF_INTEREST_RECT and V4L2_CID_UVC_REGION_OF_INTEREST_AUTO. Reviewed-by: Ricardo Ribalda Signed-off-by: Yunke Cao Reviewed-by: Yunke Cao Tested-by: Yunke Cao Reviewed-by: Hans de Goede --- drivers/media/usb/uvc/uvc_ctrl.c | 81 ++++++++++++++++++++++++++++++++++= ++++ drivers/media/usb/uvc/uvcvideo.h | 7 ++++ include/uapi/linux/usb/video.h | 1 + include/uapi/linux/uvcvideo.h | 13 ++++++ include/uapi/linux/v4l2-controls.h | 7 ++++ 5 files changed, 109 insertions(+) diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_c= trl.c index dd6129becf58..86ea24b10b54 100644 --- a/drivers/media/usb/uvc/uvc_ctrl.c +++ b/drivers/media/usb/uvc/uvc_ctrl.c @@ -358,6 +358,24 @@ static const struct uvc_control_info uvc_ctrls[] =3D { .flags =3D UVC_CTRL_FLAG_GET_CUR | UVC_CTRL_FLAG_AUTO_UPDATE, }, + /* + * UVC_CTRL_FLAG_AUTO_UPDATE is needed because the RoI may get updated + * by sensors. + * "This RoI should be the same as specified in most recent SET_CUR + * except in the case where the =E2=80=98Auto Detect and Track=E2=80=99 a= nd/or + * =E2=80=98Image Stabilization=E2=80=99 bit have been set." + * 4.2.2.1.20 Digital Region of Interest (ROI) Control + */ + { + .entity =3D UVC_GUID_UVC_CAMERA, + .selector =3D UVC_CT_REGION_OF_INTEREST_CONTROL, + .index =3D 21, + .size =3D 10, + .flags =3D UVC_CTRL_FLAG_SET_CUR | UVC_CTRL_FLAG_GET_CUR + | UVC_CTRL_FLAG_GET_MIN | UVC_CTRL_FLAG_GET_MAX + | UVC_CTRL_FLAG_GET_DEF + | UVC_CTRL_FLAG_AUTO_UPDATE, + }, }; =20 static const u32 uvc_control_classes[] =3D { @@ -603,6 +621,44 @@ static const struct uvc_control_mapping *uvc_ctrl_filt= er_plf_mapping( return out_mapping; } =20 +static int uvc_get_rect(struct uvc_control_mapping *mapping, u8 query, + const void *uvc_in, size_t v4l2_size, void *v4l2_out) +{ + const struct uvc_rect *uvc_rect =3D uvc_in; + struct v4l2_rect *v4l2_rect =3D v4l2_out; + + if (WARN_ON(v4l2_size !=3D sizeof(struct v4l2_rect))) + return -EINVAL; + + if (uvc_rect->left > uvc_rect->right || + uvc_rect->top > uvc_rect->bottom) + return -EIO; + + v4l2_rect->top =3D uvc_rect->top; + v4l2_rect->left =3D uvc_rect->left; + v4l2_rect->height =3D uvc_rect->bottom - uvc_rect->top + 1; + v4l2_rect->width =3D uvc_rect->right - uvc_rect->left + 1; + + return 0; +} + +static int uvc_set_rect(struct uvc_control_mapping *mapping, size_t v4l2_s= ize, + const void *v4l2_in, void *uvc_out) +{ + struct uvc_rect *uvc_rect =3D uvc_out; + const struct v4l2_rect *v4l2_rect =3D v4l2_in; + + if (WARN_ON(v4l2_size !=3D sizeof(struct v4l2_rect))) + return -EINVAL; + + uvc_rect->top =3D min(0xffff, v4l2_rect->top); + uvc_rect->left =3D min(0xffff, v4l2_rect->left); + uvc_rect->bottom =3D min(0xffff, v4l2_rect->top + v4l2_rect->height - 1); + uvc_rect->right =3D min(0xffff, v4l2_rect->left + v4l2_rect->width - 1); + + return 0; +} + static const struct uvc_control_mapping uvc_ctrl_mappings[] =3D { { .id =3D V4L2_CID_BRIGHTNESS, @@ -897,6 +953,28 @@ static const struct uvc_control_mapping uvc_ctrl_mappi= ngs[] =3D { .selector =3D UVC_PU_POWER_LINE_FREQUENCY_CONTROL, .filter_mapping =3D uvc_ctrl_filter_plf_mapping, }, + { + .id =3D V4L2_CID_UVC_REGION_OF_INTEREST_RECT, + .entity =3D UVC_GUID_UVC_CAMERA, + .selector =3D UVC_CT_REGION_OF_INTEREST_CONTROL, + .size =3D sizeof(struct uvc_rect) * 8, + .offset =3D 0, + .v4l2_type =3D V4L2_CTRL_TYPE_RECT, + .data_type =3D UVC_CTRL_DATA_TYPE_RECT, + .get =3D uvc_get_rect, + .set =3D uvc_set_rect, + .name =3D "Region Of Interest Rectangle", + }, + { + .id =3D V4L2_CID_UVC_REGION_OF_INTEREST_AUTO, + .entity =3D UVC_GUID_UVC_CAMERA, + .selector =3D UVC_CT_REGION_OF_INTEREST_CONTROL, + .size =3D 16, + .offset =3D 64, + .v4l2_type =3D V4L2_CTRL_TYPE_BITMASK, + .data_type =3D UVC_CTRL_DATA_TYPE_BITMASK, + .name =3D "Region Of Interest Auto Controls", + }, }; =20 /* ------------------------------------------------------------------------ @@ -1473,6 +1551,9 @@ static int __uvc_queryctrl_boundaries(struct uvc_vide= o_chain *chain, =20 static size_t uvc_mapping_v4l2_size(struct uvc_control_mapping *mapping) { + if (mapping->v4l2_type =3D=3D V4L2_CTRL_TYPE_RECT) + return sizeof(struct v4l2_rect); + if (uvc_ctrl_mapping_is_compound(mapping)) return DIV_ROUND_UP(mapping->size, 8); =20 diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvi= deo.h index 8aca1a2fe587..17b79108599f 100644 --- a/drivers/media/usb/uvc/uvcvideo.h +++ b/drivers/media/usb/uvc/uvcvideo.h @@ -538,6 +538,13 @@ struct uvc_device_info { u16 uvc_version; }; =20 +struct uvc_rect { + u16 top; + u16 left; + u16 bottom; + u16 right; +} __packed; + struct uvc_status_streaming { u8 button; } __packed; diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h index 2ff0e8a3a683..2afb4420e6c4 100644 --- a/include/uapi/linux/usb/video.h +++ b/include/uapi/linux/usb/video.h @@ -104,6 +104,7 @@ #define UVC_CT_ROLL_ABSOLUTE_CONTROL 0x0f #define UVC_CT_ROLL_RELATIVE_CONTROL 0x10 #define UVC_CT_PRIVACY_CONTROL 0x11 +#define UVC_CT_REGION_OF_INTEREST_CONTROL 0x14 =20 /* A.9.5. Processing Unit Control Selectors */ #define UVC_PU_CONTROL_UNDEFINED 0x00 diff --git a/include/uapi/linux/uvcvideo.h b/include/uapi/linux/uvcvideo.h index f86185456dc5..cbe15bca9569 100644 --- a/include/uapi/linux/uvcvideo.h +++ b/include/uapi/linux/uvcvideo.h @@ -16,6 +16,7 @@ #define UVC_CTRL_DATA_TYPE_BOOLEAN 3 #define UVC_CTRL_DATA_TYPE_ENUM 4 #define UVC_CTRL_DATA_TYPE_BITMASK 5 +#define UVC_CTRL_DATA_TYPE_RECT 6 =20 /* Control flags */ #define UVC_CTRL_FLAG_SET_CUR (1 << 0) @@ -38,6 +39,18 @@ =20 #define UVC_MENU_NAME_LEN 32 =20 +/* V4L2 driver-specific controls */ +#define V4L2_CID_UVC_REGION_OF_INTEREST_RECT (V4L2_CID_USER_UVC_BASE + 1) +#define V4L2_CID_UVC_REGION_OF_INTEREST_AUTO (V4L2_CID_USER_UVC_BASE + 2) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_EXPOSURE (1 << 0) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_IRIS (1 << 1) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_WHITE_BALANCE (1 << 2) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_FOCUS (1 << 3) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_FACE_DETECT (1 << 4) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_DETECT_AND_TRACK (1 << 5) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_IMAGE_STABILIZATION (1 << 6) +#define V4L2_UVC_REGION_OF_INTEREST_AUTO_HIGHER_QUALITY (1 << 7) + struct uvc_menu_info { __u32 value; __u8 name[UVC_MENU_NAME_LEN]; diff --git a/include/uapi/linux/v4l2-controls.h b/include/uapi/linux/v4l2-c= ontrols.h index 974fd254e573..72e32814ea83 100644 --- a/include/uapi/linux/v4l2-controls.h +++ b/include/uapi/linux/v4l2-controls.h @@ -215,6 +215,13 @@ enum v4l2_colorfx { */ #define V4L2_CID_USER_THP7312_BASE (V4L2_CID_USER_BASE + 0x11c0) =20 +/* + * The base for the uvc driver controls. + * See linux/uvcvideo.h for the list of controls. + * We reserve 64 controls for this driver. + */ +#define V4L2_CID_USER_UVC_BASE (V4L2_CID_USER_BASE + 0x11e0) + /* MPEG-class control IDs */ /* The MPEG controls are applicable to all codec controls * and the 'MPEG' part of the define is historical */ --=20 2.47.0.338.g60cca15819-goog From nobody Sun Dec 14 13:49:50 2025 Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB90A237A34 for ; Tue, 10 Dec 2024 09:43:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823790; cv=none; b=uzSriCaSdLZiOrHcdLd2NJYx2/QFo9sSBmWopaCOijISCLGWToLihF8bjbbIrZ8qrc1Sd8HGby6n92F8UNKX9hZIZsMn8NWm9TIICa26P+cLarWoRX/XVLzUtQLaqq6TvGHqupEB2ZjXS/BDvJuNGbu8G6ffklwRfiPWJsGrFWI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733823790; c=relaxed/simple; bh=fKDUU4+a+tgFts82eq+chwHIWurrBXbxHGkI4O6ed0U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QJhmQgj9lfrp4xHlfBoch86Ju9wWa2Taa90F/ExdXFA+akYsQOf8FJpXwm/92sIZAY8QNDRknHVYlJGzLIkg6vOGu+zQE2FF9l7uV3xkX/nghAboYzuQW8ORYR1lG9MiQq1DxHRwEK1yE2fMzJJDT+5Forc9qQEfeQnKVGYEhGg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jEQOMHTH; arc=none smtp.client-ip=209.85.160.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jEQOMHTH" Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4676aad83d3so15088901cf.3 for ; Tue, 10 Dec 2024 01:43:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733823788; x=1734428588; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=LcSM+HEV8BWvpd8XLVPPgYNPK82Sc3PIhfJhk9lYWic=; b=jEQOMHTHW1SSFfR671K5xpr4OpCloXT+RjDqJUcusgkoguVlj8sWmMNeXDbIOJYtnZ ahVbqTSGc2yhv6ZVxR5c5MCLt4RAlai6IiYHko1Fi06muXVGCevHsEWv/Qw9N53V5rUz 81TpCVmiBwXwd2e1uujtZvRgJxhXADAx/36Po= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733823788; x=1734428588; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LcSM+HEV8BWvpd8XLVPPgYNPK82Sc3PIhfJhk9lYWic=; b=WjRRDeE53U+R6vEPjYOlAhtqplS005nkXE/L1O0crd4Ffwx21LRda3WOEG7OtQKRR0 5c74iuG67UQjPRxR2LBcKQXq46Cj/vJ7n09DFEDeLYlrmyZKqRcRgPi4wlNhxylyIUAb 3tpR0EYSQYf3C/ke1QVYoGyL7xR0zQaQcO1Y3NE4KpqlPPd/YmbfHKwe+BB8nd0IgXM+ F0QkYOZVWnbMwGDaxkb0ha+yJlPskXc6X9Trua92hcKedn3PWAEAFMTU3+uNggyEVkLv 2U0v43AzSbIayRvHsq1mh4iOqeEBG3rmiQws94tzMQj/HnVzGMhEZtU6/rPdeK/u0nTk eCjg== X-Forwarded-Encrypted: i=1; AJvYcCU6mh1uSyaxvSAlfdp5JGQiAcebunlsCJuM+5czIoIIQTYOLHJadgo3aKSYryYw/yUlMsUjj112wMNmn6w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5O668jGDBCBDP+tIExQIdbOzUM+o+p07zZDEstAPMr2dvCVbD zTu3BLKZwMd14/2Qh9VKFymtEYqp8VBJiSOYKBSJ59r8PV8pz85FyIgUGZ588w== X-Gm-Gg: ASbGncvdi3NBPym7odrRPiU1mG8TNbzxlVTTluJeKylhEJIIlgvPMq+qqYkdZjfKfCK 1hkcTusDUo996JvGmKcD1wzdFS5x8q8dNoaSsjdrcJjhX5LGVBVpsLmnlz6QoCtp8gOhr9Sk715 WabY1bStjf0dRFxSJfOxYptgZ2nuhdvYQWtEKV8wokZ+LWhaS3scl5++HftQuv71vrqnR07MnVK 2I8vvXA41JTW5YiTsk5lpyZ9jz4mXt2vzl8P99xCE/39H72a77Gwauc1xP7xFD9PTRKYZMUfmdJ +Y6CJcffQC6T2n5qpmgLQa8yA3lg X-Google-Smtp-Source: AGHT+IFtCAY1FI+TINr0gaxNPy0pUOg439RuOUTCEezTgC51c5iK/b9dchgVcUIE8AI0mMGMWG8sDg== X-Received: by 2002:a05:6214:e6b:b0:6d4:1dc0:2620 with SMTP id 6a1803df08f44-6d91e4465a0mr64808496d6.40.1733823787859; Tue, 10 Dec 2024 01:43:07 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d92f7c2bc1sm773326d6.83.2024.12.10.01.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 01:43:06 -0800 (PST) From: Ricardo Ribalda Date: Tue, 10 Dec 2024 09:42:54 +0000 Subject: [PATCH v16 18/18] media: uvcvideo: document UVC v1.5 ROI Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-uvc-roi-v16-18-e8201f7e8e57@chromium.org> References: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> In-Reply-To: <20241210-uvc-roi-v16-0-e8201f7e8e57@chromium.org> To: Laurent Pinchart , Mauro Carvalho Chehab , Hans de Goede , Sakari Ailus , Hans Verkuil Cc: Yunke Cao , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda , Yunke Cao , Sergey Senozhatsky X-Mailer: b4 0.13.0 From: Yunke Cao Added documentation of V4L2_CID_UVC_REGION_OF_INTEREST_RECT and V4L2_CID_UVC_REGION_OF_INTEREST_AUTO. An example of a userspace implementing this feature can be found at: https://chromium.googlesource.com/chromiumos/platform2/+/refs/heads/release= -R121-15699.B/camera/hal/usb/ Reviewed-by: Ricardo Ribalda Reviewed-by: Sergey Senozhatsky Signed-off-by: Yunke Cao Tested-by: Yunke Cao Signed-off-by: Ricardo Ribalda Reviewed-by: Hans de Goede --- .../userspace-api/media/drivers/uvcvideo.rst | 64 ++++++++++++++++++= ++++ 1 file changed, 64 insertions(+) diff --git a/Documentation/userspace-api/media/drivers/uvcvideo.rst b/Docum= entation/userspace-api/media/drivers/uvcvideo.rst index a290f9fadae9..dbb30ad389ae 100644 --- a/Documentation/userspace-api/media/drivers/uvcvideo.rst +++ b/Documentation/userspace-api/media/drivers/uvcvideo.rst @@ -181,6 +181,7 @@ Argument: struct uvc_xu_control_mapping UVC_CTRL_DATA_TYPE_BOOLEAN Boolean UVC_CTRL_DATA_TYPE_ENUM Enumeration UVC_CTRL_DATA_TYPE_BITMASK Bitmask + UVC_CTRL_DATA_TYPE_RECT Rectangular area =20 =20 UVCIOC_CTRL_QUERY - Query a UVC XU control @@ -255,3 +256,66 @@ Argument: struct uvc_xu_control_query __u8 query Request code to send to the device __u16 size Control data size (in bytes) __u8 *data Control value + + +Driver-specific V4L2 controls +----------------------------- + +The uvcvideo driver implements the following UVC-specific controls: + +``V4L2_CID_UVC_REGION_OF_INTEREST_RECT (struct)`` + This control determines the region of interest (ROI). ROI is a + rectangular area represented by a struct :c:type:`v4l2_rect`. The + rectangle is in global sensor coordinates using pixel units. It is + independent of the field of view, not impacted by any cropping or + scaling. + + Use ``V4L2_CTRL_WHICH_MIN_VAL`` and ``V4L2_CTRL_WHICH_MAX_VAL`` to query + the range of rectangle sizes. + + Setting a ROI allows the camera to optimize the capture for the region. + The value of ``V4L2_CID_REGION_OF_INTEREST_AUTO`` control determines + the detailed behavior. + + An example of use of this control, can be found in the: + `Chrome OS USB camera HAL. + ` + + +``V4L2_CID_UVC_REGION_OF_INTEREST_AUTO (bitmask)`` + This determines which, if any, on-board features should track to the + Region of Interest specified by the current value of + ``V4L2_CID_UVD__REGION_OF_INTEREST_RECT``. + + Max value is a mask indicating all supported Auto Controls. + +.. flat-table:: + :header-rows: 0 + :stub-columns: 0 + + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_EXPOSURE`` + - Setting this bit causes automatic exposure to track the region of + interest instead of the whole image. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_IRIS`` + - Setting this bit causes automatic iris to track the region of inte= rest + instead of the whole image. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_WHITE_BALANCE`` + - Setting this bit causes automatic white balance to track the region + of interest instead of the whole image. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_FOCUS`` + - Setting this bit causes automatic focus adjustment to track the re= gion + of interest instead of the whole image. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_FACE_DETECT`` + - Setting this bit causes automatic face detection to track the regi= on of + interest instead of the whole image. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_DETECT_AND_TRACK`` + - Setting this bit enables automatic face detection and tracking. The + current value of ``V4L2_CID_REGION_OF_INTEREST_RECT`` may be updated by + the driver. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_IMAGE_STABILIZATION`` + - Setting this bit enables automatic image stabilization. The + current value of ``V4L2_CID_REGION_OF_INTEREST_RECT`` may be updated by + the driver. + * - ``V4L2_UVC_REGION_OF_INTEREST_AUTO_HIGHER_QUALITY`` + - Setting this bit enables automatically capture the specified region + with higher quality if possible. --=20 2.47.0.338.g60cca15819-goog