From nobody Wed Dec 17 12:45:58 2025 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B59B478F4E for ; Tue, 10 Dec 2024 14:16:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840216; cv=none; b=cxem31BzolI/3N/dlzvbi6UAoz1zO0IH6J22Xy/uy5UIAPRo+lc83x1j0CppmjYaXY1A3Xv6ECZvyameYUry6z/20YSrsBk8H3v96VtM9TmcM3mCEAjS7mxXwLIn7ILQLEF98TEtngXFBvQfmLkNoQ0Sd8Re7twwDY4vN48lj2c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840216; c=relaxed/simple; bh=w8Xw25H9E0EowRWue4E3JonkkP8YUynIV0Mvq3TC5nw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=adRSMYgEmMc5RYVfHA1hDHxm0tljrAgU0LnHetCS9M+HOuUR19fl1Lg3mh+p1GpEp2w3gy9hyMd6ZALLD/nfpnBV3MaHTntHJVoXWkZl5RSTWzavJDBBDzQpRvS3lwqutw0QAv2w2xbdjut0Q7xQQs/ZOj0Zq/vNQ+pzAMeLxE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QwY6imyY; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QwY6imyY" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5d3dce16a3dso5700570a12.1 for ; Tue, 10 Dec 2024 06:16:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840213; x=1734445013; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YDx6hbMot9hPe7Zgw4rNyld1Z3a4kDtP9bTMjfYhMss=; b=QwY6imyYllfFqBY69tDTkoiXMqAshJur9qg6/rK1dQTTV1peFT6m5+Yoilpm35UWpT S0dJ1Mix8BQyHcDv3+c867gJaFDoMfWIltai9dh5rHlIl7tzACs7LipaEiJz2G1PCYA3 BRi5TAy+1PBbUDLNUYjQCx7x51Uc3u1MVdWs8g4bSfDQASLSA70ajIAg40PnX74Wrhp6 6iSe2A12Wy8fVNnp7sGrVQHimQ8Xeiu2kG9xaAgy/PnPMpDup9zVISVV+rqPv/hKWTT1 F0fZz+8kCG6ntY7JCA7dG5p0gns0KgZYD8AAPLCbAC+S2RLac3cYhr7iPyxCBGvPYf5R ttvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840213; x=1734445013; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YDx6hbMot9hPe7Zgw4rNyld1Z3a4kDtP9bTMjfYhMss=; b=v7IuHVxk5nUJGVg0vZnI0YoqkjlI00ER9CmzHAH84V+zdpQpQy1CX/W6FIleLlBzsT vTQ6kehVVmFhXZrV+G/4vi5/6Ma76xA9wi3XQLYwtEGrHIG7yajghZHiB/cdfFYN85Ro zPToaipnRfPIvRJ2KNRqt4flYDnifPaCEyC4ZEnVWquaTOi12olhn8vomz07PT3IVPX1 IeZiZa+X5Xk75Wuh7s93awztNRSIEkf6aUqsnvlEvIJP3VmqS6wqfGlsX5llT6P42lBM S5tDzFFdnzgoy1/RAaTRyNwEOwWgGgdwIfUELZno2MWszCRmmFMEgZxcthpgU9Le8q7p yA5Q== X-Forwarded-Encrypted: i=1; AJvYcCU93Hpo7hWhws7XhkQyDLg6jTNiYWqMwLDc+whmXM3gHPIaKZKK2McTmBM9zKvk42zvhC+qcyoZN9C0A4c=@vger.kernel.org X-Gm-Message-State: AOJu0YxmY/xxhHdtPbZWA29oBvMCSoskJLUTtljehcMBNaw7fP+10iYG 63ugqsbyIlqbwGvUG225tSVGv12UzVscA2NuR2q+pGBI6RvBN/AoDgl0xIhWjEU= X-Gm-Gg: ASbGncvUwYJrx+EvUQoPTeC2SkX+bJd/EClM5jYau+jS40WWbszbDKlBxiq+BqRrwGH FaZ3QMcQfRUuZ7guqhm2xY0yfSrEWVnLb4zKtcZA0ktkS1QTOODEjq6Hyt3MLBe5MmnaddQAUe0 d9oeVACJ2F+5nkUQmN8RbVd03DPuBNFnu4ZqfO39GBKbsfYZLgiqo3o5CJCn0NaGfQr2p9NLlmB WwutkbvKNE/2N+u+mROeAuxbWowUXD6j3UtgEbsBjT7IuEOBDtTtNfS6COtjA== X-Google-Smtp-Source: AGHT+IGWT8mMHqxsdN4hdP58Pe8rJU3Stb8+4FvxSrZ3iQfKkTBWo2xyAfZGSkKZNrpT0n9roYgJVA== X-Received: by 2002:a05:6402:5212:b0:5d0:b1c4:7081 with SMTP id 4fb4d7f45d1cf-5d41e163a48mr3441285a12.4.1733840213072; Tue, 10 Dec 2024 06:16:53 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:52 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:47 +0200 Subject: [PATCH 1/4] drm/display: bridge_connector: provide atomic_check for HDMI bridges Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-bridge_hdmi_check-v1-1-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=w8Xw25H9E0EowRWue4E3JonkkP8YUynIV0Mvq3TC5nw=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1R5NPKL4rqV+jR0KPOXn80x27rRanZM+VQ5 Q4r9GgPzaKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUQAKCRCLPIo+Aiko 1atnB/9dz6pBR9aU669+5H2pdnKug29xlZBRPLZmzo+E5oJewM3cZD09he4jEBfGB6H63phwgKT PCpN6NcXKee8q0yILHUXjqQPoq0+AETXNH6uHzI0+4meAAff39OFtOxfONhTOBikdBNVu1/L126 34Smslj0Au4U5ptSosFI37VyPtgVeA3YkXyr762Thi+gFQikGCujFrG4rmoYiMn7YiCtGjO2kHo bAYnERIBIUqUoLvx/uC1WeTp2w3aS+e4u4SjSuB5yGIiPaOyqOw5Fwn0eyiotVWCwsbb0E6Oc6E XV7eLYsE+JEFYPpHPhaLSGyysWCYM1XeqIHTJMgcP4HrwECy X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The bridges using HDMI connector framework have a call to drm_atomic_helper_connector_hdmi_check() in their atomic_check() callback. In order to reduce boilerplate and make simplify bridge's code, use drm_atomic_helper_connector_hdmi_check() to implement drm_connector.atomic_check() for HDMI bridges. Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard --- drivers/gpu/drm/display/drm_bridge_connector.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/display/drm_bridge_connector.c b/drivers/gpu/d= rm/display/drm_bridge_connector.c index 512ced87ea18c74e182a558a686ddd83de891814..f6e0b6f1ffdd392ee15ddfd9ec8= 5452a88122d42 100644 --- a/drivers/gpu/drm/display/drm_bridge_connector.c +++ b/drivers/gpu/drm/display/drm_bridge_connector.c @@ -313,11 +313,24 @@ drm_bridge_connector_mode_valid(struct drm_connector = *connector, return MODE_OK; } =20 +static int drm_bridge_connector_atomic_check(struct drm_connector *connect= or, + struct drm_atomic_state *state) +{ + struct drm_bridge_connector *bridge_connector =3D + to_drm_bridge_connector(connector); + + if (bridge_connector->bridge_hdmi) + return drm_atomic_helper_connector_hdmi_check(connector, state); + + return 0; +} + static const struct drm_connector_helper_funcs drm_bridge_connector_helper= _funcs =3D { .get_modes =3D drm_bridge_connector_get_modes, .mode_valid =3D drm_bridge_connector_mode_valid, .enable_hpd =3D drm_bridge_connector_enable_hpd, .disable_hpd =3D drm_bridge_connector_disable_hpd, + .atomic_check =3D drm_bridge_connector_atomic_check, }; =20 static enum drm_mode_status --=20 2.39.5 From nobody Wed Dec 17 12:45:58 2025 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E30711A9B5A for ; Tue, 10 Dec 2024 14:16:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840217; cv=none; b=iD8XsFQYqwY2CPVHCgE5AdZsBHXpl0vRtEYKU1+MPK1z4NaRPUl4QlqflsPnnII1wqOEmCVd362rGIh+Uo4TMIEesMHXv6MY4wzyIdY3KGL0PBCQ5UgPqWVUZ8IllmtJAlgtvI3n2ZxOxO+8Le27OUJ0bV2HZfprVHeZjpqrW/o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840217; c=relaxed/simple; bh=rB/0Gsa/+27l3uQdwPdG65mhrhs66t5UJhoR+oY4WrY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pIys4Vi0L1yPF1jFdwwf/muvK4uA+zGBb9MWvxbipFUVibelQfTEyzJuC3Ek7ljTXqcDIw7i+WV7jCkT8jHo8jtu2cEy4IeWkrV6syC0Q6lPlHS5cAHFRxbqWhtG+6J9XVFWXtxXlk5MPVKv6rcscYU2omCVp+V9BkvEp0MFkAw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=iG3Hgv0h; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iG3Hgv0h" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5d3f65844deso3709554a12.0 for ; Tue, 10 Dec 2024 06:16:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840214; x=1734445014; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6+crVXPu3DLH2LlYuBMFmzZfW/018nLXCNXzwVqSUhk=; b=iG3Hgv0hyDtaIBIfmFy2AFvJnuuKteWENrwLDocCh1RG4waWkHL00AgXb1joLHAASl 7J3TKNLmBQf+27crlBnnHSm4KXW0oTZw3LhDG1pPsbEiECGzTgRCb6SN7tEGhOPFZSAw 5Og2LUc+Dcwq6vvDQOxcBEkp/y9PglFcQyPAqPUXGbSAMkKe9zHzaKE/Vs97cnE2TZdL jBvQQE3PF8OkD6CCj/g5SaJxHuHRME0qhJTmymHVmpC4eaoyalg7C1V4ThHe3QHs610v JhfBxnKQ+IUK53zJNkXTqLh7wGg4CTiehmTu3sfmcdt7tVA11xzjCZsGjbWKZMHC77mB E7bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840214; x=1734445014; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6+crVXPu3DLH2LlYuBMFmzZfW/018nLXCNXzwVqSUhk=; b=kYLWRl7lVWqrh+i//XdBt+pkBVFcq849L/4Yc8aeJbGOYPvJkBQDwHlDxvGayKNdp3 Q3vm3rudwxr4Q4C87l/jvu1sxzhVCz73z7KcSej5L8stTqqbzXtDLcFygA9HzRUwozsO 6dI7nSM7PHdWdeoVjqYQM8X1Cj9/wM8V83XqJaCOLuMw5i5ZOCN4aYZ9bTbTDEJKnJg1 y+JiXnTU8ENgK6tvjSsoCejZN8gcj1lMW5b+hk7mZfpQZZgfmiF80pQRlTHKQhtW3syV 1HCfXAqrBFSOPpvIrAQhEiYr+MAxfxdhABEPFAilcQEnti/RA72gSPOIXvACH+YOcFMm 10pQ== X-Forwarded-Encrypted: i=1; AJvYcCWI3W1SDqBBOOBw9HOY8Al8/4PTsxJXdjTxm6VF4zQtpSyaEXvyWp5FTuBg5uHdY+jZxliAhR7XtjLzovg=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0d9TmYcwDGRUL5G883TNJ0xk87Tx4idH/c9frNwBBZHk+g7At bzLQuJ1HjbsO7AoXX7YIUi3b5LEttYodoo3Xlvz2iIF9yKmfKUuWgJUxkAeBNdY= X-Gm-Gg: ASbGncvIWTIe6tT64LjVlOZCqQxxriVkgpPNImmFfUqryOUqFShCWZYMl0SwLttJzFY 7jmN5fE4gTCyzT463xZaq2kf3a18aHPTbA1N+WpIAdhq6qXTsRIYKJGMkBLfB+HeQLMDxY6URYj 8xIVrDNdLZ7avP3EZGx3+lDogTry0lhB7XljXbkbxKQnUIwLT5OwM3J2kdaPVPwxMkjIvqKTTXZ LNtAlLPNXWx65yoqcg7a+/EmTTX66yaKO7f7KgJC9qJxn8tfHNnId4i3AvtLg== X-Google-Smtp-Source: AGHT+IGxZHjKR5SCMI0IfbjDGhMhOA5BIzHnQ1eSiwRBGeabz2+uUXHR8Rsyhp3v0sQ66agXWWUdHA== X-Received: by 2002:a05:6402:1f11:b0:5d1:226e:e3bb with SMTP id 4fb4d7f45d1cf-5d3be715252mr15513178a12.19.1733840214182; Tue, 10 Dec 2024 06:16:54 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:53 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:48 +0200 Subject: [PATCH 2/4] drm/bridge: ite-it6263: drop atomic_check() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-bridge_hdmi_check-v1-2-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1627; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=rB/0Gsa/+27l3uQdwPdG65mhrhs66t5UJhoR+oY4WrY=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1SrdHcDpzN/kkXAE+ciWoTZRgyac4hMJI58 4e4awoizfWJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1c0XB/4wCdakY+iL+5vJu8w6sDWGCs1YreJcnbtzjAEPWnpXIXQe9AtTgrQ7y8qGSCkS94VMf34 WPn9zTT1BAhvOBqitBey1l0Z/m45w/2OirgOn8X/LJGqXRqGtK0mhvauVdMdfMZszXABfn/BQwh A8nuYp6UNxSTdqSudtixSGD8jZmgwOuGHd5ynNstJuhuW9e6S4sRlkC22M2ERLr7WNSFNukqNRE KFZ+CW76ORQdCjyTPmRe9ZE3nwpYwf9XQ/z+KfHgK664N6wg53/Nf/f8VkeDILhC68jlJApptwi lwG3uuOZwuujl2LZAyWkFqNu2qDVp6b6pOccFcxzDOKBDJ0h X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard Reviewed-by: Liu Ying --- drivers/gpu/drm/bridge/ite-it6263.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it6263.c b/drivers/gpu/drm/bridge/i= te-it6263.c index cbabd4e20d3ebbe632a60f7cac73302815fab7d8..902444317d67e7a65ab05568fbe= 6f4571c500585 100644 --- a/drivers/gpu/drm/bridge/ite-it6263.c +++ b/drivers/gpu/drm/bridge/ite-it6263.c @@ -550,15 +550,6 @@ static int it6263_read_edid(void *data, u8 *buf, unsig= ned int block, size_t len) return 0; } =20 -static int it6263_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - return drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); -} - static void it6263_bridge_atomic_disable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) @@ -793,7 +784,6 @@ static const struct drm_bridge_funcs it6263_bridge_func= s =3D { .mode_valid =3D it6263_bridge_mode_valid, .atomic_disable =3D it6263_bridge_atomic_disable, .atomic_enable =3D it6263_bridge_atomic_enable, - .atomic_check =3D it6263_bridge_atomic_check, .detect =3D it6263_bridge_detect, .edid_read =3D it6263_bridge_edid_read, .atomic_get_input_bus_fmts =3D it6263_bridge_atomic_get_input_bus_fmts, --=20 2.39.5 From nobody Wed Dec 17 12:45:58 2025 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 198971AB533 for ; Tue, 10 Dec 2024 14:16:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840218; cv=none; b=elG7TxpPsFFB20QYx+crIgs6BMYwpBwT+BuPZa6bKgtaiUUsIrriIsOpU7sDUR333aSzTdYZMVPt0bblVb5djD1bYbokFlqS2XT2ap8cRPBvMwX0HTp2jQHgPuvmBjzasgjYnITvhxlGOa1lDWsI/QiscW1+Qg1awSMExzM3xb8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840218; c=relaxed/simple; bh=Dv9z5EQ6QS4Oh3NjXL0UPCIboG/Nxyen1A1+0E3853U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DNYz21s4H035Ce9wriPKJELxtrQMgF0lygpwg7sZAH8rRPOTha84vjw11olehg/RdOyTmurcif/roqkrguRQCocGevPMVyMBKFJlT+SXZII39O2X1LfnvUSkq79T9oeoycKlFIZstppZEpaSA0I/ImefJdX7FH7fUaQEwvlFiH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZacQnUJ4; arc=none smtp.client-ip=209.85.208.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZacQnUJ4" Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5d41848901bso2618594a12.0 for ; Tue, 10 Dec 2024 06:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840215; x=1734445015; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=KG04n3jH1DFELR10HVCrrQfC/3zE3v8nOQLbFlHi9xk=; b=ZacQnUJ4UFpJ6L9J2PBNQKtkvibehSkqEtS6LUCStkF8cWKXz2u+Vnkn3SuXwLl+8B tY2qzGuzrzqxoiOpGjrjUPJKvL4o4oChRK3OWOvrujhlbB1y9RuWqQXwEB1V3GTt+Yoc iY+eh7RCbjunY1PKcFJBU1mwHok9BN8/MCnQdLnwhS4lt7ijbmqJgTQndCLeo3Klm7Q5 8mUVBF74EsDD4HW468WbBgRSpIIu6Or3wN6Xq/R6YSDsb11wPFxgDo/Y225wGTO+Mt9a Ojf+BIp3KpKKet3OIkj2DwX1f85XICdQCalqtayfebd2rg+jC8C2Vk530N1AP1U09Frj ji7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840215; x=1734445015; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KG04n3jH1DFELR10HVCrrQfC/3zE3v8nOQLbFlHi9xk=; b=RNqSUkH1oqAOyEd17NZ5rSgH5sRGMSsBbv83jjf5TkkXCe4ugRiv7DsNNUsW7YxDAD 2gNHthWDjv2pYCO4W+PABpgwwLwCBmBGIruoIGLVLzbrm2+S7CM7S0hCYGvvEWi9Phyc /iwyV53VhtUP7am8IPc5zX0IU9nu/O8ZpmVU53UG2DsC1+z75U8Qt8i8G4rcZcloZImC 94QOXVV19R8c7a83N/V28wvyTsPiwmycwG+l0CgBctCu7NAOvWF3LYjHzpIt9PoHvkTr Vi49x3FXlaGoQOKaXaTkV9HCIOgGNl35aH75A13VIPrRXR8P+z0w1+ru/W/nM+7gnjX3 ElEQ== X-Forwarded-Encrypted: i=1; AJvYcCVjCeZcDpegKKwwK+aFstyLNhVRjRzuFfaxO3VZs9VBqaUH72g8LK7hc48SRwJ1Fp6nclJopM2d6Ke7Oxg=@vger.kernel.org X-Gm-Message-State: AOJu0YwPM/zH2EGwCQyl/8AXYVi9JzTa1ne/U34B0kFiWrm00onmT6Jc 0kwsk6AlY1mXjaS6HcGjjq6OOIhQam9mLcbv3MGsq0Xktyf+YWELKPEt1OKS8fU= X-Gm-Gg: ASbGnctBZkp4mBvdIrHLaExvpO1EGhyv/XmJ+iSVJI37nKAa6CJ/461MwL70Qq3c8Lu PpiFLdwWiC60nlMknZ7UG9FjqgB5KiHl8A7DCtLyY0z7U0WXS6qesAJjuhefZOAnUxUNksKTZzy c6K5riLS9ttVKWRraMyUi0I9KKJMHr72hbhsVS+Oay0rWQa34vNatW4LxnvWpdr8jDJjf7wlM5e 1auRCbzXcydY58otRDC5Ghn1hOe5yxl2wtOmR2+pJ3lGqOKLV+cUZUUeI1A8w== X-Google-Smtp-Source: AGHT+IF8sFjqWDAeeHbyCT42Lo9bApykjgIi669+j87CMogHug4+toN6HpTcfoP9+THi9qi2bknF3A== X-Received: by 2002:a05:6402:1d4e:b0:5d3:cd9a:d05e with SMTP id 4fb4d7f45d1cf-5d41e2a7ce6mr3458173a12.9.1733840215431; Tue, 10 Dec 2024 06:16:55 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:55 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:49 +0200 Subject: [PATCH 3/4] drm/bridge: lontium-lt9611: drop atomic_check() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-bridge_hdmi_check-v1-3-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1610; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=Dv9z5EQ6QS4Oh3NjXL0UPCIboG/Nxyen1A1+0E3853U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1S/0Nn6akcX1McXx0ZVZ1AI/dMr6QkkQx/u U7fii/uAsiJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1Ws5B/9oZ0/B7Eid9JGphPr14wDxOw29qknjLVHN5U7NEDQ8dTTi/dtbyoKPzfPnFFN9dIwGtem prJkHHRdfpP7LhRqHneiVD36zQCzdQLIgqZVBLaov/fZF6zWQ6hDKZn2LmAB7lDzbqm6QBuBPt0 Mm06Ike4H+6d3galuqrXSJz9a747j81Lc1142qL1UGobmHzTb4gLlhLPab8l++29FWXY60kMImn 0DKEX5nwYTHM0g+J8Zb+tRum977h8CXvl5yCLQJ/aOM7o0o32N59NziNqXFoN0ePdWDYXxdrqa2 m7FfIhlygeUX6aIyYBkpvoM51yk+ZRB67f6CRUpo61LW/I7r X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard --- drivers/gpu/drm/bridge/lontium-lt9611.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/brid= ge/lontium-lt9611.c index 1ffbe473e4103dfc315a8cd3571e9407bf518797..71edb2b659de374c88b453a90a7= cae902b97d91b 100644 --- a/drivers/gpu/drm/bridge/lontium-lt9611.c +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c @@ -767,15 +767,6 @@ static enum drm_mode_status lt9611_bridge_mode_valid(s= truct drm_bridge *bridge, return MODE_OK; } =20 -static int lt9611_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - return drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); -} - static void lt9611_bridge_atomic_pre_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_bridge_state) { @@ -947,7 +938,6 @@ static const struct drm_bridge_funcs lt9611_bridge_func= s =3D { .edid_read =3D lt9611_bridge_edid_read, .hpd_enable =3D lt9611_bridge_hpd_enable, =20 - .atomic_check =3D lt9611_bridge_atomic_check, .atomic_pre_enable =3D lt9611_bridge_atomic_pre_enable, .atomic_enable =3D lt9611_bridge_atomic_enable, .atomic_disable =3D lt9611_bridge_atomic_disable, --=20 2.39.5 From nobody Wed Dec 17 12:45:58 2025 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C6831AF0DE for ; Tue, 10 Dec 2024 14:16:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840220; cv=none; b=HldcRHMPQLgR2K2ZhuwlB7o5aglAeEPo9vlhSShE7wedI7gvsXTzoMCV6IDJhkc1bft4wyyef6z93LIhr19Tr8TEybMsTcZorSp9V66Xo3xahQdf2jpoS+roRJHjeDBkBhe+ESjIJeCsKIWE2x3SpyDSbN8/TV5eEqr153Rc5ZY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733840220; c=relaxed/simple; bh=iFbekFcbElRUJbcXMzK8ElBDVWKjAytyCvWyk7X8SUk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Zm1Slr874fjc96uBKPmqTVkF63Yc6TfnDrWYaAcY0saSrkVxxUHvzxxb3pA74sGELP3jdGNmUUGIJhZSNzhESo0Nzs0U8UE1Ea8IBTNFAjNwvk1ohMrJQTQ4fCrvzusLpjwcGFTlRywa/NIH20k31cHAl2gpYh1DABaTeNRAb9g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BUx3Wh4t; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BUx3Wh4t" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-aa692211331so339732166b.1 for ; Tue, 10 Dec 2024 06:16:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733840217; x=1734445017; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8VieodBk7g9+NNIIq8wzqsxrxxT4oOk+FbtOuCNcBAU=; b=BUx3Wh4tzaInkw1out7SiCE+T2crAotVefwSsbXaJl/87D+Blg4Xka958x8+Xky8ib 5xr/xSEAlOSeoR1ZSuBMbrAWcOOtcllgDaQ5PGLsesO/D9yBIeHaVH7zoAUHQTQl3jYh fljMyrESxDJuzE4gkTOeu5sXZfCkvWkBIt45mdjs/WDkw2pLYKoAxEfLiOtEPj6LNNK+ +F78TL7hvNm1e8dMRu70zTVGx0DX3OljsAiOmVIPlSUPSVMcALtWR2xY7BY/FQtCzNUv HjQPqY/tm8xbAeDfx9xN/DzEWlp/pTMRA2rqymGDD4yCoMcISuv7600rsAzC5+TD0KSQ BCIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733840217; x=1734445017; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8VieodBk7g9+NNIIq8wzqsxrxxT4oOk+FbtOuCNcBAU=; b=OQSAZ8mmGlt8K/MuRgOAvPZvWciVTYWokD64gTyznus8SFqRRf/tWBxWVDPHPh4KpU xVt7wqVb5T2AASnDsPuuv/xVpDtXhfTze9GmnCPuiku3XOv5n0Jwxh3VsYWDSi2ToPop mNswb2K9TgkNZZl8OfQBoMb+5m/8OJi9VkbLR4cl2S1emGWxlcJ49D0CEVYc1G+wb12O 7mG9uN0TlP7ujjgkJxCu+DnUhi4E51iX3U58JsI6cK51BobHNX/GiE7N9A+j0w+5/FsJ qvW+y+jXUGno2XUBliv6QbxCRicycX6VMUVdOYAQyVnbVi8hEAkOTfntPcHNA7YJwjgY OKiA== X-Forwarded-Encrypted: i=1; AJvYcCWAJrJTVZmBe6sXsYhU7r9WMVKgWnOP77h7oU5H3ixUVCinCVCtPGlY20gEiyxXIellh3aV9gKm2LOVI6o=@vger.kernel.org X-Gm-Message-State: AOJu0YwxDgqHUHDVLlU+oJ/4DBGjzpqw/J+y7nafGqVSMfTD9vPzAiwd JXxmbELa4twi8GVKdl8zKxnkl8nTWu2B7esHaYxLum3Y4+TlH+oo8VWahhzJYWw= X-Gm-Gg: ASbGncvSxpfAWf7Ls1oJFsfni5Hv3vY/N5V8oVDtlLwGyyhJ2b8hvusGP/m5v4bk0r3 He0MztchKI47umPKNEROn/v4CmjrXrvcTpU1tQ5Xaikz5ROUrPI9OYFwRIO0DXmsk8/ZILgxSWs Fnw2Cbi37DU+wSoNVYj+eM3WsI2Af+oN0V2EPm1pfNVu0H1E3KkmH/zt0OeLZNjh9XDvHz9lkLB euIgIH9jVdAo/fbcISRR7eytY/wpWwRnXYS4MFQHk0tL5uyqTiHQvsEOp9vhg== X-Google-Smtp-Source: AGHT+IFqj9fbpUiNnMEmvJaqOFp6heSbFuzVSyMydyTzS2DZeEIE3lH+oK4BSZlyPgf81n83uN7jJA== X-Received: by 2002:a17:907:3da1:b0:a9a:6c41:50a8 with SMTP id a640c23a62f3a-aa6a01bebf7mr370929466b.17.1733840216571; Tue, 10 Dec 2024 06:16:56 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d3dc2602b0sm5104362a12.18.2024.12.10.06.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:16:56 -0800 (PST) From: Dmitry Baryshkov Date: Tue, 10 Dec 2024 16:16:50 +0200 Subject: [PATCH 4/4] drm/bridge: dw-hdmi-qp: drop atomic_check() callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241210-bridge_hdmi_check-v1-4-a8fdd8c5afa5@linaro.org> References: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> In-Reply-To: <20241210-bridge_hdmi_check-v1-0-a8fdd8c5afa5@linaro.org> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1866; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=iFbekFcbElRUJbcXMzK8ElBDVWKjAytyCvWyk7X8SUk=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnWE1SaxHLSu0OtwBtkIyYbWi0IxmjxvAGhmxU9 sS13D1+OkKJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ1hNUgAKCRCLPIo+Aiko 1UE2CACOGOQdt26+zxC6axMeEn4OWtbasMLCfvKvA1gR4JdDpUaq+snGJvhcXNFOjtt9wRZiyoU NwA3TsTrw7jLPoeMiTgDTbOnpOJlfU3jUM9O20cerZqKPELyWcgL0Ozi9WvwOjqW32T4OtS4Zzu eT5+/7pHAGGBIlrWyq9PH8QhXjJUM5eYBYhnzLpQZLL/zCcrLilrQ52M7x+1VuQoDN5lvLOum3T UvoHF6rMV6yb0s5T+lzBPB19mjwLfKlKxyTk/lnLHPY63nsf0XvL7vlimDibnc5inXoiN1pwu1n CD7wjE1v3Qm5jgejFH8SAgaghLW1R19Q6YdkyRRyZ0TtCWX1 X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A As drm_bridge_connector now provides atomic_check() implementation which calls drm_atomic_helper_connector_hdmi_check(), drop the duplicating callback from the bridge driver. Signed-off-by: Dmitry Baryshkov Acked-by: Maxime Ripard --- drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm= /bridge/synopsys/dw-hdmi-qp.c index c686671e4850a1af75b82995185ffc3cbb22a447..b281cabfe992eff88a4ba7bc903= 758bb119281f2 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -361,22 +361,6 @@ static int dw_hdmi_qp_config_drm_infoframe(struct dw_h= dmi_qp *hdmi, return 0; } =20 -static int dw_hdmi_qp_bridge_atomic_check(struct drm_bridge *bridge, - struct drm_bridge_state *bridge_state, - struct drm_crtc_state *crtc_state, - struct drm_connector_state *conn_state) -{ - struct dw_hdmi_qp *hdmi =3D bridge->driver_private; - int ret; - - ret =3D drm_atomic_helper_connector_hdmi_check(conn_state->connector, - conn_state->state); - if (ret) - dev_dbg(hdmi->dev, "%s failed: %d\n", __func__, ret); - - return ret; -} - static void dw_hdmi_qp_bridge_atomic_enable(struct drm_bridge *bridge, struct drm_bridge_state *old_state) { @@ -503,7 +487,6 @@ static const struct drm_bridge_funcs dw_hdmi_qp_bridge_= funcs =3D { .atomic_duplicate_state =3D drm_atomic_helper_bridge_duplicate_state, .atomic_destroy_state =3D drm_atomic_helper_bridge_destroy_state, .atomic_reset =3D drm_atomic_helper_bridge_reset, - .atomic_check =3D dw_hdmi_qp_bridge_atomic_check, .atomic_enable =3D dw_hdmi_qp_bridge_atomic_enable, .atomic_disable =3D dw_hdmi_qp_bridge_atomic_disable, .detect =3D dw_hdmi_qp_bridge_detect, --=20 2.39.5