From nobody Wed Dec 17 18:01:29 2025 Received: from ci74p00im-qukt09082501.me.com (ci74p00im-qukt09082501.me.com [17.57.156.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD7641B4246 for ; Mon, 9 Dec 2024 13:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=17.57.156.14 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733750809; cv=none; b=N+lqDVpDsMmX1dTuZao8EsoUwV8dVM/fzCRpjRot8vJqjViFjm28HPHwQtp2h4sWQ42ZzAndFirPTXqRoJ9ecOl96nbRJFvCvS3mdyvMvwYCwO+GLjXSgxSb5Ufg6VXoeEJsc46FysFZgXEdGCNkrF+bns7r53HKa2KrwF1MuD0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733750809; c=relaxed/simple; bh=K0Lwr+5Zc7hqtyeiWM0OCk8PT5tW57AsknNOd5lB1Dk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oDT3U+w7P7Q8pZLk6UaMuPLBZ98nTmYtNORl14RrEhhBhuViHGmnTia6dtvLDXLTvW0B3DpyFplr4MNHUiBiOy4FEGcP53GVsLwu/ApVrRmqqFY2ZBhUkjldt4CjK+KKqW5Pqmdof9xzCR95i+eiFJjZXMLI6YFSmHu53uTwcRU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com; spf=pass smtp.mailfrom=icloud.com; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b=Wso66Tc9; arc=none smtp.client-ip=17.57.156.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=icloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=icloud.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=icloud.com header.i=@icloud.com header.b="Wso66Tc9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1733750807; bh=o+mb1+yAyOmCC9VR27IaIt7teFx55tYGAzUNXG1KmaU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To: x-icloud-hme; b=Wso66Tc9D+q1txBNGW41589RkhLNh3tjT/q7i4ups0/XZb4hY7jNrnSdkUbJSLzU8 bQ88UlhyUPk+iDNeG7dIwSV/HnQZLNeWzfp/QH+T7PyzEvccAZhpidDODrCfa8jDNH YbRCw4WaXqpQkRjP27+5ZuyQeIAIQZSjrjRAYrFu9rkdQZUIb9DoKTSYFUNRf4L+Jh BoqzGPd81n2WwiDXnrp+M46qQbnOEc7nzJoGntMxMQuIIxakvGpuZcnZKU1t/DFjOO IIbczDQyslVs2aCGzP1q7OCCMHAVpF/hd4uXw+i6TyEs7ZGwLC4gjFOJf39l4CrjpF VTxbw2FMKIJPQ== Received: from [192.168.1.26] (ci77p00im-dlb-asmtp-mailmevip.me.com [17.57.156.26]) by ci74p00im-qukt09082501.me.com (Postfix) with ESMTPSA id A10FB4AA010B; Mon, 9 Dec 2024 13:26:40 +0000 (UTC) From: Zijun Hu Date: Mon, 09 Dec 2024 21:25:06 +0800 Subject: [PATCH 8/8] of/irq: Fix device node refcount leakage in API irq_of_parse_and_map() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241209-of_irq_fix-v1-8-782f1419c8a1@quicinc.com> References: <20241209-of_irq_fix-v1-0-782f1419c8a1@quicinc.com> In-Reply-To: <20241209-of_irq_fix-v1-0-782f1419c8a1@quicinc.com> To: Rob Herring , Saravana Kannan , Lorenzo Pieralisi , Bjorn Helgaas , Marc Zyngier , Stefan Wiehler , Grant Likely , Tony Lindgren , Kumar Gala , Thierry Reding , Julia Lawall , Jamie Iles , Grant Likely , Benjamin Herrenschmidt Cc: Zijun Hu , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Zijun Hu , stable@vger.kernel.org X-Mailer: b4 0.14.2 X-Apple-Remote-Links: v=1;h=KCk=;charset=UTF-8 From: Zijun Hu In irq_of_parse_and_map(), refcount of device node @oirq.np was got by successful of_irq_parse_one() invocation, but it does not put the refcount before return, so causes @oirq.np refcount leakage. Fix by putting @oirq.np refcount before return. Fixes: e3873444990d ("of/irq: Move irq_of_parse_and_map() to common code") Cc: stable@vger.kernel.org Signed-off-by: Zijun Hu --- drivers/of/irq.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/of/irq.c b/drivers/of/irq.c index 29a58d62d97d1ca4d09a4e4d21531b5b9b958494..b43c49de935c76cbf1e49391517= dd7b1a569b7fa 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -38,11 +38,15 @@ unsigned int irq_of_parse_and_map(struct device_node *dev, int index) { struct of_phandle_args oirq; + unsigned int ret; =20 if (of_irq_parse_one(dev, index, &oirq)) return 0; =20 - return irq_create_of_mapping(&oirq); + ret =3D irq_create_of_mapping(&oirq); + of_node_put(oirq.np); + + return ret; } EXPORT_SYMBOL_GPL(irq_of_parse_and_map); =20 --=20 2.34.1