From nobody Wed Dec 17 16:12:50 2025 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F3D4221DB3 for ; Mon, 9 Dec 2024 12:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745673; cv=none; b=Ywbp9pxT7ogePOJGJZT28cgguExfxL+kK+KZb5QydmuF3U14aTflohDDRUa4mZywzIDlT3BE1zQUMpp63TNXRqW4oaly/yQ1bu8N9BSRzbKMKgKSKAjTXEU0ViiS8UIg74rYs9Q7Pz00dj/6RieBuyyOqRdP/CQbNwelWS7CXt8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745673; c=relaxed/simple; bh=EayO3poauy5/rht+2wdYMwLDBTRR4tdjIRay8qW3Xeo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rQQvDuyj2gmgAONXKi+dcDj/kcj63mBrtRrSgWXjbmPSqqTx8GXg+0C63tRp9UzW5gA0ye/lpZ6bhwcfGAB/ox0B3++4S5L5vQ3IaP03pxdssUpD7j1PfoWn9QiWPBYe8awtQpY2ATDsg5kBuH1fren2TIUGNJr7zXU9Dv+NGLk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=HAsTprHA; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="HAsTprHA" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aa68d0b9e7bso140593366b.3 for ; Mon, 09 Dec 2024 04:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1733745669; x=1734350469; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cJN+RDGJvasm5eLSW6rewyUE2UnqBa7DZC8SLRN3C/Y=; b=HAsTprHANCgQ+t3XVQLmEIFv9nDGiALvmFL0chTgKcWI+RRMsHBd87QM6Im4Kqmift 04JmHuNbhIGlekInf8WTVifv+0UIEd4/seYle0hhYFD8BgTuU6+vwf6fAFEasOwE15qu eyIt4U7OI/DCffAgYdEzlTTA9lw9Y7TCMVEx1uESynmdTNASKfXx9unmiMqZj4x9VAdP 6+R1F5a2SHu7HWvHD/ml9+YxFgHMDnJobDlT80EQl4NMhlGaYW+SIER0NA2Fb+DsUYRM AyEagYDDE7Jf8vu5o1s8ejOH2Maw0IJ/ZY/KkUIVmOEbcER4Ef+/zQVVbkF5hLovcz1A 4x9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733745669; x=1734350469; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cJN+RDGJvasm5eLSW6rewyUE2UnqBa7DZC8SLRN3C/Y=; b=aMfdtr6sTJh5LanSJQImJ8F59Q8vSgezQmo63nqvNGY2j0eQt191IudlyYsVdZ3fpU AyF3oJCmcZxTwqllIMiTcvxGql72+r/ratzI56soDyK7A+6h+pGGEw46sP2huGcgS/p7 cqxhg2U+VRS+hysfC3fEFJCSu36BV6tA026UjNrGC0yWdS6kBshGC/EB7msxvkKL1JDI jw1Hb0Tdwr5SSlr+u0wEBmzCi8Rw7M+h0LjuhsauFJCHteCbjUMMzlQvwrzxS5cmjYSU FzNIHRePVDmXF/6NaO92OFR1lanJkJXEDl4tsPI5LSKqIdWqUdkO5an4irSIs3i9dCYB wp1g== X-Forwarded-Encrypted: i=1; AJvYcCUE+mV/rytjl2FbmZ4bHbLu+Sb11UxauPeg3FZn2OVzna7ATKQ6WWkzrqWchMDrqOcDmaKoumfJDiiX0e0=@vger.kernel.org X-Gm-Message-State: AOJu0YzcaNoaf6xdBG2U4TzbggJfujJg1Bc22lb3SDiFb3Pfrww+f5QQ eukz8+aVImMz8lnzioGj3c1GTYn7YrsiDcPd8pZQ1RSzA6XCmoYefJ5enhbk3YU= X-Gm-Gg: ASbGncv7vRW1b8S4QCHZCMIozyV93exe0nXmtNqBEmH7HPZbww/eFG4J9xlVgWyjSi/ 1++aatB2tyuRq5L7yWGfZJK9hLR+XJ2RRozspbGGFr4ml1aWW6mRswBHq+zhHRDu6gw4MBtLvn7 sbBVgBQor7EOS4iKCzk3Bf0h/qOAtAcadmqkncoXdt+LdOSx1+UPfmObdZrKVb9shhpdQeIsi7M 3vdSTkWwxeMGuIGG6dF0ZyfxB3d4LbNB89XkitdnrAVHhOhWu6GkCAvI1UBqiMsYp5ehYvmVqdU aH/28OqdKdPcpctXSU2AJSiml3EKlQF5E3j94OUIwS97A1UCfAhxrkCPWPbIIiCIXw== X-Google-Smtp-Source: AGHT+IF+p9gVWhFaOEldkR3XDKLXXb1rK4KX30ftSf7RjwBOAfR7BnsNTeQR8MNatD02QvNHIJdwOw== X-Received: by 2002:a17:907:770c:b0:aa6:8160:8495 with SMTP id a640c23a62f3a-aa69ce00080mr4712666b.42.1733745669239; Mon, 09 Dec 2024 04:01:09 -0800 (PST) Received: from [100.64.0.4] (2a02-8388-6584-6400-d322-7350-96d2-429d.cable.dynamic.v6.surfer.at. [2a02:8388:6584:6400:d322:7350:96d2:429d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa69afa395csm22555066b.71.2024.12.09.04.01.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 04:01:08 -0800 (PST) From: Luca Weiss Date: Mon, 09 Dec 2024 13:01:05 +0100 Subject: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241209-camss-dphy-v1-1-5f1b6f25ed92@fairphone.com> References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> In-Reply-To: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for CSI-2, but not any others so restrict the bus-type property describing this to the supported values. The only exception here is MSM8916 which only supports D-PHY. C-PHY was introduced with newer SoCs. Do note, that currently the Linux driver only supports D-PHY. Signed-off-by: Luca Weiss Reviewed-by: Bryan O'Donoghue Reviewed-by: Krzysztof Kozlowski --- .../bindings/media/qcom,msm8916-camss.yaml | 8 ++++++ .../bindings/media/qcom,msm8953-camss.yaml | 15 +++++++++++ .../bindings/media/qcom,msm8996-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sc8280xp-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sdm660-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sdm845-camss.yaml | 20 +++++++++++++++ .../bindings/media/qcom,sm8250-camss.yaml | 30 ++++++++++++++++++= ++++ 7 files changed, 133 insertions(+) diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yam= l b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml index 9cc0a968a401836814560c1af3ee84d946500b4f..3de2a3d2b5b761106975aab65ff= 614b2ef579ef5 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml @@ -94,6 +94,10 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -113,6 +117,10 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 diff --git a/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yam= l b/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml index 8856fba385b1123d748199b46c5009c97700ad9b..6d776b0ca71140c0816b246dbaf= 41ef376205bba 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8953-camss.yaml @@ -112,6 +112,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -131,6 +136,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -150,6 +160,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yam= l b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml index 5cb0e337ea6e4274dbb75b7b25a9b4ac44069cfd..cae4c4f19574be30e8a9f8ca08f= 26d67be1e455c 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml @@ -116,6 +116,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -135,6 +140,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -154,6 +164,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -173,6 +188,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 diff --git a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.ya= ml b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml index c0bc31709873c20b63c011148394f10b45c1655e..f9e3f514c61bf6fd48e15904b62= b59c390e63b20 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc8280xp-camss.yaml @@ -143,6 +143,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -166,6 +171,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -189,6 +199,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -212,6 +227,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes diff --git a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml= b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml index 584106e275f67aca814de5dd70563d395305399c..a3e2ee7f643d2a8c1490b4d02e1= 6e509cf85f85f 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm660-camss.yaml @@ -122,6 +122,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -141,6 +146,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -160,6 +170,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -179,6 +194,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml= b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml index ec4380a0a03f7dce2539085e24d9d9ec7205e825..98cd0df4570ed168fc1495619c4= 08c4fbaac66fa 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-camss.yaml @@ -109,6 +109,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -128,6 +133,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -147,6 +157,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 @@ -166,6 +181,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - data-lanes =20 diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml= b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml index fa5073c0fd1efaa94f171e4ec26b918d8a5261d6..c95533ac92002c70efe7ef56ab2= 712565a5a7297 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-camss.yaml @@ -129,6 +129,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -152,6 +157,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -175,6 +185,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -198,6 +213,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -221,6 +241,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes @@ -244,6 +269,11 @@ properties: minItems: 1 maxItems: 4 =20 + bus-type: + enum: + - 1 # MEDIA_BUS_TYPE_CSI2_CPHY + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY + required: - clock-lanes - data-lanes --=20 2.47.1 From nobody Wed Dec 17 16:12:50 2025 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EA18221DBE for ; Mon, 9 Dec 2024 12:01:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745674; cv=none; b=OHyyJYckBxxHNCKzVy0B7xWNnUGfiWq6n3PKuEQJ38gvHeph6K6czXaZ9uFQxjEmhNLxZWpBRHzfMcvjztrmIA2QVeFh2mzPXJk0Qf6HKxKMypjJIo+q9pa+zl6yQol+plfeCY87YzhDE7rEnwqyNDvDy0+JrqczIB3mrivmQQU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733745674; c=relaxed/simple; bh=8pFX+27nmjk/7KfdfuKsPNR83Jiahya68QV//JkHJU8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Fi49lMOkOKsBZzMhFONlNJHmY0xEPghGVR9aUdjV67TCqscIbCdL6VM+M3QzSrKy9RcDZuRRdhEYIH5KVdfmxDACBUrlGeLw3mt7idL5r9v9dSRR/83yeCgrDFLSpfmbCC7ZSoPhFvqoTOQJ0ly/VNRmwnzvSMITeIKOzdcUZ9w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com; spf=pass smtp.mailfrom=fairphone.com; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b=BndbPVXi; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=fairphone.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fairphone.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fairphone.com header.i=@fairphone.com header.b="BndbPVXi" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-a9f1c590ecdso758538966b.1 for ; Mon, 09 Dec 2024 04:01:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; t=1733745670; x=1734350470; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0tR6QupvutEPi+0B6/genbHIfRkFvdzSANWIhNibRjA=; b=BndbPVXiWkZ2Hymlx4djmvk3gopkES+g2ciCMtH9KuwLm8K+AKenJwUnTmlB/GOHGS wMonUq50IRzSn65wKpPNKm98Aq/INhm9tZQp9EMohv2B/OYFNPS6tpm/m0rGXSMckI3l 6QvvheUI4ft+hvwcntSi7r/aOghQMpsNiQdcUwGVNSbM1YM8a5SErFyLN5cNCcntNJmb U8OM2ROcxY1oFdHvdXVxMBNbeoAgV0vi0B3gkYrrqhxxa3PzJOps2TF0xE25omtiNzRY R4XD658MZRpjGFdtaRVlxnfoNX2ApzbIHHKesmRu7Xg//cK7epW8/LhBUnjftgwoMW5C xRFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733745670; x=1734350470; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0tR6QupvutEPi+0B6/genbHIfRkFvdzSANWIhNibRjA=; b=hmiBAfar+3glxIdx+XafRrS9wAI/hiPMYUnoBpJdwrV4sNPP1KXZ/sCIXsuJurEMKx s5DqJwllV47cQ6aaXUPn+UXSPYd4m7LFlcQn5hp1XyYt9cSPcXBLgA51n9mD/ZTKxcaA kBFgBf5gCBMI0FOJiP1ldOeifqa1CaWcTU+1koXWZRzhN0a4/vOCjSohfqrbIDZNoRny cYUNKTuMinpFcAjgub3oTwsdEl/wBgYFHrfHwVx36M37jwBGwKc+PVJQ0WB+WelCT1Op Uti7s9inVXRavHxmxXA8+tG0UNkS2HcBwHWAz9AupY0r5G0Iwthx/vlDZvBv/Mjx+4Rm 6EsA== X-Forwarded-Encrypted: i=1; AJvYcCXFlgy9tO0OZn0NdwtjT8PWDCzfXMn7LTGxUvbj/b7pnWe1Ljm/QLWvV66BbhPSta+hRjKmaDvfkvsLQtE=@vger.kernel.org X-Gm-Message-State: AOJu0YziwLMlci1ej0bzZokX4ie76nHeIQNGkajEwy2kuJF9cncjTG/F p3ozTv9JftAtc13uUTkMdBP95xxURsXSztFxIl3AV8CNibMNauM4Z12C0znHr4s= X-Gm-Gg: ASbGncvk8HgHiJAo/k+lwtfK44pPlDc+41/09oiGSSVPoscjcfIiNiDR7sXTV+5+9dm p0pS0TJtMspPWGk8a0NIQRpsZuzYbPbJck50X4SR//7oQAOn5RgiPyLjoEVEBevVI1f1v5uBcHs 2Amgawuq/nFrqQtEfxv7LcYBgB8Ueq5xYSH51IC0vRZrrmoHC4dOkFV0/zxcS9NZMdOTFFCfDAh 9Vx3Me4PSxOwGCOzpkJBpXnhUwxHisZWpCkn/PcgGt72XzXPrjWPt2g1QEMqg2wUxOwKZAemfC3 Hza9glgFxR2Jk7wrdK46qE4gh31hv64mtPCffKkyNNjZLZ5CXEKEpfnvjOj2V5IkOA== X-Google-Smtp-Source: AGHT+IGCASHop4+PMr/ElwoRqpZmRPYooFBqBNoyvG1DRpnbL890d/4qkOvn0rbSSu4AIgl1YOMZNg== X-Received: by 2002:a17:907:aa6:b0:aa6:945c:453d with SMTP id a640c23a62f3a-aa69cda0d94mr5001966b.27.1733745670385; Mon, 09 Dec 2024 04:01:10 -0800 (PST) Received: from [100.64.0.4] (2a02-8388-6584-6400-d322-7350-96d2-429d.cable.dynamic.v6.surfer.at. [2a02:8388:6584:6400:d322:7350:96d2:429d]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa69afa395csm22555066b.71.2024.12.09.04.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2024 04:01:10 -0800 (PST) From: Luca Weiss Date: Mon, 09 Dec 2024 13:01:06 +0100 Subject: [PATCH 2/2] media: qcom: camss: Restrict endpoint bus-type to D-PHY Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241209-camss-dphy-v1-2-5f1b6f25ed92@fairphone.com> References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> In-Reply-To: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> To: Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss X-Mailer: b4 0.14.2 Currently the Qualcomm CAMSS driver only supports D-PHY while the hardware on most SoCs also supports C-PHY. Until this support is added, check for D-PHY to make it somewhat explicit that C-PHY won't work. Signed-off-by: Luca Weiss Reviewed-by: Bryan O'Donoghue Reviewed-by: Vladimir Zapolskiy Tested-by: Vladimir Zapolskiy --- drivers/media/platform/qcom/camss/camss.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/plat= form/qcom/camss/camss.c index 9fb31f4c18adee886cd0bcf84438a8f27635e07f..b99af35074cdf6fa794a0d2f0d5= 4ecf12ac354d9 100644 --- a/drivers/media/platform/qcom/camss/camss.c +++ b/drivers/media/platform/qcom/camss/camss.c @@ -1855,6 +1855,15 @@ static int camss_of_parse_endpoint_node(struct devic= e *dev, if (ret) return ret; =20 + /* + * Most SoCs support both D-PHY and C-PHY standards, but currently only + * D-PHY is supported in the driver. + */ + if (vep.bus_type !=3D V4L2_MBUS_CSI2_DPHY) { + dev_err(dev, "Unsupported bus type %d\n", vep.bus_type); + return -EINVAL; + } + csd->interface.csiphy_id =3D vep.base.port; =20 mipi_csi2 =3D &vep.bus.mipi_csi2; --=20 2.47.1