From nobody Thu Dec 18 00:11:10 2025 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C787C1FF5FA for ; Fri, 6 Dec 2024 11:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733483642; cv=none; b=U7RwOPPfg3aybTsuTkFwXRX3TjdDfz0MTNr0DJwKcN4PoBQwTjkK6ytGSk+yhjzhi/m83XGW2fIKyNF/xtfKK9FpP0zQ4aqhaUUuVTjlNNOHWyeeZRAnwsslZkXjsVSIX1f0LQwMtynJkJVGuFjcCS6iCb9h4x+7dSiSZM6wFm8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733483642; c=relaxed/simple; bh=pFeVqwq5TdQjxpLyK7iTM1W+bmcdyJjKWS9gDr7aPgY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ggy4/RgjkKDat6tP40cVxSo4iw0mWHzllHOMtgmQVpzpEsmME6NzVI2qWjZ+Z8gOmvoxCDVQXQS2BzQX8esy6c/UYZIOuLniBZHGtPxzfkjmIN7PHIHsU6OhTgd94FjilVpaqd31rPOfd1Swy6OnBQdgJwBgXNSLBaWJPwpmJQc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=KTyk/JTS; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="KTyk/JTS" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-aa530a94c0eso389835266b.2 for ; Fri, 06 Dec 2024 03:14:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1733483639; x=1734088439; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IF+3d6YLoFd8ymBLjEJf+CI6Y+EI/atf0HIxguIiGOc=; b=KTyk/JTSj84SQaukd1UW5/e2pUXUmY4LMfK3scIgA5GUK5NXxh1JUjIOy2mvdCKPoc 4RUOzTCk5ejmI4TMxPI3IwlvgJjccg1KUm6GMuMzUzjZc+HWNEj8NwF8fse4+ucyoKg+ SDm/FliQmJHkw1u9yJtjMtAyvUjx/EsHww0B4qy5WoTGpkUDAnvI4fQqEhQthyRwxEDM 5gkzMPLMBvwF4AkmMYF59/a3vKFgNjklGsCTjrJYjkFXemCR2JL54Trv7bbgoyuMxm0Y FUD3dKOJMLvLka7DIOiO+PwSXNGSqFFeDqWAWM2CHIwKpRHFdvsze5IgCdmo6d+gZSaW we4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733483639; x=1734088439; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IF+3d6YLoFd8ymBLjEJf+CI6Y+EI/atf0HIxguIiGOc=; b=LhD2K8FWh0zeqjm8PhB/ZEGX2lsXkBPgDqFlGnuLTRNdW2t864CyBmxFdKZ7mqSWUy GVmbPItLUwGw1zpPHnyACfPjWzLrEvkXdAzyWHYAk/RdcGyrjuCR4KIhkLlVcXNT3rQI m3JXSXwoeKDeOEwVEmgA30lxKS0QLRz182rZPST56Nq46XRhHLVUbWl6t8OCo0Fd5A3P 87Qy5bDmiL23wZT3i47ZWu+QAVoGygDetS6jOzQfkcxRSG1zbg9SuJtS30AUU8HqepwK Ub0JPBHR80EO56TMr6iJ1NwQr29J6MXSDbD1pK2rdZCQuRS71GPJuAV2wOXkfU0AAXD1 ORow== X-Forwarded-Encrypted: i=1; AJvYcCWxD7MW2XhsKVZpxjCM7G9i7VHW3awznnKnw+q5mAK+jKMUU/EhCmQmbCCOyD+o0XLrdqetVsd/wcKpxXY=@vger.kernel.org X-Gm-Message-State: AOJu0YzMhJChTQJLHJ7Q01eNb6C6Sp9YrHxOzIuD07rReLVgD47ankMx M5ObcZSxX5dMVe3jiwB3ON1jXoLuZl/hTvr2fw4vaXpVBX8pmKSX7FAArU8MWyc= X-Gm-Gg: ASbGncttGvuKvJQkUOh1gmoJA0AOaaev/nVsMC/6CMm0xcXFZWNYH6ylmRxRBOb2sAW 95m/Wyc8QmBeN+Qko1ACvyaAmVMloEUu7uEMWecPDgsmgiC0XHt2XEJ6ImjiyVs3rxKe+WqJDOV AMOyNyeiOPWFMtqh/LpkTQpuy40wdbMTay+YzFt6EsaeYYJNRwjq/YXc6WWdjFIgciMgMgwrCyD JGo4uOCeqGtzGqiTsuGyb0TYr3mfv3ZGwDrOwkRgj+Kw1h/smny8M6os6FJeRBtwPBQn+dXZzOD uGlU X-Google-Smtp-Source: AGHT+IE8/6k5bsY8E9y5ISlKPNleG7y4yY/FFLd5nbbFNGCG10Rgtm0MhHvZLaSwwmr1LC62i+/LQg== X-Received: by 2002:a17:907:3a57:b0:aa5:1cdf:7bb1 with SMTP id a640c23a62f3a-aa63a03afedmr192091466b.24.1733483639246; Fri, 06 Dec 2024 03:13:59 -0800 (PST) Received: from claudiu-X670E-Pro-RS.. ([82.78.167.161]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa625eee2a6sm226877866b.90.2024.12.06.03.13.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 03:13:58 -0800 (PST) From: Claudiu X-Google-Original-From: Claudiu To: prabhakar.mahadev-lad.rj@bp.renesas.com, jic23@kernel.org, lars@metafoo.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de Cc: claudiu.beznea@tuxon.dev, linux-iio@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Claudiu Beznea Subject: [PATCH v2 03/15] iio: adc: rzg2l_adc: Use devres helpers to request pre-deasserted reset controls Date: Fri, 6 Dec 2024 13:13:25 +0200 Message-Id: <20241206111337.726244-4-claudiu.beznea.uj@bp.renesas.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20241206111337.726244-1-claudiu.beznea.uj@bp.renesas.com> References: <20241206111337.726244-1-claudiu.beznea.uj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Claudiu Beznea Starting with commit d872bed85036 ("reset: Add devres helpers to request pre-deasserted reset controls"), devres helpers are available to simplify the process of requesting pre-deasserted reset controls. Update the rzg2l_adc driver to utilize these helpers, reducing complexity in this way. Signed-off-by: Claudiu Beznea Reviewed-by: Lad Prabhakar --- Changes in v2: - rebased on top of patch 2/15 from this version - used "failed to get/deassert" failure messages drivers/iio/adc/rzg2l_adc.c | 37 ++++++------------------------------- 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index 8a804f81c04b..c0c13e99aa92 100644 --- a/drivers/iio/adc/rzg2l_adc.c +++ b/drivers/iio/adc/rzg2l_adc.c @@ -411,11 +411,6 @@ static void rzg2l_adc_pm_runtime_set_suspended(void *d= ata) pm_runtime_set_suspended(dev->parent); } =20 -static void rzg2l_adc_reset_assert(void *data) -{ - reset_control_assert(data); -} - static int rzg2l_adc_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -448,34 +443,14 @@ static int rzg2l_adc_probe(struct platform_device *pd= ev) if (IS_ERR(adc->adclk)) return dev_err_probe(dev, PTR_ERR(adc->adclk), "Failed to get adclk"); =20 - adc->adrstn =3D devm_reset_control_get_exclusive(dev, "adrst-n"); + adc->adrstn =3D devm_reset_control_get_exclusive_deasserted(dev, "adrst-n= "); if (IS_ERR(adc->adrstn)) - return dev_err_probe(dev, PTR_ERR(adc->adrstn), "failed to get adrstn\n"= ); - - adc->presetn =3D devm_reset_control_get_exclusive(dev, "presetn"); - if (IS_ERR(adc->presetn)) - return dev_err_probe(dev, PTR_ERR(adc->presetn), "failed to get presetn\= n"); - - ret =3D reset_control_deassert(adc->adrstn); - if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to deassert adrstn pin, %d= \n", ret); - - ret =3D devm_add_action_or_reset(&pdev->dev, - rzg2l_adc_reset_assert, adc->adrstn); - if (ret) { - return dev_err_probe(&pdev->dev, ret, - "failed to register adrstn assert devm action, %d\n", ret); - } + return dev_err_probe(dev, PTR_ERR(adc->adrstn), "failed to get/deassert = adrst-n\n"); =20 - ret =3D reset_control_deassert(adc->presetn); - if (ret) - return dev_err_probe(&pdev->dev, ret, "failed to deassert presetn pin, %= d\n", ret); - - ret =3D devm_add_action_or_reset(&pdev->dev, - rzg2l_adc_reset_assert, adc->presetn); - if (ret) { - return dev_err_probe(&pdev->dev, ret, - "failed to register presetn assert devm action, %d\n", ret); + adc->presetn =3D devm_reset_control_get_exclusive_deasserted(dev, "preset= n"); + if (IS_ERR(adc->presetn)) { + return dev_err_probe(dev, PTR_ERR(adc->presetn), + "failed to get/deassert presetn\n"); } =20 ret =3D rzg2l_adc_hw_init(adc); --=20 2.39.2