From nobody Fri Dec 19 07:02:19 2025 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AAC21E095 for ; Fri, 6 Dec 2024 21:18:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733519939; cv=none; b=t8tkWPC4P67T4L3dgA6ZLM0tXHQVojOy8mxIuKce+C/LL6vqaWATIt6GM8vvdNICa9ebed80Z9cl94YFE5qiaBeTYNfRlG1MHncMLkjVafhoxkm6p20SlSbgP5xloi65a2Cav7IeFBvpR3wnm1rBnh0qVG4Mm7emsGgUhc+JJtw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733519939; c=relaxed/simple; bh=Tcmis1yXyG1Git2X+8o1kprRdEHNd8dKBzBagujoje0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=WeGG64NZXsWcC69oP3ZyFMop5W47+/f4EFN8qbzo7URea6Qj0Nm+Ax+PRkW/rh3eRCSa+aekaPwTLI+q0jpKIGArgG9V/Z6iJN1YvxM8pyEqZnK6q+pDVixEzB7HNvukq/KwCX3bG6ALDLpjl7+CcAvS8Nm4UX4iUZq8J8JBHMw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=Oeq1Gn7f; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="Oeq1Gn7f" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-434a766b475so24447335e9.1 for ; Fri, 06 Dec 2024 13:18:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1733519933; x=1734124733; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=ClGXX4576d+FS4AfSrsTJoO8ACeKpgP1Aq3SHCHN4ug=; b=Oeq1Gn7fDEoBWFXWFd+tG4/iYbDydG7sYsuGbVWdJ5/fAUUW9ydT9xD3drTOCTPTES 1rp2KeVNuI/ClyayiHk1RVZYbyvniJtGSebXNvhu/9FMIUck0bejAfx9NC9PC2FXkyll 5046Mf0A6wpVI2c1j1tGLGhxTX2mfzcBoJ7+k4fGrDH3lgQ9qvOQuxD8B68943WQZfkv ELR/j6RAmGFEu4gq4EISJDf7ZeJKQ2LmzD1r25LlhhD/D1NreHKlwLm6HWoSfmXRH/gB +8qelN5900Vs37OBz2gizt8RXb0Vf7WskME+SGOdON10JFv2HCagIFcLyUMRJEm+4Mov TQAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733519933; x=1734124733; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ClGXX4576d+FS4AfSrsTJoO8ACeKpgP1Aq3SHCHN4ug=; b=cGom7XuiLhVTqyzI622MZwLjuwUmhQuRrPEAvJG0VMHIbm/EFugHh7/z98DCdEpeQB qIVoiACoxPrkK1bIBLsC0Lzrk2Y82APJjcA4+uF4zmgWorVawQlgc9eVwtEB8sktK437 4uxaZXvYj2pdmu5YsANJr0DSdSIFARVn9hehwMTtiOAeTyW/ok9NU09PsOMiUUSQKsiP GVmvWSbwnplPVYkQ2hf4egXqaiEz4wxWCTDqy+w6qIABF7BloU5ruRp/7/jN1xb3rqTR JLrErIDDGo7pTEudHv0dep8Pc2n0+8qvMBTaWpdpbyHIJp6KXa8TzRaGGT6JAsFX5EHx CyuQ== X-Forwarded-Encrypted: i=1; AJvYcCWx9lAkZUzja1J/sBiClEfxsRMA3f9pXd7cfPKO5fdt43nLAY/rFJA5hk82QqJ4Uy0lm5AE1j/xhK9s4G8=@vger.kernel.org X-Gm-Message-State: AOJu0YxSCstbaPbruZDhFgyXFc8rASu+ZjZe8sxXwImLncSIwhxBjSHs eypmVW1TgEBSszClNUuhu3m/xSanrIypqOZipAboM9zS4zwIuEQ9Xw73j+Pjg2I= X-Gm-Gg: ASbGncvITzeJJ+cxw2O5UqU4lkq+KQkcomZ/+/gP1PekKdwy7qeZwLjGo/rezD9JQvq WUkBdFLCb44NYnbfW9/5q9ipKxxuad1G8htCNHVmXBLuvjMO11YG1fq9DDtjAwTR1vU6u71eaT+ N5ysMWImRpwQk3U2qnr2ZXSP18RURvSwV3BbiDaH5UoQu+6oaHhkduzfCAoEVHKjuw+85u6mmww pkH9d0lpKdKUteMCIaOmeQ4cCOGEPWBSBjbtQpC+CxQYoyZgtsvW7bDxzGZqA== X-Google-Smtp-Source: AGHT+IHtVw3KjxeCH9wir8jOx+KOef7V7Mp1iwfpR6Dzrz1WvJS67DDafbbs5mQbOjjTXm7dTPyaPw== X-Received: by 2002:a5d:6dab:0:b0:386:3262:28c6 with SMTP id ffacd0b85a97d-38632622926mr1100016f8f.5.1733519933466; Fri, 06 Dec 2024 13:18:53 -0800 (PST) Received: from serenity.mandelbit.com ([2001:67c:2fbc:1:3cee:9adf:5d38:601e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3861fd46839sm5441302f8f.52.2024.12.06.13.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Dec 2024 13:18:53 -0800 (PST) From: Antonio Quartulli Date: Fri, 06 Dec 2024 22:18:35 +0100 Subject: [PATCH net-next v13 10/22] ovpn: store tunnel and transport statistics Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241206-b4-ovpn-v13-10-67fb4be666e2@openvpn.net> References: <20241206-b4-ovpn-v13-0-67fb4be666e2@openvpn.net> In-Reply-To: <20241206-b4-ovpn-v13-0-67fb4be666e2@openvpn.net> To: netdev@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Donald Hunter , Antonio Quartulli , Shuah Khan , sd@queasysnail.net, ryazanov.s.a@gmail.com, Andrew Lunn Cc: Simon Horman , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7121; i=antonio@openvpn.net; h=from:subject:message-id; bh=Tcmis1yXyG1Git2X+8o1kprRdEHNd8dKBzBagujoje0=; b=owEBbQGS/pANAwAIAQtw5TqgONWHAcsmYgBnU2pX+9u6++dwh7A49gOS1MllhYsQVQ3MUIwiJ pQ0pcjtb0GJATMEAAEIAB0WIQSZq9xs+NQS5N5fwPwLcOU6oDjVhwUCZ1NqVwAKCRALcOU6oDjV h7gLB/9NKT4hT1NATXan4/6K98i0mPdMdryB4MFbaoeQGWsg08g79yHp6ZB3i19cdwshPWW2Ehp w/LM4YLlKPj/6aEGv1+a7t2buHNY7QuZZnlhEKXOUc5YVnIT8gZi8pDaCl+K+BHN/MFJJZVtBkW ye2zBAQA39KCIb/XVWXy4eb+ut8Ubi0vdvfm9du9VXd2MunncMy2vHNF6An1Ja2XyyPBIdLXakS utkW++rXmicUQEEQVTKcOxxAQ5i3lYVhGIqpzAmHwqykYFDJnPA2YxQTtOAhaaiDfEzKb0OGJ9R jKrMBTDWdZiAYY+gVvQe1yf5XSRe1l5XAvmj5HPjJPEgOcZh X-Developer-Key: i=antonio@openvpn.net; a=openpgp; fpr=CABDA1282017C267219885C748F0CCB68F59D14C Byte/packet counters for in-tunnel and transport streams are now initialized and updated as needed. To be exported via netlink. Signed-off-by: Antonio Quartulli --- drivers/net/ovpn/Makefile | 1 + drivers/net/ovpn/io.c | 12 +++++++++++- drivers/net/ovpn/peer.c | 2 ++ drivers/net/ovpn/peer.h | 5 +++++ drivers/net/ovpn/stats.c | 21 +++++++++++++++++++++ drivers/net/ovpn/stats.h | 47 +++++++++++++++++++++++++++++++++++++++++++= ++++ 6 files changed, 87 insertions(+), 1 deletion(-) diff --git a/drivers/net/ovpn/Makefile b/drivers/net/ovpn/Makefile index ccdaeced1982c851475657860a005ff2b9dfbd13..d43fda72646bdc7644d9a878b56= da0a0e5680c98 100644 --- a/drivers/net/ovpn/Makefile +++ b/drivers/net/ovpn/Makefile @@ -17,4 +17,5 @@ ovpn-y +=3D netlink-gen.o ovpn-y +=3D peer.o ovpn-y +=3D pktid.o ovpn-y +=3D socket.o +ovpn-y +=3D stats.o ovpn-y +=3D udp.o diff --git a/drivers/net/ovpn/io.c b/drivers/net/ovpn/io.c index a6db02f712203430942e3908480026f4dbac673a..8414dbd24467d77a5122daa9c3c= 745aa5e258c98 100644 --- a/drivers/net/ovpn/io.c +++ b/drivers/net/ovpn/io.c @@ -12,6 +12,7 @@ #include #include #include +#include =20 #include "ovpnstruct.h" #include "peer.h" @@ -55,9 +56,11 @@ static void ovpn_netdev_write(struct ovpn_peer *peer, st= ruct sk_buff *skb) /* cause packet to be "received" by the interface */ pkt_len =3D skb->len; ret =3D gro_cells_receive(&peer->ovpn->gro_cells, skb); - if (likely(ret =3D=3D NET_RX_SUCCESS)) + if (likely(ret =3D=3D NET_RX_SUCCESS)) { /* update RX stats with the size of decrypted packet */ + ovpn_peer_stats_increment_rx(&peer->vpn_stats, pkt_len); dev_sw_netstats_rx_add(peer->ovpn->dev, pkt_len); + } } =20 void ovpn_decrypt_post(void *data, int ret) @@ -155,6 +158,8 @@ void ovpn_recv(struct ovpn_peer *peer, struct sk_buff *= skb) struct ovpn_crypto_key_slot *ks; u8 key_id; =20 + ovpn_peer_stats_increment_rx(&peer->link_stats, skb->len); + /* get the key slot matching the key ID in the received packet */ key_id =3D ovpn_key_id_from_skb(skb); ks =3D ovpn_crypto_key_id_to_slot(&peer->crypto, key_id); @@ -176,6 +181,7 @@ void ovpn_encrypt_post(void *data, int ret) struct ovpn_crypto_key_slot *ks; struct sk_buff *skb =3D data; struct ovpn_peer *peer; + unsigned int orig_len; =20 /* encryption is happening asynchronously. This function will be * called later by the crypto callback with a proper return value @@ -198,6 +204,7 @@ void ovpn_encrypt_post(void *data, int ret) goto err; =20 skb_mark_not_on_list(skb); + orig_len =3D skb->len; =20 switch (peer->sock->sock->sk->sk_protocol) { case IPPROTO_UDP: @@ -207,6 +214,8 @@ void ovpn_encrypt_post(void *data, int ret) /* no transport configured yet */ goto err; } + + ovpn_peer_stats_increment_tx(&peer->link_stats, orig_len); /* skb passed down the stack - don't free it */ skb =3D NULL; err: @@ -325,6 +334,7 @@ netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct n= et_device *dev) goto drop; } =20 + ovpn_peer_stats_increment_tx(&peer->vpn_stats, skb->len); ovpn_send(ovpn, skb_list.next, peer); =20 return NETDEV_TX_OK; diff --git a/drivers/net/ovpn/peer.c b/drivers/net/ovpn/peer.c index 456fd70ccd2a7e37f0ad1732ca9f5a07f2f54a97..0d625f065255c4947a18ae475b0= 4c27f0cf6bb32 100644 --- a/drivers/net/ovpn/peer.c +++ b/drivers/net/ovpn/peer.c @@ -47,6 +47,8 @@ struct ovpn_peer *ovpn_peer_new(struct ovpn_priv *ovpn, u= 32 id) ovpn_crypto_state_init(&peer->crypto); spin_lock_init(&peer->lock); kref_init(&peer->refcount); + ovpn_peer_stats_init(&peer->vpn_stats); + ovpn_peer_stats_init(&peer->link_stats); =20 ret =3D dst_cache_init(&peer->dst_cache, GFP_KERNEL); if (ret < 0) { diff --git a/drivers/net/ovpn/peer.h b/drivers/net/ovpn/peer.h index 1b427870df2cf972e0f572e046452378358f245a..61c54fb864d990ff3d746f18c9a= 06d4c950bd1ac 100644 --- a/drivers/net/ovpn/peer.h +++ b/drivers/net/ovpn/peer.h @@ -13,6 +13,7 @@ #include =20 #include "crypto.h" +#include "stats.h" =20 /** * struct ovpn_peer - the main remote peer object @@ -25,6 +26,8 @@ * @crypto: the crypto configuration (ciphers, keys, etc..) * @dst_cache: cache for dst_entry used to send to peer * @bind: remote peer binding + * @vpn_stats: per-peer in-VPN TX/RX stays + * @link_stats: per-peer link/transport TX/RX stats * @delete_reason: why peer was deleted (i.e. timeout, transport error, ..) * @lock: protects binding to peer (bind) * @refcount: reference counter @@ -42,6 +45,8 @@ struct ovpn_peer { struct ovpn_crypto_state crypto; struct dst_cache dst_cache; struct ovpn_bind __rcu *bind; + struct ovpn_peer_stats vpn_stats; + struct ovpn_peer_stats link_stats; enum ovpn_del_peer_reason delete_reason; spinlock_t lock; /* protects bind */ struct kref refcount; diff --git a/drivers/net/ovpn/stats.c b/drivers/net/ovpn/stats.c new file mode 100644 index 0000000000000000000000000000000000000000..a383842c3449b73694c318837b0= b92eb9afaec22 --- /dev/null +++ b/drivers/net/ovpn/stats.c @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: GPL-2.0 +/* OpenVPN data channel offload + * + * Copyright (C) 2020-2024 OpenVPN, Inc. + * + * Author: James Yonan + * Antonio Quartulli + */ + +#include + +#include "stats.h" + +void ovpn_peer_stats_init(struct ovpn_peer_stats *ps) +{ + atomic64_set(&ps->rx.bytes, 0); + atomic64_set(&ps->rx.packets, 0); + + atomic64_set(&ps->tx.bytes, 0); + atomic64_set(&ps->tx.packets, 0); +} diff --git a/drivers/net/ovpn/stats.h b/drivers/net/ovpn/stats.h new file mode 100644 index 0000000000000000000000000000000000000000..868f49d25eaa8fef04a02a61c36= 3d95f9c9ef80a --- /dev/null +++ b/drivers/net/ovpn/stats.h @@ -0,0 +1,47 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* OpenVPN data channel offload + * + * Copyright (C) 2020-2024 OpenVPN, Inc. + * + * Author: James Yonan + * Antonio Quartulli + * Lev Stipakov + */ + +#ifndef _NET_OVPN_OVPNSTATS_H_ +#define _NET_OVPN_OVPNSTATS_H_ + +/* one stat */ +struct ovpn_peer_stat { + atomic64_t bytes; + atomic64_t packets; +}; + +/* rx and tx stats combined */ +struct ovpn_peer_stats { + struct ovpn_peer_stat rx; + struct ovpn_peer_stat tx; +}; + +void ovpn_peer_stats_init(struct ovpn_peer_stats *ps); + +static inline void ovpn_peer_stats_increment(struct ovpn_peer_stat *stat, + const unsigned int n) +{ + atomic64_add(n, &stat->bytes); + atomic64_inc(&stat->packets); +} + +static inline void ovpn_peer_stats_increment_rx(struct ovpn_peer_stats *st= ats, + const unsigned int n) +{ + ovpn_peer_stats_increment(&stats->rx, n); +} + +static inline void ovpn_peer_stats_increment_tx(struct ovpn_peer_stats *st= ats, + const unsigned int n) +{ + ovpn_peer_stats_increment(&stats->tx, n); +} + +#endif /* _NET_OVPN_OVPNSTATS_H_ */ --=20 2.45.2