From nobody Thu Dec 18 20:19:33 2025 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C1191C3BE5 for ; Wed, 4 Dec 2024 18:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733338236; cv=pass; b=OzOX0BMxRNq62l/hCzdADZ47O8ct5tMl7NSb1/4V70r2UTpvoR20JH2T19y+uO7uJUSKKZePEPCoJNx32mLgC9pBP5YIImBMuy2rCHTyjFD40b10qJ0A3HsgEVD7b/ls1mgCb0CRzt4tMngWzfIeDzgg1SNSiDcYV9pk5W2FTQE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733338236; c=relaxed/simple; bh=wENLujEaE0/jDv9eUtx7VbQkHBJh+HI5TA1D/Kh87Ok=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ajba0xbxQTUlEjLZzA9xmi+GHz1QiqhqCZhfNO4EvEUNO2t0P2AWmfBiE5Buk+0eU3ggLvJUx0g1gWNnRshqiVIP9xQC1L9dvSA6yX2KmFIbkN8YVNp3pidVokDigbOXrQA61C5nsiQrl1LVPaRCBOw6hCteEediqW+3HAvRs0I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=HXboe/nj; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="HXboe/nj" ARC-Seal: i=1; a=rsa-sha256; t=1733338214; cv=none; d=zohomail.com; s=zohoarc; b=EiinLxhL34XIKGHWkXDMwD8VhFjkL5rkn128Fzponp3WFZvjI4g/SlhRNZqGFzSd1Dt67dx9N8n5KhxqOghs+XF7vFoiXwhw100LhiuFaUfhfTOcPso/fN6SuhjetseGGRmNNCbo2aayND1UNKqPV/6/wIqSJTj+RxuOAAiy+R0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1733338214; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=kjtahGPaTpINYYZfuLGp4VkVf+IQcM1cz95cqRqH8GE=; b=eTPw+7m4wxlXwmQfHV2nItyT0v/fvZoQei0r1d78rN3nzCFjo7zXJ8g+yGcBLmUxYK3slkNWBfIoxbcXZpIWgWICWyS5fRIr/LYmO8AD/VS1P0Ks6ypWPK+4ncDIeEKNhfo/ZT+H6NKca5op8lm1a1HNhGUiBevG+mkJye7VwGM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1733338214; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=kjtahGPaTpINYYZfuLGp4VkVf+IQcM1cz95cqRqH8GE=; b=HXboe/njq5d/+cVgEc7927qDFDglAi8ZLe2tk/IF4tO9SpNFUyCQ9fh77+Y/Dv+f bsmqsrbjzTwEz5Iehg0e0hioxAkqmEmISfpOx7Wfyb9sCKg0cYX0Zroy5r//1wSAxER mFClzVHePVTypNGMHqf4Iv5EX7D+OMx2qFM2K2/c= Received: by mx.zohomail.com with SMTPS id 1733338212967952.7450718448498; Wed, 4 Dec 2024 10:50:12 -0800 (PST) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Philipp Zabel Cc: kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/9] drm/panfrost: Handle inexistent GPU during probe Date: Wed, 4 Dec 2024 18:49:31 +0000 Message-ID: <20241204184945.1477677-3-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241204184945.1477677-1-adrian.larumbe@collabora.com> References: <20241204184945.1477677-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Just in case we're dealing with a yet not recognised device. Reviewed-by: Steven Price Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panf= rost/panfrost_gpu.c index f94337a6c302..8d049a07d393 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -240,9 +240,10 @@ static const struct panfrost_model gpu_models[] =3D { /* MediaTek MT8188 Mali-G57 MC3 */ GPU_MODEL(g57, 0x9093, GPU_REV(g57, 0, 0)), + {0}, }; =20 -static void panfrost_gpu_init_features(struct panfrost_device *pfdev) +static int panfrost_gpu_init_features(struct panfrost_device *pfdev) { u32 gpu_id, num_js, major, minor, status, rev; const char *name =3D "unknown"; @@ -327,6 +328,12 @@ static void panfrost_gpu_init_features(struct panfrost= _device *pfdev) break; } =20 + if (!model->name) { + dev_err(pfdev->base.dev, "GPU model not found: mali-%s id rev %#x %#x\n", + name, gpu_id, rev); + return -ENODEV; + } + bitmap_from_u64(pfdev->features.hw_features, hw_feat); bitmap_from_u64(pfdev->features.hw_issues, hw_issues); =20 @@ -347,6 +354,8 @@ static void panfrost_gpu_init_features(struct panfrost_= device *pfdev) =20 dev_info(pfdev->base.dev, "shader_present=3D0x%0llx l2_present=3D0x%0llx", pfdev->features.shader_present, pfdev->features.l2_present); + + return 0; } =20 void panfrost_cycle_counter_get(struct panfrost_device *pfdev) @@ -489,7 +498,9 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) if (err) return err; =20 - panfrost_gpu_init_features(pfdev); + err =3D panfrost_gpu_init_features(pfdev); + if (err) + return err; =20 err =3D dma_set_mask_and_coherent(pfdev->base.dev, DMA_BIT_MASK(FIELD_GET(0xff00, --=20 2.47.0