From nobody Fri Dec 19 04:54:26 2025 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 948111FAC51 for ; Tue, 3 Dec 2024 17:44:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733247862; cv=none; b=qTJH0fUTOGte+6CvRPeluKm0yyyCvjRoR2DcUpQHgt7CrCp5sd8Oq0/R1gvSmOO9P9Wq7jh7KCnFso1i4bHfmBAqaMqjKfrVCfxeRggsgoWr2mFvEoFPyarNq3Johb+QRRJgN2ARUAeGuI+a16tarY6qPzI6M8sL0aOayXICBrw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733247862; c=relaxed/simple; bh=/p05xSypzO/4OeH+2vX+nGZmcBYlJ2JK65edxSL5uQo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pAKuhp5LtIk/vvwOWGT4Oqny0Es0yFbfU1Z854pXFHLhznRctMGwd1AhBGEk+kw+mv2tG8sRhdyo2HVim7stOIxxTWMyPdfXMpjvU1D1EzW9gO9Jdjtt4Vou+mVRy5e+vyKCBnsDlezMi9+e7Uneb9EesieOcI5ndLAG4X5gi9Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=U0weV0Y6; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U0weV0Y6" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-434a9f2da82so51231775e9.2 for ; Tue, 03 Dec 2024 09:44:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733247859; x=1733852659; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=20enjGFbIMY6ySoTLbqeBiSJRGb2uQMuia/Z5TqK/Vk=; b=U0weV0Y6Dd76An6ast9Ib9o0DP3SetY+zXv/J9FiR0Y0buNdXZeA3obQK33TpDxKVa JDQWmg2W1IXCvBNJfT2yFAd+HNF97H6Av9MBOX/r13dvXLovztEjkENQ7tmCGf8SuzCX LZDCWu+0V2LDFj7ZSmmlmAVbTvbpbad5LWWTRerrGTRTvWJ/P9WMBFOkYsObqmTPO5rY p3nU0S5fIumsKDAGRUhOw+hs3TmNdhr9dyfTUKwVFiUBGPjxb4m72NDRaxpapNfTaOSw Jhtov0VB/5mKZVUBuHUIHyG/FM52cLla8FMtmV3jo7J8h7lfBWqEZmPQZCQXVSGD4etN 9gxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733247859; x=1733852659; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=20enjGFbIMY6ySoTLbqeBiSJRGb2uQMuia/Z5TqK/Vk=; b=j60xKg4z/IsUT9X9B3IJxVJ+cL4X2beAfm06S6JI2o0Is1GoGvh+XT4EkfN2lQHqb0 1eq0fZ2TZiuOTmp6YixCJnmTFmGj/bNcfH9hOvlR2FsWgsnuZ0oVk4b0fUsslSw9D083 o41QoJrv+/C0jVqArUNo9R02Z0S6Bb9ateqdesP9uvnUHRgjpYw8CRRYvLM31RFOGito AA5J2PjMJgPtxO+w2xiCIxhs7MMg+Lg2+EI5092cZK09uhZtzc1QfjW6tGLwIVq7kSJh a5OyB+Cs4Z3FLOlP3sA93ZR/76ZAZ5wxBPeLQ1ZMyeheAVMeyYArUtjl/vblTMyhv+3Q T+Fg== X-Forwarded-Encrypted: i=1; AJvYcCXbLszVitxsk3/1ESiO+IyPejwKqTVq7jfHr+d6CZPmZDqNFr4tJ6I4tisjRw75+OPcgngq9uB8Cz9m7no=@vger.kernel.org X-Gm-Message-State: AOJu0YwRrqUICrLd/nH01UtjgR7ATNiCPthGf7Hf5e/h0P5NKJIYbEs/ /PXWENbrdalg6FN9F/nRrsFvmUnyvFQTDJpi1NuHBAisABHiDSPlLe5Qwra+uew= X-Gm-Gg: ASbGncu1qSqKqa7HAqKX8bXK7JM5DR6ZzBkZgjBJthTp5oMjdSNqiNigmUbCWQp/+Zu 90Mf60tdtSFYNJg9C+V3jLGfy8/wUqLb1GUmO+XdyIgc0x15La+kriQoTyPh24H/9W1BbiSZB4m SV63NnHTaTYEwOCOFnu368P2t+mVGzuPi38qVfGObWHxZSHm/6OWF5ZgUaEXcXYVbvcEXxV5sXT oB/Vr/5Jfs/FTlXbsdAVieY/JqDvviWNrFe2tcjxsfFpBBnyTD/PMMqO6NREa4= X-Google-Smtp-Source: AGHT+IHWm+MdE4pGT7/SWD+IygidPPYvtwFY2rLG6XMxPlA0erOfEDLVdpRRoXo4nK9V4WvRYNyvTQ== X-Received: by 2002:a05:600c:524d:b0:431:5aea:95f with SMTP id 5b1f17b1804b1-434d09ce368mr32037235e9.16.1733247858857; Tue, 03 Dec 2024 09:44:18 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef40:9f9f:834f:9008:1528]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d05b4909sm17648055e9.2.2024.12.03.09.44.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 09:44:18 -0800 (PST) From: Stephan Gerhold Date: Tue, 03 Dec 2024 18:44:02 +0100 Subject: [PATCH 1/2] arm64: dts: qcom: sc8280xp-x13s: Drop duplicate DMIC supplies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241203-x1e80100-va-mic-bias-v1-1-0dfd4d9b492c@linaro.org> References: <20241203-x1e80100-va-mic-bias-v1-0-0dfd4d9b492c@linaro.org> In-Reply-To: <20241203-x1e80100-va-mic-bias-v1-0-0dfd4d9b492c@linaro.org> To: Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Conor Dooley , Srinivas Kandagatla , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.14.2 The WCD938x codec provides two controls for each of the MIC_BIASn outputs: - "MIC BIASn" enables an internal regulator to generate the output with a configurable voltage (qcom,micbiasN-microvolt). - "VA MIC BIASn" enables "pull-up mode" that bypasses the internal regulator and directly outputs fixed 1.8V from the VDD_PX pin. This is intended for low-power VA (voice activation) use cases. The audio-routing setup for the ThinkPad X13s currently specifies both as power supplies for the DMICs, but only one of them can be active at the same time. In practice, only the internal regulator is used with the current setup because the driver prefers it over pull-up mode. Make this more clear by dropping the redundant routes to the pull-up "VA MIC BIASn" supply. There is no functional difference except that we skip briefly switching to pull-up mode when shutting down the microphone. Fixes: 2e498f35c385 ("arm64: dts: qcom: sc8280xp-x13s: fix va dmic dai link= s and routing") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/a= rch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts index f3190f408f4b2c7ca9fe368d652d5d66bb3949af..0f1ebd869ce315bfed2c17ae90b= 2451b3892b96b 100644 --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts @@ -1202,9 +1202,6 @@ &sound { "VA DMIC0", "MIC BIAS1", "VA DMIC1", "MIC BIAS1", "VA DMIC2", "MIC BIAS3", - "VA DMIC0", "VA MIC BIAS1", - "VA DMIC1", "VA MIC BIAS1", - "VA DMIC2", "VA MIC BIAS3", "TX SWR_ADC1", "ADC2_OUTPUT"; =20 wcd-playback-dai-link { --=20 2.47.0 From nobody Fri Dec 19 04:54:26 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF921FCFD3 for ; Tue, 3 Dec 2024 17:44:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733247864; cv=none; b=YQaLv1ztDTg+RbkbJ7vGc09hbha1CdYQCkPZI654HYrABsdCZq8ULyA/tGF3akW/o0VkDO3HVWUp/F+Nd0VNAx4VJoZaNLlDYkAN8Ve4KGkSNhUZFleasnFD9LPnBfghn0yhf0ig4LS0bK3pt7wU8+C0jwGLAFBZ5OlwWmEAWZ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733247864; c=relaxed/simple; bh=2vUh2HRZeyPWfbk0QDMsBffCmlUfC7m/5QcWWanc6W8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=AGPVwZ4Jpqc+7J7wjJbG9MtN+C5AyeMLhMup+5YRjlLYzs8j+B9zCI5JjPckuTrmyN8Et6CHcpDQaYmhkvdz/KoJBzjLXlCpwXfiN8yszFHUeZZI29/Zlf6xagbos65tCKjypKXKua6t8IcVugfDetuy721lSQd0bjcjSdMFb7E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=E7+J0tKw; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E7+J0tKw" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-385e06af753so2466685f8f.2 for ; Tue, 03 Dec 2024 09:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733247860; x=1733852660; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=eiErjYAhu8MnB1/TnKAdAC45bnXaP34pbBdqkHH8OQc=; b=E7+J0tKwi9qZsncfVqm68oPZRrKd/kk6i7iObD+hk2Zg+LSFigy3K7jEIhaG9heEPX WUEIFemmw+8CUpl2krzhNneQPYnYzYVfmsockR1akn97XxKdymfNsCqVAEfwdqqHSkoK MI3yVWhb4Hjm6epVMgaH5WH/np8OWjbhn9WTTONmiF/lnz8QIvrRl6NxEdloWslI1BnR 9U2oNrPD9h7sx3MJHw4NgnsH/Nbd+ogjrgd+pD9/R3eloFFh+qioVkTCIqvMsWIGXz+y 1vU9Fvk+Dr7mjz/J+kGaCVee5LwHyeLAGzae6yir+80YpXYRtkHcmN+zvwPt7NQWIMoG 8AxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733247860; x=1733852660; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eiErjYAhu8MnB1/TnKAdAC45bnXaP34pbBdqkHH8OQc=; b=DmIfzehRPWzMfMCOUivNxIuJM6N3Z8NuuMVSs7fHOPswYv4lO9LrRcIf79ufBxSxYM PbOAPE2Bs+aNvCw++wfH2CveOYbClmolHcHioz45FPRPTexy9vL7Ll1vJrri6fuNJzmI VzEEPpeLGstPkpN9Ue5gVKnrDbfi+CYgSUMLBCTcl69v+ZfcNblc4s2V3SZOz2CRDMRd VNG4SIsf5OFFSjsIf6SlVftX0qLkHjcs8GFyA7Ptp9NYHl7Taw4yMFs5xSe01Pmd52nL hjhMcVvN1hRmfJfjZ95h6oDA5mwv3eD99KoVVdOGz4OYJbkV2goLqt0D2+/2gyChx3yo WIjA== X-Forwarded-Encrypted: i=1; AJvYcCV7alnvBKTICLTMOWrhKmmerPYDDQP5Ytw2tYIHksJ82v1iIsSHh20DYpXS9AI0JJINxGiKd1FkRLPZTmw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9U87xobltoZn5/5jMWqm95ps37EAoritkhuEPAC51IsF4PyyG qsbKD8ZfxmHs18VdP1zup953WVa6x0adlKtfkskQ99g2f6uHNDoQ2NA92FJ4pzA= X-Gm-Gg: ASbGncsRIOYUdkVjR7KGbKZc4vvsiJ/SXRTp5m5q+IhdjARPyLrdjVtPA/c70nWQYlf MvQzKBuyiG4EIdUHp6oPhbAO+gB4FeJCj4WgVbFmRTfPRZAaoq2qz6cvKgxqXRRTN43BEcrFLZQ JlHlOnK7EOfrSZeImSis55VHwj+CFWrGpEmyQXugdbQur6hJhP/yigwJh3zQR7Py0TyimDWgftD 5x1laTOSdnxqNYbNiDujHDRERyQgVlkyvVP7hOtiqhVNFhqwG0xIAgbAdWHzUs= X-Google-Smtp-Source: AGHT+IFL8yQpR4qeo7vpbXPHJqpugZ+Ztt1Yb4rNNqrVGzJhhHzSTPAwa0n5C5zUlHAIIYEJzjKpwQ== X-Received: by 2002:a05:6000:2a1:b0:385:fc00:f5d4 with SMTP id ffacd0b85a97d-385fd3e9d3amr2314279f8f.29.1733247859714; Tue, 03 Dec 2024 09:44:19 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef40:9f9f:834f:9008:1528]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d05b4909sm17648055e9.2.2024.12.03.09.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 09:44:19 -0800 (PST) From: Stephan Gerhold Date: Tue, 03 Dec 2024 18:44:03 +0100 Subject: [PATCH 2/2] arm64: dts: qcom: x1e80100-crd: Drop duplicate DMIC supplies Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241203-x1e80100-va-mic-bias-v1-2-0dfd4d9b492c@linaro.org> References: <20241203-x1e80100-va-mic-bias-v1-0-0dfd4d9b492c@linaro.org> In-Reply-To: <20241203-x1e80100-va-mic-bias-v1-0-0dfd4d9b492c@linaro.org> To: Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Conor Dooley , Srinivas Kandagatla , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.14.2 The WCD938x codec provides two controls for each of the MIC_BIASn outputs: - "MIC BIASn" enables an internal regulator to generate the output with a configurable voltage (qcom,micbiasN-microvolt). - "VA MIC BIASn" enables "pull-up mode" that bypasses the internal regulator and directly outputs fixed 1.8V from the VDD_PX pin. This is intended for low-power VA (voice activation) use cases. The audio-routing setup for the X1E80100 CRD currently specifies both as power supplies for the DMICs, but only one of them can be active at the same time. In practice, only the internal regulator is used with the current setup because the driver prefers it over pull-up mode. Make this more clear by dropping the redundant routes to the pull-up "VA MIC BIASn" supply. There is no functional difference except that we skip briefly switching to pull-up mode when shutting down the microphone. Fixes: 4442a67eedc1 ("arm64: dts: qcom: x1e80100-crd: add sound card") Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 4 ---- 1 file changed, 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dt= s/qcom/x1e80100-crd.dts index 39f9d9cdc10d8e79824b72288e2529536144fa9e..a4d8da81bb4468e03ba8a9d37ef= aae10f7a6b53e 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -188,10 +188,6 @@ sound { "VA DMIC1", "MIC BIAS3", "VA DMIC2", "MIC BIAS1", "VA DMIC3", "MIC BIAS1", - "VA DMIC0", "VA MIC BIAS3", - "VA DMIC1", "VA MIC BIAS3", - "VA DMIC2", "VA MIC BIAS1", - "VA DMIC3", "VA MIC BIAS1", "TX SWR_INPUT1", "ADC2_OUTPUT"; =20 wcd-playback-dai-link { --=20 2.47.0