From nobody Fri Dec 19 04:52:22 2025 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F3C51F8AF9 for ; Tue, 3 Dec 2024 16:27:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733243260; cv=none; b=I3IMzIiR9HE7v2D1i/4X974Jl3pPeWVibfAE46uv/8ArU1zLsXpg8pnQTDKPl4wbGT6/ulpS3XhmgvWayu0XZV512lN3Mi8r0/YTH6DO9vsJnqY0diVKJwq70Dc4/7Ee4pmvQMszzbxyNuuypFNAbyiAb5TiSirhbiWL61JdTdM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733243260; c=relaxed/simple; bh=3ilJ60KhZP1gzrR1HYyGW8yGwQLnglqIbeYGm6MINtQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=iu15HT/87Hvxhld3vj2J4P+JQC6yTJg/PEoUB9UnwdA3Zh2QigDdSLOB21d8dPU50ADrINaqS2XL8AUpRT8J26SW3s53renWEXoIzd7GuYBAIHDUoiMff7eHyEWhicgGR4XvDJXfq9n1bgLC9NytqPyBUgq1fjMTi3lYwyT27Ng= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zQJe5Cud; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zQJe5Cud" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-434aa222d96so71066515e9.0 for ; Tue, 03 Dec 2024 08:27:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733243257; x=1733848057; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=T/3G8yPHdtPq2X4oFg8aeUad7hD0nbgD7cFuNqRSr8M=; b=zQJe5CudbLWZYIdBmeBwU2YQnuWwV0y4td+wqZ/5rZIu4ltBSo/w6KloezrN8JkhMw +6aR9LZJWdLW8Wqev7aZt803OsQn5FA4mC6gxWYQ5TmjsQ5dzj2aKkaYYD1pXm8yXw9L T+1AOjGp7t+BpYjif2C5ctIpoAr0llQwGdraFvyw20hiYPqW71KJOH2ahRMetDZud7KS 5NPYmque5P6kTfJC3v0AE1IHQb5Dm68upVf0WZNWv1voilTdEbYKOuJili3GKkWG1/2Y UlCDPE7x2lfSSe7SA0ZzuQyoD3iaTS/Y1E4qynyr22dbJX1y0HAucVDQBV1G2qMMCBOw 8VsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733243257; x=1733848057; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T/3G8yPHdtPq2X4oFg8aeUad7hD0nbgD7cFuNqRSr8M=; b=Z8TyeGZTbtALUWGX97ri+OyqHnBCdz8ZkhZOXXYgUZnMbKTHrtC63swOSeJRWUVyrR 42yudeE4EHv+yzzBL2stgB0ZYtDVPM4BDLahlhFPKHoOUJPTrgkJQtGvUw0OTyLQ6yGW J3ZuyTLkNjdD361Hb04xiQnparLaX4ox0237eAjniCYiJ5naVyUbu14DmdSuWeEYu2uX S6RoccuJx63lOomcZA6Tc8trvvzwn7ycb7x+C/S0Ipg6cptJDC3cOyMJlxHC9iF5ovzh 4rTGpuVsHLoF1GS1lE9684RiYa9M3qIoA5ZSVklCp3SKPBl1fzyhE3nw6sf2EquSN4uw KRWg== X-Forwarded-Encrypted: i=1; AJvYcCW+uI0+Wv4jQQ6bghLScZuWysytjFiCtaw5sd2TQ7y1fWPaTKrmDHSBQO1busHZnXlrMFsBj8sgVvpyCuA=@vger.kernel.org X-Gm-Message-State: AOJu0YxHu6r46aXmepMo5/i+fZXLwYxmS+PFVH1KaE13ZoXmIdbbof92 BGGuIUWzmqlVnLuEFBQA3yh5v/akGxqpRgi55Iymr64xDjBmYB0qYnxJaWHHKOk= X-Gm-Gg: ASbGncsy0Lopr4v7au63/z+vz0wV+3+q76JAmDWpKQTKihEGSGh4mylQhy4fu1sfJIe ym3Duk3y9oZU7VH8V01QWWc4dC/fv5y4RlB1i4pl7YBvvrSvaHRIuDEdE/j88TsEfzOA29W1fDh y0vPSmOOA1EbkiUSfx45x9aQlmWc+Cf55zlvZAeo/sZr6FgA+4rS4JYmUmaU/W8C9fz4/Zk2EkW KClsVKy9c7SkASGDJYRyw3s+71OqudT18COIbPREuZNVpzGPD3foW9Rxak= X-Google-Smtp-Source: AGHT+IGEVUq1Uy9M3ElGXDaZu1Is65FzKHm+BqIdhN2cA4KiN6x31Zrevib2WHFALXQM/9EzR5gM2Q== X-Received: by 2002:a05:600c:6b71:b0:432:d735:cc71 with SMTP id 5b1f17b1804b1-434d0a0e3c4mr29373885e9.25.1733243256678; Tue, 03 Dec 2024 08:27:36 -0800 (PST) Received: from [127.0.0.2] ([2a02:2454:ff21:ef40:da6:821e:40a0:d7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-385ccd3a4bbsm16111295f8f.48.2024.12.03.08.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Dec 2024 08:27:36 -0800 (PST) From: Stephan Gerhold Date: Tue, 03 Dec 2024 17:27:18 +0100 Subject: [PATCH] arm64: dts: qcom: x1e80100-pmics: Enable all SMB2360 separately Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241203-x1e80100-disable-smb2360-v1-1-80942b7f73da@linaro.org> X-B4-Tracking: v=1; b=H4sIAGUxT2cC/x2MywqDQAwAf0VybiCJdqn+SvGga7QBX2ygCOK/u 3gcmJkTXJOpQ1OckPRvbtuagV8FxF+3Too2ZAYhqZilxoP1Q0yEg3nXz4q+9FIGQqGokcM7ZA9 yvicd7XjW3/a6br+PE/5qAAAA X-Change-ID: 20241129-x1e80100-disable-smb2360-20cec1656411 To: Bjorn Andersson , Konrad Dybcio Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold X-Mailer: b4 0.14.2 At the moment, x1e80100-pmics.dtsi enables two of the SMB2360 PMICs by default and only leaves the third disabled. This was introduced in commit a237b8da413c ("arm64: dts: qcom: x1e80100: Disable SMB2360_2 by default"). This is inconsistent and confusing. Some laptops will even need SMB2360_1 disabled by default if they just have a single USB-C port. Make this consistent by keeping all SMB2360 disabled in x1e80100-pmics.dtsi and enable them separately for all boards where needed. That way it is always clear which ones are available and avoids accidentally trying to read/write from missing chips when some of the PMICs are not present. Signed-off-by: Stephan Gerhold --- arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi | 8 ++++++++ arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi | 4 ++++ arch/arm64/boot/dts/qcom/x1e80100-qcp.dts | 8 ++++++++ 9 files changed, 68 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot= /dts/qcom/x1e001de-devkit.dts index c9db6298d528ed505bae08e91bf4da02faef7d76..c3ec0bb2c42dfed9f5e9f56f188= 74b4ae6c0632c 100644 --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts @@ -1062,11 +1062,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts b/a= rch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts index 975550139e1024420ed335a2a46e4d54df7ee423..4097d2677285757ce67eef76d8d= 17669c7130001 100644 --- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts +++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts @@ -635,11 +635,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts b/arch= /arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts index f25991b887de3fca0092c5f81c881c5d8bd71aac..10f140ed08f47f2cd96e953d4ad= 3c75f3aad002a 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dts @@ -501,11 +501,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dt= s/qcom/x1e80100-crd.dts index 39f9d9cdc10d8e79824b72288e2529536144fa9e..81c519e690f325f2d4d36c4a990= 61649da65ec87 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts @@ -932,11 +932,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/a= rm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index b112092fbb9fd955adca1ae8a76294c776fa2d1e..288e818961670be0d25b696730e= 7186a8d61b56e 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -905,11 +905,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts b/arc= h/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts index ca5a808f2c7df66a861a933df407fd4bdaea3fe1..3d7e0230dc0381a2c2a3b0c5b76= 6f5b854777937 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dts @@ -717,11 +717,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi b/arc= h/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi index 6835fdeef3aec10206e8b2839d23e4f3494afe1e..6941945b2f9a7e7b11598705fa2= 2d3a6f2cc01c7 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus.dtsi @@ -718,11 +718,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d>; vdd3-supply =3D <&vreg_l2b>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d>; vdd3-supply =3D <&vreg_l14b>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi b/arch/arm64/boot= /dts/qcom/x1e80100-pmics.dtsi index 5b54ee79f048e3208cbcd6f91e0cec073420fe63..d7a2a2b8fc6c30bdb10df81eac7= d92306998838f 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi +++ b/arch/arm64/boot/dts/qcom/x1e80100-pmics.dtsi @@ -491,6 +491,8 @@ smb2360_0: pmic@7 { #address-cells =3D <1>; #size-cells =3D <0>; =20 + status =3D "disabled"; + smb2360_0_eusb2_repeater: phy@fd00 { compatible =3D "qcom,smb2360-eusb2-repeater"; reg =3D <0xfd00>; @@ -504,6 +506,8 @@ smb2360_1: pmic@a { #address-cells =3D <1>; #size-cells =3D <0>; =20 + status =3D "disabled"; + smb2360_1_eusb2_repeater: phy@fd00 { compatible =3D "qcom,smb2360-eusb2-repeater"; reg =3D <0xfd00>; diff --git a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts b/arch/arm64/boot/dt= s/qcom/x1e80100-qcp.dts index 5ef030c60abe2998d093ee60a6754a90cd5aaf72..ffd28fd8059895ec345f4ee8fe6= a2c37e7989747 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-qcp.dts @@ -731,11 +731,19 @@ &remoteproc_cdsp { status =3D "okay"; }; =20 +&smb2360_0 { + status =3D "okay"; +}; + &smb2360_0_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l2b_3p0>; }; =20 +&smb2360_1 { + status =3D "okay"; +}; + &smb2360_1_eusb2_repeater { vdd18-supply =3D <&vreg_l3d_1p8>; vdd3-supply =3D <&vreg_l14b_3p0>; --- base-commit: 12b080aaf4275c579c91106ed926044b4d5df0af change-id: 20241129-x1e80100-disable-smb2360-20cec1656411 Best regards, --=20 Stephan Gerhold