From nobody Sat Feb 7 09:37:07 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC5BC205ADC for ; Mon, 2 Dec 2024 14:31:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733149919; cv=none; b=MycoFsdFJBCxVODQq+MyEjwqiu8tjYDasETvmPp2kozA0rndwF06T3an2dlxwolEgKRmdL5LraMctRku+Vho+T/wnw7UqqbIH6T+23vADGnWG9J+sWZ9xhTRAqkbZpl6NT1CVNnvxBwsv2o+0ivFLNaYdUNK628hW+Xyl/rJhTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733149919; c=relaxed/simple; bh=rQ3W2F3r6HiohVE0vY/OBK/76HhFWdieLGVWaORhDMQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MoLJQL50spx7VFZhjvIYnVvk17AYyDZLjPzVjgX+RlsHj9tp0IOsbhHPHGSbZS/04NHj8q4Jk+PmmsIYu9+fFaDD9GV3iIsDOUo2CirQNnRJf5+rl6mZU+EhCABfNp0dRPm4NE6QuNfNuyXrgOk65kjt0PGjl24wtMlXKhIgbFI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CDILgaSN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CDILgaSN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733149916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=obq27x78dLFVc+cuRfM1jM6wMytnV14P+u4LaoDA4AU=; b=CDILgaSNVFDRskNicqHI5E/dmokqKFyTQUd0jfwivcKxSVT1PPu8TU6p2/V51/Wt3Nhi0r 27womAxsgOVRXVAX2+a1yHPWE/xJ5O6vT1Y9zXYy2IaRZdczvQFyhjeEa6yDy0qMc6Mnef krzGM0qrSjRTmi+DERQnOtH/ilkEATk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-ZOjw3ZL8MdimR3D-8UBnNA-1; Mon, 02 Dec 2024 09:31:54 -0500 X-MC-Unique: ZOjw3ZL8MdimR3D-8UBnNA-1 X-Mimecast-MFC-AGG-ID: ZOjw3ZL8MdimR3D-8UBnNA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CDDE019373E6; Mon, 2 Dec 2024 14:31:49 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.42.28.48]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E9AE11955EA8; Mon, 2 Dec 2024 14:31:46 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Yunsheng Lin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 11/37] rxrpc: Add a tracepoint to show variables pertinent to jumbo packet size Date: Mon, 2 Dec 2024 14:30:29 +0000 Message-ID: <20241202143057.378147-12-dhowells@redhat.com> In-Reply-To: <20241202143057.378147-1-dhowells@redhat.com> References: <20241202143057.378147-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Content-Type: text/plain; charset="utf-8" Add a tracepoint to be called right before packets are transmitted for the first time that shows variable values that are pertinent to how many subpackets will be added to a jumbo DATA packet. Signed-off-by: David Howells cc: Marc Dionne cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: linux-afs@lists.infradead.org cc: netdev@vger.kernel.org --- include/trace/events/rxrpc.h | 41 ++++++++++++++++++++++++++++++++++++ net/rxrpc/call_event.c | 2 ++ 2 files changed, 43 insertions(+) diff --git a/include/trace/events/rxrpc.h b/include/trace/events/rxrpc.h index 9dcadad88e76..71f07e726a90 100644 --- a/include/trace/events/rxrpc.h +++ b/include/trace/events/rxrpc.h @@ -903,6 +903,47 @@ TRACE_EVENT(rxrpc_txqueue, __entry->tx_winsize) ); =20 +TRACE_EVENT(rxrpc_transmit, + TP_PROTO(struct rxrpc_call *call, int space), + + TP_ARGS(call, space), + + TP_STRUCT__entry( + __field(unsigned int, call) + __field(rxrpc_seq_t, seq) + __field(u16, space) + __field(u16, tx_winsize) + __field(u16, cong_cwnd) + __field(u16, cong_extra) + __field(u16, in_flight) + __field(u16, prepared) + __field(u16, pmtud_jumbo) + ), + + TP_fast_assign( + __entry->call =3D call->debug_id; + __entry->seq =3D call->tx_bottom; + __entry->space =3D space; + __entry->tx_winsize =3D call->tx_winsize; + __entry->cong_cwnd =3D call->cong_cwnd; + __entry->cong_extra =3D call->cong_extra; + __entry->prepared =3D call->tx_prepared - call->tx_bottom; + __entry->in_flight =3D call->tx_top - call->acks_hard_ack; + __entry->pmtud_jumbo =3D call->peer->pmtud_jumbo; + ), + + TP_printk("c=3D%08x q=3D%08x sp=3D%u tw=3D%u cw=3D%u+%u pr=3D%u if=3D= %u pj=3D%u", + __entry->call, + __entry->seq, + __entry->space, + __entry->tx_winsize, + __entry->cong_cwnd, + __entry->cong_extra, + __entry->prepared, + __entry->in_flight, + __entry->pmtud_jumbo) + ); + TRACE_EVENT(rxrpc_rx_data, TP_PROTO(unsigned int call, rxrpc_seq_t seq, rxrpc_serial_t serial, u8 flags), diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index 3379adfaaf65..1f716f09d441 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -259,6 +259,8 @@ static void rxrpc_decant_prepared_tx(struct rxrpc_call = *call) if (list_empty(&call->tx_sendmsg)) break; =20 + trace_rxrpc_transmit(call, space); + spin_lock(&call->tx_lock); do { txb =3D list_first_entry(&call->tx_sendmsg,