From nobody Mon Feb 9 07:43:53 2026 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA65D1F9A92 for ; Mon, 2 Dec 2024 08:34:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733128447; cv=none; b=l6emoXHMvXVrge0h+4ii7xXzEvHVKAzKyk4oTNumii4vWZofd0C2Xpj4MlDHsKPTYxszK8EYgKIk54dXxALUMDo+jaKVphLXikjxcdHBqXA6seV25/1a6JcWNy72WgSFo7XBZ/j8yyGdXk45+EozhTl2tL1ZtfiR8Rn916YA25c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733128447; c=relaxed/simple; bh=GhRp7JAn6rcOImHrJCrFQPMHal2W8dEKI12mch1qSdI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=hvJ6WxgvQgzRviGaNke5LEpwaw4Tv8gh1QkK9sWRWASQdzohL6xhHo3As6jRAoHPx6M9mkjZSf/6cxx7Bb7pVRcmjqOs4RCDvmI39ocnxKSurGn4N8D6DzpDiP9D+7pc5Rj6W90Zy+50YEZPS/l7h6RKZP4NVJ8SnAtBoQgAoIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=qKTfOB7j; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="qKTfOB7j" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-53de579f775so5285446e87.2 for ; Mon, 02 Dec 2024 00:34:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1733128444; x=1733733244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QzUuqdFRJBTOc5WUYdPFncGjQZclBe0xdjO8DYZWI9w=; b=qKTfOB7jYgFomvnPYrrdm2w1osEZOKYa/AHR9WhFRHb/BlK+XJu/Il5JIpCNj5RLw8 e+dJm4tVS0b7XS0yp3kW/raaGnTeBjDpLv+Pm86iOeIMkfnC44kQ6VwcYxRyFyKHRYgp 8E0hNObtOREQt8U42s0K3ZIRsyvi+ClI2V9rMbX97K/2CvdtQTf0oyBLK7wemGIQXBVg 4oID0gBV6/ofIxntzH6KpX/Fn9w/qe3Id0J4QDempWWiyzZbVbO0zfZ6f7urpOvbKfNL r07YxD16YHaVQh4wD+xZhWfXlkCzyYVqflPsmijqXdEmx+bMVbxHgeCifNHk7ymuAxqF CeVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733128444; x=1733733244; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QzUuqdFRJBTOc5WUYdPFncGjQZclBe0xdjO8DYZWI9w=; b=oDdRWbTgCYkHz+jg5dkZoNXz2PU3vOPUUwygX35GxlEMEPDk9qFwXlcBo3epZNXul2 UVFCeiWXgKeo6aI1QaQ+1ONpHgPPpiZl2Blb/s6NHcRZqwO3unI7R8UZsRuwlXyrhWGP urKP/dtE/LPUGIijcAvhkj050NvSuA/xUNbOkMD6IgrRodgLB9WXL1MSsq8gIBNmLTXQ BNP/h/Kmfkp3nWu2pD7OLg6IXDMuQhckV9n2ExInvb/eq808wmAqGHhllS34JfDjQlQK CVdYohikd96Mi71YyDOiPH+Wusdwev8+WBgLaRunExM9YeNbAHPiHZVsvZ/eYgFqYEAA 1NPQ== X-Forwarded-Encrypted: i=1; AJvYcCWPoVyyUlP9gwU7iK6iiY7BD83a1KzsM6b04wAMWiOeumXRoXP+RFjsTwL8RnyVphTksFfTr/fzJ5pt4q4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8+emv/+Rvk6IYpzUaT2By6mR5csFQW3gEyZBUNflna67Mf7av vSetiEW4DcqSrTD049o5+g1AYJgRnn6CcIxCAZw/dQidgLAGILE6H/lCHvVpQfo= X-Gm-Gg: ASbGncuRrF37mVKrsso30vkIzYfsfrOQ14y2IqBLuXbW6sPoy6Mbzw4U/JQ8KnH/9po Q65pBFzbJPiFg/Ixxe7B1Mz+iYGemHQcn2eBH78ZKP5iCg9i8WHHuOyKDAJnVlB/J4bWZLwhjFE 2PEMVdBOzoZ2Ag23ddayuns9Rj+XkQ4WHbRN0JDv7K8G28hXzUzj8UPkly/eKY89fSap1w6IiA8 wZmRfffHTnh/kRwLXKLvVIHz0MDoRqTF+gaWE6ZEPbAduwSoCxUw+SYnknuVf6G X-Google-Smtp-Source: AGHT+IF93Cj6VrT2AYZC5DEqo9FH75ITtrTeuuLtaax9mwkC+oOsEvZlaiWYlMoQiQwe7SW7NGiL3A== X-Received: by 2002:a05:6512:3e1a:b0:53d:dbc7:981 with SMTP id 2adb3069b0e04-53df00d030dmr15664997e87.16.1733128443606; Mon, 02 Dec 2024 00:34:03 -0800 (PST) Received: from cobook.home ([91.198.101.25]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df649f5a5sm1409712e87.236.2024.12.02.00.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 00:34:03 -0800 (PST) From: Nikita Yushchenko To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Dege , Christian Mardmoeller , Dennis Ostermann , Nikita Yushchenko Subject: [PATCH] net: phy: phy_ethtool_ksettings_set: Allow any supported speed Date: Mon, 2 Dec 2024 13:33:52 +0500 Message-Id: <20241202083352.3865373-1-nikita.yoush@cogentembedded.com> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When auto-negotiation is not used, allow any speed/duplex pair supported by the PHY, not only 10/100/1000 half/full. This enables drivers to use phy_ethtool_set_link_ksettings() in their ethtool_ops and still support configuring PHYs for speeds above 1 GBps. Also this will cause an error return on attempt to manually set speed/duplex pair that is not supported by the PHY. Signed-off-by: Nikita Yushchenko --- drivers/net/phy/phy.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c index 4f3e742907cb..1f85a90cb3fc 100644 --- a/drivers/net/phy/phy.c +++ b/drivers/net/phy/phy.c @@ -1101,11 +1101,7 @@ int phy_ethtool_ksettings_set(struct phy_device *phy= dev, return -EINVAL; =20 if (autoneg =3D=3D AUTONEG_DISABLE && - ((speed !=3D SPEED_1000 && - speed !=3D SPEED_100 && - speed !=3D SPEED_10) || - (duplex !=3D DUPLEX_HALF && - duplex !=3D DUPLEX_FULL))) + !phy_check_valid(speed, duplex, phydev->supported)) return -EINVAL; =20 mutex_lock(&phydev->lock); --=20 2.39.5