From nobody Sun Feb 8 05:28:10 2026 Received: from forward203b.mail.yandex.net (forward203b.mail.yandex.net [178.154.239.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C101F9E6; Mon, 2 Dec 2024 08:07:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.154.239.154 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733126884; cv=none; b=BrbAp8poBxqmBo+ZRTLdEj7UORQP1xF/qnJ9lRhq/Wx+Y/FrwLatojAmw1/1kt8Rh552O38svA0y0W8zLiDKO6MNBzKzks5/6d0YjPTZA/V2eybrcSbnxD7w9ZRnGu+Cxa46HK9t3ovF96Aiw6MlEqlYreNygapN0ux/7hs5vrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733126884; c=relaxed/simple; bh=MSW5BTDyePFiKoa+mbURS90jRDsWlUIgeZx3jybnPRI=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rGrBEG47MqqSWswZlEbZy0MiCJM8e/12vAHXD0AS8rFZJwTNAgpxnGQV+AxueHjiZLbosVRJcDdBDtMoSWnxkexZ7VSL9YpkyaVGNECcqGGj/C2YdXFMIKBM7XR8ReZqi2v5LUdgtRoj0Lw3XtqseFBHeC974q4K6a5GlBtSfuE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=itb.spb.ru; spf=pass smtp.mailfrom=itb.spb.ru; dkim=pass (1024-bit key) header.d=itb.spb.ru header.i=@itb.spb.ru header.b=YZCkkwv0; arc=none smtp.client-ip=178.154.239.154 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=itb.spb.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=itb.spb.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=itb.spb.ru header.i=@itb.spb.ru header.b="YZCkkwv0" Received: from forward101a.mail.yandex.net (forward101a.mail.yandex.net [IPv6:2a02:6b8:c0e:500:1:45:d181:d101]) by forward203b.mail.yandex.net (Yandex) with ESMTPS id D4E786486C; Mon, 2 Dec 2024 11:02:12 +0300 (MSK) Received: from mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net (mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net [IPv6:2a02:6b8:c12:2720:0:640:5aee:0]) by forward101a.mail.yandex.net (Yandex) with ESMTPS id 803B560F03; Mon, 2 Dec 2024 11:02:04 +0300 (MSK) Received: by mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net (smtp/Yandex) with ESMTPSA id f1ZvNeGOfiE0-wjjuYp10; Mon, 02 Dec 2024 11:02:03 +0300 X-Yandex-Fwd: 1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=itb.spb.ru; s=mail; t=1733126523; bh=fAvlWEkjGOo1q72idjWA0Eucb8ySH4M7IRqqfWdyYRE=; h=Message-Id:Date:Cc:Subject:To:From; b=YZCkkwv0CsBqEe9B3jleawzwSzgsrdVWTohT8pxpvgP4vnYIybRWF2MoGiOFsWpJQ t0u4obNc4EDN19bYamRefun5j7kg56DW7YghxnRW/uriBhWV6+C1yP0KyoU19KYt1S 1oQXmUZu5CD2fgaGtmHWiO4v5D1Gf56aQFBvbB0w= Authentication-Results: mail-nwsmtp-smtp-production-main-42.myt.yp-c.yandex.net; dkim=pass header.i=@itb.spb.ru From: Ivan Stepchenko To: Kenneth Feng Cc: Ivan Stepchenko , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , Xinhui Pan , David Airlie , Simona Vetter , Tim Huang , "Dr. David Alan Gilbert" , Alexander Richards , Samasth Norway Ananda , Jesse Zhang , Rex Zhu , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, lvc-project@linuxtesting.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] drm: amd: Fix potential NULL pointer dereference in atomctrl_get_smc_sclk_range_table Date: Mon, 2 Dec 2024 11:00:43 +0300 Message-Id: <20241202080043.5343-1-sid@itb.spb.ru> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The function atomctrl_get_smc_sclk_range_table() does not check the return value of smu_atom_get_data_table(). If smu_atom_get_data_table() fails to retrieve SMU_Info table, it returns NULL which is later dereferenced. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: a23eefa2f461 ("drm/amd/powerplay: enable dpm for baffin.") Cc: stable@vger.kernel.org Signed-off-by: Ivan Stepchenko --- drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c b/drivers/= gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c index fe24219c3bf4..4bd92fd782be 100644 --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/ppatomctrl.c @@ -992,6 +992,8 @@ int atomctrl_get_smc_sclk_range_table(struct pp_hwmgr *= hwmgr, struct pp_atom_ctr GetIndexIntoMasterTable(DATA, SMU_Info), &size, &frev, &crev); =20 + if (!psmu_info) + return -EINVAL; =20 for (i =3D 0; i < psmu_info->ucSclkEntryNum; i++) { table->entry[i].ucVco_setting =3D psmu_info->asSclkFcwRangeEntry[i].ucVc= o_setting; --=20 2.34.1