From nobody Sun Feb 8 18:33:14 2026 Received: from mail-ua1-f52.google.com (mail-ua1-f52.google.com [209.85.222.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67F894C62B for ; Mon, 2 Dec 2024 15:47:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154447; cv=none; b=b/2tAfEXHvHj1vPTrBnjHtMakf67vyPYRn+BFqLCRu+bjn8OR1g8G3YdqRJgey0QIiwFBfJiSRvHvJFlJY8sl75vKzPBMu3uR8x7+HR/cqgAyvC9WJ6G4WQRSHmwaEV6jHO334Fx/ksAOlB2DKQn+y3kGIMVPsTZmrF4SNUhU8w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154447; c=relaxed/simple; bh=mtiQtlXyI3b6sJIsjA4TwpaNavz3zj9aF+MIz5P2kic=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JTKLhUuBhm0vNxuv3NG/PYOo9FS6j2ge8/CZrlepYQCxxstP3kebhF1mRjYXwAcCLyBmqLHOFyBp4S8PayDp0HnjlapewzEdq54vYDkIFEeYhPd9tiFOM2y4O7NIaf63akh5btOtpQE05Nv/FODCUHgfZJzZDArNtFBrYfnyq3c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=OEhgyWGc; arc=none smtp.client-ip=209.85.222.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="OEhgyWGc" Received: by mail-ua1-f52.google.com with SMTP id a1e0cc1a2514c-85bc6a1a48cso750532241.0 for ; Mon, 02 Dec 2024 07:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733154441; x=1733759241; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=RkEW/0Y6zT4/Atf/d+puMl0WcNDtT8U8UDsIe65uvgE=; b=OEhgyWGcKXzsgFxQ5qCx3Qve3IiYC8Tcdya5BUHVAlcLvExGxT4hLwlBAA53vHG+fc ICMI1w4R6nH4/27DtxQZEHDyqGmuS5/JEMHTy9w6Tvl4m5shGwUWY1X7Yf3LW+gN59dT F+gcfmO4Q2sBal5m7xgJ2aAo7b22Y1Y+itZuw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733154441; x=1733759241; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RkEW/0Y6zT4/Atf/d+puMl0WcNDtT8U8UDsIe65uvgE=; b=nNjwWQs11fXjlBlucSsl2VXFHx2Dq61JrXa8PI77/jxcH3GIRLay1dwuA7O0wde3DG t+0GXAmlHMi19RYyXr0de+3IA/PKl0mK5s3Q8rAXcVQ0lmAc8RQaO2npvesWtXEt9ZfT FDaEO/z4puffoOGeV73aZMOe8Bnunw3x1O23FQ0i0WX4NU9C3V/sQmD4liMQQ8B1Bh/T rsjuZ07AqHN6BApeJumLQXlkAza9kXicKRQnmN58oAELib6XowSlRXdpqBfTH77W9CLA 6CPoup8wsUmj39ZoFFX/fwjbTy0D1wpk3whcbgngkayu/1n69lhvt9dwTZSlpAD8Eswh avMA== X-Forwarded-Encrypted: i=1; AJvYcCXruN9F1ZxD7G38S2QW9g4gmaPSE7jVLbIYl6ansXTDmlJv1YH4j8ruiAExBbOkNN6B29MjaicRexZOOm4=@vger.kernel.org X-Gm-Message-State: AOJu0YzCpRaxQcFhFJtvSoQD41AOeE+cbF59yK7Su+bFc8xW7jPV0J4i TsLlup2FGqVNdW1Exq0SoExdZnUTweWTyqNkzlDGZpp3P13EByba9yDMQxFx8A== X-Gm-Gg: ASbGncv2DkOGape3Y2qfdZmM0RR66eysG2E4LxoTSzZT6MLs5q9Aa2dAeeko0+nwKty U48AeLwkdLeDCe+jX+72dH+sUPInt3FrAbLQ7qqtKWse/LEB+T4mQ+jAC9/2Gs8hdcbElxR4w8y 6zyzhq2hAYCJ6j/F3ENNN2VL9OI1+BBgmCaU9IsBINsJsraeR9ccxqSnBTfdoIJRkXH+280iaw1 hXmCF+y5qs0pEw7PzOctgivJy/yT64pkyPLFSnBBNVwJug9nmu5d8LuZzXR1q0YcXVFHYIcHSWw hsoGttERc/8iCD2cyPKr2Ju2 X-Google-Smtp-Source: AGHT+IGBHPCXG9TwBD4LE/oxUh/BqCKafbDdQlV9UV4NbH/ohrUS+/WPS+6wYQbT3toO5YK2KCH6Sw== X-Received: by 2002:a05:6122:500e:10b0:515:20e6:7861 with SMTP id 71dfb90a1353d-5156a8069d4mr18897232e0c.2.1733154441340; Mon, 02 Dec 2024 07:47:21 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5156d0f8ad6sm1159729e0c.49.2024.12.02.07.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 07:47:20 -0800 (PST) From: Ricardo Ribalda Date: Mon, 02 Dec 2024 15:47:15 +0000 Subject: [PATCH 1/3] media: cx231xx: Convert enum into a define Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241202-fix-llvm9-v1-1-2a50f5acfd0b@chromium.org> References: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> In-Reply-To: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> To: Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Hans de Goede , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The code is running arithmentics with the enum, which when not done with care makes the compiler a bit nervous. Because those enums are only used as defines (no argument or variable from that enumeration type), convert it into a define and move on. It is required to build with llvm 9 without these warnings: drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:673:17: warning: bitwise operat= ion between different enumeration types ('enum TS_PORT' and 'enum POWE_TYPE= ') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:680:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum POWE= _TYPE') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:687:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum POWE= _TYPE') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:702:17: warning: bitwise operat= ion between different enumeration types ('enum TS_PORT' and 'enum POWE_TYPE= ') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:709:21: warning: bitwise operat= ion between different enumeration types ('enum TS_PORT' and 'enum POWE_TYPE= ') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:718:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum POWE= _TYPE') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:727:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum TS_P= ORT') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:737:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum TS_P= ORT') [-Wenum-enum-conversion] drivers/media/usb/cx231xx/cx231xx-pcb-cfg.c:749:21: warning: bitwise operat= ion between different enumeration types ('enum AVDEC_STATUS' and 'enum TS_P= ORT') [-Wenum-enum-conversion] Signed-off-by: Ricardo Ribalda --- drivers/media/usb/cx231xx/cx231xx-pcb-cfg.h | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-pcb-cfg.h b/drivers/media/us= b/cx231xx/cx231xx-pcb-cfg.h index 5bc44f194d0a..62ffa16bb82c 100644 --- a/drivers/media/usb/cx231xx/cx231xx-pcb-cfg.h +++ b/drivers/media/usb/cx231xx/cx231xx-pcb-cfg.h @@ -57,19 +57,17 @@ enum USB_SPEED{ }; =20 #define TS_MASK 0x6 -enum TS_PORT{ - NO_TS_PORT =3D 0x0, /* 2'b00: Neither port used. PCB not a Hybrid, +#define NO_TS_PORT 0x0 /* 2'b00: Neither port used. PCB not a Hybrid, only offers Analog TV or Video */ - TS1_PORT =3D 0x4, /* 2'b10: TS1 Input (Hybrid mode : +#define TS1_PORT 0x4 /* 2'b10: TS1 Input (Hybrid mode : Digital or External Analog/Compressed source) */ - TS1_TS2_PORT =3D 0x6, /* 2'b11: TS1 & TS2 Inputs +#define TS1_TS2_PORT 0x6 /* 2'b11: TS1 & TS2 Inputs (Dual inputs from Digital and/or External Analog/Compressed sources) */ - TS1_EXT_CLOCK =3D 0x6, /* 2'b11: TS1 & TS2 as selector +#define TS1_EXT_CLOCK 0x6 /* 2'b11: TS1 & TS2 as selector to external clock */ - TS1VIP_TS2_PORT =3D 0x2 /* 2'b01: TS1 used as 656/VIP Output, +#define TS1VIP_TS2_PORT 0x2 /* 2'b01: TS1 used as 656/VIP Output, TS2 Input (from Compressor) */ -}; =20 #define EAVP_MASK 0x8 enum EAV_PRESENT{ @@ -89,10 +87,8 @@ enum AT_MODE{ }; =20 #define PWR_SEL_MASK 0x40 -enum POWE_TYPE{ - SELF_POWER =3D 0x0, /* 0: self power */ - BUS_POWER =3D 0x40 /* 1: bus power */ -}; +#define SELF_POWER 0x0 /* 0: self power */ +#define BUS_POWER 0x40 /* 1: bus power */ =20 enum USB_POWE_TYPE{ USB_SELF_POWER =3D 0, --=20 2.47.0.338.g60cca15819-goog From nobody Sun Feb 8 18:33:14 2026 Received: from mail-vk1-f179.google.com (mail-vk1-f179.google.com [209.85.221.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B143670837 for ; Mon, 2 Dec 2024 15:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154446; cv=none; b=WY5F7n05nc8B7g4Qw3i3PO1/lFRfjIY15iRdk4LONuqkAIfufQU2I73/bLVA3bRD+jkrVp1LfBIGl/u9rIT5HxjjYV/cDnuyRGH5KwYwsG+4Ph1CzTotFiU7wNam27HmjCxkoVTtfQy2OuPFhUKUdAIgpPPFj5faPH3cTCowQqk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154446; c=relaxed/simple; bh=rjvM8q19fcbBsiIYtenn0hKh0vxaDX+5kJuh6tcl068=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=siJ88f/XQpePwp21GaecryP6TeUrFZKnSIoB3sVjgvm0K58S3qpiL8Qm5AEfZKFfbx0vE3ppRkBzJy9B5E01LjiMT91KYeYO/lNptjJhLnTEKqLhK6ttUbUHN+mjGaze/sTi2gvNZRCc4gmN7psUEhF/X3lS4CR5dvuanpYw3yc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YqqnGscm; arc=none smtp.client-ip=209.85.221.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YqqnGscm" Received: by mail-vk1-f179.google.com with SMTP id 71dfb90a1353d-5152a869d10so1078756e0c.1 for ; Mon, 02 Dec 2024 07:47:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733154443; x=1733759243; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4pxSoz1ajcI3n8y8uPzRsEcpmfNX2HaWKguXvR+KRDQ=; b=YqqnGscmJ2HFm+aU/E53L8QmkLzpSc5bLPhTe0GeXcHOfQwkFy4QjhbwzNlwXr2BRt 6gBnvHToqw7pXxW1/KnR8Su/9TjeFRDj3xbqtNLm8qwBuqt6vduXJMMUmjd1dsQFRN0j 3uF3WGeWGZRksIeAraBkdqr09H6YMW/Y5ho5Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733154443; x=1733759243; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4pxSoz1ajcI3n8y8uPzRsEcpmfNX2HaWKguXvR+KRDQ=; b=f7rPeGy4eD0uxRVyqjplCUU6f7SG58VYXQeRgpThGw9qzaND+N6aD3HedBcanZoGRY uXq+32r81dIsP5SUmNJA0knEAA9MG3mppDEWiqD1kGy2Kt6QWOxm8MtCYjSYs00o7ZcG Q2S3Bc6IsjKYpX3GLqv/paDzW1/fw2YqgRTc7XGVf1JC+EUxh+1J+1222g1ycm7fWdmw jaVsaXGuOKR4O3NasXyXwIxaiTgMcoou210UDEAnKeBt9IAHcatgnrNS8/3/KKqSDti0 cioeaTRgOSkV6Ri9H3vJu3DXW8vdnvRjmrGSDIv2PaP5psuCkCsOw0DuD65UlE8bUIMZ e0vQ== X-Forwarded-Encrypted: i=1; AJvYcCUbFNerZg2OT3w+vO+nXDCAkXdbUzRH+qn4t12iUnCpxnFnKdNxwM9EHdk+29xb9nnkHSieJdWR2rI1vug=@vger.kernel.org X-Gm-Message-State: AOJu0YzjrkPM8N1ZRIWKtafXEFMGaNWjyHvoew9mjg2PpO6OXtXPSVeR qZDHNJhQtqaaCy7U3GjHa0UkuqAngFPT+oj9dPAlJPm+AxlwlUeFqRbgC+QuzQ== X-Gm-Gg: ASbGncvadO42h9ZwI7xJE00E9ZEIleIFFxwqbGFVFURXc/NB0NhoVJXYtn/OQtA/BJP HFUDIINMGm7zEbmBqGbasVQVmb0mibB+LXsFY4YEGnI4wOjQdnaDeylaEsaiRpD+CoUwDGCD5iJ EN5N6+aa9v+Dc3VeG1i2HbdVdcQq0tokET8hyQouNgDkmL7yBbmqAf1kWS/uFdiRqKRgjtsiFXC 4/RG8U5yKrNFvK4rCVYUd2z8z88L3xSy9FAIKT1YxZct8QVsqWiCbIw3aFB2NamOj7ABCnwvCwP hgZS+jYdB3veYGYHi+2xKbXy X-Google-Smtp-Source: AGHT+IGaWcZbV6qtojnjaBkX2eRGECUPG2dd+i3FQicKN4gnW5JGkqWcKAek6j+Ilms9M2b0vFq/qA== X-Received: by 2002:a05:6122:3c4f:b0:515:3bfb:c7b7 with SMTP id 71dfb90a1353d-515568dab17mr30842699e0c.3.1733154443629; Mon, 02 Dec 2024 07:47:23 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5156d0f8ad6sm1159729e0c.49.2024.12.02.07.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 07:47:22 -0800 (PST) From: Ricardo Ribalda Date: Mon, 02 Dec 2024 15:47:16 +0000 Subject: [PATCH 2/3] media: atomisp: Use the actual value of the enum instead of the enum Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241202-fix-llvm9-v1-2-2a50f5acfd0b@chromium.org> References: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> In-Reply-To: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> To: Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Hans de Goede , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.13.0 hrt_isp_css_irq_sw_pin_0 has a different enum type than irq_sw_channel_id_t. Replace it with the actual value of hrt_isp_css_irq_sw_pin_0 to avoid arithmetic operations between different enum types (and make the compiler happy). It is required to build with llvm 9 without these warnings: drivers/staging/media/atomisp/pci/sh_css_hrt.c:68:19: warning: arithmetic b= etween different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp= _css_irq') [-Wenum-enum-conversion] drivers/staging/media/atomisp/pci/sh_css.c:1233:40: warning: arithmetic bet= ween different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp_c= ss_irq') [-Wenum-enum-conversion] drivers/staging/media/atomisp/pci/sh_css.c:1237:40: warning: arithmetic bet= ween different enumeration types ('irq_sw_channel_id_t' and 'enum hrt_isp_c= ss_irq') [-Wenum-enum-conversion] ro Signed-off-by: Ricardo Ribalda Reviewed-by: Andy Shevchenko --- drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_global.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_glob= al.h b/drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_global.h index 2c47e7820bd7..69e68ecd6bc3 100644 --- a/drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_global.h +++ b/drivers/staging/media/atomisp/pci/hive_isp_css_common/irq_global.h @@ -18,7 +18,7 @@ #endif =20 /* The IRQ is not mapped uniformly on its related interfaces */ -#define IRQ_SW_CHANNEL_OFFSET hrt_isp_css_irq_sw_pin_0 +#define IRQ_SW_CHANNEL_OFFSET HIVE_GP_DEV_IRQ_SW_PIN_0_BIT_ID =20 typedef enum { IRQ_SW_CHANNEL0_ID =3D hrt_isp_css_irq_sw_pin_0 - IRQ_SW_CHANNEL_OFFSET, --=20 2.47.0.338.g60cca15819-goog From nobody Sun Feb 8 18:33:14 2026 Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FA59136352 for ; Mon, 2 Dec 2024 15:47:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154448; cv=none; b=IkrZUBuIE+sGwCAlmz+W5/aZuxJjwn2B7l395MYRKxQjSuan4WKLKX9RnyTzOBwn9WWeQYJr6zyXWYiPtEFhp33R1C7LoKGPC0/UfwCapH8SPTYaIJwe0f5e74qMpkMzG4nXEvm2uX98fIchu2lR/dAnyJjeG3PqUvVBrRYKKRc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733154448; c=relaxed/simple; bh=NQt98Z0M5QNA/TsO8gh1YDS9GMK76KynhZ9aabRaUlg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YI4zS8Fc+NHwbT5HB2RoT8eRWpu0mecqlRrWlkRL4XgQQgOk3m9mNYM0gevTKAWXoZPacrJPwIFuKrqI14Feux6f7K8b3hSEQcyJ5EwhEsQQmcdkhfl16vuYjouZnXN4Q/B4sZtHGOT/FddOA7UpbTWMO05Fdx+2Vg+PpsfTdJQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=L7Gmv2zv; arc=none smtp.client-ip=209.85.219.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="L7Gmv2zv" Received: by mail-qv1-f51.google.com with SMTP id 6a1803df08f44-6d3e9e854b8so48399406d6.1 for ; Mon, 02 Dec 2024 07:47:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733154445; x=1733759245; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=l2F2lVT/48t59mZz2zC2oH5sxyMbSECeGcR5hkq1C/k=; b=L7Gmv2zvrBkVAJTmF5xBrM9r0j/frnToHTvotHEjxhCbFDhji/SvvD+8eNb2A5NCoN CgGDzV9PuCJ2uw0j+L3rT3rDawUrPBOJvUKbVNYwStlfEWluY7vYbtFBR+eVJ+5/0JeX JITPQD0mClFdKEgs2jmct8LMMnXjJ9WWBRWcY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733154445; x=1733759245; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l2F2lVT/48t59mZz2zC2oH5sxyMbSECeGcR5hkq1C/k=; b=t0WQtb5rbqEupA1HVwp2z4EV/F701ol8IhcJAPDtQaEaQQuAY8ajBpsJ9uS5+NfLx2 J/oS6nnppf3/yYso6XlyGe7W0r0Qbz3bUvmXLnxiJXxs3x30H3KE6ymUAg87BYiV/klG WCarRTJT4XyH8Inrmg2n3XxQFptZFhoNigB1+ac80EnWChssfZwPsCAke6n8xCsoq4qv krom38UeNUIFR/8D81Yh5xj5z80oqPp0WnWUUx7FwzPkyFG1wfNNxESdHGy0dB8YlsJ2 /Twzknno/YjG7qIPY9rT1cUUTudFuyH2WUUoahqZY1Z9L7I2AplQaLYnv+NewMQS6BiW C/1g== X-Forwarded-Encrypted: i=1; AJvYcCXFD6BKAO4WyFuT2S817UIGXAQxzVOnJUsGQzFrNMSCG0byyE1//IjjwmwtaJaJa4eBQfCTC9MjV7OSn1c=@vger.kernel.org X-Gm-Message-State: AOJu0YyRujwXDueWPlFfdXN/BB6NZZdh4IKTKOQdMfpvvxuFOoSC7QMP O+D/8KZNGpaumBs2oNh+xPGJeTUGkOMutc+BimNBXhIRaiuggx/hRXftWhOyug== X-Gm-Gg: ASbGncthrCaMExsDSS0UB5I5VcuA1aY6ekx/f8U3v1euTd6cbTIltSx5BZKhB/ZLUWs jlROTp/2XzEpFx7QUfGY1SFAP3Sq95eG9iNvKurzV7jw0QSPW8HJM1cCI9GQQtxgWWOzvHwTeUZ Pa2gx7+DSrTekYQLpr/s2R7UQP1jHHFBhxgXPq7qDD5L7yzNcc4C4A9H7H7UpI0IOqnsLvh+L87 E5rw1tbVkMwe+PP9tHtD1vmcdFfnKaak/1mfMERXmTYbA9wtEjNSUf+I3bdFCPK1m/p2WMckA5z rVnKS81Ve4gYD5Rl028OYY3s X-Google-Smtp-Source: AGHT+IGi/PMi7HKxN0drYRNoeMrQehkEDZgCgHDgtdOzyjj8HEWJDMxx4Dj3/iwSYHFuTdJy9nQktg== X-Received: by 2002:a05:6214:626:b0:6d8:a1b4:b58f with SMTP id 6a1803df08f44-6d8a1b4bb2amr99633466d6.11.1733154445272; Mon, 02 Dec 2024 07:47:25 -0800 (PST) Received: from denia.c.googlers.com (5.236.236.35.bc.googleusercontent.com. [35.236.236.5]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5156d0f8ad6sm1159729e0c.49.2024.12.02.07.47.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 07:47:24 -0800 (PST) From: Ricardo Ribalda Date: Mon, 02 Dec 2024 15:47:17 +0000 Subject: [PATCH 3/3] media: mediatek: vcodec: Workaround a compiler warning Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241202-fix-llvm9-v1-3-2a50f5acfd0b@chromium.org> References: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> In-Reply-To: <20241202-fix-llvm9-v1-0-2a50f5acfd0b@chromium.org> To: Mauro Carvalho Chehab , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Hans de Goede , Sakari Ailus , Andy Shevchenko , Greg Kroah-Hartman , Tiffany Lin , Andrew-CT Chen , Yunfei Dong , Matthias Brugger , AngeloGioacchino Del Regno Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Ricardo Ribalda X-Mailer: b4 0.13.0 llvm identifies that the SCP_IPI_VENC_H264 and IPI_VENC_H264 are from the same enum type, but their are part of the same ternary operator. vpu_inst.id is of type int, so we can just rewrite a bit the code and avoid the following llvm9 warning: drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c:597:29: = warning: conditional expression between different enumeration types ('enum = scp_ipi_id' and 'enum ipi_id') [-Wenum-compare-conditional] Signed-off-by: Ricardo Ribalda Reviewed-by: Nathan Chancellor --- drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c | 6 +++= +-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_= if.c b/drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c index f8145998fcaf..4786062e879a 100644 --- a/drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c +++ b/drivers/media/platform/mediatek/vcodec/encoder/venc/venc_h264_if.c @@ -584,7 +584,6 @@ static void h264_encode_filler(struct venc_h264_inst *i= nst, void *buf, =20 static int h264_enc_init(struct mtk_vcodec_enc_ctx *ctx) { - const bool is_ext =3D MTK_ENC_CTX_IS_EXT(ctx); int ret =3D 0; struct venc_h264_inst *inst; =20 @@ -594,7 +593,10 @@ static int h264_enc_init(struct mtk_vcodec_enc_ctx *ct= x) =20 inst->ctx =3D ctx; inst->vpu_inst.ctx =3D ctx; - inst->vpu_inst.id =3D is_ext ? SCP_IPI_VENC_H264 : IPI_VENC_H264; + if (MTK_ENC_CTX_IS_EXT(ctx)) + inst->vpu_inst.id =3D SCP_IPI_VENC_H264; + else + inst->vpu_inst.id =3D IPI_VENC_H264; inst->hw_base =3D mtk_vcodec_get_reg_addr(inst->ctx->dev->reg_base, VENC_= SYS); =20 ret =3D vpu_enc_init(&inst->vpu_inst); --=20 2.47.0.338.g60cca15819-goog