From nobody Mon Feb 9 21:37:51 2026 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6378E1FBEA9 for ; Mon, 2 Dec 2024 10:07:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733134024; cv=none; b=MwZpVeTwqYauAiisFnBnmIqNzz6KVEPTBJhq77fmx1pdlHPsr3VPa9KXlkDDOHv+AhDW+NL7xU8ksOxq/7ZVwed3NKvH+S9KOjZuBVOrD7tde65u3OubySYFU/qRdfwUEzN3YJxEeOD506d4LKqTH0++XGEG1ELESpujKz4GTdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733134024; c=relaxed/simple; bh=qCdrcWenCjLX1kh11wr6m990Tm7yf9+jkniTxA0o93U=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=aV2srk4xn305B7Di++VhBga6X6cHRWJH5mCci7W3KL3rlYloV/TITDv0nxPEHeUGyIgSGWzdlyeBS2BEbwdBM8+OxHD8ZQ+Jd0VNxukYzMoXeI4BXOnXKs2n+LnWJD1T7Kx0kgvSuKJqGgtP2VXm2xpNKZtyZSq8FxeG5PjAIB0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ZsPX+TZj; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ZsPX+TZj" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-53dd59a2bc1so4190270e87.2 for ; Mon, 02 Dec 2024 02:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1733134019; x=1733738819; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k5kww5Ac18jsflCbqCHO2jjvwRYrAKmTyY/3BmZtSo4=; b=ZsPX+TZjoKGdSSHgeF1t4NBSlrtUxxeWvzRYJpFmCh0gh7lRM/lOCytzmolK1B/q7N KrkL4u+Hvlk+NvDI4pe9b97bA9xFCcdt4R3NiUulq0pxgQNW/leUW851l9q99Dy12Bu8 3TH2YsIg30vgtMEqgy00EsvnjP0/LtybGNny+QNOBirIuiy9lgbdM9mJltjDwIjCmISz 86SUdk4p1TA4ezQWRZjsMra9zR4ZgjhEntfqxBteoK3r6Lk8nOaY+Jv52cb6gk24d/b9 ZdmU8qInx+P1CO6kccEQEN5TniFgSGJngm552u6NQjhYBRS4YJEltOU9CDWACtifcq+k EK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733134019; x=1733738819; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k5kww5Ac18jsflCbqCHO2jjvwRYrAKmTyY/3BmZtSo4=; b=pXsflQ8eWJN4HzETbWd4r0EQLeNr+Pa9OCCPYvAtfwhb56c0FV+ItcXRWb9UXNvqAT oUdTb2vLadPyATH/oWlHtUcgz/rs6dQUqkuOnnccuFuW49M7F48UCTtI1p4ggJGFDMOJ UB4VjNw29nmI2LwMqAj4rStt5q38GmYnWIA8hUMbnKGJvCzJW4WFeBcJPD4XyJHb0v6c r6aXJBOWADQY+awOT2VBVBPuWrNufq2JuLw/Z8pBfk7z9WK/zK9IFcB5JGOGbv7Halpb w5BEMwAK3vRBH29cA0PuXzjZBHgo1Jrpye8deLcr/Smk/UASMaSCDmvh61Hjd+zlgqJq vcgQ== X-Forwarded-Encrypted: i=1; AJvYcCWuMZKFQTfZFTnH1sSJl5iuvdaC3nWft+kfWz2GRkzBVTDhMxC9p8DFl0Ptj9laT8EXCMnU5CdjvioaPnc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/Y2P4qS0AVAbXi+HU7PcTSkiDs+ca2XN8FRyHCAcGVeCYslNL zPCs87yA5j7gdl/KRIokM4wcjs/TENXRQmdn28/047l82UqkQrxxgWdOAItOpqQ= X-Gm-Gg: ASbGnctKW/AYnr8/xr3T25yPv3sva5du7LOezhF0Ikgti4drUU9L/Ar+RZkkVopeQr2 aVk1UptMHTVkKZbKlz8J99/tC2UuJpmOFJKoYlDM5o0SrsbqVq7u7VuptR0fKhUBs2g7A3QuyrC x0ZNN+b/+CxsaUGr6jXSNxlk0fGIQ1MbWAlebbMcY2RPrEvM9+slzu0y50VfNlGNTSqzvlFZ4c4 vcZAYFO3PQTNLf3qFFLvjktDz8SUsT0r5BTWN0lPJdwTtTnxG1sgd5yag== X-Google-Smtp-Source: AGHT+IEGR8gZyPTfpG2L/6CVMio3zKJcxHs2HkhnlOE23O930VB22RHLjC/nmvfpmAAvcLW/N/gESg== X-Received: by 2002:a05:6512:3c99:b0:536:56d8:24b4 with SMTP id 2adb3069b0e04-53df00a923fmr12418476e87.5.1733134019375; Mon, 02 Dec 2024 02:06:59 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53df646f191sm1418314e87.136.2024.12.02.02.06.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Dec 2024 02:06:58 -0800 (PST) From: Dmitry Baryshkov Date: Mon, 02 Dec 2024 12:06:39 +0200 Subject: [PATCH v2 09/14] drm/msm/dp: use msm_dp_utils_pack_sdp_header() for audio packets Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241202-fd-dp-audio-fixup-v2-9-d9187ea96dad@linaro.org> References: <20241202-fd-dp-audio-fixup-v2-0-d9187ea96dad@linaro.org> In-Reply-To: <20241202-fd-dp-audio-fixup-v2-0-d9187ea96dad@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Paloma Arellano Cc: Douglas Anderson , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=11581; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=qCdrcWenCjLX1kh11wr6m990Tm7yf9+jkniTxA0o93U=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnTYatjPZIlEtHeiLjdPg+SLKZhYPBj1ZKB7oAL O7QRAWSid+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ02GrQAKCRCLPIo+Aiko 1ULWB/9PubzvQJphG+kakBPh3oYR/HdA0noYMXoy1t5czlPwj9NLBBjpK95cE6BB82g/JmJ1p+t 4Oec8cSXdSrK4x63tl5hmtmSm7qobWlBNIC6gYOCVQQd7AM1cvsA5PETFzKdV+ZE0yG2sODoM1x yUIC/aWqN3YYj+ea7Tn23A18MikU6AofNAq85K7Zdmgb9YdxhATpVm81I7m0XqyYydjIFlZAx89 Kd9XwNZ+akyDfjojJ1Qb+W1ZIDcl+thpFc52keWaX6/z4QrGJy1BXYddqPcGrhZIyc9OZeEciHA eF3mQgeBb1RuNBuZ4Dg91suya0G5fCdZZTUCNz4O6Aa8cidF X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A Use msm_dp_utils_pack_sdp_header() and call msm_dp_write_link() directly to program audio packet data. Use 0 as Packet ID, as it was not programmed earlier. Signed-off-by: Dmitry Baryshkov Reviewed-by: Stephen Boyd --- drivers/gpu/drm/msm/dp/dp_audio.c | 288 +++++++++-------------------------= ---- 1 file changed, 66 insertions(+), 222 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c b/drivers/gpu/drm/msm/dp/dp_= audio.c index 5cbb11986460d1e4ed1890bdf66d0913e013083c..1aa52d5cc08684a49102e45ed6e= 40ac2b13497c7 100644 --- a/drivers/gpu/drm/msm/dp/dp_audio.c +++ b/drivers/gpu/drm/msm/dp/dp_audio.c @@ -14,6 +14,7 @@ #include "dp_catalog.h" #include "dp_audio.h" #include "dp_panel.h" +#include "dp_reg.h" #include "dp_display.h" #include "dp_utils.h" =20 @@ -28,251 +29,94 @@ struct msm_dp_audio_private { struct msm_dp_audio msm_dp_audio; }; =20 -static u32 msm_dp_audio_get_header(struct msm_dp_catalog *catalog, - enum msm_dp_catalog_audio_sdp_type sdp, - enum msm_dp_catalog_audio_header_type header) -{ - return msm_dp_catalog_audio_get_header(catalog, sdp, header); -} - -static void msm_dp_audio_set_header(struct msm_dp_catalog *catalog, - u32 data, - enum msm_dp_catalog_audio_sdp_type sdp, - enum msm_dp_catalog_audio_header_type header) -{ - msm_dp_catalog_audio_set_header(catalog, sdp, header, data); -} - static void msm_dp_audio_stream_sdp(struct msm_dp_audio_private *audio) { struct msm_dp_catalog *catalog =3D audio->catalog; - u32 value, new_value; - u8 parity_byte; - - /* Config header and parity byte 1 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_1); - - new_value =3D 0x02; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_1_BIT) - | (parity_byte << PARITY_BYTE_1_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 1: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_1); - - /* Config header and parity byte 2 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_2); - new_value =3D value; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_2_BIT) - | (parity_byte << PARITY_BYTE_2_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 2: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_2); - - /* Config header and parity byte 3 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_3); - - new_value =3D audio->channels - 1; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_3_BIT) - | (parity_byte << PARITY_BYTE_3_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 3: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_STREAM, DP_AUDIO_SDP_HEADER_3); + struct dp_sdp_header sdp_hdr =3D { + .HB0 =3D 0x00, + .HB1 =3D 0x02, + .HB2 =3D 0x00, + .HB3 =3D audio->channels - 1, + }; + u32 header[2]; + + msm_dp_utils_pack_sdp_header(&sdp_hdr, header); + + msm_dp_write_link(catalog, MMSS_DP_AUDIO_STREAM_0, header[0]); + msm_dp_write_link(catalog, MMSS_DP_AUDIO_STREAM_1, header[1]); } =20 static void msm_dp_audio_timestamp_sdp(struct msm_dp_audio_private *audio) { struct msm_dp_catalog *catalog =3D audio->catalog; - u32 value, new_value; - u8 parity_byte; - - /* Config header and parity byte 1 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_1); - - new_value =3D 0x1; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_1_BIT) - | (parity_byte << PARITY_BYTE_1_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 1: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_1); - - /* Config header and parity byte 2 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_2); - - new_value =3D 0x17; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_2_BIT) - | (parity_byte << PARITY_BYTE_2_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 2: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_2); - - /* Config header and parity byte 3 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_3); - - new_value =3D (0x0 | (0x11 << 2)); - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_3_BIT) - | (parity_byte << PARITY_BYTE_3_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 3: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_TIMESTAMP, DP_AUDIO_SDP_HEADER_3); + struct dp_sdp_header sdp_hdr =3D { + .HB0 =3D 0x00, + .HB1 =3D 0x01, + .HB2 =3D 0x17, + .HB3 =3D 0x0 | (0x11 << 2), + }; + u32 header[2]; + + msm_dp_utils_pack_sdp_header(&sdp_hdr, header); + + msm_dp_write_link(catalog, MMSS_DP_AUDIO_TIMESTAMP_0, header[0]); + msm_dp_write_link(catalog, MMSS_DP_AUDIO_TIMESTAMP_1, header[1]); } =20 static void msm_dp_audio_infoframe_sdp(struct msm_dp_audio_private *audio) { struct msm_dp_catalog *catalog =3D audio->catalog; - u32 value, new_value; - u8 parity_byte; - - /* Config header and parity byte 1 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_1); - - new_value =3D 0x84; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_1_BIT) - | (parity_byte << PARITY_BYTE_1_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 1: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_1); - - /* Config header and parity byte 2 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_2); - - new_value =3D 0x1b; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_2_BIT) - | (parity_byte << PARITY_BYTE_2_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 2: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_2); - - /* Config header and parity byte 3 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_3); - - new_value =3D (0x0 | (0x11 << 2)); - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_3_BIT) - | (parity_byte << PARITY_BYTE_3_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 3: value =3D 0x%x, parity_byte =3D 0x%x\n", - new_value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_INFOFRAME, DP_AUDIO_SDP_HEADER_3); + struct dp_sdp_header sdp_hdr =3D { + .HB0 =3D 0x00, + .HB1 =3D 0x84, + .HB2 =3D 0x1b, + .HB3 =3D 0x0 | (0x11 << 2), + }; + u32 header[2]; + + msm_dp_utils_pack_sdp_header(&sdp_hdr, header); + + msm_dp_write_link(catalog, MMSS_DP_AUDIO_INFOFRAME_0, header[0]); + msm_dp_write_link(catalog, MMSS_DP_AUDIO_INFOFRAME_1, header[1]); } =20 static void msm_dp_audio_copy_management_sdp(struct msm_dp_audio_private *= audio) { struct msm_dp_catalog *catalog =3D audio->catalog; - u32 value, new_value; - u8 parity_byte; - - /* Config header and parity byte 1 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_1); - - new_value =3D 0x05; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_1_BIT) - | (parity_byte << PARITY_BYTE_1_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 1: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_1); - - /* Config header and parity byte 2 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_2); - - new_value =3D 0x0F; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_2_BIT) - | (parity_byte << PARITY_BYTE_2_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 2: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_2); - - /* Config header and parity byte 3 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_3); - - new_value =3D 0x0; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_3_BIT) - | (parity_byte << PARITY_BYTE_3_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 3: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_COPYMANAGEMENT, DP_AUDIO_SDP_HEADER_3); + struct dp_sdp_header sdp_hdr =3D { + .HB0 =3D 0x00, + .HB1 =3D 0x05, + .HB2 =3D 0x0f, + .HB3 =3D 0x00, + }; + u32 header[2]; + + msm_dp_utils_pack_sdp_header(&sdp_hdr, header); + + msm_dp_write_link(catalog, MMSS_DP_AUDIO_COPYMANAGEMENT_0, header[0]); + msm_dp_write_link(catalog, MMSS_DP_AUDIO_COPYMANAGEMENT_1, header[1]); } =20 static void msm_dp_audio_isrc_sdp(struct msm_dp_audio_private *audio) { struct msm_dp_catalog *catalog =3D audio->catalog; - u32 value, new_value; - u8 parity_byte; - - /* Config header and parity byte 1 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_ISRC, DP_AUDIO_SDP_HEADER_1); - - new_value =3D 0x06; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_1_BIT) - | (parity_byte << PARITY_BYTE_1_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 1: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_ISRC, DP_AUDIO_SDP_HEADER_1); - - /* Config header and parity byte 2 */ - value =3D msm_dp_audio_get_header(catalog, - DP_AUDIO_SDP_ISRC, DP_AUDIO_SDP_HEADER_2); - - new_value =3D 0x0F; - parity_byte =3D msm_dp_utils_calculate_parity(new_value); - value |=3D ((new_value << HEADER_BYTE_2_BIT) - | (parity_byte << PARITY_BYTE_2_BIT)); - drm_dbg_dp(audio->drm_dev, - "Header Byte 2: value =3D 0x%x, parity_byte =3D 0x%x\n", - value, parity_byte); - msm_dp_audio_set_header(catalog, value, - DP_AUDIO_SDP_ISRC, DP_AUDIO_SDP_HEADER_2); + struct dp_sdp_header sdp_hdr =3D { + .HB0 =3D 0x00, + .HB1 =3D 0x06, + .HB2 =3D 0x0f, + .HB3 =3D 0x00, + }; + u32 header[2]; + u32 reg; + + /* XXX: is it necessary to preserve this field? */ + reg =3D msm_dp_read_link(catalog, MMSS_DP_AUDIO_ISRC_1); + sdp_hdr.HB3 =3D FIELD_GET(HEADER_3_MASK, reg); + + msm_dp_utils_pack_sdp_header(&sdp_hdr, header); + + msm_dp_write_link(catalog, MMSS_DP_AUDIO_ISRC_0, header[0]); + msm_dp_write_link(catalog, MMSS_DP_AUDIO_ISRC_1, header[1]); } =20 static void msm_dp_audio_setup_sdp(struct msm_dp_audio_private *audio) --=20 2.39.5