From nobody Thu Dec 26 15:27:04 2024 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3949E3224 for ; Sat, 30 Nov 2024 02:35:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732934159; cv=none; b=e2eRd7BiZLsSgPEmIt8KLIK0yZTkmxaXCEQ93ocAf410lO9NI82dqyXznHjYUcu+EhIjZ4sYvnv9M6pfohPwpXYh3nIJnCI6/5zEt3W/l9iGu6ZmhXSxG28Oq4TJCvkjafPnBOf07LSK254RSU27Khc/+xIJEtFcIMv/kKDSMp0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732934159; c=relaxed/simple; bh=bzHt9T+FI2Nq3+fjIsmf95OgZrFD4R707PwXg8g8Jhk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LBjab62xfsuse/3MBG386+CHcdIUckOXAipiC6ub8eqrxiVkiX6AnAnfXGB8bYRZ/7aQpifKU5nP51UH8HiBo8+16c9rzo1qabwMx5gqE69Z34lxkzqRBBvYTsK3sG0lsL8HnNGaRhXpd2ytLhWU6qTOsxZJwu8eu9Xpg5mBUrI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Kz4QcoHy; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Kz4QcoHy" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=CENE67omF4txQDfD5xaTRSsaRoJ1PEywoIzFFsuu9cQ=; b=Kz4QcoHygPxmbQxjJMMyo0A+KU o1kfwJfpSWseWhXkC36WpvMxfXiV3gMWxmQwUJcYxOBM3GGTSmgSCtT4UUEi/KeBn2/qq8HzwFoXN 9olro+cCrhEyiWmkb9KypYQ4rwqYc5soEPLa1MasMi//PA2FRrfTawlGVwcdTW8GRv95G25rf2vCc TD7iFMo+QaM8G/2/fOB9ZgoeVQ/7WyP4nAq8tBoqdxCo11actOT+RSXbKxrYI1iqFZsRMuES3nlfv iwZecaZnGxCzWpdIDSDr7aB6d1E1nfOFLLpA1SyowwPVTh8468+q4jKGG3OLCtF5l9IFbknEo64iE n7Un0FKg==; Received: from [50.53.2.24] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tHDKv-00000001Jkq-0lxW; Sat, 30 Nov 2024 02:35:57 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Johannes Berg , Greg Kroah-Hartman , "Rafael J. Wysocki" , Aviya Erenfeld , Mukesh Ojha Subject: [PATCH] devcoredump: cleanup some comments Date: Fri, 29 Nov 2024 18:35:54 -0800 Message-ID: <20241130023554.538820-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Correct a spello, remove an extra space between words, and fix one kernel-doc warning: drivers/base/devcoredump.c:292: warning: No description found for return va= lue of 'devcd_read_from_sgtable' Fixes: 522566376a3f ("devcoredump: add scatterlist support") Fixes: 01daccf74832 ("devcoredump : Serialize devcd_del work") Signed-off-by: Randy Dunlap Cc: Johannes Berg Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Aviya Erenfeld Cc: Mukesh Ojha --- I prefer "in parallel" but the internet says that "parallelly" is a word. drivers/base/devcoredump.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- linux-next-20241125.orig/drivers/base/devcoredump.c +++ linux-next-20241125/drivers/base/devcoredump.c @@ -186,9 +186,9 @@ static ssize_t disabled_show(const struc * mutex_lock(&devcd->mutex); * * - * In the above diagram, It looks like disabled_store() would be racing wi= th parallely + * In the above diagram, it looks like disabled_store() would be racing wi= th parallelly * running devcd_del() and result in memory abort while acquiring devcd->m= utex which - * is called after kfree of devcd memory after dropping its last referenc= e with + * is called after kfree of devcd memory after dropping its last reference= with * put_device(). However, this will not happens as fn(dev, data) runs * with its own reference to device via klist_node so it is not its last r= eference. * so, above situation would not occur. @@ -285,6 +285,8 @@ static void devcd_free_sgtable(void *dat * @offset: start copy from @offset@ bytes from the head of the data * in the given scatterlist * @data_len: the length of the data in the sg_table + * + * Returns: the number of bytes copied */ static ssize_t devcd_read_from_sgtable(char *buffer, loff_t offset, size_t buf_len, void *data,