From nobody Thu Dec 26 20:25:20 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E17155391 for ; Fri, 29 Nov 2024 20:09:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732910995; cv=none; b=sVK8hqF/BlAiXfsJhqqjd/Bmgdb1LHzHEo5hPtBMhBBpKAsw78/OxhzOJxM3BfQ9ZrO7Ppz74ccSCGiByh7rWiVy9BNwsieOadoJHm/xAF30cEBR1Dd9rt7lN+Hl72gAkcbI0c7BAEKZeJVWuCJhgNc45G+GXTGSE4LwOEk485Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732910995; c=relaxed/simple; bh=oXcED2hhWMJEfRkbbOWIsL3bV2xVmkDz/B4XV5Rb6oo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=LvsU3yOXT0c/PaVxCVAHYV9y8tZw8yNHliT0Aw2fPagrAK1O0hNUsZ82wbKmt4PGJh0fbmT1SxI893ohu5hzvqy0vQMvj9AhHf9YKBg9StHoU+gZlPr0ej8vseh1UEtZz9fVzPv5d+Z0qbslos3543ItXDrB3JI5Kd+UYEnr9Vw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H5qs/CTy; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H5qs/CTy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732910993; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=J+UzbtdXdCwllivvhEkUKFJJlCztT5JWkviudLOf7nk=; b=H5qs/CTyspAxBxwUOiGstk2dO90rZA4dXDKa4eE0qZKgM4diXIfTc1QvBAfhLgHYXSxsXZ HvjRh0T6itpzqaPh3AWDlCCZsHSkDr7n9WyTSQKqSa6ViLQhViXTsggmP0l1NpCnq4XyWk iipiDgSQM4UGtbuoT2agRgqE0dyj6jw= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-Hc1Y9N-kOsy3FFSFe4yrgA-1; Fri, 29 Nov 2024 15:09:47 -0500 X-MC-Unique: Hc1Y9N-kOsy3FFSFe4yrgA-1 X-Mimecast-MFC-AGG-ID: Hc1Y9N-kOsy3FFSFe4yrgA Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5009C1956088; Fri, 29 Nov 2024 20:09:45 +0000 (UTC) Received: from lszubowi.redhat.com (unknown [10.22.88.155]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 96A8A1955D47; Fri, 29 Nov 2024 20:09:42 +0000 (UTC) From: Lenny Szubowicz To: pavan.chebbi@broadcom.com, mchan@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, george.shuklin@gmail.com, andrea.fois@eventsense.it, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] tg3: Disable tg3 PCIe AER on system reboot Date: Fri, 29 Nov 2024 15:09:41 -0500 Message-ID: <20241129200941.50217-1-lszubowi@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Content-Type: text/plain; charset="utf-8" Disable PCIe AER on the tg3 device on system reboot on a limited list of Dell PowerEdge systems. This prevents a fatal PCIe AER event on the tg3 device during the ACPI method _PTS (prepare to sleep) S5 on those systems. The _PTS is invoked by acpi_enter_sleep_state_prep() as part of the kernel's reboot sequence as a result of commit 38f34dba806a ("PM: ACPI: reboot: Reinstate S5 for reboot"). There was an earlier fix for this problem by commit 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER"). But it was discovered that this earlier fix caused a reboot hang when some Dell PowerEdge servers were booted via ipxe. So the earlier fix was essentially reverted by commit 9fc3bc764334 ("tg3: power down device only on SYSTEM_POWER_OFF") and re-exposed the tg3 PCIe AER on reboot. This fix is not an ideal solution because the root cause of the AER is in system firmware. Instead, it's a targeted work-around in the tg3 driver. Note also that the PCIe AER must be disabled on the tg3 device even if the system is configured to use "firmware first" error handling. Fixes: 9fc3bc764334 ("tg3: power down device only on SYSTEM_POWER_OFF") Signed-off-by: Lenny Szubowicz --- drivers/net/ethernet/broadcom/tg3.c | 50 +++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/bro= adcom/tg3.c index 378815917741..8672e3099d82 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -55,6 +55,7 @@ #include #include #include +#include =20 #include #include @@ -18151,6 +18152,46 @@ static int tg3_resume(struct device *device) =20 static SIMPLE_DEV_PM_OPS(tg3_pm_ops, tg3_suspend, tg3_resume); =20 +static const struct dmi_system_id tg3_restart_aer_quirk_table[] =3D { + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R440"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R540"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R640"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R650"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R740"), + }, + }, + { + .matches =3D { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "PowerEdge R750"), + }, + }, + {} +}; + static void tg3_shutdown(struct pci_dev *pdev) { struct net_device *dev =3D pci_get_drvdata(pdev); @@ -18167,6 +18208,15 @@ static void tg3_shutdown(struct pci_dev *pdev) =20 if (system_state =3D=3D SYSTEM_POWER_OFF) tg3_power_down(tp); + else if (system_state =3D=3D SYSTEM_RESTART && + dmi_first_match(tg3_restart_aer_quirk_table) && + pdev->current_state <=3D PCI_D3hot) { + pcie_capability_clear_word(pdev, PCI_EXP_DEVCTL, + PCI_EXP_DEVCTL_CERE | + PCI_EXP_DEVCTL_NFERE | + PCI_EXP_DEVCTL_FERE | + PCI_EXP_DEVCTL_URRE); + } =20 rtnl_unlock(); =20 --=20 2.45.2