From nobody Sat Feb 7 08:07:22 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 296F91C3035 for ; Thu, 28 Nov 2024 21:13:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732828384; cv=pass; b=nSkLZJMHfhccNLJ284FnrMWkvCB6dLqAhsygo7zfEcwewZ+g4dKysBo7nccI6jTaSPMemVWj+HUDfBRSkahFDLW6FCCTTHFa/7YrLFy9pNtg1iPaoFgHkaaWGiB8yPv/jQUIem2UNke4itnLnUHL2EZ/D6T5u2OBIiqiGv3IhEE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732828384; c=relaxed/simple; bh=r51hqawVAvNZ5vG8936yL+aGEWWOgtFLPINQposKCmI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qPHOpQAaXhW9vYKGHJW6WAYEVAH0q/ppS6xW/+4eUveag/8VMGkOqinUNGT5L9xlk1GqZQ8m9f2wm+8zdXTwfZQ5SEHk7jv5dr0yMyOYrrNxcZA47M2URgepgGN/H3C7Zis3EpmC6XNOflDAB/Itq4kl6ZCfuTNma7Z+1XMkM68= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=AaG/bbno; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="AaG/bbno" ARC-Seal: i=1; a=rsa-sha256; t=1732828362; cv=none; d=zohomail.com; s=zohoarc; b=UBXITQU65g5yMW5WrvLWYjJdwBnXfy1k89KraOMGAAfn7hn3/06ofEZa/MPSw/Q/3k/pAQdmAQABoWdCXJ68KhNM6KrdIQm73qAkP9dkJgaZPhUZlceqnqwlEJuXJu3jFMqw4Du+Iqil5aLc+Nit61HPIx1m1uguX2jqj0yql0Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1732828362; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=R39w5zBfj7DJRcNWotPOClY5HZfoNtPYpt/6Md6nCH0=; b=S+Bo7jeNYPh6Dzq2ND382HRlh1G102LCMzUrCdPXlDuAHaP3CFIKst5ze6yevoyVJkZtMOH2cBjfY7TOrOA7UaPh5G+hppq6BMChmlPdEyjj6oveoWEgfCyRPAVeiStbqfGcNK0MKG/fOh7lXlsRwxykU5+tJLG46n7wFnG92VM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1732828362; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=R39w5zBfj7DJRcNWotPOClY5HZfoNtPYpt/6Md6nCH0=; b=AaG/bbno0AhoQDzzXA3kpe5GSFtr/z93KwKgy46ut0HovS/tCkYKMIaDPgPuDCJL G/9fA7J+hva/D3PF0tQScYgKh482js0q0jhOWJfczoUhZ0MyNlwPDE+J/HLU+CWAf+u Y2tLZ9BHsHUbWBbjwTm/mj7pARrxm1UZPVulu6aQ= Received: by mx.zohomail.com with SMTPS id 1732828362107162.7255296598679; Thu, 28 Nov 2024 13:12:42 -0800 (PST) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Philipp Zabel Cc: kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/8] drm/panfrost: Handle inexistent GPU during probe Date: Thu, 28 Nov 2024 21:06:17 +0000 Message-ID: <20241128211223.1805830-3-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241128211223.1805830-1-adrian.larumbe@collabora.com> References: <20241128211223.1805830-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Just in case we're dealing with a yet not recognised device. Signed-off-by: Adri=C3=A1n Larumbe Reviewed-by: Steven Price --- drivers/gpu/drm/panfrost/panfrost_gpu.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_gpu.c b/drivers/gpu/drm/panf= rost/panfrost_gpu.c index 69425104ca97..da55dc7c0552 100644 --- a/drivers/gpu/drm/panfrost/panfrost_gpu.c +++ b/drivers/gpu/drm/panfrost/panfrost_gpu.c @@ -236,9 +236,10 @@ static const struct panfrost_model gpu_models[] =3D { */ GPU_MODEL(g57, 0x9003, GPU_REV(g57, 0, 0)), + {0}, }; =20 -static void panfrost_gpu_init_features(struct panfrost_device *pfdev) +static int panfrost_gpu_init_features(struct panfrost_device *pfdev) { u32 gpu_id, num_js, major, minor, status, rev; const char *name =3D "unknown"; @@ -323,6 +324,12 @@ static void panfrost_gpu_init_features(struct panfrost= _device *pfdev) break; } =20 + if (!model->name) { + dev_err(pfdev->base.dev, "GPU model not found: mali-%s id rev %#x %#x\n", + name, gpu_id, rev); + return -ENODEV; + } + bitmap_from_u64(pfdev->features.hw_features, hw_feat); bitmap_from_u64(pfdev->features.hw_issues, hw_issues); =20 @@ -343,6 +350,8 @@ static void panfrost_gpu_init_features(struct panfrost_= device *pfdev) =20 dev_info(pfdev->base.dev, "shader_present=3D0x%0llx l2_present=3D0x%0llx", pfdev->features.shader_present, pfdev->features.l2_present); + + return 0; } =20 void panfrost_cycle_counter_get(struct panfrost_device *pfdev) @@ -485,7 +494,9 @@ int panfrost_gpu_init(struct panfrost_device *pfdev) if (err) return err; =20 - panfrost_gpu_init_features(pfdev); + err =3D panfrost_gpu_init_features(pfdev); + if (err) + return err; =20 err =3D dma_set_mask_and_coherent(pfdev->base.dev, DMA_BIT_MASK(FIELD_GET(0xff00, --=20 2.47.0