From nobody Mon Feb 9 22:20:49 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AF071BD9F0 for ; Thu, 28 Nov 2024 16:21:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810915; cv=none; b=eSnHcv6h8x+IxkrwnLlpdKIHutCbmbv9uFLk1KK6A+fLfE2aAwqm0dY2EjYnRR2+l36BOKHGgd0zyueRBdCMkzeRoELwrxk349qOdmiwsK6rIywBI6Ar+JcdNB6Xiy1EQvYFSy9iP1b4w9rh8koYmCT+aOq4xMca1rAq1/ihHRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810915; c=relaxed/simple; bh=QBlvh42wEu8WJ3ZX0DLU3rSfBDhhQkJ+tEIxBMvq6eQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hn1h2czP6VIxruPyp17nUYCcB95M+Wvtz9URJm1fVia9Ng5dhObz1x6fisYQXrMdTqoutC4/R/V8d0eGdCLy3u0GG4Gtl5VzmV/msVY0thOPFbppeJcxg6Vym8TSX3byGEc2HxHN37QIcSH53QH/X3/hdGgvQq3G7XRbvGoCsEw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=cMZ/3rWr; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cMZ/3rWr" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-434a14d6bf4so8942975e9.1 for ; Thu, 28 Nov 2024 08:21:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732810912; x=1733415712; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=a3cXlSbMt2J53GNfeBwFHks7qn8zy+yq2dkUxzhw6rc=; b=cMZ/3rWrM5hzwXPdRJPk5DvjgPFztXNKX90/Ls51MeZrztLulwgFdWVZGk9DuBv/fo JXlvuoFpb/s/tMa50XRPhviOudUrzutH7LFkuQWc/onYAHklo5AFdnxl6v4m5fmcyLt7 QaR7Vq3UU6M106K77PtcR+FhGUmEw/7oRGmjjSrravCGt6yaldkZIrP0GeTbZeFafo/p BqKpGiz8baxnfmGuKJ4PEKZlx/hGjibRkH9La0G9SfOwAEEd45lQAFXiHiT0EBSdVoB8 GChnUj7GVu6fZg2241OVD6oVvkWGMn4ojV6CVncwsqWZ8neDowXNOC48VjrWOtMKv8Xh ZW9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732810912; x=1733415712; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a3cXlSbMt2J53GNfeBwFHks7qn8zy+yq2dkUxzhw6rc=; b=sqw9fblVtEtWOa/7u68z2P1aXkV9f2AG4ukawuF11DAzNbT3qy4fRxnWdk13TiKMRn IaiTkWBC4FeYa7ZYqRhDuIwqJ7BFSz56taN8ACy5mSEaGcqOjhW+2X5c6Xvqz8y2RTkX 8hiNfAJn8Q0bqYsKRYJ3V3Ak0qYcxM1HO4Y1noxTicjR5yX05J28fdqN5yiGBSgJJDWm 77JNi9A5BD4zQybm1c+PNmzBNwe44per/vANHeFzDhKksiaLWQr/SRt4nQWZzEzbYGwi a4O4nQ/L8dTZUge8eORZCLJd9i75fWLm4dRbQXGNN5Ftmk9pxhor/aTViHO8RFJLCPBI 5UKQ== X-Forwarded-Encrypted: i=1; AJvYcCVNqUP3bH0rAuaHOAUwRkVvvJwWcGR5olq0zAFbm9JxFVEmo6Dsyd58Qcu/Ych/LXBBXkdzfxgmwbFmm+U=@vger.kernel.org X-Gm-Message-State: AOJu0YzhGksOIaBgNc5R+exmhNBoowrQyRX8sEOlWUdISupAZN5mafPh OisQfM7nb7VK1vLs1ZEjqDCLtkAOdxQzk2F6CTsK7R8FwR9Yp9qIdL488DxbWuo= X-Gm-Gg: ASbGncv65a8d9uo+6Dd5/bVbvSN+ElHrwrl0WlrUJltl6+jrccsWcXb3PKU2IaSYRdd o20CPr3KPzjSTKAywFBtOR5+fl/u6gj9ZDZF6mIoHcqmyM05Faawr9xPnl4FPJ9BWrzlJjDl0Wq Lps1jWZhh2q8FvU7kL8vAU84YpgrP4pUsVkDmvcsi2lpLe/Ttg8diVtqZyj1yT++H93jxbNAoXO XBxQfVlFmEFL7ZOPMKnvxGA9/ueR1WGmpVkTwb+g32eoxpINqSsYxwXE4Y= X-Google-Smtp-Source: AGHT+IH2A1CDE5JVKe2dwzhkvr1V3p3l2bc+Lvq2Hf+xEtxIj89SkyS/KZUYVEcdsfpAcDDhdX6+DQ== X-Received: by 2002:a05:600c:4f85:b0:426:647b:1bfc with SMTP id 5b1f17b1804b1-434a9df22c0mr81950115e9.30.1732810911693; Thu, 28 Nov 2024 08:21:51 -0800 (PST) Received: from [127.0.0.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f70d9csm27004545e9.38.2024.11.28.08.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 08:21:51 -0800 (PST) From: Bryan O'Donoghue Date: Thu, 28 Nov 2024 16:21:49 +0000 Subject: [PATCH v4 1/3] media: venus: Add support for static video encoder/decoder declarations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-1-fd062b399374@linaro.org> References: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> In-Reply-To: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> To: Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_renjiang@quicinc.com, quic_vnagar@quicinc.com, quic_dikshita@quicinc.com, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-dedf8 Add resource structure data and probe() logic to support static declarations of encoder and decoder. Right now we rely on video encoder/decoder selection happening in the dtb but, this goes against the remit of device tree which is supposed to describe hardware, not select functional logic in Linux drivers. Provide two strings in the venus resource structure enc_nodename and dec_nodename. When set the venus driver will create an OF entry in-memory consistent with: dec_nodename { compat =3D "video-decoder"; }; and/or enc_nodename { compat =3D "video-encoder"; }; This will allow us to reuse the existing driver scheme of relying on compat names maintaining compatibility with old dtb files. dec_nodename can be "video-decoder" or "video0" enc_nodename can be "video-encoder" or "video1" This change relies on of_changeset() API as a result select OF_DYNAMIC will be added to venus/Kconfig Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/venus/Kconfig | 1 + drivers/media/platform/qcom/venus/core.c | 90 +++++++++++++++++++++++++++= ++++ drivers/media/platform/qcom/venus/core.h | 4 ++ 3 files changed, 95 insertions(+) diff --git a/drivers/media/platform/qcom/venus/Kconfig b/drivers/media/plat= form/qcom/venus/Kconfig index bfd50e8f34219db8a1de7960d7ea93b20db2982a..bc2e410b29cb415a36540a4f987= 09eae44f4ec35 100644 --- a/drivers/media/platform/qcom/venus/Kconfig +++ b/drivers/media/platform/qcom/venus/Kconfig @@ -3,6 +3,7 @@ config VIDEO_QCOM_VENUS depends on V4L_MEM2MEM_DRIVERS depends on VIDEO_DEV && QCOM_SMEM depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST + select OF_DYNAMIC if ARCH_QCOM select QCOM_MDT_LOADER if ARCH_QCOM select QCOM_SCM select VIDEOBUF2_DMA_CONTIG diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platf= orm/qcom/venus/core.c index 4e26b18790537885a77d66c1917a4e7a146eaf57..8a085611443cfda89ae71496e32= 0dfc1f02ade88 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -286,6 +286,89 @@ static irqreturn_t venus_isr_thread(int irq, void *dev= _id) return ret; } =20 +#if defined(CONFIG_OF_DYNAMIC) +static int venus_add_video_core(struct venus_core *core, const char *node_= name, + const char *compat) +{ + struct of_changeset *ocs =3D core->ocs; + struct device *dev =3D core->dev; + struct device_node *np, *enp; + int ret; + + if (!node_name) + return 0; + + enp =3D of_find_node_by_name(dev->of_node, node_name); + if (enp) { + of_node_put(enp); + return 0; + } + + np =3D of_changeset_create_node(ocs, dev->of_node, node_name); + if (!np) { + dev_err(dev, "Unable to create new node\n"); + return -ENODEV; + } + + ret =3D of_changeset_add_prop_string(ocs, np, "compatible", compat); + if (ret) + dev_err(dev, "unable to add %s\n", compat); + + of_node_put(np); + + return ret; +} + +static int venus_add_dynamic_nodes(struct venus_core *core) +{ + struct device *dev =3D core->dev; + int ret; + + core->ocs =3D kmalloc(sizeof(*core->ocs), GFP_KERNEL); + if (!core->ocs) + return -ENOMEM; + + of_changeset_init(core->ocs); + + ret =3D venus_add_video_core(core, core->res->dec_nodename, "venus-decode= r"); + if (ret) + goto err; + + ret =3D venus_add_video_core(core, core->res->enc_nodename, "venus-encode= r"); + if (ret) + goto err; + + ret =3D of_changeset_apply(core->ocs); + if (ret) { + dev_err(dev, "applying changeset fail ret %d\n", ret); + goto err; + } + + return 0; +err: + of_changeset_destroy(core->ocs); + kfree(core->ocs); + core->ocs =3D NULL; + return ret; +} + +static void venus_remove_dynamic_nodes(struct venus_core *core) +{ + if (core->ocs) { + of_changeset_revert(core->ocs); + of_changeset_destroy(core->ocs); + kfree(core->ocs); + } +} +#else +static int venus_add_dynamic_nodes(struct venus_core *core) +{ + return 0; +} + +static void venus_remove_dynamic_nodes(struct venus_core *core) {} +#endif + static int venus_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -365,6 +448,11 @@ static int venus_probe(struct platform_device *pdev) if (ret < 0) goto err_runtime_disable; =20 + if (core->res->dec_nodename || core->res->enc_nodename) { + if (venus_add_dynamic_nodes(core)) + goto err_runtime_disable; + } + ret =3D of_platform_populate(dev->of_node, NULL, NULL, dev); if (ret) goto err_runtime_disable; @@ -443,6 +531,8 @@ static void venus_remove(struct platform_device *pdev) =20 venus_firmware_deinit(core); =20 + venus_remove_dynamic_nodes(core); + pm_runtime_put_sync(dev); pm_runtime_disable(dev); =20 diff --git a/drivers/media/platform/qcom/venus/core.h b/drivers/media/platf= orm/qcom/venus/core.h index 27784fd7082c321222b23ca4b2902a04c49e19ca..306231b4f7d0201175974b4a425= 74f30d23e08f0 100644 --- a/drivers/media/platform/qcom/venus/core.h +++ b/drivers/media/platform/qcom/venus/core.h @@ -90,6 +90,8 @@ struct venus_resources { u32 cp_nonpixel_start; u32 cp_nonpixel_size; const char *fwname; + const char *enc_nodename; + const char *dec_nodename; }; =20 enum venus_fmt { @@ -171,6 +173,7 @@ struct venus_format { * @root: debugfs root directory * @venus_ver: the venus firmware version * @dump_core: a flag indicating that a core dump is required + * @ocs: OF changeset pointer */ struct venus_core { void __iomem *base; @@ -235,6 +238,7 @@ struct venus_core { u32 rev; } venus_ver; unsigned long dump_core; + struct of_changeset *ocs; }; =20 struct vdec_controls { --=20 2.47.1 From nobody Mon Feb 9 22:20:49 2026 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 912B41BD9CF for ; Thu, 28 Nov 2024 16:21:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810917; cv=none; b=jDIQyjGStjt8nwMIag/OiBcAMMYbX3oOBZwf0JPEmVdnUyWnUeABk2Ermj03zpU4lQ1fwtAdMShQBm0kf5FrRTufEPUSWYa7mmETJ8y22b9lLZWxBfWhuDys5dJvH+miaxbmsjK+TBKrId6RXQdm4XO3Q82MzHJ5UKMnkcSaGyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810917; c=relaxed/simple; bh=uHwu28kexnpu01U+BQLqCIx+XHvsd7tHdfHAO+9X+fE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S1phMbr0kIJDuZoRX2XQz/5k4B8HL2DWFJXFdLhDS0rl1BDoSNnQ2nwGp+W4khvngbKDzV2AR4NGFGP0odFMtuOHnAF4qUzaXJXBJlfxxZ6R4bcAwP6+hMSzEwjPY+kABoyFz4yqUEPub/NLER498EPdeA+1CMHn9HdyjXyLUnY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JUe6tDkW; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JUe6tDkW" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-385d7b4da2bso256272f8f.1 for ; Thu, 28 Nov 2024 08:21:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732810913; x=1733415713; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=U2ByW5LJaVgwbGGu4xqa6JYQJaVynxhc9VtK5XpZNd0=; b=JUe6tDkWypzDArBQdaQW35vaIWtolgUuBBj+czhkEJRL8AumtxZ8KU5avJjnopWI3z et9hnm0Vi2qk8A1FQrC91FhKnOhmVN45CbWa9cygE3ldd5v90VLDh1pvpUviQBhVdJm8 rme0tMzCFUm2gV58Tn6iAUJ/JwvsG38DnmXcxw7UPmE41BddyRrOZajHOReoU3iBVVGG wlHQNmL3QaHt/tjwkMmeJkKVSaEuG3nrpr1oymEfpya9cuZVghlbkT2HWS6ymsUi9fkH 5khdPYM1jSzCOXICc3NaP5uJ3RlAo25sM50TNJlkYLJyDVPbz2sdCTwTzuCdPB7wuzbK V1RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732810913; x=1733415713; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U2ByW5LJaVgwbGGu4xqa6JYQJaVynxhc9VtK5XpZNd0=; b=TF0Ap1mMrbk7DTEkALzIzROM2TgPsSj3cIYReIpcev/FI1f83yePrH8qgJOM57IasP FpRu3Dr0e/N6WfzldrVRltQH1lwg20zsih0taaa10LjNZrD2jCeuw34RdpWSQOcqsbNM tte0K/0ueIMIRGG6pkrS3Ix5W4qZHAacYhJ8YnZDhmuQJTYsxbZ52jl45IY+HQEQZlvV HhejPXugDad2eSTGHx5V+rYJN/K7nhxoMtiQrJnYLOzilpfXKYkn5q3FG4eeuwQ7W30o MxmWFuPyiOEKIeO1z0u6HIE0++ghmlULehIDpUDM6GPu7KznFZZSlSxahbm4EgpdZ+mL D2cA== X-Forwarded-Encrypted: i=1; AJvYcCVVMdtyAqi/LC2h+buFDnWaFoHRq4brQESHNcQyNd+KmNE97SKkfZX2oro+DWfqAUOh0iDjd9/dwDe4VPY=@vger.kernel.org X-Gm-Message-State: AOJu0YyxLNbx4ucM9ItfTUD1tEeQyJkg3+36j4sCYotoAmenWGJloANK qg/zjRrik7LNRhzJH4SJ0bW6vQiy6jZwuB/lmvg0v4kOcNPPtsHeufwjcXDrpP8= X-Gm-Gg: ASbGnctBnoYTxZF+w32wD4FEPJdUCqryb/GVhlm5wCkfvThGzn7+hIaCZvbrbg2cCZO 68+s9LDNG17bTDQahuED/E97D7yflAcd88hQzUuvJyGhIE1kYTl3chrRRJIqF5jqKelBM2NHojE AaIN9E/3xQKj3SWWAn/FKP9kxSxm2llR6e/HnYG/M6Nq3RY54ASuvCeGcwWVDJRIVc9DvtSXUI2 Gl3Q9srNhcNBqJ8jsfa76St7RPxMhp2OBIb/e/30UikqbAKSjSD4x2j/S0= X-Google-Smtp-Source: AGHT+IGGiN8vBkxi8NX+D9sBUXrGPX4zuLPArfsKyiosF573lLbt37akFeV+XcprEbuk25Cn/bUWfw== X-Received: by 2002:a5d:5f53:0:b0:382:3f77:8584 with SMTP id ffacd0b85a97d-385c6ebb9ebmr6891625f8f.32.1732810912756; Thu, 28 Nov 2024 08:21:52 -0800 (PST) Received: from [127.0.0.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f70d9csm27004545e9.38.2024.11.28.08.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 08:21:52 -0800 (PST) From: Bryan O'Donoghue Date: Thu, 28 Nov 2024 16:21:50 +0000 Subject: [PATCH v4 2/3] media: venus: Populate video encoder/decoder nodename entries Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-2-fd062b399374@linaro.org> References: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> In-Reply-To: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> To: Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_renjiang@quicinc.com, quic_vnagar@quicinc.com, quic_dikshita@quicinc.com, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-dedf8 Populate encoder and decoder node-name entries for the upstream parts. Once done the compat=3D"video-encoder" and compat=3D"video-decoder" in the dtsi = can be dropped though the venus driver will continue to favour DT declared video-encoder/video-decoder declarations over static declarations for compatibility. Signed-off-by: Bryan O'Donoghue --- drivers/media/platform/qcom/venus/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platf= orm/qcom/venus/core.c index 8a085611443cfda89ae71496e320dfc1f02ade88..1a408c1c2277d77c5fcb67cb94b= aff6b98c26a2b 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -672,6 +672,8 @@ static const struct venus_resources msm8916_res =3D { .vmem_addr =3D 0, .dma_mask =3D 0xddc00000 - 1, .fwname =3D "qcom/venus-1.8/venus.mbn", + .dec_nodename =3D "video-decoder", + .enc_nodename =3D "video-encoder", }; =20 static const struct freq_tbl msm8996_freq_table[] =3D { @@ -881,6 +883,8 @@ static const struct venus_resources sdm845_res_v2 =3D { .cp_nonpixel_start =3D 0x1000000, .cp_nonpixel_size =3D 0x24800000, .fwname =3D "qcom/venus-5.2/venus.mbn", + .dec_nodename =3D "video-core0", + .enc_nodename =3D "video-core1", }; =20 static const struct freq_tbl sc7180_freq_table[] =3D { @@ -929,6 +933,8 @@ static const struct venus_resources sc7180_res =3D { .cp_nonpixel_start =3D 0x1000000, .cp_nonpixel_size =3D 0x24800000, .fwname =3D "qcom/venus-5.4/venus.mbn", + .dec_nodename =3D "video-decoder", + .enc_nodename =3D "video-encoder", }; =20 static const struct freq_tbl sm8250_freq_table[] =3D { @@ -984,6 +990,8 @@ static const struct venus_resources sm8250_res =3D { .vmem_addr =3D 0, .dma_mask =3D 0xe0000000 - 1, .fwname =3D "qcom/vpu-1.0/venus.mbn", + .dec_nodename =3D "video-decoder", + .enc_nodename =3D "video-encoder", }; =20 static const struct freq_tbl sc7280_freq_table[] =3D { @@ -1046,6 +1054,8 @@ static const struct venus_resources sc7280_res =3D { .cp_nonpixel_start =3D 0x1000000, .cp_nonpixel_size =3D 0x24800000, .fwname =3D "qcom/vpu-2.0/venus.mbn", + .dec_nodename =3D "video-decoder", + .enc_nodename =3D "video-encoder", }; =20 static const struct of_device_id venus_dt_match[] =3D { --=20 2.47.1 From nobody Mon Feb 9 22:20:49 2026 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 775B11C07CB for ; Thu, 28 Nov 2024 16:21:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810917; cv=none; b=iYJFF1SMN1AoJK1kFvitbnsaN1nJYSLq/bQERuvpNk3s6GdfjEvMjlZKtCgjnmHknLOk3V0oX5sWtNLqk9v/67Tuin6UG+J6zD4Y5fvVEaXL4hazD2lhrO1k7qR8nyD9PHomu6q3PXrSElx7RDms7Gv+JWbtbF7TMi9eR8wufco= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732810917; c=relaxed/simple; bh=lveT01XJFbPiCHFrg6nSo0zlm6T0yWAAHdtlgddNXio=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GuOn53IobZ3sE37YOAEEKWwIOj2DvvJkp4zHwzzffPntBg6my5NrtDw2l1PNJJxv2qRgc7kEIfW8iFGHUmcDvjHuVv6W6LF6R6vDIO8x07x6d1QMeWGk0N59OhmA6Kxkf/fMOFmCHJdT8wHaXg7oBtEchJeK811Ty/mi/NAsvNA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yRp4f7M3; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yRp4f7M3" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-434a742481aso8817645e9.3 for ; Thu, 28 Nov 2024 08:21:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732810914; x=1733415714; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=t3dDvW0+Cz6kszp6aCIpBOpaxsGIqiTVCAZVfI6Gurs=; b=yRp4f7M3xtoptnd4IxwdyyAz8Uw+/vU8Ht4nFHYlfOcIdgWy1U3Aj6h5gPhEXo6TGQ Fiom3IVyblar5NyDx5l8BPDwVtRMR8ZT0HSUf4YoR14LI6i+1aonzHYTIcFXfYWzj46w NPeTzbz3xFX/rTo7F4LlNhni9l4BGQC6ZUF7pZDI4Vi/nlIVPJSj02StMFLDWsD3dy+N PTr4vPWR6RTw0mRk4JsvIdn1Eeg7ABekURgwW7ZmpdxDSYsrJns7KCRxR4EDgYYUlVM/ kqlGAiOJinrB/NVAnEeL4pj4pOF9e66+XdO+/uIWscEKXuwqiAri4NgGLg2jnwiZwx8S UhOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732810914; x=1733415714; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t3dDvW0+Cz6kszp6aCIpBOpaxsGIqiTVCAZVfI6Gurs=; b=gQ+vmdRZ5htvajsdzP1jkQ2ylJ9qHZDC+UH3wJ/5aJrg6huSL4vwUFdu0+VfSifpkx 3plGGl6xyh40ci2zjJOvwYBRrohjHT9pM8lR3O+sY3pT8MQMAeGQFRh/XC4IgWmufAJA rH+s7P4s5WoxbGXi4PNtRVzSXBOUiLPguVaXBpFnQHY4Lcky9HmCYo4F89++vs21PtkW mM9iZc/tPTcFeWAmWC1dZMT6KifYLKgkxVjfy8BntDrn6bXepbZuyp4Z6kN1g3q1uiAa E79afcstACqg+IfWiqDnijIqmQTknNiyUgXHzkU6jQvW8lfFzZt/o9pxbLRh/9IZxkYa 3ZrQ== X-Forwarded-Encrypted: i=1; AJvYcCVmJYVdK+CVxFTPoPxyGVRt5JaZf8DnI90JWDGv7lEHbzsXnogwDP6tO4g8i/pwN12CoFJO2ZmRAxe9YPE=@vger.kernel.org X-Gm-Message-State: AOJu0YxNH4ot42dQSsn39I/b+wLanYLrnB945nEK2c3ptWDUaWZnjJGl kFO4zHnrPXr9zAP7tsDuE9UBFRAQVCrdQ76UJ8z63JoYunoExd3M+kyhKEblYu6yta1g6RvG/8A /fLM= X-Gm-Gg: ASbGncv7GdGEBq8vlhEGK1Np6c0WMB2PU355u/DK0cB2UwwpDCINAWdaV6RMXfHQNeK xKYV3flTPQsMM7hIGNeKlhGjb2A7IAfITw1ZSQmSl5XMSY1tdh4zxiQKUrK/JRbjKve/F6/yj7n WYh2/3/TLevoFwrtgzwb7mRnhx7EYDGDGo2MpfrqW42fRuExVQLYZssjOH3dUu3PwgSydwCaIoq yY8qz8YJ5Of/Rhp3YsqQavCIjxWNgMb3cem1/0ZKJgYQVyU+xTQLUxfxVc= X-Google-Smtp-Source: AGHT+IHxY7oKgFgJZ4sweXccUfXlO3kfxAoksfpsXIIPvc2aGpAbCuTxEbmTKUh3VLkL92Hpd3UGFA== X-Received: by 2002:a05:600c:458b:b0:434:a924:44e9 with SMTP id 5b1f17b1804b1-434a9dcfedfmr76862525e9.15.1732810913825; Thu, 28 Nov 2024 08:21:53 -0800 (PST) Received: from [127.0.0.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434b0f70d9csm27004545e9.38.2024.11.28.08.21.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Nov 2024 08:21:53 -0800 (PST) From: Bryan O'Donoghue Date: Thu, 28 Nov 2024 16:21:51 +0000 Subject: [PATCH v4 3/3] media: dt-bindings: qcom-venus: Deprecate video-decoder and video-encoder where applicable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-3-fd062b399374@linaro.org> References: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> In-Reply-To: <20241128-media-staging-24-11-25-rb3-hw-compat-string-v4-0-fd062b399374@linaro.org> To: Stanimir Varbanov , Vikash Garodia , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: quic_renjiang@quicinc.com, quic_vnagar@quicinc.com, quic_dikshita@quicinc.com, konradybcio@kernel.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Bryan O'Donoghue , Krzysztof Kozlowski X-Mailer: b4 0.15-dev-dedf8 For the list of yaml files here the video-decoder and video-encoder nodes provide nothing more than configuration input for the driver. These entries do not in fact impart hardware specific data and should be deprecated. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Bryan O'Donoghue --- .../devicetree/bindings/media/qcom,msm8916-venus.yaml | 12 ++------= ---- .../devicetree/bindings/media/qcom,sc7180-venus.yaml | 12 ++------= ---- .../devicetree/bindings/media/qcom,sc7280-venus.yaml | 12 ++------= ---- .../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 12 ++------= ---- .../devicetree/bindings/media/qcom,sm8250-venus.yaml | 12 ++------= ---- 5 files changed, 10 insertions(+), 50 deletions(-) diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yam= l b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml index 9410f13ca97c181973c62fe62d0399fc9e82f05d..da140c2e3d3f3c3e886496e3e23= 03eda1df99bb4 100644 --- a/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-venus.yaml @@ -45,6 +45,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 video-encoder: @@ -57,13 +58,12 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 required: - compatible - iommus - - video-decoder - - video-encoder =20 unevaluatedProperties: false =20 @@ -83,12 +83,4 @@ examples: power-domains =3D <&gcc VENUS_GDSC>; iommus =3D <&apps_iommu 5>; memory-region =3D <&venus_mem>; - - video-decoder { - compatible =3D "venus-decoder"; - }; - - video-encoder { - compatible =3D "venus-encoder"; - }; }; diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml= b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml index 5cec1d077cda77817f6d876109defcb0abbfeb2c..83c4a5d95f020437bd160d64568= 50bc84a2cf5ff 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml @@ -70,6 +70,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 video-encoder: @@ -82,14 +83,13 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 required: - compatible - power-domain-names - iommus - - video-decoder - - video-encoder =20 unevaluatedProperties: false =20 @@ -114,12 +114,4 @@ examples: "vcodec0_core", "vcodec0_bus"; iommus =3D <&apps_smmu 0x0c00 0x60>; memory-region =3D <&venus_mem>; - - video-decoder { - compatible =3D "venus-decoder"; - }; - - video-encoder { - compatible =3D "venus-encoder"; - }; }; diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml= b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml index 10c334e6b3dcf25967fa438f8e6e5035448af1b9..413c5b4ee6504ba1d5fe9f74d5b= e04ad8c90c318 100644 --- a/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sc7280-venus.yaml @@ -68,6 +68,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 video-encoder: @@ -80,14 +81,13 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 required: - compatible - power-domain-names - iommus - - video-decoder - - video-encoder =20 unevaluatedProperties: false =20 @@ -125,14 +125,6 @@ examples: =20 memory-region =3D <&video_mem>; =20 - video-decoder { - compatible =3D "venus-decoder"; - }; - - video-encoder { - compatible =3D "venus-encoder"; - }; - video-firmware { iommus =3D <&apps_smmu 0x21a2 0x0>; }; diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.y= aml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml index 6228fd2b324631f3138e128c918266da58f6b544..c839cb1ebc0999e10b865f4bb43= ea76ffa2bf46d 100644 --- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml @@ -70,6 +70,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 video-core1: @@ -82,14 +83,13 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 required: - compatible - power-domain-names - iommus - - video-core0 - - video-core1 =20 unevaluatedProperties: false =20 @@ -119,12 +119,4 @@ examples: iommus =3D <&apps_smmu 0x10a0 0x8>, <&apps_smmu 0x10b0 0x0>; memory-region =3D <&venus_mem>; - - video-core0 { - compatible =3D "venus-decoder"; - }; - - video-core1 { - compatible =3D "venus-encoder"; - }; }; diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml= b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml index f66033ae8b590e7b6f1e344c368994744411aca2..da54493220c9dc90e7d9f5fcfce= 7590acb241c85 100644 --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml @@ -73,6 +73,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 video-encoder: @@ -85,6 +86,7 @@ properties: required: - compatible =20 + deprecated: true additionalProperties: false =20 required: @@ -95,8 +97,6 @@ required: - iommus - resets - reset-names - - video-decoder - - video-encoder =20 unevaluatedProperties: false =20 @@ -132,12 +132,4 @@ examples: resets =3D <&gcc GCC_VIDEO_AXI0_CLK_ARES>, <&videocc VIDEO_CC_MVS0C_CLK_ARES>; reset-names =3D "bus", "core"; - - video-decoder { - compatible =3D "venus-decoder"; - }; - - video-encoder { - compatible =3D "venus-encoder"; - }; }; --=20 2.47.1