From nobody Wed Nov 27 16:47:25 2024 Received: from mx07-00178001.pphosted.com (mx08-00178001.pphosted.com [91.207.212.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A43A1B6CFB; Tue, 26 Nov 2024 09:13:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.207.212.93 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732612429; cv=none; b=spYM7j+f4J0rOBnEQlksrW2HisCAC78Ox0IMLcB5CzQoJ9cO6fpO73LYe24thLNkvVBcKuMkSI02y6i3PXV6gn6Nar03kJBUalaW61QLDgfOZiAcSj8OY4vjukrTSgj3rq9AHaHlFNv1DAQCQQZd3BJN723Y9VwiwKOr2Jxol9A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732612429; c=relaxed/simple; bh=kj1hfdWSVjSnNWbE7Aa7J7Ymzw8bom7kkF0XyMlA3cc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jFLgRf/lH1NdYJ8X3SnGgclqFEWw48oxhU7E8npWPGTFVQOl4ewPDXD7EXcpM3aR++IULX/XOK5Sv9fGESIm5V8ZyzMyWwRVQg45fHar4OOxWR1PwkSH/z0VDMP2zQVIc9QFcol/40ZVm9VfSg2YhejioEYGFsTSW3gq66VrcZM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com; spf=pass smtp.mailfrom=foss.st.com; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b=CemEy3rc; arc=none smtp.client-ip=91.207.212.93 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=foss.st.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=foss.st.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com header.b="CemEy3rc" Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AQ1uJmR007632; Tue, 26 Nov 2024 10:13:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=selector1; bh= XDQDGSReDFtTs5dS4somR8H6zR6+6yKYIEpiiGNll7s=; b=CemEy3rc4ZCSTFtS aVEntbGWR11tyZfaxTatyNca1FzRUFmJRnj/VEuZ7XqP4C3CDNifk3epHrMehnFj W0QjOSCVBFUFDrj91gjn9VmEdB9rxV/X6UWgZmj2lwyjdaz321cHS4RYbEhZWhW8 fRSbP9Fw149LdBrkx/Yw7tEslE0AVN9KHVmQpBlQQOCb1Qv6PrApkKE+ci+2Q31P GKAGlyH4b68EAxpFoCU8i17gsvhFGL4PxV5PX5WHHpdZzdZ8Jw5IgcL7jQVV8mYC 7K4ovgPdY/PuhtLpyCQhLbV8TMjtRrsYT0Dvnl9DQWh206FSbF67Vs7HmhiwNy5z ZYbqrw== Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 4336tfksud-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Nov 2024 10:13:32 +0100 (CET) Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 1010340078; Tue, 26 Nov 2024 10:12:34 +0100 (CET) Received: from Webmail-eu.st.com (eqndag1node5.st.com [10.75.129.134]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id AF31A26B65D; Tue, 26 Nov 2024 10:11:18 +0100 (CET) Received: from SAFDAG1NODE1.st.com (10.75.90.17) by EQNDAG1NODE5.st.com (10.75.129.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 26 Nov 2024 10:11:18 +0100 Received: from localhost (10.48.86.121) by SAFDAG1NODE1.st.com (10.75.90.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.37; Tue, 26 Nov 2024 10:11:18 +0100 From: Arnaud Pouliquen To: Bjorn Andersson , Mathieu Poirier , Maxime Coquelin , Alexandre Torgue CC: Arnaud Pouliquen , , , , Subject: [PATCH v14 8/8] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Date: Tue, 26 Nov 2024 10:10:39 +0100 Message-ID: <20241126091042.918144-9-arnaud.pouliquen@foss.st.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241126091042.918144-1-arnaud.pouliquen@foss.st.com> References: <20241126091042.918144-1-arnaud.pouliquen@foss.st.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SAFCAS1NODE1.st.com (10.75.90.11) To SAFDAG1NODE1.st.com (10.75.90.17) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 Content-Type: text/plain; charset="utf-8" The new TEE remoteproc driver is used to manage remote firmware in a secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is introduced to delegate the loading of the firmware to the trusted execution context. In such cases, the firmware should be signed and adhere to the image format defined by the TEE. Signed-off-by: Arnaud Pouliquen --- updates vs previous version - register load_fw() ops instead of load() to call rproc_tee_load_fw() --- drivers/remoteproc/stm32_rproc.c | 57 ++++++++++++++++++++++++++++++-- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rp= roc.c index 1586978c5757..c155822324d8 100644 --- a/drivers/remoteproc/stm32_rproc.c +++ b/drivers/remoteproc/stm32_rproc.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -255,6 +256,19 @@ static int stm32_rproc_release(struct rproc *rproc) return 0; } =20 +static int stm32_rproc_tee_stop(struct rproc *rproc) +{ + int err; + + stm32_rproc_request_shutdown(rproc); + + err =3D rproc_tee_stop(rproc); + if (err) + return err; + + return stm32_rproc_release(rproc); +} + static int stm32_rproc_prepare(struct rproc *rproc) { struct device *dev =3D rproc->dev.parent; @@ -691,8 +705,20 @@ static const struct rproc_ops st_rproc_ops =3D { .get_boot_addr =3D rproc_elf_get_boot_addr, }; =20 +static const struct rproc_ops st_rproc_tee_ops =3D { + .prepare =3D stm32_rproc_prepare, + .start =3D rproc_tee_start, + .stop =3D stm32_rproc_tee_stop, + .kick =3D stm32_rproc_kick, + .load_fw =3D rproc_tee_load_fw, + .parse_fw =3D rproc_tee_parse_fw, + .find_loaded_rsc_table =3D rproc_tee_find_loaded_rsc_table, + .release_fw =3D rproc_tee_release_fw, +}; + static const struct of_device_id stm32_rproc_match[] =3D { { .compatible =3D "st,stm32mp1-m4" }, + { .compatible =3D "st,stm32mp1-m4-tee" }, {}, }; MODULE_DEVICE_TABLE(of, stm32_rproc_match); @@ -853,15 +879,36 @@ static int stm32_rproc_probe(struct platform_device *= pdev) struct device_node *np =3D dev->of_node; struct rproc *rproc; unsigned int state; + u32 proc_id; int ret; =20 ret =3D dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); if (ret) return ret; =20 - rproc =3D devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*dd= ata)); - if (!rproc) - return -ENOMEM; + if (of_device_is_compatible(np, "st,stm32mp1-m4-tee")) { + /* + * Delegate the firmware management to the secure context. + * The firmware loaded has to be signed. + */ + ret =3D of_property_read_u32(np, "st,proc-id", &proc_id); + if (ret) { + dev_err(dev, "failed to read st,rproc-id property\n"); + return ret; + } + + rproc =3D devm_rproc_alloc(dev, np->name, &st_rproc_tee_ops, NULL, sizeo= f(*ddata)); + if (!rproc) + return -ENOMEM; + + ret =3D rproc_tee_register(dev, rproc, proc_id); + if (ret) + return dev_err_probe(dev, ret, "signed firmware not supported by TEE\n= "); + } else { + rproc =3D devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*d= data)); + if (!rproc) + return -ENOMEM; + } =20 ddata =3D rproc->priv; =20 @@ -913,6 +960,8 @@ static int stm32_rproc_probe(struct platform_device *pd= ev) dev_pm_clear_wake_irq(dev); device_init_wakeup(dev, false); } + rproc_tee_unregister(rproc); + return ret; } =20 @@ -933,6 +982,8 @@ static void stm32_rproc_remove(struct platform_device *= pdev) dev_pm_clear_wake_irq(dev); device_init_wakeup(dev, false); } + + rproc_tee_unregister(rproc); } =20 static int stm32_rproc_suspend(struct device *dev) --=20 2.25.1