From nobody Mon Feb 9 15:40:21 2026 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82F5F1DFE16 for ; Tue, 26 Nov 2024 23:44:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664676; cv=none; b=U96oE0XYKNp0cGnNZ1AohfDuc9gkYejzlvM/2o6FP+QzUNyN1WGjANjWCMQGdj84n1kJnz1AnSCeDInaMe1Vgl5VFUhbfi1xIzs7Svjab2WNTU9BifH8UtlL9CAG366JMe+fa8rWVi44G4GkKcaKF8IsW/h+Z4JLV7r1z7oUjuA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664676; c=relaxed/simple; bh=CdkYU+QJ7VGTHMAgD+J6/KS8Mhb64oBSKmpBnvb/LZU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LrWL262qb8pDKShfvhtiPvwqF6BJa2pvDFUjTgjVb0inxSqCEFN+IUrGW3hTLU1/1vfbE2SSdJyTkBWpmyKOrxu4eexsv5JF0tpC+4GnZaED7dMElY9ATBdU1y1UFeFyvAICosi/NjDI2rPDWbew/KrV2VUuXletWVd8atVeqUQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HPkmxrDh; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HPkmxrDh" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3824a8a5c56so4260007f8f.3 for ; Tue, 26 Nov 2024 15:44:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732664673; x=1733269473; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+O0H/HlytTMZjW4JWV/layUzk6y2v65D7CAbQ2KVEWY=; b=HPkmxrDh0+CPbjb4L7WbvT5rXL8iMM9EZfu9l9WQMey5BAkbsfWWS4urUyEphohcbE m3t8rYNefwbCdh/ls0U8ldwX7WLYCtHRTsPoNFYNuxQkrMoDbAfntNsKd3+P7ZuaVjD/ HwmvEoHAZL9IoAqcZyK9eADMJIv9/O2Aw+92MYxzL8aLIS6dFarUoo+X8QtQg/NSJtZ5 Ogkc8cnZI6UU0BXMiygTxuI4bEssry3Ihn3eii4FAg5rQrqITrbzG1hD2BhvkZ76+dQ1 Lg7NT7cIpmaD6NT5NQr7jxN2DDHD/BS/gIp7Eur93kdU0iK3kiEDlBXT/WO2n3/948En xjBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732664673; x=1733269473; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+O0H/HlytTMZjW4JWV/layUzk6y2v65D7CAbQ2KVEWY=; b=Q55u/ylotHR4/A70erqXgHbktI2mb+Inlg1DXMOwI6Vin7GpmZiE67QVijVkNe54lT 939DnuPp4IJbubS0zvjUyDzqINa03RZos8R/R/qVubOMtwO97FQR8UjyGMMFRZPEMjIS Iolw9y5IVKp63GLiKNd/JPGSnuKztYULf9No9hwT7LaioF8NgVumHap8gpbg+uX4nCcn yoIewrm1ywp67Y+tOYANOQpGpdnxhVvSLjyOG+tzTi01b8G6Sp7GJ2f7BCLsxka7YVmm bkn3HE2efmW/XStOG7hGWpoOaXhTzhqB6MKY9HDBiGTmpFpof8ffv8tXxIK2MekuSXR6 Vr1g== X-Forwarded-Encrypted: i=1; AJvYcCUAvWYj1WHcuo+0I93wiDzKr0yzTXkaRaB81OqwddfeJ0lZHHN4DfIdtTNiCzDqFu04uDTTFuyFePqhmHU=@vger.kernel.org X-Gm-Message-State: AOJu0YzH8+kREieZrHdSbPRCSRwU5w702RFPDBkoPIklu29JgAmTh3sf a78p+E2w1toCtVmMKNbNiaCg89IQkYV9rE6xV4v0XYmacgx3DNi0Wonk/yQm3hA= X-Gm-Gg: ASbGncvIdWW7mufK6v0h9bWebdfOGIROzqGn6guAhbeJclWFhcY6kKExTKxteixJEmn CQJ3HG/GrgcRwMD7ZRcHyF4U2OpSyKa15lmtmHv8sNKHN+/kuRP6zkALElNgDPiKd4MPtdzsNPq bJhvwpe2RVHV7ik65wTNPLxzvQsXW0C7ckPWBgbiSsv+ELbReqUzJr1AiggBgfuHuRObyzLmtnF F2444tDGwi7paaqnjV1vZ6ruFR/5jB/6nxYlCxno8ul/5aFOSl/rB+bHy0= X-Google-Smtp-Source: AGHT+IF/jcs8cjb4B6GiHnOvpr78M0lvjd/SOOBsND3Uk6XPO25NFtr3q9aIzztmUerymlOVowuCsQ== X-Received: by 2002:a05:6000:2a9:b0:382:5010:c8cd with SMTP id ffacd0b85a97d-385c6ed7749mr578127f8f.44.1732664672853; Tue, 26 Nov 2024 15:44:32 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fafe338sm14482899f8f.33.2024.11.26.15.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 15:44:31 -0800 (PST) From: Bryan O'Donoghue Date: Tue, 26 Nov 2024 23:44:27 +0000 Subject: [PATCH v3 1/3] clk: qcom: gdsc: Capture pm_genpd_add_subdomain result code Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-1-836dad33521a@linaro.org> References: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> In-Reply-To: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue , stable@vger.kernel.org X-Mailer: b4 0.15-dev-355e8 Adding a new clause to this if/else I noticed the existing usage of pm_genpd_add_subdomain() wasn't capturing and returning the result code. pm_genpd_add_subdomain() returns and int and can fail. Capture that result code and throw it up the call stack if something goes wrong. Fixes: 1b771839de05 ("clk: qcom: gdsc: enable optional power domain support= ") Cc: stable@vger.kernel.org Signed-off-by: Bryan O'Donoghue Reviewed-by: Bjorn Andersson --- drivers/clk/qcom/gdsc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index fa5fe4c2a2ee7786c2e8858f3e41301f639e5d59..4fc6f957d0b846cc90e50ef243f= 23a7a27e66899 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -555,9 +555,11 @@ int gdsc_register(struct gdsc_desc *desc, if (!scs[i]) continue; if (scs[i]->parent) - pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); + ret =3D pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) - pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); + ret =3D pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd= ); + if (ret) + return ret; } =20 return of_genpd_add_provider_onecell(dev->of_node, data); --=20 2.45.2 From nobody Mon Feb 9 15:40:21 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13CE61DFE36 for ; Tue, 26 Nov 2024 23:44:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664677; cv=none; b=UPQx9aP3TfHBgILB+as9BdNpJfhAEa5Q0fv20gY2OEtTfkThBiGCOY6yvUpknfggifdac7JgGIxElaLqyMNWZLKtxfXcdEfDEjjQKCh0Nq1iG+8odSKlrGf4WDeYbc87KDONSEQEd8PFmk4Hp82TOXVFo6kl0K+VUidHjDP29RE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664677; c=relaxed/simple; bh=9DcDIgyiPEQQcegeEN1oWtNvqOat5t+dI1L4z5w/npc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jXcH1ZRzh+j5M/lB7YDuK64DHXjks9lDfHmY3tCWZyqxffM1AbLHd/vBd22amWqZ6KXabdKdcTn+OukNoYGJ45tdsJkAM6Wd/CVqXHrd7l0EZSutVEVcBcFWITRtgLJkOPdsXlIkZLcJ+9MLzTv1a/o/KAQuvJ/fUsejlBSzXV8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=f6AKDNje; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f6AKDNje" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-382442b7d9aso4704286f8f.1 for ; Tue, 26 Nov 2024 15:44:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732664674; x=1733269474; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6CvPt8QMHcz942A3Oqz3/N9DPxj3tCNq+0xhS6ngyuw=; b=f6AKDNjeC/ddGcJ/pTrP7RqmpxnNaWdSofMYY3TPXNbF6hvkg2of2rKa+C/GSW6vjv 1RpNC3zm24hAhgBtMYpuS5yw1/4wgsw8q6cLrEdBu6mfyWb+Dw60om71rEIDXWRX3tKl YTOc0PLpO/QnFAe0jXk5kEjZqzd3RZXEWS+vb4egTeOurBFnMD+FNO0XRr06vFHH73Y/ 2Q+a2bBF+EEVOP0Oh+hHKUx6HxDwWA8mCcGoUCyhbAPfIYBjWmjr6kFViBQmCEXoFoO0 qMMMoJf+hYMoA0cS9BaV6mYied2HpNCRbEm2e6FQwYoFytnngRksEp2aPwoX/VSnGkeO lGzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732664674; x=1733269474; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6CvPt8QMHcz942A3Oqz3/N9DPxj3tCNq+0xhS6ngyuw=; b=cszC4n++UzPBtcSH2rYnobok7THnqqdUf5F44HnxxVxpefGlXEzfgZs7DRds0+F5z0 p4Er7SlHvLw/i4OoEI9EDN+nnbW/ThgU++JqcuTz0ndLoI4zak62vd6sG5PC9DPBeQ2Y 6R6VWwVHsnNlnn0wCESrYcOkNkgVuUxOQ//MzayqztQVwoX+8HrNsL4T1FMuaO6rjjkh E8sCDBmGIPrfLNd7lYVbv60Ts//0seyuBl/pQ0xZ48bEu/mm8qFjEk8FZ/4skvZAhpTv YE/Mjpk8I2VqN0Z5XcxqUkAQsY8rbUQuD7L/Nebjx55CZLOR1B9v4+cPr5XGiFniOXPI n4Wg== X-Forwarded-Encrypted: i=1; AJvYcCW1mboYEMPchsiFaqGj0bAyOhnbLidZBcA3BMW3mAv4AvG3PgKoLaLkS6D6P7yWKf58RdteMSYaJSbPbSM=@vger.kernel.org X-Gm-Message-State: AOJu0YyZZrqbKTfoHf1DnYFnT1qgpp4okDZ37p03GUvBKXaZ5B4JPqb8 dslo0OahWjWOhUrMf42PNxvtWaEdthXlwmDV6deGEohHXCLr4uYxTF1c1gDwIIc= X-Gm-Gg: ASbGncvxHIrGuje+QjwwZFNNZ+biJMXPtgrHfT4gUN4l/LJmn9You6J3lIERz2OiHOR MwPoDUyWh4/kqNfJ8Anc5Wd+o4clAY2vOQbfgbjtXnBMQWw8Y9JfBNHGuZmepe4+nyDyMbZCyj4 Tp4z6BLbRpAvAlvNdEDgTQ/1xaEeq7sHCU7E5Ai1gQmkLp2Y9Loaoqm3wNSd4EfOSvtrK3ljFX/ 9XzjH6ayMhPlQ3Wj1autFHdA9JUICihva1PM/s1N0Jdr6P6IOo648OLYWo= X-Google-Smtp-Source: AGHT+IE+Oglm7E2t7Ut5iZpBl+SAvEqAXWb/9nqHNfrjK8E3TwWYDWN8olld0Ah29+gOrPXAKM3mBQ== X-Received: by 2002:a5d:5888:0:b0:382:4378:4652 with SMTP id ffacd0b85a97d-385c6edd47bmr520166f8f.45.1732664674376; Tue, 26 Nov 2024 15:44:34 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fafe338sm14482899f8f.33.2024.11.26.15.44.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 15:44:34 -0800 (PST) From: Bryan O'Donoghue Date: Tue, 26 Nov 2024 23:44:28 +0000 Subject: [PATCH v3 2/3] clk: qcom: common: Add support for power-domain attachment Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-2-836dad33521a@linaro.org> References: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> In-Reply-To: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-355e8 Right now we support one power-domain per clock controller. These single power-domains are switched on by the driver platform logic. However when we have multiple power-domains attached to a clock-controller that list of power-domains must be handled outside of driver platform logic. Use devm_pm_domain_attach_list() to automatically hook the list of given power-domains in the dtsi for the clock-controller driver. Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/common.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 33cc1f73c69d1f875a193aea0552902268dc8716..7727295c57c8f6672d46d2380e1= ff5ec2ac68d42 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -22,6 +22,7 @@ struct qcom_cc { struct qcom_reset_controller reset; struct clk_regmap **rclks; size_t num_rclks; + struct dev_pm_domain_list *pd_list; }; =20 const @@ -283,6 +284,21 @@ static int qcom_cc_icc_register(struct device *dev, desc->num_icc_hws, icd); } =20 +static int qcom_cc_pds_attach(struct device *dev, struct qcom_cc *cc) +{ + struct dev_pm_domain_attach_data pd_data =3D { + .pd_names =3D 0, + .num_pd_names =3D 0, + }; + int ret; + + ret =3D devm_pm_domain_attach_list(dev, &pd_data, &cc->pd_list); + if (ret < 0 && ret !=3D -EEXIST) + return ret; + + return 0; +} + int qcom_cc_really_probe(struct device *dev, const struct qcom_cc_desc *desc, struct regmap *regmap) { @@ -299,6 +315,10 @@ int qcom_cc_really_probe(struct device *dev, if (!cc) return -ENOMEM; =20 + ret =3D qcom_cc_pds_attach(dev, cc); + if (ret) + return ret; + reset =3D &cc->reset; reset->rcdev.of_node =3D dev->of_node; reset->rcdev.ops =3D &qcom_reset_ops; --=20 2.45.2 From nobody Mon Feb 9 15:40:21 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F244C1DFE35 for ; Tue, 26 Nov 2024 23:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664679; cv=none; b=pw4dVRP6giHsoF/+SvU28QFiQCj8v+2sIYwOYZpiZChEoUKML9X63Hf/RPCDvIXAZvp3eI7gjsclobKXwsVlm5OqZHn3Ro8DwNFyPyCSVm1vDIHp9Cs4Ywa982/R18Egasndvr/SgKPhvrd3tgqX0ZB/NWALL+B/s8q/IEyeOZI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732664679; c=relaxed/simple; bh=nVHGEOrRUdBNA5gRWj0sFzT9xtelcZ3Fgi3g7ZZhzww=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ClQUew+AO1t+FoQHZyIGaK+a6vtdp35fRymx0jg8XnZWyWMGSMliJi7Iy+2yUZqGpnRYSvVw0dnjRKG0mHmFqm2CIoFB9azrVl04qXdLcxY5Tm28bROY5ZIkzhhzNCMeLgmCFCP9NyqvyvWUGXVaHIXjXXdOV15j1rZBM248kcc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JxG539p/; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JxG539p/" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4349f160d62so25772855e9.2 for ; Tue, 26 Nov 2024 15:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732664676; x=1733269476; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QK080mMzdkSHpObUIjIterv6PuoIM1SQM8FNf9+Umao=; b=JxG539p/bnkKA/TwZTCcEQ7syyPsoN4yl43pdhfBegBFA+PKgVZhZdVR2Y2mPySnMN ENWByUqYgO9C0WRp8eJJKZ9TGUjQ7cxsNerfLjnsbI0ZZzOaT3yNT6AO57SGRIwuPEqV C3nfzjSQzWW6H0r/Zxq8RGwJ6iRW2kSeVBl1RG7Rr9oRxmam6LW7eZ/qd6neMQqHWkxp Tw7ehbmIhzQ9d6GbgStisa8NmDzARED90SfAeJv+jbzYP5ndHUggVD3RiaA7NhS+m8F/ /mRkY195lWjO9SHEntCsA3vS7V+RJO9gqqLyNGNE1pnzq8RZIDQ72mpEeGwVB26F00g6 wJJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732664676; x=1733269476; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QK080mMzdkSHpObUIjIterv6PuoIM1SQM8FNf9+Umao=; b=Blj1/pfB4EVLEzfgl+DI8pUNcJw+QPpyfhdpCTOkjPizHpR8B2tEjA+xflCnK6Dc4r plDc4CQf0b8xHfHnfTwbHkdf72mMn++s4PC5Y18Jfy6hEvsxpqUHdt3aWE459Vob+WZ1 oXZJk1OIE3jbxwHoS7puLfokBN8xrDTFG7+NneQdRw+PUPCfClzzWhgVARV73RM7MKuJ DE4ZJ+yBUKIFSAKyDpMpL/Rk4qjCJeUiLtUoKXBJmyCWinz97sdXq5zUgwUqtZq2zXG/ u+wBiBdMQvsFt9r2RvVfDCTt/ttjmwDSHSVU0f910qkVUMbiKY7qYR7X9OTcOEAItTXL d/ww== X-Forwarded-Encrypted: i=1; AJvYcCUvo7OISXuAAHM89QJItxqnBHMpnmuIXNAcrNyiJIOQaXRUuXq/3Hd6WWwjOUtsHqFaRgEawqcRdzyNM2c=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+0igWsl+LiqUcX+8k10AuW/XVPAJ2O4kd+FKJ+OMDS9h88dK9 qQa77jO6L5zOls8Mqcug/9mqVm95P7VeL0NYh6jnJi70mJ6RWPWNFfZlNeqHZbI= X-Gm-Gg: ASbGncubVuUgiY7kEZNmhPT0EdoDq9427DQRzEDOq3cFVC7CjO7zObA2XWaXjrEEvkV 9u4l1qPEQDFg2le7F+1jdrRfFSV5wwa5Ap9SMxnJEgY5ToqY1GbSkaLF2LlDFdI4vy96fEkSy46 v99NUalaghS6K1Px4imOKh7P9HYO/x6h5U9bFVDkuPTqpNw+ylh+9mEVuKw4Th6YqONxQxG05Vk 3X48NmT/Z0W5zd1SPjJF9IijGD23oWabM1IjZEW9MxYyfIAAkzMkz/tJUE= X-Google-Smtp-Source: AGHT+IGd+fjrVRUKvsVcA1pohdHvtSxuhDJA0UKE8GpD7PEO4QQLWsNHgyLqbxvvvkEfp+17KqBElA== X-Received: by 2002:a05:600c:1d18:b0:434:9936:c823 with SMTP id 5b1f17b1804b1-434a9dc694fmr9606295e9.18.1732664676497; Tue, 26 Nov 2024 15:44:36 -0800 (PST) Received: from [127.0.1.1] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fafe338sm14482899f8f.33.2024.11.26.15.44.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 15:44:35 -0800 (PST) From: Bryan O'Donoghue Date: Tue, 26 Nov 2024 23:44:29 +0000 Subject: [PATCH v3 3/3] driver: clk: qcom: Support attaching subdomain list to multiple parents Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-3-836dad33521a@linaro.org> References: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> In-Reply-To: <20241126-b4-linux-next-24-11-18-clock-multiple-power-domains-v3-0-836dad33521a@linaro.org> To: Bjorn Andersson , Michael Turquette , Stephen Boyd , Dmitry Baryshkov Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Bryan O'Donoghue X-Mailer: b4 0.15-dev-355e8 When a clock-controller has multiple power-domains we need to attach parent GDSCs in that clock-controller as subdomains of each of the power-domains. Signed-off-by: Bryan O'Donoghue --- drivers/clk/qcom/common.c | 1 + drivers/clk/qcom/gdsc.c | 35 +++++++++++++++++++++++++++++++++++ drivers/clk/qcom/gdsc.h | 1 + 3 files changed, 37 insertions(+) diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c index 7727295c57c8f6672d46d2380e1ff5ec2ac68d42..58a8397eefe51da237a4285d4e7= cee967e19948f 100644 --- a/drivers/clk/qcom/common.c +++ b/drivers/clk/qcom/common.c @@ -338,6 +338,7 @@ int qcom_cc_really_probe(struct device *dev, scd->dev =3D dev; scd->scs =3D desc->gdscs; scd->num =3D desc->num_gdscs; + scd->pd_list =3D cc->pd_list; ret =3D gdsc_register(scd, &reset->rcdev, regmap); if (ret) return ret; diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c index 4fc6f957d0b846cc90e50ef243f23a7a27e66899..cb4afa6d584899f3dafa380d5e0= 1be6de9711737 100644 --- a/drivers/clk/qcom/gdsc.c +++ b/drivers/clk/qcom/gdsc.c @@ -506,6 +506,36 @@ static int gdsc_init(struct gdsc *sc) return ret; } =20 +static int gdsc_add_subdomain_list(struct dev_pm_domain_list *pd_list, + struct generic_pm_domain *subdomain) +{ + int i, ret; + + for (i =3D 0; i < pd_list->num_pds; i++) { + struct device *dev =3D pd_list->pd_devs[i]; + struct generic_pm_domain *genpd =3D pd_to_genpd(dev->pm_domain); + + ret =3D pm_genpd_add_subdomain(genpd, subdomain); + if (ret) + return ret; + } + + return 0; +} + +static void gdsc_remove_subdomain_list(struct dev_pm_domain_list *pd_list, + struct generic_pm_domain *subdomain) +{ + int i; + + for (i =3D 0; i < pd_list->num_pds; i++) { + struct device *dev =3D pd_list->pd_devs[i]; + struct generic_pm_domain *genpd =3D pd_to_genpd(dev->pm_domain); + + pm_genpd_remove_subdomain(genpd, subdomain); + } +} + int gdsc_register(struct gdsc_desc *desc, struct reset_controller_dev *rcdev, struct regmap *regmap) { @@ -558,6 +588,9 @@ int gdsc_register(struct gdsc_desc *desc, ret =3D pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) ret =3D pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd= ); + else if (desc->pd_list) + ret =3D gdsc_add_subdomain_list(desc->pd_list, &scs[i]->pd); + if (ret) return ret; } @@ -580,6 +613,8 @@ void gdsc_unregister(struct gdsc_desc *desc) pm_genpd_remove_subdomain(scs[i]->parent, &scs[i]->pd); else if (!IS_ERR_OR_NULL(dev->pm_domain)) pm_genpd_remove_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); + else if (desc->pd_list) + gdsc_remove_subdomain_list(desc->pd_list, &scs[i]->pd); } of_genpd_del_provider(dev->of_node); } diff --git a/drivers/clk/qcom/gdsc.h b/drivers/clk/qcom/gdsc.h index 1e2779b823d1c8ca077c9b4cd0a0dbdf5f9457ef..dd843e86c05b2f30e6d9e978681= 580016333839d 100644 --- a/drivers/clk/qcom/gdsc.h +++ b/drivers/clk/qcom/gdsc.h @@ -80,6 +80,7 @@ struct gdsc_desc { struct device *dev; struct gdsc **scs; size_t num; + struct dev_pm_domain_list *pd_list; }; =20 #ifdef CONFIG_QCOM_GDSC --=20 2.45.2