From nobody Sun Nov 24 05:34:57 2024 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1C271CF5D4; Thu, 21 Nov 2024 11:54:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732190065; cv=none; b=XCDoHMB2RXxfdVm4JwcvtGUnDlUh2kAQUSl7gF/iYebmzdXC6iZxuFH6OYEVQqe3/JyIo/qdlDzl0aG7d15asi7zzqyVsGqlQ1IkbIT7n+0gZGDzSJcBUtZnaH2rFrAAR/ngAJR5AwDds+VnNjc2eN0+GAz2T7RVgVNYGmXpOns= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732190065; c=relaxed/simple; bh=GA+riEPnI10/xWsNFm8z78mAIS3Moz8d5/rbC4MCogA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=rjI4uOmb1CWA3c1TOGPaWZtQauZVHv9gZjGWN2FpnLMdkDiOkl4Y7sVx1jGJrhw+JsTqH/tpRHOKik7ha8i5xwieo+S3ZmOnQvazqzYisDx9uRX3MMacbOWew2KuzfZ2ivdEeCBu7ehI3bYDQkpYZT6amhx57tZ3Fq+L93wmcsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=QgTE7EH9; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="QgTE7EH9" Received: from ldvnode.intra.ispras.ru (unknown [10.10.2.153]) by mail.ispras.ru (Postfix) with ESMTPSA id C147F518E763; Thu, 21 Nov 2024 11:47:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru C147F518E763 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1732189660; bh=4kSpGNx4NEEFrF0ZMmnj2iC3dLzPzs1+TqbYsa2ECRM=; h=From:To:Cc:Subject:Date:From; b=QgTE7EH9jvkqd/hyYBk8H/UXwFa2wQAFJE9vVejIsSLkOeHp7Gjh3Vwa6DTYkLqjg OMN9j0bAfak3oQP/swIZ1A36QKBXxslAXYPEqffNToKkzFDTh8f9Y7FIUbOLPYpHJT IH83O/SZR4CH3jIurVcLnVPkwJyfnETgNdm4hy+w= From: Vitalii Mordan To: Alan Stern Cc: Vitalii Mordan , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , linux-sh@vger.kernel.org, Fedor Pchelkin , Alexey Khoroshilov , Vadim Mutilin , stable@vger.kernel.org Subject: [PATCH] usb: ehci-hcd: fix call balance of clocks handling routines Date: Thu, 21 Nov 2024 14:47:00 +0300 Message-Id: <20241121114700.2100520-1-mordan@ispras.ru> X-Mailer: git-send-email 2.25.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If the clocks priv->iclk and priv->fclk were not enabled in ehci_hcd_sh_pro= be, they should not be disabled in any path. Conversely, if they was enabled in ehci_hcd_sh_probe, they must be disabled in all error paths to ensure proper cleanup. Found by Linux Verification Center (linuxtesting.org) with Klever. Fixes: 63c845522263 ("usb: ehci-hcd: Add support for SuperH EHCI.") Cc: stable@vger.kernel.org # ff30bd6a6618: sh: clk: Fix clk_enable() to ret= urn 0 on NULL clk Signed-off-by: Vitalii Mordan Reviewed-by: Alan Stern --- drivers/usb/host/ehci-sh.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c index d31d9506e41a..77460aac6dbd 100644 --- a/drivers/usb/host/ehci-sh.c +++ b/drivers/usb/host/ehci-sh.c @@ -119,8 +119,12 @@ static int ehci_hcd_sh_probe(struct platform_device *p= dev) if (IS_ERR(priv->iclk)) priv->iclk =3D NULL; =20 - clk_enable(priv->fclk); - clk_enable(priv->iclk); + ret =3D clk_enable(priv->fclk); + if (ret) + goto fail_request_resource; + ret =3D clk_enable(priv->iclk); + if (ret) + goto fail_iclk; =20 ret =3D usb_add_hcd(hcd, irq, IRQF_SHARED); if (ret !=3D 0) { @@ -136,6 +140,7 @@ static int ehci_hcd_sh_probe(struct platform_device *pd= ev) =20 fail_add_hcd: clk_disable(priv->iclk); +fail_iclk: clk_disable(priv->fclk); =20 fail_request_resource: --=20 2.25.1