From nobody Mon Nov 25 16:52:06 2024 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16FD374C14; Wed, 20 Nov 2024 01:11:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732065103; cv=none; b=ANakz38nFLw1rh44EoBlOV/nwDcBdT2tJaAdGbfI8F/DsCPx68NQQ/XAW52yjsDcfBY2eR29wns6ApShax8BE1aGnE6BagdQCRAJfUgVUhWs56V2Ya6qyXvcjTFMhi7ijSRqr4x1UqsYTl5XcR901aP50coZfnl+DyCCsiihPmw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1732065103; c=relaxed/simple; bh=SzQ9MsCK3IvY/ogi6ri7XaGysw8Fenuk1opsDdO6OkI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e2NjOtiTD+3dz7ckekWScNvq0kn7NXPSSn4SMBGqqQgPbU0sZHlv//W2hiVxKYdcHZkogGQ4opXQzMaeW/qbhAOyPqQmICKoVMmrN2nXAnM9VJpNZ2Xvk+noPv7j7Qwk196PXf/pY521oMN2QOdMBUwixtwK6UmnEHzskUta8s0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PVCPe7Tx; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PVCPe7Tx" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1732065102; x=1763601102; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=SzQ9MsCK3IvY/ogi6ri7XaGysw8Fenuk1opsDdO6OkI=; b=PVCPe7Txr4Xa/Z3UxdrM1nwaqkHqq8PNmD/2Pb/B5v7P9+9hJgzLiBiJ yInkwsnfSgqvlANWcRlY3/JGQ3wpdLWkzxhfkklTmIt0ghMWlXj8AybD4 +Ipt0rJNRGrH0+lxNZwRrCA40Olz6fmjBleZ5aB02e/LuzZweXd5bS9fV ZiAfxfeu/qZ4DxJ8RJkhLNEulIm2pnXSwgnMDTNlibW86oOPaozOgL6An PYDi8OBMk9c9MFdfAY/PdByyPkfygRBqce6cUaEcMN9cA1K37xzHVWbGy NadcNc5/Wbq/uARxWsUNwciq9FvOMO2vHcAl3AR6EChsMmNcRn6vbMXYO w==; X-CSE-ConnectionGUID: DRZN6iu4RDW4QvMuLeZ4tg== X-CSE-MsgGUID: F5nEUOcBQaSJL+IDjKN7/w== X-IronPort-AV: E=McAfee;i="6700,10204,11261"; a="42612986" X-IronPort-AV: E=Sophos;i="6.12,168,1728975600"; d="scan'208";a="42612986" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 17:11:40 -0800 X-CSE-ConnectionGUID: ACgXJOB3S4Cud0dqmM8PQg== X-CSE-MsgGUID: LDUINnjVTGOdUxy3u2trtw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,168,1728975600"; d="scan'208";a="93813581" Received: from sj-4150-psse-sw-opae-dev3.sj.altera.com ([10.244.138.109]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2024 17:11:39 -0800 From: Peter Colberg To: Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Russ Weight , Marco Pagani , Matthew Gerlach , Basheer Ahmed Muddebihal , Peter Colberg Subject: [PATCH v5 06/18] fpga: dfl: factor out feature data creation from build_info_commit_dev() Date: Tue, 19 Nov 2024 20:10:22 -0500 Message-ID: <20241120011035.230574-7-peter.colberg@intel.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241120011035.230574-1-peter.colberg@intel.com> References: <20241120011035.230574-1-peter.colberg@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a separate function, binfo_create_feature_dev_data(), which allocates and populates the feature platform data, and call the function from build_info_commit_dev(), which registers the feature platform device. Signed-off-by: Peter Colberg Reviewed-by: Matthew Gerlach Reviewed-by: Basheer Ahmed Muddebihal Acked-by: Xu Yilun --- Changes since v4: - No changes. Changes since v3: - Replace ERR_PTR(PTR_ERR(feature->ioaddr) with feature->ioaddr and remove unneeded local variable ret. - Add missing commas in description. Changes since v2: - New patch extracted from monolithic v1 patch. --- drivers/fpga/dfl.c | 72 +++++++++++++++++++++++++--------------------- 1 file changed, 40 insertions(+), 32 deletions(-) diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index 4c79d433d216..56a32f5146a3 100644 --- a/drivers/fpga/dfl.c +++ b/drivers/fpga/dfl.c @@ -749,22 +749,18 @@ static void dfl_fpga_cdev_add_port_data(struct dfl_fp= ga_cdev *cdev, mutex_unlock(&cdev->lock); } =20 -/* - * register current feature device, it is called when we need to switch to - * another feature parsing or we have parsed all features on given device - * feature list. - */ -static int build_info_commit_dev(struct build_feature_devs_info *binfo) +static struct dfl_feature_platform_data * +binfo_create_feature_dev_data(struct build_feature_devs_info *binfo) { struct platform_device *fdev =3D binfo->feature_dev; struct dfl_feature_platform_data *pdata; struct dfl_feature_info *finfo, *p; enum dfl_id_type type; - int ret, index =3D 0, res_idx =3D 0; + int index =3D 0, res_idx =3D 0; =20 type =3D feature_dev_id_type(fdev); if (WARN_ON_ONCE(type >=3D DFL_ID_MAX)) - return -EINVAL; + return ERR_PTR(-EINVAL); =20 /* * we do not need to care for the memory which is associated with @@ -774,7 +770,7 @@ static int build_info_commit_dev(struct build_feature_d= evs_info *binfo) */ pdata =3D kzalloc(struct_size(pdata, features, binfo->feature_num), GFP_K= ERNEL); if (!pdata) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 pdata->dev =3D fdev; pdata->num =3D binfo->feature_num; @@ -799,7 +795,7 @@ static int build_info_commit_dev(struct build_feature_d= evs_info *binfo) fdev->resource =3D kcalloc(binfo->feature_num, sizeof(*fdev->resource), GFP_KERNEL); if (!fdev->resource) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 /* fill features and resource information for feature dev */ list_for_each_entry_safe(finfo, p, &binfo->sub_features, node) { @@ -818,7 +814,7 @@ static int build_info_commit_dev(struct build_feature_d= evs_info *binfo) finfo->params, finfo->param_size, GFP_KERNEL); if (!feature->params) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 feature->param_size =3D finfo->param_size; } @@ -835,7 +831,7 @@ static int build_info_commit_dev(struct build_feature_d= evs_info *binfo) devm_ioremap_resource(binfo->dev, &finfo->mmio_res); if (IS_ERR(feature->ioaddr)) - return PTR_ERR(feature->ioaddr); + return feature->ioaddr; } else { feature->resource_index =3D res_idx; fdev->resource[res_idx++] =3D finfo->mmio_res; @@ -845,7 +841,7 @@ static int build_info_commit_dev(struct build_feature_d= evs_info *binfo) ctx =3D devm_kcalloc(binfo->dev, finfo->nr_irqs, sizeof(*ctx), GFP_KERNEL); if (!ctx) - return -ENOMEM; + return ERR_PTR(-ENOMEM); =20 for (i =3D 0; i < finfo->nr_irqs; i++) ctx[i].irq =3D @@ -859,25 +855,7 @@ static int build_info_commit_dev(struct build_feature_= devs_info *binfo) kfree(finfo); } =20 - ret =3D platform_device_add(binfo->feature_dev); - if (!ret) { - if (type =3D=3D PORT_ID) - dfl_fpga_cdev_add_port_data(binfo->cdev, - pdata); - else - binfo->cdev->fme_dev =3D - get_device(&binfo->feature_dev->dev); - /* - * reset it to avoid build_info_free() freeing their resource. - * - * The resource of successfully registered feature devices - * will be freed by platform_device_unregister(). See the - * comments in build_info_create_dev(). - */ - binfo->feature_dev =3D NULL; - } - - return ret; + return pdata; } =20 static int @@ -912,6 +890,36 @@ build_info_create_dev(struct build_feature_devs_info *= binfo, return 0; } =20 +static int build_info_commit_dev(struct build_feature_devs_info *binfo) +{ + struct dfl_feature_platform_data *pdata; + int ret; + + pdata =3D binfo_create_feature_dev_data(binfo); + if (IS_ERR(pdata)) + return PTR_ERR(pdata); + + ret =3D platform_device_add(binfo->feature_dev); + if (ret) + return ret; + + if (feature_dev_id_type(binfo->feature_dev) =3D=3D PORT_ID) + dfl_fpga_cdev_add_port_data(binfo->cdev, pdata); + else + binfo->cdev->fme_dev =3D get_device(&binfo->feature_dev->dev); + + /* + * reset it to avoid build_info_free() freeing their resource. + * + * The resource of successfully registered feature devices + * will be freed by platform_device_unregister(). See the + * comments in build_info_create_dev(). + */ + binfo->feature_dev =3D NULL; + + return 0; +} + static void build_info_free(struct build_feature_devs_info *binfo) { struct dfl_feature_info *finfo, *p; --=20 2.47.0