From nobody Sun Nov 24 23:43:28 2024 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC0361E7663; Thu, 14 Nov 2024 02:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731551390; cv=none; b=SIjjuHAgoYFrc6m47X90CAgt07NN+gPEdqSYwApUoXkbY2g+CGb7jObUkSGlbI4ac0VSMMhQZVxmz/To0/xo/Nqq0nrvNtBgfGXKA27gVyVyBGh2HCp30w7yzqn+a3TiBI+YoEuNCif24g+OX3Wj3CZ+K24yAQFTOvArTnv0vYE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731551390; c=relaxed/simple; bh=giPc/kImraaOj3inDnO2hOUlyhXSOz6rT5Fiy2weFpA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=dT119omagiznKHCgxx53Ag2rZLhhQ93ls+brbc+zzKC6V3pH8YGWjFBKd4vLC/wDp14MM6Ju4NeNJJKvB+QL2g0GihZogzqZdMrzW2pAFlSZXDxrFO9nJHTrikk2OZMu7JGbibwHGRMUphMXx4cwnPatyOiVIO3SzG6tw4v8Rzw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=VRqUb8rX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="VRqUb8rX" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ADMkOPP025933; Thu, 14 Nov 2024 02:29:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= r7Po/FwQThiBsQWRxYcauOHGQZjpnBIU7A93c7fpQdY=; b=VRqUb8rXcHkBS5XX MTOaF+PtySELj6nNPWDwbbXASdL+JO2wfONwTYHJa6LauTQ23mbLZO9BVe2vpiJ1 LVAlRzvd9UixrQ0hoT6Qa1L4Jk6adrDGVmueCEwJ0vxcCglvorq1UN0OC3sV32TC e4OpKORpooGq+yQhBscGfhI5qiIKTc/Is/xoLnThcy8++gBeSHSuWph6Ii5vZto+ V0qXNd4jo3IKko7nW83HYtBIjzwohzO94kcCeFbT+JSHDwLR2sfR4N7p5zJVvasp GtRDyA97V7z12LsWPhseOjXubw5Ka6D+DM5SyYd2o4nAZ19+0qS69z8YgsIAjtZK GbnyNw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42vkvrb9kv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2024 02:29:40 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4AE2TdNj026874 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 14 Nov 2024 02:29:39 GMT Received: from hu-sibis-blr.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 13 Nov 2024 18:29:35 -0800 From: Sibi Sankar To: , , , , , , , , CC: , , , , , Sibi Sankar Subject: [PATCH V8 1/1] cpufreq: scmi: Register for limit change notifications Date: Thu, 14 Nov 2024 07:59:16 +0530 Message-ID: <20241114022916.644899-2-quic_sibis@quicinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241114022916.644899-1-quic_sibis@quicinc.com> References: <20241114022916.644899-1-quic_sibis@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: l5ZyfhjEhTE5y1n7Shqs0WijiK8vafjL X-Proofpoint-GUID: l5ZyfhjEhTE5y1n7Shqs0WijiK8vafjL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 phishscore=0 suspectscore=0 spamscore=0 mlxlogscore=999 priorityscore=1501 bulkscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411140017 Content-Type: text/plain; charset="utf-8" Register for limit change notifications if supported and use the throttled frequency from the notification to apply HW pressure. Signed-off-by: Sibi Sankar Tested-by: Mike Tipton Reviewed-by: Cristian Marussi Reviewed-by: Lukasz Luba Acked-by: Vincent Guittot --- v8: * Drop patch 1 since it was picked up by Viresh * Leave policy->max update to the cpufreq_qos notifier [Vincent] * We sanitized the range_max from V3 since we dealt with policy->max, now we can drop the check and policy member from scmi_data. drivers/cpufreq/scmi-cpufreq.c | 45 ++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c index 07d6f9a9b7c8..b8fe758aeb01 100644 --- a/drivers/cpufreq/scmi-cpufreq.c +++ b/drivers/cpufreq/scmi-cpufreq.c @@ -16,6 +16,7 @@ #include #include #include +#include #include #include #include @@ -26,6 +27,8 @@ struct scmi_data { int nr_opp; struct device *cpu_dev; cpumask_var_t opp_shared_cpus; + struct notifier_block limit_notify_nb; + struct freq_qos_request limits_freq_req; }; =20 static struct scmi_protocol_handle *ph; @@ -174,6 +177,22 @@ static struct freq_attr *scmi_cpufreq_hw_attr[] =3D { NULL, }; =20 +static int scmi_limit_notify_cb(struct notifier_block *nb, unsigned long e= vent, void *data) +{ + struct scmi_data *priv =3D container_of(nb, struct scmi_data, limit_notif= y_nb); + struct scmi_perf_limits_report *limit_notify =3D data; + unsigned int limit_freq_khz; + int ret; + + limit_freq_khz =3D limit_notify->range_max_freq / HZ_PER_KHZ; + + ret =3D freq_qos_update_request(&priv->limits_freq_req, limit_freq_khz); + if (ret < 0) + pr_warn("failed to update freq constraint: %d\n", ret); + + return NOTIFY_OK; +} + static int scmi_cpufreq_init(struct cpufreq_policy *policy) { int ret, nr_opp, domain; @@ -181,6 +200,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *pol= icy) struct device *cpu_dev; struct scmi_data *priv; struct cpufreq_frequency_table *freq_table; + struct scmi_device *sdev =3D cpufreq_get_driver_data(); =20 cpu_dev =3D get_cpu_device(policy->cpu); if (!cpu_dev) { @@ -294,6 +314,23 @@ static int scmi_cpufreq_init(struct cpufreq_policy *po= licy) } } =20 + ret =3D freq_qos_add_request(&policy->constraints, &priv->limits_freq_req= , FREQ_QOS_MAX, + FREQ_QOS_MAX_DEFAULT_VALUE); + if (ret < 0) { + dev_err(cpu_dev, "failed to add qos limits request: %d\n", ret); + goto out_free_table; + } + + priv->limit_notify_nb.notifier_call =3D scmi_limit_notify_cb; + ret =3D sdev->handle->notify_ops->event_notifier_register(sdev->handle, S= CMI_PROTOCOL_PERF, + SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED, + &priv->domain_id, + &priv->limit_notify_nb); + if (ret) + dev_warn(&sdev->dev, + "failed to register for limits change notifier for domain %d\n", + priv->domain_id); + return 0; =20 out_free_table: @@ -313,7 +350,13 @@ static int scmi_cpufreq_init(struct cpufreq_policy *po= licy) static void scmi_cpufreq_exit(struct cpufreq_policy *policy) { struct scmi_data *priv =3D policy->driver_data; + struct scmi_device *sdev =3D cpufreq_get_driver_data(); =20 + sdev->handle->notify_ops->event_notifier_unregister(sdev->handle, SCMI_PR= OTOCOL_PERF, + SCMI_EVENT_PERFORMANCE_LIMITS_CHANGED, + &priv->domain_id, + &priv->limit_notify_nb); + freq_qos_remove_request(&priv->limits_freq_req); dev_pm_opp_free_cpufreq_table(priv->cpu_dev, &policy->freq_table); dev_pm_opp_remove_all_dynamic(priv->cpu_dev); free_cpumask_var(priv->opp_shared_cpus); @@ -372,6 +415,8 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev) if (!handle) return -ENODEV; =20 + scmi_cpufreq_driver.driver_data =3D sdev; + perf_ops =3D handle->devm_protocol_get(sdev, SCMI_PROTOCOL_PERF, &ph); if (IS_ERR(perf_ops)) return PTR_ERR(perf_ops); --=20 2.34.1