From nobody Sat Nov 23 08:34:18 2024 Received: from smtp.ps-zuehlke.com (smtp.ps-zuehlke.com [193.135.254.84]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 90C8D1F6662; Thu, 14 Nov 2024 08:10:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.135.254.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731571808; cv=none; b=vCCktR1bhZeZfUsE4DrDpaYP9ZjTCNtsstRZ/PBgP1yy6dQKTMpzE2cTa2k3VO2wcVbxqzHajqwUQLVELnaY70DqzeC6EOgQ81cRWJ9W8b5aUoXCiqdwgtyqtwQtQaYIvPnapT6QynO496NAQiDUFoGu0puVJ0f/uul1iHdi0mA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731571808; c=relaxed/simple; bh=MMFNcDZl1O95DgMDsY1PAL4cRz865YcySfeAV8FEz+w=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Alu549Ef6NEksP3TekbhsoDccOuzfey7Uah3HyCAcDQjKiHeNYw7R1gHJgLzbBEucbEJ/kzpPhmMZ7i3lgZKfD5AZLJg6WimM7fqzG1WEAk633MSvSej82kYxTIss3zYT8wEHcqL2klIJhk3axiUTeUsNjiyTJiNCqxDZe6D14w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zuehlke.com; spf=pass smtp.mailfrom=zuehlke.com; arc=none smtp.client-ip=193.135.254.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=zuehlke.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=zuehlke.com Received: from ZUEN49445. (unknown [10.192.66.22]) by smtp.ps-zuehlke.com (Postfix) with ESMTP id 7748B129; Thu, 14 Nov 2024 09:02:22 +0100 (CET) From: Oliver Facklam Date: Thu, 14 Nov 2024 09:02:07 +0100 Subject: [PATCH v2 2/4] usb: typec: hd3ss3220: use typec_get_fw_cap() to fill typec_cap Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241114-usb-typec-controller-enhancements-v2-2-362376856aea@zuehlke.com> References: <20241114-usb-typec-controller-enhancements-v2-0-362376856aea@zuehlke.com> In-Reply-To: <20241114-usb-typec-controller-enhancements-v2-0-362376856aea@zuehlke.com> To: Heikki Krogerus , Biju Das , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Benedict von Heyl , Mathis Foerst , Michael Glettig , Oliver Facklam X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1731571341; l=1216; i=oliver.facklam@zuehlke.com; s=20241107; h=from:subject:message-id; bh=MMFNcDZl1O95DgMDsY1PAL4cRz865YcySfeAV8FEz+w=; b=8yynHsCy9WVM4CVOzaSXunNk89Nd1jajct9/wsLrGRXDuGUoRMHTO97bvd81Oev+lRCuPAQbE Js5ejRVBywsA4ISKgnmvvHIpSEkcX5aXBLzBn3Fz+QlJyV8I1+9yMGu X-Developer-Key: i=oliver.facklam@zuehlke.com; a=ed25519; pk=bMlB+nko+ewJHQJLwq2t26VDbmRmNDPr/1woleqp7Lw= The type, data, and prefer_role properties were previously hard-coded when creating the struct typec_capability. Use typec_get_fw_cap() to populate these fields based on the respective fwnode properties, if present. Signed-off-by: Oliver Facklam Reviewed-by: Heikki Krogerus --- drivers/usb/typec/hd3ss3220.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/hd3ss3220.c b/drivers/usb/typec/hd3ss3220.c index 56f74bf70895ca701083bde44a5bbe0b691551e1..e581272bb47de95dee8363a5491= f543354fcbbf8 100644 --- a/drivers/usb/typec/hd3ss3220.c +++ b/drivers/usb/typec/hd3ss3220.c @@ -264,7 +264,14 @@ static int hd3ss3220_probe(struct i2c_client *client) typec_cap.type =3D TYPEC_PORT_DRP; typec_cap.data =3D TYPEC_PORT_DRD; typec_cap.ops =3D &hd3ss3220_ops; - typec_cap.fwnode =3D connector; + + /* + * Try to get properties from connector, + * but continue with defaults anyway if they are not found + */ + ret =3D typec_get_fw_cap(&typec_cap, connector); + if (ret !=3D 0 && ret !=3D -EINVAL && ret !=3D -ENXIO) + goto err_put_role; =20 hd3ss3220->port =3D typec_register_port(&client->dev, &typec_cap); if (IS_ERR(hd3ss3220->port)) { --=20 2.34.1