From nobody Sat Nov 23 18:43:23 2024 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B218522EE46 for ; Tue, 12 Nov 2024 10:39:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407954; cv=none; b=r3/jfGz6Of9YDl7RYJGdPTkQWz1rCn0gh08Hmz/rEINiWlUBQ5fay9z0JRgL47h3TlcRimLpHSdETb5f/Q5mQm4GrvxkDLxoBq8Hi8rRfvNnTkJumyTl0HRn1hKDbaBOA0/SJaP2vWapJRYBD7plR5dLOw7A7an4Z3MWVOkFdQo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731407954; c=relaxed/simple; bh=pMtsPPkR/TZ2GwbF+ikIZ8cONXgj2KQRbInBexTV9Hg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lsB3G+vX3NmyM/kxbQffVqEv4XBWl53rpsYDk84bvb5FGDAkTSaAAHEUYgQQKZAkQ4OD0Eofy2tV1+lBkHPyAbyQKEwyodPG+RRusAxxwlvwU44B03aZe+T0RRo4vfpIEUdgS6hMrkgh1YShTcpDOjGf4+rU/FgL3JdcwqyaKnk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zJo3IFGM; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zJo3IFGM" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-539ebb5a20aso5986999e87.2 for ; Tue, 12 Nov 2024 02:39:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731407950; x=1732012750; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3ypieNLjv9hoDv5n/xchGDgtSOzf0gFSsJH7dIkvwXY=; b=zJo3IFGM5xAp4EFkCOFrMJBoeWpNxyY5tnpSwaorpHA2+fgDa0RuhqCQvZlalEnuv+ /VTVBWYcumvTTfZpTCF2JiUK86RgW2eqVXogvGG6dvThts56mrobW8bfbtQO0oX478fi 1yVRxp4u4IzLwQkorBDzKC9A58iSbOvXw+iYJ+D58sYst4597K8sEHlOWBJSui/dcDly JsaH2olKYzq0skLLPq9aV7wE7ypQhTrsJtypV7NMgqS5qGHjZSFguUnCHf8ytxQjeH3o 2BzMPV1/4l/GUt5FmEnUhOlJ12WuoJwloSwExanbG3Sj6aQjtGjyu33/I0U5KEajYwRP 5DQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731407950; x=1732012750; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3ypieNLjv9hoDv5n/xchGDgtSOzf0gFSsJH7dIkvwXY=; b=hgP8PPWQ8HCYAhDzY2sW45ZseimEgbcNCmJRg4tFNrzoEh5rfmomTUBWAxrnfWi1Fp HGah3/uNtyOaVtGra0gAPiJ0Hk6a8b4RYqNf9Ed97Kie0cMAJyuGEji8DkcCgrmiqUwR ZLor8KD8bzA+2hBfG9Za1GLImX1gM9PTzrBSmOrHsgfo1CUR17GFtVKOZAmggL3A821W Sm7E/cHAvGAu8QGb7lAqGaUVK8DbOUkQ8z04jawUQk0+Bmpx+ag4QHdYbPzmfne7lotW pr/YzmTxDFSENc2FXqSfyzoEOfmlHdVreZye4kQTJ+0vOGpz0MgiO9h3LhlViicHKjGr G4tA== X-Forwarded-Encrypted: i=1; AJvYcCUV/45ewInl7y1zHxHZbjjGdkQ6aYGejHf/lV1r9jUJSXECXlzpGDoyJUgjueDKjSxE+hoRUJR3R9YSpio=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlr55jSt+EAQ1G4RMBadkGskrKgFC+6UokHOG06EDI78QMJapF 1yZpl4actzTra/oDeCK/b878h2IDjqfIvPKasZRAsW78Lx/Q2AtXzhwRu1QWM1c= X-Google-Smtp-Source: AGHT+IHSYTMPa2/VMqq86Adc2dUVIbc8G1yKZTl0omP+kqjQjHeg+DHnbhm+3rJYolYmdWgjyHudRg== X-Received: by 2002:a05:6512:1395:b0:539:959e:f0e8 with SMTP id 2adb3069b0e04-53d862d3f7dmr8300391e87.21.1731407950470; Tue, 12 Nov 2024 02:39:10 -0800 (PST) Received: from pop-os.. ([145.224.90.214]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432bbf436ffsm142270955e9.44.2024.11.12.02.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2024 02:39:10 -0800 (PST) From: James Clark To: suzuki.poulose@arm.com, oliver.upton@linux.dev, coresight@lists.linaro.org, kvmarm@lists.linux.dev Cc: James Clark , James Clark , Marc Zyngier , Joey Gouly , Zenghui Yu , Catalin Marinas , Will Deacon , Mike Leach , Alexander Shishkin , Mark Rutland , Anshuman Khandual , Fuad Tabba , Shiqi Liu , James Morse , Mark Brown , Raghavendra Rao Ananta , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 12/12] coresight: Pass guest TRFCR value to KVM Date: Tue, 12 Nov 2024 10:37:11 +0000 Message-Id: <20241112103717.589952-13-james.clark@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241112103717.589952-1-james.clark@linaro.org> References: <20241112103717.589952-1-james.clark@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: James Clark Currently the userspace and kernel filters for guests are never set, so no trace will be generated for them. Add support for tracing guests by passing the desired TRFCR value to KVM so it can be applied to the guest. By writing either E1TRE or E0TRE, filtering on either guest kernel or guest userspace is also supported. And if both E1TRE and E0TRE are cleared when exclude_guest is set, that option is supported too. This change also brings exclude_host support which is difficult to add as a separate commit without excess churn and resulting in no trace at all. Testing =3D=3D=3D=3D=3D=3D=3D The addresses were counted with the following: $ perf report -D | grep -Eo 'EL2|EL1|EL0' | sort | uniq -c Guest kernel only: $ perf record -e cs_etm//Gk -a -- true 535 EL1 1 EL2 Guest user only (only 5 addresses because the guest runs slowly in the model): $ perf record -e cs_etm//Gu -a -- true 5 EL0 Host kernel only: $ perf record -e cs_etm//Hk -a -- true 3501 EL2 Host userspace only: $ perf record -e cs_etm//Hu -a -- true 408 EL0 1 EL2 Reviewed-by: Suzuki K Poulose Signed-off-by: James Clark Signed-off-by: James Clark --- .../coresight/coresight-etm4x-core.c | 43 ++++++++++++++++--- drivers/hwtracing/coresight/coresight-etm4x.h | 2 +- drivers/hwtracing/coresight/coresight-priv.h | 3 ++ 3 files changed, 41 insertions(+), 7 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/h= wtracing/coresight/coresight-etm4x-core.c index 66d44a404ad0..347dea49a996 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include #include @@ -271,9 +272,23 @@ static void etm4x_prohibit_trace(struct etmv4_drvdata = *drvdata) /* If the CPU doesn't support FEAT_TRF, nothing to do */ if (!drvdata->trfcr) return; + + kvm_set_trfcr(0, 0); cpu_prohibit_trace(); } =20 +static u64 etm4x_get_kern_user_filter(struct etmv4_drvdata *drvdata) +{ + u64 trfcr =3D drvdata->trfcr; + + if (drvdata->config.mode & ETM_MODE_EXCL_KERN) + trfcr &=3D ~TRFCR_ELx_ExTRE; + if (drvdata->config.mode & ETM_MODE_EXCL_USER) + trfcr &=3D ~TRFCR_ELx_E0TRE; + + return trfcr; +} + /* * etm4x_allow_trace - Allow CPU tracing in the respective ELs, * as configured by the drvdata->config.mode for the current @@ -286,18 +301,28 @@ static void etm4x_prohibit_trace(struct etmv4_drvdata= *drvdata) */ static void etm4x_allow_trace(struct etmv4_drvdata *drvdata) { - u64 trfcr =3D drvdata->trfcr; + u64 trfcr, guest_trfcr; =20 /* If the CPU doesn't support FEAT_TRF, nothing to do */ - if (!trfcr) + if (!drvdata->trfcr) return; =20 - if (drvdata->config.mode & ETM_MODE_EXCL_KERN) - trfcr &=3D ~TRFCR_ELx_ExTRE; - if (drvdata->config.mode & ETM_MODE_EXCL_USER) - trfcr &=3D ~TRFCR_ELx_E0TRE; + if (drvdata->config.mode & ETM_MODE_EXCL_HOST) + trfcr =3D drvdata->trfcr & ~(TRFCR_ELx_ExTRE | TRFCR_ELx_E0TRE); + else + trfcr =3D etm4x_get_kern_user_filter(drvdata); =20 write_trfcr(trfcr); + + /* Set filters for guests and pass to KVM */ + if (drvdata->config.mode & ETM_MODE_EXCL_GUEST) + guest_trfcr =3D drvdata->trfcr & ~(TRFCR_ELx_ExTRE | TRFCR_ELx_E0TRE); + else + guest_trfcr =3D etm4x_get_kern_user_filter(drvdata); + + /* TRFCR_EL1 doesn't have CX so mask it out. */ + guest_trfcr &=3D ~TRFCR_EL2_CX; + kvm_set_trfcr(trfcr, guest_trfcr); } =20 #ifdef CONFIG_ETM4X_IMPDEF_FEATURE @@ -655,6 +680,12 @@ static int etm4_parse_event_config(struct coresight_de= vice *csdev, if (attr->exclude_user) config->mode =3D ETM_MODE_EXCL_USER; =20 + if (attr->exclude_host) + config->mode |=3D ETM_MODE_EXCL_HOST; + + if (attr->exclude_guest) + config->mode |=3D ETM_MODE_EXCL_GUEST; + /* Always start from the default config */ etm4_set_default_config(config); =20 diff --git a/drivers/hwtracing/coresight/coresight-etm4x.h b/drivers/hwtrac= ing/coresight/coresight-etm4x.h index 9e9165f62e81..1119762b5cec 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.h +++ b/drivers/hwtracing/coresight/coresight-etm4x.h @@ -817,7 +817,7 @@ enum etm_impdef_type { * @s_ex_level: Secure ELs where tracing is supported. */ struct etmv4_config { - u32 mode; + u64 mode; u32 pe_sel; u32 cfg; u32 eventctrl0; diff --git a/drivers/hwtracing/coresight/coresight-priv.h b/drivers/hwtraci= ng/coresight/coresight-priv.h index 05f891ca6b5c..76403530f33e 100644 --- a/drivers/hwtracing/coresight/coresight-priv.h +++ b/drivers/hwtracing/coresight/coresight-priv.h @@ -42,6 +42,9 @@ extern const struct device_type coresight_dev_type[]; =20 #define ETM_MODE_EXCL_KERN BIT(30) #define ETM_MODE_EXCL_USER BIT(31) +#define ETM_MODE_EXCL_HOST BIT(32) +#define ETM_MODE_EXCL_GUEST BIT(33) + struct cs_pair_attribute { struct device_attribute attr; u32 lo_off; --=20 2.34.1