From nobody Sat Nov 23 19:26:33 2024 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82E4415B554; Mon, 11 Nov 2024 10:46:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731321970; cv=none; b=PDwRq1uUbi3hs2hHe3YTCiZ7/GhS07r2pvAZ2CzoP5DZV+bb/UlJCxy2cUHxKfAonOuy4DwZkl0UmsirBgHTsR8wnsNxJ0641ytF/mgvEqxnoiHR/0ScfsuIueQYvkAfl+Mp+/NCBDVcjc7Ou62RUmGxsWDkdy8rl3M+S/o4i7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731321970; c=relaxed/simple; bh=5o6ue3Y/9WUhxE5zoGBuUR1NiMa8Zm6mQizx/j1vSgs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=mpeMLPAWyA0y0Zym6l41VZ+auIxS0EZMQIKnU9snSB4KRAQVS47szVDiL9T2dE9PcPKKok5b62EEWfMiLIRNI+QtqKl+Ie8IBPNGu82WWP7yd+bNgbmPNvDNBMXggMVSqDvZjJjoPxL+zoiAuhGj37L2zzjGqI/sMu4bCSWaJts= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u0sWa1bv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u0sWa1bv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 47AD3C4CECF; Mon, 11 Nov 2024 10:46:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731321970; bh=5o6ue3Y/9WUhxE5zoGBuUR1NiMa8Zm6mQizx/j1vSgs=; h=From:To:Cc:Subject:Date:From; b=u0sWa1bvI6RRro/9TkKiMUmt3YmLZ94glC4mudUvEXjdWX+PuEmF26kpDL3ctEEm6 RcfyAiV7OKSBgwFuDNWm76NsP5i3S5OrIwuE/aISRPPqMT0J2pJBnph2QvxzvcUV8N I5HJEDsKYmi7WBRBb265h9Z2wjNHvkaI6WwWp+m0LLMeNsoTpnDDlK6PZVSIsbc/S7 VleBfxRAs5jzo+HoFtjdaNm1L6vMZ+v2uCbkjcbwLRb/Foq0d9YM6htWDdp5RjXqWU XvBaQT953MAXh9zBbOqFoPGATO6/eI034ieh3ThGXjfg4sHkQhmKMhQ2YXrqHOml+W rR9GJNxWz9mNQ== From: Arnd Bergmann To: Ulf Hansson , Vibhore Vardhan , Kevin Hilman , Nishanth Menon , Markus Schneider-Pargmann Cc: Arnd Bergmann , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pmdomain: ti_sci: add CONFIG_PM_SLEEP dependency Date: Mon, 11 Nov 2024 11:46:01 +0100 Message-Id: <20241111104605.3964041-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Without CONFIG_PM_SLEEP, the pm_generic_suspend() function cannot be called since it is defined to NULL: In file included from include/uapi/linux/posix_types.h:5, ... from drivers/pmdomain/ti/ti_sci_pm_domains.c:10: drivers/pmdomain/ti/ti_sci_pm_domains.c: In function 'ti_sci_pd_suspend': include/linux/stddef.h:9:14: error: called object is not a function or func= tion pointer 9 | #define NULL ((void *)0) | ^ include/linux/pm.h:875:41: note: in expansion of macro 'NULL' 875 | #define pm_generic_suspend NULL | ^~~~ drivers/pmdomain/ti/ti_sci_pm_domains.c:134:15: note: in expansion of macro= 'pm_generic_suspend' 134 | ret =3D pm_generic_suspend(dev); | ^~~~~~~~~~~~~~~~~~ Fixes: 7c2c8d2651b5 ("pmdomain: ti_sci: add per-device latency constraint m= anagement") Signed-off-by: Arnd Bergmann --- drivers/pmdomain/ti/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pmdomain/ti/Kconfig b/drivers/pmdomain/ti/Kconfig index 67c608bf7ed0..f92fa9b58bb0 100644 --- a/drivers/pmdomain/ti/Kconfig +++ b/drivers/pmdomain/ti/Kconfig @@ -11,6 +11,7 @@ config TI_SCI_PM_DOMAINS tristate "TI SCI PM Domains Driver" depends on TI_SCI_PROTOCOL depends on PM_GENERIC_DOMAINS + depends on PM_SLEEP help Generic power domain implementation for TI device implementing the TI SCI protocol. --=20 2.39.5