From nobody Mon Feb 9 10:40:47 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E49861A0BFA for ; Sat, 9 Nov 2024 19:52:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181931; cv=none; b=rJLUYyn5IRmuvlxeWUyLpYtrE8NRlqJQ5CgewyJR+0ipNxXgn9aAD/XIegf4ipFnPy2iFM5XJx9RMSzMUJmNBWNG5YHdyueG5Sx52QgtboxaXhcNARXzckhV9LklToH2sp0h5CaxDn/eGwjtfRGB8rSBX4vqaY+GLAM4DSlmisE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181931; c=relaxed/simple; bh=SV+CBISDRcceKmAV7UBfCAiWuL09kGw2rD7YZrf5BkY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=J1dJgySPAsi1hTlL1CtY5o2M5Q82hfodlWbsGEiM1RpSaBXDyHfU5mdiGO0OLLYtyvgD0XS+8f7AUE0DWn5tC1oHhYZQLSgNrtal8fcsYMqjkuD012fKvNX7HnTLU1y3t4xJB4Zse5j0Ku3/D7KdiAaSCGPA/TQC5hY4P79D8ws= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org; spf=fail smtp.mailfrom=beagleboard.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b=PQNoDjXO; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b="PQNoDjXO" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-720b2d8bb8dso2396867b3a.1 for ; Sat, 09 Nov 2024 11:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1731181929; x=1731786729; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P5LNGQE4gBDVRfeiKZcltb/2gOhU4SNw+NWSVQDaKIM=; b=PQNoDjXOr+awPxw3gH/7cWd7d+e23FwMRKkNML0RkSaExFY496Nw54LPXNrcFdw38B jnp/ei17Fh46PEDhP1gj2ZPFUo16Hhdg0tAZ7KXWuZrjmBvAq9jy9iSV6CVaOO4u85aq +hynGVxsZ+ycXRQBUt/LVvtqFJwnyrRcZA1R7wUSpY0JPxfHOFsqO6dGuAdq70flZYR/ T/ZqOjPddFwZFPHygnAa1upPvWOyKeJ2WwRjbV/bOZaPEuKtuFYCjeHM1jbVSOocZGLV GD6C5xBVyfA5ZwtAakl77BXk6YsmBboG+exl/ywooeOB8s2R3Lm5edJttaArC+lxAzb9 +oMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731181929; x=1731786729; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P5LNGQE4gBDVRfeiKZcltb/2gOhU4SNw+NWSVQDaKIM=; b=siMiqsNl61PmzRH46IFgWk9aP537SdQfcXASoC49VKtlQ8mHGZ4iFYupWKP3f2D4op pNbCGCFcAv+jFLvVH+vcx4m+loFfNxI4L3sHhEFKn5lfHX/FUph2Uw8p1m4KCJnSpb8Z QbUlpLZAK25N2fPeEqV1xkr1UuTVMdSo3xxPvwJf+xU82rQNWWKAH8JGn2Kls6LxqtI6 YIbkkyrl73hZm+wVI/t1obxzGKEkN4AD3vp8GBp2cKeXLaYtRONRPbjHbH8lgzPRLhop g+kdk/lXG5ny9BvhpuNYcgCvREDX6dM+zMd9fWxupLW1AEdSu9NIOf7aBA1SS7YziSgf zqWw== X-Forwarded-Encrypted: i=1; AJvYcCXUcQs65HZhV9XWFSdxwbjHBpL8cWkOk52/EG9iObqtlwMycKI1Mtz7wjeAYnPO+CJSV80vOdRHehUqOdM=@vger.kernel.org X-Gm-Message-State: AOJu0YxjC9CTDvBZx4tEDszgTtEAieJBL41xmNJhQLTouuePeI322Gri uX7/e81XQ1bVwxBTItI2gs0WJBSxPbzWN3HkCRtIFPSPRaO+jpYe6ESvvfsLyQ== X-Google-Smtp-Source: AGHT+IHeFKHHtNFnXGTeAvs5Hms+wGtkixhFXyshXKlIfVKXHm+IQB5p/sN1qLQ3nVaF7nXsOxBzug== X-Received: by 2002:a05:6a21:339b:b0:1dc:154a:b8d8 with SMTP id adf61e73a8af0-1dc22b61288mr10478061637.35.1731181929076; Sat, 09 Nov 2024 11:52:09 -0800 (PST) Received: from [172.22.58.163] ([117.250.76.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724079a4177sm5972288b3a.99.2024.11.09.11.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2024 11:52:08 -0800 (PST) From: Ayush Singh Date: Sun, 10 Nov 2024 01:21:33 +0530 Subject: [PATCH v2 1/3] of: Extract of_alias_create() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241110-of-alias-v2-1-16da9844a93e@beagleboard.org> References: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> In-Reply-To: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> To: Rob Herring , Saravana Kannan , d-gole@ti.com, jkridner@beagleboard.org, lorforlinux@beagleboard.org, Geert Uytterhoeven , Andrew Davis , robertcnelson@beagleboard.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayush Singh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3656; i=ayush@beagleboard.org; h=from:subject:message-id; bh=SV+CBISDRcceKmAV7UBfCAiWuL09kGw2rD7YZrf5BkY=; b=owEBbQKS/ZANAwAIAQXO9ceJ5Vp0AcsmYgBnL71fWT488AKGi2xOmM+WIweUfCnHdsBbch7hS szcbDKg6yWJAjMEAAEIAB0WIQTfzBMe8k8tZW+lBNYFzvXHieVadAUCZy+9XwAKCRAFzvXHieVa dCggEACb1+omj5FCGSylnXwbd+oSopkKcCUnpk7tef9ku+DI8iMvAgHmjAICEKp340HKSigZE7u NB4R+99LZ2hBL39+UJVrM4/fdbF4BUAS57jPBxsL1a8xhrdmUBtOK/I8qBG7e9BehgS62GWA9aF +oKSgG/aMb9ax+91f2rpxxrqc8yqXrJwssrgVZpyT1ToskkdVJ/wuGrU3VnW2k5TFM2IWD/7hfi SA6O2+P7dYXf1l/Zz6aq2oXvhQcCIEICk6/IBEJj045TFAS6K3FDwhvc82JhM3F9erE6CGliDAm egEIQ3FF/LiMwgc9qCL1ldaMkoST/38BJdPbjHHFM44pDZxZrIHvT/FeIpK0Y+XFONFssiEZm3y kKA8Ig4lXZ+Xw7EDDnZ+iASlCo5ciuq65QQruZNUKr77wqfSMyvgNdnzW31/LRwbjSjJMSKuivZ IRnWig+ZYztGBtagu6zM+1km8vMyBBpQ73JfJdvm0oUGNfJO6T4JGTe/svj/BA2DgT/tjuG2h7h 0Ck5woFx0KNsgs7SA7Oq6dNMsO1fNQ6xzabQR8Iz3hgbFbZUnj7KZpwB8JU3KlE+QvyJprxrs82 S3JP8B893GyARMQA3JyqazXOwLxGZUAhLqq58HEJ098eLFsqf4+GZxp9HFKBMwQBoFggvH7UlGe C6OvpQZ8PhtaJ+A== X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 Extract the code to create and add an alias from of_alias_scan() into its own function of_alias_create(). Co-developed-by: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven Signed-off-by: Ayush Singh --- drivers/of/base.c | 79 +++++++++++++++++++++++++++++----------------------= ---- 1 file changed, 42 insertions(+), 37 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index a8b0c42bdc8e9c352b0af9f9a8540aa6a3afd771..e5cd75fca95132060334aa8547c= 58951d2132cfb 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -180,6 +180,47 @@ void __of_phandle_cache_inv_entry(phandle handle) phandle_cache[handle_hash] =3D NULL; } =20 +static void of_alias_add(struct alias_prop *ap, struct device_node *np, + int id, const char *stem, int stem_len) +{ + ap->np =3D np; + ap->id =3D id; + strscpy(ap->stem, stem, stem_len + 1); + list_add_tail(&ap->link, &aliases_lookup); + pr_debug("adding DT alias:%s: stem=3D%s id=3D%i node=3D%pOF\n", + ap->alias, ap->stem, ap->id, np); +} + +static void of_alias_create(const struct property *pp, + void *(*dt_alloc)(u64 size, u64 align)) +{ + const char *start =3D pp->name; + const char *end =3D start + strlen(start); + struct device_node *np; + struct alias_prop *ap; + int id, len; + + np =3D of_find_node_by_path(pp->value); + if (!np) + return; + + /* walk the alias backwards to extract the id and work out the 'stem' str= ing */ + while (isdigit(*(end - 1)) && end > start) + end--; + len =3D end - start; + + if (kstrtoint(end, 10, &id) < 0) + return; + + /* Allocate an alias_prop with enough space for the stem */ + ap =3D dt_alloc(sizeof(*ap) + len + 1, 4); + if (!ap) + return; + memset(ap, 0, sizeof(*ap) + len + 1); + ap->alias =3D start; + of_alias_add(ap, np, id, start, len); +} + void __init of_core_init(void) { struct device_node *np; @@ -1763,17 +1804,6 @@ int of_update_property(struct device_node *np, struc= t property *newprop) return rc; } =20 -static void of_alias_add(struct alias_prop *ap, struct device_node *np, - int id, const char *stem, int stem_len) -{ - ap->np =3D np; - ap->id =3D id; - strscpy(ap->stem, stem, stem_len + 1); - list_add_tail(&ap->link, &aliases_lookup); - pr_debug("adding DT alias:%s: stem=3D%s id=3D%i node=3D%pOF\n", - ap->alias, ap->stem, ap->id, np); -} - /** * of_alias_scan - Scan all properties of the 'aliases' node * @dt_alloc: An allocator that provides a virtual address to memory @@ -1811,38 +1841,13 @@ void of_alias_scan(void * (*dt_alloc)(u64 size, u64= align)) return; =20 for_each_property_of_node(of_aliases, pp) { - const char *start =3D pp->name; - const char *end =3D start + strlen(start); - struct device_node *np; - struct alias_prop *ap; - int id, len; - /* Skip those we do not want to proceed */ if (!strcmp(pp->name, "name") || !strcmp(pp->name, "phandle") || !strcmp(pp->name, "linux,phandle")) continue; =20 - np =3D of_find_node_by_path(pp->value); - if (!np) - continue; - - /* walk the alias backwards to extract the id and work out - * the 'stem' string */ - while (isdigit(*(end-1)) && end > start) - end--; - len =3D end - start; - - if (kstrtoint(end, 10, &id) < 0) - continue; - - /* Allocate an alias_prop with enough space for the stem */ - ap =3D dt_alloc(sizeof(*ap) + len + 1, __alignof__(*ap)); - if (!ap) - continue; - memset(ap, 0, sizeof(*ap) + len + 1); - ap->alias =3D start; - of_alias_add(ap, np, id, start, len); + of_alias_create(pp, dt_alloc); } } =20 --=20 2.47.0 From nobody Mon Feb 9 10:40:47 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C93001A00F2 for ; Sat, 9 Nov 2024 19:52:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181937; cv=none; b=ELj5Fav2HGrURHZZt2GDRHfWy6GuJcrW+VQsOAKdKSWNN9DZ4W1FX9YwL3ZqOh86NuUAR3/zfOVZ/8e9S37Y4J6HpJTHoqMdbRy3qS0TyP88tFO+6Ejq+srq7j1a0S/TmTi0ZoT5b6lLTKUjgoWN1R4v9dJCK8tmmqRbnf44Wfo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181937; c=relaxed/simple; bh=FE5OKahuQbeKkOcWp0inYK+4t5zKMypUJZaonXoh7Sw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qwsdFc3BF/oX/FH85yMkA/7bWK8ezNKLiUQnMz/cLXJjP7arf/Y5VGmZXcDLjQ/Z6hW+MUJ5iLuYxq1eOy3C7mZKiHLlk30SFY3XOoLRSmozNRYCtH18Tid5n6q4wz3UwacKy8RcpSPVxIFVnWucieL1PTdP24nYtxS1HFCXQnQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org; spf=fail smtp.mailfrom=beagleboard.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b=YhfMgXXU; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b="YhfMgXXU" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7242f559a9fso143154b3a.1 for ; Sat, 09 Nov 2024 11:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1731181935; x=1731786735; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6/6W91RQBKdWea/k2P+RWwcZxX0A/q3VyEVyWhYVDwQ=; b=YhfMgXXU6MJHxeYtpe/71jd8UyK3f+/yP7lyut+bzpe4iXrCzzNep/l/44g93GVlYy Od49bVYxN+oMVavc9vwApJm0LxeFc9NfYAqh855nWm3KFOBYVrAakSiq7guCh3Po2PSo Lrgjnh0DbvDURfN2JQiqIcatk1rXYuzE7WD0oOScwJEXgtHXWI2oLNj7J+v6E4rKVQTR DyrpBlpqVBUo6PwuaYG5tGh8JAmCnijiDrO+d6fyDmBORi2DqiV/IshdCr/Em2edCLgT cM7u1TLuUMfmm4rL+9xGcfJGzjx7A44KEKh5IIoiyIHycM185Pl8w3sMbXb4JzCUlZNM QEQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731181935; x=1731786735; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6/6W91RQBKdWea/k2P+RWwcZxX0A/q3VyEVyWhYVDwQ=; b=BqTINEa5mr2jsRREH2U0zU34y+9qrO7Te1XFRZyMBeKUQt6SEW7TJiHgExVDllPvUz QYpHfzIObJDjv8v76tPjuClNsWoeoBlqJE/AeZaNZL45VWBpgkt//e3AeSg9uwC4Zj3v DyDu8nZbYxe7hyY1lj7/QF8TEYBrOaht7X3Jq+lft0jjxuzMdO0Ifg0wG4/d4ZwbVl8x HhefjGeLVLlpi4eQuDacJVZjgcAt1DYmh4H5ajs4qtM6xx+VULwYYGscBs0Ss7vs31MA PN7CJojZRvHjQQkKD8mSIhzHHXtAGnefCXMYZ8J1FTlqWFuHRhK3rfZvoCnbMj4vKnHm pIBw== X-Forwarded-Encrypted: i=1; AJvYcCXbFWWM6bYikJs3LBT/xIpK+Ir+aMx5MAI7sFeUDgedXY52w1e6qdegYWsNNMMMjMNtNmiYNSIIQznPgiU=@vger.kernel.org X-Gm-Message-State: AOJu0YwWHI4JtZ5+gfIB5u6JuwloiQ6q13s9sx3EdyBf4R6Yn2o/kN7o sl1NfY96Z3G1RhmEO9FLhrBwFEOPKbx3eTVzTASfSRv91SYwkqRY/I08QRh/4A== X-Google-Smtp-Source: AGHT+IFndOxsMdOpWc5B2xO4LeTRwkyKUS80N00ci5n9+MxvfL5ryT4r8diucBi3Siep0unb4PjQtg== X-Received: by 2002:a05:6a00:1252:b0:71e:5e04:be9b with SMTP id d2e1a72fcca58-724132c0d20mr10606164b3a.12.1731181935217; Sat, 09 Nov 2024 11:52:15 -0800 (PST) Received: from [172.22.58.163] ([117.250.76.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724079a4177sm5972288b3a.99.2024.11.09.11.52.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2024 11:52:13 -0800 (PST) From: Ayush Singh Date: Sun, 10 Nov 2024 01:21:34 +0530 Subject: [PATCH v2 2/3] of: Add of_alias_destroy() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241110-of-alias-v2-2-16da9844a93e@beagleboard.org> References: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> In-Reply-To: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> To: Rob Herring , Saravana Kannan , d-gole@ti.com, jkridner@beagleboard.org, lorforlinux@beagleboard.org, Geert Uytterhoeven , Andrew Davis , robertcnelson@beagleboard.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayush Singh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1027; i=ayush@beagleboard.org; h=from:subject:message-id; bh=FE5OKahuQbeKkOcWp0inYK+4t5zKMypUJZaonXoh7Sw=; b=owEBbQKS/ZANAwAIAQXO9ceJ5Vp0AcsmYgBnL71fymQFG8xdl/TB1Jum+jcjavL/0Lu3s/7lP 58tzd3711iJAjMEAAEIAB0WIQTfzBMe8k8tZW+lBNYFzvXHieVadAUCZy+9XwAKCRAFzvXHieVa dMi7D/9bkd2pD0Qwumvco5P1YYaxKcdGjrmi/8xNl3bg3bVP2uwRqeZSjU9RcOEPF6sm+moNNYG suakf1sfGR5JV709ygjewizb8c0DpgvKcl4jHNGfsU4UkhNiy4Ijhv7v/VBFLkf1QIFBB2Dh0oh lytSrANDYKls0+uLAy7/MUHLVQ+k6ioeUjuwLdFCxI1wjx0dKUCmWOy62Dd1WTUyLIPtsenghTJ J/h4HtDoQgzHXOgBCABvRx/t9zT+4V5kfGd0xS310clFSvuvaq5XPnLo6/STEThp2R/MCQ0qaCi jGu2gF35HZvP2CeRyBCNMipqPi06ruW/Mo/MTL2ynCWn4wuJmA+3LXO71/GIE67yZmjgOZWzXqa tCJU2IuCAsLlr96oNfRaLPP4D/mf7ZM4H4XFsOiLTi1hrG8uYzxeQ7TAfpHn4QR6o3wovqvmgeH B4WgbnmLCwOMz6nKbMPkIFp6nWAX/UwAZjhuf9P90mu7cunWvwqZ99WI2ehxSe16L3hZihJZ88E zXRJyDyEBEAFq6Mkvv4YAyKuBo5az47Tpdh8/rnEhnrpx5XuJjD1nEsB/05avO/fmArWg3dq1So 9HgFd466RVosGepjMN+HrxoRHTqK5c9s4al3PhBlJKil/Zd4DQsiVHylRgLuD95ZqWquQIehfEZ rOvx9rahqhOf0CQ== X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 Add a helper function to find an alias, remove it from the list of aliases, and destroy it. Co-developed-by: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven Signed-off-by: Ayush Singh --- drivers/of/base.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index e5cd75fca95132060334aa8547c58951d2132cfb..1cfb3cd4493e17d168689812881= 15798c6a6a151 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -221,6 +221,20 @@ static void of_alias_create(const struct property *pp, of_alias_add(ap, np, id, start, len); } =20 +static void of_alias_destroy(const char *name, void (*dt_free)(void *)) +{ + struct alias_prop *ap; + + list_for_each_entry(ap, &aliases_lookup, link) { + if (strcmp(ap->alias, name)) + continue; + + list_del(&ap->link); + dt_free(ap); + return; + } +} + void __init of_core_init(void) { struct device_node *np; --=20 2.47.0 From nobody Mon Feb 9 10:40:47 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A44F1A0BC5 for ; Sat, 9 Nov 2024 19:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181942; cv=none; b=bIY0AzvbPaa0RxB68SS/Jj8QSlYJvNf4Wdv8B+a7GlkIwv2edsQH4lsLsm2TlILa1pW4YtXIJcMQ4mesWUQcH0riSFUD5lo3P8OG1pDmDySCcsanNSDkH0nhHHrRad0OcGtUPQsXuCBbESEag8Osxk2TYHH+8MW4y09shhTT71U= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731181942; c=relaxed/simple; bh=LV7SPvJw7vBMe8rg9yhfbRbdXTu1kfyfhM7Z0nqZXcU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eWSTTCu6tLK8SOHngQm0E/SZHd9slIQxJkfomoXgqIm/mln0uWlhRfIcvGEVgK5p1WoWW0b+NBuiyBICpiQQpdY4k5/+bMHSXq9KqpLWb9Pu8dJtBnjhVUqa3HCGYtwgEw63AxOiD/38U1dDDjoCcSafQavaCMjNcCySxyRMQBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org; spf=fail smtp.mailfrom=beagleboard.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b=buo8KZZS; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=beagleboard.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=beagleboard-org.20230601.gappssmtp.com header.i=@beagleboard-org.20230601.gappssmtp.com header.b="buo8KZZS" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-720e94d36c8so3810591b3a.1 for ; Sat, 09 Nov 2024 11:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20230601.gappssmtp.com; s=20230601; t=1731181940; x=1731786740; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uC/Aqfht74BfKqo7buArS8NTdFz27K7/sj2Os++ZHYU=; b=buo8KZZSG7Q3aIZDKnPwKbY8nzYfS7fFuB1ONKKV9vAIlbKwLwbaw8B7uhsqoC6pp4 6hOlX7CwOGYYRpw/jFV50+jakVl+hhkxOLD0wsg3Rq1tZ6OpmDMvZoeodsp3gAr+YLYz EXUdBE/1hSm3+/Lerx2GH9TcASQPgV88LB2MIJDqY8k/HfmoUwFdrfeyfld/PXSAUhJV LANtkwr7xTbDdD94WH++KD+4zV2rZPlC+3Y0azwujm8b8y3mOIQqyNMZqcwUbZFdYBAd ggUaKVsBNSLSriE8nd43uExYP5DgqNMlGh3LARCmDCByR+l+jPISq9Hxw/d48OeIvoPV JX3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731181940; x=1731786740; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uC/Aqfht74BfKqo7buArS8NTdFz27K7/sj2Os++ZHYU=; b=SJCTJnAr8ncVT4e/gGZwVfXB/GjfTaX9MGb/7rIgZ1qixfKYXMvO60XryZmfImsrud ONOYMO2hIajHtTfFnj+D2hiMHdB+iB6qw1qytq3pG3msX5IHHWBc/WntwUEm476sUUx/ WtD9HyBVKyVllB/hk7q43cNFfVYHwEEeFaF2Iu1dkJGs39z6N0HtKBqFlENgGLrVwTIS s9A5YxB1FsDU9XPXd5ohTx8l6mwJ7y1vpChfy8kvitjNIJXLVHxx3XtTLfU1UoTMK1FH RD23kBfEAaiyWiJo47aBcWmnOlLf7A5RYfzhz818FWvhhfo8LZ9IUwl8COxc70+Wzpuk Dc5A== X-Forwarded-Encrypted: i=1; AJvYcCUb/BbTk6/l6fWg2yGCJqImWJSEDyNkYVcWxUjVYjwsKZSMcFJPDDwyJPqTGxG7Awt5ZhiTh6W3lwA2m9w=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3aUafs/kOGS63vAWNK6w7y3E8M+1CPUhXX35Z0NpFSY2P/EeR WOi93RP+hLjfioEVG4rAHeTNDB51TqFNgqYg060skR8KPbDYeD2aLSU0QtI31Q== X-Google-Smtp-Source: AGHT+IHQxgNVWJFp45lVcQFqlSiJyuXRJLd2I1ZpT5fDTPHng9gSOcweCkStWBA7PTyur3DSUkNghw== X-Received: by 2002:aa7:9f4f:0:b0:71e:40cd:b607 with SMTP id d2e1a72fcca58-7241230ed29mr10408575b3a.11.1731181940345; Sat, 09 Nov 2024 11:52:20 -0800 (PST) Received: from [172.22.58.163] ([117.250.76.240]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724079a4177sm5972288b3a.99.2024.11.09.11.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Nov 2024 11:52:19 -0800 (PST) From: Ayush Singh Date: Sun, 10 Nov 2024 01:21:35 +0530 Subject: [PATCH v2 3/3] of: Add notifier in of_reconfig_notifier_register() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241110-of-alias-v2-3-16da9844a93e@beagleboard.org> References: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> In-Reply-To: <20241110-of-alias-v2-0-16da9844a93e@beagleboard.org> To: Rob Herring , Saravana Kannan , d-gole@ti.com, jkridner@beagleboard.org, lorforlinux@beagleboard.org, Geert Uytterhoeven , Andrew Davis , robertcnelson@beagleboard.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ayush Singh X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2046; i=ayush@beagleboard.org; h=from:subject:message-id; bh=LV7SPvJw7vBMe8rg9yhfbRbdXTu1kfyfhM7Z0nqZXcU=; b=kA0DAAgBBc71x4nlWnQByyZiAGcvvV+iIvLUBoBURgIH4sC0ZtcRYPLBYkh69TrlgTYVgZSLt okCMwQAAQgAHRYhBN/MEx7yTy1lb6UE1gXO9ceJ5Vp0BQJnL71fAAoJEAXO9ceJ5Vp0Wx8QANro 3HQOQ3kwIL9CMjIJ7g2/g4+DpLezqa98+8ZU6Zu4dhyp0VilIK2DMSpECJ2qFiHRePLPtphcfOl ZUbnS4nWBZ/T7OEFMV/kEw8Kk+pLWYn9GAVimVhavx9pVyX7ddwJbHE3SpyZ81p2M0K5nzi7OWb qt+p0W/RxEO1UHm4MFvKPRtRZjecVtpgnCqZ8ATy/Q7uCD3I7OnwqRwAtjT6FXUWuH0wg2BaqSM LI4aRQ0k84w7GqqhNk2zAjfIdWHT+BNH9Baikmixw3T0yG//3LV1PrJF6Ii7HWF4XbYyOxUePqY tZYhqw0FzDUMwfsj2N5WAnysFUVFs1UlRAffOORXHlGr3dknxItJUJ2JZmKimK5YQAd9V/mddmX l1W6+RRdGO6AOUDdVeiY1Bj7FHXD4WrN+MjUVmgFd2k9/p0G/xpJ+vMAarXRYJ4IivZL5G5cpC2 Gf10lKf4tiRjmzCMot237977rZqOELD/de1KU9l3MZA3+h2q1EK9IB2MDjhieIKQHBH2le/Hp5q x/IlcL5W1oui5CsL9FUEkaCUCwu8FMG9nycsgeMNCv3tq1LvcVgFKIX310EYDrpLp0m5qU+qRUc f75JNx4Y7Hf9LCOwt3G6XkBhxNvKkXi3zP8GaPZ59O9rYBc36XMbNDmv+sGsaHg1BeZsdcS0swV bE23I X-Developer-Key: i=ayush@beagleboard.org; a=openpgp; fpr=DFCC131EF24F2D656FA504D605CEF5C789E55A74 Currently the list of aliases is not updated when an overlay that modifies /aliases is added or removed. This breaks drivers (e.g. serial) that rely on of_alias_get_id(). Update the list of aliases when a property of the /aliases node is added, removed, or updated by registering a notifier. Co-developed-by: Geert Uytterhoeven Signed-off-by: Geert Uytterhoeven Signed-off-by: Ayush Singh --- drivers/of/base.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/drivers/of/base.c b/drivers/of/base.c index 1cfb3cd4493e17d16868981288115798c6a6a151..5c061fdca885973d4389c0f6afe= 459a751d850b8 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -235,11 +235,50 @@ static void of_alias_destroy(const char *name, void (= *dt_free)(void *)) } } =20 +static void *alias_alloc(u64 size, u64 align) +{ + return kzalloc(size, GFP_KERNEL); +} + +static void alias_free(void *p) +{ + /* Leak memory */ +} + +static int alias_OF_notifier(struct notifier_block *np, unsigned long acti= on, + void *data) +{ + struct of_reconfig_data *reconf_data =3D data; + + if (reconf_data->dn !=3D of_aliases) + return NOTIFY_DONE; + + switch (action) { + case OF_RECONFIG_ADD_PROPERTY: + of_alias_create(reconf_data->prop, alias_alloc); + break; + case OF_RECONFIG_REMOVE_PROPERTY: + of_alias_destroy(reconf_data->prop->name, alias_free); + break; + case OF_RECONFIG_UPDATE_PROPERTY: + of_alias_destroy(reconf_data->old_prop->name, alias_free); + of_alias_create(reconf_data->prop, alias_alloc); + break; + } + + return NOTIFY_OK; +} + +static struct notifier_block alias_of_nb =3D { + .notifier_call =3D alias_OF_notifier, +}; + void __init of_core_init(void) { struct device_node *np; =20 of_platform_register_reconfig_notifier(); + of_reconfig_notifier_register(&alias_of_nb); =20 /* Create the kset, and register existing nodes */ mutex_lock(&of_mutex); --=20 2.47.0