From nobody Sun Nov 24 03:05:53 2024 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302A11E882A; Fri, 8 Nov 2024 10:29:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.89.224.132 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731061789; cv=none; b=YNfIbVnfbzXsrM2NNylO6uAz6vo2Du8PZYG+t7j2PicRdIbSgpGOPT7YPflgXf/CEGxs1HmAXpK8Hf6Hf3Z4U6/cFI9yJIAcryqIor3jSAW8Bre7LFUDsXgwtwsP2LBTB0NDAGEVWZCuZdm+fhla+1mIJ/cauFl6xYDVLTdZ2zc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731061789; c=relaxed/simple; bh=nRvHMPQyccCtRzF/bRdchRqq5Ivtf+cbDU1nS/KMsFY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jLKCF5Mg7jImkStvP/LjneN2KX9ZAA/677ZxuFJbyJNPypJZFcbx24OpbkkzLZ6nOPUFpo/fomT5YiEekuAjzr+BC3Bmpl5CKEMzUJRcdvckLS56jCn8cBRv3JpgjvHPgFo8CijlbdpRbmwIRkKnksNL5HNB11xR/3xPY/XBW/A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com; spf=pass smtp.mailfrom=salutedevices.com; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b=u6RHnyD7; arc=none smtp.client-ip=45.89.224.132 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=salutedevices.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=salutedevices.com header.i=@salutedevices.com header.b="u6RHnyD7" Received: from p-infra-ksmg-sc-msk02.sberdevices.ru (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 663E0120034; Fri, 8 Nov 2024 13:29:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 663E0120034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1731061785; bh=VamG/ymoMHLOlKtTX9SQ1tmHgBSD8v0zCJU57Bm5hMc=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=u6RHnyD7qDFgSSchjUmIovuaDEEC9ePmwjyznYFfir39zkUoIZxI8jcU0y3qSyd/A ioDFFwERq7iH2j+Py7F0GpHWjTepPOQnIN66HqKFlwGKWKb5NWmrVT4Ipb2TKINuiS +wltA+g2TQwxMtA8WD1aJZR8ObAIbq+IShn1NZg01sPLaWAIuYZjZB12m6RA5aCZh1 vRrdHpzAY6ePRBVcAVorYYmShJlvghERiQR7vJlsKvglSC4uUGbsHQOdTJRoJSD1Uk GbFmqfUe9eDMCQjp4fZKvWZniOmakNNzXcj1QSezV0CV4lA23n51AjQJHSOSIcoP/4 IGKK0msiPQJig== Received: from smtp.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Fri, 8 Nov 2024 13:29:45 +0300 (MSK) From: Alexey Romanov To: , , , , , , , , , , , CC: , , , , , , "Alexey Romanov" Subject: [PATCH v10 10/22] crypto: amlogic - Avoid kzalloc in engine thread Date: Fri, 8 Nov 2024 13:28:55 +0300 Message-ID: <20241108102907.1788584-11-avromanov@salutedevices.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241108102907.1788584-1-avromanov@salutedevices.com> References: <20241108102907.1788584-1-avromanov@salutedevices.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: p-i-exch-a-m2.sberdevices.ru (172.24.196.120) To p-i-exch-a-m1.sberdevices.ru (172.24.196.116) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 189039 [Nov 08 2024] X-KSMG-AntiSpam-Version: 6.1.1.7 X-KSMG-AntiSpam-Envelope-From: avromanov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 41 0.3.41 623e98d5198769c015c72f45fabbb9f77bdb702b, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;smtp.sberdevices.ru:7.1.1,5.0.1;127.0.0.199:7.1.2, FromAlignment: s X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2024/11/08 08:34:00 #26834472 X-KSMG-AntiVirus-Status: Clean, skipped Content-Type: text/plain; charset="utf-8" It makes no sense to allocate memory via kzalloc, we can use static buffer, speedup data processing and don't think about kfree() calls. Signed-off-by: Alexey Romanov Reviewed-by: Neil Armstrong --- drivers/crypto/amlogic/amlogic-gxl-cipher.c | 52 +++++++++------------ drivers/crypto/amlogic/amlogic-gxl.h | 6 +-- 2 files changed, 26 insertions(+), 32 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/crypto/a= mlogic/amlogic-gxl-cipher.c index 0d32d2e3ca3b..622e179320ff 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c @@ -59,7 +59,7 @@ static bool meson_cipher_need_fallback(struct skcipher_re= quest *areq) static int meson_cipher_do_fallback(struct skcipher_request *areq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(areq); int err; #ifdef CONFIG_CRYPTO_DEV_AMLOGIC_GXL_DEBUG @@ -91,7 +91,6 @@ struct cipher_ctx { struct skcipher_request *areq; struct scatterlist *src_sg; struct scatterlist *dst_sg; - void *bkeyiv; =20 unsigned int src_offset; unsigned int dst_offset; @@ -147,7 +146,7 @@ static void meson_setup_keyiv_descs(struct cipher_ctx *= ctx) struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); struct meson_alg_template *algt =3D container_of(alg, struct meson_alg_template, alg.skcipher.base); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_dev *mc =3D op->mc; unsigned int ivsize =3D crypto_skcipher_ivsize(tfm); unsigned int blockmode =3D algt->blockmode; @@ -157,7 +156,7 @@ static void meson_setup_keyiv_descs(struct cipher_ctx *= ctx) return; =20 if (blockmode =3D=3D DESC_OPMODE_CBC) { - memcpy(ctx->bkeyiv + AES_MAX_KEY_SIZE, ctx->areq->iv, ivsize); + memcpy(op->keyiv + AES_MAX_KEY_SIZE, ctx->areq->iv, ivsize); dma_sync_single_for_device(mc->dev, ctx->keyiv.addr, ctx->keyiv.len, DMA_TO_DEVICE); } @@ -179,7 +178,7 @@ static bool meson_setup_data_descs(struct cipher_ctx *c= tx) { struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(ctx->areq); struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(ctx->areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); struct meson_alg_template *algt =3D container_of(alg, struct meson_alg_template, @@ -222,7 +221,7 @@ static int meson_kick_hardware(struct cipher_ctx *ctx) { struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(ctx->areq); struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(ctx->areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); struct meson_alg_template *algt =3D container_of(alg, struct meson_alg_template, @@ -294,7 +293,7 @@ static int meson_kick_hardware(struct cipher_ctx *ctx) static int meson_cipher(struct skcipher_request *areq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(areq); struct meson_dev *mc =3D op->mc; struct skcipher_alg *alg =3D crypto_skcipher_alg(tfm); @@ -307,6 +306,7 @@ static int meson_cipher(struct skcipher_request *areq) .dst_sg =3D areq->dst, .cryptlen =3D areq->cryptlen, }; + unsigned int ivsize =3D crypto_skcipher_ivsize(tfm); int err; =20 dev_dbg(mc->dev, "%s %s %u %x IV(%u) key=3D%u ctx.flow=3D%d\n", __func__, @@ -322,21 +322,21 @@ static int meson_cipher(struct skcipher_request *areq) mc->chanlist[rctx->flow].stat_req++; #endif =20 - ctx.bkeyiv =3D kzalloc(48, GFP_KERNEL | GFP_DMA); - if (!ctx.bkeyiv) - return -ENOMEM; - - memcpy(ctx.bkeyiv, op->key, op->keylen); ctx.keyiv.len =3D op->keylen; if (ctx.keyiv.len =3D=3D AES_KEYSIZE_192) ctx.keyiv.len =3D AES_MAX_KEY_SIZE; =20 - ctx.keyiv.addr =3D dma_map_single(mc->dev, ctx.bkeyiv, ctx.keyiv.len, + if (algt->blockmode =3D=3D DESC_OPMODE_CBC) { + memcpy(op->keyiv + AES_MAX_KEY_SIZE, areq->iv, ivsize); + ctx.keyiv.len =3D AES_MAX_KEY_SIZE + ivsize; + } + + ctx.keyiv.addr =3D dma_map_single(mc->dev, op->keyiv, ctx.keyiv.len, DMA_TO_DEVICE); err =3D dma_mapping_error(mc->dev, ctx.keyiv.addr); if (err) { dev_err(mc->dev, "Cannot DMA MAP KEY IV\n"); - goto free_keyiv; + return err; } =20 err =3D meson_map_scatterlist(areq, mc); @@ -370,9 +370,6 @@ static int meson_cipher(struct skcipher_request *areq) unmap_keyiv: dma_unmap_single(mc->dev, ctx.keyiv.addr, ctx.keyiv.len, DMA_TO_DEVICE); =20 -free_keyiv: - kfree_sensitive(ctx.bkeyiv); - return err; } =20 @@ -392,7 +389,7 @@ int meson_handle_cipher_request(struct crypto_engine *e= ngine, void *areq) static int meson_skdecrypt(struct skcipher_request *areq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(areq); struct crypto_engine *engine; int e; @@ -410,7 +407,7 @@ static int meson_skdecrypt(struct skcipher_request *are= q) static int meson_skencrypt(struct skcipher_request *areq) { struct crypto_skcipher *tfm =3D crypto_skcipher_reqtfm(areq); - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_cipher_req_ctx *rctx =3D skcipher_request_ctx(areq); struct crypto_engine *engine; int e; @@ -427,7 +424,7 @@ static int meson_skencrypt(struct skcipher_request *are= q) =20 static int meson_cipher_init(struct crypto_tfm *tfm) { - struct meson_cipher_tfm_ctx *op =3D crypto_tfm_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_tfm_ctx_dma(tfm); struct meson_alg_template *algt; const char *name =3D crypto_tfm_alg_name(tfm); struct crypto_skcipher *sktfm =3D __crypto_skcipher_cast(tfm); @@ -453,16 +450,15 @@ static int meson_cipher_init(struct crypto_tfm *tfm) =20 static void meson_cipher_exit(struct crypto_tfm *tfm) { - struct meson_cipher_tfm_ctx *op =3D crypto_tfm_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_tfm_ctx_dma(tfm); =20 - kfree_sensitive(op->key); crypto_free_skcipher(op->fallback_tfm); } =20 static int meson_aes_setkey(struct crypto_skcipher *tfm, const u8 *key, unsigned int keylen) { - struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx(tfm); + struct meson_cipher_tfm_ctx *op =3D crypto_skcipher_ctx_dma(tfm); struct meson_dev *mc =3D op->mc; =20 switch (keylen) { @@ -479,11 +475,9 @@ static int meson_aes_setkey(struct crypto_skcipher *tf= m, const u8 *key, dev_dbg(mc->dev, "ERROR: Invalid keylen %u\n", keylen); return -EINVAL; } - kfree_sensitive(op->key); + + memcpy(op->keyiv, key, keylen); op->keylen =3D keylen; - op->key =3D kmemdup(key, keylen, GFP_KERNEL | GFP_DMA); - if (!op->key) - return -ENOMEM; =20 return crypto_skcipher_setkey(op->fallback_tfm, key, keylen); } @@ -501,7 +495,7 @@ static struct meson_alg_template algs[] =3D { .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY | CRYPTO_ALG_NEED_FALLBACK, - .cra_ctxsize =3D sizeof(struct meson_cipher_tfm_ctx), + .cra_ctxsize =3D sizeof(struct meson_cipher_tfm_ctx) + CRYPTO_DMA_PADDI= NG, .cra_module =3D THIS_MODULE, .cra_alignmask =3D 0xf, .cra_init =3D meson_cipher_init, @@ -530,7 +524,7 @@ static struct meson_alg_template algs[] =3D { .cra_flags =3D CRYPTO_ALG_TYPE_SKCIPHER | CRYPTO_ALG_ASYNC | CRYPTO_ALG_ALLOCATES_MEMORY | CRYPTO_ALG_NEED_FALLBACK, - .cra_ctxsize =3D sizeof(struct meson_cipher_tfm_ctx), + .cra_ctxsize =3D sizeof(struct meson_cipher_tfm_ctx) + CRYPTO_DMA_PADDI= NG, .cra_module =3D THIS_MODULE, .cra_alignmask =3D 0xf, .cra_init =3D meson_cipher_init, diff --git a/drivers/crypto/amlogic/amlogic-gxl.h b/drivers/crypto/amlogic/= amlogic-gxl.h index 9fbe5ab44877..e2e843ea6c4c 100644 --- a/drivers/crypto/amlogic/amlogic-gxl.h +++ b/drivers/crypto/amlogic/amlogic-gxl.h @@ -127,15 +127,15 @@ struct meson_cipher_req_ctx { =20 /* * struct meson_cipher_tfm_ctx - context for a skcipher TFM - * @key: pointer to key data + * @keyiv: key data * @keylen: len of the key * @keymode: The keymode(type and size of key) associated with this TFM * @mc: pointer to the private data of driver handling this TFM * @fallback_tfm: pointer to the fallback TFM */ struct meson_cipher_tfm_ctx { - u32 *key; - u32 keylen; + u8 keyiv[AES_MAX_KEY_SIZE + AES_BLOCK_SIZE] ____cacheline_aligned; + u32 keylen ____cacheline_aligned; u32 keymode; struct meson_dev *mc; struct crypto_skcipher *fallback_tfm; --=20 2.34.1