From nobody Sun Nov 24 02:34:57 2024 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C2F21A704; Fri, 8 Nov 2024 15:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731080234; cv=none; b=Q/zEZyM8t4pLx1fUBiffHEjiWzCtT1CUlScJY6XixQEOIflk5rz8ozgEUT3ufw2Qs4ixzgjLy/pLriU2R3ptYo6a1sfr0v8WdG95VGSK+5OLslzgd/4RURTrZMkM3QjUMkcHzSIIJ4kWVFbdme6M4c3ICXSi+k7YM5M/4Q/VaVk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731080234; c=relaxed/simple; bh=1ypPzc3wV+lBm0DYM/aNzTLOzfM+uS1LxxpyOA8V4G8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CZyVumgKRSzOZOOEQRpiNVUn1Ce0NmvrWO4E0CnwtWnbfWbymZYADYdllEEEpcN6HV4o3SDT+6MsUD7sTCEKh9bRksVQ/z+fYt9czmu7/20c6jKe3h9T8UYBdH33RXOTwg31FFbdFRbOelcPbjznvlk21MgTUhis30iwaM+w43Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=RdHcc/qu; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="RdHcc/qu" Received: by mail.gandi.net (Postfix) with ESMTPSA id 58B322000B; Fri, 8 Nov 2024 15:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1731080230; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sFZV/j2cdKSUUBE7wpD1K2bQ3OXCC6ZtMchgh75jPUI=; b=RdHcc/quHj39f7IVeGSH6D28RaxUwLToaFRa+6LfyztqF/cHy+j6MN+KXSuPHOTPBO8loZ UXGOhvC04vxwAaPkCbsaWBBs9X2mZdHh7Iu6Dz86tA3HF5ypt0UT2hNleh8IcdUAROz4gN ZcW1H0BM4vfetLuNu9+ALmTTHAr0yNSPCfA7/6IkOhtmWwZcxem7e6NXEeRMfPUWEpZJpM mbTXDAVX/yOQz0vQrGv10wt8gbDxu0d/WPmdJhmPQtZLhG0VtEao9F8pniSmNK0xNflthl 0K3OLbNAxo9O/Usw294hYzdFMAnGWHCQhsDBH+vLXJ4X7D3pYZ9mejjQ8cTBJQ== From: Romain Gantois Date: Fri, 08 Nov 2024 16:36:54 +0100 Subject: [PATCH 2/9] media: i2c: ds90ub960: Replace aliased clients list with bitmap Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20241108-fpc202-v1-2-fe42c698bc92@bootlin.com> References: <20241108-fpc202-v1-0-fe42c698bc92@bootlin.com> In-Reply-To: <20241108-fpc202-v1-0-fe42c698bc92@bootlin.com> To: Wolfram Sang , Tomi Valkeinen , Luca Ceresoli , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Mauro Carvalho Chehab Cc: Thomas Petazzoni , Kory Maincent , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-media@vger.kernel.org, Romain Gantois X-Mailer: b4 0.14.2 X-GND-Sasl: romain.gantois@bootlin.com The ds90ub960 driver currently uses a list of i2c_client structs to keep track of used I2C address translator (ATR) alias slots for each RX port. Keeping these i2c_client structs in the alias slot list isn't actually needed, the driver only needs to know if a specific alias slot is already in use or not. Convert the aliased_clients list to a bitmap named "alias_use_mask". This will allow removing the "client" parameter from the i2c-atr callbacks in a future patch. Signed-off-by: Romain Gantois --- drivers/media/i2c/ds90ub960.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/media/i2c/ds90ub960.c b/drivers/media/i2c/ds90ub960.c index ffe5f25f8647624be005da33a6412da2493413b4..f86028894c78187257efc8fd708= 12387000796f7 100644 --- a/drivers/media/i2c/ds90ub960.c +++ b/drivers/media/i2c/ds90ub960.c @@ -468,7 +468,7 @@ struct ub960_rxport { }; } eq; =20 - const struct i2c_client *aliased_clients[UB960_MAX_PORT_ALIASES]; + DECLARE_BITMAP(alias_use_mask, UB960_MAX_PORT_ALIASES); }; =20 struct ub960_asd { @@ -1032,17 +1032,13 @@ static int ub960_atr_attach_client(struct i2c_atr *= atr, u32 chan_id, struct device *dev =3D &priv->client->dev; unsigned int reg_idx; =20 - for (reg_idx =3D 0; reg_idx < ARRAY_SIZE(rxport->aliased_clients); reg_id= x++) { - if (!rxport->aliased_clients[reg_idx]) - break; - } - - if (reg_idx =3D=3D ARRAY_SIZE(rxport->aliased_clients)) { + reg_idx =3D find_first_zero_bit(rxport->alias_use_mask, UB960_MAX_PORT_AL= IASES); + if (reg_idx >=3D UB960_MAX_PORT_ALIASES) { dev_err(dev, "rx%u: alias pool exhausted\n", rxport->nport); return -EADDRNOTAVAIL; } =20 - rxport->aliased_clients[reg_idx] =3D client; + set_bit(reg_idx, rxport->alias_use_mask); =20 ub960_rxport_write(priv, chan_id, UB960_RR_SLAVE_ID(reg_idx), client->addr << 1); @@ -1063,18 +1059,15 @@ static void ub960_atr_detach_client(struct i2c_atr = *atr, u32 chan_id, struct device *dev =3D &priv->client->dev; unsigned int reg_idx; =20 - for (reg_idx =3D 0; reg_idx < ARRAY_SIZE(rxport->aliased_clients); reg_id= x++) { - if (rxport->aliased_clients[reg_idx] =3D=3D client) - break; - } + reg_idx =3D find_first_zero_bit(rxport->alias_use_mask, UB960_MAX_PORT_AL= IASES); =20 - if (reg_idx =3D=3D ARRAY_SIZE(rxport->aliased_clients)) { + if (reg_idx >=3D UB960_MAX_PORT_ALIASES) { dev_err(dev, "rx%u: client 0x%02x is not mapped!\n", rxport->nport, client->addr); return; } =20 - rxport->aliased_clients[reg_idx] =3D NULL; + clear_bit(reg_idx, rxport->alias_use_mask); =20 ub960_rxport_write(priv, chan_id, UB960_RR_SLAVE_ALIAS(reg_idx), 0); =20 @@ -3404,6 +3397,8 @@ static int ub960_parse_dt_rxport(struct ub960_data *p= riv, unsigned int nport, if (ret) goto err_put_remote_fwnode; =20 + bitmap_zero(rxport->alias_use_mask, UB960_MAX_PORT_ALIASES); + return 0; =20 err_put_remote_fwnode: --=20 2.47.0