From nobody Sun Nov 24 02:37:08 2024 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E78ED2178F2 for ; Thu, 7 Nov 2024 19:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008900; cv=none; b=lG/nMz4WIXSw+7vADlal7jdWV6RJZGeVBgzvYcEn+tM2j9ml9tZjVFzZ8cy0pr5xwDgtVqBof95H4IgR5gfTF4hDQ4IbB9kQ67G9LwHG19J62KNtXs3afFtm0FdGrBOI/DjhpH1UFmJLuBi0PvOqZXeuL/2+ty3gPjSZ0sXXPbg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008900; c=relaxed/simple; bh=RO0c7EoopaN1SQrMONOFRGPZT4eehsDieDHwLK5y4+E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jkehRrLJNbQCUEhbBODf6TXee507UPDNsUhJvuW3KVpsa4CX2O2dVpnzMhWfhEsUPdkXqsLJvE/jRax0gF8we7Nca0Ry5PjNbYlSmJfGJjhsGujfcIMy7mirO/SRyhLKrYmiROs+HVcmF1QRla+3xyKWAteLN4/qMTiisk5awto= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=fLGm/iU9; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="fLGm/iU9" Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9B2E0792; Thu, 7 Nov 2024 20:48:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008888; bh=RO0c7EoopaN1SQrMONOFRGPZT4eehsDieDHwLK5y4+E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fLGm/iU9sPvAnn5tjy3RYomLWN8cyiFhWWvRWnnRM9g4mdkwHcPj8VlW+G5pyUI1T zx6AHenunLiXvdYbdB2obf1uUVTpwHVXABPVcs98qoNCyAkZUf7+NyV2l1SUnB7c6b VVmUp/zSpJ74TS9VCvXHjwAeXePD98oyNdsS8t1Q= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 1/3] staging: vc04_services: Cleanup TODO entry Date: Fri, 8 Nov 2024 01:18:04 +0530 Message-ID: <20241107194806.90408-2-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The TODO entry "Fix behvaiour of message handling" no longer applies due to killable completions [1]. Drop the entry from TODO list. [1] https://lore.kernel.org/all/20240918163100.870596-1-umang.jain@ideasonb= oard.com/ Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/TODO | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/staging/vc04_services/interface/TODO b/drivers/staging= /vc04_services/interface/TODO index 2ae75362421b..f6f24600aa86 100644 --- a/drivers/staging/vc04_services/interface/TODO +++ b/drivers/staging/vc04_services/interface/TODO @@ -26,12 +26,3 @@ kthreads, userspace, limitations) could be very helpful = for reviewers. The code follows the 80 characters limitation yet tends to go 3 or 4 level= s of indentation deep making it very unpleasant to read. This is specially rele= vant in the character driver ioctl code and in the core thread functions. - -* Fix behavior of message handling - -The polling behavior of vchiq_bulk_transmit(), vchiq_bulk_receive() and -vchiq_queue_kernel_message() looks broken. A possible signal should be -propagated back to user space to let the calling task handle it before -retrying. Hopefully these msleep(1) shouldn't be necessary anymore. - -https://lore.kernel.org/linux-staging/CAK8P3a3HGm1cPo4sW9fOY4E8AN8yAq3tevX= xU5m8bmtmsU8WKw@mail.gmail.com/ --=20 2.45.2 From nobody Sun Nov 24 02:37:08 2024 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BE85218300 for ; Thu, 7 Nov 2024 19:48:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008903; cv=none; b=PyIZHHENJfSB+piYjFQ5nDTr8fYTi1K3XQoUpMXSBSKy9tN/5IDFS/3EN1I6MR/tXU+5Lrwg8oUYn8XT8zj2TRsS9nVSQrmIdkf8MtWF6NUhCGTLoGfOsKREMB5YrVeNqbTmNoC2BUC5SaMPqFZL/U/AbNM89p+aR5gFeWWwnEI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008903; c=relaxed/simple; bh=u3Nlc3VrK6eIFZ/S5a9xrWzVB09MmxR0BHD8rNbHZ9w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EXZqehzTzJjtQeE/196DzS4KUENC1JAUDsatP5z2RnLkLWVCKI2btKVyc6OB84x/amHieO2/tgEH+/mF4oZJS+hsh9wblN103C8+FQQUcsdQ+beUvnDuyIUaPlCf+Adyk5pvemjV5WVxjWMrv7wIAqi430oMdqxO2YbBcvF2s5E= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Plgr2cOE; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Plgr2cOE" Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 87AF899F; Thu, 7 Nov 2024 20:48:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008890; bh=u3Nlc3VrK6eIFZ/S5a9xrWzVB09MmxR0BHD8rNbHZ9w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Plgr2cOEIf3tTqxCgt5dXMIK+DMiSd+f4ueONz75ODGLhPZbcybzbHcYDu9+zAGYW DFFYlu5piJdtUoaivonivYdwdodXVR1U+0YcIM3izORQcl9n7eEO+digqYgj52AoUx QVPSyDDH8JSjT9hnTlgQRGmSKMB0pxCeAWlpfeU0= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 2/3] staging: vchiq_core: Rectify header include for vchiq_dump_state() Date: Fri, 8 Nov 2024 01:18:05 +0530 Message-ID: <20241107194806.90408-3-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The header vchiq_core.h does not need . It needs the for vchiq_dump_state() to dump the vchiq state through vchiq_debugfs.[ch]. Signed-off-by: Umang Jain --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h= b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index fadca7b1b196..9b4e766990a4 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -7,11 +7,11 @@ #include #include #include -#include #include #include #include #include +#include #include #include =20 --=20 2.45.2 From nobody Sun Nov 24 02:37:08 2024 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F318218313 for ; Thu, 7 Nov 2024 19:48:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008903; cv=none; b=QXmMyF5UTqg7tpwRqFJBcBNVD40T00ZTa2YLuWDbA1lX7vY3CKT5wVbNaVSDngT2VpHL/2rag3FHNyvOJ5Ig1vFWMKRvIxh+BD+lDihtUDjGHOI0EMsM6JvjE7vYtVG5CzxPBiVwTi/N4VcGno7sPhORW3qwRDV4Wsj90oGeiNQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731008903; c=relaxed/simple; bh=f0YywPWanEM24s0q52GKso9Nv195uicG46KTsPUxLW8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BH9ADiTk+Ouk9kcIsqdsedc7E4nil6B9a6M3IGWg8JgSWPpRGxjUI5s5bQNRmNLNShqy593s4cLV98vMH4RUFprCe7Zbi7LR3pcNUztcnSMeEN7GobKbZm789U6jnNUf4ySsjH1gV0ZN7iLdhdb/bW0SodGeAYCRrAzf6Hzu9So= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ZyAD5dPw; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZyAD5dPw" Received: from umang.jain (unknown [IPv6:2405:201:2015:f873:c173:4b:4a04:3a21]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 7B4DFA44; Thu, 7 Nov 2024 20:48:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1731008892; bh=f0YywPWanEM24s0q52GKso9Nv195uicG46KTsPUxLW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZyAD5dPwUsqoCX0oK08eQBVUxzuucLvpE56CEQAcS1Bg2BQ5gySzMC4cKZgAS41Px 0VteNgF5hMwh7EEv6c37NDD6FUPMz8ha9H6yXOXyWJxiO9r9N9TDBOv4EbXHM1ob54 vurRy453/TxYeVJO2wOYSU6LAEe/j+XR/1GEGuOo= From: Umang Jain To: Greg Kroah-Hartman , Broadcom internal kernel review list Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , Kieran Bingham , Stefan Wahren , Umang Jain Subject: [PATCH 3/3] staging: vchiq_debugfs: Use forward declarations Date: Fri, 8 Nov 2024 01:18:06 +0530 Message-ID: <20241107194806.90408-4-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241107194806.90408-1-umang.jain@ideasonboard.com> References: <20241107194806.90408-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Use forward declarations for struct vchiq_state and vchiq_instance. We can then drop the vchiq_core.h header from vchiq_debugfs.h. Signed-off-by: Umang Jain --- .../staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugf= s.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h index fabffd81b1ec..b29e6693c949 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_debugfs.h @@ -4,7 +4,8 @@ #ifndef VCHIQ_DEBUGFS_H #define VCHIQ_DEBUGFS_H =20 -#include "vchiq_core.h" +struct vchiq_state; +struct vchiq_instance; =20 struct vchiq_debugfs_node { struct dentry *dentry; --=20 2.45.2