From nobody Sun Nov 24 04:45:23 2024 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5781F4298 for ; Thu, 7 Nov 2024 11:18:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978308; cv=none; b=NynQsXpez03+VcbEP5YSulTxngmXi5ZT4NjVbhzrPTxnTUeAS8QxtPxlNzUex9g+C7276NTegaAFVjQgVb/Ss75kQQpUV099j/wv6DApvTmj80bhKQL3qRddSYsbhR/6DzCg+eeE5KDUTTsYa6WVY2spOE9PDTMJvEkrRZhEQsQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978308; c=relaxed/simple; bh=n/wesm0uKO7AlZ/J2WWe+dCoVouDNP5+tIlmkRDg3qw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pvuMJZyVjPg10zDFpVr3ROM78lSXfwZ6zNRcENRYxCouxszc0on+MIZCjyR6mNIcts66jvJwHKaOMg7ywrxHN2KQoaI2N/2s/K/FhnWqSFMV+/xiyXvN2CkO5EzZ6WQJ7IbcDVqQYEI0Y9JL7PgRNqWgZfmvdhU28T5xQEM/ZIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=wtsNZeNO; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=94PFRSzp; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="wtsNZeNO"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="94PFRSzp" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlnDNt/q+P1z8kgLF+N992bHvMJ9T7IfJZldadLin68=; b=wtsNZeNOyMJaldtbOFaqNx8Fida5NHgixfmht+XXgQL0xo2mc7k4R5BDokhZGEAAf8puhY RdaNsQqt5gLo9RzhmXtjmMEXAPSzEDrdEM428J0L8X8bgAKSqxHlUZmercMPgiaI4clbkB ovMAgCRyrdKw8bOWUgivcosNYwZGearQAPTjk3OWJxxP/+/QluQm+XzyzydmSOR1TurxAw 1VcmIe6jEMY5XIEv8bkhXi30L0O0zucKKTJ/kmEtxzTugkWiTe09cQe2z1SvGwVM/L0Uyt IymvOb70uBfkVjuv82GnKmMyUulUqf+9FRNZl+3BDNeakG35dM8WrAZv2JZZ1g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rlnDNt/q+P1z8kgLF+N992bHvMJ9T7IfJZldadLin68=; b=94PFRSzpi6CjV9+fwfoYfFcVVSDiklFOujZck6z98CsK6lfD6ykQFvnYpIGnoHzKMnEoru u2W1K7fZOV3JHVAA== To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" , Boqun Feng , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au, Sebastian Andrzej Siewior Subject: [PATCH v2 1/3] scftorture: Avoid additional div operation. Date: Thu, 7 Nov 2024 12:13:06 +0100 Message-ID: <20241107111821.3417762-2-bigeasy@linutronix.de> In-Reply-To: <20241107111821.3417762-1-bigeasy@linutronix.de> References: <20241107111821.3417762-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace "scfp->cpu % nr_cpu_ids" with "cpu". This has been computed earlier. Signed-off-by: Sebastian Andrzej Siewior Tested-by: Paul E. McKenney --- kernel/scftorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 44e83a6462647..455cbff35a1a2 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -463,7 +463,7 @@ static int scftorture_invoker(void *arg) =20 // Make sure that the CPU is affinitized appropriately during testing. curcpu =3D raw_smp_processor_id(); - WARN_ONCE(curcpu !=3D scfp->cpu % nr_cpu_ids, + WARN_ONCE(curcpu !=3D cpu, "%s: Wanted CPU %d, running on %d, nr_cpu_ids =3D %d\n", __func__, scfp->cpu, curcpu, nr_cpu_ids); =20 --=20 2.45.2 From nobody Sun Nov 24 04:45:23 2024 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C64A1F582B for ; Thu, 7 Nov 2024 11:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978308; cv=none; b=GlouQnXWgSs3QFktJNOC4mcadSAxzdqA9coJ6KGLZn/lbu2YAO12y2hOAc+sh7btMEl4HRU+XC9xcRVXU9OGPvHpuiFLQOs4JEQEoqeGBkkWhc9uYinrofhOer2vsgg4RMqAaCTfUvl3hkhSE9jaducOHcbZ6OuNgnHZwKOQq78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978308; c=relaxed/simple; bh=xXgdPQajIX3QF9Pj+zYTgpnN5VTr6dxFGsnPh/dOmgk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LIcjj9mcFCSI1A1lxFfSu3dDafg7z+wwDtjbquNDWQbgUBav2ERo0wHhheocJAc3InssPCMn+r8C2/+uwZCiy2KlJNrh2eMeuzrUExV936JGwqUtNxF423uE8Wkj5X9Gm0kHAiQJW+IWulq5gGvhTVJZbMGW8IK98ijarQd+yVw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=M9xvkSfR; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=KnxUBCaR; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="M9xvkSfR"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="KnxUBCaR" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gSS1F9zfYFqWED7mnEuItD0xDLRRE+69aaEbBshj25g=; b=M9xvkSfRi0mLUpX9TLv4MNv7FmIhnXB2PGcxl8jqrsZiTgmfXRBrLhJpqFMwH7Uch3kAc0 Zgq5WD3+uqCt0eWW7v/qYhFeIIFg+7gSe1HKqZTPiut9f7Nis8B0xtXwsCcBUfiRJZmYI9 f4ks6rTTH/lP2QUC1WpSLTqTVjPGBAxeJk77KGrjHjmpZry5sAqKOspHaB85k+uv/YpO3j wFY/7jBhLyKRB8MVxFb4SAPQP4KvF4hkpyOem2RkBmMB2phCWxSH06T9nGeKeCpXC9mS0W 4zW4IJ+UDHlgfIK2+ko98AltF74QmSgKRxPRF4YjOWQ+JWpVccUKawT/MVp8sg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gSS1F9zfYFqWED7mnEuItD0xDLRRE+69aaEbBshj25g=; b=KnxUBCaRXPrO8SHNZYEuBzqr9XpR/DJfDS0jlMBpakInVwKuNBU6xlNJN/hBffhYxpmnVc Lj9nJ2NCMjyOJXDQ== To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" , Boqun Feng , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au, Sebastian Andrzej Siewior Subject: [PATCH v2 2/3] scftorture: Move memory allocation outside of preempt_disable region. Date: Thu, 7 Nov 2024 12:13:07 +0100 Message-ID: <20241107111821.3417762-3-bigeasy@linutronix.de> In-Reply-To: <20241107111821.3417762-1-bigeasy@linutronix.de> References: <20241107111821.3417762-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Memory allocations can not happen within regions with explicit disabled preemption PREEMPT_RT. The problem is that the locking structures underneath are sleeping locks. Move the memory allocation outside of the preempt-disabled section. Keep the GFP_ATOMIC for the allocation to behave like a "ememergncy allocation". Signed-off-by: Sebastian Andrzej Siewior Tested-by: Paul E. McKenney --- kernel/scftorture.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 455cbff35a1a2..555b3b10621fe 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -320,10 +320,6 @@ static void scftorture_invoke_one(struct scf_statistic= s *scfp, struct torture_ra struct scf_check *scfcp =3D NULL; struct scf_selector *scfsp =3D scf_sel_rand(trsp); =20 - if (use_cpus_read_lock) - cpus_read_lock(); - else - preempt_disable(); if (scfsp->scfs_prim =3D=3D SCF_PRIM_SINGLE || scfsp->scfs_wait) { scfcp =3D kmalloc(sizeof(*scfcp), GFP_ATOMIC); if (!scfcp) { @@ -337,6 +333,10 @@ static void scftorture_invoke_one(struct scf_statistic= s *scfp, struct torture_ra scfcp->scfc_rpc =3D false; } } + if (use_cpus_read_lock) + cpus_read_lock(); + else + preempt_disable(); switch (scfsp->scfs_prim) { case SCF_PRIM_RESCHED: if (IS_BUILTIN(CONFIG_SCF_TORTURE_TEST)) { --=20 2.45.2 From nobody Sun Nov 24 04:45:23 2024 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B55A61F5844 for ; Thu, 7 Nov 2024 11:18:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978310; cv=none; b=rxpRqG4i6H2pZS3NlKxf34EwqKTEPbaXe6dgdSUZQDsYxjTnvJ4AIS18L7xFnwTP5dngbEJEbysX0AU+VvuWyRivT7AUnBb2aMQ9bNErhMieB5vT0ze56lVGFR3Wnl/IvILyuE+sHZqC+ntv4UHScZaFQVThKmx87xpskg0q+7I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730978310; c=relaxed/simple; bh=qa7ziYpoaJsIzOf/1KHhQOXPGsum/b3J+a0FOaXGg4o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uMJN1uW85TvNnDvN6VGhXw08OpVA0subeCMXF18RILBTEh6TgreeAtJEVLRj2+dEspDyvLGqJZgqIpV6b85x+zF7H32tACiPL7TikMGO4MXqvHiYqXZwfFWq/CtA9IlbIZtlztvUCh1ci5NsIfRgbVcGJt+F1DGNLiuAmFkFwSU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=hebjJzYt; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=6rBlaRMX; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="hebjJzYt"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="6rBlaRMX" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UREpr2g7dNESBp66vCKny1OLw5nYLTave8FGBQMbiqs=; b=hebjJzYt5XphUNmoFrKvrRey/8dSLOnZF+JVRGOlYlm0vHgkXUhLb2qING2kAiqHPYaesF +6JwaIot+DsI5wIYho72FiJO/MCvu1hhIXayNgicQBTDb0ZCIqVuCGeOFfd6RL4MuLKooF OAU7VSdzQqjrKU9J5xtOvdpqeaHAp/L7195AFiV1Gl0dErQSAwL8clasnyAe9NPqFTkUDS v0vhAOU+sDLxfPnDuLmgo9W2qsL+PJXX3L9FsXsXFDQ14Tin0BVsmDqjxSac4Kf+W2wXjj Otc1m0GaoC0cKcq0OCjJEZ8iSz2OppX9HYbpFR6BEfpr8LwQ876PK4XoIUgL+A== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730978304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UREpr2g7dNESBp66vCKny1OLw5nYLTave8FGBQMbiqs=; b=6rBlaRMXpg74iBIs0MX5d43tUWarZm/yzruVF2Ngma8aPTtKThQISSfBrY5vOrQGKd2fUK rvaNMEM3oa1+C9Aw== To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" , Boqun Feng , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au, Sebastian Andrzej Siewior Subject: [PATCH v2 3/3] scftorture: Use a lock-less list to free memory. Date: Thu, 7 Nov 2024 12:13:08 +0100 Message-ID: <20241107111821.3417762-4-bigeasy@linutronix.de> In-Reply-To: <20241107111821.3417762-1-bigeasy@linutronix.de> References: <20241107111821.3417762-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" scf_handler() is used as a SMP function call. This function is always invoked in IRQ-context even with forced-threading enabled. This function frees memory which not allowed on PREEMPT_RT because the locking underneath is using sleeping locks. Add a per-CPU scf_free_pool where each SMP functions adds its memory to be freed. This memory is then freed by scftorture_invoker() on each iteration. On the majority of invocations the number of items is less than five. If the thread sleeps/ gets delayed the number exceed 350 but did not reach 400 in testing. These were the spikes during testing. The bulk free of 64 pointers at once should improve the give-back if the list grows. The list size is ~1.3 items per invocations. Having one global scf_free_pool with one cleaning thread let the list grow to over 10.000 items with 32 CPUs (again, spikes not the average) especially if the CPU went to sleep. The per-CPU part looks like a good compromise. Reported-by: "Paul E. McKenney" Closes: https://lore.kernel.org/lkml/41619255-cdc2-4573-a360-7794fc3614f7@p= aulmck-laptop/ Signed-off-by: Sebastian Andrzej Siewior Tested-by: Paul E. McKenney --- kernel/scftorture.c | 39 +++++++++++++++++++++++++++++++++++---- 1 file changed, 35 insertions(+), 4 deletions(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 555b3b10621fe..1268a91af5d88 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -97,6 +97,7 @@ struct scf_statistics { static struct scf_statistics *scf_stats_p; static struct task_struct *scf_torture_stats_task; static DEFINE_PER_CPU(long long, scf_invoked_count); +static DEFINE_PER_CPU(struct llist_head, scf_free_pool); =20 // Data for random primitive selection #define SCF_PRIM_RESCHED 0 @@ -133,6 +134,7 @@ struct scf_check { bool scfc_wait; bool scfc_rpc; struct completion scfc_completion; + struct llist_node scf_node; }; =20 // Use to wait for all threads to start. @@ -148,6 +150,31 @@ static DEFINE_TORTURE_RANDOM_PERCPU(scf_torture_rand); =20 extern void resched_cpu(int cpu); // An alternative IPI vector. =20 +static void scf_add_to_free_list(struct scf_check *scfcp) +{ + struct llist_head *pool; + unsigned int cpu; + + cpu =3D raw_smp_processor_id() % nthreads; + pool =3D &per_cpu(scf_free_pool, cpu); + llist_add(&scfcp->scf_node, pool); +} + +static void scf_cleanup_free_list(unsigned int cpu) +{ + struct llist_head *pool; + struct llist_node *node; + struct scf_check *scfcp; + + pool =3D &per_cpu(scf_free_pool, cpu); + node =3D llist_del_all(pool); + while (node) { + scfcp =3D llist_entry(node, struct scf_check, scf_node); + node =3D node->next; + kfree(scfcp); + } +} + // Print torture statistics. Caller must ensure serialization. static void scf_torture_stats_print(void) { @@ -296,7 +323,7 @@ static void scf_handler(void *scfc_in) if (scfcp->scfc_rpc) complete(&scfcp->scfc_completion); } else { - kfree(scfcp); + scf_add_to_free_list(scfcp); } } =20 @@ -363,7 +390,7 @@ static void scftorture_invoke_one(struct scf_statistics= *scfp, struct torture_ra scfp->n_single_wait_ofl++; else scfp->n_single_ofl++; - kfree(scfcp); + scf_add_to_free_list(scfcp); scfcp =3D NULL; } break; @@ -391,7 +418,7 @@ static void scftorture_invoke_one(struct scf_statistics= *scfp, struct torture_ra preempt_disable(); } else { scfp->n_single_rpc_ofl++; - kfree(scfcp); + scf_add_to_free_list(scfcp); scfcp =3D NULL; } break; @@ -428,7 +455,7 @@ static void scftorture_invoke_one(struct scf_statistics= *scfp, struct torture_ra pr_warn("%s: Memory-ordering failure, scfs_prim: %d.\n", __func__, scfs= p->scfs_prim); atomic_inc(&n_mb_out_errs); // Leak rather than trash! } else { - kfree(scfcp); + scf_add_to_free_list(scfcp); } barrier(); // Prevent race-reduction compiler optimizations. } @@ -479,6 +506,8 @@ static int scftorture_invoker(void *arg) VERBOSE_SCFTORTOUT("scftorture_invoker %d started", scfp->cpu); =20 do { + scf_cleanup_free_list(cpu); + scftorture_invoke_one(scfp, &rand); while (cpu_is_offline(cpu) && !torture_must_stop()) { schedule_timeout_interruptible(HZ / 5); @@ -538,6 +567,8 @@ static void scf_torture_cleanup(void) =20 end: torture_cleanup_end(); + for (i =3D 0; i < nthreads; i++) + scf_cleanup_free_list(i); } =20 static int __init scf_torture_init(void) --=20 2.45.2 From nobody Sun Nov 24 04:45:23 2024 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B2EA1E7676 for ; Thu, 7 Nov 2024 15:27:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730993261; cv=none; b=B8VMeFoAg/3E0ex39Hwsib4tVvpMerAiKkrbl6tDRUWVhhzqRxZ2dwXtiR/aCCXSgr374N9r2o3ut/LJHswxqee7UnPRB5/31w8/5L76TxgGSAVah/QiHpo+VceBan/e+X/sltZUHMQvtd3HhgM0boub6+vmt/ENHlnUfn6m9ks= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730993261; c=relaxed/simple; bh=ZZu2BXSdjUtMwxAWzNqbqFoawcRzg9hKYNF9EMvsMPU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oFfX8uxFXGhqiPmq2MiZD0o0nzOvA0YRaIehivfMMRkQ9m+LO+4QbiKOTmeTdg7GTtfnNxYK05Q23avlo2pd2PPacHcuDII0b92ii8UxdatYMXboQf3K2FmkTPlVO5TPT6UKjIlQhrYSFi31yUWmpqhbRxyjjtZNmo3zpoeoULE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=4gWnbb0J; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ZxTtCI6C; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="4gWnbb0J"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ZxTtCI6C" Date: Thu, 7 Nov 2024 16:27:36 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1730993257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9GAkp6axrm31ZMYGbMxCuOZ4EkrG3h1hb4DuwNIX7w=; b=4gWnbb0JPA6louZB7MhLxMUhWSLppTnsLQbINltZYCdkRoFvDAOb8+j8uG1uTAQ31JdCBw 8bq2UJJC8T03kvvs8d9RqMv7kYIY8H147SAnH7YP+jVL3eCAIFbzk2URYTOyr0nZc6cYKo AitVwZZe8xTdc9dIk7S/lbQnDuh1aDKS8uNBTInwEVbJ0r7mMDIznyADV1VSwmw1u/bVnY I2lprx7i6DVpgJ0dV+DcIs87c3MlalAbPOO/L3q1nD9qMM9CiTOj9ZvHyc0O1fbqKPjdVk uYLcT3kZz0zGuryquAThpQ3caFZsH2LksUvyBtOo7XUP5SLyCaaIiUPwTaGUhg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1730993257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9GAkp6axrm31ZMYGbMxCuOZ4EkrG3h1hb4DuwNIX7w=; b=ZxTtCI6CCJFS73eVuWExDYOllEmHp7Pxsrcs7aU7TeuBaqEJUgzfINiHhmE64uY9O5/NXf 4Bbi4xp5gjVmDpDg== From: Sebastian Andrzej Siewior To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: "Paul E. McKenney" , Boqun Feng , Marco Elver , Peter Zijlstra , Tomas Gleixner , Vlastimil Babka , akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com, longman@redhat.com, penberg@kernel.org, rientjes@google.com, sfr@canb.auug.org.au Subject: [PATCH v2 4/3] scftorture: Wait until scf_cleanup_handler() completes. Message-ID: <20241107152736.BJPBLXGO@linutronix.de> References: <20241107111821.3417762-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20241107111821.3417762-1-bigeasy@linutronix.de> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The smp_call_function() needs to be invoked with the wait flag set to wait until scf_cleanup_handler() is done. This ensures that all SMP function calls, that have been queued earlier, complete at this point. Signed-off-by: Sebastian Andrzej Siewior Tested-by: Paul E. McKenney --- kernel/scftorture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/scftorture.c b/kernel/scftorture.c index 1268a91af5d88..ee8831096c091 100644 --- a/kernel/scftorture.c +++ b/kernel/scftorture.c @@ -552,7 +552,7 @@ static void scf_torture_cleanup(void) torture_stop_kthread("scftorture_invoker", scf_stats_p[i].task); else goto end; - smp_call_function(scf_cleanup_handler, NULL, 0); + smp_call_function(scf_cleanup_handler, NULL, 1); torture_stop_kthread(scf_torture_stats, scf_torture_stats_task); scf_torture_stats_print(); // -After- the stats thread is stopped! kfree(scf_stats_p); // -After- the last stats print has completed! --=20 2.45.2