From nobody Sun Nov 24 11:16:50 2024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0D6E1FEFD5 for ; Wed, 6 Nov 2024 12:39:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896760; cv=none; b=n+64iW+alNcyQ3n6/EVr6uTOFiIzCizBeqpU0sE54Dt7TDxT4WjGCv2CrV9TWe/8alS5JkB2jw+Q8wssQ8RoxiKztuy4NDMgyt27NanRbvQ9Z2Lt4hnH2IFd3ARnzR/oenm9gdvOJLYKlzaVau5yOcZ+VbFonTbxKWPZu8j/hE8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730896760; c=relaxed/simple; bh=UmlFcj8tXOOokXfBucQp9mv1mu7Iq78kv8AF7oENJ+4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PtQQYHT4dFvPbjdL8JNA5x9RWv/uvPpz6gmEQ6zN5mmVlF7HXKbcoNMNEusnS9JrvQlWDxBmLREiQoeCtXK3nAoi7rw3rR9dKTgVfThFRWcN1GTcJ8YuE7tSxqTytmgfd2nlh37ZXfGbJi+h/YsInHauhzcFvluORsWLCZlK3/s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=JFKyltZw; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="JFKyltZw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730896757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=amC5aop3KJx0r1HYYuGRhvQAJFiWIu7nIKfZ7/jIV/8=; b=JFKyltZw8EVd5cTApPoietuJcXMuf1FIaU51xitso01bHFlVayIpAfmYPpBmkzYY4DLW5A DDPc4SpUliI2SNI9iV5d9XtgVODRTFHKic114COVWkqD7RknEOXX5BeeNFg88qpi23iBE8 cRSiyw1Qj/gYuZQZ+goEq7Q5AedtGco= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-bgLSGnt1O0Sbwlr6Xohwmw-1; Wed, 06 Nov 2024 07:39:13 -0500 X-MC-Unique: bgLSGnt1O0Sbwlr6Xohwmw-1 X-Mimecast-MFC-AGG-ID: bgLSGnt1O0Sbwlr6Xohwmw Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 71FDA1955F3C; Wed, 6 Nov 2024 12:39:10 +0000 (UTC) Received: from warthog.procyon.org.uk.com (unknown [10.42.28.231]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1CA78195607C; Wed, 6 Nov 2024 12:39:02 +0000 (UTC) From: David Howells To: Christian Brauner , Steve French , Matthew Wilcox Cc: David Howells , Jeff Layton , Gao Xiang , Dominique Martinet , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Eric Van Hensbergen , Ilya Dryomov , netfs@lists.linux.dev, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 24/33] afs: Use netfslib for symlinks, allowing them to be cached Date: Wed, 6 Nov 2024 12:35:48 +0000 Message-ID: <20241106123559.724888-25-dhowells@redhat.com> In-Reply-To: <20241106123559.724888-1-dhowells@redhat.com> References: <20241106123559.724888-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Content-Type: text/plain; charset="utf-8" Use netfslib to read symlinks, thereby allowing them to be cached by fscache and cachefiles. Signed-off-by: David Howells cc: Marc Dionne cc: Jeff Layton cc: linux-afs@lists.infradead.org cc: netfs@lists.linux.dev cc: linux-fsdevel@vger.kernel.org --- fs/afs/file.c | 32 ------------------- fs/afs/inode.c | 64 +++++++++++++++++++++++++++++++++++--- fs/afs/internal.h | 4 ++- fs/afs/mntpt.c | 22 ++++++------- include/trace/events/afs.h | 1 + 5 files changed, 74 insertions(+), 49 deletions(-) diff --git a/fs/afs/file.c b/fs/afs/file.c index 5bc36bfaa173..48695a50d2f9 100644 --- a/fs/afs/file.c +++ b/fs/afs/file.c @@ -20,7 +20,6 @@ #include "internal.h" =20 static int afs_file_mmap(struct file *file, struct vm_area_struct *vma); -static int afs_symlink_read_folio(struct file *file, struct folio *folio); =20 static ssize_t afs_file_read_iter(struct kiocb *iocb, struct iov_iter *ite= r); static ssize_t afs_file_splice_read(struct file *in, loff_t *ppos, @@ -61,13 +60,6 @@ const struct address_space_operations afs_file_aops =3D { .writepages =3D afs_writepages, }; =20 -const struct address_space_operations afs_symlink_aops =3D { - .read_folio =3D afs_symlink_read_folio, - .release_folio =3D netfs_release_folio, - .invalidate_folio =3D netfs_invalidate_folio, - .migrate_folio =3D filemap_migrate_folio, -}; - static const struct vm_operations_struct afs_vm_ops =3D { .open =3D afs_vm_open, .close =3D afs_vm_close, @@ -346,30 +338,6 @@ static void afs_issue_read(struct netfs_io_subrequest = *subreq) queue_work(system_long_wq, &subreq->work); } =20 -static int afs_symlink_read_folio(struct file *file, struct folio *folio) -{ - struct afs_vnode *vnode =3D AFS_FS_I(folio->mapping->host); - struct afs_read *fsreq; - int ret; - - fsreq =3D afs_alloc_read(GFP_NOFS); - if (!fsreq) - return -ENOMEM; - - fsreq->pos =3D folio_pos(folio); - fsreq->len =3D folio_size(folio); - fsreq->vnode =3D vnode; - fsreq->iter =3D &fsreq->def_iter; - iov_iter_xarray(&fsreq->def_iter, ITER_DEST, &folio->mapping->i_pages, - fsreq->pos, fsreq->len); - - ret =3D afs_fetch_data(fsreq->vnode, fsreq); - if (ret =3D=3D 0) - folio_mark_uptodate(folio); - folio_unlock(folio); - return ret; -} - static int afs_init_request(struct netfs_io_request *rreq, struct file *fi= le) { struct afs_vnode *vnode =3D AFS_FS_I(rreq->inode); diff --git a/fs/afs/inode.c b/fs/afs/inode.c index 0ed1e5c35fef..6f27a2b4bf5a 100644 --- a/fs/afs/inode.c +++ b/fs/afs/inode.c @@ -25,8 +25,60 @@ #include "internal.h" #include "afs_fs.h" =20 +static void afs_put_link(void *arg) +{ + struct folio *folio =3D virt_to_folio(arg); + + kunmap_local(arg); + folio_put(folio); +} + +const char *afs_get_link(struct dentry *dentry, struct inode *inode, + struct delayed_call *callback) +{ + struct afs_vnode *vnode =3D AFS_FS_I(inode); + struct folio *folio; + char *content; + ssize_t ret; + + if (atomic64_read(&vnode->cb_expires_at) =3D=3D AFS_NO_CB_PROMISE || + !vnode->directory) { + if (!dentry) + return ERR_PTR(-ECHILD); + ret =3D afs_read_single(vnode, NULL); + if (ret < 0) + return ERR_PTR(ret); + } + + folio =3D folioq_folio(vnode->directory, 0); + folio_get(folio); + content =3D kmap_local_folio(folio, 0); + set_delayed_call(callback, afs_put_link, content); + return content; +} + +int afs_readlink(struct dentry *dentry, char __user *buffer, int buflen) +{ + DEFINE_DELAYED_CALL(done); + const char *content; + int len; + + content =3D afs_get_link(dentry, d_inode(dentry), &done); + if (IS_ERR(content)) { + do_delayed_call(&done); + return PTR_ERR(content); + } + + len =3D umin(strlen(content), buflen); + if (copy_to_user(buffer, content, len)) + len =3D -EFAULT; + do_delayed_call(&done); + return len; +} + static const struct inode_operations afs_symlink_inode_operations =3D { - .get_link =3D page_get_link, + .get_link =3D afs_get_link, + .readlink =3D afs_readlink, }; =20 static noinline void dump_vnode(struct afs_vnode *vnode, struct afs_vnode = *parent_vnode) @@ -124,13 +176,13 @@ static int afs_inode_init_from_status(struct afs_oper= ation *op, inode->i_mode =3D S_IFDIR | 0555; inode->i_op =3D &afs_mntpt_inode_operations; inode->i_fop =3D &afs_mntpt_file_operations; - inode->i_mapping->a_ops =3D &afs_symlink_aops; } else { inode->i_mode =3D S_IFLNK | status->mode; inode->i_op =3D &afs_symlink_inode_operations; - inode->i_mapping->a_ops =3D &afs_symlink_aops; } + inode->i_mapping->a_ops =3D &afs_dir_aops; inode_nohighmem(inode); + mapping_set_release_always(inode->i_mapping); break; default: dump_vnode(vnode, op->file[0].vnode !=3D vnode ? op->file[0].vnode : NUL= L); @@ -443,7 +495,8 @@ static void afs_get_inode_cache(struct afs_vnode *vnode) struct afs_vnode_cache_aux aux; =20 if (vnode->status.type !=3D AFS_FTYPE_FILE && - vnode->status.type !=3D AFS_FTYPE_DIR) { + vnode->status.type !=3D AFS_FTYPE_DIR && + vnode->status.type !=3D AFS_FTYPE_SYMLINK) { vnode->netfs.cache =3D NULL; return; } @@ -657,7 +710,8 @@ void afs_evict_inode(struct inode *inode) =20 ASSERTCMP(inode->i_ino, =3D=3D, vnode->fid.vnode); =20 - if ((S_ISDIR(inode->i_mode)) && + if ((S_ISDIR(inode->i_mode) || + S_ISLNK(inode->i_mode)) && (inode->i_state & I_DIRTY) && !sbi->dyn_root) { struct writeback_control wbc =3D { diff --git a/fs/afs/internal.h b/fs/afs/internal.h index ecf5df9ca12c..6fa3b1dd4c98 100644 --- a/fs/afs/internal.h +++ b/fs/afs/internal.h @@ -1115,7 +1115,6 @@ extern void afs_dynroot_depopulate(struct super_block= *); * file.c */ extern const struct address_space_operations afs_file_aops; -extern const struct address_space_operations afs_symlink_aops; extern const struct inode_operations afs_file_inode_operations; extern const struct file_operations afs_file_operations; extern const struct netfs_request_ops afs_req_ops; @@ -1221,6 +1220,9 @@ extern void afs_fs_probe_cleanup(struct afs_net *); */ extern const struct afs_operation_ops afs_fetch_status_operation; =20 +const char *afs_get_link(struct dentry *dentry, struct inode *inode, + struct delayed_call *callback); +int afs_readlink(struct dentry *dentry, char __user *buffer, int buflen); extern void afs_vnode_commit_status(struct afs_operation *, struct afs_vno= de_param *); extern int afs_fetch_status(struct afs_vnode *, struct key *, bool, afs_ac= cess_t *); extern int afs_ilookup5_test_by_fid(struct inode *, void *); diff --git a/fs/afs/mntpt.c b/fs/afs/mntpt.c index 297487ee8323..507c25a5b2cb 100644 --- a/fs/afs/mntpt.c +++ b/fs/afs/mntpt.c @@ -30,7 +30,7 @@ const struct file_operations afs_mntpt_file_operations = =3D { =20 const struct inode_operations afs_mntpt_inode_operations =3D { .lookup =3D afs_mntpt_lookup, - .readlink =3D page_readlink, + .readlink =3D afs_readlink, .getattr =3D afs_getattr, }; =20 @@ -118,9 +118,9 @@ static int afs_mntpt_set_params(struct fs_context *fc, = struct dentry *mntpt) ctx->volnamesz =3D sizeof(afs_root_volume) - 1; } else { /* read the contents of the AFS special symlink */ - struct page *page; + DEFINE_DELAYED_CALL(cleanup); + const char *content; loff_t size =3D i_size_read(d_inode(mntpt)); - char *buf; =20 if (src_as->cell) ctx->cell =3D afs_use_cell(src_as->cell, afs_cell_trace_use_mntpt); @@ -128,16 +128,16 @@ static int afs_mntpt_set_params(struct fs_context *fc= , struct dentry *mntpt) if (size < 2 || size > PAGE_SIZE - 1) return -EINVAL; =20 - page =3D read_mapping_page(d_inode(mntpt)->i_mapping, 0, NULL); - if (IS_ERR(page)) - return PTR_ERR(page); + content =3D afs_get_link(mntpt, d_inode(mntpt), &cleanup); + if (IS_ERR(content)) { + do_delayed_call(&cleanup); + return PTR_ERR(content); + } =20 - buf =3D kmap(page); ret =3D -EINVAL; - if (buf[size - 1] =3D=3D '.') - ret =3D vfs_parse_fs_string(fc, "source", buf, size - 1); - kunmap(page); - put_page(page); + if (content[size - 1] =3D=3D '.') + ret =3D vfs_parse_fs_string(fc, "source", content, size - 1); + do_delayed_call(&cleanup); if (ret < 0) return ret; =20 diff --git a/include/trace/events/afs.h b/include/trace/events/afs.h index d05f2c09efe3..49a749672e38 100644 --- a/include/trace/events/afs.h +++ b/include/trace/events/afs.h @@ -422,6 +422,7 @@ enum yfs_cm_operation { EM(afs_file_error_dir_over_end, "DIR_ENT_OVER_END") \ EM(afs_file_error_dir_small, "DIR_SMALL") \ EM(afs_file_error_dir_unmarked_ext, "DIR_UNMARKED_EXT") \ + EM(afs_file_error_symlink_big, "SYM_BIG") \ EM(afs_file_error_mntpt, "MNTPT_READ_FAILED") \ E_(afs_file_error_writeback_fail, "WRITEBACK_FAILED")