From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FEDD1CCED2 for ; Wed, 6 Nov 2024 08:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; cv=none; b=Eo4uxzn5y63Q3k5BDv6Uvumy6U4oNPiS8j0z79oA55m8UXnwL1aMl1vmOfgrY+CiOEIfoJi5cV7XeLkwlD08YlZbARpELAhPowU/d7iOLrT6iPowHfzaTnirpb/L+Zfi7t+aEDIsNec1f/mkKWGSZx8jV10XCCXWuVc3eC4pOQ8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; c=relaxed/simple; bh=KiN6DGOmM7OzUXs2Uv6Tvbtd/F9eVemP3yL1pAxNyV8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=RHASU//1ipmIZ5DSiDDs1r8590sbD0o0ahjgNwIPW4lSn44sdpHRx2m1p9Kp12OUwSfC1mOjjXq/mEBIIO+iidWXz02NJhILYsujf0fBmxQlF38Kdg5obLYFxluHwtwl775soSiAKRdiPpcfuSkRBAmaUENKuRRbmBtCJ2CZclc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000ne-AV; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax4-002Gdf-31; Wed, 06 Nov 2024 08:59:42 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax4-006rrr-2l; Wed, 06 Nov 2024 08:59:42 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , Rob Herring , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 1/6] dt-bindings: net: dsa: microchip: add internal MDIO bus description Date: Wed, 6 Nov 2024 08:59:36 +0100 Message-Id: <20241106075942.1636998-2-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Add description for the internal MDIO bus, including integrated PHY nodes, to ksz DSA bindings. Signed-off-by: Oleksij Rempel Reviewed-by: Rob Herring (Arm) Reviewed-by: Andrew Lunn --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b= /Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index 30c0c3e6f37a4..a4e463819d4d7 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml @@ -81,6 +81,17 @@ properties: interrupts: maxItems: 1 =20 + mdio: + $ref: /schemas/net/mdio.yaml# + unevaluatedProperties: false + patternProperties: + "^ethernet-phy@[0-9a-f]$": + type: object + $ref: /schemas/net/ethernet-phy.yaml# + unevaluatedProperties: false + description: + Integrated PHY node + required: - compatible - reg --=20 2.39.5 From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FAF684D02 for ; Wed, 6 Nov 2024 08:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; cv=none; b=HyZJPIDxxR713Gf4h2qLObGEbcbetIuqOKCCSHmILJ6VO0VenVbI5XzSjaMk1CGde/pTn1Hs9uYOfdR83kdaFeTcVNilTEoqsXx5iuN0LQsWbJcf5C4Gf4YsQg+oTQ2437GI+XT1/NwkHIuk61Ek1ADfmg+1jsBzCby/vUuWcPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; c=relaxed/simple; bh=mv2/SEFrlPC3p6OnzI+7NQhDPVvHM/AyOdIW9TzUXwc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BevwJZfHC8hvwhEUHd4cKaBdsOT8tZjTrev7jjIBa54dEEvVc9LzeQTjxNKMIRFFyy9fuIrY+y4FeEUw8fN2eARn11kE0YHs4mF6BCEMU9H+U9sT7i1AcfDmglL8rHxBJkBcvieyhmSuytVx067bZFRhvYctDaPK5EmG+OoHPm0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000nf-AV; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax4-002Gdg-38; Wed, 06 Nov 2024 08:59:42 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax4-006rs1-2s; Wed, 06 Nov 2024 08:59:42 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , Rob Herring , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 2/6] dt-bindings: net: dsa: microchip: add mdio-parent-bus property for internal MDIO Date: Wed, 6 Nov 2024 08:59:37 +0100 Message-Id: <20241106075942.1636998-3-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Introduce `mdio-parent-bus` property in the ksz DSA bindings to reference the parent MDIO bus when the internal MDIO bus is attached to it, bypassing the main management interface. Signed-off-by: Oleksij Rempel Reviewed-by: Rob Herring (Arm) Reviewed-by: Andrew Lunn --- .../devicetree/bindings/net/dsa/microchip,ksz.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b= /Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml index a4e463819d4d7..121a4bbd147be 100644 --- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml +++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml @@ -84,6 +84,15 @@ properties: mdio: $ref: /schemas/net/mdio.yaml# unevaluatedProperties: false + properties: + mdio-parent-bus: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Phandle pointing to the MDIO bus controller connected to the + secondary MDIO interface. This property should be used when + the internal MDIO bus is accessed via a secondary MDIO + interface rather than the primary management interface. + patternProperties: "^ethernet-phy@[0-9a-f]$": type: object --=20 2.39.5 From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C556F1D3656 for ; Wed, 6 Nov 2024 08:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880008; cv=none; b=k040uouOM8XFEowsCDO8Uw31C39sc1z/7sLp5c0Pq/2oibFDHfwuSJjQ9B5ZnmN+OKua2SRQOeyEk4BhCJSg3V9BsfbpdVX5vSga6bhZ5uGSit4TKD3g13mHr9Cn8s5drfBDNRm6leoHCBudtHSif6A1LItrGtYSyxFGkGmMClk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880008; c=relaxed/simple; bh=XfyTAQa+XSyqkdFh9qJ64RLPb4jY0ssbC51Qc3HzkRs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=rA9MEBR+JFOMj6V1eXbgYynIT2UPi8feWJybeNp3mIFXEVgOR1b0ToAh2W+XhEXgxP7F0UZmHiWtGJBg1wr4494hX8aCRzHrKrbfhPjJ7UNieARCdvMpP0A8RvbbxGwxpCRRvgs0MXWaJLZl/aEpTF2H2vSXrj6AauEIUuot9Kg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000ng-AV; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax5-002Gdi-03; Wed, 06 Nov 2024 08:59:43 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax4-006rsB-2z; Wed, 06 Nov 2024 08:59:42 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 3/6] net: dsa: microchip: Refactor MDIO handling for side MDIO access Date: Wed, 6 Nov 2024 08:59:38 +0100 Message-Id: <20241106075942.1636998-4-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Add support for accessing PHYs via a side MDIO interface in LAN937x switches. The existing code already supports accessing PHYs via main management interfaces, which can be SPI, I2C, or MDIO, depending on the chip variant. This patch enables using a side MDIO bus, where SPI is used for the main switch configuration and MDIO for managing the integrated PHYs. On LAN937x, this is optional, allowing them to operate in both configurations: SPI only, or SPI + MDIO. Typically, the SPI interface is used for switch configuration, while MDIO handles PHY management. Additionally, update interrupt controller code to support non-linear port to PHY address mapping, enabling correct interrupt handling for configurations where PHY addresses do not directly correspond to port indexes. This change ensures that the interrupt mechanism properly aligns with the new, flexible PHY address mappings introduced by side MDIO support. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- changes v4: - add Reviewed-by: Andrew Lunn changes v2: - fail on phy_side_mdio_supported - add of_node_put(parent_bus_node) - add comments --- drivers/net/dsa/microchip/ksz_common.c | 175 +++++++++++++++++++++++-- drivers/net/dsa/microchip/ksz_common.h | 59 +++++++++ 2 files changed, 224 insertions(+), 10 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index f73833e24622a..e9460650d46e0 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -2236,16 +2236,100 @@ static int ksz_sw_mdio_write(struct mii_bus *bus, = int addr, int regnum, return dev->dev_ops->w_phy(dev, addr, regnum, val); } =20 +/** + * ksz_parent_mdio_read - Read data from a PHY register on the parent MDIO= bus. + * @bus: MDIO bus structure. + * @addr: PHY address on the parent MDIO bus. + * @regnum: Register number to read. + * + * This function provides a direct read operation on the parent MDIO bus f= or + * accessing PHY registers. By bypassing SPI or I2C, it uses the parent MD= IO bus + * to retrieve data from the PHY registers at the specified address and re= gister + * number. + * + * Return: Value of the PHY register, or a negative error code on failure. + */ +static int ksz_parent_mdio_read(struct mii_bus *bus, int addr, int regnum) +{ + struct ksz_device *dev =3D bus->priv; + + return mdiobus_read_nested(dev->parent_mdio_bus, addr, regnum); +} + +/** + * ksz_parent_mdio_write - Write data to a PHY register on the parent MDIO= bus. + * @bus: MDIO bus structure. + * @addr: PHY address on the parent MDIO bus. + * @regnum: Register number to write to. + * @val: Value to write to the PHY register. + * + * This function provides a direct write operation on the parent MDIO bus = for + * accessing PHY registers. Bypassing SPI or I2C, it uses the parent MDIO = bus + * to modify the PHY register values at the specified address. + * + * Return: 0 on success, or a negative error code on failure. + */ +static int ksz_parent_mdio_write(struct mii_bus *bus, int addr, int regnum, + u16 val) +{ + struct ksz_device *dev =3D bus->priv; + + return mdiobus_write_nested(dev->parent_mdio_bus, addr, regnum, val); +} + +/** + * ksz_phy_addr_to_port - Map a PHY address to the corresponding switch po= rt. + * @dev: Pointer to device structure. + * @addr: PHY address to map to a port. + * + * This function finds the corresponding switch port for a given PHY addre= ss by + * iterating over all user ports on the device. It checks if a port's PHY + * address in `phy_addr_map` matches the specified address and if the port + * contains an internal PHY. If a match is found, the index of the port is + * returned. + * + * Return: Port index on success, or -EINVAL if no matching port is found. + */ +static int ksz_phy_addr_to_port(struct ksz_device *dev, int addr) +{ + struct dsa_switch *ds =3D dev->ds; + struct dsa_port *dp; + + dsa_switch_for_each_user_port(dp, ds) { + if (dev->info->internal_phy[dp->index] && + dev->phy_addr_map[dp->index] =3D=3D addr) + return dp->index; + } + + return -EINVAL; +} + +/** + * ksz_irq_phy_setup - Configure IRQs for PHYs in the KSZ device. + * @dev: Pointer to the KSZ device structure. + * + * Sets up IRQs for each active PHY connected to the KSZ switch by mapping= the + * appropriate IRQs for each PHY and assigning them to the `user_mii_bus` = in + * the DSA switch structure. Each IRQ is mapped based on the port's IRQ do= main. + * + * Return: 0 on success, or a negative error code on failure. + */ static int ksz_irq_phy_setup(struct ksz_device *dev) { struct dsa_switch *ds =3D dev->ds; - int phy; + int phy, port; int irq; int ret; =20 - for (phy =3D 0; phy < KSZ_MAX_NUM_PORTS; phy++) { + for (phy =3D 0; phy < PHY_MAX_ADDR; phy++) { if (BIT(phy) & ds->phys_mii_mask) { - irq =3D irq_find_mapping(dev->ports[phy].pirq.domain, + port =3D ksz_phy_addr_to_port(dev, phy); + if (port < 0) { + ret =3D port; + goto out; + } + + irq =3D irq_find_mapping(dev->ports[port].pirq.domain, PORT_SRC_PHY_INT); if (irq < 0) { ret =3D irq; @@ -2263,40 +2347,109 @@ static int ksz_irq_phy_setup(struct ksz_device *de= v) return ret; } =20 +/** + * ksz_irq_phy_free - Release IRQ mappings for PHYs in the KSZ device. + * @dev: Pointer to the KSZ device structure. + * + * Releases any IRQ mappings previously assigned to active PHYs in the KSZ + * switch by disposing of each mapped IRQ in the `user_mii_bus` structure. + */ static void ksz_irq_phy_free(struct ksz_device *dev) { struct dsa_switch *ds =3D dev->ds; int phy; =20 - for (phy =3D 0; phy < KSZ_MAX_NUM_PORTS; phy++) + for (phy =3D 0; phy < PHY_MAX_ADDR; phy++) if (BIT(phy) & ds->phys_mii_mask) irq_dispose_mapping(ds->user_mii_bus->irq[phy]); } =20 +/** + * ksz_mdio_register - Register and configure the MDIO bus for the KSZ dev= ice. + * @dev: Pointer to the KSZ device structure. + * + * This function sets up and registers an MDIO bus for the KSZ switch devi= ce, + * allowing access to its internal PHYs. If the device supports side MDIO, + * the function will configure the external MDIO controller specified by t= he + * "mdio-parent-bus" device tree property to directly manage internal PHYs. + * Otherwise, SPI or I2C access is set up for PHY access. + * + * Return: 0 on success, or a negative error code on failure. + */ static int ksz_mdio_register(struct ksz_device *dev) { + struct device_node *parent_bus_node; + struct mii_bus *parent_bus =3D NULL; struct dsa_switch *ds =3D dev->ds; struct device_node *mdio_np; struct mii_bus *bus; - int ret; + struct dsa_port *dp; + int ret, i; =20 mdio_np =3D of_get_child_by_name(dev->dev->of_node, "mdio"); if (!mdio_np) return 0; =20 + parent_bus_node =3D of_parse_phandle(mdio_np, "mdio-parent-bus", 0); + if (parent_bus_node && !dev->info->phy_side_mdio_supported) { + dev_err(dev->dev, "Side MDIO bus is not supported for this HW, ignoring = 'mdio-parent-bus' property.\n"); + ret =3D -EINVAL; + + goto put_mdio_node; + } else if (parent_bus_node) { + parent_bus =3D of_mdio_find_bus(parent_bus_node); + if (!parent_bus) { + ret =3D -EPROBE_DEFER; + + goto put_mdio_node; + } + + dev->parent_mdio_bus =3D parent_bus; + } + bus =3D devm_mdiobus_alloc(ds->dev); if (!bus) { of_node_put(mdio_np); return -ENOMEM; } =20 + if (dev->dev_ops->mdio_bus_preinit) { + ret =3D dev->dev_ops->mdio_bus_preinit(dev, !!parent_bus); + if (ret) + goto put_mdio_node; + } + + if (dev->dev_ops->create_phy_addr_map) { + ret =3D dev->dev_ops->create_phy_addr_map(dev, !!parent_bus); + if (ret) + goto put_mdio_node; + } else { + for (i =3D 0; i < dev->info->port_cnt; i++) + dev->phy_addr_map[i] =3D i; + } + bus->priv =3D dev; - bus->read =3D ksz_sw_mdio_read; - bus->write =3D ksz_sw_mdio_write; - bus->name =3D "ksz user smi"; - snprintf(bus->id, MII_BUS_ID_SIZE, "SMI-%d", ds->index); + if (parent_bus) { + bus->read =3D ksz_parent_mdio_read; + bus->write =3D ksz_parent_mdio_write; + bus->name =3D "KSZ side MDIO"; + snprintf(bus->id, MII_BUS_ID_SIZE, "ksz-side-mdio-%d", + ds->index); + } else { + bus->read =3D ksz_sw_mdio_read; + bus->write =3D ksz_sw_mdio_write; + bus->name =3D "ksz user smi"; + snprintf(bus->id, MII_BUS_ID_SIZE, "SMI-%d", ds->index); + } + + dsa_switch_for_each_user_port(dp, dev->ds) { + if (dev->info->internal_phy[dp->index] && + dev->phy_addr_map[dp->index] < PHY_MAX_ADDR) + bus->phy_mask |=3D BIT(dev->phy_addr_map[dp->index]); + } + + ds->phys_mii_mask =3D bus->phy_mask; bus->parent =3D ds->dev; - bus->phy_mask =3D ~ds->phys_mii_mask; =20 ds->user_mii_bus =3D bus; =20 @@ -2316,7 +2469,9 @@ static int ksz_mdio_register(struct ksz_device *dev) ksz_irq_phy_free(dev); } =20 +put_mdio_node: of_node_put(mdio_np); + of_node_put(parent_bus_node); =20 return ret; } diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/micro= chip/ksz_common.h index bec846e20682f..bbb548af201ef 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -65,6 +65,12 @@ struct ksz_chip_data { u8 num_tx_queues; u8 num_ipms; /* number of Internal Priority Maps */ bool tc_cbs_supported; + + /** + * @phy_side_mdio_supported: Indicates if the chip supports an additional + * side MDIO channel for accessing integrated PHYs. + */ + bool phy_side_mdio_supported; const struct ksz_dev_ops *ops; const struct phylink_mac_ops *phylink_mac_ops; bool phy_errata_9477; @@ -191,6 +197,22 @@ struct ksz_device { struct ksz_switch_macaddr *switch_macaddr; struct net_device *hsr_dev; /* HSR */ u8 hsr_ports; + + /** + * @phy_addr_map: Array mapping switch ports to their corresponding PHY + * addresses. + */ + u8 phy_addr_map[KSZ_MAX_NUM_PORTS]; + + /** + * @parent_mdio_bus: Pointer to the external MDIO bus controller. + * + * This points to an external MDIO bus controller that is used to access + * the PHYs integrated within the switch. Unlike an integrated MDIO + * bus, this external controller provides a direct path for managing + * the switch=E2=80=99s internal PHYs, bypassing the main SPI interface. + */ + struct mii_bus *parent_mdio_bus; }; =20 /* List of supported models */ @@ -326,6 +348,43 @@ struct ksz_dev_ops { void (*port_cleanup)(struct ksz_device *dev, int port); void (*port_setup)(struct ksz_device *dev, int port, bool cpu_port); int (*set_ageing_time)(struct ksz_device *dev, unsigned int msecs); + + /** + * @mdio_bus_preinit: Function pointer to pre-initialize the MDIO bus + * for accessing PHYs. + * @dev: Pointer to device structure. + * @side_mdio: Boolean indicating if the PHYs are accessed over a side + * MDIO bus. + * + * This function pointer is used to configure the MDIO bus for PHY + * access before initiating regular PHY operations. It enables either + * SPI/I2C or side MDIO access modes by unlocking necessary registers + * and setting up access permissions for the selected mode. + * + * Return: + * - 0 on success. + * - Negative error code on failure. + */ + int (*mdio_bus_preinit)(struct ksz_device *dev, bool side_mdio); + + /** + * @create_phy_addr_map: Function pointer to create a port-to-PHY + * address map. + * @dev: Pointer to device structure. + * @side_mdio: Boolean indicating if the PHYs are accessed over a side + * MDIO bus. + * + * This function pointer is responsible for mapping switch ports to PHY + * addresses according to the configured access mode (SPI or side MDIO) + * and the device=E2=80=99s strap configuration. The mapping setup may va= ry + * depending on the chip variant and configuration. Ensures the correct + * address mapping for PHY communication. + * + * Return: + * - 0 on success. + * - Negative error code on failure (e.g., invalid configuration). + */ + int (*create_phy_addr_map)(struct ksz_device *dev, bool side_mdio); int (*r_phy)(struct ksz_device *dev, u16 phy, u16 reg, u16 *val); int (*w_phy)(struct ksz_device *dev, u16 phy, u16 reg, u16 val); void (*r_mib_cnt)(struct ksz_device *dev, int port, u16 addr, --=20 2.39.5 From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 889711D3588 for ; Wed, 6 Nov 2024 08:00:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; cv=none; b=pl75ZtwW2WxIUC1odBlQfDpTijZEascEgcipCeYOh8FAVKcJoqfj0RkuTJ3yZJrDTJKYWgd68U8U21j8VuXajncarRdELYMf/FVVYCjV4k7dXoL0bLnKsEPXsPVaYZ0AxFH+2wPnf/y5fD4l4x5btWcgil+4Bco6XHlIFXyizhE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880006; c=relaxed/simple; bh=BfSjHU+J9WCMj+O3iK3tJmO7ipT4x4j3+v0Bm1Fx9bQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sVL4Hf6yInCOwIgxBdwMkFWJtWpB7xCEnFFkNbuEbcldeg4CHzUciukSzMF1/EJDsRUquHiPDN8HuWm6LF6ic5NK8wY/ANiaxCOVBoBmh/g4aI/RvjdeOV1mHWVrcpQmi9FuI2yw6iH4UkN+BpqriV1RnuPA8akwGJSFdf+K0Mo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000nh-AW; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax5-002Gdl-09; Wed, 06 Nov 2024 08:59:43 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax4-006rsL-36; Wed, 06 Nov 2024 08:59:42 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 4/6] net: dsa: microchip: cleanup error handling in ksz_mdio_register Date: Wed, 6 Nov 2024 08:59:39 +0100 Message-Id: <20241106075942.1636998-5-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Replace repeated cleanup code with a single error path using a label. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- drivers/net/dsa/microchip/ksz_common.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index e9460650d46e0..26a4a8b49dc83 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -2409,8 +2409,8 @@ static int ksz_mdio_register(struct ksz_device *dev) =20 bus =3D devm_mdiobus_alloc(ds->dev); if (!bus) { - of_node_put(mdio_np); - return -ENOMEM; + ret =3D -ENOMEM; + goto put_mdio_node; } =20 if (dev->dev_ops->mdio_bus_preinit) { @@ -2455,10 +2455,8 @@ static int ksz_mdio_register(struct ksz_device *dev) =20 if (dev->irq > 0) { ret =3D ksz_irq_phy_setup(dev); - if (ret) { - of_node_put(mdio_np); - return ret; - } + if (ret) + goto put_mdio_node; } =20 ret =3D devm_of_mdiobus_register(ds->dev, bus, mdio_np); --=20 2.39.5 From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7882413CFAD for ; Wed, 6 Nov 2024 08:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880007; cv=none; b=P5SBdidDXgI/6OJavDp5AbL6NU0sydddvi0FS7u7r6cKprOa0/o+14jW28Q8O7jlW9gNzB2dY3go1EWW4m86Ghh3ajI8MxtT3YnOX1RqQEwg82Xo9pR31FlU7seNUNYa08v2Q9PEnEwYzt/k8nx7e0sSY8bdqm43soW0WDwwYPM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880007; c=relaxed/simple; bh=buNi4DQBdEkwbBm44GMfkxOPGPQEsGKgKHOL4hj/ZwA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gAMHciK1Ugj4BakNmRtw1pakP66xHlC7W6C6fhVS4g/5WpBic4i+CTvqIDFf7mYsqfHN2id2XT3YOFmteJY8yz4gnqSEDskXVM92iN7jAuf251xiMAbE55gekvjyxFFEbCEjD8f30SETx/8AdYgs8qtwscSy2gSk+TnQiFreVvI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000ni-AW; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax5-002Gdn-0H; Wed, 06 Nov 2024 08:59:43 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax4-006rsW-3B; Wed, 06 Nov 2024 08:59:42 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 5/6] net: dsa: microchip: add support for side MDIO interface in LAN937x Date: Wed, 6 Nov 2024 08:59:40 +0100 Message-Id: <20241106075942.1636998-6-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Implement side MDIO channel support for LAN937x switches, providing an alternative to SPI for PHY management alongside existing SPI-based switch configuration. This is needed to reduce SPI load, as SPI can be relatively expensive for small packets compared to MDIO support. Also, implemented static mappings for PHY addresses for various LAN937x models to support different internal PHY configurations. Since the PHY address mappings are not equal to the port indexes, this patch also provides PHY address calculation based on hardware strapping configuration. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn --- changes v4: - add Reviewed-by: Andrew Lunn changes v2: - add lan9371_phy_addr map - add comments - add define LAN937X_NO_PHY --- drivers/net/dsa/microchip/ksz_common.c | 7 + drivers/net/dsa/microchip/lan937x.h | 2 + drivers/net/dsa/microchip/lan937x_main.c | 226 +++++++++++++++++++++-- drivers/net/dsa/microchip/lan937x_reg.h | 4 + 4 files changed, 223 insertions(+), 16 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index 26a4a8b49dc83..19fb090c09ab7 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -411,6 +411,8 @@ static const struct ksz_dev_ops lan937x_dev_ops =3D { .flush_dyn_mac_table =3D ksz9477_flush_dyn_mac_table, .port_setup =3D lan937x_port_setup, .set_ageing_time =3D lan937x_set_ageing_time, + .mdio_bus_preinit =3D lan937x_mdio_bus_preinit, + .create_phy_addr_map =3D lan937x_create_phy_addr_map, .r_phy =3D lan937x_r_phy, .w_phy =3D lan937x_w_phy, .r_mib_cnt =3D ksz9477_r_mib_cnt, @@ -1762,6 +1764,7 @@ const struct ksz_chip_data ksz_switch_chips[] =3D { .num_tx_queues =3D 8, .num_ipms =3D 8, .tc_cbs_supported =3D true, + .phy_side_mdio_supported =3D true, .ops =3D &lan937x_dev_ops, .phylink_mac_ops =3D &lan937x_phylink_mac_ops, .mib_names =3D ksz9477_mib_names, @@ -1790,6 +1793,7 @@ const struct ksz_chip_data ksz_switch_chips[] =3D { .num_tx_queues =3D 8, .num_ipms =3D 8, .tc_cbs_supported =3D true, + .phy_side_mdio_supported =3D true, .ops =3D &lan937x_dev_ops, .phylink_mac_ops =3D &lan937x_phylink_mac_ops, .mib_names =3D ksz9477_mib_names, @@ -1818,6 +1822,7 @@ const struct ksz_chip_data ksz_switch_chips[] =3D { .num_tx_queues =3D 8, .num_ipms =3D 8, .tc_cbs_supported =3D true, + .phy_side_mdio_supported =3D true, .ops =3D &lan937x_dev_ops, .phylink_mac_ops =3D &lan937x_phylink_mac_ops, .mib_names =3D ksz9477_mib_names, @@ -1850,6 +1855,7 @@ const struct ksz_chip_data ksz_switch_chips[] =3D { .num_tx_queues =3D 8, .num_ipms =3D 8, .tc_cbs_supported =3D true, + .phy_side_mdio_supported =3D true, .ops =3D &lan937x_dev_ops, .phylink_mac_ops =3D &lan937x_phylink_mac_ops, .mib_names =3D ksz9477_mib_names, @@ -1882,6 +1888,7 @@ const struct ksz_chip_data ksz_switch_chips[] =3D { .num_tx_queues =3D 8, .num_ipms =3D 8, .tc_cbs_supported =3D true, + .phy_side_mdio_supported =3D true, .ops =3D &lan937x_dev_ops, .phylink_mac_ops =3D &lan937x_phylink_mac_ops, .mib_names =3D ksz9477_mib_names, diff --git a/drivers/net/dsa/microchip/lan937x.h b/drivers/net/dsa/microchi= p/lan937x.h index 3388d91dbc44e..df13ebbd356f9 100644 --- a/drivers/net/dsa/microchip/lan937x.h +++ b/drivers/net/dsa/microchip/lan937x.h @@ -13,6 +13,8 @@ void lan937x_port_setup(struct ksz_device *dev, int port,= bool cpu_port); void lan937x_config_cpu_port(struct dsa_switch *ds); int lan937x_switch_init(struct ksz_device *dev); void lan937x_switch_exit(struct ksz_device *dev); +int lan937x_mdio_bus_preinit(struct ksz_device *dev, bool side_mdio); +int lan937x_create_phy_addr_map(struct ksz_device *dev, bool side_mdio); int lan937x_r_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 *data); int lan937x_w_phy(struct ksz_device *dev, u16 addr, u16 reg, u16 val); int lan937x_change_mtu(struct ksz_device *dev, int port, int new_mtu); diff --git a/drivers/net/dsa/microchip/lan937x_main.c b/drivers/net/dsa/mic= rochip/lan937x_main.c index 824d9309a3d35..b7652efd632ea 100644 --- a/drivers/net/dsa/microchip/lan937x_main.c +++ b/drivers/net/dsa/microchip/lan937x_main.c @@ -18,6 +18,87 @@ #include "ksz9477.h" #include "lan937x.h" =20 +/* marker for ports without built-in PHY */ +#define LAN937X_NO_PHY U8_MAX + +/* + * lan9370_phy_addr - Mapping of LAN9370 switch ports to PHY addresses. + * + * Each entry corresponds to a specific port on the LAN9370 switch, + * where ports 1-4 are connected to integrated 100BASE-T1 PHYs, and + * Port 5 is connected to an RGMII interface without a PHY. The values + * are based on the documentation (DS00003108E, section 3.3). + */ +static const u8 lan9370_phy_addr[] =3D { + [0] =3D 2, /* Port 1, T1 AFE0 */ + [1] =3D 3, /* Port 2, T1 AFE1 */ + [2] =3D 5, /* Port 3, T1 AFE3 */ + [3] =3D 6, /* Port 4, T1 AFE4 */ + [4] =3D LAN937X_NO_PHY, /* Port 5, RGMII 2 */ +}; + +/* + * lan9371_phy_addr - Mapping of LAN9371 switch ports to PHY addresses. + * + * The values are based on the documentation (DS00003109E, section 3.3). + */ +static const u8 lan9371_phy_addr[] =3D { + [0] =3D 2, /* Port 1, T1 AFE0 */ + [1] =3D 3, /* Port 2, T1 AFE1 */ + [2] =3D 5, /* Port 3, T1 AFE3 */ + [3] =3D 8, /* Port 4, TX PHY */ + [4] =3D LAN937X_NO_PHY, /* Port 5, RGMII 2 */ + [5] =3D LAN937X_NO_PHY, /* Port 6, RGMII 1 */ +}; + +/* + * lan9372_phy_addr - Mapping of LAN9372 switch ports to PHY addresses. + * + * The values are based on the documentation (DS00003110F, section 3.3). + */ +static const u8 lan9372_phy_addr[] =3D { + [0] =3D 2, /* Port 1, T1 AFE0 */ + [1] =3D 3, /* Port 2, T1 AFE1 */ + [2] =3D 5, /* Port 3, T1 AFE3 */ + [3] =3D 8, /* Port 4, TX PHY */ + [4] =3D LAN937X_NO_PHY, /* Port 5, RGMII 2 */ + [5] =3D LAN937X_NO_PHY, /* Port 6, RGMII 1 */ + [6] =3D 6, /* Port 7, T1 AFE4 */ + [7] =3D 4, /* Port 8, T1 AFE2 */ +}; + +/* + * lan9373_phy_addr - Mapping of LAN9373 switch ports to PHY addresses. + * + * The values are based on the documentation (DS00003110F, section 3.3). + */ +static const u8 lan9373_phy_addr[] =3D { + [0] =3D 2, /* Port 1, T1 AFE0 */ + [1] =3D 3, /* Port 2, T1 AFE1 */ + [2] =3D 5, /* Port 3, T1 AFE3 */ + [3] =3D LAN937X_NO_PHY, /* Port 4, SGMII */ + [4] =3D LAN937X_NO_PHY, /* Port 5, RGMII 2 */ + [5] =3D LAN937X_NO_PHY, /* Port 6, RGMII 1 */ + [6] =3D 6, /* Port 7, T1 AFE4 */ + [7] =3D 4, /* Port 8, T1 AFE2 */ +}; + +/* + * lan9374_phy_addr - Mapping of LAN9374 switch ports to PHY addresses. + * + * The values are based on the documentation (DS00003110F, section 3.3). + */ +static const u8 lan9374_phy_addr[] =3D { + [0] =3D 2, /* Port 1, T1 AFE0 */ + [1] =3D 3, /* Port 2, T1 AFE1 */ + [2] =3D 5, /* Port 3, T1 AFE3 */ + [3] =3D 7, /* Port 4, T1 AFE5 */ + [4] =3D LAN937X_NO_PHY, /* Port 5, RGMII 2 */ + [5] =3D LAN937X_NO_PHY, /* Port 6, RGMII 1 */ + [6] =3D 6, /* Port 7, T1 AFE4 */ + [7] =3D 4, /* Port 8, T1 AFE2 */ +}; + static int lan937x_cfg(struct ksz_device *dev, u32 addr, u8 bits, bool set) { return regmap_update_bits(ksz_regmap_8(dev), addr, bits, set ? bits : 0); @@ -30,24 +111,144 @@ static int lan937x_port_cfg(struct ksz_device *dev, i= nt port, int offset, bits, set ? bits : 0); } =20 -static int lan937x_enable_spi_indirect_access(struct ksz_device *dev) +/** + * lan937x_create_phy_addr_map - Create port-to-PHY address map for MDIO b= us. + * @dev: Pointer to device structure. + * @side_mdio: Boolean indicating if the PHYs are accessed over a side MDI= O bus. + * + * This function sets up the PHY address mapping for the LAN937x switches, + * which support two access modes for internal PHYs: + * 1. **SPI Access**: A straightforward one-to-one port-to-PHY address + * mapping is applied. + * 2. **MDIO Access**: The PHY address mapping varies based on chip variant + * and strap configuration. An offset is calculated based on strap sett= ings + * to ensure correct PHY addresses are assigned. The offset calculation= logic + * is based on Microchip's Article Number 000015828, available at: + * https://microchip.my.site.com/s/article/LAN9374-Virtual-PHY-PHY-Addr= ess-Mapping + * + * The function first checks if side MDIO access is disabled, in which cas= e a + * simple direct mapping (port number =3D PHY address) is applied. If side= MDIO + * access is enabled, it reads the strap configuration to determine the co= rrect + * offset for PHY addresses. + * + * The appropriate mapping table is selected based on the chip ID, and the + * `phy_addr_map` is populated with the correct addresses for each port. A= ny + * port with no PHY is assigned a `LAN937X_NO_PHY` marker. + * + * Return: 0 on success, error code on failure. + */ +int lan937x_create_phy_addr_map(struct ksz_device *dev, bool side_mdio) +{ + static const u8 *phy_addr_map; + u32 strap_val; + u8 offset =3D 0; + size_t size; + int ret, i; + + if (!side_mdio) { + /* simple direct mapping */ + for (i =3D 0; i < dev->info->port_cnt; i++) + dev->phy_addr_map[i] =3D i; + + return 0; + } + + ret =3D ksz_read32(dev, REG_SW_CFG_STRAP_VAL, &strap_val); + if (ret < 0) + return ret; + + if (!(strap_val & SW_CASCADE_ID_CFG) && !(strap_val & SW_VPHY_ADD_CFG)) + offset =3D 0; + else if (!(strap_val & SW_CASCADE_ID_CFG) && (strap_val & SW_VPHY_ADD_CFG= )) + offset =3D 7; + else if ((strap_val & SW_CASCADE_ID_CFG) && !(strap_val & SW_VPHY_ADD_CFG= )) + offset =3D 15; + else + offset =3D 22; + + switch (dev->info->chip_id) { + case LAN9370_CHIP_ID: + phy_addr_map =3D lan9370_phy_addr; + size =3D ARRAY_SIZE(lan9370_phy_addr); + break; + case LAN9371_CHIP_ID: + phy_addr_map =3D lan9371_phy_addr; + size =3D ARRAY_SIZE(lan9371_phy_addr); + break; + case LAN9372_CHIP_ID: + phy_addr_map =3D lan9372_phy_addr; + size =3D ARRAY_SIZE(lan9372_phy_addr); + break; + case LAN9373_CHIP_ID: + phy_addr_map =3D lan9373_phy_addr; + size =3D ARRAY_SIZE(lan9373_phy_addr); + break; + case LAN9374_CHIP_ID: + phy_addr_map =3D lan9374_phy_addr; + size =3D ARRAY_SIZE(lan9374_phy_addr); + break; + default: + return -EINVAL; + } + + if (size < dev->info->port_cnt) + return -EINVAL; + + for (i =3D 0; i < dev->info->port_cnt; i++) { + if (phy_addr_map[i] =3D=3D LAN937X_NO_PHY) + dev->phy_addr_map[i] =3D phy_addr_map[i]; + else + dev->phy_addr_map[i] =3D phy_addr_map[i] + offset; + } + + return 0; +} + +/** + * lan937x_mdio_bus_preinit - Pre-initialize MDIO bus for accessing PHYs. + * @dev: Pointer to device structure. + * @side_mdio: Boolean indicating if the PHYs are accessed over a side MDI= O bus. + * + * This function configures the LAN937x switch for PHY access either throu= gh + * SPI or the side MDIO bus, unlocking the necessary registers for each ac= cess + * mode. + * + * Operation Modes: + * 1. **SPI Access**: Enables SPI indirect access to address clock domain + * crossing issues when SPI is used for PHY access. + * 2. **MDIO Access**: Grants access to internal PHYs over the side MDIO b= us, + * required when using the MDIO bus for PHY management. + * + * Return: 0 on success, error code on failure. + */ +int lan937x_mdio_bus_preinit(struct ksz_device *dev, bool side_mdio) { u16 data16; int ret; =20 - /* Enable Phy access through SPI */ + /* Unlock access to the PHYs, needed for SPI and side MDIO access */ ret =3D lan937x_cfg(dev, REG_GLOBAL_CTRL_0, SW_PHY_REG_BLOCK, false); if (ret < 0) - return ret; + goto print_error; =20 - ret =3D ksz_read16(dev, REG_VPHY_SPECIAL_CTRL__2, &data16); - if (ret < 0) - return ret; + if (side_mdio) + /* Allow access to internal PHYs over MDIO bus */ + data16 =3D VPHY_MDIO_INTERNAL_ENABLE; + else + /* Enable SPI indirect access to address clock domain crossing + * issue + */ + data16 =3D VPHY_SPI_INDIRECT_ENABLE; =20 - /* Allow SPI access */ - data16 |=3D VPHY_SPI_INDIRECT_ENABLE; + ret =3D ksz_rmw16(dev, REG_VPHY_SPECIAL_CTRL__2, + VPHY_SPI_INDIRECT_ENABLE | VPHY_MDIO_INTERNAL_ENABLE, + data16); + +print_error: + if (ret < 0) + dev_err(dev->dev, "failed to preinit the MDIO bus\n"); =20 - return ksz_write16(dev, REG_VPHY_SPECIAL_CTRL__2, data16); + return ret; } =20 static int lan937x_vphy_ind_addr_wr(struct ksz_device *dev, int addr, int = reg) @@ -363,13 +564,6 @@ int lan937x_setup(struct dsa_switch *ds) struct ksz_device *dev =3D ds->priv; int ret; =20 - /* enable Indirect Access from SPI to the VPHY registers */ - ret =3D lan937x_enable_spi_indirect_access(dev); - if (ret < 0) { - dev_err(dev->dev, "failed to enable spi indirect access"); - return ret; - } - /* The VLAN aware is a global setting. Mixed vlan * filterings are not supported. */ diff --git a/drivers/net/dsa/microchip/lan937x_reg.h b/drivers/net/dsa/micr= ochip/lan937x_reg.h index 2f22a9d01de36..4ec93e421da45 100644 --- a/drivers/net/dsa/microchip/lan937x_reg.h +++ b/drivers/net/dsa/microchip/lan937x_reg.h @@ -37,6 +37,10 @@ #define SW_CLK125_ENB BIT(1) #define SW_CLK25_ENB BIT(0) =20 +#define REG_SW_CFG_STRAP_VAL 0x0200 +#define SW_CASCADE_ID_CFG BIT(15) +#define SW_VPHY_ADD_CFG BIT(0) + /* 2 - PHY Control */ #define REG_SW_CFG_STRAP_OVR 0x0214 #define SW_VPHY_DISABLE BIT(31) --=20 2.39.5 From nobody Sun Nov 24 08:28:34 2024 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EAE61CC894 for ; Wed, 6 Nov 2024 08:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880005; cv=none; b=imrpBE7NBLyGGd89gX6KlcXDpBHYyoSHZtWgf2+Fv8WjHjnBL8d8UEKXOa4gsh1FXEEcN5agb5J5N/IwzeqHyfopVWzKm2BtUo3MYQvniWTmqSEHz5VkC4MgnABJClZUsBhJkBlpPspFvYTHUB1r/Szs2xzLVnW5mOg3jPCCFDk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730880005; c=relaxed/simple; bh=yVtSRi1TUvXDgkHZifvC0hJgVKCc8ur1X4YrlOFi8o0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LNerOVUkzr94+oAMB7VYhrHk50Z07/Eff77Mjk0BhGH3k+gvNcBx/UmCNdA66xThlWPQ7Uu6naT0J1+mYZF+/+P1/oa8pi6ftI1CsH836u5HSRZPDlWppBvjDagBdRn7WhNJQGbrfEjFj391Y7qDILd6Fueqx1NXTWVt7S3YK70= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t8ax6-0000nj-AW; Wed, 06 Nov 2024 08:59:44 +0100 Received: from dude04.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::ac]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1t8ax5-002Gdq-0H; Wed, 06 Nov 2024 08:59:43 +0100 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1t8ax5-006rsh-01; Wed, 06 Nov 2024 08:59:43 +0100 From: Oleksij Rempel To: "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Woojung Huh , Arun Ramadoss , Conor Dooley , Krzysztof Kozlowski , Rob Herring Cc: Oleksij Rempel , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, UNGLinuxDriver@microchip.com, "Russell King (Oracle)" , devicetree@vger.kernel.org, Marek Vasut Subject: [PATCH net-next v4 6/6] net: dsa: microchip: parse PHY config from device tree Date: Wed, 6 Nov 2024 08:59:41 +0100 Message-Id: <20241106075942.1636998-7-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241106075942.1636998-1-o.rempel@pengutronix.de> References: <20241106075942.1636998-1-o.rempel@pengutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Introduce ksz_parse_dt_phy_config() to validate and parse PHY configuration from the device tree for KSZ switches. This function ensures proper setup of internal PHYs by checking `phy-handle` properties, verifying expected PHY IDs, and handling parent node mismatches. Sets the PHY mask on the MII bus if validation is successful. Returns -EINVAL on configuration errors. Signed-off-by: Oleksij Rempel --- changes v4: - remove second internal_phy check - rename phy_id to phy_addr --- drivers/net/dsa/microchip/ksz_common.c | 79 ++++++++++++++++++++++++-- 1 file changed, 73 insertions(+), 6 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/micro= chip/ksz_common.c index 19fb090c09ab7..d57782cdda599 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -2371,6 +2371,76 @@ static void ksz_irq_phy_free(struct ksz_device *dev) irq_dispose_mapping(ds->user_mii_bus->irq[phy]); } =20 +/** + * ksz_parse_dt_phy_config - Parse and validate PHY configuration from DT + * @dev: pointer to the KSZ device structure + * @bus: pointer to the MII bus structure + * @mdio_np: pointer to the MDIO node in the device tree + * + * This function parses and validates PHY configurations for each user port + * defined in the device tree for a KSZ switch device. It verifies that the + * `phy-handle` properties are correctly set and that the internal PHYs ma= tch + * expected addresses and parent nodes. Sets up the PHY mask in the MII bu= s if + * all validations pass. Logs error messages for any mismatches or missing= data. + * + * Return: 0 on success, or a negative error code on failure. + */ +static int ksz_parse_dt_phy_config(struct ksz_device *dev, struct mii_bus = *bus, + struct device_node *mdio_np) +{ + struct device_node *phy_node, *phy_parent_node; + bool phys_are_valid =3D true; + struct dsa_port *dp; + u32 phy_addr; + int ret; + + dsa_switch_for_each_user_port(dp, dev->ds) { + if (!dev->info->internal_phy[dp->index]) + continue; + + phy_node =3D of_parse_phandle(dp->dn, "phy-handle", 0); + if (!phy_node) { + dev_err(dev->dev, "failed to parse phy-handle for port %d.\n", + dp->index); + phys_are_valid =3D false; + continue; + } + + phy_parent_node =3D of_get_parent(phy_node); + if (!phy_parent_node) { + dev_err(dev->dev, "failed to get PHY-parent node for port %d\n", + dp->index); + phys_are_valid =3D false; + } else if (phy_parent_node !=3D mdio_np) { + dev_err(dev->dev, "PHY-parent node mismatch for port %d, expected %pOF,= got %pOF\n", + dp->index, mdio_np, phy_parent_node); + phys_are_valid =3D false; + } else { + ret =3D of_property_read_u32(phy_node, "reg", &phy_addr); + if (ret < 0) { + dev_err(dev->dev, "failed to read PHY address for port %d. Error %d\n", + dp->index, ret); + phys_are_valid =3D false; + } else if (phy_addr !=3D dev->phy_addr_map[dp->index]) { + dev_err(dev->dev, "PHY address mismatch for port %d, expected 0x%x, go= t 0x%x\n", + dp->index, dev->phy_addr_map[dp->index], + phy_addr); + phys_are_valid =3D false; + } else { + bus->phy_mask |=3D BIT(phy_addr); + } + } + + of_node_put(phy_node); + of_node_put(phy_parent_node); + } + + if (!phys_are_valid) + return -EINVAL; + + return 0; +} + /** * ksz_mdio_register - Register and configure the MDIO bus for the KSZ dev= ice. * @dev: Pointer to the KSZ device structure. @@ -2390,7 +2460,6 @@ static int ksz_mdio_register(struct ksz_device *dev) struct dsa_switch *ds =3D dev->ds; struct device_node *mdio_np; struct mii_bus *bus; - struct dsa_port *dp; int ret, i; =20 mdio_np =3D of_get_child_by_name(dev->dev->of_node, "mdio"); @@ -2449,11 +2518,9 @@ static int ksz_mdio_register(struct ksz_device *dev) snprintf(bus->id, MII_BUS_ID_SIZE, "SMI-%d", ds->index); } =20 - dsa_switch_for_each_user_port(dp, dev->ds) { - if (dev->info->internal_phy[dp->index] && - dev->phy_addr_map[dp->index] < PHY_MAX_ADDR) - bus->phy_mask |=3D BIT(dev->phy_addr_map[dp->index]); - } + ret =3D ksz_parse_dt_phy_config(dev, bus, mdio_np); + if (ret) + goto put_mdio_node; =20 ds->phys_mii_mask =3D bus->phy_mask; bus->parent =3D ds->dev; --=20 2.39.5