From nobody Tue Feb 10 00:32:26 2026 Received: from m16.mail.163.com (m16.mail.163.com [117.135.210.3]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 37E921B652C for ; Tue, 5 Nov 2024 05:36:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=117.135.210.3 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730785001; cv=none; b=ozlIvW3K2dEUwj4bjWFHue2gFuAEl/nDQk0uPn8mf/Kqg/R1ew0rBzOy7RNrmhhtYAygOlsRIywkmB+efeG7xUpW/UaJpmX/nFft32Jx9dB5T3a6xs/UDW0yjptymmZJhkBCywzXdGNMiNYKIKsnvsMS/axTN8F65H5t6AUt4tc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730785001; c=relaxed/simple; bh=gsqi8UWYwZW+FFKHRC3djIqnm2yhVz86vrz/ef4JhaQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=lYHiZuxaiCe2qhOqeEVRBjwIcpupnf3hYWlX7dUo8QdmSuDVyM1Ya4CT0kz7UV0UE7b4SyWDd3vFqH+EK044LKNSyRMate48i6gOFPhYrcsLoIQabtuJhRQZRUKA3kuIY6mT8kKoZflHLbcbYu4aMOfdRp3K22IjgYPOqnhIWZA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com; spf=pass smtp.mailfrom=163.com; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b=pNk0NC5s; arc=none smtp.client-ip=117.135.210.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=163.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=163.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="pNk0NC5s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=NmYQI qNL67zkFkSfFu+pBgVdo0xBn6QfVDfDg3MWx3M=; b=pNk0NC5sJQGjVvxDKsvvC Od0Y7Nr/DDAvzH2Cn+ET7Tm+i6CUmNqayaCHWv6Q8zg8FU72JDphhw/IKdUNdMxM /0EzhthMjPyoGFUtGuEhkmveTpnuqfY9CvfCTd0SRmSyuQvSe5zOeWOqhkeNF4OM uXhcFCI9H06KIsvSVh9DyQ= Received: from localhost.localdomain (unknown [124.16.141.247]) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wDn75zGrilnWUHdAw--.23436S4; Tue, 05 Nov 2024 13:36:09 +0800 (CST) From: Wentao Liang To: shannon.nelson@amd.com, brett.creeley@amd.com, davem@davemloft.net, kuba@kernel.org Cc: linux-kernel@vger.kernel.org, Wentao Liang Subject: [PATCH] ionic: fix memory leak in ionic_probe Date: Tue, 5 Nov 2024 13:34:33 +0800 Message-ID: <20241105053433.1614-1-Wentao_liang_g@163.com> X-Mailer: git-send-email 2.42.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDn75zGrilnWUHdAw--.23436S4 X-Coremail-Antispam: 1Uf129KBjvdXoW7Wr43JFy7tFWkJw1kAr1xAFb_yoWkWrc_K3 48Zr9xJ3y5Gr18tw17Kr43Z34a9FZagr18Ja1SgFWfKa429r4DAF1DZFnrXa1rWr1xAFZ8 ZFn3tFy5Z340qjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRWnQUUUUUUU== X-CM-SenderInfo: xzhq3t5rboxtpqjbwqqrwthudrp/1tbiDxCOL2cpqyZI8wAAsG Content-Type: text/plain; charset="utf-8" In line 334, the ionic_setup_one() creates a debugfs entry for ionic upon successful execution. However, the ionic_probe() does not release the dentry before returning, resulting in a memory leak. To fix this bug, we add the ionic_debugfs_del_dev() before line 397 to release the resources before the function returns. Signed-off-by: Wentao Liang --- drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/= net/ethernet/pensando/ionic/ionic_bus_pci.c index b93791d6b593..f5dc876eb500 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c @@ -394,6 +394,7 @@ static int ionic_probe(struct pci_dev *pdev, const stru= ct pci_device_id *ent) err_out_pci: ionic_dev_teardown(ionic); ionic_clear_pci(ionic); + ionic_debugfs_del_dev(ionic); err_out: mutex_destroy(&ionic->dev_cmd_lock); ionic_devlink_free(ionic); --=20 2.42.0.windows.2