From nobody Sun Nov 24 15:24:19 2024 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F063E192D99; Mon, 4 Nov 2024 11:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721415; cv=none; b=Ijh61KhQRSC/QH3FJo96RyWAEs2DFkovX80Sqr8SOf2eZLwGMZNqxi3ZsPt5kDmIb6gIhnrw5LMGF7upRgJ4AaDg/QxNPKWZFsXd0AbvZ0m5QSePy7hcr98JwSJgzw/P2/j2kAX5VLsZ4aa0P7DCQ4iKTl/JQK32/wty0FTEWeQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721415; c=relaxed/simple; bh=tW6lYfDQgWTzkIZNrcEony2IMOCr5u+WoYAYNqXNnNg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ZQYjYu4IbbLS4La+9gHB2MSNg9xDKVxTbmrCQ9sGnGlPuQ9Pj7P08QvsYz6IAjIajq/aSRT8LJtX9ykafXsFTelr52rUKVMJS5HlxOaTIV534iDtnOpbKY5585FrWRSyHw9MwO5QjoCSmSJXK9qm5yqC8z8I307Q3RQV57LuS/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=LGexz7H/; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="LGexz7H/" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4BjX6A013486; Mon, 4 Nov 2024 11:56:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=r7QGRJT45n0T5+Wc2ENAMTJg AWENYDW4gQh9c7sFtMA=; b=LGexz7H/pgS4ghvnQNtGWZnB/K1ux3FPGNogdG1O x6g9u3m3lXOVdHf0DxcAo8CyzRkIB7zUjKmHldNU24zV44udehHErCY/h6kc1YJ4 rZzt7ULrH2XVZBp6E54eSO1nFctlsCmj+ZHnPdDHGyZ6uFMT7waHWlnkLgQcmL71 JdqviHOMgkdboF9ARsC+jFYM04vYpkhnixpTq1UPXobeagkuRmbC+brSB10HowQv KYKQNfdWXvszOR521dm96y79j14Vi1Ck5XeD6nLK8fT6C4i5ImbEU9WY0uildXZe SEFuJNInJ/M7zj1X7UfBWC85zOXoDKoDpSR/Dl7NpcNufg== Received: from nalasppmta02.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd4um2n9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Nov 2024 11:56:36 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA02.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A4BuP6A004862 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Nov 2024 11:56:25 GMT Received: from jinlmao-gv.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 4 Nov 2024 03:56:21 -0800 From: Mao Jinlong To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mao Jinlong , "Alexander Shishkin" CC: , , , , Subject: [PATCH v6 1/3] dt-bindings: arm: Add arm,static-trace-id for coresight dummy source Date: Mon, 4 Nov 2024 19:56:02 +0800 Message-ID: <20241104115604.14522-2-quic_jinlmao@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20241104115604.14522-1-quic_jinlmao@quicinc.com> References: <20241104115604.14522-1-quic_jinlmao@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: JznvFPf7BOZQmtmtC0KLiLiT7LA1wo3w X-Proofpoint-ORIG-GUID: JznvFPf7BOZQmtmtC0KLiLiT7LA1wo3w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=910 impostorscore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411040105 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some dummy source HW has static trace id which cannot be changed via software programming. Add arm,static-trace-id for static id support to coresight dummy source. Signed-off-by: Mao Jinlong Reviewed-by: Rob Herring (Arm) Reviewed-by: Mike Leach --- .../devicetree/bindings/arm/arm,coresight-dummy-source.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-sour= ce.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.= yaml index 04a8c37b4aff..742dc4e25d3b 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-dummy-source.yaml @@ -38,6 +38,12 @@ properties: enum: - arm,coresight-dummy-source =20 + arm,static-trace-id: + description: If dummy source needs static id support, use this to set = trace id. + $ref: /schemas/types.yaml#/definitions/uint32 + minimum: 1 + maximum: 111 + out-ports: $ref: /schemas/graph.yaml#/properties/ports =20 --=20 2.17.1 From nobody Sun Nov 24 15:24:19 2024 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88D8E192D99; Mon, 4 Nov 2024 11:56:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721421; cv=none; b=cYZAKOZWQdi1ryBcVFD+bfo5+G9YIS5xNRpcRnszAt6SdcL/Wmx4gg+3Fp90mKIxUHzhuc0779Dno9yPLG/7AS7cxeO24dq6CaQZvoh8xebTDlCAlMiP260/CaQbMOVhKoMIMiLkRX3wAW6QsCHlULUEz2XcGf+zDmSlwphTqqE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721421; c=relaxed/simple; bh=s8U56cssd7IMg9M8LNalQxYZn3ZKw0rJDsT5kelVzfM=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eFMDjJTty9yjm2PJvPzE+ylAKonqAc/itr3DmhkphJtd5fKj1xUZScRJbClqHVIFm1HpqT8xaJtgAG8ZzdV4Y/17iJyIx8pLSsxsVLP4bd05G8okCjlqfwBBbuFURRkKhtoZ66RdVy21THAT7zIJYxgDZirY5c1HgDL3+FP2vXM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=Z2PZbyey; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="Z2PZbyey" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4BjXGG013477; Mon, 4 Nov 2024 11:56:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=UOm8t3tx397O6nSn3xLibpe5 sobjrBVkHwLcbsHi2vg=; b=Z2PZbyey9pZCiAkUx67sGk7MKt1k/rnf2ZIg9iwZ 5VUt1F3NkF3xkVVmQq+ZO0Uc0wlihSzXzKQ+uQec1iKUIqVsZOyIkPKRVoN1CrOv nJzLv7Ft7yJPUfIg71NJo76dTe8ZUCUjNYGW5WQIHcR7y8Cy+C4DGO4PL7A71Hm1 +37coQPoOwIySqF5cyahR4sy7Wq6YcQEFoMxbPO7AX+cA0Fp9C7oKLZl9pQ+6EOh 5DeIjMYBC/eSvE7HWPuF4/lYkX8FfSsC3hsLLXIwN8c/le+jF8E46Q+M2yl9Wb6E eQKUwpcyXrXMXX2/bcSwxBhF5obbvkjKix6Q3V7+ZlidMQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42nd4um2p1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Nov 2024 11:56:47 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A4BuSuC004393 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Nov 2024 11:56:28 GMT Received: from jinlmao-gv.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 4 Nov 2024 03:56:25 -0800 From: Mao Jinlong To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mao Jinlong , "Alexander Shishkin" CC: , , , , Subject: [PATCH v6 2/3] coresight: Add support to get static id for system trace sources Date: Mon, 4 Nov 2024 19:56:03 +0800 Message-ID: <20241104115604.14522-3-quic_jinlmao@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20241104115604.14522-1-quic_jinlmao@quicinc.com> References: <20241104115604.14522-1-quic_jinlmao@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: xa2-vw6mkQSFeP7Qw4DT09FP2vdLpRwt X-Proofpoint-ORIG-GUID: xa2-vw6mkQSFeP7Qw4DT09FP2vdLpRwt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 priorityscore=1501 mlxlogscore=999 impostorscore=0 suspectscore=0 spamscore=0 mlxscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411040105 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Dynamic trace id was introduced in coresight subsystem, so trace id is allocated dynamically. However, some hardware ATB source has static trace id and it cannot be changed via software programming. For such source, it can call coresight_get_static_trace_id to get the fixed trace id from device node and pass id to coresight_trace_id_get_static_system_id to reserve the id. Signed-off-by: Mao Jinlong Reviewed-by: Mike Leach --- .../hwtracing/coresight/coresight-platform.c | 6 +++ .../hwtracing/coresight/coresight-trace-id.c | 39 +++++++++++++------ .../hwtracing/coresight/coresight-trace-id.h | 9 +++++ include/linux/coresight.h | 1 + 4 files changed, 44 insertions(+), 11 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwt= racing/coresight/coresight-platform.c index 64e171eaad82..633d96b9577a 100644 --- a/drivers/hwtracing/coresight/coresight-platform.c +++ b/drivers/hwtracing/coresight/coresight-platform.c @@ -796,6 +796,12 @@ int coresight_get_cpu(struct device *dev) } EXPORT_SYMBOL_GPL(coresight_get_cpu); =20 +int coresight_get_static_trace_id(struct device *dev, u32 *id) +{ + return fwnode_property_read_u32(dev_fwnode(dev), "arm,static-trace-id", i= d); +} +EXPORT_SYMBOL_GPL(coresight_get_static_trace_id); + struct coresight_platform_data * coresight_get_platform_data(struct device *dev) { diff --git a/drivers/hwtracing/coresight/coresight-trace-id.c b/drivers/hwt= racing/coresight/coresight-trace-id.c index d98e12cb30ec..df8fe50b413f 100644 --- a/drivers/hwtracing/coresight/coresight-trace-id.c +++ b/drivers/hwtracing/coresight/coresight-trace-id.c @@ -12,6 +12,12 @@ =20 #include "coresight-trace-id.h" =20 +enum trace_id_flags { + TRACE_ID_ANY =3D 0x0, + TRACE_ID_PREFER_ODD =3D 0x1, + TRACE_ID_REQ_STATIC =3D 0x2, +}; + /* Default trace ID map. Used in sysfs mode and for system sources */ static DEFINE_PER_CPU(atomic_t, id_map_default_cpu_ids) =3D ATOMIC_INIT(0); static struct coresight_trace_id_map id_map_default =3D { @@ -74,16 +80,18 @@ static int coresight_trace_id_find_odd_id(struct coresi= ght_trace_id_map *id_map) * Otherwise allocate next available ID. */ static int coresight_trace_id_alloc_new_id(struct coresight_trace_id_map *= id_map, - int preferred_id, bool prefer_odd_id) + int preferred_id, unsigned int flags) { int id =3D 0; =20 /* for backwards compatibility, cpu IDs may use preferred value */ - if (IS_VALID_CS_TRACE_ID(preferred_id) && - !test_bit(preferred_id, id_map->used_ids)) { - id =3D preferred_id; - goto trace_id_allocated; - } else if (prefer_odd_id) { + if (IS_VALID_CS_TRACE_ID(preferred_id)) { + if (!test_bit(preferred_id, id_map->used_ids)) { + id =3D preferred_id; + goto trace_id_allocated; + } else if (flags & TRACE_ID_REQ_STATIC) + return -EINVAL; + } else if (flags & TRACE_ID_PREFER_ODD) { /* may use odd ids to avoid preferred legacy cpu IDs */ id =3D coresight_trace_id_find_odd_id(id_map); if (id) @@ -153,7 +161,7 @@ static int _coresight_trace_id_get_cpu_id(int cpu, stru= ct coresight_trace_id_map */ id =3D coresight_trace_id_alloc_new_id(id_map, CORESIGHT_LEGACY_CPU_TRACE_ID(cpu), - false); + TRACE_ID_ANY); if (!IS_VALID_CS_TRACE_ID(id)) goto get_cpu_id_out_unlock; =20 @@ -188,14 +196,14 @@ static void _coresight_trace_id_put_cpu_id(int cpu, s= truct coresight_trace_id_ma DUMP_ID_MAP(id_map); } =20 -static int coresight_trace_id_map_get_system_id(struct coresight_trace_id_= map *id_map) +static int coresight_trace_id_map_get_system_id(struct coresight_trace_id_= map *id_map, + int preferred_id, unsigned int traceid_flags) { unsigned long flags; int id; =20 spin_lock_irqsave(&id_map->lock, flags); - /* prefer odd IDs for system components to avoid legacy CPU IDS */ - id =3D coresight_trace_id_alloc_new_id(id_map, 0, true); + id =3D coresight_trace_id_alloc_new_id(id_map, preferred_id, traceid_flag= s); spin_unlock_irqrestore(&id_map->lock, flags); =20 DUMP_ID(id); @@ -255,10 +263,19 @@ EXPORT_SYMBOL_GPL(coresight_trace_id_read_cpu_id_map); =20 int coresight_trace_id_get_system_id(void) { - return coresight_trace_id_map_get_system_id(&id_map_default); + /* prefer odd IDs for system components to avoid legacy CPU IDS */ + return coresight_trace_id_map_get_system_id(&id_map_default, 0, + TRACE_ID_PREFER_ODD); } EXPORT_SYMBOL_GPL(coresight_trace_id_get_system_id); =20 +int coresight_trace_id_get_static_system_id(int trace_id) +{ + return coresight_trace_id_map_get_system_id(&id_map_default, + trace_id, TRACE_ID_REQ_STATIC); +} +EXPORT_SYMBOL_GPL(coresight_trace_id_get_static_system_id); + void coresight_trace_id_put_system_id(int id) { coresight_trace_id_map_put_system_id(&id_map_default, id); diff --git a/drivers/hwtracing/coresight/coresight-trace-id.h b/drivers/hwt= racing/coresight/coresight-trace-id.h index 9aae50a553ca..db68e1ec56b6 100644 --- a/drivers/hwtracing/coresight/coresight-trace-id.h +++ b/drivers/hwtracing/coresight/coresight-trace-id.h @@ -116,6 +116,15 @@ int coresight_trace_id_read_cpu_id_map(int cpu, struct= coresight_trace_id_map *i */ int coresight_trace_id_get_system_id(void); =20 +/** + * Allocate a CoreSight static trace ID for a system component. + * + * Used to allocate static IDs for system trace sources such as dummy sour= ce. + * + * return: Trace ID or -EINVAL if allocation is impossible. + */ +int coresight_trace_id_get_static_system_id(int id); + /** * Release an allocated system trace ID. * diff --git a/include/linux/coresight.h b/include/linux/coresight.h index c13342594278..129795873072 100644 --- a/include/linux/coresight.h +++ b/include/linux/coresight.h @@ -662,6 +662,7 @@ void coresight_relaxed_write64(struct coresight_device = *csdev, void coresight_write64(struct coresight_device *csdev, u64 val, u32 offset= ); =20 extern int coresight_get_cpu(struct device *dev); +extern int coresight_get_static_trace_id(struct device *dev, u32 *id); =20 struct coresight_platform_data *coresight_get_platform_data(struct device = *dev); struct coresight_connection * --=20 2.17.1 From nobody Sun Nov 24 15:24:19 2024 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03ED31B3946; Mon, 4 Nov 2024 11:57:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721456; cv=none; b=kR2kjESma69XBODbF20Bcapkv+vSVjxvLAkvkW80WsVwLAja+wNM9pFn9i6c5atN+1e0pRYyGNr4sD1DJfrzyI53kFA/hR2zZwFhusrWTC+gMlM2Xls3WO5vE/xBNywcWHjwErXHFFOflueSHw3IkE2Zvv1FkLPYVOtLDNt0oqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730721456; c=relaxed/simple; bh=Fp9acJAq1viml6aONoLkrzH1j6dXeAAq6r3AB7BKNDk=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kWf/lri9Nul69vcNxYCh98dbIT5JEqCQVoHG8qSgv4TAy4V5kcl8dJA/V8RXWebYMFdTTGamk0wcXBjKZjbHA4tWvepTfbxDIj9Ux1pnoj67hRKDnFLbekpozHXLCsSgpxB6FHMjtR5B3wALAFSQGwRt4ksRJkrb2XaGuihjWsI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=h8I5zDmI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="h8I5zDmI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4A4Bu4Mt028042; Mon, 4 Nov 2024 11:57:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=lzclN3YhOCRQjbGcg650MTM0 tplf8gQukz0VcoeCgJk=; b=h8I5zDmIoggkokRcI/9A/6SU4j6vSXzPgWSBh6/X JI/Wwz59EgDigaU5+whgmcyzko36UQG2QjmdM5r3YNWaTS/VpWk1t2fidJsKv/HN 8AVVCbli7eFDUNJZzNKsAED+fG2HQXeXMhSVjpzJFn7jFQiRL1LVd7Qnm7mIh+Bb UtmNV1YA9nV0tLT2YJ//E0ayeXhtzP7eYGkiiXisSlyc/R+AOzm5+pqc6ZVrt5qg 8g/sQkTwnpJ6/2K/ZPNlxTQffd7C6Ymbbklj+mWqK3JUPzjPQnVkWvA+HxeH1G76 52r/qDLjp8q/uez6WyYBH5BFQidbttiolwzbu/K4Vo86tA== Received: from nalasppmta03.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 42p5ye263m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Nov 2024 11:57:14 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA03.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 4A4BuWxn008070 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 4 Nov 2024 11:56:32 GMT Received: from jinlmao-gv.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Mon, 4 Nov 2024 03:56:28 -0800 From: Mao Jinlong To: Suzuki K Poulose , Mike Leach , James Clark , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mao Jinlong , "Alexander Shishkin" CC: , , , , Subject: [PATCH v6 3/3] coresight: dummy: Add static trace id support for dummy source Date: Mon, 4 Nov 2024 19:56:04 +0800 Message-ID: <20241104115604.14522-4-quic_jinlmao@quicinc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20241104115604.14522-1-quic_jinlmao@quicinc.com> References: <20241104115604.14522-1-quic_jinlmao@quicinc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: pwkGq2YEquS1tezv9Gtc6pV9wxShRQWf X-Proofpoint-GUID: pwkGq2YEquS1tezv9Gtc6pV9wxShRQWf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 mlxscore=0 spamscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411040105 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some dummy source has static trace id configured in HW and it cannot be changed via software programming. Configure the trace id in device tree and reserve the id when device probe. Signed-off-by: Mao Jinlong --- .../sysfs-bus-coresight-devices-dummy-source | 15 ++++ drivers/hwtracing/coresight/coresight-dummy.c | 81 ++++++++++++++++--- 2 files changed, 87 insertions(+), 9 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-d= ummy-source diff --git a/Documentation/ABI/testing/sysfs-bus-coresight-devices-dummy-so= urce b/Documentation/ABI/testing/sysfs-bus-coresight-devices-dummy-source new file mode 100644 index 000000000000..c7d975e75d85 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-coresight-devices-dummy-source @@ -0,0 +1,15 @@ +What: /sys/bus/coresight/devices/dummy_source/enable_source +Date: Oct 2024 +KernelVersion: 6.13 +Contact: Mao Jinlong +Description: (RW) Enable/disable tracing of dummy source. A sink should be= activated + before enabling the source. The path of coresight components linking + the source to the sink is configured and managed automatically by the + coresight framework. + +What: /sys/bus/coresight/devices/dummy_source/traceid +Date: Oct 2024 +KernelVersion: 6.13 +Contact: Mao Jinlong +Description: (R) Show the trace ID that will appear in the trace stream + coming from this trace entity. diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtrac= ing/coresight/coresight-dummy.c index bb85fa663ffc..666fd36b81b9 100644 --- a/drivers/hwtracing/coresight/coresight-dummy.c +++ b/drivers/hwtracing/coresight/coresight-dummy.c @@ -11,10 +11,12 @@ #include =20 #include "coresight-priv.h" +#include "coresight-trace-id.h" =20 struct dummy_drvdata { struct device *dev; struct coresight_device *csdev; + u8 traceid; }; =20 DEFINE_CORESIGHT_DEVLIST(source_devs, "dummy_source"); @@ -72,6 +74,32 @@ static const struct coresight_ops dummy_sink_cs_ops =3D { .sink_ops =3D &dummy_sink_ops, }; =20 +/* User can get the trace id of dummy source from this node. */ +static ssize_t traceid_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + unsigned long val; + struct dummy_drvdata *drvdata =3D dev_get_drvdata(dev->parent); + + val =3D drvdata->traceid; + return sysfs_emit(buf, "%#lx\n", val); +} +static DEVICE_ATTR_RO(traceid); + +static struct attribute *coresight_dummy_attrs[] =3D { + &dev_attr_traceid.attr, + NULL, +}; + +static const struct attribute_group coresight_dummy_group =3D { + .attrs =3D coresight_dummy_attrs, +}; + +static const struct attribute_group *coresight_dummy_groups[] =3D { + &coresight_dummy_group, + NULL, +}; + static int dummy_probe(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; @@ -79,6 +107,11 @@ static int dummy_probe(struct platform_device *pdev) struct coresight_platform_data *pdata; struct dummy_drvdata *drvdata; struct coresight_desc desc =3D { 0 }; + int ret =3D 0, trace_id =3D 0; + + drvdata =3D devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); + if (!drvdata) + return -ENOMEM; =20 if (of_device_is_compatible(node, "arm,coresight-dummy-source")) { =20 @@ -90,6 +123,26 @@ static int dummy_probe(struct platform_device *pdev) desc.subtype.source_subtype =3D CORESIGHT_DEV_SUBTYPE_SOURCE_OTHERS; desc.ops =3D &dummy_source_cs_ops; + desc.groups =3D coresight_dummy_groups; + + ret =3D coresight_get_static_trace_id(dev, &trace_id); + if (!ret) { + /* Get the static id if id is set in device tree. */ + ret =3D coresight_trace_id_get_static_system_id(trace_id); + if (ret < 0) { + dev_err(dev, "Fail to get static id.\n"); + return -EBUSY; + } + } else { + /* Get next available id if id is not set in device tree. */ + trace_id =3D coresight_trace_id_get_system_id(); + if (trace_id < 0) { + ret =3D trace_id; + return ret; + } + } + drvdata->traceid =3D (u8)trace_id; + } else if (of_device_is_compatible(node, "arm,coresight-dummy-sink")) { desc.name =3D coresight_alloc_device_name(&sink_devs, dev); if (!desc.name) @@ -104,27 +157,35 @@ static int dummy_probe(struct platform_device *pdev) } =20 pdata =3D coresight_get_platform_data(dev); - if (IS_ERR(pdata)) - return PTR_ERR(pdata); + if (IS_ERR(pdata)) { + ret =3D PTR_ERR(pdata); + goto free_id; + } pdev->dev.platform_data =3D pdata; =20 - drvdata =3D devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); - if (!drvdata) - return -ENOMEM; - drvdata->dev =3D &pdev->dev; platform_set_drvdata(pdev, drvdata); =20 desc.pdata =3D pdev->dev.platform_data; desc.dev =3D &pdev->dev; drvdata->csdev =3D coresight_register(&desc); - if (IS_ERR(drvdata->csdev)) - return PTR_ERR(drvdata->csdev); + if (IS_ERR(drvdata->csdev)) { + ret =3D PTR_ERR(drvdata->csdev); + goto free_id; + } =20 pm_runtime_enable(dev); dev_dbg(dev, "Dummy device initialized\n"); =20 - return 0; + ret =3D 0; + goto out; + +free_id: + if (IS_VALID_CS_TRACE_ID(drvdata->traceid)) + coresight_trace_id_put_system_id(drvdata->traceid); + +out: + return ret; } =20 static void dummy_remove(struct platform_device *pdev) @@ -132,6 +193,8 @@ static void dummy_remove(struct platform_device *pdev) struct dummy_drvdata *drvdata =3D platform_get_drvdata(pdev); struct device *dev =3D &pdev->dev; =20 + if (IS_VALID_CS_TRACE_ID(drvdata->traceid)) + coresight_trace_id_put_system_id(drvdata->traceid); pm_runtime_disable(dev); coresight_unregister(drvdata->csdev); } --=20 2.17.1