From nobody Sun Nov 24 20:58:27 2024 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52DC71C9DFA for ; Fri, 1 Nov 2024 18:15:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484949; cv=none; b=MDNEc16KegcQpqZfWMeIjs8dt/0epsDDLrqL4fr9vH0vJeBXOjSoBE3FneJqHODJal6lQxZUnGMY8TJf9zbzBQS3wFB28MlAJX+gwdLPXdFpoyAKWqJm9tUwIrdFlSlSsF9PJxUzJqdgqCpC2okT15AnZVgobXNIePSp7qBX/Dc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484949; c=relaxed/simple; bh=FW8JHk3YGfbCYGtZ3Mzk1ogv3Mmj+0IgvWXC0ldYUQ8=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=pgL1wpUmSS4/Y2LLDskYac59SWCxZVIzS9AR6XQAGFV/ULvKML+IK9Oe+7AR8KXCCCrBdT3pgxcJWDvLAtc/YKmWT7QpKTnz5TF4y66O6+16HUds8j1ENhXPuJf4EqjYJzNBYwSH0EAXnLdvDqigdIHOQpli01GVkstKdW5xQE0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=DhPIakyU; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="DhPIakyU" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2e2ed2230fcso2694408a91.0 for ; Fri, 01 Nov 2024 11:15:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730484948; x=1731089748; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=q2bdkQ9H/fP+Nu98WcPEJqY3qMdHmveh6b6/XkHLIus=; b=DhPIakyU+PGljn1IYsHRJVHApfz5j7W8fLttrF7UCdH7rPJezxDMskrTzm1OFfjINW NSqzlasgKXkhEvKZ7HuwuENlL/+1CbRpU0CMrIdsuyoz64WYdmZN/Le1jL5MvCls4aaU bjhZvi2n1vz93RzxOg8fLCbN87wyJ6u/gVv1AuDqRFfsehrDq+lWTzArpYJrBtl6XWW7 OgAn7PDdxc3aX36wfNudo1AL6ipuB1pj7KYKcJfuN3E20J5pdyg53kbYqNDpxkfT1SPS 9aKwI26xrSAOBlg32C26DMzY7vEYFZiA3KS04TrYMCyWQ7jT7wDJqlKdF14fCUoKEO/K fb3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730484948; x=1731089748; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q2bdkQ9H/fP+Nu98WcPEJqY3qMdHmveh6b6/XkHLIus=; b=ljLlu6GCYDMIt9yjf9jVpF+V8felhDbdso+A45EL05YMOkEl+gtpz95ntEF5hMd9UT QcBVN5oJMu4EcheyqAZNAcTdTHqhbrUJzOLXfXqS8+UrKuyRmlDA9Sg/UDhke3NcPuQR SmxByjCQuU3OUbcWFA2aoE/TOaSVWGIFwBZvN6ZMtMBFEE4tDz/CfPExdqxlMu/mMTbl O47Owo8MtpoC0lomI7ZAgahZa0Et3lq+mEw0AYXEpIM1PQBrkcD+1QabrghuGAeCLnxu M3rDwuCfG7qYwcCSP3D07ugUAaLaNGjFpW95vUTLqJf2PV9hF6iv2L6ODFgt4xHbzb6s rdqA== X-Gm-Message-State: AOJu0Yz9XoirMV0psTK16ljCtuFA/Mfi52t+al5mP5d5xyHYbQdLDy0l L7POgXntDaAXAgBZ28eXRkphAWRvKHFJYKREtM/u0cjehIAfAIFd4fSGLq7XVhZ58JZ0jjjToAx x+btBjRqOu1C5oGCt2s9IL/CBVPFXx4KZcKnqnwrt8bf++Ru0s0hBbULUYmmr57GqaCtsikyGYQ qY8TLdZIYWXDZAx0kXyWBGChhGGhdP1HJhoNXoLk5tk2u/d5q4qtOlTdnYz4D1Qqvhx2U= X-Google-Smtp-Source: AGHT+IFlwPuf/K5AJA0znbtgKqO2qjyZICURRqpIPVlJ0DxEHxgaCJsPPCi1KIaDOmrvJ9kcdz+yRyVUuPdSr5nT+g== X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:36:e7b8:ac13:c9e8]) (user=dionnaglaze job=sendgmr) by 2002:a17:90a:62c5:b0:2e2:bad0:926e with SMTP id 98e67ed59e1d1-2e93c1c9adamr28528a91.4.1730484946570; Fri, 01 Nov 2024 11:15:46 -0700 (PDT) Date: Fri, 1 Nov 2024 18:15:26 +0000 In-Reply-To: <20241101181533.1976040-1-dionnaglaze@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241101181533.1976040-1-dionnaglaze@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241101181533.1976040-2-dionnaglaze@google.com> Subject: [PATCH v2 1/4] kvm: svm: Fix gctx page leak on invalid inputs From: Dionna Glaze To: linux-kernel@vger.kernel.org, x86@kernel.org, Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Michael Roth , Brijesh Singh , Ashish Kalra Cc: Dionna Glaze , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang , kvm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Ensure that snp gctx page allocation is adequately deallocated on failure during snp_launch_start. Fixes: 136d8bc931c8 ("KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command") CC: Sean Christopherson CC: Paolo Bonzini CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: Ashish Kalra CC: Tom Lendacky CC: John Allen CC: Herbert Xu CC: "David S. Miller" CC: Michael Roth CC: Luis Chamberlain CC: Russ Weight CC: Danilo Krummrich CC: Greg Kroah-Hartman CC: "Rafael J. Wysocki" CC: Tianfei zhang Signed-off-by: Dionna Glaze --- arch/x86/kvm/svm/sev.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index 714c517dd4b72..f6e96ec0a5caa 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -2212,10 +2212,6 @@ static int snp_launch_start(struct kvm *kvm, struct = kvm_sev_cmd *argp) if (sev->snp_context) return -EINVAL; =20 - sev->snp_context =3D snp_context_create(kvm, argp); - if (!sev->snp_context) - return -ENOTTY; - if (params.flags) return -EINVAL; =20 @@ -2230,6 +2226,10 @@ static int snp_launch_start(struct kvm *kvm, struct = kvm_sev_cmd *argp) if (params.policy & SNP_POLICY_MASK_SINGLE_SOCKET) return -EINVAL; =20 + sev->snp_context =3D snp_context_create(kvm, argp); + if (!sev->snp_context) + return -ENOTTY; + start.gctx_paddr =3D __psp_pa(sev->snp_context); start.policy =3D params.policy; memcpy(start.gosvw, params.gosvw, sizeof(params.gosvw)); --=20 2.47.0.163.g1226f6d8fa-goog From nobody Sun Nov 24 20:58:27 2024 Received: from mail-pf1-f201.google.com (mail-pf1-f201.google.com [209.85.210.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C99411CEAA7 for ; Fri, 1 Nov 2024 18:15:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484951; cv=none; b=JjSe8qcBSFle0FknW3pXa27gSqRk9ko2mtE4eaT1HXD0n5PvHvwJGO9bqrEH0jt7vdDlmJRhlpN+bLyUsdfTc89xeDPBEbMsX+V1b///nkPorZytY9g6OsxtRWlYS6tDZG2mvdPq6Aaln5f5DiDGBKBySLfKB+NjUlcju7DL+64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484951; c=relaxed/simple; bh=CRLaBJcbgMnRwxlma4TtUjkzI9nzDDegqxb4hAOa1II=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=LHDCoWg9IPbNzv+YfCvyzeVl+SZOxoCxdybaKcgvoWSzaRhzJ3NHkZmaT/1HYk/mseV+O5IRdCfYu9nXWmwMVbkZBsURgOGjjA9ZSUMIt2xphp7038Ax+QWLPv2IhJJi3VaCA2+S4xnkVpTSiI4QrXyuZJ3Jv5IPRS4Y2EImcuI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uEM4odJ3; arc=none smtp.client-ip=209.85.210.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uEM4odJ3" Received: by mail-pf1-f201.google.com with SMTP id d2e1a72fcca58-71e467c39a4so2822043b3a.3 for ; Fri, 01 Nov 2024 11:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730484949; x=1731089749; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=A+HgrFNy1S3okvh+7az30cmRtXI+hsD3EQs9truFaNI=; b=uEM4odJ3R4z0Htq5/g82UZahx1T7Iioim9lSIE1t3pREdbfXhvRP6b1hNWnB+EP1t8 BcwCl/Oa6DTFLprkXws/5ovIgvdh0pCObTEpD2KfHiCjE54Y/U4ATXQtz6AkAX8QL8Q1 +4nbQq3zpfhTD/XFk4vxHt1Ah8DQR/FvSn+H8bfkXc1SQ5xyK3Tca42BkNyrMHOnabwb H5/fecZDTiFmOE+PVJ/0DyMUYRLx5bZMAxNubFCK9Cz1EkPcPXb93YtddKQFuuG1FqQk iYllhl1dMLa44zfjUywTdjn8wluROg69RCitNZOwAzv9jk1vruNj9aZ8gl6MAfI2ZbBO 6Png== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730484949; x=1731089749; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A+HgrFNy1S3okvh+7az30cmRtXI+hsD3EQs9truFaNI=; b=H7lLA7mKBCdRZJfgRhSKS4Nrl0PqsLTZNxW2aBcVS/eeYFBM75jQNHwfm5GgYVVyq4 gTy5uMAic+ZAZPMuxiv/20e1TkZ6vK3zuMAaGYn+Pq3/3EXk1qfSlKR393iIdJaNlrAH LUTduXjMoi8/ygZ+NVBX+gkfgzZrxb/JStXrrA8p7bt1TEkv2Y6f+BLFA/ZadYxX1UOK IB8dcILS11NoL6g2chDK1CTQwO1EKG8SUd8YBsOuIJE4+hXUO8z3SO5Ze5EmA6YrvTUB GSrR65lS+/1Uq5BnMrvsMKNcqTLrMKVsb6blMr4QWvBG4A6lASxv9SqdoA/AdqKiTPRz T7qA== X-Gm-Message-State: AOJu0YwPma5w3NygKEBbLaOq9hcSLcfHh9LwSFHILB526mp24YTbqlvr 4ve+R+seTOGayU8TFvJDXUHr7iGRbJcW21GU5u0tJDITTTMswcHYZS4k2tEwTXOBad1JfRN76fJ Zt7pG1q7uOQdRb/nNFh/I0NOpMpqfskHxLj8qtTSWDaYI+OdVYO/0ksIelnD5WBan9cCzgMwAUq /qT1mS5TQtJFgb7vfiXsAzJQlA+qJLFYyQpjmRz+f6nd1hfFNcAcW2MDqpWkd99XPHwK8= X-Google-Smtp-Source: AGHT+IG7wmlIzLfxL2ty/OwpieTnV1d/2VRca3whn85OUbmznjoBhH3JCc6Z4h0bptq/5GHwpF6DK0NJGNc1d6wq/Q== X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:36:e7b8:ac13:c9e8]) (user=dionnaglaze job=sendgmr) by 2002:a05:6a00:8581:b0:720:2db7:c7e3 with SMTP id d2e1a72fcca58-720b9a200fbmr50184b3a.0.1730484948657; Fri, 01 Nov 2024 11:15:48 -0700 (PDT) Date: Fri, 1 Nov 2024 18:15:27 +0000 In-Reply-To: <20241101181533.1976040-1-dionnaglaze@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241101181533.1976040-1-dionnaglaze@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241101181533.1976040-3-dionnaglaze@google.com> Subject: [PATCH v2 2/4] firmware_loader: Move module refcounts to allow unloading From: Dionna Glaze To: linux-kernel@vger.kernel.org, x86@kernel.org, Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang Cc: Dionna Glaze , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Ashish Kalra , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Michael Roth , Russ Weight Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" If a kernel module registers a firmware upload API ops set, then it's unable to be moved due to effectively a cyclic reference that the module depends on the upload which depends on the module. Instead, only require the try_module_get when an upload is requested to disallow unloading a module only while the upload is in progress. Fixes: 97730bbb242c ("firmware_loader: Add firmware-upload support") CC: Sean Christopherson CC: Paolo Bonzini CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: Ashish Kalra CC: Tom Lendacky CC: John Allen CC: Herbert Xu CC: "David S. Miller" CC: Michael Roth CC: Luis Chamberlain CC: Russ Weight CC: Danilo Krummrich CC: Greg Kroah-Hartman CC: "Rafael J. Wysocki" CC: Tianfei zhang Tested-by: Ashish Kalra Signed-off-by: Dionna Glaze Reviewed-by: Russ Weight --- drivers/base/firmware_loader/sysfs_upload.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/base/firmware_loader/sysfs_upload.c b/drivers/base/fir= mware_loader/sysfs_upload.c index 829270067d163..7d9c6aef7720a 100644 --- a/drivers/base/firmware_loader/sysfs_upload.c +++ b/drivers/base/firmware_loader/sysfs_upload.c @@ -204,6 +204,7 @@ static void fw_upload_main(struct work_struct *work) fwlp->ops->cleanup(fwl); =20 putdev_exit: + module_put(fwlp->module); put_device(fw_dev->parent); =20 /* @@ -239,6 +240,9 @@ int fw_upload_start(struct fw_sysfs *fw_sysfs) } =20 fwlp =3D fw_sysfs->fw_upload_priv; + if (!try_module_get(fwlp->module)) /* released in fw_upload_main */ + return -EFAULT; + mutex_lock(&fwlp->lock); =20 /* Do not interfere with an on-going fw_upload */ @@ -310,13 +314,10 @@ firmware_upload_register(struct module *module, struc= t device *parent, return ERR_PTR(-EINVAL); } =20 - if (!try_module_get(module)) - return ERR_PTR(-EFAULT); - fw_upload =3D kzalloc(sizeof(*fw_upload), GFP_KERNEL); if (!fw_upload) { ret =3D -ENOMEM; - goto exit_module_put; + goto exit_err; } =20 fw_upload_priv =3D kzalloc(sizeof(*fw_upload_priv), GFP_KERNEL); @@ -358,7 +359,7 @@ firmware_upload_register(struct module *module, struct = device *parent, if (ret) { dev_err(fw_dev, "%s: device_register failed\n", __func__); put_device(fw_dev); - goto exit_module_put; + goto exit_err; } =20 return fw_upload; @@ -372,8 +373,7 @@ firmware_upload_register(struct module *module, struct = device *parent, free_fw_upload: kfree(fw_upload); =20 -exit_module_put: - module_put(module); +exit_err: =20 return ERR_PTR(ret); } @@ -387,7 +387,6 @@ void firmware_upload_unregister(struct fw_upload *fw_up= load) { struct fw_sysfs *fw_sysfs =3D fw_upload->priv; struct fw_upload_priv *fw_upload_priv =3D fw_sysfs->fw_upload_priv; - struct module *module =3D fw_upload_priv->module; =20 mutex_lock(&fw_upload_priv->lock); if (fw_upload_priv->progress =3D=3D FW_UPLOAD_PROG_IDLE) { @@ -403,6 +402,5 @@ void firmware_upload_unregister(struct fw_upload *fw_up= load) =20 unregister: device_unregister(&fw_sysfs->dev); - module_put(module); } EXPORT_SYMBOL_GPL(firmware_upload_unregister); --=20 2.47.0.163.g1226f6d8fa-goog From nobody Sun Nov 24 20:58:27 2024 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AA2C1684B0 for ; Fri, 1 Nov 2024 18:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484955; cv=none; b=qNmS9xho7GKsbSWW5KKGpzQl0Md1DvuxFSO/Joia8oJQNVjJyHOhUYsruwaT/qDaGLjm9dKqpJUMsR/U+T/QgZj59J5oAOwoOOs90lhrewnPWSDV7ob/Q/mTsDDqNoXEV3z42K0dLAbiYaDA84AGw3Y/9PEkM9WDLxcTxxJZ0V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484955; c=relaxed/simple; bh=acutDWs5RdLyVYwoT65KrpKw4yMmL2UENg4qoCn0IDk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=oU8gAALtStqoEj5GIVmB1cRaA27G0lcJ7hHGq0s6eN5bX6VfN9Ux8qzIS9o4boUk4zmejmVSZGLrxfB6/FgSD6EM9hok4ee2yC49S4wuW5deo1RGHsDdOfMZLFi0PSGAefVJsGdcO5dxlwNCIob6ndQofq7GUOxE8UE2+3oo7B8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AQ7mreZk; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AQ7mreZk" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-20ca1692cb7so24468205ad.3 for ; Fri, 01 Nov 2024 11:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730484952; x=1731089752; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=WxheHXwQWugtY0Z24M6pR88jYM3VDRd3NDyd38G2+64=; b=AQ7mreZk3qJhGS85wbUsXwqEC1BP13z01coc0Ri7ZA9/G5mrxyViyIZoIupLLTH79r wywAktTqwZWskOzcNE0ECKZXsGUJaROHh6u+sh3kcx/j8dXpRJroBjOVerTOzkBTC9PS uNzC9a9Z7yMgNif7szIpPrlQ3YT1V636KoUItgsWhsAMhv8gLwLGF+Aw/ZeFGFNE2vXh Vpba4kuv6d2OTX5CXVm9jccmA4iv6QhT5B3yzWD1apZ7PFFvFr7yjoZ/qji8DhTyOFOa sMhmvY5l6mNLyACiBVcTLz1YYwRTsdgc8W41Oem+dHWsJP/g8lgbSEl6k3a9EYsEm6/0 YbaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730484952; x=1731089752; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WxheHXwQWugtY0Z24M6pR88jYM3VDRd3NDyd38G2+64=; b=lgYo8u0Kd+mIzGbyWfVgG/KIifX/Ao+DbCrjUSVf3DNCBViQo/Lo1xT7upuidt0Ksw tQvLvMAuNKFNwgePArLg0poQcW2Ap99PlXdxqsoOM7NTY4uWuom1X1rIac0pDW/4ySMf thBOfM8MaIijTpIJaEaRWbk9jjpDx0rq70wBKvgkAZAvy5iAW2+yXTwBYq9nPgwTCODc cAmiTktnj6ccr3f48BsskR34lvhY4tO4yrldzAJw/HuwJIDk5LYjWastnWIrSJFGU8nW JXTQYbYVShmkC3snvzqkdgaL7gDZA9/iCgfD2FyLv3DOCmGm3GqcAEBZWxTmZ0A91Zuw o4Dg== X-Gm-Message-State: AOJu0YzUu2c7CUORlmkGL/3qYixY+KxMH+TZlON/KOugcrZ50Mc+GwkZ 7EutmifvcIWSASNVZyaUyDDK7T3v+4xQwcHhYgsdk3o3vLHWNzD7rhBuIZWdfqTs6275F0u+JV0 n17dE3DIcVzvj8g30l+dazovlJ4BjhD5qspLk4lu5A0IZGlTal0uP7nirtxL2BjuKWkcQXEkF86 TrU9bYG33J7cMFH2KOhtqxngexsA/5HVrMFQsESZPC+j8VDw5WErSaYH9lokOlKIqXbCU= X-Google-Smtp-Source: AGHT+IGwDdotDTo4+Rc31CHMTUC4DcjckGzxa7L4lLR118zrDI0jS9nmIo2KJqo6GwzzaTbS7IRe3k41nqYr+PQqpQ== X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:36:e7b8:ac13:c9e8]) (user=dionnaglaze job=sendgmr) by 2002:a17:902:c792:b0:205:968b:31c1 with SMTP id d9443c01a7336-2111af0fb4dmr34375ad.3.1730484951732; Fri, 01 Nov 2024 11:15:51 -0700 (PDT) Date: Fri, 1 Nov 2024 18:15:28 +0000 In-Reply-To: <20241101181533.1976040-1-dionnaglaze@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241101181533.1976040-1-dionnaglaze@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241101181533.1976040-4-dionnaglaze@google.com> Subject: [PATCH v2 3/4] crypto: ccp: Add SNP firmware hotload support From: Dionna Glaze To: linux-kernel@vger.kernel.org, x86@kernel.org, Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Ashish Kalra Cc: Dionna Glaze , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Michael Roth , Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang , linux-crypto@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" uapi changes: The status values added are defined in AMD's SEV-SNP API documentation as new error modes for the DOWNLOAD_FIRMWARE_EX command. On init, the ccp device will make /sys/class/firmware/amd/loading etc firmware upload API attributes available to late-load a SEV-SNP firmware binary. The firmware upload api errors reported are actionable in the following ways: * FW_UPLOAD_ERR_HW_ERROR: the machine is in an unstable state and must be reset. * FW_UPLOAD_ERR_RW_ERROR: the firmware update went bad but can be recovered by hotloading the previous firmware version. Also used in the case that the kernel used the API wrong (bug). * FW_UPLOAD_ERR_FW_INVALID: user error with the data provided, but no instability is expected and no recovery actions are needed. * FW_UPLOAD_ERR_BUSY: upload attempted at a bad time either due to overload or the machine is in the wrong platform state. snp_asid_to_gctx_page_map: Compliance with SEV-SNP API section 3.3 Firmware Updates and 4.1.1 Live Update: before a firmware is committed, all active GCTX pages should be updated with SNP_GUEST_STATUS to ensure their data structure remains consistent for the new firmware version. There can only be cpuid_edx(0x8000001f)-1 many SEV-SNP asids in use at one time, so this map associates asid to gctx in order to track which addresses are active gctx pages that need updating. When an asid and gctx page are decommissioned, the page is removed from tracking for update-purposes. Given that GCTX page creation and binding through the SNP_ACTIVATE command are separate, the creation operation also tracks pages that are yet to be bound to an asid. synthetic_restore_required: Instead of tracking the status of whether an individual GCTX is safe for use in a firmware command, force all following commands to fail with an error that is indicative of needing a firmware rollback. According to SEV-SNP API section 3.3 Firmware Updates, the DOWNLOAD_FIRMWARE_EX command is usable when the SNP firmware is in either UNINIT or INIT states, but SEV-legacy firmware must be in the UNINIT state. A sev_platform_init call when only SEV-SNP VMs are expected should set supports_download_firmware_ex to delay legacy initialization actions. The firmware can only be hotloaded for SEV VMs when legacy initialization has not happened. To test: 1. Build the kernel enabling SEV-SNP as normal and add CONFIG_FW_UPLOAD=3Dy. 2. Add the following to your kernel_cmdline: ccp.psp_init_on_probe=3D0. 3.Get an AMD SEV-SNP firmware sbin appropriate to your Epyc chip model at https://www.amd.com/en/developer/sev.html and extract to get a .sbin file. 4. Run the following with your sbinfile in FW: echo 1 > /sys/class/firmware/snp_dlfw_ex/loading cat "${FW?}" > /sys/class/firmware/snp_dlfw_ex/data echo 0 > /sys/class/firmware/snp_dlfw_ex/loading 5. Verify the firmware update message in dmesg. CC: Sean Christopherson CC: Paolo Bonzini CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: Ashish Kalra CC: Tom Lendacky CC: John Allen CC: Herbert Xu CC: "David S. Miller" CC: Michael Roth CC: Luis Chamberlain CC: Russ Weight CC: Danilo Krummrich CC: Greg Kroah-Hartman CC: "Rafael J. Wysocki" CC: Tianfei zhang Co-developed-by: Ashish Kalra Signed-off-by: Ashish Kalra Tested-by: Ashish Kalra Signed-off-by: Dionna Glaze --- drivers/crypto/ccp/Kconfig | 2 + drivers/crypto/ccp/sev-dev.c | 398 ++++++++++++++++++++++++++++++++++- drivers/crypto/ccp/sev-dev.h | 14 ++ include/linux/psp-sev.h | 28 +++ include/uapi/linux/psp-sev.h | 5 + 5 files changed, 439 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/ccp/Kconfig b/drivers/crypto/ccp/Kconfig index f394e45e11ab4..cd9b667640e7c 100644 --- a/drivers/crypto/ccp/Kconfig +++ b/drivers/crypto/ccp/Kconfig @@ -39,6 +39,8 @@ config CRYPTO_DEV_SP_PSP bool "Platform Security Processor (PSP) device" default y depends on CRYPTO_DEV_CCP_DD && X86_64 && AMD_IOMMU + select FW_LOADER + select FW_UPLOAD help Provide support for the AMD Platform Security Processor (PSP). The PSP is a dedicated processor that provides support for key diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 9810edbb272d2..d2a79a368f848 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -223,6 +223,7 @@ static int sev_cmd_buffer_len(int cmd) case SEV_CMD_SNP_GUEST_REQUEST: return sizeof(struct sev_data_snp_guest_= request); case SEV_CMD_SNP_CONFIG: return sizeof(struct sev_user_data_snp_config); case SEV_CMD_SNP_COMMIT: return sizeof(struct sev_data_snp_commit); + case SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX: return sizeof(struct sev_data_down= load_firmware_ex); default: return 0; } =20 @@ -829,6 +830,7 @@ static int snp_reclaim_cmd_buf(int cmd, void *cmd_buf) return 0; } =20 +static void snp_cmd_bookkeeping_locked(int cmd, struct sev_device *sev, vo= id *data); static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret) { struct cmd_buf_desc desc_list[CMD_BUF_DESC_MAX] =3D {0}; @@ -852,6 +854,15 @@ static int __sev_do_cmd_locked(int cmd, void *data, in= t *psp_ret) if (WARN_ON_ONCE(!data !=3D !buf_len)) return -EINVAL; =20 + /* The firmware does not coordinate all GCTX page updates. Force an + * error to ensure that no new VM can be started and no active VM makes + * progress on guest requests until the firmware is rolled back. + */ + if (sev->synthetic_restore_required) { + *psp_ret =3D SEV_RET_RESTORE_REQUIRED; + return -EBUSY; + } + /* * Copy the incoming data to driver's scratch buffer as __pa() will not * work for some memory, e.g. vmalloc'd addresses, and @data may not be @@ -982,6 +993,9 @@ static int __sev_do_cmd_locked(int cmd, void *data, int= *psp_ret) print_hex_dump_debug("(out): ", DUMP_PREFIX_OFFSET, 16, 2, data, buf_len, false); =20 + if (!ret) + snp_cmd_bookkeeping_locked(cmd, sev, data); + return ret; } =20 @@ -1082,6 +1096,7 @@ static int snp_filter_reserved_mem_regions(struct res= ource *rs, void *arg) return 0; } =20 +static int sev_snp_platform_init_firmware_upload(struct sev_device *sev); static int __sev_snp_init_locked(int *error) { struct psp_device *psp =3D psp_master; @@ -1179,6 +1194,8 @@ static int __sev_snp_init_locked(int *error) =20 sev_es_tmr_size =3D SNP_TMR_SIZE; =20 + rc =3D sev_snp_platform_init_firmware_upload(sev); + return rc; } =20 @@ -1326,6 +1343,13 @@ static int _sev_platform_init_locked(struct sev_plat= form_init_args *args) if (args->probe && !psp_init_on_probe) return 0; =20 + /* + * Defer legacy SEV/SEV-ES support if legacy VMs are not being launched + * and module psp_init_on_probe parameter is false. + */ + if (args->supports_download_firmware_ex && !psp_init_on_probe) + return 0; + return __sev_platform_init_locked(&args->error); } =20 @@ -1592,14 +1616,8 @@ static int sev_update_firmware(struct device *dev) return -1; } =20 - /* - * SEV FW expects the physical address given to it to be 32 - * byte aligned. Memory allocated has structure placed at the - * beginning followed by the firmware being passed to the SEV - * FW. Allocate enough memory for data structure + alignment - * padding + SEV FW. - */ - data_size =3D ALIGN(sizeof(struct sev_data_download_firmware), 32); + data_size =3D ALIGN(sizeof(struct sev_data_download_firmware), + SEV_FW_ALIGNMENT); =20 order =3D get_order(firmware->size + data_size); p =3D alloc_pages(GFP_KERNEL, order); @@ -2224,6 +2242,366 @@ static int sev_misc_init(struct sev_device *sev) return 0; } =20 +#ifdef CONFIG_FW_UPLOAD + +static enum fw_upload_err snp_dlfw_ex_prepare(struct fw_upload *fw_upload, + const u8 *data, u32 size) +{ + return FW_UPLOAD_ERR_NONE; +} + +static enum fw_upload_err snp_dlfw_ex_poll_complete(struct fw_upload *fw_u= pload) +{ + return FW_UPLOAD_ERR_NONE; +} + +/* + * This may be called asynchronously with an on-going update. All other + * functions are called sequentially in a single thread. To avoid contenti= on on + * register accesses, only update the cancel_request flag. Other functions= will + * check this flag and handle the cancel request synchronously. + */ +static void snp_dlfw_ex_cancel(struct fw_upload *fw_upload) +{ + struct sev_device *sev =3D psp_master->sev_data; + + mutex_lock(&sev->fw_lock); + sev->fw_cancel =3D true; + mutex_unlock(&sev->fw_lock); +} + +static enum fw_upload_err snp_dlfw_ex_err_translate(struct sev_device *sev= , int psp_ret) +{ + dev_dbg(sev->dev, "Failed to update SEV firmware: %#x\n", psp_ret); + /* + * Operation error: + * HW_ERROR: Critical error. Machine needs repairs now. + * RW_ERROR: Severe error. Roll back to the prior version to recover. + * User error: + * FW_INVALID: Bad input for this interface. + * BUSY: Wrong machine state to run download_firmware_ex. + */ + switch (psp_ret) { + case SEV_RET_RESTORE_REQUIRED: + dev_warn(sev->dev, "Firmware updated but unusable\n"); + dev_warn(sev->dev, "Need to do manual firmware rollback!!!\n"); + return FW_UPLOAD_ERR_RW_ERROR; + case SEV_RET_SHUTDOWN_REQUIRED: + /* No state changes made. Not a hardware error. */ + dev_warn(sev->dev, "Firmware image cannot be live updated\n"); + return FW_UPLOAD_ERR_FW_INVALID; + case SEV_RET_BAD_VERSION: + /* No state changes made. Not a hardware error. */ + dev_warn(sev->dev, "Firmware image is not well formed\n"); + return FW_UPLOAD_ERR_FW_INVALID; + /* SEV-specific errors that can still happen. */ + case SEV_RET_BAD_SIGNATURE: + /* No state changes made. Not a hardware error. */ + dev_warn(sev->dev, "Firmware image signature is bad\n"); + return FW_UPLOAD_ERR_FW_INVALID; + case SEV_RET_INVALID_PLATFORM_STATE: + /* Calling at the wrong time. Not a hardware error. */ + dev_warn(sev->dev, "Firmware not updated as SEV in INIT state\n"); + return FW_UPLOAD_ERR_BUSY; + case SEV_RET_HWSEV_RET_UNSAFE: + dev_err(sev->dev, "Firmware is unstable. Reset your machine!!!\n"); + return FW_UPLOAD_ERR_HW_ERROR; + /* Kernel bug cases. */ + case SEV_RET_INVALID_PARAM: + dev_err(sev->dev, "Download-firmware-EX invalid parameter\n"); + return FW_UPLOAD_ERR_RW_ERROR; + case SEV_RET_INVALID_ADDRESS: + dev_err(sev->dev, "Download-firmware-EX invalid address\n"); + return FW_UPLOAD_ERR_RW_ERROR; + default: + dev_err(sev->dev, "Unhandled download_firmware_ex err %d\n", psp_ret); + return FW_UPLOAD_ERR_HW_ERROR; + } +} + +static enum fw_upload_err snp_dlfw_ex_write(struct fw_upload *fwl, const u= 8 *data, + u32 offset, u32 size, u32 *written) +{ + struct sev_data_download_firmware_ex *data_ex; + struct sev_data_snp_guest_status status_data; + struct sev_device *sev =3D fwl->dd_handle; + void *snp_guest_status, *fw_dest; + u8 api_major, api_minor, build; + int ret, error, order; + struct page *p; + u64 data_size; + bool cancel; + + if (!sev) + return FW_UPLOAD_ERR_HW_ERROR; + + mutex_lock(&sev->fw_lock); + cancel =3D sev->fw_cancel; + mutex_unlock(&sev->fw_lock); + + if (cancel) + return FW_UPLOAD_ERR_CANCELED; + + /* + * SEV firmware update is a one-shot update operation, the write() + * callback to be invoked multiple times for the same update is + * unexpected. + */ + if (offset) + return FW_UPLOAD_ERR_INVALID_SIZE; + + if (sev_get_api_version()) + return FW_UPLOAD_ERR_HW_ERROR; + + api_major =3D sev->api_major; + api_minor =3D sev->api_minor; + build =3D sev->build; + + data_size =3D ALIGN(sizeof(struct sev_data_download_firmware_ex), + SEV_FW_ALIGNMENT); + + order =3D get_order(size + data_size); + p =3D alloc_pages(GFP_KERNEL, order); + if (!p) { + ret =3D FW_UPLOAD_ERR_INVALID_SIZE; + goto fw_err; + } + + /* + * Copy firmware data to a kernel allocated contiguous + * memory region. + */ + data_ex =3D page_address(p); + fw_dest =3D page_address(p) + data_size; + memcpy(fw_dest, data, size); + + data_ex->address =3D __psp_pa(fw_dest); + data_ex->len =3D size; + data_ex->cmdlen =3D sizeof(struct sev_data_download_firmware_ex); + + /* + * SNP_COMMIT should be issued explicitly to commit the updated + * firmware after guest context pages have been updated. + */ + + ret =3D sev_do_cmd(SEV_CMD_SNP_DOWNLOAD_FIRMWARE_EX, data_ex, &error); + + if (ret) { + ret =3D snp_dlfw_ex_err_translate(sev, error); + goto free_err; + } + + __free_pages(p, order); + + /* Need to do a DF_FLUSH after live firmware update */ + wbinvd_on_all_cpus(); + ret =3D __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &error); + if (ret) { + dev_dbg(sev->dev, "DF_FLUSH error %d\n", error); + ret =3D FW_UPLOAD_ERR_HW_ERROR; + goto fw_err; + } + + sev_get_api_version(); + + /* + * Force an update of guest context pages after SEV firmware + * live update by issuing SNP_GUEST_STATUS on all guest + * context pages. + */ + snp_guest_status =3D sev_fw_alloc(PAGE_SIZE); + if (!snp_guest_status) { + ret =3D FW_UPLOAD_ERR_INVALID_SIZE; + goto fw_err; + } + + /* + * After the last bound asid-to-gctx page is snp_unbound_gctx_end-many + * unbound gctx pages that also need updating. + */ + for (int i =3D 1; i <=3D sev->last_snp_asid + sev->snp_unbound_gctx_end; = i++) { + if (sev->snp_asid_to_gctx_pages_map[i]) { + status_data.gctx_paddr =3D sev->snp_asid_to_gctx_pages_map[i]; + status_data.address =3D __psp_pa(snp_guest_status); + ret =3D sev_do_cmd(SEV_CMD_SNP_GUEST_STATUS, &status_data, &error); + if (ret) { + /* + * Handle race with SNP VM being destroyed/decommissoned, + * if guest context page invalid error is returned, + * assume guest has been destroyed. + */ + if (error =3D=3D SEV_RET_INVALID_GUEST) + continue; + sev->synthetic_restore_required =3D true; + dev_err(sev->dev, "SNP GCTX update error: %#x\n", error); + dev_err(sev->dev, "Roll back SNP firmware!\n"); + snp_free_firmware_page(snp_guest_status); + ret =3D FW_UPLOAD_ERR_RW_ERROR; + goto fw_err; + } + } + } + snp_free_firmware_page(snp_guest_status); + + if (api_major !=3D sev->api_major || api_minor !=3D sev->api_minor || + build !=3D sev->build) { + dev_info(sev->dev, "SEV firmware updated from %d.%d.%d to %d.%d.%d\n", + api_major, api_minor, build, + sev->api_major, sev->api_minor, sev->build); + } else { + dev_info(sev->dev, "SEV firmware same as old %d.%d.%d\n", + api_major, api_minor, build); + } + + *written =3D size; + return FW_UPLOAD_ERR_NONE; + +free_err: + __free_pages(p, order); +fw_err: + return ret; +} + +static const struct fw_upload_ops snp_dlfw_ex_ops =3D { + .prepare =3D snp_dlfw_ex_prepare, + .write =3D snp_dlfw_ex_write, + .poll_complete =3D snp_dlfw_ex_poll_complete, + .cancel =3D snp_dlfw_ex_cancel, +}; + +static void sev_snp_dev_init_firmware_upload(struct sev_device *sev) +{ + struct fw_upload *fwl; + + fwl =3D firmware_upload_register(THIS_MODULE, sev->dev, "snp_dlfw_ex", &s= np_dlfw_ex_ops, sev); + + if (IS_ERR(fwl)) + dev_err(sev->dev, "SEV firmware upload initialization error %ld\n", PTR_= ERR(fwl)); + + sev->fwl =3D fwl; + mutex_init(&sev->fw_lock); +} + +static void sev_snp_destroy_firmware_upload(struct sev_device *sev) +{ + firmware_upload_unregister(sev->fwl); +} + +/* + * After a gctx is created, it is used by snp_launch_start before getting + * bound to an asid. The launch protocol allocates an asid before creating= a + * matching gctx page, so there should never be more unbound gctx pages th= an + * there are possible SNP asids. + * + * The unbound gctx pages must be updated after executing DOWNLOAD_FIRMWAR= E_EX + * and before committing the firmware. + */ +static void snp_gctx_create_track_locked(struct sev_device *sev, void *dat= a) +{ + struct sev_data_snp_addr *gctx_create =3D data; + + /* This condition should never happen, but is needed for memory safety. */ + if (sev->snp_unbound_gctx_end >=3D sev->last_snp_asid) { + dev_warn(sev->dev, "Too many unbound SNP GCTX pages to track\n"); + return; + } + + sev->snp_unbound_gctx_pages[sev->snp_unbound_gctx_end] =3D gctx_create->a= ddress; + sev->snp_unbound_gctx_end++; +} + +/* + * PREREQUISITE: The snp_activate command was successful, meaning the asid + * is in the acceptable range 1..sev->last_snp_asid. + * + * The gctx_paddr must be in the unbound gctx buffer. + */ +static void snp_activate_track_locked(struct sev_device *sev, void *data) +{ + struct sev_data_snp_activate *data_activate =3D data; + + sev->snp_asid_to_gctx_pages_map[data_activate->asid] =3D data_activate->g= ctx_paddr; + + for (int i =3D 0; i < sev->snp_unbound_gctx_end; i++) { + if (sev->snp_unbound_gctx_pages[i] =3D=3D data_activate->gctx_paddr) { + /* + * Swap the last unbound gctx page with the now-bound + * gctx page to shrink the buffer. + */ + sev->snp_unbound_gctx_end--; + sev->snp_unbound_gctx_pages[i] =3D + sev->snp_unbound_gctx_pages[sev->snp_unbound_gctx_end]; + sev->snp_unbound_gctx_pages[sev->snp_unbound_gctx_end] =3D 0; + break; + } + } +} + +static void snp_decommission_track_locked(struct sev_device *sev, void *da= ta) +{ + struct sev_data_snp_addr *data_decommission =3D data; + + for (int i =3D 1; i <=3D sev->last_snp_asid; i++) { + if (sev->snp_asid_to_gctx_pages_map[i] =3D=3D data_decommission->address= ) { + sev->snp_asid_to_gctx_pages_map[i] =3D 0; + break; + } + } +} + +static void snp_cmd_bookkeeping_locked(int cmd, struct sev_device *sev, vo= id *data) +{ + if (!sev->snp_asid_to_gctx_pages_map) + return; + + switch (cmd) { + case SEV_CMD_SNP_GCTX_CREATE: + snp_gctx_create_track_locked(sev, data); + break; + case SEV_CMD_SNP_ACTIVATE: + snp_activate_track_locked(sev, data); + break; + case SEV_CMD_SNP_DECOMMISSION: + snp_decommission_track_locked(sev, data); + break; + default: + break; + } +} + +static int sev_snp_platform_init_firmware_upload(struct sev_device *sev) +{ + u32 max_snp_asid; + + /* + * cpuid_edx(0x8000001f) is the minimum SEV ASID, hence the exclusive + * maximum SEV-SNP ASID. Save the inclusive maximum to avoid confusing + * logic elsewhere. + */ + max_snp_asid =3D cpuid_edx(0x8000001f); + sev->last_snp_asid =3D max_snp_asid - 1; + if (sev->last_snp_asid) { + sev->snp_asid_to_gctx_pages_map =3D devm_kmalloc_array( + sev->dev, max_snp_asid * 2, sizeof(u64), GFP_KERNEL | __GFP_ZERO); + sev->snp_unbound_gctx_pages =3D &sev->snp_asid_to_gctx_pages_map[max_snp= _asid]; + if (!sev->snp_asid_to_gctx_pages_map) { + kfree(snp_range_list); + dev_err(sev->dev, + "SEV-SNP: snp_asid_to_gctx_pages_map memory allocation failed\n"); + return -ENOMEM; + } + } + return 0; +} + +#else + +static int sev_snp_platform_init_firmware_upload(struct sev_device *sev) {= return 0; } +static void sev_snp_dev_init_firmware_upload(struct sev_device *sev) { } +static void sev_snp_destroy_firmware_upload(struct sev_device *sev) { } +static void snp_cmd_bookkeeping_locked(int cmd, struct sev_device *sev, vo= id *data) { } +#endif + int sev_dev_init(struct psp_device *psp) { struct device *dev =3D psp->dev; @@ -2265,6 +2643,8 @@ int sev_dev_init(struct psp_device *psp) if (ret) goto e_irq; =20 + sev_snp_dev_init_firmware_upload(sev); + dev_notice(dev, "sev enabled\n"); =20 return 0; @@ -2343,6 +2723,8 @@ void sev_dev_destroy(struct psp_device *psp) kref_put(&misc_dev->refcount, sev_exit); =20 psp_clear_sev_irq_handler(psp); + + sev_snp_destroy_firmware_upload(sev); } =20 static int snp_shutdown_on_panic(struct notifier_block *nb, diff --git a/drivers/crypto/ccp/sev-dev.h b/drivers/crypto/ccp/sev-dev.h index 3e4e5574e88a3..d6280688675d9 100644 --- a/drivers/crypto/ccp/sev-dev.h +++ b/drivers/crypto/ccp/sev-dev.h @@ -57,6 +57,20 @@ struct sev_device { bool cmd_buf_backup_active; =20 bool snp_initialized; + +#ifdef CONFIG_FW_UPLOAD + /* Lock to protect fw_cancel */ + struct mutex fw_lock; + struct fw_upload *fwl; + bool fw_cancel; + + /* Firmware update management. */ + u32 last_snp_asid; + bool synthetic_restore_required; + u64 *snp_asid_to_gctx_pages_map; + u64 *snp_unbound_gctx_pages; + u32 snp_unbound_gctx_end; +#endif /* CONFIG_FW_UPLOAD */ }; =20 int sev_dev_init(struct psp_device *psp); diff --git a/include/linux/psp-sev.h b/include/linux/psp-sev.h index 903ddfea85850..1d8eb5d0974bf 100644 --- a/include/linux/psp-sev.h +++ b/include/linux/psp-sev.h @@ -16,6 +16,15 @@ =20 #define SEV_FW_BLOB_MAX_SIZE 0x4000 /* 16KB */ =20 +/* + * SEV FW expects the physical address given to it to be 32 + * byte aligned. Memory allocated has structure placed at the + * beginning followed by the firmware being passed to the SEV + * FW. Allocate enough memory for data structure + alignment + * padding + SEV FW. + */ +#define SEV_FW_ALIGNMENT 32 + /** * SEV platform state */ @@ -185,6 +194,22 @@ struct sev_data_download_firmware { u32 len; /* In */ } __packed; =20 +/** + * struct sev_data_download_firmware_ex - DOWNLOAD_FIRMWARE_EX command par= ameters + * + * @length: length of this command buffer + * @address: physical address of firmware image + * @len: len of the firmware image + * @commit: automatically commit the newly installed image + */ +struct sev_data_download_firmware_ex { + u32 cmdlen; /* In */ + u32 reserved; /* in */ + u64 address; /* In */ + u32 len; /* In */ + u32 commit:1; /* In */ +} __packed; + /** * struct sev_data_get_id - GET_ID command parameters * @@ -797,10 +822,13 @@ struct sev_data_snp_shutdown_ex { * @probe: True if this is being called as part of CCP module probe, which * will defer SEV_INIT/SEV_INIT_EX firmware initialization until needed * unless psp_init_on_probe module param is set + * @supports_download_firmware_ex: True if legacy SEV/SEV-ES guests are not + * being launched via KVM */ struct sev_platform_init_args { int error; bool probe; + bool supports_download_firmware_ex; }; =20 /** diff --git a/include/uapi/linux/psp-sev.h b/include/uapi/linux/psp-sev.h index 832c15d9155bd..936464d4f282a 100644 --- a/include/uapi/linux/psp-sev.h +++ b/include/uapi/linux/psp-sev.h @@ -80,6 +80,11 @@ typedef enum { SEV_RET_INVALID_PAGE_OWNER, SEV_RET_INVALID_PAGE_AEAD_OFLOW, SEV_RET_RMP_INIT_REQUIRED, + SEV_RET_BAD_SVN, + SEV_RET_BAD_VERSION, + SEV_RET_SHUTDOWN_REQUIRED, + SEV_RET_UPDATE_FAILED, + SEV_RET_RESTORE_REQUIRED, SEV_RET_MAX, } sev_ret_code; =20 --=20 2.47.0.163.g1226f6d8fa-goog From nobody Sun Nov 24 20:58:27 2024 Received: from mail-pj1-f74.google.com (mail-pj1-f74.google.com [209.85.216.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC86D1CF28A for ; Fri, 1 Nov 2024 18:15:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484956; cv=none; b=utsdGEFkknYRYre/W3VJKQtfvFNPtBRsjx3+eHE8btMACLoxDNnVJ3rQSDto8HFCBkaZtrmuA7R/bvJQXsh8LRPzB+6blQmFQBAqnvxG42jkyPCh/PSERytLNU605GS19XqLkS3c0YykJZMzeZqoSJM0NP/lcNVHQf3dtavNLk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730484956; c=relaxed/simple; bh=GSHbBwZfkYhqvZmnpUSaXG42ezayg8nwJR7cfig/aho=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VeZlUjFT0SozizWfYCZtqXpL/1PfF/EsideIE4cFJ6KLpJIjGVhtVsyWWLQjMvKvmQon06MsCb5FURTBPvtAnkC6W6bcS87r7eJjPEy84OqJ9V5rTKEWhKCNa9TFeLblFuJlQhQW6v4QHhppisv1UXuchUtEsdl/yxqpmW1JCOw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=YpTHgRMA; arc=none smtp.client-ip=209.85.216.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--dionnaglaze.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YpTHgRMA" Received: by mail-pj1-f74.google.com with SMTP id 98e67ed59e1d1-2e2ca4fb175so2519477a91.3 for ; Fri, 01 Nov 2024 11:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730484954; x=1731089754; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=MEZAnkCadaVg1BrSWxgRmpQSE/TbQcmppmH+q7yf6WQ=; b=YpTHgRMAdoZAKkHFfRpC6r90RhqV0TD28pXPHSyTRIlrKLTuXKZA3RT+jLb9A+siZ4 itulhAA4Yjk+kzxe09vqyvG+OEq7iV0EnBEVNxzKrEbxzQZC/938l+ci149VTBvIPzrZ WAdZvDFKD3rZ9oo0vWUfuRMl+Fo2dm9oSesxWg1OPy51yZFdw1Ixsum4ha8XajpBkvdM up5Nzb6a+F9Ald2mzE81CzXdkQD9W64EIhqRu1F/trpWNTL7XHuM32xDPM3YUOXOOUt6 TZ+xEJzh9Ma9CAKccIYa/X2HUnBc3O0461XALm0ivGX5ZgXEcfQBMdbjRbmbU2UojZWx x2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730484954; x=1731089754; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MEZAnkCadaVg1BrSWxgRmpQSE/TbQcmppmH+q7yf6WQ=; b=MAfye74NlRqs1fu5MglvwU+67ZrOtNIMapso3DSr8SW3isqP6fNydOl3m4h0Q/7UZ8 AeGwrgB3X4LfT/iOwaQPRh6FkRKafQ12tEpVpWo6HDwmpWLKbLZe5QZM9MPVKv0LYRKV goMkoUOfpHnoum1AZB12j/0hE0UuqjK1QZ1+uwiR3yHa+1gWOWp8TWwy/0wjQ2vvWLQ1 877XIoKksjxCq90OCakgHjjBNr12idfjSZ7xYfmtHT8Xp8Wur/bPX6gIMvHUHwURUZIp qRx8f5mRj8QFRp3/kb5ae9rYVfl26Itv3sKSClZU3UdybDfezerScMxvKlVcdvEF9EFT bixQ== X-Gm-Message-State: AOJu0Yx1Nab+hSRRxmU04C4m+pPuDumNYrKnTkJlrt2qTRelxFGolUkF pZBqDyqnByU/JTna6iPhA0zFOzigsVCH4SQKnlIoKO7XnTeYQLB09x4jkPaVXUTRTw5xhWyxYZA YKoBGwdWY0a084S9HrPqtz1XdeWQqobppuqDr+x8LS3vQgeC+gFsRmQlj9RULZSPzeAH9M4ww5b 07c51trnVYLGOTpsYilEdjCp3UHHY/0youQu5B6+b3iTudAYRNMixNP8TF+VUAbnxBxNA= X-Google-Smtp-Source: AGHT+IEXa+QnTPnVNgHoaewOLlIH8wFAnb+M/ihAEAGqYML1uHaPbaA1TFQ+R1PS5raQE1UTHGA6cnlOKUra43n49A== X-Received: from dionnaglaze.c.googlers.com ([fda3:e722:ac3:cc00:36:e7b8:ac13:c9e8]) (user=dionnaglaze job=sendgmr) by 2002:a17:90b:616:b0:2e2:af52:a7c3 with SMTP id 98e67ed59e1d1-2e92cf4f915mr20243a91.8.1730484953636; Fri, 01 Nov 2024 11:15:53 -0700 (PDT) Date: Fri, 1 Nov 2024 18:15:29 +0000 In-Reply-To: <20241101181533.1976040-1-dionnaglaze@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241101181533.1976040-1-dionnaglaze@google.com> X-Mailer: git-send-email 2.47.0.163.g1226f6d8fa-goog Message-ID: <20241101181533.1976040-5-dionnaglaze@google.com> Subject: [PATCH v2 4/4] KVM: SVM: Delay legacy platform initialization on SNP From: Dionna Glaze To: linux-kernel@vger.kernel.org, x86@kernel.org, Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" Cc: Dionna Glaze , Ashish Kalra , Tom Lendacky , John Allen , Herbert Xu , "David S. Miller" , Michael Roth , Luis Chamberlain , Russ Weight , Danilo Krummrich , Greg Kroah-Hartman , "Rafael J. Wysocki" , Tianfei zhang , kvm@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When no SEV or SEV-ES guests are active, then the firmware can be updated while (SEV-SNP) VM guests are active. CC: Sean Christopherson CC: Paolo Bonzini CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: Ashish Kalra CC: Tom Lendacky CC: John Allen CC: Herbert Xu CC: "David S. Miller" CC: Michael Roth CC: Luis Chamberlain CC: Russ Weight CC: Danilo Krummrich CC: Greg Kroah-Hartman CC: "Rafael J. Wysocki" CC: Tianfei zhang Co-developed-by: Ashish Kalra Signed-off-by: Ashish Kalra Reviewed-by: Ashish Kalra Signed-off-by: Dionna Glaze --- arch/x86/kvm/svm/sev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kvm/svm/sev.c b/arch/x86/kvm/svm/sev.c index f6e96ec0a5caa..8d365e2e3c1b1 100644 --- a/arch/x86/kvm/svm/sev.c +++ b/arch/x86/kvm/svm/sev.c @@ -445,6 +445,8 @@ static int __sev_guest_init(struct kvm *kvm, struct kvm= _sev_cmd *argp, goto e_no_asid; =20 init_args.probe =3D false; + init_args.supports_download_firmware_ex =3D + vm_type !=3D KVM_X86_SEV_VM && vm_type !=3D KVM_X86_SEV_ES_VM; ret =3D sev_platform_init(&init_args); if (ret) goto e_free; --=20 2.47.0.163.g1226f6d8fa-goog