From nobody Mon Nov 25 02:54:23 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EAC71F131B; Wed, 30 Oct 2024 14:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; cv=none; b=SzECp12a28QbMTJaQqH1bCEb3HdmFFf2GJjPzLrIHnlF4tcMaNHaytlHKBkxsF3u3x08bnUk3/3SdGVD2ctAQeiQBsCkDLrvBoN63qgz/j/DqgSu39PX50foHmVcZfC3hjPlvQeEPOFk8R40EKjEL2dqcObYaD4jfRqrUiHrSMw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; c=relaxed/simple; bh=kB476cZ7Eg0szy7auuBRAuEbGXXnIMw0YbN/pQtaU6U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ReFrPoZDHofMetsSYB/tf0Ut7PpTGdzqAR/BTOgJGLpAgjUMihBbpbhQmLx1fNyzq+5W1f2m+INSK2T6tNPXXP9orCySyOz5bxLQrdLZDdMLOMOrPPwP9iu0BJvGdON0QC668H32H5xZvceS9otuBbp5pqJs3+a1qPRp2OgUemU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=Ovt9GcV9; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="Ovt9GcV9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730299696; bh=kB476cZ7Eg0szy7auuBRAuEbGXXnIMw0YbN/pQtaU6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ovt9GcV9QaTqKnynMnZ2/S0yBrVIPmFkwilYSADh3kOiXnZggV9M7kzZf9nwR7pTO u6uYEQhx/Pl44SlFKLXVwZhlI/b6A+SEHtd2dP9F3tiTwnSiwHhST6HPd7TYdF/5Ld FaJ+3Lkj/y3nz39yxNopR22aDNaOs+oUPo2KS7eBXz+QTWpnjYhGlHbOreM8d+L9GN R0rhqw4b+69Gwt9qnIVZnv+bjhgQEdGlL6Aj10k2OhmyM8I+cvII7bonwtgQeKWNZz IsTkIqxmHwdUfZp7JqhaFBUvL+3TRQ2BruwcivhQXtD0ggN8m1XShwflHFwVrC3v33 kApTAV/q/hQDQ== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Xdqk75rFfzL8N; Wed, 30 Oct 2024 10:48:15 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife Subject: [PATCH v5 1/4] tracing: Introduce tracepoint extended structure Date: Wed, 30 Oct 2024 10:46:31 -0400 Message-Id: <20241030144634.721630-2-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> References: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Shrink the struct tracepoint size from 80 bytes to 72 bytes on x86-64 by moving the (typically NULL) regfunc/unregfunc pointers to an extended structure. Tested-by: Jordan Rife Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- Changes since v4: - Add static to DEFINE_TRACE_FN. --- include/linux/tracepoint-defs.h | 8 ++++++-- include/linux/tracepoint.h | 19 +++++++++++++------ kernel/tracepoint.c | 9 ++++----- 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/include/linux/tracepoint-defs.h b/include/linux/tracepoint-def= s.h index 60a6e8314d4c..967c08d9da84 100644 --- a/include/linux/tracepoint-defs.h +++ b/include/linux/tracepoint-defs.h @@ -29,6 +29,11 @@ struct tracepoint_func { int prio; }; =20 +struct tracepoint_ext { + int (*regfunc)(void); + void (*unregfunc)(void); +}; + struct tracepoint { const char *name; /* Tracepoint name */ struct static_key_false key; @@ -36,9 +41,8 @@ struct tracepoint { void *static_call_tramp; void *iterator; void *probestub; - int (*regfunc)(void); - void (*unregfunc)(void); struct tracepoint_func __rcu *funcs; + struct tracepoint_ext *ext; }; =20 #ifdef CONFIG_HAVE_ARCH_PREL32_RELOCATIONS diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 0dc67fad706c..862ab49177a4 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -302,7 +302,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) * structures, so we create an array of pointers that will be used for ite= ration * on the tracepoints. */ -#define DEFINE_TRACE_FN(_name, _reg, _unreg, proto, args) \ +#define __DEFINE_TRACE_EXT(_name, _ext, proto, args) \ static const char __tpstrtab_##_name[] \ __section("__tracepoints_strings") =3D #_name; \ extern struct static_call_key STATIC_CALL_KEY(tp_func_##_name); \ @@ -316,9 +316,9 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) .static_call_tramp =3D STATIC_CALL_TRAMP_ADDR(tp_func_##_name), \ .iterator =3D &__traceiter_##_name, \ .probestub =3D &__probestub_##_name, \ - .regfunc =3D _reg, \ - .unregfunc =3D _unreg, \ - .funcs =3D NULL }; \ + .funcs =3D NULL, \ + .ext =3D _ext, \ + }; \ __TRACEPOINT_ENTRY(_name); \ int __traceiter_##_name(void *__data, proto) \ { \ @@ -341,8 +341,15 @@ static inline struct tracepoint *tracepoint_ptr_deref(= tracepoint_ptr_t *p) } \ DEFINE_STATIC_CALL(tp_func_##_name, __traceiter_##_name); =20 -#define DEFINE_TRACE(name, proto, args) \ - DEFINE_TRACE_FN(name, NULL, NULL, PARAMS(proto), PARAMS(args)); +#define DEFINE_TRACE_FN(_name, _reg, _unreg, _proto, _args) \ + static struct tracepoint_ext __tracepoint_ext_##_name =3D { \ + .regfunc =3D _reg, \ + .unregfunc =3D _unreg, \ + }; \ + __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); + +#define DEFINE_TRACE(_name, _proto, _args) \ + __DEFINE_TRACE_EXT(_name, NULL, PARAMS(_proto), PARAMS(_args)); =20 #define EXPORT_TRACEPOINT_SYMBOL_GPL(name) \ EXPORT_SYMBOL_GPL(__tracepoint_##name); \ diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 6474e2cf22c9..5658dc92f5b5 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -278,8 +278,8 @@ static int tracepoint_add_func(struct tracepoint *tp, struct tracepoint_func *old, *tp_funcs; int ret; =20 - if (tp->regfunc && !static_key_enabled(&tp->key)) { - ret =3D tp->regfunc(); + if (tp->ext && tp->ext->regfunc && !static_key_enabled(&tp->key)) { + ret =3D tp->ext->regfunc(); if (ret < 0) return ret; } @@ -362,9 +362,8 @@ static int tracepoint_remove_func(struct tracepoint *tp, switch (nr_func_state(tp_funcs)) { case TP_FUNC_0: /* 1->0 */ /* Removed last function */ - if (tp->unregfunc && static_key_enabled(&tp->key)) - tp->unregfunc(); - + if (tp->ext && tp->ext->unregfunc && static_key_enabled(&tp->key)) + tp->ext->unregfunc(); static_branch_disable(&tp->key); /* Set iterator static call */ tracepoint_update_call(tp, tp_funcs); --=20 2.39.5 From nobody Mon Nov 25 02:54:23 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2FF91F4277; Wed, 30 Oct 2024 14:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; cv=none; b=OTTi0Z06HkXRyTVJtdj34bjm8Dq8V2x24EIfKxz5aZnqd0e4ZbmB3s46QnQjLIlLhixJYkSOkCyTDPlqOR6CZFRuf/rG1OqnY7+XnAn0qTpNHUduA184wfOmd8vmDIqc9W3L8IfP+J8mZ+Iv8miSTP0oZvGf1rqAOLZjbKXz37c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; c=relaxed/simple; bh=VFazdOH+1YDO3SL0dfrwz0oYFjH6rcaam0qwzaFy1M4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=laxUomqtaZPwGvwFfSXws4mfc6sYLpZ49RkWlDTJqx1JORCRkCgNCvql20Jy7XIBuJrnhYMFALmt9Y1ZSe+uOwrhJJ6ZZ+SZtkWi7TjxN/3sOIdPmFQBYiP2z1trBdiUxo/nDAgxxvOK26KX8iJKq8QR1SUmYefP1VeylYCeU7M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=eBboh+uG; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="eBboh+uG" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730299696; bh=VFazdOH+1YDO3SL0dfrwz0oYFjH6rcaam0qwzaFy1M4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eBboh+uGPNm/Ma+qa2f6YKKYfNehUkTH0qpCJ4NDYB5u15pH22f+PpBPDoa7ymG7x qoGdCkValuNOEGGqz3p07WeONSUaVGxXoe4nd+PjWiauYc5tsfr6L6kBqQFVxDF2pL wE0KJCbcB+hWyowyzzQw021mk7nSRQNWCi8qM3Y3K318iKHtA0nb6n2wn6ivGEHzlC Jbk77Eb3pr3dUwcvtkXQO0NjfN+7sdhwqElXgbppt/u9xa/C82b90Z++RJT0tgTXAh iMNdTR60/EX2BGtVOrG6S9ajK30vP4DhZie7JElq+aLPV41US/PW1aL8zvTgUhe9jT t8ELgb5glnvgg== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Xdqk81VghzL8P; Wed, 30 Oct 2024 10:48:16 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife , Andrii Nakryiko Subject: [PATCH v5 2/4] tracing: Introduce tracepoint_is_faultable() Date: Wed, 30 Oct 2024 10:46:32 -0400 Message-Id: <20241030144634.721630-3-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> References: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Introduce a "faultable" flag within the extended structure to know whether a tracepoint needs rcu tasks trace grace period before reclaim. This can be queried using tracepoint_is_faultable(). Acked-by: Andrii Nakryiko Tested-by: Jordan Rife Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- Changes since v4: - Add static to DEFINE_TRACE_SYSCALL. --- include/linux/tracepoint-defs.h | 2 ++ include/linux/tracepoint.h | 24 ++++++++++++++++++++++++ include/trace/define_trace.h | 2 +- 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/include/linux/tracepoint-defs.h b/include/linux/tracepoint-def= s.h index 967c08d9da84..aebf0571c736 100644 --- a/include/linux/tracepoint-defs.h +++ b/include/linux/tracepoint-defs.h @@ -32,6 +32,8 @@ struct tracepoint_func { struct tracepoint_ext { int (*regfunc)(void); void (*unregfunc)(void); + /* Flags. */ + unsigned int faultable:1; }; =20 struct tracepoint { diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 862ab49177a4..906f3091d23d 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -104,6 +104,12 @@ void for_each_tracepoint_in_module(struct module *mod, * tracepoint_synchronize_unregister must be called between the last trace= point * probe unregistration and the end of module exit to make sure there is no * caller executing a probe when it is freed. + * + * An alternative is to use the following for batch reclaim associated + * with a given tracepoint: + * + * - tracepoint_is_faultable() =3D=3D false: call_rcu() + * - tracepoint_is_faultable() =3D=3D true: call_rcu_tasks_trace() */ #ifdef CONFIG_TRACEPOINTS static inline void tracepoint_synchronize_unregister(void) @@ -111,9 +117,17 @@ static inline void tracepoint_synchronize_unregister(v= oid) synchronize_rcu_tasks_trace(); synchronize_rcu(); } +static inline bool tracepoint_is_faultable(struct tracepoint *tp) +{ + return tp->ext && tp->ext->faultable; +} #else static inline void tracepoint_synchronize_unregister(void) { } +static inline bool tracepoint_is_faultable(struct tracepoint *tp) +{ + return false; +} #endif =20 #ifdef CONFIG_HAVE_SYSCALL_TRACEPOINTS @@ -345,6 +359,15 @@ static inline struct tracepoint *tracepoint_ptr_deref(= tracepoint_ptr_t *p) static struct tracepoint_ext __tracepoint_ext_##_name =3D { \ .regfunc =3D _reg, \ .unregfunc =3D _unreg, \ + .faultable =3D false, \ + }; \ + __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); + +#define DEFINE_TRACE_SYSCALL(_name, _reg, _unreg, _proto, _args) \ + static struct tracepoint_ext __tracepoint_ext_##_name =3D { \ + .regfunc =3D _reg, \ + .unregfunc =3D _unreg, \ + .faultable =3D true, \ }; \ __DEFINE_TRACE_EXT(_name, &__tracepoint_ext_##_name, PARAMS(_proto), PARA= MS(_args)); =20 @@ -389,6 +412,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) #define __DECLARE_TRACE_SYSCALL __DECLARE_TRACE =20 #define DEFINE_TRACE_FN(name, reg, unreg, proto, args) +#define DEFINE_TRACE_SYSCALL(name, reg, unreg, proto, args) #define DEFINE_TRACE(name, proto, args) #define EXPORT_TRACEPOINT_SYMBOL_GPL(name) #define EXPORT_TRACEPOINT_SYMBOL(name) diff --git a/include/trace/define_trace.h b/include/trace/define_trace.h index ff5fa17a6259..63fea2218afa 100644 --- a/include/trace/define_trace.h +++ b/include/trace/define_trace.h @@ -48,7 +48,7 @@ =20 #undef TRACE_EVENT_SYSCALL #define TRACE_EVENT_SYSCALL(name, proto, args, struct, assign, print, reg,= unreg) \ - DEFINE_TRACE_FN(name, reg, unreg, PARAMS(proto), PARAMS(args)) + DEFINE_TRACE_SYSCALL(name, reg, unreg, PARAMS(proto), PARAMS(args)) =20 #undef TRACE_EVENT_NOP #define TRACE_EVENT_NOP(name, proto, args, struct, assign, print) --=20 2.39.5 From nobody Mon Nov 25 02:54:23 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B2F9F1F131C; Wed, 30 Oct 2024 14:48:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; cv=none; b=ZmcKm3YdklM0oO7T/NXPM0mje+Zz9oNjEitEijGYERN3tQ7DNGXuhb86bk9VjXhW6dmaz5GjnKbafpFI1Ka/0ome89i06nRSmc1UiY2xNoWQi8Qo6Bhl/TX1W4CwmWKQwKPsWrqTI56KQZY2L193jLE+m/9GAbQXud5g5F21ou8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; c=relaxed/simple; bh=1JEthXtzxz6eAsr1v+U00Vn7zL7CFulinbZM6JAJ/10=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=CQ4V6zMFHviHg1I3r/qDm/Lr6ovN9moTFMCSl1EwS2aEZ6clW44SdjLu4mws6ky33yLtfmMKPzBTyFFUraOyL4w5hzx8W6OVMC2UPR4eFJ1oxgu94EzXl/fWbxZWbxdVCmsu5eYqHOXTN7iKXJlA/COZKeOFfdk/jtz5X4LrRgY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=lWvssXgc; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="lWvssXgc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730299696; bh=1JEthXtzxz6eAsr1v+U00Vn7zL7CFulinbZM6JAJ/10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lWvssXgc2LWJz4g0DqaUvIRnRsuc4aQ45HyV4oDyrxwl28721qb0f6anJciZB7yQR fpzWSI6F1dxK7XQ20YhApIj/ncXPdEmKm6wxc4kStNCgYMPBPl3NJBhvWNoS7E5J0t 1e3mL/lEO7R0wH1h1dgpsQK/sFb0lnciN1tK7ML4FkBviCm2mXFoV2Yv/r1/RXIBIT IxorV+W1lgwcOGLoOjAqLuIMwogFIVqRElTNAFOlZjnO0PxJmYnzOZLBL2dvjEliyp 07Cimiu+9ZCwCs1UwZ8AnBZD4cd5LSmhlNiNsb/c9FaybPqstfxx4/WrFhYpoSfF3M yBhBmzB6RcKqg== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Xdqk84JyLzL8Q; Wed, 30 Oct 2024 10:48:16 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife , syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com Subject: [PATCH v5 3/4] tracing: Fix syscall tracepoint use-after-free Date: Wed, 30 Oct 2024 10:46:33 -0400 Message-Id: <20241030144634.721630-4-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> References: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The grace period used internally within tracepoint.c:release_probes() uses call_rcu() to batch waiting for quiescence of old probe arrays, rather than using the tracepoint_synchronize_unregister() which blocks while waiting for quiescence. With the introduction of faultable syscall tracepoints, this causes use-after-free issues reproduced with syzkaller. Fix this by using the appropriate call_rcu() or call_rcu_tasks_trace() before invoking the rcu_free_old_probes callback. This can be chosen using the tracepoint_is_faultable() API. A similar issue exists in bpf use of call_rcu(). Fixing this is left to a separate change. Reported-by: syzbot+b390c8062d8387b6272a@syzkaller.appspotmail.com Fixes: a363d27cdbc2 ("tracing: Allow system call tracepoints to handle page= faults") Tested-by: Jordan Rife Signed-off-by: Mathieu Desnoyers Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- Changes since v0: - Introduce tracepoint_call_rcu(), - Fix bpf_link_free() use of call_rcu as well. Changes since v1: - Use tracepoint_call_rcu() for bpf_prog_put as well. Changes since v2: - Do not cover bpf changes in the same commit, let bpf developers implement it. Changes since v3: - Use tracepoint_is_faultable(). --- kernel/tracepoint.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/kernel/tracepoint.c b/kernel/tracepoint.c index 5658dc92f5b5..1848ce7e2976 100644 --- a/kernel/tracepoint.c +++ b/kernel/tracepoint.c @@ -106,13 +106,16 @@ static void rcu_free_old_probes(struct rcu_head *head) kfree(container_of(head, struct tp_probes, rcu)); } =20 -static inline void release_probes(struct tracepoint_func *old) +static inline void release_probes(struct tracepoint *tp, struct tracepoint= _func *old) { if (old) { struct tp_probes *tp_probes =3D container_of(old, struct tp_probes, probes[0]); =20 - call_rcu(&tp_probes->rcu, rcu_free_old_probes); + if (tracepoint_is_faultable(tp)) + call_rcu_tasks_trace(&tp_probes->rcu, rcu_free_old_probes); + else + call_rcu(&tp_probes->rcu, rcu_free_old_probes); } } =20 @@ -334,7 +337,7 @@ static int tracepoint_add_func(struct tracepoint *tp, break; } =20 - release_probes(old); + release_probes(tp, old); return 0; } =20 @@ -405,7 +408,7 @@ static int tracepoint_remove_func(struct tracepoint *tp, WARN_ON_ONCE(1); break; } - release_probes(old); + release_probes(tp, old); return 0; } =20 --=20 2.39.5 From nobody Mon Nov 25 02:54:23 2024 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50FE61F427F; Wed, 30 Oct 2024 14:48:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; cv=none; b=mmtDhJbvSAydyOwA0ZffmaL7DNGisj23qIeiSuuPgKHGWneUd/VVdMtCBQTY0jwC+1CXGeGBS2BDhbSOx4RXOGeKxAt5hwQHU/+fuSYWlO2quSyNIKnvp5mc8WQzi8wv1GWW6bStdqMClsWkiUUp0/d6V+Ex5FYAYwmmAl0FKzo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730299700; c=relaxed/simple; bh=fZ4aXsvx9pf6rtAgOnrIQ2yOSxwJ5B0XGke7hbnZHrA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F4sa2RB/LK2RIACZQzhgwiHU71PW43L2qfS8mPpCUZ6q0/ghn0Q5rD+FWN5ZBFIUMN7RbfVDVznavFOWmKjUsF+8edBOZdBrU7XVOLMVVzT9EcbFZtv7QB4otGh/asB9F2YTVK9KYD9CMzuqwmbLHvbbQJDe1YaEdc+14sWKv3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=X1xVI4KX; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="X1xVI4KX" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1730299697; bh=fZ4aXsvx9pf6rtAgOnrIQ2yOSxwJ5B0XGke7hbnZHrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=X1xVI4KXD5WGCrUqrtHtzsSmRw7bZlyK/DVPDejOoaFqVc6mjCyIHq2l2rhQ9JMx2 ikYEPrdOpApryDWpVMrlFApAbudYJWmgvY8CIWF905Hl63o+m7guPatxoPDzT1DXLp nikxWQkGqfRx4zIOuSV2anayN3TjnePiTAZPOYo/9W5R5tgnJHvrcPEpfl3uJ1O2yv 2Z9WWSD38e1VWpUvkn5TJJmZ9IO0Q2upOtnF2/PnuO7LIsmMtndehfYOHa/y0n1MSV ZOKtM6IFBMOclefZXb7kMooK7n5AJG+CZlpPj5mdLM9Qhj463zr6KaOgVSTWdLDfs9 VuYnP28by7IiA== Received: from thinkos.internal.efficios.com (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Xdqk86zmpzL6D; Wed, 30 Oct 2024 10:48:16 -0400 (EDT) From: Mathieu Desnoyers To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Mathieu Desnoyers , Thomas Gleixner , Michael Jeanson , Masami Hiramatsu , Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Namhyung Kim , Andrii Nakryiko , bpf@vger.kernel.org, Joel Fernandes , Jordan Rife Subject: [PATCH v5 4/4] tracing: Add might_fault() check in __DECLARE_TRACE_SYSCALL Date: Wed, 30 Oct 2024 10:46:34 -0400 Message-Id: <20241030144634.721630-5-mathieu.desnoyers@efficios.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> References: <20241030144634.721630-1-mathieu.desnoyers@efficios.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Catch incorrect use of syscall tracepoints even if no probes are registered by adding a might_fault() check in trace_##name() emitted by __DECLARE_TRACE_SYSCALL. Suggested-by: Thomas Gleixner Tested-by: Jordan Rife Signed-off-by: Mathieu Desnoyers Cc: Thomas Gleixner Cc: Michael Jeanson Cc: Steven Rostedt Cc: Masami Hiramatsu Cc: Peter Zijlstra Cc: Alexei Starovoitov Cc: Yonghong Song Cc: Paul E. McKenney Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Mark Rutland Cc: Alexander Shishkin Cc: Namhyung Kim Cc: Andrii Nakryiko Cc: bpf@vger.kernel.org Cc: Joel Fernandes Cc: Jordan Rife --- Changes since v4: - Move might_fault() to trace_##name() emitted by __DECLARE_TRACE_SYSCALL so it is validated even when the tracepoint is disabled. --- include/linux/tracepoint.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h index 906f3091d23d..425123e921ac 100644 --- a/include/linux/tracepoint.h +++ b/include/linux/tracepoint.h @@ -301,6 +301,7 @@ static inline struct tracepoint *tracepoint_ptr_deref(t= racepoint_ptr_t *p) __DECLARE_TRACE_COMMON(name, PARAMS(proto), PARAMS(args), cond, PARAMS(da= ta_proto)) \ static inline void trace_##name(proto) \ { \ + might_fault(); \ if (static_branch_unlikely(&__tracepoint_##name.key)) \ __DO_TRACE(name, \ TP_ARGS(args), \ --=20 2.39.5